GitLab

This patch fixes two excessive marking of line box dirtiness
in NGInlineNode::MarkLineBoxesDirty().

1. LayoutObject::InsertedIntoTree() marks dirty, even if it
   will be dirtied again later in NGInlineNode::
   MarkLineBoxesDirty(). Fixed LayoutNGMixin<Base>::
   DirtyLinesFromChangedChild() to do only if it was in NG
   inline formatting context.
2. It may dirty the first line box because it clears
   LayoutObject::FirstInlineFragment as it traverses in pre-
   order, but NGPaintFragment::DirtyLinesFromChangedChild()
   needs FirstInlineFragment of its previous siblings.
   Changed to keep previous fragment in this loop.

blink_perf.layout does not show observable improvements, but
loading.desktop shows ~3% improvements.

Bug: 636993
Change-Id: Ia0706bb2407427b3e4ed093290646eb21bc5c0f3
Reviewed-on: https://chromium-review.googlesource.com/c/1309388
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604835}

This patch changes HotModeSpellCheckRequester to use uncanonical versions
of PreviousWordPosition and EndOfWord to reduce usage of VisiblePosition.

Bug: 657237
Change-Id: I26428ede826bc63ee76af02ace14a8bf43d69e25
Reviewed-on: https://chromium-review.googlesource.com/c/1313839Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604834}

Currently, optimization hints are fetched only when data saver pref is
set. This can be done by going to data saver setting or by
installing the extension on the desktop.

This CL additionally checks if data saver is enabled via command
line switch. This makes it simpler to test hints on Linux without
having to install the extension.

This is not really a user-facing change since users are not expected
to turn data saver via that switch.

Bug: 878131
Change-Id: I4f728a3e9bbfe30119257ff43c8eeb52b211732d
TBR: dougarnett@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1313274
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604833}

This patch exposes noncanonical versions of Previous/NextWordPosition to
reduce usage of VisiblePosition.

Bug: 657237
Change-Id: I0815b0c0bf4de34427432ca8f6aa769c356c6385
Reviewed-on: https://chromium-review.googlesource.com/c/1313876Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604832}

Implementation for chrome.tabs.goBack and chrome.tabs.goForward
Above APIs provide a reliable way to trigger a navigate-back/forward
action like back/forward button on toolbar.

Bug: 830622
Change-Id: I1f5e8d5e4768161f43b2df1621a03a6cc3383b4f
Reviewed-on: https://chromium-review.googlesource.com/c/1274225Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604831}

This patch stops passing VisiblePosition to the functions, and hoists
creation of VisiblePosition to the callers, to decrease the usage of
VisiblePosition.

Bug: 657237
Change-Id: I52a6a34e240aa0180d2459c262b2db919fab4674
Reviewed-on: https://chromium-review.googlesource.com/c/1309568Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Cr-Commit-Position: refs/heads/master@{#604830}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=abdulsyed@chromiue.org

Change-Id: Id8d03ff031991eeea8a2d4069332adb17b6ae869
Reviewed-on: https://chromium-review.googlesource.com/c/1314148Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604829}

https://google.github.io/styleguide/cppguide.html#Namespace_Names
> Namespace names are all lower-case.

This CL has no behavior changes.

Bug: 889726
Change-Id: I8724b84354fda40bcaa90a7d90a82c563fb11698
Reviewed-on: https://chromium-review.googlesource.com/c/1312151Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Cr-Commit-Position: refs/heads/master@{#604828}

This change fixes a number of issues with sending bulk and interrupt
transfers to a USB device using the new Windows backend.

* Posting completion callbacks to the proper thread (a requirement for
  DevTools) has been fixed.
* Overlapped I/O results are now read using the correct method
  (WinUsb_GetOverlappedResult) and from the correct handle.
* Aborting transfers on handle close no longer results in a double-free.

Bug: 637404
Change-Id: I4fdb254e4ea6e9cbf7d764f588c94d698d61cb02
Reviewed-on: https://chromium-review.googlesource.com/c/1313828
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604827}

It adds X11ScreenOzone for PlatformScreen which has basic
implementation.

When it creates PlatformScreen for Ozone/X11, X11ScreenOzone
is created and it creates X11DisplayFetcherOzone, which
communicates with 'x11::xrandr'. The way to get display
information in X11DisplayFetcherOzone is similar to
DesktopScreenX11. Once it builds display information from
'x11::xrandr', it adds the information to display list from
X11ScreenOzone.

This patch also moves 'GetICCProfileForMonitor' to x11_util.cc
to share it with X11ScreenOzone.

Bug: 891175
Test: ozone_x11_unittests
Change-Id: I2d901f72ca2d9609ef19eef7da35bf99aec62d2a
Reviewed-on: https://chromium-review.googlesource.com/c/1293290Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#604826}

https://chromium.googlesource.com/catapult.git/+log/b281d52b301d..971689c0597c


git log b281d52b301d..971689c0597c --date=short --no-merges --format='%ad %ae %s'
2018-11-01 bpastene@chromium.org Revert "ADB commands should only retry errors, not exceptions."


Created with:
  gclient setdep -r src/third_party/catapult@971689c0597c

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:895027
TBR=sullivan@chromium.org

Change-Id: I805d1b998211fe410ea719e9a3486f8f90dc61ae
Reviewed-on: https://chromium-review.googlesource.com/c/1313689Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604825}

Bug: 829414
Change-Id: Ib6b84bcac405deda514b76c426b14f19888687a3
Reviewed-on: https://chromium-review.googlesource.com/c/1311655Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604824}

During browser startup, registering a service worker can be slow (in
order of a few seconds). We currently register SW based extension's
script on every extension activation (when we load extensions),
which isn't necessary as SW registrations are suppose to persist
across browser restart by design.

Add a pref to remember the fact that we have successfully registered
an extension's background SW script for a particular version of
that extension and use that to decide whether or not to register
the SW during OnActivateExtension.

This CL will improve SW based extension's startup time.

Bug: 889687
Test: Demo browser clock extension doesn't lag much with the change (note that this is requires local modification to chromium, specifically Patchset #2)
Change-Id: Icfb7174be27f65a1cb6b8ac6d99ddc6b33fdf1c0
Reviewed-on: https://chromium-review.googlesource.com/c/1265821
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604823}

Change-Id: I36f9dc912bd90e8ea4c5726089b70d76dba0d6e9
Reviewed-on: https://chromium-review.googlesource.com/c/1311927
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604822}

https://pdfium.googlesource.com/pdfium.git/+log/dd8eb5ae7bcc..86e5fbf71b88


git log dd8eb5ae7bcc..86e5fbf71b88 --date=short --no-merges --format='%ad %ae %s'
2018-11-01 tsepez@chromium.org Move Non-JS date functions to fx_date_helpers.cpp


Created with:
  gclient setdep -r src/third_party/pdfium@86e5fbf71b88

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I494fb3ce687a4b8d32b0344724a9a209c75b52f2
Reviewed-on: https://chromium-review.googlesource.com/c/1313296Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604821}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/73b23f5ede8f..da627bb2e1dc


Created with:
  gclient setdep -r src-internal@da627bb2e1dc

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Id486fa305563fb93b88f25fe06e02027fa2cb7d1
Reviewed-on: https://chromium-review.googlesource.com/c/1313293Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604820}

This is a logical revert of "Use preferred language in extension i18n"
(commit 693d01a6). Because of some
intervening changes causing more complicated merges, it's simpler to
just undo the side effects of the original change, leaving the changed
boilerplate intact.

Reason for revert: Testing perf regression in crbug.com/898191

If this exonerates the original CL, we will revert this change.
Otherwise, we will clean up the boilerplate added for the original CL.

Original change's description:
> Use preferred language in extension i18n
>
> When localizing an extension, prioritize the user's preferred language
> over the application locale.
>
> Normally, these are the same. In some cases, they differ. For example,
> the user may choose to display Chrome in "en-CA" (the intl.app_locale
> pref), but because we don't have translations for that, the actual
> UI locale is "en-GB".
>
> This CL makes extensions try to use the user's preferred locale for i18n
> ("en_CA"), falling back to the UI locale ("en_GB") if no locale
> directory is found for the preferred locale.
>
> This change also updates the "current_locale" manifest key to reflect
> the user's preferred locale, or the UI locale if intl.app_locale is
> unset.
>
> Note: Like the application locale, the preferred locale is only set at
> startup (and in certain situations in CrOS). If the user changes their
> intl.app_locale pref, they have to restart Chrome before extensions are
> re-localized, just like before.
>
> Bug: 874225
> Change-Id: I1aabe3c3680b77d6522193e764aec15a3d618d2d
> Reviewed-on: https://chromium-review.googlesource.com/c/1244666
> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600619}

Bug: 898191
Change-Id: Iaddceb16d61ffc5572a25ed31276443ea5b5baa4
Reviewed-on: https://chromium-review.googlesource.com/c/1308765Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604819}

https://skia.googlesource.com/skia.git/+log/6c3879dcec38..94d7af7bcc96


git log 6c3879dcec38..94d7af7bcc96 --date=short --no-merges --format='%ad %ae %s'
2018-11-01 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-11-01 herb@google.com Revert "Remove the unused buffers for unique glyph handling"
2018-11-01 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 75889d00033b..a23184454e9c (1 commits)


Created with:
  gclient setdep -r src/third_party/skia@94d7af7bcc96

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=herb@chromium.org

Change-Id: Ic5e9b7a8d262ad5e9f180e2a915c7f23109f3ab8
Reviewed-on: https://chromium-review.googlesource.com/c/1313691Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604818}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8f8a50d00a8b..fec80c41355c


git log 8f8a50d00a8b..fec80c41355c --date=short --no-merges --format='%ad %ae %s'
2018-11-01 ehmaldonado@chromium.org git-cl: Report git push information to metrics collection.


Created with:
  gclient setdep -r src/third_party/depot_tools@fec80c41355c

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:897394
TBR=agable@chromium.org

Change-Id: Ie1478e08383e456d754435c88cad4c980afcbb4f
Reviewed-on: https://chromium-review.googlesource.com/c/1313295Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604817}

In addition to being somewhat silly and inefficient, this also made it
impossible to check whether these things need to be removed on destruction
(because it would add a reference to a doomed object).

Bug: 856641
Change-Id: Ia017304cddbc417a5fce5350de6726471aff930f
Reviewed-on: https://chromium-review.googlesource.com/c/1312571Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604816}

This is a follow up to the content-side change, we need chrome
to respect these overrides as well when the check originates
outside of the web platform.

Bug: 631464
Change-Id: I8300a17d6b2b65140aef8232a58a694e56a709e3
Reviewed-on: https://chromium-review.googlesource.com/c/1308935
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604815}

https://chromium.googlesource.com/angle/angle.git/+log/2197dc529052..502d2e215556


git log 2197dc529052..502d2e215556 --date=short --no-merges --format='%ad %ae %s'
2018-11-01 jmadill@chromium.org Vulkan: Crunch RenderPassDesc.


Created with:
  gclient setdep -r src/third_party/angle@502d2e215556

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: Ia275637aa1efcadf797eefe58cd0930916010cf7
Reviewed-on: https://chromium-review.googlesource.com/c/1313766Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604814}

If a download is getting no response while it completes, it shouldn't carry
the DOWNLOAD_INTERRUPT_REASON_NONE reason.
Otherwise, it will fail the DCHECK in InProgressDownloadManager::StartDownload().
This CL fixes the issue by adding the NETWORK_FAILED reason to the download.

BUG=900149

Change-Id: Ic068691f8bc5146fba92e75894eec74ce5c54bc8
Reviewed-on: https://chromium-review.googlesource.com/c/1308672Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604813}

No behaviour change.
This CL clarifies which HTTP methods are actually in the allowed set.

Bug: 803774
Change-Id: Ie787a72c2600b96e97aa8540826b5adf63894715
Reviewed-on: https://chromium-review.googlesource.com/c/1313809
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604812}

Enables Frame clients to inject arbitrary JS into browser frames,
so that Fuchsia native applications may interact with web content.

* Define and implement ScriptInjector Mojo service for RenderFrames.
* Rename AllowInjectingJavaScriptForAndroidWebView() to AllowInjectingJavaScript(),
to reflect the fact that this feature is no longer exclusive to Android.

Bug: 893236
Change-Id: I25b7364db21662af8a763e0788ddb3719d91328a
Reviewed-on: https://chromium-review.googlesource.com/c/1295173
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604811}

This reverts commit be707070.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 604801 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2JlNzA3MDcwZjA4YzQ1ZGFmM2QxYmI5ZTc0OWRjM2JkZjM2MzYwOTIM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium/win-rel/5462

Sample Failed Step: compile

Original change's description:
> Roll src/third_party/googletest/src/ 2e68926a9..879ac092f (182 commits)
> 
> https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/2e68926a9d49..879ac092fde0
> 
> $ git log 2e68926a9..879ac092f --date=short --no-merges --format='%ad %ae %s'
> 2018-10-31 jerryturcios08 Correct grammatical error in README.md
> 2018-10-30 absl-team Googletest export
> 2018-10-30 misterg Googletest export
> 2018-10-29 absl-team Googletest export
> 2018-10-29 akonradi Add Optional() to the cheat sheet doc.
> 2018-10-29 misterg Googletest export
> 2018-10-29 misterg Googletest export
> 2018-10-28 vbrkov Replaced all NULLs with nullptr in googlemock
> 2018-10-28 vbrkov Replaced all NULLs with nullptr in googletest
> 2018-10-26 absl-team Googletest export
> 2018-10-24 absl-team Googletest export
> 2018-10-24 misterg Googletest export
> 2018-10-24 jeffvd.a216 Change CMake googletest download location in docs
> 2018-10-23 durandal Googletest export
> 2018-10-24 peter_jiachen Disable extensions and force standard
> 2018-10-24 peter_jiachen Revert previous changes
> 2018-10-24 peter_jiachen Fix -std=c++11 flag
> 2018-10-23 joelanderson333 add documentation of manual c++11 specification
> 2018-10-23 gennadiycivil Update advanced.md
> 2018-10-23 gennadiycivil Update advanced.md
> 2018-10-23 gennadiycivil Update advanced.md
> 2018-10-23 svg153 ACTION table format
> 2018-10-22 absl-team Googletest export
> 2018-10-19 gennadiycivil Update .travis.yml
> 2018-10-18 gennadiycivil Update .travis.yml
> 2018-10-18 misterg Googletest export
> 2018-10-16 absl-team Googletest export
> 2018-10-17 kakkoko Fix incorrect XML file name in help message
> 2018-10-16 jonathan.wendeborn Removed last reference to internal::kDefault
> 2018-10-16 jonathan.wendeborn Use existing Mock::GetReactionOnUninterestingCalls()
> 2018-10-16 jonathan.wendeborn Don't fully qualify enum member
> 2018-10-16 jonathan.wendeborn Added Mock::IsNaggy, IsNice, and IsStrict
> 2018-10-12 robert Change types to remove cast warnings.
> 2018-10-11 misterg Remove duplicate functionality PrintValue (in googletest-param-test-test.cc), use testing::PrintToString
> 2018-10-11 komh Merge c41b2bf861ef2ac1a975af05ff66d9256f280b01 into f203b2db77161fe54846ea9e839ebec81aeeccac
> 2018-10-11 dneto Merge 4c92120d6dedb4eeb499a8702faea0224e0a8b23 into 658c6390a5b363f46c6ad448ad1bce9d6e97e53a
> 2018-10-11 aarond Merge 41fc9745d4a448db7d932250d22fac1dda287443 into 658c6390a5b363f46c6ad448ad1bce9d6e97e53a
> 2018-10-09 absl-team Project import generated by Copybara.
> 2018-10-09 misterg Internal Change
> 2018-10-11 filipp.andjelo Use pcfiledir for prefix in pkgconfig file
> 2018-10-06 ryee88 fix typo
> 2018-10-10 spartucus Update .gitignore
> 2018-10-09 misterg Remove non-variadic pre C++11 AnyOf
> 2018-10-09 absl-team Unconditionally use std::tuple. Remove all mention of TR1 tuple and our own implementation of tuple.
> 2018-10-09 misterg Remove testing::internal::BothOfMatcher, no longer needed
> 2018-10-09 absl-team Apply [[noreturn]] to Abort()
> 2018-10-09 gennadiycivil Update Makefile.am
> 2018-10-09 gennadiycivil Update BUILD.bazel
> 2018-10-09 gennadiycivil Update README.md
> 2018-10-09 gennadiycivil Delete CHANGES
> 2018-10-09 gennadiycivil Delete CHANGES
> 2018-10-08 kuroiwa Merge c1170881039e859738c62b02a918116fc6d346bc into 27c86f29417e53a622a2902baab2d1d82dafc5f9
> 2018-10-08 misterg Fixing AllOfMatches test, where it properly belongs
> 2018-10-08 misterg always define define GTEST_LANG_CXX11 1
> 2018-10-08 misterg Remove non-variadic pre C++11 AllOf
> 2018-10-05 gennadiycivil Update primer.md
> 2018-10-05 misterg Remove pre-C++11 code from gtest-printers
> 2018-10-05 absl-team Make GTestColor and ColoredPrintF available as internal APIs from gtest.h.  This is for use in abseil exception safety testing.
> 2018-10-05 misterg Removed pre-C++11 IsContainerTest and IteratorTraits
> 2018-10-04 absl-team Apply clang-tidy modernize-use-nullptr to googletest.
> 2018-10-04 misterg Remove checking for C++ 11 and a pre-C++11 test from googletest tests
> 2018-10-03 theonetruecamper Merge d830440d48a9502161448bc78be33a53388dd1f4 into f5260ae757a681566d8f7d0558b8dc0551036506
> 2018-10-02 jerryturcios08 Remove compilation option for C++11 in the root CMakeLists.txt
> 2018-10-02 mateo.longo Merge c798e39a4f96f5a985126cc3fab4738b6412cfc1 into e93da23920e5b6887d6a6a291c3a59f83f5b579e
> 2018-10-02 jerryturcios08 Add compilation option for C++11 in the root CMakeLists.txt
> 2018-10-02 gennadiycivil Merge 68b8a4c60cd80c78e1875b77807fa13cdd2313f8 into 77962730563eece3525f40b8769e4ca0c6baf64c
> 2018-10-02 30830880+marbub Merge 86fe8a25eb5a6e4546f9e39cf23a5c764217bf85 into 440527a61e1c91188195f7de212c63c77e8f0a45
> 2018-10-01 arseny.aprelev Merge 2ce0685f76a4db403b7b2650433a584c150f2108 into 75e834700d19aa373b428c7c746f951737354c28
> 2018-10-01 misterg Googletest export
> 2018-09-27 durandal Googletest export
> 2018-09-30 jerryturcios08 Add a cached variable to CMAKE_CXX_STANDARD
> 2018-09-28 jerryturcios08 Add C++11 support in the root CMakeLists.txt
> 2018-09-26 gennadiycivil Update appveyor.yml
> 2018-09-25 gennadiycivil Revert "[mingw] enable the unittests for gmock and gtest again"
> 2018-09-25 gennadiycivil Keep one MinGW build, remove the others
> 2018-09-25 gennadiycivil Update appveyor.yml
> 2018-09-25 gennadiycivil Update appveyor.yml
> 2018-09-25 gennadiycivil Delete m4_ax_cxx_compile_stdcxx_11.m4
> 2018-09-25 gennadiycivil Delete m4_ax_cxx_compile_stdcxx.m4
> 2018-09-25 gennadiycivil Update configure.ac
> 2018-09-25 gennadiycivil Update Makefile.am
> 2018-09-25 gennadiycivil Update .travis.yml
> 2018-09-25 misterg automake
> 2018-09-25 misterg test automake c++11
> 2018-09-25 gennadiycivil Update configure.ac
> 2018-09-25 gennadiycivil Update configure.ac
> 2018-09-25 misterg typo
> 2018-09-25 misterg autotools c++11
> 2018-09-25 misterg autotools c++11
> 2018-09-25 misterg test
> 2018-09-25 misterg include c++11 for autotools
> 2018-09-25 absl-team Googletest export
> 2018-09-25 gennadiycivil Revert "Add clang format check to one of the builds"
> 2018-09-25 misterg Googletest export
> 2018-09-24 misterg Googletest export
> 2018-09-20 absl-team Googletest export
> 2018-09-25 misterg enable MingW on PR
> 2018-09-25 misterg C++11 autotools build
> 2018-09-25 misterg adding c++11 to appveyor mingW
> 2018-09-25 misterg typo
> (...)
> 
> Created with:
>   roll-dep src/third_party/googletest/src
> 
> TBR=thakis@chromium.org
> 
> Bug: 893369
> Change-Id: Ic7e13ff5fd3952c4d71ab23166a5c36dcad86b99
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng
> Reviewed-on: https://chromium-review.googlesource.com/c/1310634
> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
> Reviewed-by: Victor Costan <pwnall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#604801}

Change-Id: I290509bb9d2e13791ce12f30846aa0703b85f5c0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 893369
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/c/1313882
Cr-Commit-Position: refs/heads/master@{#604810}

https://pdfium.googlesource.com/pdfium.git/+log/9b86cb69f2f2..dd8eb5ae7bcc


git log 9b86cb69f2f2..dd8eb5ae7bcc --date=short --no-merges --format='%ad %ae %s'
2018-11-01 thestig@chromium.org Use more constants in CPDF_FontEncoding.
2018-11-01 thestig@chromium.org Make MSSymbolEncoding table all hex.


Created with:
  gclient setdep -r src/third_party/pdfium@dd8eb5ae7bcc

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I7fb5f074daa20a2e32e5f10716b3f981b8c60df7
Reviewed-on: https://chromium-review.googlesource.com/c/1313281Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604809}

This CL has no behavior changes.

Bug: 732657
Change-Id: I2d543eb78ad5900c8ad0e160a839dbd13be66a09
Reviewed-on: https://chromium-review.googlesource.com/c/1312182Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Cr-Commit-Position: refs/heads/master@{#604808}

https://google.github.io/styleguide/cppguide.html#Namespace_Names
> Namespace names are all lower-case.

This CL has no behavior changes.

Bug: 889726
Change-Id: If8309ac44fb9177139998346fd5b8c56ee0ba4e4
Reviewed-on: https://chromium-review.googlesource.com/c/1312147Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Cr-Commit-Position: refs/heads/master@{#604807}

This moves the static factory methods for instantiating subclasses of
FidoDeviceDiscovery out of FidoDeviceDiscovery and into a new class called
FidoDiscoveryFactory. The ScopedFidoDeviceDiscoveryFactory is moved along with
it.

This will simplify changes that let us instantiate non-device authenticators
(Windows, Touch ID) through the existing factory methods. Also, instantiating
different kinds of FidoDiscovery is becoming complex enough that centralizing
this code in a single place, separate from any of the FidoDiscovery
implementations seems sensible.

Bug: 898718
Change-Id: I6c114c5aa9e8db4538a003108c4e7acec7100fbd
Reviewed-on: https://chromium-review.googlesource.com/c/1311841
Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604806}

An extension is granted activeTab permission when the user invokes it on
a certain site. Currently, this grants host permission to the extension
until the user performs a (not-same-document) navigation or closes the
tab.

With RuntimeHostPermissions, we apply a similar model to extensions with
withheld permissions, but make the permission grant "sticky" while the
user is on the same origin - that is, the permission is only revoked on
cross-origin navigation or tab close.

Apply this behavior to activeTab as well. There's not really an
increased security risk here, since the extension already has access to
the site. This also simplifies the code by reducing the differences
between activeTab and RuntimeHostPermissions.

Update tests for activeTab to reflect the new behavior, and update
public documentation to include the change.

Bug: 898617
Change-Id: I6772cf7d88ed53ceb4540e06adf33d5f17bbb4b0
Reviewed-on: https://chromium-review.googlesource.com/c/1298420Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604805}

Change-Id: If78728aac86b3108e6525cffcee0dfc6122db607
Reviewed-on: https://chromium-review.googlesource.com/c/1312180Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604804}

WebRTC will improve its IP handling with mDNS and replace private IP
addresses with mDNS hostnames when signaling ICE host candidates to the
application. See the Internet Draft (draft-mdns-ice-candidates-02) for
the detailed approach.

This CL defines a Mojo interface of mDNS responder and implements it as
a service that will be consumed by WebRTC.

Bug: 878465
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I4b644286467622b3dfdb728a9d5f3a4bde9fc1ec
Reviewed-on: https://chromium-review.googlesource.com/c/1182875Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Qingsi Wang <qingsi@google.com>
Cr-Commit-Position: refs/heads/master@{#604803}

Adding the annotation makes it clear which fields are protected by
base::Lock, and enables compile-time analysis to verify this.

BUG=893739,887645
TEST=compiles

Change-Id: Ibf8ff9b73f218fcd3cfeb4387e7ad406418ef522
Reviewed-on: https://chromium-review.googlesource.com/c/1303405Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604802}

https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/2e68926a9d49..879ac092fde0

$ git log 2e68926a9..879ac092f --date=short --no-merges --format='%ad %ae %s'
2018-10-31 jerryturcios08 Correct grammatical error in README.md
2018-10-30 absl-team Googletest export
2018-10-30 misterg Googletest export
2018-10-29 absl-team Googletest export
2018-10-29 akonradi Add Optional() to the cheat sheet doc.
2018-10-29 misterg Googletest export
2018-10-29 misterg Googletest export
2018-10-28 vbrkov Replaced all NULLs with nullptr in googlemock
2018-10-28 vbrkov Replaced all NULLs with nullptr in googletest
2018-10-26 absl-team Googletest export
2018-10-24 absl-team Googletest export
2018-10-24 misterg Googletest export
2018-10-24 jeffvd.a216 Change CMake googletest download location in docs
2018-10-23 durandal Googletest export
2018-10-24 peter_jiachen Disable extensions and force standard
2018-10-24 peter_jiachen Revert previous changes
2018-10-24 peter_jiachen Fix -std=c++11 flag
2018-10-23 joelanderson333 add documentation of manual c++11 specification
2018-10-23 gennadiycivil Update advanced.md
2018-10-23 gennadiycivil Update advanced.md
2018-10-23 gennadiycivil Update advanced.md
2018-10-23 svg153 ACTION table format
2018-10-22 absl-team Googletest export
2018-10-19 gennadiycivil Update .travis.yml
2018-10-18 gennadiycivil Update .travis.yml
2018-10-18 misterg Googletest export
2018-10-16 absl-team Googletest export
2018-10-17 kakkoko Fix incorrect XML file name in help message
2018-10-16 jonathan.wendeborn Removed last reference to internal::kDefault
2018-10-16 jonathan.wendeborn Use existing Mock::GetReactionOnUninterestingCalls()
2018-10-16 jonathan.wendeborn Don't fully qualify enum member
2018-10-16 jonathan.wendeborn Added Mock::IsNaggy, IsNice, and IsStrict
2018-10-12 robert Change types to remove cast warnings.
2018-10-11 misterg Remove duplicate functionality PrintValue (in googletest-param-test-test.cc), use testing::PrintToString
2018-10-11 komh Merge c41b2bf861ef2ac1a975af05ff66d9256f280b01 into f203b2db77161fe54846ea9e839ebec81aeeccac
2018-10-11 dneto Merge 4c92120d6dedb4eeb499a8702faea0224e0a8b23 into 658c6390a5b363f46c6ad448ad1bce9d6e97e53a
2018-10-11 aarond Merge 41fc9745d4a448db7d932250d22fac1dda287443 into 658c6390a5b363f46c6ad448ad1bce9d6e97e53a
2018-10-09 absl-team Project import generated by Copybara.
2018-10-09 misterg Internal Change
2018-10-11 filipp.andjelo Use pcfiledir for prefix in pkgconfig file
2018-10-06 ryee88 fix typo
2018-10-10 spartucus Update .gitignore
2018-10-09 misterg Remove non-variadic pre C++11 AnyOf
2018-10-09 absl-team Unconditionally use std::tuple. Remove all mention of TR1 tuple and our own implementation of tuple.
2018-10-09 misterg Remove testing::internal::BothOfMatcher, no longer needed
2018-10-09 absl-team Apply [[noreturn]] to Abort()
2018-10-09 gennadiycivil Update Makefile.am
2018-10-09 gennadiycivil Update BUILD.bazel
2018-10-09 gennadiycivil Update README.md
2018-10-09 gennadiycivil Delete CHANGES
2018-10-09 gennadiycivil Delete CHANGES
2018-10-08 kuroiwa Merge c1170881039e859738c62b02a918116fc6d346bc into 27c86f29417e53a622a2902baab2d1d82dafc5f9
2018-10-08 misterg Fixing AllOfMatches test, where it properly belongs
2018-10-08 misterg always define define GTEST_LANG_CXX11 1
2018-10-08 misterg Remove non-variadic pre C++11 AllOf
2018-10-05 gennadiycivil Update primer.md
2018-10-05 misterg Remove pre-C++11 code from gtest-printers
2018-10-05 absl-team Make GTestColor and ColoredPrintF available as internal APIs from gtest.h.  This is for use in abseil exception safety testing.
2018-10-05 misterg Removed pre-C++11 IsContainerTest and IteratorTraits
2018-10-04 absl-team Apply clang-tidy modernize-use-nullptr to googletest.
2018-10-04 misterg Remove checking for C++ 11 and a pre-C++11 test from googletest tests
2018-10-03 theonetruecamper Merge d830440d48a9502161448bc78be33a53388dd1f4 into f5260ae757a681566d8f7d0558b8dc0551036506
2018-10-02 jerryturcios08 Remove compilation option for C++11 in the root CMakeLists.txt
2018-10-02 mateo.longo Merge c798e39a4f96f5a985126cc3fab4738b6412cfc1 into e93da23920e5b6887d6a6a291c3a59f83f5b579e
2018-10-02 jerryturcios08 Add compilation option for C++11 in the root CMakeLists.txt
2018-10-02 gennadiycivil Merge 68b8a4c60cd80c78e1875b77807fa13cdd2313f8 into 77962730563eece3525f40b8769e4ca0c6baf64c
2018-10-02 30830880+marbub Merge 86fe8a25eb5a6e4546f9e39cf23a5c764217bf85 into 440527a61e1c91188195f7de212c63c77e8f0a45
2018-10-01 arseny.aprelev Merge 2ce0685f76a4db403b7b2650433a584c150f2108 into 75e834700d19aa373b428c7c746f951737354c28
2018-10-01 misterg Googletest export
2018-09-27 durandal Googletest export
2018-09-30 jerryturcios08 Add a cached variable to CMAKE_CXX_STANDARD
2018-09-28 jerryturcios08 Add C++11 support in the root CMakeLists.txt
2018-09-26 gennadiycivil Update appveyor.yml
2018-09-25 gennadiycivil Revert "[mingw] enable the unittests for gmock and gtest again"
2018-09-25 gennadiycivil Keep one MinGW build, remove the others
2018-09-25 gennadiycivil Update appveyor.yml
2018-09-25 gennadiycivil Update appveyor.yml
2018-09-25 gennadiycivil Delete m4_ax_cxx_compile_stdcxx_11.m4
2018-09-25 gennadiycivil Delete m4_ax_cxx_compile_stdcxx.m4
2018-09-25 gennadiycivil Update configure.ac
2018-09-25 gennadiycivil Update Makefile.am
2018-09-25 gennadiycivil Update .travis.yml
2018-09-25 misterg automake
2018-09-25 misterg test automake c++11
2018-09-25 gennadiycivil Update configure.ac
2018-09-25 gennadiycivil Update configure.ac
2018-09-25 misterg typo
2018-09-25 misterg autotools c++11
2018-09-25 misterg autotools c++11
2018-09-25 misterg test
2018-09-25 misterg include c++11 for autotools
2018-09-25 absl-team Googletest export
2018-09-25 gennadiycivil Revert "Add clang format check to one of the builds"
2018-09-25 misterg Googletest export
2018-09-24 misterg Googletest export
2018-09-20 absl-team Googletest export
2018-09-25 misterg enable MingW on PR
2018-09-25 misterg C++11 autotools build
2018-09-25 misterg adding c++11 to appveyor mingW
2018-09-25 misterg typo
(...)

Created with:
  roll-dep src/third_party/googletest/src

TBR=thakis@chromium.org

Bug: 893369
Change-Id: Ic7e13ff5fd3952c4d71ab23166a5c36dcad86b99
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/c/1310634
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604801}

NVDA doesn't seem to be picking up the accessibility event on the zoom
level label. This change sends an alert event on the zoom bubble
instead.

Bug: 849472
Change-Id: I391e01bb952325b133cf9362d80c473140717a44
Reviewed-on: https://chromium-review.googlesource.com/c/1305242Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604800}

This uses the undocumented pthread_chdir_np() to change the launching
thread's PWD for the duration of the posix_spawn() syscall. There is no
other way to change directories when using posix_spawn, other than an
exec trampoline.

Bug: 179923
Change-Id: Ic6ab10cd1cb5be2f008b434b3546c05f080ef9b1
Reviewed-on: https://chromium-review.googlesource.com/c/1311258Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604799}

Currently redirect is not supported for download in non network service
code path without a renderer where we handle the network request with
UrlDownloader.

We have two legit use cases for redirect in UrlDownloader.

1. Retry, we won't assume the renderer exists and the download URL is
the final URL.

2. Background download in normal user profile. It should be legit for
all clients to redirect.

Bug: 883387
Change-Id: Ib517b3a1e23fbfac939386c0f2341a15a54b70ab
Reviewed-on: https://chromium-review.googlesource.com/c/1312114
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604798}

This is a quick fix for crbug.com/888215. crbug.com/901092 will track
the longer term fix, which will likely require quite a bit more work.

Bug: 888215
Change-Id: I071ea0a1508e486211789073c43050f4cd56accb
Reviewed-on: https://chromium-review.googlesource.com/c/1313414
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604797}

Bug: 870460
Change-Id: I1c8e20231d88fb7cb87b1bb2a31b6edcb031f6aa
Reviewed-on: https://chromium-review.googlesource.com/c/1313751
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604796}