- 10 Jan, 2020 40 commits
-
-
Yuki Shiino authored
The old bindings generator uses V8StringResource without NativeValueTraits, and existing NativeValueTraits<IDLString> is not as much performative as V8StringResource. This patch introduces NativeValueTraits<IDLStringV2> which uses the same technique as V8StringResource so that the new bindings generator can use NativeValueTraits for all the types without performance regression. Bug: 839389 Change-Id: Ibf7f40ba36d10affdef70d489f0f56a005bf73f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993360 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#730159}
-
Andreas Haas authored
I disabled the ArrayBufferContentsTest.AllocationFail test on ASAN, because ASAN causes a crash when allocation fails. Note that allocation is meant to fail in this test, and we want to check if the implementation can deal with a failed allocation. However, ASAN escalates the failed allocation to a crash. R=haraken@chromium.org, huangs@chromium.org Bug: chromium:1038741 Change-Id: I89c7138eb9b636cfd5ce6eae95bdfcf7dd7871cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985953 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#730158}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5a8f4d89e1e6..ef05f96d6de1 git log 5a8f4d89e1e6..ef05f96d6de1 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 aerotwist@chromium.org Migrates bindings/ to ESM internally Created with: gclient setdep -r src/third_party/devtools-frontend/src@ef05f96d6de1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I334cf37c9e63ce581899a0e73ec507fb1724ad0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994085Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730157}
-
Anders Hartvoll Ruud authored
BUG=545324 Change-Id: I2ce865bf6c9bb07d258bdc568128341b1d08d9d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986798 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#730156}
-
Vasiliy Telezhnikov authored
This CL moves BeginFrame related code to SynchronousCompositorHost from RenderWidgetHostViewAndroid as it was used only for WebView. This is part of ongoing refactoring for viz for WebView. Bug: 805739 Change-Id: I06c264db4fceb8ebee281660f1c771ac45a68b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992250 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#730155}
-
Vasiliy Telezhnikov authored
This CL moves code related to BeginFrames for browser-side fling to RenderWidgetHostViewAndroid. It also removes RenderWidgetHostView::SetNeedsBeginFrames as it's not used anywhere anymore (webview was last usage). This cleans up code after OOP-D launch and also part of viz for webview refactoring. Bug: 812322, 805739 Change-Id: I96d89e77fa9a31e51a87abb8ca203c6dc9265c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992506Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Robbie Gibson authored
This adds a simple UI for text zoom (just the done button). The more important contribution is that now, BVC will check which feature is active, text zoom or find in page, and if something asks it to display the other, it first dismisses the shown one. Bug: 1028938 Change-Id: I576a096a635e0736f70e853f3c78e5459d7f4b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946481 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#730153}
-
Tim van der Lippe authored
It was broken in https://chromium-review.googlesource.com/c/chromium/src/+/1636716 TBR=jalyn@microsoft.com Bug: 963183 Change-Id: I759d3430fdcdf253c59d921902f0c61b6ca17dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993811Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#730152}
-
Stepan Khapugin authored
Moves AppURLLoadingServiceDelegate from Main to Scene Controller. * adds SceneControllerGuts temporary interface to expose scene-level internals to MainController while the code is moved. Bug: None Change-Id: I0c7dbe077a94ff5b9c598c401c9c7340cc8f969c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983226 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
Vasilii Sukhanov authored
TBR=nzolghadr@chromium.org TBR=mustaq@chromium.org TBR=input-dev@chromium.org TBR=dom-dev@chromium.org Bug: 1034789 Change-Id: I80123c55571c5ebf98737101f9be2b1f2a84a75e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993972Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#730150}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 81-3987.18-1578307857-benchmark-81.0.4016.0-r1 to 81-3987.18-1578307857-benchmark-81.0.4019.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ib734989ad8dfc2fa33ca62a24cbd5b41bf889430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995301Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/079a14224dd1..3f1bd1b88a31 Created with: gclient setdep -r src-internal@3f1bd1b88a31 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1010717 Tbr: jbudorick@google.com Change-Id: I81b8a6846ce4dd210dd7102ab633c4eee9c8eed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995224Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730148}
-
Mikel Astiz authored
With this patch TrustedVaultClient.Backend has the ability to notify native code that the keys in the vault may have changed. This notification makes its way via TrustedVaultClientAndroid to ultimately SyncServiceCrypto, where refetching logic is triggered. This is expected to be an effective means for resolving encryption issues transparently without user action and without having to restart the browser. The very same method is also used upon relevant user action such as triggering the retrieval flow, in case the keys within the vault have changed since the last fetch (e.g. if the backend failed to or does not support broadcasting change notifications). Bug: 1012659 Change-Id: I985db773fe5b18f107a8c8731d31dbd80aaf599c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978005Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#730147}
-
Monica Basta authored
This CL adds tests for communicating the sWAA bit in sync setup settings. Bug: 1035421 Change-Id: I40f3c5304b04e433a2cac571a715299459a565c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991624 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#730146}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4b6df1777cba..56452dd17bac git log 4b6df1777cba..56452dd17bac --date=short --first-parent --format='%ad %ae %s' 2020-01-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision aa827d65..54a7cb4b (729982:730109) Created with: gclient setdep -r src/third_party/webrtc@56452dd17bac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I24e8d14bb2fd1576508df7df884f1fe5b21d613d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995223Reviewed-by:
-
Olivier Li authored
Set browser state builder dir to avoid file leaks in ios tests in /ios/chrome/browser/ui/location_bar This cl is generated with 'git cl split' This CL was uploaded by git cl split. R=stkhapugin@chromium.org Bug: 546640 Change-Id: If47000191d0170327c9e74d270c7b6cb0506367a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991752Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#730144}
-
Vasilii Sukhanov authored
TBR=foolip@chromium.org Bug: 1040912 Change-Id: Ie273a75c2f6f7efc1f0b17d9f8325eaaa6e8facf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994296Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/63dded1f4d55..033f08c5a865 git log 63dded1f4d55..033f08c5a865 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 primiano@google.com probes: workaround for missing NUL in /proc/pid/cmdline Created with: gclient setdep -r src/third_party/perfetto@033f08c5a865 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:147438623 Tbr: perfetto-bugs@google.com Change-Id: I8310f1a402b5a8bb0a3d09922a1b42f3301c6e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994083Reviewed-by:
-
Gyuyoung Kim authored
This CL cleans up redundant Create() factory methods in //third_partyb/blink/renderer only when it meets the policy of removing Create() so that we support only one of Create() methods or public constructors in a class. Then, this CL makes all callers use MakeGarbageCollected<Foo> instead. This CL removes below Create() functions, - CSSConicGradientValue::Create - PaymentManager::Create - RTCIceCandidatePlatform::Create Bug: 939691 Change-Id: I17f79f7478aa4491ee1995ac22593142731c0260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994541Reviewed-by:
-
Corentin Wallez authored
This reverts commit 7cb3f403. Reason for revert: Make TabCaptureApiPixelTest.EndToEndThroughWebRTC fail consistently on Win10 FYI x64 Release (Intel HD 630) Original change's description: > Fix issue where DXGI_FORMAT_R16G16B16A16_FLOAT gets used even when unsupported by hardware > > Issue backtrace: > - video_device_->CreateVideoProcessorOutputView(...) in > DXVAVideoDecodeAccelerator::CopyTextureOnDecoderThread() fails because > DXGI_FORMAT_R16G16B16A16_FLOAT is not supported by client's hardware. > - in DXVAVideoDecodeAccelerator::Initialize, use_fp16_ = true due to > "Issue 592074: Add support for different VP9 profiles". > - DXGI_FORMAT_R16G16B16A16_FLOAT is in fact not supported, and > CheckOutputFormatSupport(DXGI_FORMAT_R16G16B16A16_FLOAT) > DXVAVideoDecodeAccelerator::CreateDX11DevManager() reflects that, > and use_fp16_ = false. > > Proposed fix: > - Make use_fp16_ an enum to reflect the fact that its non-binary states. > - Because intent to use fp16 is expressed in DXVAVideoDecodeAccelerator::Initialize, > which can be called before or after support for fp16 is determined, let use_fp16_ be > set to kUsing for all states except kUnsupported. kUsing can be reversed later > when hardware support is queried. > > Bug: 1032438 > Change-Id: I113f26b126fdc1e0131a2362cbf19629f268f3eb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974761 > Reviewed-by: Frank Liberato <liberato@chromium.org> > Reviewed-by: Ted Meyer <tmathmeyer@chromium.org> > Commit-Queue: Vi Nguyen <ving@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#730012} TBR=sandersd@chromium.org,liberato@chromium.org,tmathmeyer@chromium.org,ving@microsoft.com Change-Id: I5071f5b78391ba4479d04132402f728799821ffa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1032438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995167Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#730140}
-
Anatoliy Potapchuk authored
app data Change-Id: I372946839db9523e76c3f1c6c6165087c2e8e4ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993822Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#730139}
-
Markus Handell authored
This change fixes a problem where MediaStreamVideoTrack would would CHECK-fail when the source has been cleared or deallocated AND a call to either SetEnabled, AddEncodedSink or RemoveEncodedSink occurs. The change also includes a new unit test for this case which was previously uncovered. Change-Id: Iab02df69277b2d2a287e2505977ce94345afb848 Bug: 1013590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993291Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#730138}
-
Markus Handell authored
This change fixes a crash in RequestRefreshFrame and also a few other potential cases found during code inspection. Bug: 1040626 Change-Id: I1cdeaa76b530b833dbdad8ab239ae66ee08bac60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994287Reviewed-by:
-
Olya Kalitova authored
Adds failure details in case default Crostini configuration using Ansible has failed. TEST: deployed on DUT and checked that logs are present Bug: 1000287 Change-Id: I4215bb117ed82fe8829ea5375767000645326915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991561Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#730136}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a104a789f873..f6f813d450e5 git log a104a789f873..f6f813d450e5 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 khokhlov@google.com [py_trace_event] Support clock snapshots in proto trace format Created with: gclient setdep -r src/third_party/catapult@f6f813d450e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:990304 Tbr: crouleau@google.com Change-Id: Ie00fda30a7af9b9330a96400879c164e0d846f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994084Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/72ee5754..e195519d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5c29cdd5bb0f59a1f365f9983832fffda65ec8f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993763Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730134}
-
Gauthier Ambard authored
This CL adds the UIAccessibilityTraitNotEnabled to the search engine cells when they are not interactable. Fixed: 1040497 Change-Id: Iec65f625d7bf3d7f738d82ab86b204c3c58a6099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994284 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#730133}
-
Vasilii Sukhanov authored
TBR=erikchen@chromium.org Bug: 989810 Change-Id: I45c6ba5ddc575e8c5202ca32db5165169de1421b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994289Reviewed-by:
-
Mikel Astiz authored
It reuses a screenshot previously uploaded for IDS_SYNC_ERROR_PASSWORDS_USER_MENU_TITLE. Bug: 1036454 Change-Id: I4388b36516d040b4314197f9b4f642d9577c3523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995160 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#730131}
-
Anders Hartvoll Ruud authored
BUG=545324 Change-Id: Ib7c79ad352a8d68a7815ca992f25280e5c980561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986797 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
-
Alex Danilo authored
Quickview loads image previews by calling decode() on the <img> element after its 'src' attribute is set. When the image is finished decoding it should replace the previous decoded image. Changes decode() failures to send a message to the container that decode failed and in turn, set the contentURL to '' which in turn unloads the webview and displays the 'no preview available' icon. Bug: 645021 Tests: browser_tests --gtest_filter="*QuickViewBrokenImage" Change-Id: Ie1d19f1a4f1014486eaaec9581007f25d4c7f165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992954 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#730129}
-
Clemens Backes authored
We plan to run a finch trial on mobile chrome to test different compilation strategies. For this, we need to separate enabling Liftoff from enabling tiering. The finch config could then enable Liftoff but disable tiering - a configuration which is not possible currently. Note that this CL does not change the default configuration. On Desktop, we enable both Liftoff and tiering. On mobile platforms, Liftoff is disabled, so the tiering flag has no effect. R=ahaas@chromium.org, jochen@chromium.org Bug: 1040030, 1040061 Change-Id: I7cd0a8907d84388d15cb49663d18fe4c5c81dd83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988360 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#730128}
-
Monica Basta authored
This CL implements communicating the sWAA to |chrome://settings/syncSetup| as part of the friendly settings project. The sWAA bit will be fetched and shown in the sync section. Its value depends on the following factors: 1- Data is encrypted with custom passphrase or not. If yes, Google has no access to the data and can not use history to provide personalized experience. In that case, sWAA is 'Off'. 2- History sync is On/Off. This pref is set per device which means history from this device can not be used for personalization. We show 'Off' as well. 2- History recording is enabled/disabled in |Web and Activity| in the Activity control page. If the user does not have encryption and history sync is On, then sWAA will be On if history recording is enabled and Off otherwise. The sWAA can be in one of the following states: 1- Not fetched: On startup, sync is off, feature |kSyncSetupFriendlySettings| is disabled. In that case, no changes is reflected in the UI. 2- Fetching: we show a spinner. The request is pretty fast and the spinner is almost not visible. 3- Failed: If we fail for any reason to fetch the sWAA bit. Also, in that case no changes to the UI. 4- On: We show sWAA state 'On' + hint to reflect how will this affect the user experience. 5- Off: We 'Off' + hint to indicate the reason why Google can not use history to provide personalized experience whether it's because of encryption or history sync off or history recording toggled off. To guarantee we show the most up to date value, we refresh sWAA on the following events: On navigation to page, Sync turned on, Encryption, History sync toggled, sync pref changes in case we previously failed to fetch (fetch failures sometimes are due to sync service not active yet) and page is visible. Bug: 1035421 Change-Id: I0577b0ff76bfd7d66415416fdfba5f91f4e34316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973915 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
-
Vasilii Sukhanov authored
TBR=eirage@chromium.org Bug: 1040874 Change-Id: Iec6b2cc5a72e1b3256d66b8acf09f515e8a0b250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995164Reviewed-by:
-
Richard Knoll authored
The P2PSocketManager resolves host names in GetHostAddress and responds with the supplied callback. That callback is dropped in the destructor which can happen if there is a mojo connection error. We need to close the pipe to the mojom::P2PSocketManager before doing that as mojo will check if the connection is still active when dropping a callback. Bug: None Change-Id: I2a1e411f5aba21a375e33bd242b67f64c9362a8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991560Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#730125}
-
Alice Wang authored
This CL tests and refactors the SignOutDialogFragment. Bug: 967374 Change-Id: Ibe0af76022877305b38513d5855e238465635469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982557 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
-
Vasilii Sukhanov authored
This reverts commit d140b7a4. Reason for revert: Broke crashpad_tests reliably https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64%20%28dbg%29/12597 Original change's description: > Enable init_stack_vars for non-official Debug Windows builds > > Debug build is fixed with: crrev.com/c/1973353 > > Bug: 977230, 1030261 > Change-Id: Idcb24d092247f6bc7438c74b6405b4b93539507d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970852 > Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> > Reviewed-by: Vitaly Buka <vitalybuka@chromium.org> > Reviewed-by: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#728840} TBR=hans@chromium.org,vitalybuka@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 977230, 1030261 Change-Id: Iad7d92e12299365b4a45a5237c3bc5e371e33dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993964Reviewed-by:
-
Richard Knoll authored
The latest beta of 10.15.3 fixed the issue where an XPC service could not show notifications. This removes the workaround we put in place in https://crrev.com/c/1883648 for macOS 10.15.3+ but keeps it for earlier versions of 10.15. Bug: 1007418 Change-Id: I928dac7366c9e7faee793dd72d282b031e535092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991637 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#730122}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9dbcda838560..a104a789f873 git log 9dbcda838560..a104a789f873 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 dberris@chromium.org Fix dispatch routing Created with: gclient setdep -r src/third_party/catapult@a104a789f873 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1035930 Tbr: crouleau@google.com Change-Id: I895bd006cf70d17e86fc254e5382c50f708cbe76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994259Reviewed-by:
-
Eric Seckler authored
Replaces SyncChannel::Send, RenderProcessHostImpl::Send, and GpuChannelHost::Send trace events with typed trace events. Also adds a utility to convert the IPC class ID to a corresponding protobuf enum. Corresponding proto buffer definitions for these events were added in aosp/1180211. Typed trace events will allow inclusion of the event arguments in slow reports data in the future. The trace format is protocol-buffer based under the hood already (see docs.perfetto.dev for details), this patch adds strong typing for the arguments of the respective events only. TBR: sunnyps@chromium.org Bug: 644264 Change-Id: I91c71230e62161b08faec889bf9eb70639ae0b5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950986 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#730120}
-
