- 23 Aug, 2018 40 commits
-
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/31629a8a3271..9db44ed0ef7f git log 31629a8a3271..9db44ed0ef7f --date=short --no-merges --format='%ad %ae %s' 2018-08-23 halcanary@google.com bin/droid script: fix wierd mkdir error on my device 2018-08-23 bsalomon@google.com Revert "Fix leak in SkSLParser" 2018-08-23 bsalomon@google.com Fix leak in SkSLParser 2018-08-23 egdaniel@google.com Revert "Add GPU-side caching of mask-filtered path masks" 2018-08-23 fmalita@chromium.org [skottie] Plumb external SkFontMgr 2018-08-23 borenet@google.com [infra] Speculative fix for cq.cfg 2018-08-23 robertphillips@google.com Add GPU-side caching of mask-filtered path masks Created with: gclient setdep -r src/third_party/skia@9db44ed0ef7f The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I2cbb2524eafe25d1acf017b7ae0c1ad25963e0c7 Reviewed-on: https://chromium-review.googlesource.com/1186665Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585504}
-
Calder Kitagawa authored
Phase 3 of the work to replace url_template with action and params as per the updated WebShareTarget spec: https://wicg.github.io/web-share-target/. This work updates WebAPKs to use the new action and parameter model rather than |url_template|. See the bug for a detailed plan for performing these changes. Bug: 871788 Change-Id: I17ea1f7cb0fa5b6bef0e1ad1cf90434f0bacb60f Reviewed-on: https://chromium-review.googlesource.com/1171587 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#585503}
-
Paul Meyer authored
Bug: 872771 Change-Id: Ia3732f5112be42bdb517bee5b47855fcf2e24d8a TBR: avi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1169591 Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#585502}
-
Pavel Yatsuk authored
Specifics: +618,790 bytes normalized apk size +3 zip entries file count +41,588 bytes main lib size +391,432 bytes main dex size InstallSize: +230,268 bytes APK size +1,811,653.28 bytes Estimated installed size InstallBreakdown (+1,809,693.28 bytes): +2,910 bytes unwind_cfi (dev and canary only) size +1,568 bytes Non-compiled Android resources size +41,588 bytes Native code size +164 bytes Package metadata size +1,748,939.28 bytes Java code size +14,524 bytes Compiled Android resources size Dex: +1,948 entries fields +2,665 entries methods +633 entries types +1,320 entries strings R=fgorski@chromium.org Change-Id: I024c2f4c193059fc9b93d75d4f756ed1de076dd2 Reviewed-on: https://chromium-review.googlesource.com/1185844 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#585501}
-
Theresa authored
BUG=871802 Change-Id: Ia96c4bd872ba9d0e2e7529b5b27b91d8b8ffbc7e Reviewed-on: https://chromium-review.googlesource.com/1185891Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#585500}
-
Guido Urdaneta authored
This reverts commit a9ed1fd3. Reason for revert: Speculative revert since two WebRTC bots started failing reliably after this CL. If the revert does not fix the bots (which I think is likely), we will reland it. Original change's description: > [NTP] Clear attribution on the existing tab when apply a theme > > Now we will clear the attribution also on the existing tab when a theme > is applied. > > Bug: 875519 > Change-Id: I65e8a0dc1ed3492c512cabcf1a2d3f0e6f2e64f7 > Reviewed-on: https://chromium-review.googlesource.com/1181684 > Commit-Queue: Weilun Shi <sweilun@chromium.org> > Reviewed-by: Kristi Park <kristipark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584964} TBR=kristipark@chromium.org,ramyan@chromium.org,kmilka@chromium.org,sweilun@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 875519 Change-Id: I20ff372903d2abee0620d42e9cff18777515ac65 Reviewed-on: https://chromium-review.googlesource.com/1186762Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#585499}
-
Lukasz Anforowicz authored
This CL exposes content::GlobalFrameRoutingId and GlobalRoutingID via //content/public/browser API and uses it where appropriate instead of std::pair<int, int>. This CL also opportunistically fixes some other minor issues: - IWYU problems reported by |git cl lint| - Presubmit issues (e.g. using base::Callback instead of OnceCallback) This CL is intended to be pure refactoring - no intended behavior change. Bug: 834185 Change-Id: I39daff220c8a7da19114d28a1ea9ca8e24cc93fe Reviewed-on: https://chromium-review.googlesource.com/1184150Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#585498}
-
Troy Hildebrandt authored
In preparation for a single shared database for browser features, additional parameters have been added to LoadWithFilter to allow only specific entries to be loaded instead of the entire database. Some minor modifications to FakeDB are made to ensure tests still build and run. Bug: 870813 Change-Id: I802331d477ec0ed2d6821c6d937cb2d497560345 Reviewed-on: https://chromium-review.googlesource.com/1169874 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#585497}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2229a8947448..a7fb87b3a3d1 git log 2229a8947448..a7fb87b3a3d1 --date=short --no-merges --format='%ad %ae %s' 2018-08-23 nednguyen@google.com Wrap all exception of websocket with telemetry's exception.Error for recoverability Created with: gclient setdep -r src/third_party/catapult@a7fb87b3a3d1 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:876681,chromium:877074 TBR=sullivan@chromium.org Change-Id: I71fcf38964d1c2bde5afaea5d789314b35724b0e Reviewed-on: https://chromium-review.googlesource.com/1186664Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585496}
-
Rayan Kanso authored
Starting a request / storing a response don't propagate errors to the job controller. This is why we should check whether we got all of the request/response pairs before deciding what sort of event to dispatch. Change-Id: Ie3c89ab92a7b843220b8f3b1201f527f895faf77 Reviewed-on: https://chromium-review.googlesource.com/1181576 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#585495}
-
Victor Costan authored
Change-Id: I03d1e0ba27eae87f73862027b52d3d46aff09179 Reviewed-on: https://chromium-review.googlesource.com/1185785 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#585494}
-
chaopeng authored
This test switches a <frameset> to a <body>. For framesets, LayoutView::CalculateScrollbarModes forces the user scrollable bit to be false. So, we need to make sure to call LayoutView::SetNeedsPaintPropertyUpdate when the LayoutView's child changes to/from a frameset. Bug: 875287 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5ae0a7673ae8e325242465633749ffcd76ca705f Reviewed-on: https://chromium-review.googlesource.com/1186181Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#585493}
-
Tim Schumann authored
Change the sync Wallet integration tests to simulate a more realistic server behavior. In particular, provide a realistic version number, GC directives, no client defined unique tags, and non-incremental updates. Wallet data cannot be served by the loopback server (which only supports incremental updates) and shouldn't as that server is used for local sync. Instead, this functionality is added to the FakeServer. Worth noting: Adding time-based values to the progress marker (gc directive's version_watermark) required changes in the way how integration tests verify two clients are in an equal sync-state. Before this was done by comparing the complete progress markers. Verified that when enabling USS for autofill wallet data, the incorrect behavior of dropping cards without a client tag is exercised. Bug: 876308 Change-Id: I9fc8929a508ce5fb62df79a1acf62c65ff98d0fe Reviewed-on: https://chromium-review.googlesource.com/1184821 Commit-Queue: Tim Schumann <tschumann@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#585492}
-
Mason Freed authored
This continues the work done in https://chromium-review.googlesource.com/c/chromium/src/+/1171144, this time expanding the set of folders considered for replacement, and the scope of the replacements. With this CL, I believe I have replaced most references to Style() with StyleRef() within these folders: - paint - layout - svg - frame Note that I only replaced immediate uses of Style(), i.e. Style()->Xyz. These are guaranteed not to cause any breakage (assuming I did the replacement well) because they already dereferenced the pointer. There are many references to Style() where the result is first checked, or where the actual pointer is passed around, and I have not touched those (yet). Perhaps for a later CL. I have also consciously not modified code in other folders (including animation, css, dom, editing, exported, html, input, layout/ng, page, and style). The reason I skipped these is that, at least for now, I am not sure that Style can always safely be assumed to be available (non-null). There are definitely cases where that can be inferred, but I didn't want to change some references in a folder and not others. Perhaps for a later CL. Bug: 872508 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie2293901477ef3ed8912582d206bdaac8fd000e1 Reviewed-on: https://chromium-review.googlesource.com/1182185 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#585491}
-
Doug Arnett authored
This is in conjunction with launching NoScript Preview to Stable channel via Finch. Bug: 876778 Change-Id: Ibc5f559b4c4b36555fc04966c8c44a4cccdb381d Reviewed-on: https://chromium-review.googlesource.com/1185369 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#585490}
-
Kevin McNee authored
Currently, app windows (possibly containing webviews): 1) suppress all pinch events which also suppresses the synthetic wheel event, but not touchscreen touch events, and 2) allow "smart zoom" on Mac which can change the page scale even though other means of changing the page scale are suppressed. As a result of (1), if we have, say, google maps in a webview, a user can pinch zoom with a touchscreen, but not with a touchpad. We now suppress gesture events to app windows based on whether they cause a scale change. So now touchscreen and touchpad pinching are consistent since the page has access to the events so that it may implement custom pinch zoom behaviour, but unhandled events still do not result in a scale change for the app window. Also, smart zoom is suppressed to be consistent with other touchpad pinching. Bug: 725970, 874132 Change-Id: I03dd2048002d69dc7c8a822fc727140c67d64706 Reviewed-on: https://chromium-review.googlesource.com/1174933Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#585489}
-
Ned Nguyen authored
This reverts commit 088dc9df. Reason for revert: breaking memory.top_10_mobile on android-go-perf BUG:chromium:877058 Original change's description: > DevTools: Restore GPU tasks recording in performance profiles. > > Add GPU process pid to the list of processes where tracing is enabled. > > Change-Id: Ic401ee4ea7d218cad36f687be226d092cd4e54a0 > Reviewed-on: https://chromium-review.googlesource.com/1182304 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585301} TBR=dgozman@chromium.org,kbr@chromium.org,alph@chromium.org Change-Id: I256ed424aa4af07ccd63b561b17d86a7d7c9dded No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1186841Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#585488}
-
Max Moroz authored
TBR=inferno@chromium.org,liaoyuke@chromium.org Bug: 817798,866943 Change-Id: Ibbd8117a8adc656defefaa776f6983dde9a13a4f Reviewed-on: https://chromium-review.googlesource.com/1186544Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#585487}
-
David Benjamin authored
Change-Id: I03095ea46e32d41def4a444ff1c8c41409209294 Reviewed-on: https://chromium-review.googlesource.com/1185972Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#585486}
-
Daniel Erat authored
Now that VirtualFileRequestServiceProvider lives in //chrome/browser/chromeos/dbus, it no longer needs a Delegate interface. Bug: 843392 Change-Id: Iaafc3d7d79c6c39cca0e8de2febe31bad07efd6e Reviewed-on: https://chromium-review.googlesource.com/1184159 Commit-Queue: Dan Erat <derat@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#585485}
-
Joe Mason authored
This reverts commit 0a12bc8f. Reason for revert: https://chromium-review.googlesource.com/c/chromium/src/+/1186241 reverted a related patch, but the error in the log was from pup.mojom, which is in this patch. Reverting both patches until I can find the root cause. Original change's description: > Add chrome_cleaner sandboxed engine Mojo interfaces > > R=wfh > > Bug: 830892 > Change-Id: I0a4b25b2ba04b65a80e2c03e9151b5ef55912432 > Reviewed-on: https://chromium-review.googlesource.com/1171737 > Commit-Queue: Joe Mason <joenotcharles@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585025} TBR=joenotcharles@chromium.org,wfh@chromium.org Change-Id: Ieaf8c3d4e8557361e79084b18708f786b88c8473 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 830892 Reviewed-on: https://chromium-review.googlesource.com/1186781Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#585484}
-
gogerald authored
Bug: 806868 Change-Id: Ic4628b11191d2be98e892fce107464ee694301ed Reviewed-on: https://chromium-review.googlesource.com/1184149 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#585483}
-
Aga Wronska authored
Bug: 857525 Test: Manually Change-Id: I18789fe5973d97097829e8bdb260c2292aa7ddc3 Reviewed-on: https://chromium-review.googlesource.com/1159692 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#585482}
-
Ken Buchanan authored
When the browser uses InputTargetClient to perform a slow path hit test to an out-of-process iframe, it currently uses TransformPointToCoordSpaceForView to convert the event's target point into the OOPIF's coordinate space. This does not work correctly for iframes with perspective transforms applied or otherwise non-invertible transform matrices. This CL causes InputTargetClient to return the transformed point from the renderer process, which already covers such transforms. The browser uses that point for subsequent hit tests or passes it back to the renderer with the input event. It also changes HitTestQuery and SurfaceHitTest to always defer to slow path hit testing whenever any element with such a transform is encountered, because it can't determine accurately whether the point is within the bounds of the transformed element. Bug: 854247 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ic9b69afe418bccdadab45480fc58b8942fccd09f Reviewed-on: https://chromium-review.googlesource.com/1118612Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#585481}
-
Ulan Degenbaev authored
This introduces four isolate types (main, worker, utility, test) and stores the isolate type in IsolateHolder. V8's memory dump provider will group memory dumps by the isolate type, which is necessary for UMA/UKM reporting of V8's memory metrics. Bug: chromium:852415 Change-Id: Id9a31404e6bc62562545518aaa4e35cae00a97d6 Reviewed-on: https://chromium-review.googlesource.com/1183194 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#585480}
-
Matt Menke authored
Bug: 875253 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I44040a7f396954436f7dadcd6d80fa87a862328d Reviewed-on: https://chromium-review.googlesource.com/1185748Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#585479}
-
Benoit Lize authored
Test is no longer flaky locally. Bug: 864718 Change-Id: I79dcbf886b5365f6802144ef99a0a3ae024b3594 TBR: nednguyen@chromium.org Cc: mythria@chromium.org,ulan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1186469Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#585478}
-
Finnur Thorarinsson authored
This reverts commit 87182d18. Reason for revert: Breaks browser_tests and viz_browser_tests. Example: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28716 Triggers DCHECK on line 859: https://chromium.googlesource.com/chromium/src/+blame/87182d18c9a56d1860288e4e92e726e1f399bf97/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc#859 Original change's description: > Avoid conversion between GURL and std::string > > ProfileDownloader::GetProfilePictureURL returns a std::string > corresponding to the representation of a GURL then immediately > converts it back to a GURL. > > This is wasteful, so convert this method to return a GURL > instead and convert GetCachedPictureURL to also cache the > GURL instead of the string representation. > > Convert static std::string to static char[] and use EXPECT_ > instead of ASSERT_ macros when possible in unit tests (since > the EXPECT_ macro do not stop the test in case of failure). > > Bug: none > Change-Id: Ibe73f28b38b2061b37cbdb0b9b0696b25ca8c41c > Reviewed-on: https://chromium-review.googlesource.com/1160645 > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585426} TBR=bauerb@chromium.org,msarda@chromium.org,sdefresne@chromium.org,jdufault@chromium.org Change-Id: Ib1cc81bef47d279214f63528e78d4d885a7aa0e5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/1186761Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#585477}
-
Amirhossein Simjour authored
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I81fca5889609d48f81b05d2394700787b6b56c44 Reviewed-on: https://chromium-review.googlesource.com/1186154Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#585476}
-
Christian Biesinger authored
This just runs blink_perf.layout with the NG flag. TESTED=tools/perf/run_benchmark run blink_perf.layout_ng --browser=release -v (and verified that the commandline includes the layoutng flag) Change-Id: I4302330462d52291d96d3d8509498337e267a1f4 Reviewed-on: https://chromium-review.googlesource.com/1185641Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#585475}
-
Mugdha Lakhani authored
through various Background Fetch events. This also makes adding FailureReason to BackgroundFetchRegistration easy, since the plumbing to various service worker dispatcher classes won't have to be done again. Bug: 874092, 873630 Change-Id: I1ae3b2115b1b1c357efa67e3e684423e5f4cd060 Reviewed-on: https://chromium-review.googlesource.com/1176085 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#585474}
-
Arthur Sonzogni authored
RenderFrameHostImpl are removed from the set of frame in fullscreen when they are deleted. It means they are still in this set in between their swap out and their deletion. As a result this test was flaky on slow devices: WebContentsImplbrowserTest.NotifyFullscreenAcquired_Navigate This CL: * Fix this issue by removing the frame immediatly when it is swapped out. * Renable the flaky test on Android. * Add a regression test. Bug: 855018, 609963 Change-Id: Ic858acd462cd8f80f39b76c09d5fbd8f9c3110b1 Reviewed-on: https://chromium-review.googlesource.com/1181433 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#585473}
-
Ioana Pandele authored
This CL changes: - colors - spacing - tap animation on suggestions in the accessory sheet - keyboard accessory dividers Bug: 856180 Change-Id: Ieb0809f5c175a481bb5d9d0b0e0e8187c300f542 Reviewed-on: https://chromium-review.googlesource.com/1163612 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Friedrich Horschig [CEST] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#585472}
-
Justin Cohen authored
For historical reference, four years we started hiding this view "to prevent it from overlapping slightly with Most Visited after a device rotation when the omnibox is focused." per: https://chromereviews.googleplex.com/99937015 It doesn't appear this is necessary anymore, and hiding that view is causing some edge case bugs. Bug: 703024 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icb43e4a93b3e1675684267e2b8f4433a47acad17 Reviewed-on: https://chromium-review.googlesource.com/1185742Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#585471}
-
Corentin Wallez authored
These are the initial suppressions because the webgl[2]_gl_passthrough_conformance_tests just got added on Win/Intel. TBR=kbr@chromium.org BUG=angleproject:2760 BUG=chromium:602688 BUG=chromium:809594 BUG=chromium:864524 BUG=chromium:876777 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I88cc85a313ab09fafca5f44129a7f85cc99ddcb2 Reviewed-on: https://chromium-review.googlesource.com/1186462Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#585470}
-
Olivier Robin authored
Change the implementation of the WebFramesManagerImpl to use a map instead of a vector. WebFrames are uniquely identified by frameID, so having a map frameID -> WebFrame will ensure that there uniqueness and make lookup easier and faster (log(N) instead of N). Bug: 851636 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If3c76acd8b1bd05a57821c87b571cffa7b8d3607 Reviewed-on: https://chromium-review.googlesource.com/1142781 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#585469}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5953a476d9f7..31629a8a3271 git log 5953a476d9f7..31629a8a3271 --date=short --no-merges --format='%ad %ae %s' 2018-08-23 benjaminwagner@google.com [infra] Rename PowerVR jobs to be consistent. Created with: gclient setdep -r src/third_party/skia@31629a8a3271 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I97329ee7b8115615158b63446d2f0073bf8953ad Reviewed-on: https://chromium-review.googlesource.com/1186541Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585468}
-
Rayan Kanso authored
For any child frames, the permission model will follow that of worker contexts. Bug: 692647 Change-Id: Ibb9d8a0fde4f7f61188ae11edd8600f1775acd4c Reviewed-on: https://chromium-review.googlesource.com/1186331 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#585467}
-
Rayan Kanso authored
Bug: 692647 Change-Id: I780b7137f34ca444d4e47030eb96b17628931209 Reviewed-on: https://chromium-review.googlesource.com/1183669 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#585466}
-
Ramin Halavati authored
Reading List preference is moved to the persistent storage list for incognito mode. This CL does NOT make any change of behavior. Bug: 861722 Change-Id: Ie29e7c86cedc19842f64939a1acf60e7835bffc1 Reviewed-on: https://chromium-review.googlesource.com/1172132Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#585465}
-