- 26 Jun, 2018 40 commits
-
-
Mike Wittman authored
Flakily times out on Chromium OS ASan and Windows. Bug: 512431 Change-Id: I358abf93cd6225a44477e1a83e1814ed4eb3b1da Reviewed-on: https://chromium-review.googlesource.com/1113916Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570551}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/0a6dbeffbc61..c4dce690f433 git log 0a6dbeffbc61..c4dce690f433 --date=short --no-merges --format='%ad %ae %s' 2018-06-26 tsepez@chromium.org Use pdfium::span<> in cpdf_fontglobals.h 2018-06-26 hnakashima@chromium.org Assert that tab width assumption holds in CFX_RTFBreak. Created with: gclient setdep -r src/third_party/pdfium@c4dce690f433 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:844367 TBR=dsinclair@chromium.org Change-Id: I6ac929ade18a91057a923cfaa74a1f046f472b1b Reviewed-on: https://chromium-review.googlesource.com/1115411Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570550}
-
Varun Khaneja authored
R=jialiul Bug: 855202 Change-Id: I100381590c3d87b5aeae8711abe2a38c8a28d8a5 Reviewed-on: https://chromium-review.googlesource.com/1110949 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#570549}
-
kylechar authored
Remove code for creating a RootCompositorFrameSinkImpl from FrameSinkManagerImpl. FrameSinkManagerImpl is already a complicated class and it just needs to be manage CompositorFrameSinks that have been created. The complexity of creating a RootCompositorFrameSinkImpl is now contained in the class itself. Add a static RootCompositorFrameSinkImpl::Create() that handles creating the BeginFrameSource, Display and RootCompositorFrameSinkImpl. Move all BeginFrameSource creation into this one function. Also split the intialization of RootCompositorFrameSinkImpl so it can be created before a Display exists. Bug: 856705 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I5b24658232c40d5f4c7801cf6562611eb4a2c996 Reviewed-on: https://chromium-review.googlesource.com/1115340 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#570548}
-
Zhongyi Shi authored
Finch config for "migrate_sessions_on_network_change"(used by QUIC Connection Migration V1) is removed in https://chromium-review.googlesource.com/c/chromium/src/+/1060285. This change also removes unused methods. Bug: 843299 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icc4642112a82158411078893e6780e77123e2cc2 Reviewed-on: https://chromium-review.googlesource.com/1114085 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#570547}
-
David Tseng authored
- capital personality was tuned for Google tts some years ago. It is too high for the current engine - re-do precedence logic. Do not set speech props if they were supplied by callers. Bug: 855257 Change-Id: I541021fa456c5283e943ecb71183e99c547a4f8a Reviewed-on: https://chromium-review.googlesource.com/1115517Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#570546}
-
Bin Wu authored
If a QuicConnection is writer blocked, always add it to the write blocked list. Protected by --quic_reloadable_flag_quic_add_to_blocked_list_if_writer_blocked. If --quic_reloadable_flag_quic_add_to_blocked_list_if_writer_blocked is true, QuicConnection::ProcessPacket will also add the connection to write blocked list if it is write blocked, and will not attempt to write before the writer unblocks. Merge internal change: 201524024 R=rch@chromium.org Bug: 848178 Change-Id: I2e7087ccb6fe11d575ceb7bea57fbaa9b1aeb68c Reviewed-on: https://chromium-review.googlesource.com/1114923Reviewed-by:
-
Manu Cornet authored
* Add close buttons * Wire up events for previews and close buttons * Introduce a WindowPreview class and observer interface * Add base methods so that the tooltip manager can delegate some event handling to individual tooltips. The "default" type of tooltip remains simple and non-interactive (no change in behavior). Bug: 834392 Change-Id: I174c166fc1c3f50580448420af7bb1a71ab6a65d Reviewed-on: https://chromium-review.googlesource.com/1090852 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#570544}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/83a57e01cd02..7ccf2f0c21b3 git log 83a57e01cd02..7ccf2f0c21b3 --date=short --no-merges --format='%ad %ae %s' 2018-06-26 ehmaldonado@chromium.org gclient: Report what dependencies were not processed. Created with: gclient setdep -r src/third_party/depot_tools@7ccf2f0c21b3 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:853010 TBR=agable@chromium.org Change-Id: I2114a967bdc99da371523385f2b019141c4575dd Reviewed-on: https://chromium-review.googlesource.com/1115414Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570543}
-
Christian Fremerey authored
[Video Capture Service, ChromeOS] Separate startup of CameraHalDispatcher from instantiation of VideoCaptureDeviceFactory Separate startup of CameraHalDispatcher from instantiation of VideoCaptureDeviceFactory by extracting the startup calls from VideoCaptureDeviceFactoryChromeOS to MediaStreamManager (which is where VideoCaptureDeviceFactoryChromeOS gets instantiated in case the video capture service is not enabled). For ChromeOS builds that use the cros_camera_service for video capture, the CameraHalDispatcher must be started as part of Chrome startup. This startup has for now been tied to the instantiation of VideoCaptureDeviceFactoryChromeOS. With the move to the VideoCaptureService, the instantiation of VideoCaptureDeviceFactoryChromeOS no longer happens on Chrome startup, but instead happens on-demand and potentially more than once. Design Doc: https://docs.google.com/document/d/169LS3U0DD7hHpqZSli0gpCaCqE1eWN4QXFSIGoruPwQ/edit?usp=sharing Test: See test plan section in design doc. Bug: 820608 Change-Id: I257a9eaa6368144fd252e532d211dfa716e8c242 Reviewed-on: https://chromium-review.googlesource.com/1107008Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#570542}
-
Aaron Leventhal authored
The ax_dump_events tool is crashing when IA2 not supported on an object. This checks that the queryInterface succeeded and that we hold a non-null IA2 pointer, before trying to use the IA2 pointer. Bug: None Change-Id: I4e2e2b469b0d891eac920fac1273436d28702f85 Reviewed-on: https://chromium-review.googlesource.com/1115561 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#570541}
-
Parastoo Geranmayeh authored
When showing titles we check to see if it's the right form. While checking to see if two forms are identical, it's not a good idea to check for the actions, they may not be updated. Instead, we use the number of the fields in that form to make sure it's the right one. (Names are not unique.) Fixes: bbc, avon, northface, etc. Bug: 856739, 850292, 850251, 850248 Change-Id: Ia434715e54a30406872f1ff5aeee39c67b2948c5 Reviewed-on: https://chromium-review.googlesource.com/1115423 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#570540}
-
Nicolas Pena authored
This CL adds a UseCounter that tracks the two ways to use EventTiming explicitly: * getEntriesByType or getEntriesByName with event/firstInput. * Having PerformanceObservers of event/firstInput. Bug: 851484 Change-Id: I8c2af71d089dbbf7db87b94b8b5d9f56e1699998 Reviewed-on: https://chromium-review.googlesource.com/1115511Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#570539}
-
Sunny Sachanandani authored
Describes generation, verification, waiting, completion, and correctness of sync tokens. TBR=piman BUG=826541 Change-Id: Id087134081af41264140d640c90ea96843bdf678 Reviewed-on: https://chromium-review.googlesource.com/1114387Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#570538}
-
Kyle Horimoto authored
This class provides all RemoteDeviceRefs on the user's account which are eligible to become MultiDevice hosts. Bug: 824568 Change-Id: I32936f40c5fdcc8f9a9a0264a4f8d6d02da73341 Reviewed-on: https://chromium-review.googlesource.com/1115458Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#570537}
-
Evan Stade authored
Test: chrome --enable-features=Mash --ash-enable-v1-app-back-button Bug: 854704 Change-Id: I37217f18900c9f93c94ea7148de900f3d14564d5 Reviewed-on: https://chromium-review.googlesource.com/1114202Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#570536}
-
Tiger Oakes authored
Continuation of work in bug 646094. This CL was uploaded by git cl split. R=pavely@chromium.org Bug: 846456 Change-Id: I2d3ca825f9e312a9b4bb5c0addda69a1159b8de6 Reviewed-on: https://chromium-review.googlesource.com/1095990 Commit-Queue: Tiger Oakes <tigero@google.com> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#570535}
-
Eric Stevenson authored
We switched to D8 in 2e3db781, but it turns out that D8 doesn't support Java asserts. This CL updates D8 with a fix to allow our assertion-enabling code to work again. Bug: 856575 Change-Id: I8f0f239c40de503445bc6a24ad54449a6b5de18c Reviewed-on: https://chromium-review.googlesource.com/1115424Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#570534}
-
Tao Bai authored
This patch parses forms in AutofillHandler::OnFormsSeen(), so the code could be shared between chrome and WebView autofill. The parse is disabled in WebView autofill now. Bug: 849913 Change-Id: I25260fa87eb59c2cc2d9060a1d92acbca0254e84 Reviewed-on: https://chromium-review.googlesource.com/1108921Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#570533}
-
Khushal authored
The PaintCanvas API for drawing SkBitmaps has 2 short-comings when used with a recording canvas: 1) It re-generates a PaintImage with a new key for potentially same bitmaps. 2) It creates an internal SkImage wrapping this bitmap, which may incur a copy of the pixels if the bitmap is not marked immutable. Both of the above are also non-obvious from the API. Remove it and switch callers to use PaintImages instead. The main user of this is ui/, which already caches bitmaps for reuse in ImageSkiaRep. Also cache a PaintImage with it to ensure we use a stable key for the bitmap. R=danakj@chromium.org Bug: 851282 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0ef7e8db798778b52b74a96dbf1a143fbead2ba9 Reviewed-on: https://chromium-review.googlesource.com/1110950Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#570532}
-
Devlin Cronin authored
Add SecurityPolicy::RemoveAllOriginAccessWhitelistEntriesForOrigin() to remove all entries associated with a given origin. This simplifies the extensions code and is faaaar more efficient, since we don't have to construct <n> different origin entries and iterate over the list of possible matches. Instead, we just remove the entry from the map in its entirety. No behavior change is expected. TBR=slan@chromium.org Bug: None Change-Id: Ibb05221898d4a2539e1a687941526e7ecf09c72a Reviewed-on: https://chromium-review.googlesource.com/1105287 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#570531}
-
Robert Sesek authored
This could occur if a detached code signature file is shorter than its typical prologue. Bug: 826761 Test: unit_tests --gtest_filter=DMGAnalyzerTest.InvalidDetachedCodeSignature Change-Id: Ic11b12eb9ce7d7b787b7668af43e2c6ddb3abd52 Reviewed-on: https://chromium-review.googlesource.com/1114925 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
Michael Mitasev authored
Bug:848978 Change-Id: I71dcd04531b9d48d292e3bc3de879be8cf9b6b63 Reviewed-on: https://chromium-review.googlesource.com/1109583 Commit-Queue: Michael Mitasev <mitasev@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#570529}
-
Miguel Casas authored
This reverts commit 4db64ed1. Reason for revert: broke some bots (e.g. Mac FYI Experimental ... Intel) , see: https://bugs.chromium.org/p/chromium/issues/detail?id=848182#c3 Original change's description: > ShapeDetection: Start the minimum implementation of mojom::BarcodeDetection > > The new implementation is based on Mac OS Vision Framework[1] which recognizes > more barcode symbologies, then use the @available(macOS 10.13, *) in the barcode > detection provider to choose different implementation. > > Split original large CL[2] up in smaller subpatches including this CL. > > [1] https://developer.apple.com/documentation/vision > [2] https://chromium-review.googlesource.com/c/chromium/src/+/1088466 > > BUG=848182 > > Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win10_chromium_x64_rel_ng > Change-Id: I5cb8634240a35e52b3c0b696c1ccab9c24cd023e > Reviewed-on: https://chromium-review.googlesource.com/1107493 > Commit-Queue: Junwei Fu <junwei.fu@intel.com> > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570336} TBR=reillyg@chromium.org,mcasas@chromium.org,junwei.fu@intel.com Change-Id: Ibde8b37fea960671a85bbaf8a4bae59614b50eef No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 848182 Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win10_chromium_x64_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1115638Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#570528}
-
Oriol Brufau authored
Unlike 'width' and 'height', 'inline-size' and 'block-size' were not considered to be layout dependent, and thus getComputedStyle could provide a wrong value. BUG=849855 TEST=external/wpt/css/css-logical/logical-box-size.html The test still has some failures because sideways writing modes have not been implemented yet (http://crbug.com/680331). Change-Id: I4ee8ed8b2cd575fb3ddd5226b23c6a4bb843b81f Reviewed-on: https://chromium-review.googlesource.com/1114966 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#570527}
-
Caleb Rouleau authored
When you send --remote-debugging-port=0 to Chrome, devtools chooses its own port and writes it to chrome::DIR_USER_DATA as a file named "DevToolsActivePort". Cast doesn't have a user data dir, so this CL writes the file to chromecast::DIR_CAST_HOME. The ability to specify a 0 as the port is needed to avoid the race condition of some other process binding to a port that you choose before Chrome gets a chance to bind to it. ChromeDriver switched to using DevToolsActivePort to fix a race condition: https://bugs.chromium.org/p/chromedriver/issues/detail?id=2161 ChromeDriver does not natively work with cast_shell, but you can pass a shell script as the chrome binary to ChromeDriver and then have the shell script write a symbolic link from DevToolsActivePort in the user-data-dir flag value that ChromeDriver provides to the DIR_CAST_HOME directory. Therefore, this change allows cast_shell to work with ChromeDriver again. Note that the "Devtools started: port=X" log is not needed since DevTools code logs something like "DevTools listening on ws://0.0.0.0:45447/devtools/browser/665edec7-dbee-4547-816e-1d5e0c4a5dd3" already. Bug: 854864, chromedriver:2161 Change-Id: I55c20881607d581f628840cdf906569807f541ca Reviewed-on: https://chromium-review.googlesource.com/1114378 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570526}
-
Vaclav Brozek authored
If Chrome sees a username-less form being submitted on an origin, and has exactly one pair of credentials stored for that origin, it offers the user to update that pair with the new password, as a convenience. However, if the only credential is stored for a PSL-related (having the same eTLD+1) but different origin, this update should not be offered. There is much less chance that the old credential and the new password actually represent the same account. Also, saving PSL-related credentials has the side effect of skipping the confirmation prompt, so such update happens without user confirmation. That's bad, because it led to overwriting useful credentials (see the attached bug). Therefore, this CL removes PSL-matching credentials from the list of candidates to be updated. Bug: 856543 Change-Id: Ibb77eaf5bf22d5865b83edd0bbd1bc6e02c41107 Reviewed-on: https://chromium-review.googlesource.com/1114740 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#570525}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 21d4c7bb. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20259 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I2b5d323e2bdfb21a1b850f7d2549d71ae8f642bf Reviewed-on: https://chromium-review.googlesource.com/1115459 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#570524}
-
Evan Stade authored
Extension apps already use DefaultFrameHeader and packaged apps should do the same (and already do in classic Ash). This patch also fixes layout of non-app, non-tabbed browser windows, i.e. popup windows, in Mash. Bug: 854704 Change-Id: Id80a06cbd6d0489efd0761421909c9b4ec06c263 Reviewed-on: https://chromium-review.googlesource.com/1115344 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
Zhongyi Shi authored
Bug: 843299 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I943bbc01880a0a8c81cdcef16b884d0fdc89f55e Reviewed-on: https://chromium-review.googlesource.com/1112670 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
-
rbpotter authored
Bug: 855264 Change-Id: I3f4b42c193f5d62d6858b60b412c4c46e36d8b1f Reviewed-on: https://chromium-review.googlesource.com/1113915Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#570521}
-
Karan Bhatia authored
This CL unifies more of the JSON ruleset indexing code used by the SandboxedUnpacker and UnpackedInstaller. In particular, the JSON parsing of the ruleset is now handled by declarative_net_request::IndexAndPersistRules and declarative_net_request::IndexAndPersistRulesUnsafe. This is useful since subsequent usages of JSON ruleset indexing need to be added. (for example on indexed ruleset corruption). Also, no longer delete any existing file at the indexed ruleset path for packed extensions. It's not necessary since these would be overwritten anyway while ruleset indexing. BUG=852058 Change-Id: Ic0718c03f7e056dfbb0e034f1dfafa3b52a0f03f Reviewed-on: https://chromium-review.googlesource.com/1098526 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570520}
-
rbpotter authored
Bug: 856156 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I0b9470bdd7318300f68d3df615c3b21955d156b8 Reviewed-on: https://chromium-review.googlesource.com/1115206Reviewed-by:
-
Daniel Vogelheim authored
Bug: 751996 Change-Id: Ibd6624f9ee940f25d09287433d924e1223793365 Reviewed-on: https://chromium-review.googlesource.com/1111997Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#570518}
-
Francois Doray authored
Previously, when an event could cause a state transition (e.g. change of tab visiblity, tab finishes loading...), we called TabManager::PerformStateTransitions() synchronously. Unfortunately, the call wasn't always made in a context where performing the state transition was safe (e.g. can't discard when we are doing a tab switch, because both the tab switch and the discard touch the TabStripModel). With this CL, we schedule asynchronous calls to PerformStateTransitions() when an event could cause a state transition instead of calling it synchronously, to ensure that state transitions always occur in a safe context. Bug: 855053 Change-Id: I5c4f00fb9c4b58393ea7792a05f588614c68f62c Reviewed-on: https://chromium-review.googlesource.com/1115367 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#570517}
-
Xiaocheng Hu authored
According to spec (https://drafts.csswg.org/css-ui/#ellipsing-details): "The UA should dispatch any pointer event on the ellipsis to the elided element, as if text-overflow had been none." Current layout test fast/css/text-overflow-ellipsis-vertical-hittest.html asserts that hit testing on ellipsis doesn't hit the elided text node. This patch changes its baseline to match the spec. It also marks it as failure in legacy layout and pass in LayoutNG. Bug: 855279 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I41e41a1072578330b7dbdf08e153d2022f59b79d Reviewed-on: https://chromium-review.googlesource.com/1114280 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#570516}
-
Martin Kreichgauer authored
This updates the implementation of isUserVerifyingPlatformAuthenticatorAvailable to call TouchIdAuthenticator::IsAvailable on macOS >10.12.2. The method returns true on supported hardware if Touch ID is available and enrolled. Also move the __builtin_available guards checking for a minimum macOS version *inside* the TouchIdAuthenticator class to make the interface less clunky. Bug: 803842, 678128 Change-Id: Iea2600767b872660debf7d5a807e13f99132d4ec Reviewed-on: https://chromium-review.googlesource.com/1112800 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#570515}
-
edchin authored
Since iOS 9, table views automatically shorten their width and center content on large iPads so that the content is more readable in larger screens. The cell separator is following the shortened width on recent tabs in tab grid. This CL makes the separator fit the whole table. Screenshot: https://drive.google.com/open?id=12CFWGsy9KQ7vPZINT-mBZkJzhHVy_PXL Bug: 855115 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iaa56257c56c511a0cb315e579737396c7e5e3c78 Reviewed-on: https://chromium-review.googlesource.com/1115473Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570514}
-
Ehsan Karamad authored
Reasons for adding the bool memeber to Document class: * Feature policy is set and maintained the same throughout the lifetime of a document * To get feature state using Frame::IsFeatureEnabled is a bit costly as it involves checking all the origins mentioned for the policy. * Vertical scroll policy is checked quite frequently (e.g. for all wheels and touch starts) * Removes a few lines of code (more readable) Bug: none Change-Id: I7095801689aa90acc2f429643804e002cffbdc25 Reviewed-on: https://chromium-review.googlesource.com/1108342 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:Ian Clelland <iclelland@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#570513}
-
Eric Stevenson authored
Without it the --cloud option is broken. Change-Id: I86c4a6c1975904e3d1944cb4daf50c6cbd833cd5 Reviewed-on: https://chromium-review.googlesource.com/1115502Reviewed-by:
-
