- 16 Mar, 2018 40 commits
-
-
John Abd-El-Malek authored
Bug: 769401 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ia9ad46583b00f88631eccbc65c23cf6864134f26 Reviewed-on: https://chromium-review.googlesource.com/965921Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#543837}
-
CrystalFaith authored
Sample extension that displays users top sites on new tab. Includes button that triggers optional permission request/ shows warning. Bug: none Change-Id: Ib590b1d94773ba25dcbddd79d5f9be2de84aabf7 Reviewed-on: https://chromium-review.googlesource.com/920644 Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#543836}
-
Gabriel Charette authored
Trace event left behind after matching TRACE_EVENT_BEGIN was removed in https://chromium-review.googlesource.com/c/chromium/src/+/941264/26/content/browser/browser_main_loop.cc R=jam@chromium.org Bug: 815225 Change-Id: I5c1e2d94429e1b6366662ab01cda614a7246a4b3 Reviewed-on: https://chromium-review.googlesource.com/966933Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#543835}
-
Gabriel Charette authored
Missing includes are blocking a bigger upcoming change that removes browser_thread.h from other places which tend to have a far reach. This removal was done by a script which adds browser_thread.h if the file has "BrowserThread::" on a line which isn't a comment. If the file is a header it also substracts the include from matching .cc file if any. If the file is a .cc it omits the include if it's already in the matching .h Minor exceptions : * files that already included test_browser_thread.h (not doing so broke DEPS as some tests are explicitly allowed to include test_browser_thread.h but no content/public) * chrome/renderer/chrome_content_renderer_client_browsertest.cc (because it violates DEPS already by using BrowserThread:: from content/renderer but this CL doesn't aim to fix tricky use cases) TBR=jam@chromium.org Bug: 815225, 821034 Change-Id: I5274433918c85f26caaa5b99adb990f07222fb99 Reviewed-on: https://chromium-review.googlesource.com/967186Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#543834}
-
CrystalFaith authored
Currently, user interface information is low and scattered. This document will centralize and explain the types and limits to extension UI. Bug: None Change-Id: Ia6acac35fe731b6e76134239202194201e4a9edb Reviewed-on: https://chromium-review.googlesource.com/768621 Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#543833}
-
Charles Harrison authored
Bug: 167187 Change-Id: I532b689de22a7f2dc5b681074707a4eb00d5ba1e Reviewed-on: https://chromium-review.googlesource.com/966787Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#543832}
-
Andrew Grieve authored
ApplicationStatus ends up pulling in a *lot* of code, because it ends up pulling in all of its listeners. This reduces the main dex size by 3400 methods. To get ApplicationStatus to not be included: * Made @MainDex applicable to methods * Changed ContextUtils and ChromeApplication to annotate methods rather than entire class. * Stopped using mainDexClasses.rules, in order to avoid -keep'ing all of ChromeApplication.attachBaseContext(). Really, all that's needed to be kept is the part of attachBaseContext() before the ChromiumMultiDexInstaller.install() call. Bug: 820570 Change-Id: I39220b99f6d89b2429ba7406619a485179a3b2fc Reviewed-on: https://chromium-review.googlesource.com/963307 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#543831}
-
Saman Sami authored
Instead of dropping fallback every time a tab goes hidden, only drop fallback if size changes when the tab was hidden. Bug: 822442 Change-Id: Ib1ac403f9c76cbb406ca5f85d47f6b789ca9b055 Reviewed-on: https://chromium-review.googlesource.com/965016Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#543830}
-
Jun Choi authored
U2F and CTAP share same BLE GATT service UUID and service characteristics. Furthermore, BLE transport specification for CTAP is a strict superset of U2F BLE transport specifications. All transport specifications including fragmentation, request, and response structure are the same. CTAP protocol simply adds cancel command to the list of commands. Rename all Ble related objects to have Fido as prefix. Bug: 814474 Change-Id: I1978e4b536337e97311cb8c651a8d95256a75c6e Reviewed-on: https://chromium-review.googlesource.com/929805 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#543829}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2d6bcd79..5505a4a1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ife24d9b95fd220c3e75eafd9c93039692a363e7c Reviewed-on: https://chromium-review.googlesource.com/966882Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#543828}
-
Nate Fischer authored
No change to production code. This test was previously modified to anticipate the behavior change for loadDataWithBaseURL (namely, that we now call shouldInterceptRequest) caused by PlzNavigate, with backwards compatibility for the old code path. This removes the support for the old code path, and asserts the new behavior. As with http://crrev/c/820717, this leaves a TODO to actually assert the URL intercepted for the main resource, since this value is not yet finalized. Bug: 822124 Test: run_webview_instrumentation_test_apk -f AwContentsClientShouldInterceptRequestTest#testBaseUrlOfLoadDataSentInRefererHeader Change-Id: I315e1c0c310cda116603ee4026e15d89947760df Reviewed-on: https://chromium-review.googlesource.com/967082Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#543827}
-
Sergio Collazos authored
This reverts commit 44aa3a7f. Reason for revert: Causes crbug.com/819999 Original change's description: > Encapsulate dismissal cleanup within SettingsNavigationController > > Bug: 782943 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: If5ebc06503448526b57f42ea6543b5373efe2c90 > Reviewed-on: https://chromium-review.googlesource.com/826024 > Reviewed-by: Mark Cogan <marq@chromium.org> > Reviewed-by: edchin <edchin@chromium.org> > Commit-Queue: Peter Laurens <peterlaurens@chromium.org> > Cr-Commit-Position: refs/heads/master@{#525372} TBR=marq@chromium.org,edchin@chromium.org,peterlaurens@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 782943 Change-Id: If7daa3faaa515430e5354c9fe0c4654840094696 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/966961Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#543826}
-
erikchen authored
PrerenderContents are destroyed when they use too much memory. They were previously using base::ProcessMetrics, which returns inconsistent results across OSes. This CL changes it to use memory_instrumentation, which returns consistent metrics across all OSes. Bug: 819289 Change-Id: I1b459c2b8838c5ed69c07bf37182ca4e164d7fc3 Reviewed-on: https://chromium-review.googlesource.com/966598Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#543825}
-
Ramin Halavati authored
Traffic annotation that is provided to create HttpProxyClientSocketWrapper, is passed to RequestStream for QuicChromiumClientSession. Bug: 6566607 Change-Id: I2127334706fa4fb66546ac0e89428f19994e7977 Reviewed-on: https://chromium-review.googlesource.com/966185 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#543824}
-
Kevin McNee authored
Bug: 818214 Change-Id: I9be587ea88ae50809e8d09f18133e38db02d7ee5 Reviewed-on: https://chromium-review.googlesource.com/967014 Commit-Queue: Kevin McNee <mcnee@chromium.org> Commit-Queue: Nick Carter <nick@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#543823}
-
Xi Han authored
This is a follow up to CL (https://chromium-review.googlesource.com/c/chromium/src/+/941264). LazySingleThreadTaskRunner allows the created single-thread task runner be be recycled in unittests. Bug: 815225 Change-Id: I70402798883f3550aced26ef07d48d8e882967f4 Reviewed-on: https://chromium-review.googlesource.com/964782Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#543822}
-
https://pdfium.googlesource.com/pdfium.git/+log/7d75650672a8..9d7c7ff0a5f0 $ git log 7d7565067..9d7c7ff0a --date=short --no-merges --format='%ad %ae %s' 2018-03-16 thestig Make more variables const-ref. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I53fba8807cedd17fdad810e64af595df15c3284c Reviewed-on: https://chromium-review.googlesource.com/967104 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543821}
-
Albert Chaulk authored
Previously the API build targets from //extensions/shell were used to simplify the porting process. As we will be needing to extend this with custom features this moves the shell API build files and changes them to be correct for chromecast This also adds content_scripts from chrome and custom cast_url manifest features to match the removed code Bug: b/73383411 Test: Load local extension verify things still work Change-Id: I4e3a08e463ed7560c93ac45d7a4295dfdca8e4d4 Reviewed-on: https://chromium-review.googlesource.com/963074 Commit-Queue: Albert Chaulk <achaulk@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#543820}
-
Aaron Leventhal authored
Bug: 819350 Change-Id: I244117aa25f5da865af5d3d8492079337b3f9696 Reviewed-on: https://chromium-review.googlesource.com/964244 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#543819}
-
Tommy Steimel authored
This CL modifies the modern media controls CSS to have a larger timeline in order to match the new mocks. Bug: 814958, 817303 Change-Id: I049dbc2042d5af4b45d799ddd9f14881a6f0cc03 Reviewed-on: https://chromium-review.googlesource.com/963840Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#543818}
-
CrystalFaith authored
Updated description for clarity. Bug: 740432 Change-Id: Ic7c8c7f96738d77c7b188e0b08d637f97b7bc31f Reviewed-on: https://chromium-review.googlesource.com/957864Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Cr-Commit-Position: refs/heads/master@{#543817}
-
Calder Kitagawa authored
In trying to port Zucchini to build elsewhere a -Wshadow error occurred this is a fix for that. Change-Id: I8534756e8ee675704e7468bf5512b4e45ec599de Reviewed-on: https://chromium-review.googlesource.com/967110Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@google.com> Cr-Commit-Position: refs/heads/master@{#543816}
-
Peter Boström authored
Adds material-refresh to top-chrome-md under chrome://flags for upcoming Material style changes. Bug: chromium:822040 Change-Id: Ibc5ce5ead8462a56f04b80b637406d5726665c09 Reviewed-on: https://chromium-review.googlesource.com/961275 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#543815}
-
CrystalFaith authored
Mappy used deprecated APIs. Updated sendRequest and onRequest to sendMessage and onMessage. Bug: 808592 Change-Id: I52a24f12d16cfde1bab8f9729bfe996ba97a356d Reviewed-on: https://chromium-review.googlesource.com/907214Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Cr-Commit-Position: refs/heads/master@{#543814}
-
Ian Kilpatrick authored
See intent: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/pfDg-VAeKWs This makes new formatting contexts behave exactly like floats would when they are positioned. I.e. they don't look at the shape-outside of the float, and instead as positioned for their margin box. I've added a .tentative test as per the intent. This will allow us to have a (relatively) simple implementation of css-shapes in LayoutNG as we only have to consider the shape area for line-boxes. \o/ Bug: 820520 Change-Id: Ib07600a291eb4838675a9a1068c5fc16cac0633f Reviewed-on: https://chromium-review.googlesource.com/739961 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#543813}
-
Marijn Kruisselbrink authored
Bug: 777879, 821878 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I1bbc4db1fc665ab1844780c4d689d7a8ab0d044c Reviewed-on: https://chromium-review.googlesource.com/967111 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#543812}
-
Matt Menke authored
This currently seems to work, but isn't a great idea, and the code isn't expecting another callback after that point, anyways. Bug: 821067 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I57a7cd5b71d1859c72a1dcbf76fba3f68943e45f Reviewed-on: https://chromium-review.googlesource.com/966986 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#543811}
-
Helen Li authored
This CL moves a few mojo types out of url_loader.mojom so they can be shared (e.g. with the new tls socket APIs). Bug: 721401 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ie613dc08b32eb0541ef43137dee1ac4f515cc078 Reviewed-on: https://chromium-review.googlesource.com/962991Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#543810}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 177e20da. With Chromium commits locally applied on WPT: d42a5bc8 "bluetooth: FakeBluetoothChooser stub impl." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13880 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: chongz@chromium.org, garykac@chromium.org: external/wpt/staticrange dcheng@chromium.org, scottmg@chromium.org: external/wpt/domxpath kojii@chromium.org: external/wpt/css/css-scoping ksakamoto@chromium.org: external/wpt/resource-timing meade@chromium.org: external/wpt/web-animations rego@igalia.com: external/wpt/css/css-grid TBR=lukebjerring No-Export: true Change-Id: I26ed6baee62d9b9797384c328f5a676c0912c19d Reviewed-on: https://chromium-review.googlesource.com/966889 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#543809}
-
David Bokan authored
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I5994c5a3fc087c80441009ac1316752f1cfafff6 Reviewed-on: https://chromium-review.googlesource.com/964719Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#543808}
-
Marijn Kruisselbrink authored
This makes it simpler to create a DataPipeGetter out of a Blob, and also ensures that a blob that is used as the body of a request can still be read even after the process that created the DataPipeGetter (i.e. the renderer that initiated the fetch) dies. Bug: 821878, 761117 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I519a6061900f4cb29b786b8445dc14f034959e27 Reviewed-on: https://chromium-review.googlesource.com/963088 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#543807}
-
Chandan Padhi authored
This CL also makes the WebRTC UMA utility available in Blink for features that have been migrated from content/renderer. UMA histograms for MediaDevices.enumerateDevices() got removed while migrating it from content to blink in https://crrev.com/c/808128. This CL restores the same. Bug: 821331 Change-Id: Iaba8ede9cfe36dfde0f6d18203f09be42bd15061 Reviewed-on: https://chromium-review.googlesource.com/961778Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Cr-Commit-Position: refs/heads/master@{#543806}
-
Richard Bustamante authored
The test testLitePageBTFWithoutFallback is failing due passing in the "alt1" experiment which is the basic team food experiment and will return a stale preview. The test is expecting a lite page, the experiment needs to be changed to alt6 which will force lite page. Bug: 822863 Change-Id: I657ab3d08c6d40c224ca190434eb37bdf1a102d0 Reviewed-on: https://chromium-review.googlesource.com/967147Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Richard Bustamante <bustamante@google.com> Cr-Commit-Position: refs/heads/master@{#543805}
-
John Budorick authored
Bug: 799921 Change-Id: Ie1a0773bc7ae23c141b170611ecc1d44acfcf45a Reviewed-on: https://chromium-review.googlesource.com/966861Reviewed-by:
Benjamin Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#543804}
-
David Bokan authored
Selection bounds are sent from Blink to CC as part of a commit cycle so that we can draw touch handles for it. Currently, the selection bounds are relative to the main graphics layer of a CompositedLayerMapping. In the case of a scroller, this will be its clip rect - rather than its scrolling contents layer. Unfortunately, this means that scrolling on the compositor isn't applied as part of the ToScreen transformation on the selection bounds so scrolling wont update the selection bounds location until another Blink commit. This went unnoticed until now because the root layer was not considered a scroller. The page would paint into a document-sized layer and the compositor would provide extra scrolling layers to handle frame scrolling. In this configuration, the ToScreen transformation from the root layer does include the scroll offset. Now that root layer scrolling has been turned on, frame scrolling works much the same as other scrollers. Thus, this shortcoming is seen on frame scrolling also. The solution in this CL is to move the selection bounds rect to be relative to the scrolling contents layer - if one exists. The ToScreen transformation done in CC will correctly compensate for any scroll offset applied in the compositor and touch selection handles stick to the selection as its scrolled. For the CC side, see ComputeViewportSelectionBound in layer_tree_impl.cc Reland Note: This patch makes the RenderedPositionTests run with mock scrollbars. TBR=chrishtr@chromium.org Bug: 812048 Change-Id: Ib9eacd14b75b71b4e0d4f0a9b57416800f9dfb91 Reviewed-on: https://chromium-review.googlesource.com/967001Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#543803}
-
Philip Rogers authored
blink_perf.events.hit-test-lots-of-layers is a microbenchmark of hit PaintLayer::HitTestLayer which uses GeometryMapper. One of the hottest functions is GeometryMapper::LocalToClipRectInternal which creates a lot of FloatClipRects that check FloatRoundedRect::IsZero in their constructor. By inlining the IsZero functions, we get a 3%-4% improvement on the entire benchmark. Bug: 818772 Change-Id: I0fb4c02152b799399aa19d521ba91ed46e326c3c Reviewed-on: https://chromium-review.googlesource.com/966797Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#543802}
-
Sergey Ulanov authored
UDPSocket supports RANDOM_BIND flag which ensures that local port number is allocated randomly. To implement this feature it was previously taking RandIntCallback as one of constructor parameters. That parameter was useful only in tests - in other cases base::RandInt() was always sufficient. Than additional callback adds extra complexity where is can be avoided. Also some platforms (e.g. Fuchsia) allocate port numbers randomly by default. That callback made it impossible to rely on the OS for port random allocation. In this CL: 1. Removed RandIntCallback from UDPSocket constructor. UDPSocket implementations are supposed to generate random port numbers internally. 2. Updated unittests that were relying on this custom RandIntCallback. New RandomBind unittest should be more reliable (see linked bug). TBR=miu@chromium.org, bbudge@chromium.org, mikhail.pozdnyakov@intel.com Bug: 821516 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: If813d9db2ce5a5b0c6cdcfd8670361ccf6836fd8 Reviewed-on: https://chromium-review.googlesource.com/964895 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#543801}
-
Greg Thompson authored
When run using a 64-bit build of python.exe, the tool needs to explicitly look in the 32-bit hive for Chrome's uninstall key. BUG=822448 Change-Id: Icc0274f73411a717878651ec50ad65e7292f3102 Reviewed-on: https://chromium-review.googlesource.com/966444 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#543800}
-
Jun Choi authored
Rename U2fDevice, U2fHidDevice, U2fBleDevice to FidoDevice, FidoHidDevice, FidoBleDevice and change prefix of U2fHidMessageCallback to HidMessageCallback. Bug: 814059 Change-Id: Ia77ade2f571325d177872178eaa2f2995bcf3809 Reviewed-on: https://chromium-review.googlesource.com/927809 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#543799}
-
Karan Bhatia authored
BUG=822752 TBR=guidou@chromium.org Change-Id: I5a2c60b22df4953c8aa207abd90650b86628edf4 Reviewed-on: https://chromium-review.googlesource.com/967019Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#543798}
-