GitLab

This feature was launched to 100 percent stable. This cl removes the
java side of the feature flag.

Bug: 1096011
Change-Id: Ib836eee0e256d541b30ed3ac6bb17324335c1640
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266879
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782932}

Fix for crrev.com/c/2242078 that is reverted here(crrev.com/c/2259150),
because of crbug.com/1098208.

This CL replaces deprecated functions of IdentityServicesProvider with
the newer service getters with profile parameter. Since
HistoryManager runs only in regular mode, this CL always pass
regular profile to IdentityServicesProvider. The code behaviour stays
same as today.

Bug: 1041781, 1075562
Change-Id: Ib1f32ca458c7d2243991d7b4f17af1c8f5c2f78e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262952Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782931}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/837b9c5748eb..b60d96652beb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC droger@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1090082,chromium:1091851
Tbr: droger@google.com
Change-Id: Ib74ee441e24f0265abfe5ae6de3affc20358665e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270421Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#782930}

R=msisov@igalia.com

Bug: 896640
Change-Id: I8a6fcdd87e9bcb622e21bf3e86af185cd0b761f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267418Reviewed-by: Maksim Sisov <msisov@igalia.com>
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#782929}

AddAccountSigninManagerTests were failing due to a missing run
completion. Remove intermediary method that causes this failure.

Bug: 1078815
Change-Id: I1766e593927cd40be318cf66bb67d11f5ed47006
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264057
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782928}

Migrating from MDCInkView to MDCRippleView in IdentityPickerView.
For more details:
https://material.io/develop/ios/components/ink/#migration-guide-ink-to-ripple

Fixed: 1099381
Change-Id: I074db9baabaff9461a456df48498d63089a13cc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267323
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Nohemi Fernandez <fernandex@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782927}

It's not actually used to sync any data because all datatypes have been
migrated, so there is no need to continue persisting the Directory to
disk (sqlite), sparing unnecessary I/O load.

The patch also removes the plumbing for unrecoverable Directory errors,
which are no longer relevant.

Change-Id: I956df6d69d3dbdd466074c9df468a2b7ab629a72
Bug: 923287
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265999Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782926}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/46f8ecc40de9..6580fb3e51cc

2020-06-26 paulirish@chromium.org stylelint: exit gracefully if all affected files are ignored
2020-06-26 changhaohan@chromium.org Add search cancel button to SearchableView
2020-06-26 mathias@chromium.org Add e2e test for fake eval in Console

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1067184,chromium:1083142,chromium:1099603
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I794bf3758a4b7c3784049748e24e75d2a7f919b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270422Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#782925}

Bug: 1089532,1088885,1088884,1088883,1088881,1088800
Change-Id: If98d79e873b32b4037b9535540da7056c9848c66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266898Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782924}

... instead of WebMediaStreamTrack.

This is part of the effort to reduce the needless use of
public Blink APIs (wrappers) within renderer/modules.

BUG=704136
R=guidou@chromium.org

Change-Id: I6e0adab94e65727828893d34444fc2feb8e8304e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256767Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#782923}

This reverts commit b7b42218.

Reason for revert: the tests are flaky. See https://crbug.com/1099636

Original change's description:
> Add location delegation instrumentation tests
> 
> Add some integration tests that runs javascript get geolocations and
> verify results.
> 
> Bug: 1069506
> Change-Id: I368489922b13711b3e9d0f3d800a7cc3172a979c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249372
> Reviewed-by: Peter Conn <peconn@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Commit-Queue: Ella Ge <eirage@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#782422}

TBR=mthiesse@chromium.org,peconn@chromium.org,eirage@chromium.org

Change-Id: I3b143731db0bcbae01f880cd1bb70474f0b32e22
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1069506, 1099636
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270321Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782922}

This reverts commit 3a2a481f.

Reason for revert: This doesn't work because gtest_enable_absl_printers
is declare_arg'd in googletest so in WebRTC we get an error even if
we use declare_default in the .gn file.

Original change's description:
> Add gtest absl deps to the absl component.
> 
> This CL conditionally adds absl/debugging deps to the absl component
> if build_with_chromium=false. This will allow downstream projects to
> use gtest with absl (for pretty printers and matchers) but it will
> remove these dependencies in Chromium to avoid to add static
> initializers.
> 
> When static initializers will be removed, the dependency will not be
> conditional so Chromium will also be able to set
> 'gtest_enable_absl_printers=true'.
> 
> Bug: 1046390
> Change-Id: Ifffea81ba8f7a9412bebc3798e8f79eaff2777d7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262972
> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
> Auto-Submit: Mirko Bonadei <mbonadei@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#782889}

TBR=thakis@chromium.org,mbonadei@chromium.org,danilchap@chromium.org

Change-Id: I808c4b928c98733965276fd49093bfe35b4d9f74
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1046390
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270082Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782921}

R=tmrts@chromium.org, ulan@chromium.org

Open Conversation is a critical user journey for Gmail.

Open first conversation in inbox.

Bug: 1044682
Change-Id: Ia03c9b5799823a203e63ee1357f025b874945e70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246867
Commit-Queue: Benjamin Smith <codesmith@google.com>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782920}

Following a hard-to-reproduce bug report (crbug.com/1098059), this cl
adds logging to monitor if some curve data is invalid.

Bug: 881215
Change-Id: I9b2b099c052ff601a747b4e6241d6cb31b5b3c8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269598
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782919}

shell=True is a security hazard per the Python documentation:
https://docs.python.org/2/library/subprocess.html#frequently-used-arguments

This has 2 effects that required changes in scripts:
1. The shell removes extraneous quotes from arguments, which we now should no
longer include in any argument passed in
2. The shell now requires an array of arguments, rather than a string

Next to that, removal of shell=True is required if we later want to call
the script as part of a GN action.

R=tapted@chromium.org,dpapad@chromium.org

Bug: 1096473
Change-Id: I77e85048e5a6db33035ca774434857170aeaf91e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264365Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782918}

This reverts commit 60d33a56.

Reason for revert: unittests are flaky. See https://crbug.com/1099629

Original change's description:
> Add shutting down process to the Storage and StorageQueue.
> 
> Making that will guarantee, that queue is destructed on the appropriate
> queue only and in order with other asynchronous operations (after them
> all). When the device is shutting down, it won't allow any new asyn
> operations to start.
> This should resolve crbug/1098359.
> 
> Bug: 1098359
> Change-Id: I12fd860778bc8dd7efb1f51f6d878c2cd1dd3256
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268382
> Reviewed-by: Zach Trudo <zatrudo@google.com>
> Commit-Queue: Leonid Baraz <lbaraz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#782828}

TBR=zatrudo@google.com,lbaraz@chromium.org

Change-Id: I63eeb790e5bbd164ed4e7b4884ef5ffe7ba457c4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1098359, 1099629
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270143Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782917}

The whole folder components/sync/notifier was part of the old
invalidations system and can go away:
InvalidationPreferences and InvalidationIntentProtocol were trivially
unused.
InvalidationClientNameProvider/Generator and its implementations were
not fully unused: A global provider instance was set up with a
generator, but it was never actually used.

Bug: 1029481
Change-Id: I490620d1a75e1fa66993788e9b1f1ff79d7fe3a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266957
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Auto-Submit: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782916}

The CL fixes a typo in a CSS selector used in crrev.com/c/2254281, which
caused a bad alignment of the Undo button.

The CL also merges the selector with #undoLabel, which is actually a
leftover that has been around since M78 (crrev.com/c/1729469).

Bug: 1099236
Change-Id: I8315fafd4e4c20be66324d9cc013872066e9f362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266877Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/master@{#782915}

Implement Perfetto's platform abstraction layer using Chrome's
TLS and task runner primitives.

Bug: b/158460267
Change-Id: I2b2653c550db4c6bb8c8e8e325af7693d1bb496b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248559
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782914}

https://chromium.googlesource.com/angle/angle.git/+log/c81da1c809fe..3330d56fbe19

2020-06-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 0f4d5f74f199 to ff825d988fe8 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: cwallez@google.com
Change-Id: I2c65dcd816b7c021ca5f096f254abc7dfa5cb4f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270104Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#782913}

Bug: 1073933
Change-Id: Id5e95549368323ce77fd3d0ff8957e92445b3b4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266255
Commit-Queue: Bartek Nowierski <bartekn@chromium.org>
Reviewed-by: Bartek Nowierski <bartekn@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782912}

Change-Id: I34bf1a3c07c0f3379a50a68bdd7a07c0032dc37a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251999
Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782911}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d15f969132d7..46f8ecc40de9

2020-06-26 sigurds@chromium.org Fix stylelint-config-standard issues in elements/computedStyleWidgetTree.css

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1083142
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ibee786cb29c5c256021f1987c73ab041e586337e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270419Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#782910}

Bug: 1091665
Change-Id: I5487cf88e0b5d60c3a421cce521428adc0822938
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269403
Auto-Submit: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782909}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7be9918fef15..837b9c5748eb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC droger@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: droger@google.com
Change-Id: I952e9866356eb26d3fffb5dcaa6b82eb76d1e1de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270100Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#782908}

This CL removes old ServiceWorkerResponseReader and starts using
new mojofied ServiceWorkerResourceReader in prod code.

Bug: 1055677
Change-Id: I2fb4daf37242535716a0e38c9a89a69de960f37e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256110Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782907}

Verifying local use_x11 && use_ozone build and sending for review
the fixups.

TBR=sky@chromium.org

Bug: 1085700
Change-Id: Idca3d217224339fcf53dfdc4c65fb33c2ecb84b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266672Reviewed-by: Maksim Sisov <msisov@igalia.com>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#782906}

This test is now captured as an e2e test in the DevTools repository:
https://source.chromium.org/chromium/chromium/src/+/master:third_party/devtools-frontend/src/test/e2e/console/console-message-format_test.ts;l=11-21;drc=869374bcab6fa261360d6cd62fd135898274204d

Bug: chromium:1099603
Change-Id: I1e109c0e6d87d38b621acafca41f7e49cc2abe17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270058
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782905}

This patch changes "hit-test-on-text-with-line-height.html" to test all
platforms by using |internals.settings.setEditingBehavior()|.

This patch also adjusts hit points for platform 'mac'.

Bug: 707656
Change-Id: I840cdc7db8de3f5ca695e045fa1fbd862b752056
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269605
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782904}

Roll Chrome Win64 PGO profile from chrome-win64-master-1593129542-2eaae9cac4b4a7ab29032c694ec87a1eba9074ff.profdata to chrome-win64-master-1593151085-cd414c91e242db50072f832cc2413fee8d11ae76.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win64-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: I6194113c51fb3b54a4383dcf8d4ddc5e05d04e6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270106Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#782903}

The test depends on 100 msec timeouts to load and reload
the plugin iframe, and this is the root of flakiness.

Bug: 1090400
Change-Id: I03800d347d864a4032c784b0888509d563640cbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266253
Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782902}

Base code should include base_tracing.h instead of trace_event impl
headers, so that base can build with enable_base_tracing = false.

Previously, a presubmit check emitted a warning if a trace_event
implementation header was included outside trace_event implementation
directories. This modifies the warning into an error, which can be
bypassed via a source code comment.

TBR: rsesek@chromium.org
Bug: 1093406
Change-Id: Ic82f399390ededd12c04ad6005de8f68929bae87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264555Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782901}

For performance, we'd like to define simple methods in class
definitions, but it is difficult for some methods because they need
forward-declared classes' definitions.

This CL moves definitions of such methods from .h to .cc.


Bug: 839389
Change-Id: I8ef040191e6a5c0f30961b43667af200494cb995
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255729
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782900}

The TokenPreloadScanner::StartTagScanner class has its own
LoadingAttrValue enum, and member of this type.

However, we've introduced a more general LoadingAttributeValue enum,
along with a helper method to convert strings to members of this enum.

The StartTagScanner class should use these more general primitives,
as opposed to providing its own.
This is good so that the preload scanner infrastructure does not
accidentally become out-of-sync with other code that uses the more
general LoadingAttributeValue class.

Bug: 1099123
Change-Id: I7a07e17baa722881b10bd55ae28d10976bfae50b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267518Reviewed-by: Dominic Farolino <dom@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782899}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chonggu@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chonggu@google.com
Change-Id: Idda4aadcf1aee4b7c75cc0ea90444edb4ae6ff97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270101Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#782898}

Remove the dedicated Crostini/GuestOs code for fetching icons.  This
code was written before AppService existed to manage icons.

When icons are not found for crostini, return the default penguin,
but for Plugin VM, return an empty icon so that AppService will use
its defaults.

Bug: b/158617133
Bug: b/159050715
Change-Id: I0ea16e6b795f8e8cdace315f6c9b500781bd0b73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269619Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782897}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/82270c608217..d15f969132d7

2020-06-26 vidorteg@microsoft.com Service Worker should not be translatable
2020-06-26 wolfi@chromium.org Styling for 'deactivate breakpoints'-button

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1041830
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I46dfb44327dc46b605249e09c97fd1d42a1ec88a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270102Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#782896}

This reverts commit ce6e5f49.

Reason for revert: the test is now flaky. See details in https://crbug.com/1099615

Original change's description:
> [WebAppProvider] Fix test flakiness for AppSorting.
> 
> The test waits for both installations, but this can be flaky as waiting
> for the first installation could hide the second installation. So when
> it waits for the second installation, it already happened.
> 
> This fix only waits for the second installation to prevent this race
> from happening.
> 
> R=​loyso@chromium.org
> 
> Change-Id: I57549f0d1be11e980ecebc6ba7fb8d2ec4e0b7be
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268180
> Auto-Submit: Daniel Murphy <dmurph@chromium.org>
> Reviewed-by: Alexey Baskakov <loyso@chromium.org>
> Reviewed-by: Chase Phillips <cmp@chromium.org>
> Commit-Queue: Alexey Baskakov <loyso@chromium.org>
> Commit-Queue: Daniel Murphy <dmurph@chromium.org>
> Commit-Queue: Chase Phillips <cmp@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#782775}

TBR=cmp@chromium.org,dmurph@chromium.org,loyso@chromium.org

Change-Id: I69984efe4b14b967eeccc4a59f617725bd648339
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1099615
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270178Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782895}

This changes on the approach taken in crrev.com/c/2251571 where we
stopped notifying app service of changes to be consistent with the
fact that we were not registering pvm apps to start with.

Now we register all pvm apps, but we set them not to show in launcher,
shelf, etc. This will allow us to use AppService to manage icons.

Bug: b/158617133
Bug: b/159050715
Change-Id: I5813a3249af20f81229c6829d9c81e56628bdecb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268897Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782894}

This workaround is no longer needed now that there is no
WebMediaPlayerAndroid.

Bug: 1091203
Change-Id: I50aeea360d7b81f65c803c70ca8dc96b413d5e2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263159Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com>
Cr-Commit-Position: refs/heads/master@{#782893}