GitLab

BUG=402134
TEST=gpu_unittests

Review URL: https://codereview.chromium.org/463673002

Cr-Commit-Position: refs/heads/master@{#289603}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289603 0039d316-1c4b-4281-b951-d872f2087c98

This is the GYP version. The GN change was done in
https://chromium.googlesource.com/chromium/src/+/4eebe74dc1fd6d3780180361f75707a6be33c3ce

BUG=400860
TEST=None
R=jamesr@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/468733002

Cr-Commit-Position: refs/heads/master@{#289602}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289602 0039d316-1c4b-4281-b951-d872f2087c98

Adds loading indicator for long distilled pages.

BUG=383630

Review URL: https://codereview.chromium.org/444143002

Cr-Commit-Position: refs/heads/master@{#289601}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289601 0039d316-1c4b-4281-b951-d872f2087c98

The thread watcher appears to be kicking on when we're trying to
remove a handle. Not sure why. This converts some DCHECKs to CHECKs
and fixes handling of the deadline. I suspect none of this will help,
but it's worth a shot.

BUG=399769
TEST=none
R=darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288949

Review URL: https://codereview.chromium.org/454433003

Cr-Commit-Position: refs/heads/master@{#289600}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289600 0039d316-1c4b-4281-b951-d872f2087c98

This issue: https://code.google.com/p/chromium/issues/detail?id=398549,
was difficult to debug because gin/shell/gin_shell_unittest.cc didn't verify
that its input files existed before forging ahead.

The unit test now verifies that the gin_shell and hello_world.js paths
exist before launching the former and loading the latter.


BUG=398549

Review URL: https://codereview.chromium.org/471623002

Cr-Commit-Position: refs/heads/master@{#289599}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289599 0039d316-1c4b-4281-b951-d872f2087c98

Disable MigrationSingleClientTest.AllTypesIndividually* since they're timing out sometimes on Windows

BUG=403778
TBR=akalin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/471993002

Cr-Commit-Position: refs/heads/master@{#289598}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289598 0039d316-1c4b-4281-b951-d872f2087c98

Before this patch, when register() fails to install a worker, it would
result in ServiceWorkerRegistrationHandle::OnRegisterFailed nulling out
its reference to the registration in order to allow the registration
to die. This was flawed for two reasons:
- When the handle is destructed, it would dereference the null pointer.
- SWRegistrationHandle is responsible for listening for ref count changes from
Blink-side about the corresponding JavaScript ServiceWorkerRegistration object.
It's a weird state for Handle to forget about the Chromium-side registration
while Blink-side is alive. The Chromium-side Registration lifetime should be
tied to Blink's.

BUG=384119, 396400

Review URL: https://codereview.chromium.org/461233004

Cr-Commit-Position: refs/heads/master@{#289597}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289597 0039d316-1c4b-4281-b951-d872f2087c98

This reverts https://src.chromium.org/viewvc/chrome?revision=288555&view=revision

It caused ASAN failures on the Blink Linux ASAN bots.

BUG=403412,400158

Review URL: https://codereview.chromium.org/470683002

Cr-Commit-Position: refs/heads/master@{#289596}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289596 0039d316-1c4b-4281-b951-d872f2087c98

of pending transactions for PUT/DELETE operations independently.
It means that both counters counts the operation for the entry, if an entry is put and deleted.


BUG=347425
TEST=./unit_tests --gtest_filter="LevelDBWrapper*"

Review URL: https://codereview.chromium.org/466373004

Cr-Commit-Position: refs/heads/master@{#289595}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289595 0039d316-1c4b-4281-b951-d872f2087c98

GL drivers are allowed to generate errors when NaN is supplied to
functions under GLES 3.0 section 2.1.1 or OpenGL 4.5 section 2.3.4.1.
NVIDIA OpenGL driver generates an error when NaN is supplied to
glLineWidth. Make this behavior consistent for Chromium, which removes
the possibility of drawing with an undefined line width, and makes sure
that errors don't leak from the GL driver.

BUG=402847
TEST=WebGL conformance tests on debug build with virtual contexts,
gpu_unittests

Review URL: https://codereview.chromium.org/469673003

Cr-Commit-Position: refs/heads/master@{#289594}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289594 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402811

Review URL: https://codereview.chromium.org/454083002

Cr-Commit-Position: refs/heads/master@{#289593}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289593 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403033

Review URL: https://codereview.chromium.org/467853002

Cr-Commit-Position: refs/heads/master@{#289590}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289590 0039d316-1c4b-4281-b951-d872f2087c98

Using EXPECT_EQ(false, condition_expr) assertion gets the following error with gcc 4.8.x toolchain on linux
when building unit test:

error: converting ‘false’ to pointer type for argument 1 of ‘char testing::
internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Werror=conversion-null]

It is a mysterious problem occurred in gtest. Only EXPECT_EQ(false, condition_expr) cause the compile error, while EXPECT_EQ(true, condition_expr) can work well.

BUG=139326
TBR=rkc@chromium.org

Review URL: https://codereview.chromium.org/474773003

Cr-Commit-Position: refs/heads/master@{#289586}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289586 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403338

Review URL: https://codereview.chromium.org/469863002

Cr-Commit-Position: refs/heads/master@{#289585}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289585 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289582}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289582 0039d316-1c4b-4281-b951-d872f2087c98

See https://codereview.chromium.org/465283003/ for
actual changes. Note: GYP only change.

Review URL: https://codereview.chromium.org/472593002

Cr-Commit-Position: refs/heads/master@{#289581}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289581 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403775
TBR=liyanhou@chromium.org

Review URL: https://codereview.chromium.org/471983002

Cr-Commit-Position: refs/heads/master@{#289580}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289580 0039d316-1c4b-4281-b951-d872f2087c98

This implements connect, disconnect, getInfo, update, getControlSignals,
setControlSignals, flush, setPaused and getConnections.

BUG=389016

Review URL: https://codereview.chromium.org/423403002

Cr-Commit-Position: refs/heads/master@{#289578}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289578 0039d316-1c4b-4281-b951-d872f2087c98

BUG=390086

Review URL: https://codereview.chromium.org/460113005

Cr-Commit-Position: refs/heads/master@{#289577}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289577 0039d316-1c4b-4281-b951-d872f2087c98

- Remove "of this user" from the supervision disclaimer.

In the profile list in about:settings:
- Change the SU label from "Supervised user" to "Supervised"

In the create profile overlay:
- Hide the "import existing supervised user" link if the current user is signed in, but has no supervised users.
- Remove "sign in to import SUs" label.
- Change strings.

BUG=400744,403290,403293,403295

Review URL: https://codereview.chromium.org/445003002

Cr-Commit-Position: refs/heads/master@{#289576}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289576 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403774
TBR=michaeln@chromium.org

Review URL: https://codereview.chromium.org/474993002

Cr-Commit-Position: refs/heads/master@{#289575}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289575 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=isherman@chromium.org,asvitkine@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/470933002

Cr-Commit-Position: refs/heads/master@{#289574}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289574 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402190
TBR=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/477523003

Cr-Commit-Position: refs/heads/master@{#289573}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289573 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401226
TBR=rdevlin.cronin@chromium.org

Review URL: https://codereview.chromium.org/474953003

Cr-Commit-Position: refs/heads/master@{#289572}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289572 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds the json file containing test_spec for linux_browser_asan.

BUG=399730
NOTRY=true

Review URL: https://codereview.chromium.org/471963002

Cr-Commit-Position: refs/heads/master@{#289571}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289571 0039d316-1c4b-4281-b951-d872f2087c98

This reduces cycle time by about 15 seconds and has the desirable property that
it prevents developers from doing anything racy with a Wait. Waits should only
be used for a period of perf measurement like smoothness, energy, etc. They
shouldn't be used to wait for some condition to be true.

BUG=388256

Review URL: https://codereview.chromium.org/473703002

Cr-Commit-Position: refs/heads/master@{#289570}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289570 0039d316-1c4b-4281-b951-d872f2087c98

Currently the UMA tells us whenever audio/video is bypassed as collateral damage of a short bypass. 
We want to know when audio or video is the cause of a bypass so we now report to 
DataReductionProxy.BypassedBytes.ShortTriggeringRequestAudioVideo when audio or video triggers a bypass.

BUG=401257

Review URL: https://codereview.chromium.org/447933002

Cr-Commit-Position: refs/heads/master@{#289569}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289569 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403687
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/471003002

Cr-Commit-Position: refs/heads/master@{#289568}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289568 0039d316-1c4b-4281-b951-d872f2087c98

If you both deleted the computed_hashes.json and modified the
verified_contents.json so that the signature failed, we'd never fix it.
This patch changes things so that we validate the verified_contents.json
instead of just assuming that the file existing means it's contents are
ok.

BUG=402727
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/465333003

Cr-Commit-Position: refs/heads/master@{#289567}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289567 0039d316-1c4b-4281-b951-d872f2087c98

After below CLs, the check is unnecessary, because for linux_chromeos,
if no extension background pages, key events won't be blocked by IMF.

https://codereview.chromium.org/433163005/
https://codereview.chromium.org/444523003/

BUG=None
TEST=Verified on linux_chromeos.

Review URL: https://codereview.chromium.org/462383003

Cr-Commit-Position: refs/heads/master@{#289566}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289566 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402935
TEST=Verified on Pixel.

Review URL: https://codereview.chromium.org/466223004

Cr-Commit-Position: refs/heads/master@{#289565}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289565 0039d316-1c4b-4281-b951-d872f2087c98

R=dalecurtis@chromium.org,brettw@chromium.org
BUG=354261

Review URL: https://codereview.chromium.org/471753002

Cr-Commit-Position: refs/heads/master@{#289564}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289564 0039d316-1c4b-4281-b951-d872f2087c98

BUG=398612

The value of proxy action name also changes from K to L release. Fix it.

Review URL: https://codereview.chromium.org/473613002

Cr-Commit-Position: refs/heads/master@{#289563}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289563 0039d316-1c4b-4281-b951-d872f2087c98

This CL updates the size of the new avatar button that is needed after updating the resources in this CL:
https://codereview.chromium.org/462043003/

BUG=395798

Review URL: https://codereview.chromium.org/460233003

Cr-Commit-Position: refs/heads/master@{#289562}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289562 0039d316-1c4b-4281-b951-d872f2087c98

BUG=397738,397734

Review URL: https://codereview.chromium.org/465183002

Cr-Commit-Position: refs/heads/master@{#289561}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289561 0039d316-1c4b-4281-b951-d872f2087c98

The MessageLoop has some code for adding debug annotations such as trace
flows and memory usage tags to posted tasks. Since we want to use these
annotations more generally for tasks that are scheduled outside the base
message loop, this patch factors it out into a standalone class.

TEST=TaskAnnotatorTest
BUG=391005

Review URL: https://codereview.chromium.org/455833004

Cr-Commit-Position: refs/heads/master@{#289560}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289560 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289559}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289559 0039d316-1c4b-4281-b951-d872f2087c98

Originally landed as 289216 and reverted as 289223 due to a GYP bug.

BUG=401761

Review URL: https://codereview.chromium.org/401453002

Cr-Commit-Position: refs/heads/master@{#289558}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289558 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sergeyu@chromium.org

BUG=

Review URL: https://codereview.chromium.org/475683002

Cr-Commit-Position: refs/heads/master@{#289557}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289557 0039d316-1c4b-4281-b951-d872f2087c98

Previously, we were having Summary take a boolean had_failures. Now that
failures are part of Telemetry's value system, it is easy to have Summary
reason about how to summarize values when failures and/or skips are present.
This CL is the first step: it eliminates had_failures from being passed around
and instead computes it directly based on the presence of failures in the
passed list of page-specific values.

Review URL: https://codereview.chromium.org/465063002

Cr-Commit-Position: refs/heads/master@{#289556}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289556 0039d316-1c4b-4281-b951-d872f2087c98