- 27 Apr, 2019 40 commits
-
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I0d417aa83e71bc9f78aeba2384bc5df46962358c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586523Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654727}
-
James Hollyer authored
Mac OS is now preventing applications from being able to see Wifi Access Point MAC Addresses if location services are turned off. We did not have a check for this and we were assuming that if we got an access point then it would have a MAC Address. This caused bad requests to be sent to the Location API. This CL added in a check so that we do not include access points without MAC Addresses in the request body. Bug: 956376 Change-Id: Ifa67e8e1e025f8b75087c68751f5bc544d910566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583587Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#654726}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a32d6303a613..28f142f1b0a2 git log a32d6303a613..28f142f1b0a2 --date=short --no-merges --format='%ad %ae %s' 2019-04-27 swiftshader.regress@gmail.com Regres: Update test lists @ a32d6303 Created with: gclient setdep -r src/third_party/swiftshader@28f142f1b0a2 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: Id55fa6fd387c040ebc7b5908b6a13b7888833f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586520Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c3ba2e82..df395535 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie264d4aa667fb3b367f4ec39e16b221df271d406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586517Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654724}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ffa3433a8c08..e6d08137f66c git log ffa3433a8c08..e6d08137f66c --date=short --no-merges --format='%ad %ae %s' 2019-04-27 benjhayden@chromium.org Add JsTsMonHandler to dashboard Created with: gclient setdep -r src/third_party/catapult@e6d08137f66c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:867060 TBR=eyaich@chromium.org Change-Id: I6aee4df66d33e272112e58f125f2d53d85fcd98d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586519Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e178c0586cd6..d7082a5805c8 git log e178c0586cd6..d7082a5805c8 --date=short --no-merges --format='%ad %ae %s' 2019-04-27 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@d7082a5805c8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: I6ea4e8bc0886670cb41a94e575b1e3ef4bc8f852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586722Reviewed-by:
-
Vlad Tsyrklevich authored
Previously we were compiling sampling_allocator_shims* even if use_allocator_shim=false, but we simply excluded calls to the missing symbols if so. This is incorrect because we should not even be including base/allocator/allocator_shim.h or referencing its types in that case. Change the build to only build sampling_allocator_shim* if use_allocator_shim=true and print a warning message in gwp_asan.cc if upstream users try to enable GWP-ASan for malloc() otherwise. Bug: 956824 Change-Id: Icfa7adbbcb6647b1a61b5391352c3c6208f1a4e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586544 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#654721}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ce903c4c1357..fcea8c13bfa1 Created with: gclient setdep -r src-internal@fcea8c13bfa1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=andruud@chromium.org,alexmos@chromium.org,horo@chromium.org,adithyas@chromium.org Change-Id: I9be24446c5b2c48a574efa1348938a15131d03f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586720Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654720}
-
Dominick Ng authored
This ensures that ArcAppsPrivateApiTest.* browser tests pass with the App Service + App List integration enabled. Prior to this CL, the tests failed because the App Service was being shut down while there were in-flight LoadIconCallbacks from the ArcApps publisher. There were in-flight callbacks because the connection to ARC had been shut down. This CL also adds the AppServiceProxy as a dependency of the AppListSyncableService. BUG=826982 Change-Id: I113b895fc59787c0b782785c8152121580441397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585404Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#654719}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4799d13aa0fb..ce903c4c1357 Created with: gclient setdep -r src-internal@ce903c4c1357 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=andruud@chromium.org,alexmos@chromium.org,horo@chromium.org,adithyas@chromium.org Change-Id: I4fec89dae2f200c3f75c4c309f971edc5ecae4d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586719Reviewed-by:
-
Fergus Dall authored
Currently, spinners appear in the shelf on all profiles and will only go away if the app window opens when you are on the profile that owns that window (currently, this is always the primary profile). This CL changes this behaviour so that spinners are associated with a profile and hidden when other profiles are active, and are closed at the right time. Bug: 846213 Change-Id: Iaf9447eed491d956831b8f5b30a95cd7d6f5b288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504667Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#654717}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/8bceb48c2222..ae6ebf06c7e8 git log 8bceb48c2222..ae6ebf06c7e8 --date=short --no-merges --format='%ad %ae %s' 2019-04-27 thestig@chromium.org Fix CFXJSE_FormCalcContext::Substr() behavior. 2019-04-27 thestig@chromium.org Beef up CFXJSE_FormCalcContextEmbedderTest.Substr Created with: gclient setdep -r src/third_party/pdfium@ae6ebf06c7e8 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:956985 TBR=dsinclair@chromium.org Change-Id: I7a2403f3fbf4afa1f917717f19c4f195b244f025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586717Reviewed-by:
-
Ryan Hamilton authored
Change-Id: Ic8db4fbaaf01bc24351753c87562e015cc59f825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586320 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#654715}
-
Mounir Lamouri authored
Bug: 951548 Change-Id: Ice27c1c114f9bb3e93f5516fb964a78f8d43a637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585293 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#654714}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c6130f7f5dc8..4799d13aa0fb Created with: gclient setdep -r src-internal@4799d13aa0fb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=andruud@chromium.org,alexmos@chromium.org,horo@chromium.org,adithyas@chromium.org Change-Id: Ie3f8dfee0f72dea41b87e3671ea225ba7ed07873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585334Reviewed-by:
-
Elly Fong-Jones authored
Bug: None Change-Id: Iba8178164ddfb99e4d2ee6236e6d4cb6418890d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585537 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#654712}
-
Jazz Xu authored
Touchless context menu implementation. Implemented fullscreen, mute, download, and captions. Tests will be in follow CL. Bug: 942156 Change-Id: Ifeae091aa0c35cfe989483d230df3bf28bbe23ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585957Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#654711}
-
Darwin Huang authored
Remove unused arguments, to make blink and mojo more "thin" and readable. https://cs.chromium.org/chromium/src/third_party/blink/public/mojom/clipboard/clipboard.mojom?l=62 Bug: 956291 Change-Id: I62a14b7fd3cb35f566a31d3fd5ac43995724534f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582305Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#654710}
-
Sujie Zhu authored
Use the supported_card_bin_range from GDFSC to filter the migratable credit cards for checkout flow. Will abandon the migartion if no supported card left. Will only show the supported card in the main dialog. Bug: 954367 Change-Id: Ic35ca24e5d3d5c018a2f114d59ea587f255d9971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582448 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#654709}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Ibf4b69cefd21c91b941d7810f9a92621df332781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586662Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#654708}
-
Rakib M. Hasan authored
This CL adds validations for test expectations files. One validation makes sure that all test expectations patterns in the file are for existing tests. Another validation makes sure that there are no collisions between expectations in the file. This CL also creates a namespace for the pixel test generator methods Bug: chromium:948891 Bug: chromium:698902 Change-Id: I80c3120113b09d11f4a79db449f73149605b38f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586475Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#654707}
-
Elly Fong-Jones authored
We're planning to remove this flag for reasons thestig will end up documenting :). Bug: None Change-Id: If1cc4dae41ab2ae13778c87aecf4fd8932c66a1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586254 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#654706}
-
Yann Dago authored
Unmanaged browser: http://screen/iSGQc3jemSh Managed browser(no extension, no reporting): http://screen/mBhBmNFFZdm Local reporting: http://screen/J3TuQiOLKRt Cloud reporting: http://screen/BPDRCMM7vJP No Reporting: http://screen/UBDpXm8wgKs Unknown/incognito domain: http://screen/4gLqBq7xrpi Dark mode: http://screen/n64k5C6cWfn Bug: 956561 Change-Id: I7cb4501edce48950e43534616de4caaf716ebb93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584884Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#654705}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3610ded5e409..a32d6303a613 git log 3610ded5e409..a32d6303a613 --date=short --no-merges --format='%ad %ae %s' 2019-04-27 chrisforbes@google.com Support more more formats for input attachments Created with: gclient setdep -r src/third_party/swiftshader@a32d6303a613 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/131171141 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I96cfe0b32b0d1100daa4abaf9aa952983d8c3777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585332Reviewed-by:
-
Dan Beam authored
$i18n{} is used across many other web UI pages in Chrom{e,ium} and is recommended by styleguide/web/web.md. In this case, its also more efficient as it only need make 1 pass in total over the contents of local_ntp.html (current code makes 8). R=kristipark@chromium.org BUG=none Change-Id: Ie839d12322ab4baca8445eeba1a8a47c76d22e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586695 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#654703}
-
Ben Chan authored
The shill.Device.SetCarrier API only works on the modems supported by cromo and it is being deprecated along with cromo. This CL removes all usage of the shill.Device.SetCarrier API from Chrome. Bug: 954634 Change-Id: I9114650783f9c3f848c4012db718ca4caa8f1803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586460Reviewed-by:
-
David Schinazi authored
https://quiche.googlesource.com/quiche.git/+log/43a1c0f10f28..d31f86fa34ef $ git log 43a1c0f10..d31f86fa3 --date=short --no-merges --format='%ad %ae %s' 2019-04-26 dschinazi Add presubmit to force use of QUIC_LOG 2019-04-26 vasilvv Make SimpleRandom faster by using Chacha20 as underlying primitive. 2019-04-26 dschinazi Fixup use of gunit and gmock in QUIC 2019-04-26 fayang gfe-relnote: In QUIC, adjust cwnd when doing bandwidth resumption in BBR. Protected by gfe2_reloadable_flag_quic_fix_bbr_cwnd_in_bandwidth_resumption. 2019-04-26 danzh gfe-relnote: n/a(code not in use) a few changes to improve SimpleLinkedHashMap's portability. 2019-04-25 dschinazi Make QUIC EXPECT and ASSERT test macros reject comparison of unsigned integers Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I2232f1fc7b19184f3af31e04f592c62c27952935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586549 Auto-Submit: David Schinazi <dschinazi@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
-
David Bokan authored
NonFastScrollableRegions are set on the FrameView's scrolling contents layer in order to let the compositor know about scrollers that aren't composited or need forwarding events to the main thread for some reason. This logic breaks when a non-composited subscroller is placed inside the root scroller. The root scroller is always composited and it becomes the layout/outer viewport in the compositor. This means we never actually check the frame view's scrolling layer for NFSRs since we stop walking up the scroll tree once we've scrolled the viewport. This CL fixes the issue by setting the regions on the root scroller's scrolling contents layer, rather than the FrameView's. GetScrollableArea on the root FrameView will return a RootFrameViewport which returns the layout viewport's scrolling layer. Bug: 954496 Change-Id: Ic6ee4273fe7d34a97c60c48f00d0ba4892295953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580219Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#654700}
-
Chris Harrelson authored
DidBeginMainFrame can cause mutations to layer state, and the commit needs to be complete before doing so. Bug: 939342 Change-Id: I078a78879394f999cebe05a2804ac05617a31cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584498 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#654699}
-
John Rummell authored
Also adds a test to verify the behavior. BUG=957138 TEST=new base_unittest passes Change-Id: Ida1d0801f457e96dbf1d2ed299966a50aec05442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586220 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
rbpotter authored
Remove new/ folder, since the old UI code has been deleted, and move all contents to a new ui/ folder or the data/ folder, as appropriate. Bug: 888272 Change-Id: I57e7df9e96a12fce112d18a70c58889587fb6e7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586265Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#654697}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6841244fb6c0..c6130f7f5dc8 Created with: gclient setdep -r src-internal@c6130f7f5dc8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=andruud@chromium.org,alexmos@chromium.org,horo@chromium.org,adithyas@chromium.org Change-Id: I79ac08fe959d178a639b2e0b4a18027b9a64f357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586192Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6f691fbb59c7..1ad7a07212b2 git log 6f691fbb59c7..1ad7a07212b2 --date=short --no-merges --format='%ad %ae %s' 2019-04-26 jonahr@google.com Clean up unexpected passed/failed test behavior for generate_stats Created with: gclient setdep -r src/third_party/angle@1ad7a07212b2 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I15ebacc6a43a0833d64e8235a8a1254be5256cf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586245Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3349fb0195ff..e178c0586cd6 git log 3349fb0195ff..e178c0586cd6 --date=short --no-merges --format='%ad %ae %s' 2019-04-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@e178c0586cd6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: I0f3b0522a4474dca262f6b4b91a52546271b0b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585331Reviewed-by:
-
John Budorick authored
Bug: 861983 Change-Id: I4265612b47bff2799a63cda4cc5c28952446a7ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586469 Auto-Submit: John Budorick <jbudorick@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#654693}
-
Mounir Lamouri authored
Bug: 952090 Change-Id: I0abea411b1dfb60b5d4c6a37b9cd571d70fffa48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585347Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#654692}
-
PKH authored
This CL splits the webapk_java GN template into two targets: 1) webapk_java - Contains most of the source files of the old webapk_java template - Does not depend on compiled_in_runtime_library_java - shell_apk_javatests depends on webapk_java 2) webapk_with_service_java - depends on webapk_java and compiled_in_runtime_library_java BUG=817263 Change-Id: If234e939fc3ba5119dd9290256fab3a34c80b2fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585114 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#654691}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f5c8936c463e..3610ded5e409 git log f5c8936c463e..3610ded5e409 --date=short --no-merges --format='%ad %ae %s' 2019-04-26 chrisforbes@google.com Adjust input attachment index when indexing into array of input descriptors Created with: gclient setdep -r src/third_party/swiftshader@3610ded5e409 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/131171141 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I31ed519038dadcb83b4b9fa650d9a35e970489c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586190Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5fb2ca3384f7..8bceb48c2222 git log 5fb2ca3384f7..8bceb48c2222 --date=short --no-merges --format='%ad %ae %s' 2019-04-26 thestig@chromium.org Fix some nits in CFXJSE_FormCalcContext. Created with: gclient setdep -r src/third_party/pdfium@8bceb48c2222 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic327f49bfda5eb9f492a0cbce6216907e92f8da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586189Reviewed-by:
-
Nigel Tao authored
This commit is part 1 of 2, being a refactor with no change in behavior. There is an existing observer leak (an AddObserver call with no matching RemoveObserver call), but this commit keeps that leak. A follow-up commit will fix the leak. TBR=seantopping@chromium.org Change-Id: I73e9087540949c29bb76d6526362b5448452e182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585403 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#654688}
-
