- 17 Jan, 2020 40 commits
-
-
danakj authored
The UpdateBrowserControlsState IPC requires a main frame to be present and only makes sense for a (local) main frame since that is the single place that has browser controls. This DCHECKs instead of ignoring the IPC to catch and point out logic errors if they exist in the browser. All callers clearly check or are calling the IPC for the main frame already except BFCache which is difficult to tell. The BFCache bot will inform us if there are any tested misuses already, and this DCHECK will prevent future mistakes. R=avi@chromium.org Bug: 419087 Change-Id: Ic91453ab8cbf5d0d575983a82a2cf3a3855e3d8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005814 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#732944}
-
Elly Fong-Jones authored
They are replaced with the new setters. Bug: 1011446 Change-Id: I1c4bcb1853e4ae43d043135bc7f3fbf534aca66f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007649Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#732943}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d092437b81ea..2e5c7edf368f git log d092437b81ea..2e5c7edf368f --date=short --first-parent --format='%ad %ae %s' 2020-01-17 lalitm@google.com Merge "trace_processor: allow selecting rowmaps with smaller rowmaps" 2020-01-17 buss@google.com Merge "Fix compilation on Windows/VSC." 2020-01-17 hjd@google.com Merge "ui: Remove small gap in pinned track container" Created with: gclient setdep -r src/third_party/perfetto@2e5c7edf368f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib8ceb5de792d61f42929d30e6f411fb3435d8238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008168Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732942}
-
Akihiro Ota authored
This change modifies data in ja_phonetic_data.js so disambiguations for characters reflect the character set they originate from, if it is ambiguous. Bug: 1034152 Change-Id: Ife07a64d8bc0e57d1cf30575150c969401ce1926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994524Reviewed-by:
Zachary Kuznia <zork@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#732941}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/cb3f04f584a53844546aaa32e949534c453185aa..89730072b81077cc3e3a973963015b2494d36b1a The following commits have Chromium bugs associated: f22e5fbab Try again to deal with expensive tests. The following commits have update notes: 0df6edff4 Split BN_prime_checks into two constants for generation and validation. Bug: 1042657 Change-Id: I40133ee19fe61595e658fc9adb757ceb61d25ba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007512 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#732940}
-
Sylvain Defresne authored
In preparation of moving ios::ChromeBrowserState to the global namespace, add a header to forward declare ChromeBrowserState. This can be used to change the forward declaration atomically when moving the class without having to change all the clients. Bug: 1042208 Change-Id: I9273f83989390b569b74db771d3b1fc00fe9525a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007415Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#732939}
-
Himanshu Jaju authored
Add Discovery request/response and WebRtcSignalingFrame to SharingMessage protos. Bug: 1043149 Change-Id: I025365006d96c188308b85cc62064d48a6617f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007575Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#732938}
-
Liquan (Max) Gu authored
This CL is to add a test for Expandable Payment Handler UI. Main Change: * add 1 test * add maxpay.com payment app Flag enabled: ScrollToExpandPaymentHandler. With this flag, Payment Request will open the Expandable PH UI instead of the CCT PH UI. Test Steps: 1. install payment app - maxpay.com 2. launch the app 3. when the app is on load, invoke a callback to respond "success" to the PaymentRequest. Bug: 1042892 Change-Id: I8a64a6f892eff8c9ae3c6c98acd948938b7eb173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980187 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#732937}
-
David Black authored
As this is the last usage of Content Service by Assistant, the Content Service-related APIs on AssistantController/AssistantViewDelegate are also cleaned up in this CL. Bug: b:146351046 Change-Id: I852a17630e3d9e3b17b8dfac025648d693004dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006228Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#732936}
-
Steven Bingler authored
In preparation for an upcoming change refactor the warning status to be a bit vector similar to the exclusion reason field. Previously the warning field was an enum which explicitly stated "DO_NOT_WARN", the lack of a warning is now indicated by an empty bit field. All other warnings are indicated by the position of each set bit in the field. Change-Id: I5ffcdbe7bb5c2e558af8e73e22465e1bb6e44e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003223Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#732935}
-
Mathew King authored
If XkbLookup fails and there is no DOM|code|->DOM|key| mapping. This will happen in cases where a DOM|code| exists without a W3C standard DOM|key|. BUG=952051 TBR=wez Change-Id: I63af869118e15c99bcb7cd4cbcb3e58def610334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008049Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Auto-Submit: Mathew King <mathewk@chromium.org> Cr-Commit-Position: refs/heads/master@{#732934}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9293af72309e..a067a830b31a git log 9293af72309e..a067a830b31a --date=short --first-parent --format='%ad %ae %s' 2020-01-17 obrufau@igalia.com [css-pseudo] Handle nested pseudo-elements in devtools tree (front end) Created with: gclient setdep -r src/third_party/devtools-frontend/src@a067a830b31a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:457718 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7153b9b040be3b46c86fdf4eba93dd76f7fb4ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007920Reviewed-by:
-
Mark Pearson authored
Change-Id: I838126917cbd2301ae4609fbc23528ccdb41fb2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006077 Auto-Submit: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#732932}
-
Victor Fei authored
This is a reland of 9612f58a The change was reverted because of failure on linux-trusty-rel due to a mismatch in dump test result for "checkable" state. In this reland, I added a filter @AURALINUX-DENY:checkable to fix this test mismatch. This filter seems to accompany all other radio button dump tests for linux platform. Original change's description: > A11y:Expose labels of radio & checkbox when focused. > > Currently, when a label is referenced by a control of type radio or > checkbox, we set the label as ignored in the AXTree thereby excluding > it from being perceived by ATs. > However, for the case when the control (radio/checkbox) is a > descendant of the label and label is focusable (tabindex="0") but > control is to be omitted from focus (tabindex="-1"), ATs perceive > neither the label nor the control when tabbing through the content: > > <label style="display:block" tabindex="0"> > radio button 1 > <input type="radio" id="radio1" tabindex="-1"> > </label> > > <label style="display:block" for="radio2" tabindex="0"> > radio button 2 > <input type="radio" id="radio2" tabindex="-1"> > </label> > > <label style="display:block" for="checkbox1" tabindex="0"> > checkbox 1 > <input type="checkbox" id="checkbox1" tabindex="-1"> > </label> > > <label style="display:block" for="checkbox2" tabindex="0"> > checkbox 2 > <input type="checkbox" id="checkbox2" tabindex="-1"> > </label> > > This change fixes the above scenario by exposing labels (referenced by > radio or checkbox) when they are focusable. For all other cases when > labels are referenced by radio or checkbox, we keep the existing > behavior of ignoring the label. > > Note: Neither Firefox nor Edge legacy hides a label from AT when the > label is referenced by a control. On Firefox and Edge legacy, label > content will be read twice (focus on label and focus on control > respectively). > WAI-ARIA spec does not specify label should be ignored when associated > with a radio/checkbox control. > > Bug: 1040210 > Change-Id: Ie7df5144dd2f0d285d97e6556adb46dcf2338f25 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992017 > Commit-Queue: Victor Fei <vicfei@microsoft.com> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#731820} Bug: 1040210 Change-Id: I09243796ec3affe648d46ec64d7dd20e20c5893f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002892Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
-
Chase Phillips authored
Bug: 1039869 Change-Id: I4398a8c95cf3c8a818d8655fe037078fe183e0d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003797 Auto-Submit: Chase Phillips <cmp@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#732930}
-
Mustaq Ahmed authored
Bug: 687724 Change-Id: Ib4f2d12d0e6a40b482dddafe0346f9852df6e7ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004504Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#732929}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Id995913e624d185645f7316669c4410405f82a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007918Reviewed-by:
-
Yi Gu authored
Currently we unconditionally iterate all the snap containers to check whether a snap container needs update its data. On a page with lots of snap containers, e.g. youtube.com, this introduces big regression: it adds ~0.2ms to Document::UpdateStyleAndLayout() and LocalFrameView::RunStyleAndLayoutLifecyclePhases() which accounts for ~90% of the total time. Bug: 1042396 Change-Id: I0ef268bd0d5a2f448766059814c6b14bf34ba73a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005822Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#732927}
-
Dominic Battre authored
Unfillable form fields should not label a form as an "Address form". Bug: 1043150 Change-Id: I47916142f32eb36df0c08d6897f2d36de3b86df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007811 Commit-Queue: Dominic Battré <battre@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Auto-Submit: Dominic Battré <battre@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#732926}
-
Xinghui Lu authored
Bug: 1042984 Change-Id: I12c1287f42f39dfab883c2976b7c7ae39441cf7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005906Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#732925}
-
Nasko Oskov authored
The negative wording of IsInvalid makes it harder to read, especially when trying to test the inverse - !IsInvalid. It is easier to read a positively worded method name, so I'm renaming it to IsValid. Change-Id: I50718a2a903138ebe33c36c0afec3d379941f7b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005810Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#732924}
-
Ted Choc authored
CCTs that have been pre-warmed create a Tab prior to the ShareDelegate being available. This switches to passing a Supplier around for late binding access. BUG=1034460 Change-Id: I8127b2928cd8de523683b8fa1a2f1e4bd3f50374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006259 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#732923}
-
llin@chromium.org authored
First usage of this API is Quick Answers in browser process. This CL also added "Quick Answers" as a query source. Bug: 146020947 Test: Manual Change-Id: I0d0b5186471cea3550bce5519e0f9014a8aaa14a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961151 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#732922}
-
Ioana Pandele authored
Bug: 1041374 Change-Id: I64e410eb11f1841ab48dfc142dcee8361089541a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002911 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#732921}
-
Mason Freed authored
The [1] CL enabled the FormControlsRefresh feature by default for Windows, Linux, and ChromeOS. In the process, many layout tests were disabled, because the form controls have a different appearance with the feature enabled. This is one of several patches rebaselining those disabled tests. [1] http://crrev.com/c/1967608 Bug: 1035582 Change-Id: I30e8a7fa14ced59b7e918c86b2acf0dae1aef439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997977 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#732920}
-
Wez authored
The FIDL/JS generator is unused and would likely be re-implemented for integration into the V8 repo, so remove it from Chromium. We can of course refer to the removed implementation thanks to source control! Bug: 1043093, fuchsia:44191 Change-Id: I93db91acef1a31e0e54ec1b9c4348963bd9e5f90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007393 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#732919}
-
Eugene But authored
This CL adds Identity Disk to toolbar view instead of header view. Pull To Action UI uses toolbar view screenshot for fade in and fade out animations, which creates smoother transition experience. Bug: 1022441 Change-Id: Ib6aeecdb04143c362041246897f78eac2e741ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986242Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#732918}
-
Tanmoy Mollik authored
These methods are made non-static so that tests can be created to capture calls to these methods. Bug: 1029322 Change-Id: I72124cd09d154e15c36c30bd00e206e342382e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991632 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#732917}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b46e6c2fa626..4efa82edacaa git log b46e6c2fa626..4efa82edacaa --date=short --first-parent --format='%ad %ae %s' 2020-01-17 syoussefi@chromium.org Vulkan: Avoid INT_MAX resource limits Created with: gclient setdep -r src/third_party/angle@4efa82edacaa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jonahr@google.com Change-Id: Ic324b33b0487490e44398fcdc584ab65d3a59408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007366Reviewed-by:
-
Ben Pastene authored
Currently failing on new CrOS versions, and consequently blocking LKGM updates. Bug: 1042974 Change-Id: I977f1bf825cbcd4c6eea64b95255b9a808a17633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008056Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#732915}
-
Alex Chau authored
Bug: 1043148 Change-Id: Ic0fcfb5dc26b2cfc59acbd15580ff58aa23fe5bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007417 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#732914}
-
danakj authored
Previously it was owned by the RenderViewImpl, in order to let its lifetime extend beyond that of the RenderFrameImpl. Since that is no longer needed, we can move its ownership over to the RenderFrameImpl as it is for other local roots. This gives RenderFrameImpl consistent ownership, creation, initialization, and destruction paths for all frame-based RenderWidgets. The GetWidget() accessor is misleading since it can be null and is dropped. Instead, callers go through GetMainRenderFrame() which is null for more obvious reasons, and get the RenderWidget from there. R=avi@chromium.org Bug: 419087 Change-Id: I268d7ef12e32f5ae131ecc1c7978eb1bc16cadf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005389 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Ian Wells authored
Just prevents reaching the Logger.wtf(). Considering a refactoring of the Feed library is soon to be underway, there's not much point in investigating why the spinner isn't being shown in the first place. Bug: 992570 Change-Id: I693bd57bb60e5396f565a3b8fd8bb2c3cc08d1e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006423 Commit-Queue: Ian Wells <iwells@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Auto-Submit: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#732912}
-
Juanmi Huertas authored
We need a better check if the bounds of the dest rect of the draw image inside canvas is correct, after applying some transformations to a big enough canvas. Bug: 103912 Change-Id: I00558d3d9e5996e2cb822bc6a3cbf5c7a89811d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001249Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#732911}
-
Guillaume Jenkins authored
When I attempted to submit the field trial test for the Windows native spell checker integration, the try bots picked up several crashes in existing tests when the native spell checker flags are enabled in Chrome: https://cr-buildbucket.appspot.com/build/8891251817173916304 The crashes were caused by the use of raw pointers instead of weak pointers, because the SpellcheckHunspellDictionary object was deleted by the time the callback from PlatformSupportsLanguage() was invoked. Change-Id: I8ac2afa9b66a11a2846a086f23d024ce380f77eb Bug: 463364, Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003087Reviewed-by:
-
Michael Crouse authored
This change uses the persisted session FCP mean for the previous page load's FCP when there is no previous page load available. For the first page load of the session, this will always be the case. Bug: 1041664 Change-Id: Ie2666cbcf841ebaa4ad20a2747c92377cf6c451b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999302Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#732909}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b7cd486d..c766f984 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I919f537bb6a276addd551f62e964b8144cbd6ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007769Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732908}
-
Eric Seckler authored
Also includes manual modification to switch to perfetto's EventContext. https://android.googlesource.com/platform/external/perfetto.git/+log/11c11a1a891c..d092437b81ea 2020-01-17 fmayer@google.com Merge "Cleanup of profile related trackers." 2020-01-17 eseckler@google.com Merge "client lib: Add an EventContext constructor for Chrome" 2020-01-17 lalitm@google.com Merge "bazel: Disable warning about unused system_header pragma" 2020-01-17 lalitm@google.com Merge "trace_processor: fix overflow in bitvector" 2020-01-17 taylori@google.com Merge "Make selection default behaviour" 2020-01-17 treehugger-gerrit@google.com Merge "GTEST_EXECUTE_STATEMENT_ is not available on iOS execute the statement directly instead." 2020-01-17 eseckler@google.com Merge "processor: Only fall back to legacy tracks for legacy events" 2020-01-17 treehugger-gerrit@google.com Merge "TrackEvent: Add initial legacy macro support" 2020-01-17 fmayer@google.com Merge "Function for on-demand flamegraph for heap graph." 2020-01-17 treehugger-gerrit@google.com Merge "Turn ingestion DFATALs into DLOG." 2020-01-17 khokhlov@google.com Merge "Exclude targets depending on sqlite from embedder builds" 2020-01-16 ilkos@google.com Merge "Remove symbols that are definitely not obfuscated" 2020-01-16 eseckler@google.com Merge "processor: Export pid/tid as signed integers into JSON" 2020-01-16 lalitm@google.com Merge "trace_processor: fix compile and build on fuzzer" 2020-01-16 joelaf@google.com Merge "Fix precision errors by explicit casting" 2020-01-16 lalitm@google.com Merge "Revert "GTEST_EXECUTE_STATEMENT_ is not available on iOS execute the statement directly instead."" 2020-01-16 chiur@google.com Merge "Add VulkanApiEvent.VkQueueSubmit message" 2020-01-16 khokhlov@google.com Merge "trace_processor: Run metrics on Windows" 2020-01-16 primiano@google.com Merge "gn: Fix issue with finding llvm when using python3" 2020-01-16 hjd@google.com Merge changes Ic6800bd0,I29636316 2020-01-16 treehugger-gerrit@google.com Merge "processor: Fix handling of 0 timestamp in TrackEventTokenizer." 2020-01-16 rsavitski@google.com Merge "heapprofd producer: use sigqueue(si_value: 0) instead of kill" 2020-01-16 taylori@google.com Merge "perfetto-ui: Toggle sidebar on ctrl/cmd + b" 2020-01-16 eseckler@google.com Merge "client lib: Support building in Chrome using a fake platform" 2020-01-16 eseckler@google.com Merge "processor: Translate duplicate pids/tids during json export" 2020-01-16 buss@google.com Merge changes I1bb0e215,I498ed990 2020-01-16 treehugger-gerrit@google.com Merge "processor: Support pid reuse in ProcessTracker without Start/EndThread" 2020-01-16 primiano@google.com Merge "GTEST_EXECUTE_STATEMENT_ is not available on iOS execute the statement directly instead." Created with: gclient setdep -r src/third_party/perfetto@d092437b81ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: 1043059 Change-Id: I37e4964f76d212bcfef69c8715ac7521521e82a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007750Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#732907}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/486a2cf15526..243095cddff8 Created with: gclient setdep -r src-internal@243095cddff8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1007337 Tbr: jbudorick@google.com Change-Id: I938935162017b29cbb817777383a47c2834e80eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007913Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732906}
-
Jan Wilken Dörrie authored
This reverts commit 61f91381. Reason for revert: Likely causing flakiness in source-frame-breakpoint-decorations.js: https://crbug.com/1043146 Original change's description: > Remove event races in two breakpoint decoration tests > > This CL changes two layout tests to follow the pattern of: > 1. Install an instrumentation promise > 2. Run and await an async action > 3. Await that the instrumentation is called > 4. Dump breakpoint information > > This CL is also in preparation for asyncification of source mapping, > hence making the "action" async. > > Drive-by: Re-baseline one of the layout tests that seems to be fixed > now. > > Bug: chromium:1032016 > Change-Id: Ibad4160fe9ab32aa3f818cdd4937112c3f4e6f08 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000023 > Commit-Queue: Simon Zünd <szuend@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#731171} TBR=sigurds@chromium.org,szuend@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1032016 Change-Id: I05e46d646d6cbf1516c8d9a2c1eab46cd8d05377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007810Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#732905}
-
