GitLab

Changing in the intialization order of WeakPtrFactory such that all
member variables should appear before the WeakPtrFactory to ensure
that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818

Review URL: https://codereview.chromium.org/572853002

Cr-Commit-Position: refs/heads/master@{#295233}

BUG=413944
TEST=Instlal ChromeVox and confirms that it speaks both on the icon and on menu item.

Review URL: https://codereview.chromium.org/569123003

Cr-Commit-Position: refs/heads/master@{#295232}

This gets the //chrome subtree down to a fairly small number of build
errors on Android. Most of the changes are making features not enabled
on android like extensions and plugins properly guarded. This also adds
a few jni targets and fixes up some bitrotted bits.

R=brettw@chromium.org, cjhopman@chromium.org

Review URL: https://codereview.chromium.org/571863002

Cr-Commit-Position: refs/heads/master@{#295231}

ViewManager from mojo_shell. First attempt here:
https://codereview.chromium.org/477923004/

Failed the linux gn dbg build after cq landed:
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/12251

BUG=
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/568883003

Cr-Commit-Position: refs/heads/master@{#295230}

BUG=None
TEST=gn gen out_gn/Debug && ninja -C out_gn/Debug gfx_unittests
R=brettw@chromium.org,sky@chromium.org

Review URL: https://codereview.chromium.org/566303002

Cr-Commit-Position: refs/heads/master@{#295229}

This CL changes the experimental app list's AppListItem size when
displayed in the AppsGridView and adds padding between each AppListItem.

BUG=411775

Review URL: https://codereview.chromium.org/559373004

Cr-Commit-Position: refs/heads/master@{#295228}

The re-land fixes the unittests to test with/without the field trial set.

Sending is controlled by a finch experiment.

The verdict from the server is ignored for now.

BUG=413967

Review URL: https://codereview.chromium.org/580593003

Cr-Commit-Position: refs/heads/master@{#295227}

R=lcwu@chromium.org,byungchul@chromium.org
BUG=400914

Review URL: https://codereview.chromium.org/568243002

Cr-Commit-Position: refs/heads/master@{#295226}

Original CL broke the Win official bots because they report their default
version channel as "canary" instead of "trunk".

https://codereview.chromium.org/572813002

Original description:

This refactor will allow some manifest tests running in Chrome's unit_tests
suite to move to the extensions_unittests suite.

* Rename ExtensionManifestTest to extensions::ManifestTest and move it into
  src/extensions.
* Introduce ChromeManifestTest to load manifests from Chrome's test data dir.
* Eliminate some unnecessary use of chrome::VersionInfo::Channel.
* Move SharedModuleManifestTest to extensions_unittests as an example.

FileHandlerManifestTest and ExternallyConnectableManifestTest will be next,
but require more refactoring (e.g. of permissions).

BUG=397165
TEST=unit_tests, extensions_unittests
TBR=rockot@chromium.org

Review URL: https://codereview.chromium.org/574173002

Cr-Commit-Position: refs/heads/master@{#295225}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG=110610

Review URL: https://codereview.chromium.org/579663002

Cr-Commit-Position: refs/heads/master@{#295224}

Revert of Clean up GestureEventDetails constructors and fix unit tests (patchset #1 id:20001 of https://codereview.chromium.org/573963005/)

Reason for revert:
This broke TouchEditableImplAuraTest.TouchSelectionOnLongPressTest.
[24874:24874:0916/151803:584385367:FATAL:gesture_event_details.cc(54)] Check failed: false. Invalid event type for constructor: 32
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=undefined&tests=TouchEditableImplAuraTest.TouchSelectionOnLongPressTest&testType=content_browsertests

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=undefined&tests=TouchEditableImplAuraTest.TouchSelectionOnLongPressTest&testType=content_browsertests

Original issue's description:
> Clean up GestureEventDetails constructors and fix unit tests.
>
> A new version of Issue 565583005: Clean up GestureEventDetails
> constructors
> https://codereview.chromium.org/565583005/
>
> BUG=350942
>
> TBR=tdresser@chromium.org, jdduke@chromium.org, sadrul@chromium.org
>
> Committed: https://crrev.com/874611d5ab5b879648682c1ea41062bebc9c95e5
> Cr-Commit-Position: refs/heads/master@{#295144}

TBR=sky@chromium.org,lanwei@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=350942

Review URL: https://codereview.chromium.org/577833003

Cr-Commit-Position: refs/heads/master@{#295223}

Routing policy override is needed at the point where ping test is executed in AndroidRndisConfigurator or the ping may fail.

It's also needed after DNS is changed in AndroidRndisForwarder constructor as executing setifdns may reset the policy table.

Thus we need to make multiple calls to OverrideRoutingPolicy() during RNDIS forwarder creation lifecycle.  But this is ok since the function is idempotent.

BUG=

Review URL: https://codereview.chromium.org/577853002

Cr-Commit-Position: refs/heads/master@{#295222}

BUG=411173
TEST=layouttest http/tests/serviceworker/

Review URL: https://codereview.chromium.org/574643003

Cr-Commit-Position: refs/heads/master@{#295221}

The memory allocated by AllocAndCopyName was not being freed
if the in-process policy engine did not allow the request to
query the broker.

This was nicely reported by typo.pl@gmail.com

TEST=see bug
BUG=414039

Review URL: https://codereview.chromium.org/575623004

Cr-Commit-Position: refs/heads/master@{#295220}

Add plumbing for a ResetStreamTextureProxy which should be
called on the event of a context loss. Only hooked up the
call for the in-process implementation in this CL when the
contex is restored.

ResetStreamTextureProxy currently handles "onContextLoss" as
well as "onContextRestored" concepts. It deletes the old
stream texture id, and recreates and binds a new
StreamTextureProxy.

BUG=412578

Review URL: https://codereview.chromium.org/532993002

Cr-Commit-Position: refs/heads/master@{#295219}

https://chromium.googlesource.com/chromium/blink/+log/435acf076b2d5f0243b4a87c5d5ef904ae59bed3..cf5fdf9447d2c84224c74bf676957d6aac0f7f42
TBR=loislo@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/555793003

Cr-Commit-Position: refs/heads/master@{#295218}

source - fixes to includes.

R=rch@chromium.org

Review URL: https://codereview.chromium.org/579643002

Cr-Commit-Position: refs/heads/master@{#295217}

TEST=Tested that easy unlock still works
BUG=None

Review URL: https://codereview.chromium.org/562393002

Cr-Commit-Position: refs/heads/master@{#295216}

This saves 11 bytes per call site on x64-clang and 12 byte per call site on
ARM-gcc.

BUG=410776
TEST=base_unittests

Review URL: https://codereview.chromium.org/540883002

Cr-Commit-Position: refs/heads/master@{#295215}

This CL implements a WebRTC Desktop Capturer that captures from
the Aura Shell root window.

The capturer is used by the It2MeHost on Chrome OS.
|DesktopCaptureDeviceAura| cannot be re-used in our scenario
because is timer-driven as opposed to caller driven, which is
required by WebRTC.

The current implementation uses the layer API

desktop_window_->layer()->RequestCopyOfOutput(request.Pass())

to request the layer and its subtree to be rendered to a
|SkiaBitmap|.  It then copies the pixels to a WebRTC |DesktopFrame|.

BUG=411530

Committed: https://crrev.com/278b065b519617b1e9231bd53e6502706d20787c
Cr-Commit-Position: refs/heads/master@{#295187}

Review URL: https://codereview.chromium.org/543243003

Cr-Commit-Position: refs/heads/master@{#295214}

unit_tests failing on bots even though they passed the CQ.

This reverts commit d117e910.

BUG=413967
TBR=noelutz@chromium.org

Review URL: https://codereview.chromium.org/555373005

Cr-Commit-Position: refs/heads/master@{#295213}

Currently, ObjectProxy::CallMethodAndBlock() returns NULL on
failure but the D-Bus error details are not passed to the caller.

Added a method that would return the D-Bus error information
to the caller and switched ObjectProxy::CallMethodAndBlock()
to use the new method instead.

BUG=chromium:414838
TEST=Build Chrome
TEST=ninja -C out/Debug dbus_unittests && out/Debug/dbus_unittests

Review URL: https://codereview.chromium.org/563763004

Cr-Commit-Position: refs/heads/master@{#295212}

Review URL: https://codereview.chromium.org/571463003

Cr-Commit-Position: refs/heads/master@{#295211}

* Handling RenderProcessGone in CastWindowAndroid
* Using CastBrowserProcess instead of passing the browser context
* A few style nits

R=byungchul@chromium.org,lcwu@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/566963003

Cr-Commit-Position: refs/heads/master@{#295210}

Disable high DPI assets for ui scaling. This will be removed in 39, after this change is landed.

BUG=413368

Review URL: https://codereview.chromium.org/578553002

Cr-Commit-Position: refs/heads/master@{#295209}

BUG=414956
TEST=manual

Review URL: https://codereview.chromium.org/551373009

Cr-Commit-Position: refs/heads/master@{#295208}

BUG=None

Review URL: https://codereview.chromium.org/552983003

Cr-Commit-Position: refs/heads/master@{#295207}

BUG=

Review URL: https://codereview.chromium.org/575923002

Cr-Commit-Position: refs/heads/master@{#295206}

Revert of Revert of Introduce GetBackendFromContextId to avoid using list index. (patchset #1 id:1 of https://codereview.chromium.org/573573003/)

Reason for revert:
Revert the revert since the bot is still red after the revert.

Original issue's description:
> Revert of Introduce GetBackendFromContextId to avoid using list index. (patchset #1 id:1 of https://codereview.chromium.org/556003005/)
>
> Reason for revert:
> It looks like the moto E perf bots are broken due to this change.
>
> BUG=414267
>
> Original issue's description:
> > Introduce GetBackendFromContextId to avoid using list index.
> >
> > BUG=398467
> > TEST=ExtensionTest
> >
> > Committed: https://crrev.com/a1a83005087fdac70e7809f9dc1d89f6c4f88dfc
> > Cr-Commit-Position: refs/heads/master@{#294455}
>
> TBR=tbarzic@chromium.org,achuith@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=398467
>
> Committed: https://crrev.com/c8fad04c1e2119f9e8efc68f32d5268161d044d3
> Cr-Commit-Position: refs/heads/master@{#295136}

TBR=tbarzic@chromium.org,achuith@chromium.org,tonyg@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=414267

Review URL: https://codereview.chromium.org/578693002

Cr-Commit-Position: refs/heads/master@{#295205}

Add ContextualSearchParams constructor to be called when content is passed via HTTP header and not CGI params.

BUG=376007

Review URL: https://codereview.chromium.org/573063002

Cr-Commit-Position: refs/heads/master@{#295204}

Renamed datadeps to data_deps for consistency.

Renamed direct_dependent_configs to public_configs for consistency with the public deps. This is also easier to understand and hopefully will encourage people to do this instead of use all_dependent_configs.

Now that there are so many types of deps, added a DepsIterator that allows easy iterating over all of them (or only the linked ones). This simplified some code.

This simplified the header checker significantly since it had complicated logic to find direct_dependent_configs and prefer paths with those forwarded.

Removed a bunch of weird group special-casing. Groups no longer have their deps copied into the target, but are dependents like everything else. For now, unless you explicitly specify public_deps, all group deps will default to public. I'd like to change this in a future pass.

Added a bool return value to the target generator functions that fill values. Since I originally did that, I've started both returning a bool and setting an Err, which makes checking for the error and early-returning easier to remember. I did this because I found yet another case of forgetting to check err, which gives very strange results.

Review URL: https://codereview.chromium.org/561273003

Cr-Commit-Position: refs/heads/master@{#295203}

Revert of Add public API generation with cr.makePublic() and handle it in compiler pass (patchset #10 id:180001 of https://codereview.chromium.org/557633002/)

Reason for revert:
Likely culprit for OOBE WebUI test breakage.

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%282%29/builds/1974/steps/browser_tests/logs/stdio

Original issue's description:
> Add public API generation with cr.makePublic() and handle it in compiler pass
>
> R=dbeam@chromium.org,tbreisacher@chromium.org
> BUG=393873
> TEST=third_party/closure_compiler/runner/how_to_test_compiler_pass.md
>
> Committed: https://crrev.com/730652530d108372ef14f62b89665197628f7880
> Cr-Commit-Position: refs/heads/master@{#295173}

TBR=dbeam@chromium.org,tbreisacher@chromium.org,vitalyp@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=393873

Review URL: https://codereview.chromium.org/577843003

Cr-Commit-Position: refs/heads/master@{#295202}

Fix some more for= usage.

Also fix some controlled settings indicators.

BUG=409938
R=dbeam@chromium.org

Review URL: https://codereview.chromium.org/572853007

Cr-Commit-Position: refs/heads/master@{#295201}

With current autofill implementaion for credit card number field on a secure form that splits up the credit card number across multiple fields fails to fill all fields, and instead it just fills first of the credit card number field.

With this patch it solves the problem by book-keeping spilt information to hold the credit card number grouping.

BUG=90280

Review URL: https://codereview.chromium.org/381613005

Cr-Commit-Position: refs/heads/master@{#295200}

This CL adds the components_browsertests target to android, linux,
mac and windows platforms.

BUG=311270

Review URL: https://codereview.chromium.org/578653003

Cr-Commit-Position: refs/heads/master@{#295199}

Since Chrome 8, invoking <input type="file"> in a browser action popup
on OSX would show, then immediately close the sheet (and the popup).

This CL fixes it by ignoring loss of key status on the bubble window
when it has an attached sheet. Loss of key status (or clicks) on windows
that are sheets themselves are also ignored, otherwise dismissing the
sheet would close the bubble as well, since it's already lost its "sheet
attached" status by that stage.

BUG=61632

Review URL: https://codereview.chromium.org/576643002

Cr-Commit-Position: refs/heads/master@{#295198}

This test verifies that the "Chrome-Proxy: block-once" directive for
bypassing the data reduction proxy for just the current request works as
expected.

BUG=404053

Review URL: https://codereview.chromium.org/558743003

Cr-Commit-Position: refs/heads/master@{#295197}

Revert of Remote Assistance on Chrome OS Part I - Aura Desktop Capturer (patchset #11 id:220001 of https://codereview.chromium.org/543243003/)

Reason for revert:
This patch appears to cause a Chrome OS bot to break.

http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20ChromeOS&number=71945

Original issue's description:
> Remote Assistance on Chrome OS - Aura Desktop Capturer
>
> This CL implements a WebRTC Desktop Capturer that captures from
> the Aura Shell root window.
>
> The capturer is used by the It2MeHost on Chrome OS.
> |DesktopCaptureDeviceAura| cannot be re-used in our scenario
> because is timer-driven as opposed to caller driven, which is
> required by WebRTC.
>
> The current implementation uses the layer API
>
> desktop_window_->layer()->RequestCopyOfOutput(request.Pass())
>
> to request the layer and its subtree to be rendered to a
> |SkiaBitmap|.  It then copies the pixels to a WebRTC |DesktopFrame|.
>
> BUG=411530
>
> Committed: https://crrev.com/278b065b519617b1e9231bd53e6502706d20787c
> Cr-Commit-Position: refs/heads/master@{#295187}

TBR=sergeyu@chromium.org,dcaiafa@chromium.org,darin@chromium.org,wez@chromium.org,jamescook@chromium.org,reed@google.com,danakj@chromium.org,sky@chromium.org,kelvinp@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=411530

Review URL: https://codereview.chromium.org/579583003

Cr-Commit-Position: refs/heads/master@{#295196}

These checks were lost in refs/heads/master@{#294801}: https://codereview.chromium.org/541763002.

BUG=382975
TEST=Compiling does not warn about an unused result.

Review URL: https://codereview.chromium.org/573963007

Cr-Commit-Position: refs/heads/master@{#295195}

This allows custom launcher pages to be torn down in response to this
notification in the same way that regular packaged app windows are.
Currently these WebContents are torn down later, by
Widget::CloseAllSecondaryWidgets(), but this relies on the WebContents
lifetime being tied to a Widget.

Observing NOTIFICATION_APP_TERMINATING also allows us to explore
decoupling the AppListViewDelegate from the AppListView lifetime, and
remove some special code on Mac to deal with updating the profile
switcher (since the AppListViewDelegate is owned by a leaky singleton
there).

BUG=403647

Review URL: https://codereview.chromium.org/559823002

Cr-Commit-Position: refs/heads/master@{#295194}