GitLab

This CL removes the unnecessary inclusion of base/metrics/histogram.h
(introduced by crrev.com/308221) in base/message_loop/incoming_task_queue.cc.
The latter doesn't actually use any of the code provided by histogram.h

BUG=None

Review URL: https://codereview.chromium.org/1844693003

Cr-Commit-Position: refs/heads/master@{#383883}

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1802163002

Cr-Commit-Position: refs/heads/master@{#383882}

This patch renames consumeImage to consumeImageOrNone to more
accurately represent what the function does. It consumes an ident in
the case CSSValueNone is specified and consumes an image otherwise.

Review URL: https://codereview.chromium.org/1842523003

Cr-Commit-Position: refs/heads/master@{#383881}

During merging, display items that have been moved to new places
have null client. Avoid crash during PaintController::showDebugData()
so that we can dump data during merge.

Review URL: https://codereview.chromium.org/1843863002

Cr-Commit-Position: refs/heads/master@{#383880}

BUG=catapult:#2102

Review URL: https://codereview.chromium.org/1845443002

Cr-Commit-Position: refs/heads/master@{#383879}

Replace one WebAudio logging with a VLOG(1) call.

BUG=596760

Review URL: https://codereview.chromium.org/1837113002

Cr-Commit-Position: refs/heads/master@{#383878}

Depends on https://codereview.chromium.org/1830323005/

BUG=513354

Review URL: https://codereview.chromium.org/1837443002

Cr-Commit-Position: refs/heads/master@{#383877}

This mostly updates the language.md file.

Review URL: https://codereview.chromium.org/1841013003

Cr-Commit-Position: refs/heads/master@{#383876}

BUG=598748
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1837343002

Cr-Commit-Position: refs/heads/master@{#383875}

See screenshot in bug.

BUG=595538

Review URL: https://codereview.chromium.org/1817123003

Cr-Commit-Position: refs/heads/master@{#383874}

BUG=

Review URL: https://codereview.chromium.org/1842933002

Cr-Commit-Position: refs/heads/master@{#383873}

When wheel event listeners were moved to the layer tree instead of
on individual layers in https://codereview.chromium.org/1639363002

We should have stopped hit testing on whether there was a wheel
event listener or not. These properties are checked on the general
page before processing the event.

BUG=597913
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1843813002

Cr-Commit-Position: refs/heads/master@{#383872}

The switch to Monorail switched the Cr-Platform-ARC to Component Platform>ARC,
also switch to domain bugs.chromium.org.

BUG=monorail:1169

Review URL: https://codereview.chromium.org/1844733002

Cr-Commit-Position: refs/heads/master@{#383871}

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1840883002

Cr-Commit-Position: refs/heads/master@{#383870}

BUG=474373

Review URL: https://codereview.chromium.org/1844613004

Cr-Commit-Position: refs/heads/master@{#383869}

This CL adds the Layout.ScrollAnchor.AdjustedScrollOffset histogram which
simply counts the number of times an adjustment is made.

This CL also adds a UseCount to ScrollAnchor.

The first metric gives us an overall idea of the number of times we
adjust the scroll position. The UseCount tells us out of all the page
visits, for how many of them did we have to adjust the scroll offset.

BUG=596956

Review URL: https://codereview.chromium.org/1827793004

Cr-Commit-Position: refs/heads/master@{#383868}

https://chromium.googlesource.com/native_client/src/native_client.git/+log/a36a2c6d3a01..dabc9f016f3c

$ git log a36a2c6d3..dabc9f016 --date=short --no-merges --format='%ad %ae %s'
2016-03-29 smklein PNaCl Dynamic Linking: Tests storing dependencies from command line in PLL.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
TBR=mseaborn@chromium.org

Review URL: https://codereview.chromium.org/1844723002

Cr-Commit-Position: refs/heads/master@{#383867}

for xcode-ninja, GENERATOR is set to xcode, and GENERATOR_FLAVOR
is set to ninja.

BUG=

Review URL: https://codereview.chromium.org/1844563004

Cr-Commit-Position: refs/heads/master@{#383866}

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1839223002

Cr-Commit-Position: refs/heads/master@{#383865}

This reverts commit e99ec407.

It breaks the browser tests on all platforms due to:

[3820:5896:0329/153506:WARNING:histogram_base.cc(131)] 2 histograms were created before reporting was enabled.
[5572:3816:0329/153506:FATAL:l10n_util.cc(704)] Check failed: std::string::npos == pos (4294967295 vs. 559) Unexpectedly found a $2 placeholder in A supervised user can explore the web with your guidance. As the manager of a supervised user in Chrome, you can:

???allow or prohibit certain websites,
???review websites the supervised user has visited, and
???manage other settings.

Creating a supervised user does not create a Google Account, and their bookmarks, browsing history, and other preferences will not follow them to other devices with Chrome Sync. After you create a new supervised user, you can manage their settings at any time, from any device, at <a target="_blank" href="$1">$2</a>.

For more information, visit our <a target="_blank" href="https://support.google.com/chrome/?p=ui_supervised_users&hl=en">Help Center</a>.

BUG=563722
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=mahmadi@chromium.org

Review URL: https://codereview.chromium.org/1842703004

Cr-Commit-Position: refs/heads/master@{#383864}

These don't do anything but force the object to be created in the heap
and then wrap them in a scoped_ptr.  Callers can do that themselves without
needing a second, static copy of every constructor.

R=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1840223002

Cr-Commit-Position: refs/heads/master@{#383863}

Shrinks Channel's read buffer back down to the maximum
unused capacity any time its contents have been fully
discarded. This prevents us from permanently wasting
memory after a large IPC is transmitted.

Based on work detailed in issue 529940, the max unused
capacity has also been reduced from 256 kB down to
64 kB. In practice we rarely transmit messages larger
than this, so the performance impact of these extra
allocations should be negligible.

BUG=593731,500019
R=amistry@chromium.org

Review URL: https://codereview.chromium.org/1835933002

Cr-Commit-Position: refs/heads/master@{#383862}

https://chromium.googlesource.com/chromium/src/+/0aab1b730

BUG=594516
TBR=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/1838383003 .

Cr-Commit-Position: refs/heads/master@{#383861}

The UX suggested using #7BAAF7.

BUG=b/25797993

Review URL: https://codereview.chromium.org/1843743002

Cr-Commit-Position: refs/heads/master@{#383860}

This is an optional minor refactoring.

Reason: Putting the main public method first after the constructor, rather than in the middle, seems to be a more natural ordering.

The rest of the methods in this class are helper methods not used outside
of this class, and thus should all be private, including needs_servers.

Review URL: https://codereview.chromium.org/1827833005

Cr-Commit-Position: refs/heads/master@{#383859}

There is no pointer event equivalent for mouse event type MOUSE_CAPTURE_CHANGED
and MoveEventHandler doesn't need to deal with this event type.

https://codereview.chromium.org/1814533002/ caused a change in mouse event
handling that caused this DCHECK to be hit.

BUG=598330
TEST=mojo_runner mojo:mash_session and click the close box for any window

Review URL: https://codereview.chromium.org/1843433002

Cr-Commit-Position: refs/heads/master@{#383858}

Removed some periods.
"setup" -> "set up".

BUG=593842

Review URL: https://codereview.chromium.org/1816383002

Cr-Commit-Position: refs/heads/master@{#383857}

Add an in-process bridge between the gpu, main and drm threads so that
the drm ozone implementation can operate in single-process mode.

BUG=558602

Review URL: https://codereview.chromium.org/1831693002

Cr-Commit-Position: refs/heads/master@{#383856}

It doesn't really make sense to get overflow scrollbars for an iframe (the
real scrollbars are drawn within the frame, and the frame itself cannot
overflow in any useful way).

Rather than address this in the legacy compositing code, this makes the style
system prevent this nonsensical state from ever occurring, by adjusting the
overflow property to visible for all frame elements.

This matches the existing behavior of the non-composited path here: no
scrollbars are drawn in response to the 'overflow' property on a frame.

BUG=384154
TEST=LayoutTests/scrollbars/iframe-overflow-scroll-ignored.html

Review URL: https://codereview.chromium.org/1843723002

Cr-Commit-Position: refs/heads/master@{#383855}

We were calling willAnimaterToOffset with the updated target position before
clearing the animation state when in PostAnimationCleanup. As a result, we
didn't take into account the potentially modified scroll offset by a
programmatic scroll.

BUG=598548

Review URL: https://codereview.chromium.org/1842623003

Cr-Commit-Position: refs/heads/master@{#383854}

This is what I meant to do in https://codereview.chromium.org/1770983002/

BUG=548423

Review URL: https://codereview.chromium.org/1818603002

Cr-Commit-Position: refs/heads/master@{#383853}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/9bcc481fe3e6..2dc8af398989

$ git log 9bcc481fe..2dc8af398 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1836373002

Cr-Commit-Position: refs/heads/master@{#383852}

Revert of Allocator shims working on VS2015. (patchset #11 id:200001 of https://codereview.chromium.org/1414453017/ )

Reason for revert:
It breaks the link on Windows.

FAILED: C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x86 True views_examples_with_content_exe.exe "C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x86 False link.exe /nologo /OUT:views_examples_with_content_exe.exe @views_examples_with_content_exe.exe.rsp" 1 mt.exe rc.exe "obj\ui\views\examples\views_examples_with_content_exe.views_examples_with_content_exe.exe.intermediate.manifest" obj\ui\views\examples\views_examples_with_content_exe.views_examples_with_content_exe.exe.generated.manifest ..\..\ui\views\examples\views_examples.exe.manifest ..\..\build\win\compatibility.manifest
allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __query_new_mode already defined in libucrt.lib(new_mode.obj)

allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __set_new_mode already defined in libucrt.lib(new_mode.obj)

allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _calloc already defined in libucrt.lib(calloc.obj)

allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _free already defined in libucrt.lib(free.obj)

allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _malloc already defined in libucrt.lib(malloc.obj)

allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _realloc already defined in libucrt.lib(realloc.obj)

views_examples_with_content_exe.exe : fatal error LNK1169: one or more multiply defined symbols found

Original issue's description:
> Allocator shims working on VS2015.
>
> VS2015 is happy for us to simply override the CRT symbols since they
> seem to be defined weakly by the universal CRT.
>
> This shim is far simpler than the previous one, as the libcmt stripping
> technique can be removed.
>
> Allocator shim is also now only be enabled on Release Static builds.
>
> BUG=481611
> TEST=base_unittests --gtest_filter=*Memory* in all configurations
>  (Debug/Release/Static/Component/GN/gyp/x64/x86)
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
>
> Committed: https://crrev.com/e20c2e0ab4e5b796e7a1890fb9048b5eb307d015
> Cr-Commit-Position: refs/heads/master@{#383810}

TBR=thakis@chromium.org,brucedawson@chromium.org,rnk@chromium.org,piman@chromium.org,primiano@chromium.org,wfh@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=481611

Review URL: https://codereview.chromium.org/1839783005

Cr-Commit-Position: refs/heads/master@{#383851}

In the future, content/browser/compositor will likely be
moved to components/display_compositor. In anticipation of
that move, I'm moving files that are content specific to
content/browser/renderer_host.

BUG=598792

Review URL: https://codereview.chromium.org/1841153002

Cr-Commit-Position: refs/heads/master@{#383850}

This is required to transition consumers of PlatformFileForTransit into using
attachment brokering. Alias PlatformFileForTransit to base::SharedMemoryHandle,
since that class has the exact semantics required for brokering a HANDLE.

I tried to avoid unnecessary functionality changes, but couldn't avoid changing
some logic in NaclHostMessageFilter and DesktopSessionProxy. Both classes
receive an IPC message that contain a HANDLE from the sender process, and try to
copy the HANDLE into the current process. By switching to an
attachment-brokerable class, PlatformFileForTransit is automatically brokered,
so the duplication logic is no longer required.

Expect future CLs to convert the remaining consumers of PlatformFileForTransit
into using attachment brokering.

BUG=493414

Review URL: https://codereview.chromium.org/1830853002

Cr-Commit-Position: refs/heads/master@{#383849}

If you edit a DOM item in console it should now properly change view
ports and go into editing mode instead of breaking elements panel and
doing nothing.

BUG=598166
R=lushnikov

Review URL: https://codereview.chromium.org/1844623002

Cr-Commit-Position: refs/heads/master@{#383848}

BUG=597000

Review URL: https://codereview.chromium.org/1837053003

Cr-Commit-Position: refs/heads/master@{#383847}

Three separate crashes were possible when a RenderViewHost is pending
deletion.  We now compute this state on demand rather than storing it
in a boolean, since it can change between the time of swapout and the
next navigation.  We were also failing to check this state in
FrameTree::GetRenderViewHost.

This also clears the pending delete RenderFrameHost if its process
dies, since we won't hear a swap out ACK from it after that.

BUG=581912, 544755, 591478
TEST=See bugs for repro steps.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1835833002

Cr-Commit-Position: refs/heads/master@{#383846}

- actually parsing png data
- png dictionary

BUG=584819

Review URL: https://codereview.chromium.org/1839203002

Cr-Commit-Position: refs/heads/master@{#383845}

Adds a few junit tests for the getAllPagesAsync as a template for other
asynchronous functions on OfflinePageBridge.

BUG=598476,595252
R=dewittj@chromium.org

Review URL: https://codereview.chromium.org/1841103002

Cr-Commit-Position: refs/heads/master@{#383844}