GitLab

This adds a flag to disable:
- window.OffscreenCanvas
- Context2DCreation.desynchronize.
- HTMLCanvasElement.transferControlToOffscreen

This is a reland to add WebView layout test expectations.

TBR=alexmos,chrishtr,wfh,boliu

Bug: 940953
Change-Id: I1973c94ced693f0e91785c5197c0d9173e467af8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743098Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685334}

TBR=pwnall@chromium.org

Bug: None
Change-Id: Ie9ef58efb532a0f2392959fa3f3b3cd35118f910
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744523Reviewed-by: Chris Mumford <cmumford@google.com>
Commit-Queue: Chris Mumford <cmumford@google.com>
Cr-Commit-Position: refs/heads/master@{#685333}

test_util.waitForRender -> test_util.waitBeforeNextRender
PolymerTest.afterNextRender -> PolymerTest.waitAfterNextRender

This is a preparatory step for exposing these helpers from the
auto-generated test_util.m.js, necessary for testing Polymer3 elements.

Bug: 965770
Change-Id: I6fbee615a19311c534023490222298b4582e3d7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744580Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685332}

This CL adds enforce-vulkan-protected-memory switch that forces us to
use protected memory for vulkan compositing in fuchsia. Based on this flag, we
make sure that all the allocations and vulkan calls are marked as protected
according to the spec.

This is a part of the bigger effort to enable protected memory usage for video
playback, see bug for details. Adding these changes behind this flag allows us
to test chrome in different environments while there are ongoing changes re
protected memory in skia, scenic and HW decode.

Bug: 982922
Change-Id: If69345ee757d6571c4934cab477a3e19c6dd888b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695931
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685331}

Add a cache of the result of calls to NewLibraryWithRetry. This will
store all resulting MTLLibraries indefinitely, and will grow without
bound.

The goal is to minimize the number of calls hitting the
MTLCompilerService, which is prone to hangs. Should this significantly
help the situation, a more robust cache will be added either to
MTLDeviceProxy or to Skia.

This does not cache MTLRenderPipelineState results (a follow-on patch
may, if that seems helpful in diagnosing the crases).

Bug: 974219, 988964
Change-Id: I94e360eb8996b0624eae03fe6f0a85a3aee71fb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738807Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685330}

Setting this policy should affect the state of the network service as it
is getting created. This test verifies that the policy does indeed
modify the state of the network service. It does not experimentally
verify the number of connections per proxy. That sort of test is covered
in /services code.

Bug: 981598
Change-Id: Icf376f922d7d8907fb22abfad62ffd7daf33c6b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738342
Commit-Queue: Nicolas Arciniega <niarci@microsoft.com>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685329}

https://chromium.googlesource.com/angle/angle.git/+log/4c833efb60a1..b8ec98fe171b

git log 4c833efb60a1..b8ec98fe171b --date=short --no-merges --format='%ad %ae %s'
2019-08-08 courtneygo@google.com Fix build issue with tracing enabled
2019-08-08 ianelliott@google.com Vulkan: Fix crash with glBeginTransformFeedback
2019-08-08 clemendeng@google.com BasicMangledName class
2019-08-08 iannucci@chromium.org Roll ./build/ 54ea0e7fd..680f9ea3d (665 commits)

Created with:
  gclient setdep -r src/third_party/angle@b8ec98fe171b

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Bug: chromium:973721
Change-Id: I90943e9ef4b08a0c8fb3c350c6d6bc77c85c8254
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743024Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685328}

This test dummy module will be used by a smoke test execute various
bundle / DFM system test scenarios (see go/dfm-testing for more
details). The test type needs to be a smoke test as we will be testing
scenarios that depend on packaging, i.e. we need an actual bundle with
separate DFM APKs. That is something a unit or integration test doesn't
provide. This CL adds one sample test scenario. We will add more later.

Bug: 989651
Change-Id: I3f78025a7f0b48904eaa24c1080a817dadd7811a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726394Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685327}

Also, hide Parental controls from regular settings if SplitSettings
is enabled.

Bug: 977615
Change-Id: I13aa6f32aec8768e94bc2bf4730fb62209633c80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740306
Commit-Queue: Danan S <danan@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685326}

On Windows, the default native widget type is DesktopNativeWidgetAura,
while on Linux it's NativeWidgetAura. This leads to different behavior
on Windows for contents border widget: clicks don't go through the
widget, z-ordering is incorrect (the border widget is always on top),
and the widget does not follow the browser window when dragged around.

Use a NativeWidgetAura on Windows as well to fix these issues.

Bug: 991896, 991954, 991921
Change-Id: Id9ea6101ae24dbf0cad6bfb162bed634aba22bca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742140
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685325}

Startup experiments use the next session's behavior to upload. It is
simpler if we made proto output the default behavior.

Change-Id: I0b00dce1a4f07f16dc7283084886f2d75c949764
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725119
Commit-Queue: ssid <ssid@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685324}

This adds a preliminary system call filter, which passes basic web
browsing on 10.15, and an experimental flag to control it. The
experiment won't be rolled out until the V2 GPU sandbox is complete.

Bug: 988148
Change-Id: I4529b31bd88df8f2e786b1765226560e53cdd472
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721240
Auto-Submit: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685323}

Chrome OS Account Manager is launching (via Finch) in M76 but it needs
some time (until next branch point = M78) to be enabled by default in
ToT and a subsequent cleanup.

Change-Id: If32390e3792e8a6b74cf9c4406b2067bf90a462a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744548Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685322}

https://wpt.fyi/results/webaudio/the-audio-api/the-convolvernode-interface?label=master&label=experimental
doesn't show any test failures so let's try removing the entry from
TestExpectations.  Local runs on a macbook show no timeouts either.

Bug: 989036
Change-Id: I7ca70277f7ca9578931686967a7199e3e4e5148c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743076Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685321}

The canonicalization of file URLs effectively lowercases IPv6
addresses. This confuses GetCookieDomainWithString; when it determines
the host is an IP address, it checks whether the specified domain is
an exact match to the URL's host. This exact string match works fine
for IPv4 addresses, because lowercasing them has no effect.

Suppose the URL is "file://[A::]" and the domain is "[A::]". Because
the URL's host was canonicalized as "[a::]", the exact match will
fail.

The reason the linked Clusterfuzz bug only reproduced on Windows is
that it relies on Windows-specific behavior that turns URLs that
resemble UNC paths (prefixed with two backslashes) into file URLs.

Bug: 986675
Change-Id: I66b81dcd499a36132bdf39e42479425e427f0c4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726989Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685320}

Account for RTL arrow key directions when moving between shortcut
options in RTL mode.

Bug: 953822
Change-Id: I883cfa2056e5bfad897426420b363a62265adb60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742888
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685319}

In this CL, we record more information, field trails to the Persistent histogram
data in the reduced mode.

Bug: 965482
Change-Id: I5a5221d2e4c9eeeaeb8f5ace8275921a9aa08b8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742367Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685318}

universal_newlines=True makes communicate() return a string
instead of bytes. This is necessary to match the type of the
return value of readlines() in clobber_if_necessary so that
we don't think the lines are different when they are
actually the same.

R=thakis@chromium.org

Bug: 941669
Change-Id: Ideb56385cdf5c3036e6858922fa3a7275e3b1be9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744689
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685317}

This experiment shows good results on Android as well as Desktop
platforms, so far. Based on those results, we'll move to Beta for more
data.

Bug: 962693
Change-Id: Id37d846101a2573494b1e340156628ed188dc758
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740650
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685316}

This CL adds an infobar for Android for safety tips. This infobar is
only included in Android builds. The CL also updates strings with the
latest draft strings.

This version does NOT use the lightbulb icon, nor does it bold the
safety tip title text. Those will come in a subsequent CL.

Bug: 982930
Change-Id: I112a77f5f68ed9bcd7be9044c35af4a6a7c0a863
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739674Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685315}

The element is unnecessary.  We can implement ripple effect in author's
stylesheets.

The test switch-appearance-customization.html has a sample
implementation of ripple effect.

Bug: 972476
Change-Id: Iaffe849d34f34614635906522c56ad42cd30e7fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743434
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685314}

Subsequent CL uncovered a few issues JobTaskSource that weren't exposed previously.
This CL fixes those issues and add proper coverage:
- ThreadPoolImpl::PostJobTaskSource was never called and had logic flaws.
- A job taskSource that becomes empty while in queue could sit there forever
  without waking up any workers. This is fixed by forcing at least 1 worker
  to wakeup as long as there are things in the queue.
- GetRemainingConcurrency could underflow if max concurrency drops below num workers.

Bug: 839091
Change-Id: Id634eec15c925654b6ebba19b5f7e87c7fa8dd70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742210
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685313}

Bug: 976673
Change-Id: I8644c0151fca6d589c9f7cd0d6b8c4203e62484d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744518Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685312}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/171da61e7635..ecc1e12f780d

git log 171da61e7635..ecc1e12f780d --date=short --no-merges --format='%ad %ae %s'
2019-08-08 shchen@chromium.org Revert "branch_archive_stages: Update firmware blob pathname"

Created with:
  gclient setdep -r src/third_party/chromite@ecc1e12f780d

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: Icd4ecdcdb9381bbf49ea5fe29f21ba42e2ccfc40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744646Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685311}

https://swiftshader.googlesource.com/SwiftShader.git/+log/75efa7bb97a4..f046402b1480

git log 75efa7bb97a4..f046402b1480 --date=short --no-merges --format='%ad %ae %s'
2019-08-08 bclayton@google.com VkDevice: Fix sample cache hash collisions that caused spurious test failures.

Created with:
  gclient setdep -r src/third_party/swiftshader@f046402b1480

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Bug: chromium:b/137649247
Change-Id: I6e1dd21653ca0f7e03668533e8f940a6cb80cf4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744651Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685310}

Bug: 829021
Change-Id: I19b5f71e8c43541459f8429cbdfe36d9823d7b81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742568
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685309}

Bug: none
Change-Id: I723b19f0c95f9cf9ef6a8dcc314a73b65e9cbff6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733091
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685308}

Change-Id: If8ea00756ba3a22b078a6cf19a39b1f923d5ca9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740130Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org>
Auto-Submit: Madeleine Barowsky <mbarowsky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685307}

Added a preference for the auto-scan speed specific to navigating
within the on-screen keyboard. Added a slider to the Switch Access
settings page to adjust this preference. The new preference and slider
are not yet connected to the behavior of Switch Access (so the auto-scan
time in the keyboard will not yet change to reflect the value of the
preference).

Test: With emulated Chrome OS on Linux and both the Switch Access and
text input command line flags enabled
(--enable-experimental-accessibility-switch-access and
--enable-experimental-accessibility-switch-access-text), manually
checked the slider for keyboard scanning speed in Switch Access
settings.

Screenshot of the change in chrome://settings:
https://screenshot.googleplex.com/yoxXvHa67F1.png
This change adds the slider for 'Keyboard Scanning Speed'
in the 'Auto-Scan' section.

Bug: 958081
Change-Id: I24550276bd6bfe360e9703ce677ab62c3a83b033
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728428Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Commit-Queue: Sophie Yang <sophyang@google.com>
Cr-Commit-Position: refs/heads/master@{#685306}

This reverts commit b85e79be.

Reason for revert: chrome_public_test_apk has lots of failures, need to debug.

Original change's description:
> Add android_oreo_standard_gtests to android-oreo-arm64-rel bot
> 
> Change-Id: I932940a233e7e92c6474d4d3d85c69e92eae8eb8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739158
> Reviewed-by: Ben Pastene <bpastene@chromium.org>
> Commit-Queue: Andrew Luo <aluo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#685227}

TBR=bpastene@chromium.org,aluo@chromium.org,hypan@google.com

Change-Id: I8bf97f5f805be16935e73b6aa27f67385288b6ae
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744643Reviewed-by: Andrew Luo <aluo@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685305}

- The tests now use the testing locale "xx-XX", which marks
  certain words offensive to make this unit test correct.
- Re-enabled the remaining part of the test since the
  suggestions are now sped up.
- Added extra test check to verify spellchecker loaded the
  local correctly, otherwise it defaults to en-US

Bug: 981132, 673424
Change-Id: Idc84ddba5dc40a2bd2b47cc6fa58a622ab30ca2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701958
Commit-Queue: Mohamed Mansour <mmansour@microsoft.com>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685304}

https://dawn.googlesource.com/dawn.git/+log/bb10a9187623..e9fabf59160b

git log bb10a9187623..e9fabf59160b --date=short --no-merges --format='%ad %ae %s'
2019-08-08 enga@chromium.org Factor PassResourceUsageTracker to its own file

Created with:
  gclient setdep -r src/third_party/dawn@e9fabf59160b

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
TBR=cwallez@google.com

Bug: None
Change-Id: Iba146542a941ec8048a2f75b6851ddf8aaee1017
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744536Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685303}

Current interpolation code assumes that a specified length can always
be converted into a |CSSLengthArray|, which is no longer true if the
length calculation involves comparison functions min/max().

Hence, this patch allows |CSSPrimitiveValue::AccumulateLengthArray| to
to fail, so that interpolation can fail gracefully.

This patch is preparation for min/max implementation. Note that CSS
comparison functions are not implemented yet, so there is no real code
path that fails such interpolation at this moment.

See the all-in-one implementation of min/max for reference:
https://crrev.com/c/1737874

Bug: 991672
Change-Id: I1b5fe2d324f0836b1e21f6ef12abe21e1d7307c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743135Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685302}

In a separate commit, I intend to add a call to chrome::GetChannel() in
all child processes. This was causing crashes on the kitkat bot because
the VersionConstants* classes were not included in the main dex and
causing crashes when trying to call into
VersionConstantsBridge.getChannel().

Bug: 991688
Change-Id: I5cd98f5cb5be17e28d48b4def798d9e7359d6753
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744515Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685301}

Largest Contentful Paint compares the text and the image candidate
to decide which is the largest candidate. Currently, LCP generates
a result entry between updating the text candidate and the image
candidate, which produces an intermediate result. It causes
the issue in crbug.com/988115, #c4 explains the mechanism of the bug.

To remove the intermediate state, this CL changes the way
LCP-calculator takes the text candidate and image candidate. Instead
of notifying LCP-calculator of the text candidate's update right after
the update, we wait until both text candidate and image candidate have
been updated to notify LCP-calculator.

Also, LCP-calculator adds the logic of checking whether candidate
has changed, from ImagePaintTimingDetector and TextPaintTimingDetector.
Although it's redundant with |UpdateCandidate| in text and image,
these are necessary because going forwards, the "has_changed" logic in
both detectors would have to be removed along with the LIP and LTP
logic.

This CL also considers the chances where either detector is destroyed,
where it would no longer be able to find the largest candidate. In
this case, perf API would use the last reported candidate as the
candidate to compare with the candidate from another detector, in
order to decide the largest between text and image.

Bug: 982307, 988115

Change-Id: I562c7aeab6037678dd4bd7d6eddacdeb5be8bfbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733456
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685300}

BUG=991397

Change-Id: I6fe57a8f8e51200a87c8c7eaeb77b6ea6e7cc68f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742807Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685299}

Bug: 924136
Change-Id: I3043866d36065257cac004d529728d3fc7a4dc55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737370
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685298}

Bug: 906847
Bug: v8:8672
Change-Id: I885ab765ebdf6c8dea965092317d73844e9c3809
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744524
Auto-Submit: Yury Semikhatsky <yurys@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685297}

Instead of passing in a pointer to |error_html|, PrepareErrorPage now
takes a callback. This is done in preparation to implement
committed interstitials for SSL errors, since SSL error HTML must be
generated asynchronously to account for asynchronous captive portal
detection.

Bug: 987407
Change-Id: Ia50442072e0ff1515a3d941f0f27cf68f411aae0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742731Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685296}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time
       requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",
          "PostTask"],
         ["PostDelayedTaskWithTraits",
          "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",
          "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",
          "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",
          "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits",
          "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",
          "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",
          "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=rajendrant@chromium.org

Bug: 968047
Change-Id: Ic67b9572e1cf244f3225037562959074d4e46a1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739829
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685295}