- 27 Jan, 2018 40 commits
-
-
Nico Weber authored
This CL was uploaded by git cl split. R=sadrul@chromium.org Bug: 177475 Change-Id: I39e7b389e2bb228ca717c2029a7c34d2f32b6446 Reviewed-on: https://chromium-review.googlesource.com/890063 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#532180}
-
Lei Zhang authored
BindToBrowserConnector() should just be called on the right thread in the first place. Change-Id: Ib5ea945b34faa054e179a7d5be4c43d749bd219b Reviewed-on: https://chromium-review.googlesource.com/888143Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#532179}
-
rbpotter authored
Bug: 793335 Change-Id: I910d8c2100476372cd0004edde23ecde2bd4bd58 Reviewed-on: https://chromium-review.googlesource.com/887622Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#532178}
-
Ting-Yuan Huang authored
ICF is currently decided by platform/compiler/etc. We need a switch to turn it off in some cases. BUG=b:72175832 Change-Id: I9637c27cd5e663152afc3102ac6996fc9cc1f5f6 Reviewed-on: https://chromium-review.googlesource.com/876802Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Commit-Queue: Ting-Yuan Huang <laszio@chromium.org> Cr-Commit-Position: refs/heads/master@{#532177}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 638337f7. With Chromium commits locally applied on WPT: 2928474c "Revert "Add WPT tests for feature policy"" 9f32e9c0 "S13nServiceWorker: Add tests for network fallback for navigations with request bodies" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/11049 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-writing-modes TBR=leon.han@intel.com No-Export: true Change-Id: I10c8592ef1adacd417aa017273926f8c55abd4e4 Reviewed-on: https://chromium-review.googlesource.com/890060 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#532176}
-
Kurt Horimoto authored
The previous implementation of ToolbarView had a constraint that attempted to layout the view's height by constraining its bottom anchor to kToolbarHeight away from the top layout guide provided by the BVC. This is incorrect because when the page is scrolled, fullscreen will translate the toolbar up so that its bottom edge is less than its height away from the bottom of the top safe area inset. This CL updates ToolbarView to use |intrinsicContentSize| to specify kToolbarHeight as its minimum size (enforced via implicit compression resistance constraints created by returning a custom value for |intrinsicContentSize|). The remainder of the toolbar's layout is managed by constraints created by BVC: 1. |primaryToolbarHeightConstraint|, which accounts for the top layout guide's height. 2. |primaryToolbarOffsetConstraint|, which manages the vertical positioning of the toolbar. When a fullscreen progress value is observed, BVC updates this value to move the toolbar up and down. Note that the height never changes. 3. Leading and trailing constraints that match that of BVC's view so the toolbar's width spans the entire screen. Bug: 799907, 799117, 798496 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6cf2c7e09d3a8324be4008f7be7c313231fabd43 Reviewed-on: https://chromium-review.googlesource.com/882135 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#532175}
-
George Burgess IV authored
I tripped over this, causing presubmit breakages: https://crrev.com/c/884981. In retrospect, this is sort of obvious (and would be if I looked at the comments in the source), but... Bug: None Test: Looked at the new file in gitiles Change-Id: I5aac9a0da52b34b15d8947062811779bfeeb070f Reviewed-on: https://chromium-review.googlesource.com/884988Reviewed-by:
-
Gyuyoung Kim authored
If updated files don't use base::WrapUnique, base/memory/ptr_util.h includes are changed to <memory>. Bug: 755727 Change-Id: Ifb9ad8d3ee41130ac5c159cf084c979a304b80ed Reviewed-on: https://chromium-review.googlesource.com/885383 Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#532173}
-
Daniel Bratell authored
A trailing "}" was not included in the include guard so if included multiple time, you would get "extraneous }" errors. Change-Id: I32582e928220ee9428acbefa9a4833d9d36d2eec Reviewed-on: https://chromium-review.googlesource.com/888581Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#532172}
-
Kurt Horimoto authored
Since this required that the content offset adjustment and toolbar reveal animations occur simulteneously, this animation is governed by a new animator. In order to share code, a FullscreenAnimator superclass was created. This CL also contains some small fixes: - comment update in chrome_broadcast_observer.h - update BVC to pixel-align animations Bug: 796946 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ieee50986644339c4b6d2e86c9fb6be314a416834 Reviewed-on: https://chromium-review.googlesource.com/875248 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#532171}
-
Karan Bhatia authored
This CL prevents redundant copies of URLPatternSet at certain locations by taking a const reference. BUG=None Change-Id: Ib44686f30e10bd03a4e05b925cf4f1664b30bd34 Reviewed-on: https://chromium-review.googlesource.com/890044Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#532170}
-
Karan Bhatia authored
ExtensionsClient::GetPermittedChromeSchemeHosts is only used for determining valid host permissions and is not used for determining valid scriptable hosts. Correct the function documentation to reflect the same. BUG=None Change-Id: I45b171132be5871193d73ad535e9bd6111abbd4b Reviewed-on: https://chromium-review.googlesource.com/886840Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#532169}
-
Devlin Cronin authored
ObjectBackedNativeHandlers have a RouteFunction() ability, which essentially exposes a callback to JS. Routing all these functions can be potentially expensive (at the scale we do it). Factor RouteFunction() calls into an ObjectBackedNativeHandler::Initialize() method (also exposed as NativeHandler::Initialize()), and ensure (through a DCHECK) that this is the only place that allows RouteFunction() calls (as well as potential future initialization). This will allow us to experiment with where to put this logic. For now, call near construction of each handler, which ensures that this patch does *not* introduce a behavior change. Future patches will modify this flow. This patch should have no functional effect. Bug: 805244 Change-Id: I3cd886a85e2c8e4ebb17b01d640e030df9b40700 Reviewed-on: https://chromium-review.googlesource.com/879721Reviewed-by:
-
Hwanseung Lee authored
According to below linked issue(#514), CSSVariableReferenceValue should have a constructor. and also fallback attribute should be readonly attribute. constructor was already added in chromium. but readonly keyword was not added. so add readonly keyword for fallback attribute. (actually it is related with #513 to add readonly keyword) https://github.com/w3c/css-houdini-drafts/pull/547 https://github.com/w3c/css-houdini-drafts/issues/514 https://github.com/w3c/css-houdini-drafts/issues/513 Bug: 803687 Change-Id: I91b5d4f21b75cd5d27063bfceba0b39b30977be9 Reviewed-on: https://chromium-review.googlesource.com/881381Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#532167}
-
Pavel Feldman authored
- removes legacy code from building release modules - makes context submenus populatable via descriptors - inlines network_priorities into perf_ui - removes main -> network_log and main -> console_counters dependencies - introduces late initialization extension point and uses it for showing releaes notes - makes help module non-autostart, removes main -> help dependency - brushes up BUILD.gn - introduces ndb.json for non-browser targets Change-Id: I7790bdff293afdaa80d0882df5efc565440019d1 Reviewed-on: https://chromium-review.googlesource.com/888330 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#532166}
-
Stefan Zager authored
These are tests whose non-rls expectations have changed since the flag-specific/root-layer-scrolls expectations were created. A lot of them changed in https://chromium-review.googlesource.com/872256. BUG=711468 R=skobes@chromium.org,chrishtr@chromium.org Change-Id: Icbb2cd94b89af0c91b7e8b52525fc26955034927 Reviewed-on: https://chromium-review.googlesource.com/890038Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#532165}
-
Han Leon authored
Rather than a non-null ServiceWorkerObjectInfoPtr with an invalid handle id, this CL uses a null ServiceWorkerObjectInfoPtr to indicate those non-existing service worker objects. BUG=772713 Change-Id: Ibb666ffd8bb66b1a10b112390329917b7ff61663 Reviewed-on: https://chromium-review.googlesource.com/877593Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#532164}
-
Ian Kilpatrick authored
This parses the class, and creates the appropriate CSSLayoutDefinition, and DocumentLayoutDefinitions. The tests aren't wpt compatible tests, as there aren't any side-effects that we can measure yet, to verify the correctness of the parsing. So I've added them as unit tests at the moment. Bug: 726125 Change-Id: I6aecd77e5b47d00567eb3636226b3aa4ae7cbc5a Reviewed-on: https://chromium-review.googlesource.com/874716 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#532163}
-
Qiang Xu authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/10ace85c7a3e..5b16d08cfaf8 $ git log 10ace85c7..5b16d08cf --date=short --no-merges --format='%ad %ae %s' 2018-01-23 derat chromite: Build tast-remote-tests-cros CIPD package. 2018-01-23 phobbs risk_report: Also add step links 2018-01-11 miguelosorio Disables guado-macrophage ImageTest 2018-01-25 chrome-bot Update config settings by config-updater. 2018-01-24 chirantan usergroup_baseline: Add crosvm to the wayland group 2018-01-25 manojgupta Revert "generic_stages: temporarily ignore all target prebuilts." 2018-01-21 derat chromite: Make PackageInfraGoBinariesStage install all files. 2018-01-23 nxia Screen and launch Pre-CQs for ready changes in one cycle. 2018-01-22 chirantan usergroup_baseline: Add shill to the tun group 2017-12-15 manojgupta generic_stages: temporarily ignore all target prebuilts. 2018-01-18 ejcaruso ImageTest: add modem to usb group baseline 2018-01-23 vpalatin group_baseline: add group policy-readers 2018-01-22 davidriley som_alerts_dispatcher: Fix logs when unable to find build. 2018-01-20 bhthompson Add eve-arcnext to boards list 2018-01-12 victoryang Add board=capri-zfpga to cbuildbot config and waterfall 2018-01-22 chirantan usergroup_baseline: Add tun group 2018-01-22 davidriley som_alerts_dispatcher: Handle failed build look ups. 2018-01-19 manojgupta Chromiumos-sdk: Move SDK test stage before upload prebuilts. 2018-01-19 dgarrett cros buildresult: Don't crash if build not found. 2018-01-11 haddowk [moblab] Enable paygen testing again 2018-01-19 chrome-bot Update config settings by config-updater. Created with: roll-dep src/third_party/chromite Bug: 762650 Change-Id: I8bc7a9d73fc33cedefb6857642afe914776555b0 Reviewed-on: https://chromium-review.googlesource.com/890054Reviewed-by:
Qiang(Joe) Xu <warx@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#532162}
-
Yuri Wiitala authored
Fixes a couple of issues where frame capture becomes frozen or choppy, with the following changes: 1. Move the "source dirty" logic out of VideoCaptureOracle and into FrameSinkVideoCapturerImpl. 2. More-agressive response to frame refresh requests (needed for improved mouse cursor update response). 3. Remove the distinction between passive and active refreshes from VideoCaptureOracle. FrameSinkVideoCapturer now tracks source damage, and can execute any refresh passively when there is no damage. 4. Add logic to ensure that FrameSinkVideoCapturerImpl provides consumers with a refresh frame whenever key events occur; such as params changes, capture target changes, etc.; that are known to require a full update. 5. Re-enable the content_browsertests that were disabled due to flakiness. Bug: 785072, 754872 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I402f3f928de61e6754e04014327421e4f6917d5f Reviewed-on: https://chromium-review.googlesource.com/884996Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#532161}
-
Kenneth Russell authored
The driver bug's been fixed in 10.13.4. Bug: 775202 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie068990d23884956b614705aa9f7abf81953cec0 Reviewed-on: https://chromium-review.googlesource.com/889414 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#532160}
-
Chris Harrelson authored
Bug: 770324 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib33f369309e59128a134e8f4120e46f647373d16 Reviewed-on: https://chromium-review.googlesource.com/869136 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#532159}
-
Chris Nardi authored
font-feature-settings accepts an integer, but the code for parsing that integer did not check for calc() values. Update the code to accept calculated integers. Bug: 397061 Change-Id: I33ed1538f8148257f22a3e67cbd3478e523a1ff5 Reviewed-on: https://chromium-review.googlesource.com/888161Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#532158}
-
Xiaocheng Hu authored
The wrapper function is called only once, and doesn't wrap complicated logic. Removing it makes the code easier to read. Change-Id: If416aa671221d646fc60271e681a8d2eedc28834 Reviewed-on: https://chromium-review.googlesource.com/889640Reviewed-by:
Ryan Landay <rlanday@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#532157}
-
Fady Samuel authored
A deadline should never be set more than once for a CompositorFrame unless a client explicitly requests a second shot. This CL resets the deadline in frames to 0 on a SurfaceLayer after commit and after activation from pending to active layer trees. If the client expliclty requests a new deadline, then another shot will be taken. base::nullopt signifies to use whatever default deadline the viz service decides. Bug: 707510, 672962 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I856c74a2c50f287d1085b4b99330c42ba6bbeb64 Reviewed-on: https://chromium-review.googlesource.com/887743 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#532156}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=anantha@chromium.org Change-Id: Ib47ae6b7e46083290cad343b843fec4991cb4a25 Reviewed-on: https://chromium-review.googlesource.com/889963Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#532155}
-
Tibor Goldschwendt authored
Bug: 806328 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic11d57e15fdd3645365c07d80addd672b838ac3e Reviewed-on: https://chromium-review.googlesource.com/889680Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#532154}
-
Jeremy Roman authored
For security reasons, it is not valid for script to call getClass, which would allow it to reach the Java reflection APIs. Reject any attempts (but allow uses of other methods named "getClass"), and report it to an auditing object. Provide an implementation of the auditor intended for use in production, which writes to EventLog. This is not inline in the class, as content_junit_tests doesn't fully initialize the Android framework and so cannot call Process.myUid. Bug: 794320 Change-Id: I56d2467e5d15c0d886ce46c63c1bdcc00cf8335c Reviewed-on: https://chromium-review.googlesource.com/881555 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#532153}
-
Randy Smith authored
https://chromium-review.googlesource.com/c/chromium/src/+/775606 that is causing collisions on cookie creation time. This is a quick fix of problems being seen in the field; a longer term fix is being tracked in http://crbug.com/800414. Bug: 800414 Bug: 795827 Bug: 794453 Change-Id: I0ff206fdc517e20f270cebadc6b64704f4c18d21 Reviewed-on: https://chromium-review.googlesource.com/889958Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Randy Smith <rdsmith@chromium.org> Cr-Commit-Position: refs/heads/master@{#532152}
-
Marijn Kruisselbrink authored
With mojo blobs a blob handle is passed all the way across from the browser process to blink so there should be no need for blob acking anymore. Bug: 805597 Change-Id: I11a59f4af80df4c13c73ee5d7761a07a1a38129a Reviewed-on: https://chromium-review.googlesource.com/883980Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#532151}
-
Yuzhu Shen authored
This CL: - introduces ChildURLLoaderFactoryBundle which is a subclass of URLLoaderFactoryBundle with support for a direct network loader factory and lazy initialization for certain factories. It is basically the combination of URLLoaderFactoryBundle and ChildURLLoaderFactoryGetter. - replaces all usage of URLLoaderFactoryBundle and ChildURLLoaderFactoryGetter in renderer with ChildURLLoaderFactoryBundle. Bug: 796425 TBR=jam@chromium.org (for removing an include from chrome/renderer/net/net_error_helper.cc) Change-Id: I1d3a1141bc35340ae586fc30df6496eb84a26c29 Reviewed-on: https://chromium-review.googlesource.com/882606 Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#532150}
-
Chris Harrelson authored
This prevents animations from updating twice as fast for webview plugins because plugins have their lifecycle run as part of the containing plage, then have Paint() called on them. Bug: 737787 Change-Id: I7596d2d0dd74f5733a8d32e8d381662a88708eba Reviewed-on: https://chromium-review.googlesource.com/888170 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#532149}
-
Ryan Hamilton authored
Merge internal change: 183282622 Change-Id: Ibef39b6e706ebd86972909504ce521b460f813ec Reviewed-on: https://chromium-review.googlesource.com/886823 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#532148}
-
Marijn Kruisselbrink authored
Also remove last usage of these deprecated constructors (mostly in tests, where just passing a dangling mojo message pipe works fine). Bug: 769024 Change-Id: I38b390e64552abc971035eec97d090a85ec701f9 Reviewed-on: https://chromium-review.googlesource.com/883570Reviewed-by:
Chris Mumford <cmumford@chromium.org> Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/508734bf..2fce0c43 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Icdb9cbbcf235dc3a4412dace0b95d7a3e001b14c Reviewed-on: https://chromium-review.googlesource.com/888967Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#532146}
-
Gheorghe Comanici authored
https://chromium.googlesource.com/chromium/src/+/e76e0e99dc3b8b2b7ad502603331ea7104745a1a This reverts commit 8e96399b. The original CL was reverted because of two consecutive unconditional returns within the same function, which was causing Windows MSVC build failures. This CL adds the preprocessor command to avoid this issue. TBR=rohitrao for mechanical changes to ios/c/b/a/* Change-Id: I823b815ae29f154df25391c21c0c43ec485192d5 Reviewed-on: https://chromium-review.googlesource.com/889698Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Gheorghe Comanici <gcomanici@chromium.org> Cr-Commit-Position: refs/heads/master@{#532145}
-
Jeremy Roman authored
This makes DisposeContext consistent with DisposeAllContexts in that it cancels out the implicit Enter of the "main" context. Two tests that relied on this not happening need to be tweaked for it. This resolves an LSAN failure in another patch. Change-Id: Iac7312610cb63feed2c2eb20227d40d6a2197460 Reviewed-on: https://chromium-review.googlesource.com/887658 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Nico Weber authored
Fixes a bug where Renderer4.LockExistingCachedImage.Software.SOON and Renderer4.LockExistingCachedImage.Software.EVENTUALLY were overcounted, and removes a redundant check from a test. Bug: 177475 R=danakj@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I531d3f661c4d893412fb074b7f1b9a3c8ba8bc41 Reviewed-on: https://chromium-review.googlesource.com/889719Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#532143}
-
Ian Vollick authored
This CL creates a button that enters window repositioning mode. There is still a great deal of work to be done -- the behavior once we're in the mode is not what we ultimately want -- but this gets some of the infrastructure out of the way. Subsequent patches will refine the repositioning UX. Bug: 799270 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I826a5868d17ee2d1ed5e69b7e1c75eb81142623e Reviewed-on: https://chromium-review.googlesource.com/888540Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#532142}
-
Miguel Casas authored
This CL removes the DeleteSoon()s for |decoder_| and |*_accelerator|s as a speculative fix for the second bug below crbug.com/799204 that tracks a crash on the field. It leaves most of the SEQUENCE_CHECKER usage, since this is useful as documentation-in-code, and leaves a few TODO()s to figure out, if DeleteSoon() proves the culprit, why doing the right thing leads to crashes. from crosvideo.appspot.com, compiled with dcheck_always_on=true Bug: 789160,799204 TEST: Tested via simplechrome on Soraka playing back VP9 videos Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6dace88a448a08bdf441725701347968326442ac Reviewed-on: https://chromium-review.googlesource.com/889143Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#532141}
-
