GitLab

This fixes an assertion failure in ~PickerIndicatorElement.

We need to do rebaseline of many tests because these tests opened pickers
without focus.  openPicker() force to focus on <input> elements now.

We confirmed Win10 failures were trivial.  They were due to month
format change and minor font glitch.

BUG=529530

Review URL: https://codereview.chromium.org/1311013012

git-svn-id: svn://svn.chromium.org/blink/trunk@201962 bbb929c8-8fbe-4397-9dbb-9b2b20218538

6 tests have super-minor differences in pixel color. Probably due to the
roll in https://codereview.chromium.org/1315893005

TBR=dalecurtis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1316663006

git-svn-id: svn://svn.chromium.org/blink/trunk@201961 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Add a FOUC painting test. (patchset #6 id:100001 of https://codereview.chromium.org/1329553004/ )

Reason for revert:
This patch is failing on debug bots, all platforms. For example:

* https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/3244

* https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7%20%28dbg%29/builds/24575

Original issue's description:
> Add a FOUC painting test.
> 
> This expands the Sim(ulation) testing framework to support a very rudimentary
> compositor that can run a simple BeginMainFrame which runs the WebView's
> beginFrame() and layout() steps followed by a simplified paint step which paints
> the main layer of every composited layer mapping. This is a very rough
> approximation of what the real compositor would do, but is enough to test the
> code for avoiding FOUC in DeprecatedPaintLayerPainter's shouldSuppressPaintingLayer
> and BlockPainter::paintContents. It's also enough to test the paint invalidation
> logic in Document::styleResolverChanged for when we painted by skipping painting
> the actual content because of the previously mentioned FOUC avoidance logic.
> 
> I also went and added a bunch of comments to the Sim* classes to explain what
> they do and how to use the testing framework. A future patch may add a README
> so we can use this framework to write future pipeline tests.
> 
> BUG=521692
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201944

TBR=dglazkov@chromium.org,pdr@chromium.org,esprehn@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=521692

Review URL: https://codereview.chromium.org/1316673009

git-svn-id: svn://svn.chromium.org/blink/trunk@201960 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As specified in [1], the 'frame-ancestors' CSP directive should take
control of the access checks when loading a document. In particular,
the 'x-frame-options' header should be ignored if a 'frame-ancestors'
directive is present and enforced.

[1]: https://w3c.github.io/webappsec/specs/content-security-policy/#frame-ancestors-and-frame-options

BUG=510423
R=estark@chromium.org

Review URL: https://codereview.chromium.org/1326823003

git-svn-id: svn://svn.chromium.org/blink/trunk@201959 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces composed tree version of |endOfDocument()| by
templatizing original |endOfDocument()| to work both DOM tree position and
composed tree position version for introducing composed tree version of
|VisibleSelection| class.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1326683006

git-svn-id: svn://svn.chromium.org/blink/trunk@201958 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fold FormDataList::getEntry(index) into DOMFormData without creating
FormDataList::Entry.
 - Add Item::file() to share code between itemsToEntry() and
   DOMFormDataIterationSource::next().
 - Add Item::isString() and isFile() for compatibility with Entry.
 - Add DOMFormData::decode() to decode CStrings in Item.

This CL has no behavior changes.

BUG=528840

Review URL: https://codereview.chromium.org/1334513002

git-svn-id: svn://svn.chromium.org/blink/trunk@201957 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Because CSSParserTokens depends on PartitionAlloc.

BUG=501171

Review URL: https://codereview.chromium.org/1333583003

git-svn-id: svn://svn.chromium.org/blink/trunk@201956 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces composed tree version of
|isEndOfEditableOrNonEditableContent()| by templatizing original
|isEndOfEditableOrNonEditableContent()| to work both DOM tree position and
composed tree position version for introducing composed tree version of
|VisibleSelection| class.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1333583002

git-svn-id: svn://svn.chromium.org/blink/trunk@201955 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces composed tree version of |leftPositionOf()|
by templatizing original |leftPositionOf()| to work both DOM tree
position and composed tree position version for introducing composed tree
version of |VisibleSelection| class.

This patch also introduces |createVisiblePosition()| for
|PositionInComposdTreeWithAffinity| and templaizes
|honorEditingBoundaryAtOrAfter()| and |leftVisuallyDistinctCandidate()| used
by |leftPositionOf()|.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1326313002

git-svn-id: svn://svn.chromium.org/blink/trunk@201954 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The XHR specification defines 'FormData' interface [1], but the blink::FormData
is not its implementation.  It's confusing.
A later patch will rename DOMFormData to FormData.

This CL has no behavior changes.

[1] https://xhr.spec.whatwg.org/#interface-formdata

BUG=528840

Review URL: https://codereview.chromium.org/1311923004

git-svn-id: svn://svn.chromium.org/blink/trunk@201953 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a speculative fix for crbug.com/515899.  If a JavaScript dialog is
opened while a SELECT popup is shown, and the SELECT popup is hidden before the
dialog is hidden, window focus is not correctly restored.  So, we guess delaying
change events solves the problem.

BUG=515899

Review URL: https://codereview.chromium.org/1321993005

git-svn-id: svn://svn.chromium.org/blink/trunk@201952 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Move FormDataList::deleteEntry() to DOMFormData
- Fold FormDataList::hasEntry() into DOMFormData::has().

This CL has no behavior changes.

BUG=528840

Review URL: https://codereview.chromium.org/1308183006

git-svn-id: svn://svn.chromium.org/blink/trunk@201951 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201938

BUG=521124
TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/1307203008 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201950 bbb929c8-8fbe-4397-9dbb-9b2b20218538

See https://code.google.com/p/chromium/issues/detail?id=452745#c17 for details.

BUG=452745

Review URL: https://codereview.chromium.org/1300083002

git-svn-id: svn://svn.chromium.org/blink/trunk@201949 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none

Review URL: https://codereview.chromium.org/1328273003

git-svn-id: svn://svn.chromium.org/blink/trunk@201947 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201930

BUG=237050
TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/1314943011 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201946 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We create ScrollingCoordinator for pages with non-local frames, but it's noop in functionality because of guards:

if (!m_page->mainFrame()->isLocalFrame())
  return;

Let's align the behavior with the rest of ScrollingCoordinator code. Otherwise it crashes browser tests.

BUG=394777

Review URL: https://codereview.chromium.org/1304213003

git-svn-id: svn://svn.chromium.org/blink/trunk@201945 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This expands the Sim(ulation) testing framework to support a very rudimentary
compositor that can run a simple BeginMainFrame which runs the WebView's
beginFrame() and layout() steps followed by a simplified paint step which paints
the main layer of every composited layer mapping. This is a very rough
approximation of what the real compositor would do, but is enough to test the
code for avoiding FOUC in DeprecatedPaintLayerPainter's shouldSuppressPaintingLayer
and BlockPainter::paintContents. It's also enough to test the paint invalidation
logic in Document::styleResolverChanged for when we painted by skipping painting
the actual content because of the previously mentioned FOUC avoidance logic.

I also went and added a bunch of comments to the Sim* classes to explain what
they do and how to use the testing framework. A future patch may add a README
so we can use this framework to write future pipeline tests.

BUG=521692

Review URL: https://codereview.chromium.org/1329553004

git-svn-id: svn://svn.chromium.org/blink/trunk@201944 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=474759

Review URL: https://codereview.chromium.org/1328293002

git-svn-id: svn://svn.chromium.org/blink/trunk@201943 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds internals.advanceImageAnimationFrame([img]) for
advancing an image's animation in tests. With this patch, 2.5 seconds
of unnecessary and flaky setTimeout calls have been removed.

Review URL: https://codereview.chromium.org/1304093006

git-svn-id: svn://svn.chromium.org/blink/trunk@201942 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201880

BUG=524134
TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/1311363010 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201941 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201927

BUG=449197
TBR=dcastagna@chromium.org

Review URL: https://codereview.chromium.org/1315063009 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201940 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201913

BUG=528262
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/1326363003 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201939 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Update the fast/css/font-weight-1.html test to wait for the fonts loaded
promise to resolve thereby blocking on all webfonts to load. This should
ensure that the Windows try bots gets the correct expected image result.

BUG=521124
TBR=szager@chromium.org

Review URL: https://codereview.chromium.org/1334473002

git-svn-id: svn://svn.chromium.org/blink/trunk@201938 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Makes active buttons (like filter) remain red on hover.
- Makes toolbar text not selectable.

BUG=none

Review URL: https://codereview.chromium.org/1319163005

git-svn-id: svn://svn.chromium.org/blink/trunk@201937 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=522237, 493262

Review URL: https://codereview.chromium.org/1312903017

git-svn-id: svn://svn.chromium.org/blink/trunk@201936 bbb929c8-8fbe-4397-9dbb-9b2b20218538

content, the touch rect is translated into the iframe document's
space using the document's scroll offset. It has
a subtle problem that if originally the touch rect is only
partially overlapping with the iframe, after it is translated
into the iframe document's space, the touch rect might be
considered to be fully contained in the document.

Reinforce the detection by asserting that only when the touch
hit-test rect is totally within the iframe's bound in the main
document's space then do we stop the rect-base hit-test search.

BUG=461972

Review URL: https://codereview.chromium.org/1308173007

git-svn-id: svn://svn.chromium.org/blink/trunk@201935 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We do not scheduleVisualUpdate for setNeedsStyleRecalc when we have
pending stylesheets. If we setNeedsStyleRecalc while loading a stylesheet,
we won't necessarily trigger a BeginFrame when the stylesheet finishes
loading because subsequent setNeedsStyleRecalc call won't trigger those
either if the ascendants are already marked with childNeedsStyleRecalc
because we assume the visual update is already scheduled.

Schedule a BeginFrame from resumeTreeViewCommits to make sure deferred
visual updates are triggered.

BUG=384934

Review URL: https://codereview.chromium.org/1316403004

git-svn-id: svn://svn.chromium.org/blink/trunk@201933 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Just to fix the assertion failure.
The related code will be deprecated soon.

BUG=457415,523142

Review URL: https://codereview.chromium.org/1326093003

git-svn-id: svn://svn.chromium.org/blink/trunk@201932 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This has moved to WebRemoteFrameClient.

BUG=none

Review URL: https://codereview.chromium.org/1309363005

git-svn-id: svn://svn.chromium.org/blink/trunk@201931 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add fallback fonts for more math and symbol unicode blocks on Windows to
allow better font fallback and handling of symbols that generally aren't
available in the commonly used fonts.

R=szager@chromium.org
BUG=237023, 237050, 526354
TEST=fast/text/unicode-fallback-font.html

Review URL: https://codereview.chromium.org/1314543011

git-svn-id: svn://svn.chromium.org/blink/trunk@201930 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When building SVG image-backed WebGL textures, we're currently drawing
into a reusable buffer.  Since SVG images are not guaranteed to be
opaque, we should clear the buffer as needed.

Update the existing test to cover this logic (the updated version fails
at ToT but passes with the patch).

Also reactivate the imageForRender null-check (ineffective after
http://crrev.com/29203004), and change drawImageIntoBuffer() to take a
ref instead of a raw ptr.

TEST=fast/canvas/webgl/tex-image-and-sub-image-2d-with-svg-image.html

BUG=500180
R=kbr@chromium.org,pdr@chromium.org

Review URL: https://codereview.chromium.org/1315233003

git-svn-id: svn://svn.chromium.org/blink/trunk@201929 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This code only worked when we weren't using FCM mode, but now we always do for
tests. We also always run tests with asserts turned on, even for release builds
so this code clearly is never used since it contains a
RELEASE_ASSERT_NOT_REACHED().

Lets remove it!

I also removed the old baselines from tests that used this. These tests must all
be disabled on the platforms where these baselines would have been used since we
no longer were capable of producing this output without crashing on the
ASSERT_NOT_REACHED().

BUG=368518,521692

Review URL: https://codereview.chromium.org/1309243006

git-svn-id: svn://svn.chromium.org/blink/trunk@201928 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Re-baseline expectations for video-to-canvas yuv tests.

BUG=449197

Review URL: https://codereview.chromium.org/1321163003

git-svn-id: svn://svn.chromium.org/blink/trunk@201927 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A pair of user-timing timing tests imported from web-platform-tests
have a threshold that's too low for our Windows bots. I filed an
upstream bug[1] to try and improve the tests, but in lieu of that
we should skip them on Windows since they aren't giving us good
data.

[1] https://github.com/w3c/web-platform-tests/issues/2115

NOTRY=true
TBR=ojan@chromium.org
BUG=518992,518993

Review URL: https://codereview.chromium.org/1308393010

git-svn-id: svn://svn.chromium.org/blink/trunk@201926 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This went untested before, but our pointercancel firing code for touch
scroll already takes care of it.

BUG=476576

Review URL: https://codereview.chromium.org/1316013007

git-svn-id: svn://svn.chromium.org/blink/trunk@201924 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The lowercase version comes from <cassert>, and shouldn't be used within Blink.

Review URL: https://codereview.chromium.org/1305353011

git-svn-id: svn://svn.chromium.org/blink/trunk@201923 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=529370
TBR=haraken@chromium.org

Review URL: https://codereview.chromium.org/1333523002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201922 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=490608

Review URL: https://codereview.chromium.org/1328183002

git-svn-id: svn://svn.chromium.org/blink/trunk@201921 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Resource for https://codereview.chromium.org/1316673007/, landed
separately so that patch can go through CQ (as it won't upload the .xml
because it's too large.)

TBR=dominicc@chromium.org
BUG=528078, 463958

Review URL: https://codereview.chromium.org/1328093005 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201920 bbb929c8-8fbe-4397-9dbb-9b2b20218538