GitLab

WebUI is in the process of upgrading to Polymer 3. In the
meantime, the Web Components APIs (particularly HTML Imports)
will be auto-re-enabled for WebUI pages, so that the existing
Polymer 2 code continues to function. A v0 polyfill was
previously being used to ensure compatibility on some pages,
but that approach has been abandoned in favor of a full
upgrade to P3. So the can_use_polyfill check can be
eliminated, and instead rely on the re-enabled features for
all WebUI pages.

Bug: 911943, 965770
Change-Id: Icd3a0d768c64d3e8b81cb89885872fcd67a875ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869622
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707605}

Patch 1-of-6.

Previously this bit didn't propagate for new formatting contexts.
For enabling more of the NGBoxFragmentPainter we need this bit to
cross across these boundaries.

This worked previously as it was only for inline formatting contexts,
which only contain atomic-inlines which paint atomically (the one case
where we don't want to propagate this bit).

Bug: 988015
Change-Id: I06ee83fdfda924d781cb4f34ca312989591f017f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869402
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707604}

This is a reland of e0b95885

Previous CL broke WebView build because startAllowlistLookup is not implemented.

Original change's description:
> Remove default startAllowlistLookup interface
>
> Bug: 995926
> Change-Id: I76ac44526fcf7241b800899810db81dbdd598ae3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846092
> Reviewed-by: Varun Khaneja <vakh@chromium.org>
> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#703911}

Bug: 995926, 1012531
Change-Id: I9d1788b61d87fa05c6f03ae1a76f454526bab6c1
Test: autoninja -C out/Debug system_webview_google_apk
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850769Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707603}

In https://bugs.chromium.org/p/chromium/issues/detail?id=1005096, I
fixed a crash in HTTP Auth committed interstitials by changing a
GetVisibleEntry() to a GetPendingEntry(), and I reasoned that
GetPendingEntry() should always be non-null at this point. It turns
out, I reasoned wrong. It seems that there is some interleaving of
navigations starting and getting cancelled where the pending entry is
null when processing a main-frame response. So this CL adds a null
check before accessing the pending entry.

Bug: 1015787,1006955
Change-Id: I70e06e6c8aeee6db93c5797593d4eda6cd5c906d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869299
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707602}

I seemed to have messed up and not uploaded the last changes I made
to https://crrev.com/c/1856822. I had meant to switch to ninja targets,
but the CL doesn't have those changes.

Bug: 1015682
Change-Id: Iefff69a47a682f2bc5ca549dc65348bd65536981
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869836
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Auto-Submit: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707601}

This patch adds an enabled-by-default feature (DoNotCompositeTrivial3D)
that stops compositing trivial 3D transforms (e.g., translateZ(0)) on
all platforms (low and high end). This change will reduce cross-platform
and cross-browser differences. This is likely to reduce memory as well.
A feature flag has been added so a reverse-experiment can be run. This
can be manually tested with --enable-features=DoNotCompositeTrivial3D
and --disable-features=DoNotCompositeTrivial3D.

The logic for whether a non-trivial 3D transform was present had bugs
such as not accounting for the "rotate" CSS property, treating
"transform: rotateX(0)" as having a 3D component, and treating
"rotate: 1 1 1 0deg" as having a 3D component. These issues have been
fixed in the new ComputedStyle::HasNonTrivial3DTransformOperation
function which is tested in
CompositingRequirementsUpdaterTest.NonTrivial3DTransforms.

Bug: 1012775
Change-Id: I368847f61d015df8b2f703d7cbe8098da5eb79f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849141
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707600}

New revision: bbc72612409377752c8fd2e7a63a1a5947b7dc4b

Change-Id: Iba3668076860e1844b2d6c49c10bbf6a6de35e9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867437
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707599}

1) add "subpixel_font_rendering" condition in gpu control list.
2) Add subplixel_font_rendering gn flag to set this value.
3) Enable gpu_raster on Mali* GPU only when subpixel font rendering
  is disabled.

Bug: 996858
Test: Manually tested on the device. covered by unittest.
Change-Id: If7d2a96e0ec7d3eba0f10f218a50c2d52957272b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787352
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707598}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/a5230910bf2f..973a36942fb6

git log a5230910bf2f..973a36942fb6 --date=short --no-merges --format='%ad %ae %s'
2019-10-18 lamontjones@chromium.org config: update bug# on (non-crit) jetstream

Created with:
  gclient setdep -r src/third_party/chromite@973a36942fb6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: Ic89a7261b97457d4f5e11c576eeaa6cacc5f4442
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869768Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707597}

No change to logic.

This adds a java_cpp_strings target to generate MetricsSwitches.java, so
Chrome (and later, Android WebView) javatests can depend on these
switches. This is implemented following
https://chromium.googlesource.com/chromium/src/+/HEAD/docs/android_accessing_cpp_switches_in_java.md

This does not verify the existing usage of these tests, but only swaps
the string literal for the corresponding java constant.

Bug: 1011991
Test: autoninja -C out/Default chrome_public_test_apk
Change-Id: I14177f1194438d12ca04338475bbb28dc6daca03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863867
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707596}

This puts the registration closer to where the prefs are used. It also
eliminates duplicate "for_test" registration that we added for the
now-cancelled mustash project.

This CL is cleanup, no behavior changes.

Bug: 1013466
Change-Id: If8710cea0733291af14ce69e0ac95de9f34b34b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869760
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707595}

Before r694827, request_initiator for fetches from content scripts would
be incompatible with request_initiator_site_lock, so CORB would
safe-fail to treating request_initiator as if it was an opaque origin.
This meant that no Access-Control-Allow-Origin would ever satisfy CORB.

Since r694827 requests from content scripts set request_initiator to the
origin of the frame/page where the content script was injected (not to
the origin of the extension).  This helps a tiny bit with
https://crbug.com/920638 - now CORB will pass through responses with
Access-Control-Allow-Origin that matches the origin of the frame/page
where the content script runs.  This CL adds a test that verifies this
particular benefit of r694827.

Bug: 920638
Change-Id: I139b12e4f46d48136e627a98b4f072cacc33b8e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864827
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707594}

This CL includes following changes:
- Record user's interaction with IdentityDisc in a way that can be used
  in IPH triggering conditions.
- Introduce IPH metrics
- Enable IdentityDisc IPH in tests through fieldtrial_testing_config.json

R=holte@chromium.org,twellington@chromium.org

Change-Id: I6b1aa2b64d2d52173ad9e83ea2329287d7c28635
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868833
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707593}

This CL converts SharedURLLoaderFactoryInfo to new Mojo types
using PendingRemote and Remote and updates
ContentBrowserClient::HandleExternalProtocol() with
mojo::PendingRemote<network::mojom::URLLoaderFactory>.

Bug: 955171
Change-Id: Ie0d3dec0d00f107d9b9eea84c7cd7e0a314b5445
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861554
Commit-Queue: Julie Kim <jkim@igalia.com>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707592}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a286fcc59c3a..6f8624c5117e


Created with:
  gclient setdep -r src-internal@6f8624c5117e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I04bbfa19e78f0d0843464c482a7b2e110668e33b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869930Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707591}

This ensures that even at odd scaling factors we get a 1DIP separator
between infobars.

Fixes: 1014072
Bug: 1014072
Change-Id: Ib3e0deb6601b7c8f2b3949feabce9a35af45697c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867849Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Auto-Submit: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707590}

This method on RenderFrameHostManager::Delegate is not really needed.
It is a single line wrapper around NavigationController method and the
delegate interface already has a method to get the NavigationController.
As such, I'm removing it and replacing it with a direct call on the
NavigationContoller.

Bug: 1015882
Change-Id: Iffc68d2e3e42e102d115337c271a820a2b368707
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869714
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707589}

The previous implementation assumed there was always a client and could
crash attempting to retrieve the name of the layer.  Instead, we are
making DebugName always available and leveraging that.


Bug: 1015727
Change-Id: I01ebcf5babd117ec2340a79064785ba4ba6b161d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869295Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Sam Fortiner <samfort@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#707588}

This ensures we don't capture the Search key when there's no ChromeVox
focus. This is important for cases like ARC++, where TalkBack needs to get
Search. The ARC++ window explicitly clears focus in the case where TalkBack is
in control.

Bug: 1011894
Change-Id: I15f0b438f16397e92ee59ebd8bd0cb74b9a927e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862719
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707587}

This change changes the behavior of when multiple requests come from the
same origin on one tab. Instead of cancelling requests that come later,
this will be changed to prioritize the last request made for the origin
and cancel requests previously made. This is consistent with the behavior
in web USB.

Bug: 985438
Change-Id: I76c0047fea8852346e13fc99a4d092ab80a5a24c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860683Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707586}

Write profile data after Android apk-based gtests finished.

Bug: 985574
Change-Id: If22313a6eca142226a3fa095a0f40b8d44c00e85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867190Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Yun Liu <yliuyliu@google.com>
Cr-Commit-Position: refs/heads/master@{#707585}

This is done by querying the cookie store on navigation start and on
every redirect for the current navigation url. If any one of the
requests had cookies, the boolean flag is set.

Bug: 995437
Change-Id: If39c9b98ff35423bcb672f437d35d0b7aff9f538
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868329
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707584}

This puts the pref registration closer to where the prefs are used.
It also eliminates the duplicate "for_test" registration that we added
for the now-cancelled mustash project.

I fixed a few cases where the pref was registered with a different
default value in tests than in production.

This CL is cleanup, no behavior changes expected.

Bug: 1013466
Change-Id: Ie8c36b0adc9d39ce1f3170ae8ff6983e831e030a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869770
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707583}

This CL removes the ShouldTransitionCrossSite method on
RenderFrameHostManager as it is no longer useful. It only
checks for --single-process command line flag and that flag
is not supported configuration.

Bug: 1015882
Change-Id: I0b0443e9dce5db6165de1a5f40d4f9b685908767
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866443Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707582}

This CL addresses a corner case where the new bottom sheet request
is blocked by the currently hidden bottom sheet.

Bug: 1009942
Change-Id: I4a6a58ff9c240dd82ef6300d9346f8a9f5c240ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866097
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707581}

This reverts commit 442aea6e.

Reason for revert: Reverting for now since ExecuteScriptTest.testBasicScript is flaky. Will reland after http://crrev.com/c/1869849 is landed.

Original change's description:
> [WebLayer] Implement executeScript() on BrowserController
> 
> This adds a way to execute javascript in WebLayer. The script will be
> executed in a weblayer isolate that will not be able to access any
> scripts from the page.
> 
> Change-Id: Ia17bd8476b5d9247d5761f0af24cd4d61edaccb2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867300
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#707455}

TBR=sky@chromium.org,cduvall@chromium.org

Change-Id: If6e7dfaf486a0974ae0a638e0861e7632178c934
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869885Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707580}

Currently, setting the use-vulkan flag both initializes Vulkan and
enables Vulkan compositing/raster. WebGPU-on-Linux sets the use-vulkan
flag so it can use Vulkan for rendering, but it also requires a bunch
of other flags [1] despite having no dependencies on other Vulkan
efforts. As such, we would like to be able to decouple WebGPU's
development from that of the larger Vulkan-on-Chrome effort.

The core issue is that while use-vulkan initializes the VkInstance, it
also sets the |vulkan_context_provider| [2] for the GrContext. Vulkan
Chrome codepaths then check for the existence of the
|vulkan_context_provider| to decide whether the GrContext is Vulkan and
thus, enable Vulkan compositing/raster.

This CL adds a new gr-context-type flag so the type of the GrContext
can be explicitly set instead of implied via the existence of
|vulkan_context_provider| and |metal_context_provider|. For WebGPU, we
can simply set --use-vulkan=true and --gr-context-type=gl to get the
VkInstance without any side effects.

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=976495#c21
[2] https://cs.chromium.org/chromium/src/gpu/command_buffer/service/shared_context_state.h?l=69&rcl=b405097b146118b345e2802b20d7df5d9a5ea908

BUG=996470,976495,1009029
TEST=unit tests and ran chrome with various permutations of the Vulkan
flags

Change-Id: I49cf84c65f58044446eadffabdaef7ab4db517d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829863
Commit-Queue: Brian Ho <hob@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707579}

The spec underwent many breaking changes this week, and the Blink
implementation was also updated to follow suit.

This CL makes README.md match the new API, the new classes and new
separation of concerns (e.g. the WakeLockController class in Blink was
merged into WakeLock itself).

Bug: 1015359
Change-Id: Ibd52542ef7421714db2180d1aa6c962515004166
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869213
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707578}

mojom.NetworkConfig.type was eliminated when we switched to unions.
A few places referencing it were not properly converted.

This also renames securityType to securityType_ to properly reflect
that it is a private member and converts configRequiresPassphrase_()
to the preferred pattern of using members directly.

Bug: 1014914
Change-Id: I9543f7831e950a343ba8ce6444fbbb3c51fe2bef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864463Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707577}

These changes simplify migrating to starlark by removing spurious diffs
from the semantic diff.

The header_id fields have no effect when builder_view_only is true
because builder views do not display headers.

The manifest_name field is ignored and cannot be set in starlark.

Bug: 1011908
Change-Id: I92d1fd67ba41a68fefdc5524ee0acbc583cfc9d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869684
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707576}

The only custom action in HoverButton's manual layout is to
position title label vertically in its parent. We create a small
custom view class for its parent to change its position upon bound
change. Therefore, we can remove the manual layout in HoverButton.

BUG=1005568

Change-Id: Iea0f9a8236a519373e299b31550d4240551cda7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866981
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707575}

It was only being used on iOS, but the system handles
wkWebView-initiated data URL requests there, and they aren't needed for
internal requests, so this CL also removes all of iOS's uses of the
class.

I'll remove DataProtocolHander and URLRequestDataJob in followup CLs
that make sure we don't lose test coverage of the data URL parsing code,
which is still in use.

Change-Id: I5e6789b36c457a7ab06f7a8e0c1cf1dcee2929b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868837
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707574}

With Narrator and UIA enabled if the user navigates to the end of a
document, then the document is modified such that Narrator now has a
range whos |start_| or |end_| position is at the end or start of the
document respectively, |NormalizeTextRange| would have created a
NULL_POSITION for that range edge.

To avoid this, if there is no next/previous character for that edge
of the range, then that edge position will not be modified.

Bug: 1015593
Change-Id: If706057eaf533dfd0ab5e544eefd102d95ca767e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869716Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Commit-Queue: Adam Ettenberger <adettenb@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#707573}

Bug: 1015501
Change-Id: Ifb0d0f12229ee37fe9abeecfbc46218a4314ea34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865758
Commit-Queue: Carlos IL <carlosil@chromium.org>
Auto-Submit: Carlos IL <carlosil@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707572}

Bug: 1015976
Change-Id: Iffe5eb9fbde4c2abb666f174700699d0025b3c6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869711
Auto-Submit: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707571}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/9bd9f4b3ed64..f28d5287c68b

git log 9bd9f4b3ed64..f28d5287c68b --date=short --no-merges --format='%ad %ae %s'
2019-10-18 dneto@google.com Remove utils/build.py (#841)

Created with:
  gclient setdep -r src/third_party/shaderc/src@f28d5287c68b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=radial-bots+chrome-roll@google.com

Bug: None
Change-Id: I01ea6b78988bcaeaafacdc16fe5aad5ff234b876
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869764Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707570}

The presubmit script did not warn about the missing example tag for placeholders.
This Cl added more details to the error message.
https://imgur.com/a/9I7hXfx

Bug: 941561
Change-Id: I2a950e4dd1fecc0a4dfea7467216c71c964c97b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845580
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Reviewed-by: Mandy Chen <mandy.chen@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#707569}

The terminology we use in the SiteInstance and process model code is
"site" not "web site", therefore it makes more sense for the
IsSameWebSite method to be named IsSameSite and be more consistent with
the rest of the code.

Bug: 1015882
Change-Id: Icb4ba1464b8559ff07c10d2dc338014ec79522ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869761Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707568}

Logging whether or not the user perceived any latency between selecting a card
and being prompted for authentication.

This would help us determine if our efforts to reduce user-perceived latency
were successful. When the user is opted-out, it also determines how often we
can actually present the user with the opt-in flow.

Bug: 949269
Change-Id: I9ef2a34d05ec04e97d572f4d563fca92eeef9dec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810022
Commit-Queue: Manas Verma <manasverma@google.com>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#707567}

Chrome OS used to use the mojo preferences service, which required
prefs used across the browser/ash boundary to be flagged as PUBLIC.
Since mustash was cancelled we don't use the mojo service any more,
so the flag isn't needed.

This helps clarify which prefs are still actually using the mojo
preference service (e.g. assistant).

This CL is just cleanup, no behavior changes expected.

Bug: none
Change-Id: I4f53ff4f1dcaba600a797f61774c186459c751aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869672
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707566}