GitLab

This is the same as
https://codereview.chromium.org/284743002

Which was reverted because a mojo refactoring won the checking race
and I did not notice the revert.

Original message:

Adding more guts to the mojo spy.

This CL fleshes out the basic architecture of the spy. Introducing SpyServerImpl and enough code to operate the "start" and "stop" commands of the front-end.

Still a quite a few loose ends, specially on teardown.

I updated the design doc to reflect this CL:
https://docs.google.com/a/chromium.org/document/d/11FKYXf9mSohlsgl4JmGlyWE1ScX3DKdssdjub63tkwA/edit?usp=sharing

TBR=darin
BUG=360188
TEST=manual via test/spy_repl_test.html

Review URL: https://codereview.chromium.org/379753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281995 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281994 0039d316-1c4b-4281-b951-d872f2087c98

cb46ea1 Fix BUILD.gn for commit 3522876d.
ab99c38 Revert 95c018e.
95c018e Fixes for re-enabling more MSVC level 4 warnings.
3522876 Remove custom memory manager.
e7ee98e Fix for UMR in CXML_Parser::GetCharRef.
30f2ff1 Fix integer overflow in fx_basic_[bw]string.cpp.
d7db790 Fix a crasher issue due to invalid 'bits per component' in PDF.
a26b328 fix a crash issue in _CMapLookupCallback.
f3227ae Fix uninitialized nresults and RGB.
e644f7f Fix uninitialized offset.
5a5c042 Fix uninitialized RGB in GetRGB.
17dd07a Fix uninitialized RGB in translating scanline.
ab4221c Integer overflow in fx_basic.h and fx_memory.h.
c7d8739 Fix uninitialized RGB in LoadPalette.
cceb554 Fix uninitialized font_offset.

Review URL: https://codereview.chromium.org/374233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281993 0039d316-1c4b-4281-b951-d872f2087c98

This will give us some insight into how often this happens.

BUG=353047

Review URL: https://codereview.chromium.org/356893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281992 0039d316-1c4b-4281-b951-d872f2087c98

The existing safe_browsing=2 only exercises the code path using
flywheel protection. safe_browsing=1 uses new code path that
combines full safe browsing and flywheel.

However, the full safe browsing feature is controlled by Finch
experiment. Without Finch experiment setup, the behavior is the
same as before, i.e., only Flywheel safe browsing is enabled.

BUG=381896

Review URL: https://codereview.chromium.org/343183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281991 0039d316-1c4b-4281-b951-d872f2087c98

Revert of DevTools: enable Screencast in DEBUG_DEVTOOLS mode (https://codereview.chromium.org/375873002/)

Reason for revert:
Breaks docked DevTools

Original issue's description:
> DevTools: enable Screencast in DEBUG_DEVTOOLS mode
> 
> This is useful for debugging Screencast without an Android device.
> 
> BUG=None
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281755

TBR=pfeldman@chromium.org,kaznacheev@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/379123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281990 0039d316-1c4b-4281-b951-d872f2087c98

1) Early restart is disabled in "Chrome for ChromeOS" desktop build.
2) Ignore signin profile.

The first change simplifies development.
The second fixes the problem "user session cannot be ended if both
owner and current user both have (different) flags set."

BUG=391357
TEST=none

Review URL: https://codereview.chromium.org/378893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281989 0039d316-1c4b-4281-b951-d872f2087c98

- file_system extensions API.
- various extensions API code.
- some print preview code.

BUG=305852

Review URL: https://codereview.chromium.org/376813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281988 0039d316-1c4b-4281-b951-d872f2087c98

No need to manually manipulate the ref count when scoped_refptr can be used.

BUG=None

Review URL: https://codereview.chromium.org/376863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281987 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a unit test for the app list search result mixer. This
involves making Publish a static method on Mixer and moving the SortData
struct into the header file.

This is a precursor CL for https://codereview.chromium.org/369693004/.

BUG=349727

Review URL: https://codereview.chromium.org/372843003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281986 0039d316-1c4b-4281-b951-d872f2087c98

This CL includes:
- Simple replacement by following rules.
    s/display: -webkit-box/display: flex/
    s/-webkit-box-orient: vertical/flex-direction: column/
    s/-webkit-box-orient: horizontal/flex-direction: row/
    s/-webkit-box-flex: 1/flex: auto/
    s/-webkit-box-flex: 0/flex: none/
    s/-webkit-box-pack: start/justify-content: flex-start/
    s/-webkit-box-pack: end/justify-content: flex-end/
    s/-webkit-box-pack: center/justify-content: center/
    s/-webkit-box-align: center/align-items: center/
    s/-webkit-box-align: baseline/align-items: baseline/
    s/-webkit-box-align: stretch/align-items: stretch/
- Flex items in "-webkit-box" don't shrink by default, but ones in "flex" shrink by default. So some flex items are specified "flex: none;" additionally. 
- "vertical-align: middle;" doesn't work for flex items, so specify "align-items: center;" for their parents.
- Some position adjustment taking care of difference between "-webkit-box" and "flex". (commented inline)

BUG=387568

Review URL: https://codereview.chromium.org/376783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281985 0039d316-1c4b-4281-b951-d872f2087c98

autocomplete_match_type is in chrome/common, but it is not used
by common and renderer actually. This CL removes the unused
includes and unused class referring AutocompleteMatchType.

BUG=388510
R=pkasting@chromium.org, brettw@chromium.org
TBR=jered@chromium.org, jschuh@chromium.org
TEST=build all

Review URL: https://codereview.chromium.org/377783005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281984 0039d316-1c4b-4281-b951-d872f2087c98

Use filename mentioned in download attribute of anchor element while saving file using "Save Link As" from context menu.

BUG=366370

Review URL: https://codereview.chromium.org/339153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281983 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281982 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
http://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%283%29/builds/14776/steps/mojo_view_manager_unittests/logs/SetNodeBounds

[  FAILED  ] ViewManagerTest.SetNodeBounds (109 ms)


Original issue's description:
> Connect X11 ConfigureNotify events to Mojo
> 
> This change plumbs top level window resize notifications from X11 through to the WindowManager and to the GLSurface associated with the top level window. It's an incremental step towards adding support for window manager level layout management (see crbug.com/389785).
> 
> There's preliminary X11 Support for --start-fullscreen (don't try this) and --start-maximized command line arguments as well. This part of the patch could be broken out.
> 
> 
> BUG=388524
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281955

TBR=ben@chromium.org,sky@chromium.org,jamesr@chromium.org,hansmuller@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=388524

Review URL: https://codereview.chromium.org/378243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281981 0039d316-1c4b-4281-b951-d872f2087c98

- CountFileMetadata
- CountFileTracker
- GetAllMeatadaIDs
- GetAllTrackerIDs


BUG=347425
TEST=./unit_tests --gtest_filter="Metadata*"

Review URL: https://codereview.chromium.org/372843007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281980 0039d316-1c4b-4281-b951-d872f2087c98

It's the second step to accept Android's heap profiler discussed in http://crbug.com/382489.

BUG=391212
NOTRY=True

Review URL: https://codereview.chromium.org/371303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281979 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338338
TEST=None
R=jam@chromium.org
TBR=boliu@chromium.org # for android_webview
TBR=bauerb@chromium.org # for components/plugins
TBR=dmichael@chromium.org # for ppapi

Review URL: https://codereview.chromium.org/357203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281978 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Instrumented libraries: turn off leak detection when building with ASan. (https://codereview.chromium.org/376733006/)

Reason for revert:
http://build.chromium.org/p/chromium.lkgr/builders/MSAN%20Release%20%28no%20origins%29/builds/41/steps/compile/logs/stdio

FAILED: cd ../../third_party/instrumented_libraries; ../../third_party/instrumented_libraries/download_build_install.py "--product-directory=../../out/Release" "--package=libappindicator1" "--intermediate-directory=../../out/Release/obj/third_party/instrumented_libraries/msan-libappindicator1.gen" "--sanitizer-type=msan" "--extra-configure-flags=--disable-introspection" "--cflags=-O2 -gline-tables-only -fPIC -w -U_FORITFY_SOURCE \"-fsanitize=memory\" \"-fsanitize-memory-track-origins=0\"" "--ldflags=-Wl,-z,origin -Wl,-R,XORIGIN/. \"-fsanitize=memory\"" "--patch=" "--run-before-build=" "--cc=/mnt/data/b/build/goma/gomacc /mnt/data/b/build/slave/MSAN_Release__no_origins_/build/src/third_party/llvm-build/Release+Asserts/bin/clang" "--cxx=/mnt/data/b/build/goma/gomacc /mnt/data/b/build/slave/MSAN_Release__no_origins_/build/src/third_party/llvm-build/Release+Asserts/bin/clang++" "--jobs=1" "--build-method=destdir" "--sanitizer-blacklist=../../out/Release/../../tools/msan/blacklist.txt"
Traceback (most recent call last):
  File "../../third_party/instrumented_libraries/download_build_install.py", line 366, in <module>
    main()
  File "../../third_party/instrumented_libraries/download_build_install.py", line 362, in main
    download_build_install(parsed_arguments)
  File "../../third_party/instrumented_libraries/download_build_install.py", line 262, in download_build_install
    environment = build_environment(parsed_arguments, install_prefix)
  File "../../third_party/instrumented_libraries/download_build_install.py", line 232, in build_environment
    product_directory,



Original issue's description:
> Instrumented libraries: turn off leak detection when building with ASan.
> 
> Fixes a build failure. I also did some refactoring.
> 
> BUG=313751
> TBR=glider@chromium.org
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281804

TBR=glider@chromium.org,earthdok@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=313751

Review URL: https://codereview.chromium.org/380623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281977 0039d316-1c4b-4281-b951-d872f2087c98

The bug in conformance_textures_texture_draw_with_2d_and_cube has been fixed
after we roll in khronos ToT webgl conformance.

BUG=391951
TEST=gpu bots
TBR=kbr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/380533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281976 0039d316-1c4b-4281-b951-d872f2087c98

Previously, the selection ranges were set implicitly when setValue() was
called.  After [ https://codereview.chromium.org/258063005/ ], setValue()
will no longer implicitly set a field's selection range, so do so explicitly.

BUG=367736, 133242
TEST=browser_tests

Review URL: https://codereview.chromium.org/373023004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281975 0039d316-1c4b-4281-b951-d872f2087c98

For some reason, the default checkbox appears underneath the styled checkbox on Mac. This sets the visibility to hidden so that it won't peek out anymore.

BUG=386867
R=dbeam@chromium.org

Review URL: https://codereview.chromium.org/378093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281974 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371535

Review URL: https://codereview.chromium.org/371333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281973 0039d316-1c4b-4281-b951-d872f2087c98

No need to call GetPrefs()->GetString(prefs::kAcceptLanguages) as all callers are passing the same value as |languages|.

BUG=388515
TEST=build

Review URL: https://codereview.chromium.org/372843005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281972 0039d316-1c4b-4281-b951-d872f2087c98

HistoryMatch is placed under the history namespace and has no dependency to autocomplete.
It should be placed under components/history.

BUG=388515
TEST=build

Review URL: https://codereview.chromium.org/371283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281971 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/343343004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281970 0039d316-1c4b-4281-b951-d872f2087c98

Two issues with GN:
*) We need to set SK_BUILD_FOR_MAC on mac
*) On mac, the sse4 opts are built with -msse4.1 (which is what
GCC_ENABLE_SSE41_EXTENSIONS=YES expands to) not -msse4

and for consistency use -msse4.1 on linux as well.

Review URL: https://codereview.chromium.org/377833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281969 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/378083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281968 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/375703009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281967 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391888

Review URL: https://codereview.chromium.org/373973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281966 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392281
TEST=ChunkDemuxerTest.SeekCompleteDuringAbort

Review URL: https://codereview.chromium.org/374203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281965 0039d316-1c4b-4281-b951-d872f2087c98

This contains fixes for the following sorts of issues:
* Assignment inside conditional
* Signedness mismatch

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/372163005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281964 0039d316-1c4b-4281-b951-d872f2087c98

We should really get rid of the plain |identifier|, rename
|identifier_wrapped| to |identifier|, and make that rule produce an
ast.Identifier (say).

But that change will be more involved.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/376023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281963 0039d316-1c4b-4281-b951-d872f2087c98

c/b/e/extension_view_host.h currently includes platform-specific UI code
and has a "temporary" exception in extensions/DEPS.

This CL removes the exception and resolves the layering by having the
platform-specific UI code provide an implementation of (static)
ExtensionViewHost::CreateExtensionView(). An abstract base,
ExtensionView, is added for use in the platform agnostic code.

This removes a lot of #ifdefs from extension_view_host.h which were in
the way while trying to get toolkit-views building on Mac for the
`chrome` target.

BUG=125846, 390755
TEST=Refactoring. Should be no functional changes for extension views
(e.g. Google Cast toolbar popup, Lookup Companion for Wikipedia) -
appearance and keyboard interaction should be unchanged.

Review URL: https://codereview.chromium.org/363233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281962 0039d316-1c4b-4281-b951-d872f2087c98

The bitstream has changed. Once the roll in
https://codereview.chromium.org/380493002
lands this test can be updated and re-enabled.

BUG=392309

Review URL: https://codereview.chromium.org/379563008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281961 0039d316-1c4b-4281-b951-d872f2087c98

This is a precursor CL to having MetricsStateManager be able to recover missing client_ids and restore old installation dates.

BUG=391338
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/370813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281960 0039d316-1c4b-4281-b951-d872f2087c98

Fixup after "Gamepad: don't notify about connected pads twice".
The CHECK(!g_gamepad_service) I added is failing because during
unit tests several instance can be created and destroyed.

R=bajones@chromium.org
BUG=391503

Review URL: https://codereview.chromium.org/372053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281959 0039d316-1c4b-4281-b951-d872f2087c98

This adds requireAsync, which returns a promise for the requested
module, allowing extension modules to asynchronously import AMD modules:

requireAsync('foo').then(function(foo) {
  // Use foo.
});

BUG=390397

Review URL: https://codereview.chromium.org/359413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281957 0039d316-1c4b-4281-b951-d872f2087c98

Using an ArrayBuffer as the argument to XMLHttpRequest.send() is no
longer deprecated in the latest WHATWG spec, according to
https://www.w3.org/Bugs/Public/show_bug.cgi?id=26153#c1

This change removes the metrics used by the deprecation process. The
deprecation warnings will be removed in the Blink-side CL below.
https://codereview.chromium.org/373023002/

BUG=237493
NOTRY=true

Review URL: https://codereview.chromium.org/372223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281956 0039d316-1c4b-4281-b951-d872f2087c98

This change plumbs top level window resize notifications from X11 through to the WindowManager and to the GLSurface associated with the top level window. It's an incremental step towards adding support for window manager level layout management (see crbug.com/389785).

There's preliminary X11 Support for --start-fullscreen (don't try this) and --start-maximized command line arguments as well. This part of the patch could be broken out.


BUG=388524

Review URL: https://codereview.chromium.org/354933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281955 0039d316-1c4b-4281-b951-d872f2087c98