- 12 Jun, 2017 31 commits
-
-
Keigo Oka authored
Bug: 719905 Change-Id: I14a1ee6b8e66c4f4c98ea4957dde7a7e0d75aad3 Reviewed-on: https://chromium-review.googlesource.com/516866 Commit-Queue: Keigo Oka <oka@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#478568}
-
yoichio authored
It must be Null SelectionPaintRange w/o calculating VSinFlatTree. BUG=708453 Review-Url: https://codereview.chromium.org/2932293002 Cr-Commit-Position: refs/heads/master@{#478567}
-
mahmadi authored
Toggling the Google Payments switch toggles the autofill::prefs::kAutofillWalletImportEnabled which is watched by the autofill::PersonalDataManager. If as a result of this, there is any change to the list of autofill profiles and credit cards, PersonalDataManager notifies its observers via -onPersonalDataChanged where AutofillCollectionViewController reloads the model. Therefore no item or section needs to be added/removed when the swtich is toggled. BUG=671552 Review-Url: https://codereview.chromium.org/2934453004 Cr-Commit-Position: refs/heads/master@{#478566}
-
Kent Tamura authored
The DOM specification [1] doesn't ask any special handling for ShadowRoot in Range.insertNode. So we should treat a ShadowRoot same as DocumentFragment. [1] https://dom.spec.whatwg.org/#concept-range-insert Bug: 732220 Change-Id: Id907833514abcd447d5458a973a7a077cc3297c4 Reviewed-on: https://chromium-review.googlesource.com/530607Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#478565}
-
ccameron authored
We are always sending these images to sRGB canvases, so do the conversion ahead of time. This fixes a bug wherein, when a WebGLRenderingContext reads a BitmapImage it wants the image to be in sRGB (if not-none was requested). We will eventually need to decide how a color-canvas-using WebGLRenderingContext should handle non-sRGB images. BUG=730983 Review-Url: https://codereview.chromium.org/2924373002 Cr-Commit-Position: refs/heads/master@{#478564}
-
Kent Tamura authored
so that it matches to the DOM specification more. This CL has no behavior changes. Bug: 730412 Change-Id: I8881f2286e098238e255553bea8d2e1ab8b13ca4 Reviewed-on: https://chromium-review.googlesource.com/530924Reviewed-by:
-
yoichio authored
LayoutSelection traverses Layout tree in the way here and there. This CL introduces LayoutSelection::Iterator which lists only 'valid' LayoutObjects( see SelectionPaintRange::Iterator::operator++); BUG=708453 Review-Url: https://codereview.chromium.org/2921863002 Cr-Commit-Position: refs/heads/master@{#478562}
-
leon.han authored
This CL - modifies is_service_worker() in external/wpt/resources/testharness.js so that frame.contentWindow.navigator.serviceWorker.controller CAN be identified correctly as ServiceWorker object within main frame's execution context, this ensures success of fetch_tests_from_worker, which is called by several tests in client-navigate.https.html. - throws TypeError if navigation failed for Client.navigate, E.g. mixed-content violation. BUG=658997 TEST=blink_tests external/wpt/service-workers/service-worker/client-navigate.https.html Review-Url: https://codereview.chromium.org/2912593003 Cr-Commit-Position: refs/heads/master@{#478561}
-
shimazu authored
In several tests, currently provider's id is assigned to a variable which is initialized by some random value at the beginning of the test, the provider host instance is created by using the id, and some other objects are also initialized by the id. After browser-side SWProviderHost creation, it'll be problematic because the id will be assigned internally. This patch is to fix the tests by getting the id from ServiceWorkerProviderHost::provider_id() directly. This is split off from https://crrev.com/2779763004/ . BUG=629701, 676983, 668633 Review-Url: https://codereview.chromium.org/2932273002 Cr-Commit-Position: refs/heads/master@{#478560}
-
lushnikov authored
This patch makes DebuggerWorkspaceBinding.rawLocationToUILocation return nullable UILocation. This happens if the rawLocation is "outdated". One example of such situation is using raw location which does not have script (because script has being collected due to navigation). BUG=724328 R=dgozman Review-Url: https://codereview.chromium.org/2931143003 Cr-Commit-Position: refs/heads/master@{#478559}
-
tripta.g authored
BUG=561800 Review-Url: https://codereview.chromium.org/2930573005 Cr-Commit-Position: refs/heads/master@{#478558}
-
Joel Hockey authored
Bug: 712963 Change-Id: I8841efae2eb18b575dbe93b3b4cf248e8b45142b Reviewed-on: https://chromium-review.googlesource.com/530725Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#478557}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0b040040..113a309a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2930253002 Cr-Commit-Position: refs/heads/master@{#478556}
-
tzik authored
Mark virtual/new-remote-playback-pipeline/media/controls/video-controls-overflow-menu-hide-on-click-panel.html flaky on Mac This layout test has been marked flaky on Windows, but also flaky on Mac. A failure log is: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/builds/20666 TBR=tzik@chromium.org NOTRY=true Bug: 731035 Change-Id: I5ab087150375eef210e145694aabc89c025d7b7b Reviewed-on: https://chromium-review.googlesource.com/530905Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#478555}
-
Hayato Ito authored
Rename some of PerformanceTests/ShadowDOM/ files so that it becomes clear which test is for v0 or v1. After this CL, I'll convert some of v0 tests to v1 tests. Change-Id: I415039f8841cc20230356effcd648f5d42d5ce86 Reviewed-on: https://chromium-review.googlesource.com/530865 Commit-Queue: Hayato Ito <hayato@chromium.org> Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#478554}
-
ricea authored
Modify the three "real" implementations of SafeBrowsingDatabaseManager to enable lookups for "ws:" and "wss:" URLs. This change doesn't cause SafeBrowsing checks to be performed on WebSocket URLs. No ws: or wss: URLs will be passed to the SafeBrowsingDatabaseManager yet. It just ensures that they will actually be looked up when a future change causes them to be checked. This change is required for both designs described in the "WebSocket SafeBrowsing Support" design document: https://docs.google.com/document/d/1iR3XMIQukqlXb6ajIHE91apHZAxyF_wvRoB5JGeJYPs/edit BUG=644744 Review-Url: https://codereview.chromium.org/2925233002 Cr-Commit-Position: refs/heads/master@{#478553}
-
tzik authored
This layout test has been marked as flaky on Windows and Linux, but looks flaky also on Mac. A failure log is: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/47093 TBR=tzik@chromium.org NOTRY=true Bug: 731518 Change-Id: I9e37d6f69e0146a192a31ce46b14b1219de52395 Reviewed-on: https://chromium-review.googlesource.com/530885Reviewed-by:
-
tripta.g authored
BUG=561800 Review-Url: https://codereview.chromium.org/2926383003 Cr-Commit-Position: refs/heads/master@{#478551}
-
tripta.g authored
BUG=561800 Review-Url: https://codereview.chromium.org/2926793002 Cr-Commit-Position: refs/heads/master@{#478550}
-
tzik authored
Helper classes in usb_device_handle_unittest.cc don't fit to OnceCallback migration, as they are copied and passed to others. This CL updates them to pass new callbacks for each use to avoid the copy of callbacks. Bug: 714018 Change-Id: Ifb70901439ae92b6b049b84534283c39ebc40ee0 Reviewed-on: https://chromium-review.googlesource.com/527549Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#478549}
-
kinuko authored
- Add ServiceWorkerUtils::IsServicificationEnabled() for easier check. Currently this simply internally check --enable-network-service && PlzNavigate enabled. - Disable request interception via Network provider if servicified code path is enabled (temporarily; otherwise various DCHECK could fail) - Small fixes in ServiceWorkerURLLoaderJob BUG=715640 Review-Url: https://codereview.chromium.org/2931033005 Cr-Commit-Position: refs/heads/master@{#478548}
-
donna.wu authored
This CL replaces ScopedVector with std::vector<std::unique_ptr> in components/history. ScopedVector is deprecated, see bug. BUG=554289 Review-Url: https://codereview.chromium.org/2906953003 Cr-Commit-Position: refs/heads/master@{#478547}
-
Kenichi Ishibashi authored
Having ScriptValue in ErrorEvent creates a cycle reference between blink and v8 and causes memory leak. Fix it by using wrapper tracing. BUG=701695,501866 Change-Id: I3235bc52f95e9fb54ab37e234269ffe5374f10c6 Reviewed-on: https://chromium-review.googlesource.com/527547 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
This CL makes FrameFetchContext work after detached from the underlying frame and document, in order to support use-cases currently covered by PingLoader. After detached, FrameFetchContext stops notifying, but keeps enforcing security checks by storing the security information when detached. One important TODO is ShouldBlockFetchByMixedContentCheck which is not implemented in this CL because MixedContentChecker requires a real Frame instance. Bug: 695939 Change-Id: I0fee9d39cd996a5546fe8378910386d9de7dc27d Reviewed-on: https://chromium-review.googlesource.com/518743 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#478545}
-
yosin authored
This patch introduces |AdjustInlineBoxPositionForTextDirection()| which is split from |ComputeInlineBoxPosition()| to reduce source code size of |ComputeInlineBoxPosition()| for improving code health. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2928083003 Cr-Commit-Position: refs/heads/master@{#478544}
-
yosin authored
This patch chagnes |ComputeInlineBoxPosition()| to avoid to reuse local variable |equivalent| by introducing two const-variable and another call site of |ComputeInlineBoxPosition()| to explicitly denotes what value is used, e.g. |downstream_equivalent| or |upstream_equivalent|, for improving code health. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2933513002 Cr-Commit-Position: refs/heads/master@{#478543}
-
Kent Tamura authored
EnsurePreInsertionValidity() was the only callsite of CheckAcceptChildGuaranteedNodeTypes(). Bug: 730412 Change-Id: I3f623f6f2511c8634f3832739ac064975547a7d9 Reviewed-on: https://chromium-review.googlesource.com/530606Reviewed-by:
-
Hiroki Nakagawa authored
This is a refactoring CL and does not change behavior. This CL... - moves CreateWorkerThread() from 'protected' to 'private'. - moves getters from 'public' to 'protected'. - renames GetThreadableLoadingContext() to CreateThreadableLoadingContext() because this returns a newly created context. - adds class-level comments and thread checks. Bug: 673711, 719775 Change-Id: I855e43eba5f51858cf0afb68a074682de8ef0523 Reviewed-on: https://chromium-review.googlesource.com/527714Reviewed-by:
-
chrome-release-bot authored
Cr-Commit-Position: refs/heads/master@{#478540} -
blakeo authored
Adds the following under the "vk" trace marker group: - ShowKeyboardInternal - ShowKeyboardContainerWindow - ShowKeyboardContainer - KeyboardLayoutSetChildBounds - OnTextInputStateChanged - HideKeyboard - ReloadKeyboardIfNeeded - EnsureCaretInWorkArea - MoveKeyboardToDisplay - MoveKeyboardToTouchableDisplay - MoveKeyboardToDisplayInternal - LoadContents BUG=725789 Review-Url: https://codereview.chromium.org/2923493002 Cr-Commit-Position: refs/heads/master@{#478539}
-
haraken authored
BUG= TBR=jbroman@chromium.org Review-Url: https://codereview.chromium.org/2936533002 Cr-Commit-Position: refs/heads/master@{#478538}
-
- 11 Jun, 2017 9 commits
-
-
zijiehe authored
DataChannelManager manages a set of factory functions to create DataChannelHandler instances to handle named data channels. So once the peer creates a new data channel, DataChannelManager can automatically handle it. Lifetime of a DataChannelHandler is consistent with the MessagePipe it received: it deletes itself once the MessagePipe is closed. BUG=650926 Review-Url: https://codereview.chromium.org/2907073003 Cr-Original-Commit-Position: refs/heads/master@{#478442} Committed: https://chromium.googlesource.com/chromium/src/+/4a15f818c5fdbd1e2c44bf102047ecd9b2c166e2 Review-Url: https://codereview.chromium.org/2907073003 Cr-Commit-Position: refs/heads/master@{#478537}
-
Charles Harrison authored
This CL prevents a needless copy of the first disallowed load callback but in general should just give us more meaningful stack traces in crashes. Bug: 731714 Change-Id: I24e536effe048886a054f1a4ac8a2b2ee493363a Reviewed-on: https://chromium-review.googlesource.com/530244 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#478536}
-
huangs authored
TBR=junov@chromium.org Bug: 732140 Change-Id: I95acb83bf7e2d62fa559c618b8e32a893c19bd69 Reviewed-on: https://chromium-review.googlesource.com/530467 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#478535}
-
mamir authored
BUG=730537 Review-Url: https://codereview.chromium.org/2925053003 Cr-Commit-Position: refs/heads/master@{#478534}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/be1b0570..0b040040 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2931293002 Cr-Commit-Position: refs/heads/master@{#478533}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0e39219e..be1b0570 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2935583003 Cr-Commit-Position: refs/heads/master@{#478532}
-
luoe authored
BUG=726972 Review-Url: https://codereview.chromium.org/2927573004 Cr-Commit-Position: refs/heads/master@{#478531}
-
scottmg authored
(Also base_unittests, which is removed from build repo config in https://chromium-review.googlesource.com/c/530188/ ) BUG=707029, 731217 Review-Url: https://codereview.chromium.org/2930193002 Cr-Commit-Position: refs/heads/master@{#478530}
-
thakis authored
BUG=732100 TBR=agrieve Review-Url: https://codereview.chromium.org/2931283002 Cr-Commit-Position: refs/heads/master@{#478529}
-
