GitLab

An earlier patch (http://crrev.com/582337) regressed this.

Bug: 873883

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie5fe1149ac1da2df7c1a59864339f5b5982527ff
Reviewed-on: https://chromium-review.googlesource.com/1183596
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585128}

Bug: 871478
Change-Id: I781bc9c7a13f6b90812d986f6cb56d2eefa20abd
Reviewed-on: https://chromium-review.googlesource.com/1183626Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585127}

There is some places that temporary string constants are used when
server side strings are not ready. Replace these places with server
strings now.

Bug: b/78190629
Test: Manual Test
Change-Id: I94c7816f1039c7f2dec994317029f69a2acd2866
Reviewed-on: https://chromium-review.googlesource.com/1184309Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585126}

The interfaces for committing were not kept in sync. The work-in-progress
interface NavigationClient was lacking the added callbacks.
This is corrected in this patch.

Bug: 789577
Change-Id: Ic803d8265e9b8544f1f1027df5d4f5b5991838cf
Reviewed-on: https://chromium-review.googlesource.com/1181051
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585125}

Overview
========

Flash has its own CORS-like mechanism (crossdomain.xml-based) and
therefore CORB (Cross-Origin Read Blocking) cannot be enforced for
requests initiated by Flash.

This CL avoids making an exception for plugins, unless the given
renderer process is actually hosting a Flash plugin (and is therefore
capable of proxying network requests on behalf of Flash).  This
means that the exception won't take place unless the user has
approved running Flash (via click-to-play / content settings /
enterprise policy - see the bug for more details).


Details
=======

This CL introduces a global set that stores process IDs of renderers
that host Flash.  This set lives either in the NetworkService process or
(if NetworkService feature is disabled) in the IO thread of the browser
process.  In both cases the global set is implemented and exposed by new
static methods of network::CrossOriginReadBlocking class.

The CL populates the global set from
PluginServiceImpl::FindOrStartPpapiPluginProcess after all the security
checks have been done and the plugin process is ready to be used or
launched.

The CL consults the global set before deciding to make a CORB exception
for a plugin request.  This is done from network::URLLoader (used if
NetworkService feature is enabled) and from
CrossSiteDocumentResourceHandler (used otherwise).

The CL removes items from the global set when RenderProcessHostImpl is
destroyed.


Bug: 874515
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I50484807c921a4daea08be8a00c67a3cf9c82cf0
Reviewed-on: https://chromium-review.googlesource.com/1178885
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585124}

Buffering state changes should only be dropped when two
seek operations are queued, as we dont want the state change
from the first to be misinterpreted as the second one finishing.

This manifested itself as a severe issue with HLS playback
(especially on android phones) where track switches were causing
the buffering updates used to signal startup to be dropped.

Bug: 873837
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I3930bb446f69a2c166419aedd0b5a97d3200ce49
Reviewed-on: https://chromium-review.googlesource.com/1183893Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585123}

As following spec[1], the [SecureContext] extended attribute appears on an interface,
partial interface, interface mixin and so on but not dictionary.
So, it should be deleted.

[1] : https://heycam.github.io/webidl/#SecureContext

Bug: None
Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I752e0c53ad1848b58278d4def47b034e450a88eb
Reviewed-on: https://chromium-review.googlesource.com/1180630Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585122}

Bug: 757605
Change-Id: I0fa269386a04ca91e58dfdfb47c7a047de8b0754
Reviewed-on: https://chromium-review.googlesource.com/1184331Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585121}

These are histograms that have not been viewed in the last 6 months, but still
report data on the Stable channel. Set these histograms to stop being recorded
for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug)
reminding owners about the approaching histogram expiry – initially 30 days
prior to expiry, and also with follow-up alerts. The metrics dashboards will
also display a warning for anyone viewing a soon-to-expire histogram.

Owners and/or users of these histograms: Please comment on this CL if you think
that any affected histogram should not have an expiry date set! This should be
uncommon.

Otherwise, there are a few options going forward:
  * If the histogram is no longer needed, please send a follow-up CL to delete
    the recording code and to mark the histogram as <obsolete>. (You can also
    remove the expiry date in the same CL.)
  * If you want to set a different expiry date, please send a follow-up CL to do
    so.
  * If neither of the above apply, then keep an eye out for Monorail bugs as the
    histogram expiry date approaches.
For more info on how unused histograms are identified, see
https://goto.google.com/uma-unused-histograms-cleanup

Bug: 850539
Change-Id: Ie73f2b6256c39cc5b9df211af257f4537d985da6
Reviewed-on: https://chromium-review.googlesource.com/1126201Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585120}

It is being added by
https://skia-review.googlesource.com/c/skia/+/136062

Bug: skia:6839
Bug: skia:8052
Change-Id: I552a0e94f04cc29b27450792494e9f0160fb5b3a
Reviewed-on: https://chromium-review.googlesource.com/1183382Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585119}

The Runnable and BiFunction overrides are either only used in
tests or can easily replace the "() ->" syntax with "x ->".
This simplifies the Observers class considerably while not
adding much inconvenience anywhere else, modulo the need to use
Both.adapt(), which is now documented in reactive_java.md.

Also fixed the generics of the remaining methods and made sure
the tests would actually catch type errors correctly.

Bug: None
Test: cast_base_junit_tests, cast_shell_junit_tests
Change-Id: I99095c07615e57cb7265e57a3ca0c196c1424d6b
Reviewed-on: https://chromium-review.googlesource.com/1182795Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Simeon Anfinrud <sanfin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585118}

To reland 1164647 which was reverted in 1179701 where one test
fails on MacOS 10.13. After manual testing on MacOS 10.13, it
consistently logs |kDialogClosed| rather than the expected
|kCancelDialogsCalled|. It never appears as flaky since for
all builds between 4738 and 4746
(https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29?limit=200),
where the reverted change was in place, the test
"browser_tests on (none) GPU" never succeeded.

Thus, we need to relax the check in this test for MacOS to cover
the behavior difference for different versions.


Bug: 872795
Change-Id: Ie2c5ccd4881f5c8bbbf37bd7aae4be4fc5591c59
Reviewed-on: https://chromium-review.googlesource.com/1181245
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585117}

These are histograms that have not been viewed in the last 6 months, but still
report data on the Stable channel. Set these histograms to stop being recorded
for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug)
reminding owners about the approaching histogram expiry – initially 30 days
prior to expiry, and also with follow-up alerts. The metrics dashboards will
also display a warning for anyone viewing a soon-to-expire histogram.

Owners and/or users of these histograms: Please comment on this CL if you think
that any affected histogram should not have an expiry date set! This should be
uncommon.

Otherwise, there are a few options going forward:
  * If the histogram is no longer needed, please send a follow-up CL to delete
    the recording code and to mark the histogram as <obsolete>. (You can also
    remove the expiry date in the same CL.)
  * If you want to set a different expiry date, please send a follow-up CL to do
    so.
  * If neither of the above apply, then keep an eye out for Monorail bugs as the
    histogram expiry date approaches.
For more info on how unused histograms are identified, see
https://goto.google.com/uma-unused-histograms-cleanup

Bug: 850539
Change-Id: Iaeae7928bc4d14d92db53526373d8e9931ac106a
Reviewed-on: https://chromium-review.googlesource.com/1126177
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585116}

Change-Id: Idc9d5300360eb9b7061ff1bc68532d7083cf6b2b
Reviewed-on: https://chromium-review.googlesource.com/1184905Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585115}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/171ca366..0c05bf73

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I824cb6250377a854a9467df6d27b5daf632a85c2
Reviewed-on: https://chromium-review.googlesource.com/1184964Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585114}

Android Location and Search Geolocation preferences are removed from the
persistent storage list for incognito mode.
After this CL, if these preferences are changed from incognito mode,
they are only stored in memory and won't affect user profile.

Bug: 861722
Change-Id: Ia23460d35650fd7631dfcad2b42b54fcd3305856
Reviewed-on: https://chromium-review.googlesource.com/1176809Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585113}

Bug: 740715
Change-Id: I96168d9078151e0bd64cda1b987ad3b546ce4570
Reviewed-on: https://chromium-review.googlesource.com/1181161Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585112}

R=bauerb@chromium.org, proberge@chromium.org

Bug: gab's memory is dwindling and proberge is better suited for this :)
Change-Id: Iade9b7416f0e0c20bfcf826255c9ea034af86b2b
Reviewed-on: https://chromium-review.googlesource.com/1184978Reviewed-by: proberge <proberge@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585111}

This reverts commit 1501aabf.

Reason for revert: Various compiles are failing on targets not being changed in those ranges

Each with a similar compiler error: No matching compiler(clang++ 4.2.1[clang version 7.0.0 (trunk 338452)]

Example failure: https://www.google.com/url?sa=j&url=https%3A%2F%2Fci.chromium.org%2Fp%2Fchromium%2Fbuilders%2Fluci.chromium.ci%2FLinux%2520Builder%2520%2528dbg%2529%252832%2529%2F86901&uct=1516637227&usg=pKzrEj68lML-ZPjHPTSWUKP4wTA.

Original change's description:
> Clang: stop building with GCC/libstdc++ from Ubuntu Precise (roll 338452-1:338452-2)
> 
> Previously we used a GCC/libstdc++ package from Ubuntu Precise to build a Clang
> that would work on Precise or later. These days, all bots and developers are on
> Trusty or later, so this should no longer be necessary.
> 
> Bug: none
> Change-Id: I518ee55d07c04dc89163fe262c81d935e05fed78
> Reviewed-on: https://chromium-review.googlesource.com/1183915
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Commit-Queue: Hans Wennborg <hans@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#585067}

TBR=thakis@chromium.org,hans@chromium.org,thomasanderson@chromium.org

Change-Id: I9a21a41db52458d77b949842e11b13dbec02368c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/1185104Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585110}

These are histograms that have not been viewed in the last 6 months, but still
report data on the Stable channel. Set these histograms to stop being recorded
for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug)
reminding owners about the approaching histogram expiry – initially 30 days
prior to expiry, and also with follow-up alerts. The metrics dashboards will
also display a warning for anyone viewing a soon-to-expire histogram.

Owners and/or users of these histograms: Please comment on this CL if you think
that any affected histogram should not have an expiry date set! This should be
uncommon.

Otherwise, there are a few options going forward:
  * If the histogram is no longer needed, please send a follow-up CL to delete
    the recording code and to mark the histogram as <obsolete>. (You can also
    remove the expiry date in the same CL.)
  * If you want to set a different expiry date, please send a follow-up CL to do
    so.
  * If neither of the above apply, then keep an eye out for Monorail bugs as the
    histogram expiry date approaches.
For more info on how unused histograms are identified, see
https://goto.google.com/uma-unused-histograms-cleanup

Bug: 850539

Change-Id: I6915b08846dd50f587dded3544b990334615d4bc
Reviewed-on: https://chromium-review.googlesource.com/1111597Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585109}

Timezone preferences are removed from the persistent storage list for
incognito mode.
After this CL, if these preferences are changed from incognito mode,
they are only stored in memory and won't affect user profile.

Bug: 861722
Change-Id: Ia6839002befb019f46617fc373c77b9600c069f1
Reviewed-on: https://chromium-review.googlesource.com/1180219Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585108}

Adds cells to show credentials. These support dynamic fonts and have 2
buttons. One for password and one for username, which send the events
to the delegate passed when setting the cell up.

Mocks: https://folio.googleplex.com/ntp/Autofill/Autofill%20Manual%20Fallback

Bug: 845472
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia375e00789fb21935817801b904ec7190a516875
Reviewed-on: https://chromium-review.googlesource.com/1183192
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585107}

The transient bit in UserActivationState is a proxy for the
state that "the user is currently active with the page".
From a logical perspective, this state should expire/reset
after a certain period of users' inactivity.  Chrome's
current expiry is 1sec (but can be 10secs in certain cases).
As of mid-2017, none of Edge, Firefox and Safari had any
expiry time, so we wanted to explore the simplest possible
design for UAv2---w/o any expiry.  This created issues with
APIs that never consumes the activation, and we learned
that Firefox also added an expiry time last year.  Hence
we are bringing down the experimental 1h expiry time here.

Bug: 776404
Change-Id: I640c22805c8d4db74812a02d24e645aa994dc20f
Reviewed-on: https://chromium-review.googlesource.com/1178746
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585106}

https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/ddbe19a87228..bfe62e18d24f

$ git log ddbe19a87..bfe62e18d --date=short --no-merges --format='%ad %ae %s'
2018-08-21 dalecurtis Update patches and README with ffmpeg roll hash.
2018-08-21 dalecurtis Correct opus-in-mp4 pre-skip to be uint16_t versus int16_t.

Created with:
  roll-dep src/third_party/ffmpeg

Bug: 649438
Change-Id: I4467ea64338e7f136cd431acd923ae2aaa01048d
Tbr: tguilbert
Reviewed-on: https://chromium-review.googlesource.com/1183848Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585105}

This CL adds a feature to use THREAD_MODE_BACKGROUND_BEGIN instead of
THREAD_PRIORITY_LOWEST for ThreadPriority::BACKGROUND threads. This
lowers the disk and network I/O priority of the thread in addition to
the CPU scheduling priority. MSDN recommends using this setting for
threads that perform background work.
https://docs.microsoft.com/en-us/windows/desktop/api/processthreadsapi/nf-processthreadsapi-setthreadpriority

Bug: 872820
Change-Id: Ia731fcf39c991ae30ca74055595a84385f27635f
Reviewed-on: https://chromium-review.googlesource.com/1171482
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585104}

According to spec, if start is undefined for performance.measure(), 0 will be
used as the start time. However, the current implementation treats undefined as
"null".

This CL doesn't solve all the problems. For backward compatibility, L2 should
treat undefined passed to start/end as empty, null as a string 'null'. As a
temporary fix, we treat both null and undefined as undefined, which is safer
than as 'null'.

Bug: 876324

Change-Id: I7d74d6be9552d090ab7f28342be9a739017bf59b
Reviewed-on: https://chromium-review.googlesource.com/1180345
Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org>
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585103}

This patch:
- moves browser context management to devtools_manager_delegate
- implements browser context related protocol methods in content/

R=dgozman

Bug: 631464
Change-Id: Ia43343d5c2208556214b41225cb05f744f2d9ccd
Reviewed-on: https://chromium-review.googlesource.com/1183594
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585102}

This change is related to https://crrev.com/c/1180480.
Removed tests with @Ignore, as they are now excluded automatically.
Also removed a few obsolete entries.

Change-Id: I5cad3d57602af4c5386bc19c898089356a58136b
Reviewed-on: https://chromium-review.googlesource.com/1180510Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585101}

Uses jinja comments, which will be stripped out during the build. (JSON
doesn't support comments, itself.)

Also convert existing comment (which is technically invalid JSON) to a
jinja comment.

Change-Id: I128f4ac5f07e76de21d208526f7c5028ec7b96c4
Reviewed-on: https://chromium-review.googlesource.com/1184338Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585100}

This CL allows getDisplayMedia() calls where video is enabled to cross from
blink to content side. Additionally, it applies the constraints handling
mentioned in the spec(current state) and adds Layout tests.

Bug: 326740
Change-Id: I864f485595c63485cc70e519796072f928e22e4c
Reviewed-on: https://chromium-review.googlesource.com/1179310Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585099}

Change-Id: If6181220603b75a00cf0d8c9bae194e1300afc9b
Reviewed-on: https://chromium-review.googlesource.com/1176400
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585098}

Added an interface to the existing printing Mojo service for pdf N-up
Conversion for web content.  The service has two main functions:
NupPageConvert(): Convert N PDF pages to a N-up PDF.
NupDocumentConvert(): Convert a PDF document to a N-up PDF document.

In printing, 2-up, 3-up, or more generally N-up refers to a page
layout strategy in which multiple pages are composited onto a
single page.

Bug: 775999
Change-Id: I7c3b78a6d7b2fdaaa3d67e456b6b3b624480897e
Reviewed-on: https://chromium-review.googlesource.com/1172100
Commit-Queue: Shirleen Lou <xlou@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585097}

This feature never launched to stable, and beta results were lukewarm.

Bug: 871496,596676
Change-Id: I9628acd33c50bff7ddf3cf612c6bbe963a3c4682
Reviewed-on: https://chromium-review.googlesource.com/1183634Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585096}

https://pdfium.googlesource.com/pdfium.git/+log/94822b57c10e..3caad939aead


git log 94822b57c10e..3caad939aead --date=short --no-merges --format='%ad %ae %s'
2018-08-22 thestig@chromium.org Roll tools/clang/ dec27d726..13b165992 (29 commits)
2018-08-22 thestig@chromium.org Roll third_party/depot_tools/ 5484b866d..02d534031 (93 commits; 18 trivial rolls)
2018-08-22 thestig@chromium.org Roll third_party/zlib/ 39b4a6260..dcf1d0f8c (6 commits)
2018-08-22 thestig@chromium.org Roll third_party/binutils/ e146228c2..4110e0919 (2 commits)
2018-08-22 thestig@chromium.org Roll third_party/googletest/src/ ce468a17c..d52663267 (62 commits)
2018-08-21 tsepez@chromium.org Use UnownedPtr in CPDF_VariableText
2018-08-21 tsepez@chromium.org Use UnownedPtr<> to theme provider in cfwl_widgetproperties.h
2018-08-21 tsepez@chromium.org Use UnownedPtr<> in xfa_resolvenode_rs.h
2018-08-21 hnakashima@chromium.org Remove dead code in CBC_CommonBitMatrix.
2018-08-21 tsepez@chromium.org Use UnownedPtr<> in JBIG2_SDDProc.
2018-08-21 tsepez@chromium.org Use UnownedPtr<> in JBig2_GrrdProc.h.
2018-08-21 hnakashima@chromium.org Remove excessive padding above and below PDF417 barcodes.
2018-08-21 tsepez@chromium.org Use UnownedPtr<> in CJBig2_TRDProc.
2018-08-21 tsepez@chromium.org Avoid copying some big vectors in JBIG2_SymbolDict
2018-08-21 thestig@chromium.org Change GetEmbbedObj() to return an Optional<WideString>.
2018-08-21 tsepez@chromium.org Fix lifetime issue in CJBig2_GRDProc::ProgressiveArithDecodeState
2018-08-21 tsepez@chromium.org Allow creation of a MaybeOwned<T> from UnownedPtr<T>.
2018-08-21 hnakashima@chromium.org Optimize rendering of two dimensional barcodes: defer upscale.
2018-08-21 thestig@chromium.org Fix some IWYU issues in xfa/fxfa/.
2018-08-21 hnakashima@chromium.org Fix one-of property JS errors.


Created with:
  gclient setdep -r src/third_party/pdfium@3caad939aead

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:876222,chromium:872907,chromium:872899
TBR=dsinclair@chromium.org

Change-Id: Ia5aa435aa788b862aaf0c474dd646807a687166b
Reviewed-on: https://chromium-review.googlesource.com/1184402Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585095}

Make session observer to be ScopedObserver so it remove itself when out
of scope.
Also add AllowJavascript in some JS call hander.

Bug: 876467
Change-Id: If7cd1c2fe42024708027bee5f87855244c7a4ea9
Reviewed-on: https://chromium-review.googlesource.com/1183590Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585094}

Currently, an encrypted file will simply fail to extract. It is useful
for SafeBrowsing to be able to indicate that the file is encrypted,
instead of malformed.

Bug: 874621
Change-Id: Ie0b2448b0fd2340c554351d1131baa3854a73e44
Reviewed-on: https://chromium-review.googlesource.com/1176558Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Satoru Takabayashi <satorux@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585093}

Adds in the loadshedding behavior according to the design doc. When the
Retry-After header is sent, use that. Otherwise, pick a random interval
from 1-5 minutes.

Also massages the manager API a bit to make testing easier.

Bug: 864650
Change-Id: I485223278a08ad2185c19116552cb934d50f90bf
Reviewed-on: https://chromium-review.googlesource.com/1180069
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585092}

Revert "MacViews: exit early when trying to drag without a drag image instead of crashing on Mojave"

This reverts commit 24c96bd0.

Reason for revert: Mac ASan 64 Tests failing views_unittests, test
case DragDropClientMacTest.ReleaseCapture,
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20ASan%2064%20Tests%20%281%29/43120

Original change's description:
> MacViews: exit early when trying to drag without a drag image instead of crashing on Mojave
> 
> This is a temporary patch to merge back to 69 while we figure out the root cause.
> 
> Bug: 876201
> Change-Id: Id87ac81f16b1cd3102c8605691421e8bc53dc401
> Reviewed-on: https://chromium-review.googlesource.com/1183991
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Commit-Queue: Leonard Grey <lgrey@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#585001}

TBR=ellyjones@chromium.org,lgrey@chromium.org

Change-Id: I80ec51eded1f8ba886eebc0c369ba23b96635c90
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 876201
Reviewed-on: https://chromium-review.googlesource.com/1185142Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585091}

This will make notification latched at an in-between position by
partially sliding it left or right, when the notification has either or
both snooze/settings buttons. The position to latch the slider changes
based on the number of those buttons.
This change does not yet show buttons there.

The feature is behind a flag.
To test this, add --enable-features=NotificationSwipeControl flag.

Bug: 840497
Change-Id: I5fce9216ebae79112d66eb289f6e669347c4aba7
Reviewed-on: https://chromium-review.googlesource.com/1177464Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585090}

(The motivation here is to fix a compile error on the libc++ bot -- looks like
std::size() is a C++17 thing, and libc++ only enables these functions with
/std:c++17 while the MSVC STL allows it even in C++14 language mode. But using
strlen() is simpler too.)

Bug: 801780
Change-Id: Ic955935253e61d3a3947a314a2bdc3e0a9354016
Reviewed-on: https://chromium-review.googlesource.com/1182081Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585089}