- 11 Feb, 2016 11 commits
-
-
ortuno authored
Eventually sandboxed iframes may be explicitly granted the right to request permissions but for now we block any Bluetooth requests from sandboxed iframes. BUG=579691 Review URL: https://codereview.chromium.org/1672863002 Cr-Commit-Position: refs/heads/master@{#374804}
-
rch authored
BUG= Review URL: https://codereview.chromium.org/1680243005 Cr-Commit-Position: refs/heads/master@{#374803}
-
qinmin authored
Currently download cancel and download failure are treated in the same way. This causes the DownloadController to receive a download failure call when cancelling a download. And the DownloadNotificationService will show a failure notification after user hit cancel button. This CL splits download cancel from download failure. So when user cancels a download, we won't show the failure notification. BUG=579110 Review URL: https://codereview.chromium.org/1684293002 Cr-Commit-Position: refs/heads/master@{#374802}
-
lushnikov authored
The patch avoids serializing array indexes in getCompletions function. BUG=585877 R=pfeldman, kozyatinskiy Review URL: https://codereview.chromium.org/1685683006 Cr-Commit-Position: refs/heads/master@{#374801}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/64e75330916f..1de415f2c33f $ git log 64e753309..1de415f2c --date=short --no-merges --format='%ad %ae %s' 2016-02-10 kjlubick Revert of Make SkPicture/SkImageGenerator default to SkCodec (patchset #7 id:120001 of https://codereview.chromium.org/1671193002/ ) 2016-02-10 scroggo Make SkPicture/SkImageGenerator default to SkCodec 2016-02-10 bsalomon Turn on conservative raster clip for GPU canvases GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1682223002 2016-02-10 egdaniel Finalize gpu shaders in ProgramBuilding. 2016-02-10 joshualitt Fix for mips build 2016-02-10 reed move compose-shader into base-class as factory 2016-02-10 joshualitt cleanup textblob cache sanity check and prevent it from bitrotting 2016-02-10 msarett Clean up comments in SkSwizzler 2016-02-10 mtklein Sk4f: floor() via int32_t roundtrip. 2016-02-10 msarett Enable ImageGenerator tests on direct raster and direct gpu backends 2016-02-10 ethannicholas Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas. SkJSONCanvas and SkJSONRenderer will be deleted once the debug server has been updated. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1681643002 2016-02-10 caryclark Revert of Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas. (patchset #3 id:40001 of https://codereview.chromium.org/1681643002/ ) CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel;tryserver.chromium.win:win_clang_dbg TBR=kjlubick@google.com Review URL: https://codereview.chromium.org/1686553005 Cr-Commit-Position: refs/heads/master@{#374800}
-
dgrogan authored
The bug has an old repro that depends on whether the inner table is floated. This no longer seems to have an impact on our behavior. BUG=244182 Review URL: https://codereview.chromium.org/1682453004 Cr-Commit-Position: refs/heads/master@{#374799}
-
rob authored
BUG=585471 Review URL: https://codereview.chromium.org/1691453002 Cr-Commit-Position: refs/heads/master@{#374798}
-
dfalcantara authored
* Adds an icon to CCTs opened by Chrome that allows the user to open the URL in the full Chrome browser. * Allows CustomTabActivity to be finished() when it fires a PendingIntent that was created by Chrome itself. * Adds an icon for the "open in chrome" action. BUG=582539 Review URL: https://codereview.chromium.org/1683533002 Cr-Commit-Position: refs/heads/master@{#374797}
-
atotic authored
It gets tricky to match tests with their images without borders BUG= Review URL: https://codereview.chromium.org/1686433004 Cr-Commit-Position: refs/heads/master@{#374796}
-
mattm authored
The explicit sequence tag on the Name was not being stripped. BUG=none Review URL: https://codereview.chromium.org/1686003002 Cr-Commit-Position: refs/heads/master@{#374795}
-
kojii authored
When the writing-mode of ancestors of an orthogonal writing-mode root were changed, the orthogonal writing-mode root may no longer be orthogonal to its parent. However, since the style of the orthogonal writing-mode root was not changed, its styleDidChange() is not called and thus FrameView fails to track it. This patch checks children to mark or unmark as orthogonal roots when the writing-mode was changed after they were created. BUG=584185, 584210 Review URL: https://codereview.chromium.org/1672003002 Cr-Commit-Position: refs/heads/master@{#374794}
-
- 10 Feb, 2016 29 commits
-
-
imcheng authored
Add missing RuntimeEnabled=Presentation annotation to PresentationConnectionCloseEvent.idl. BUG=585879 TBR=mlamouri@chromium.org Review URL: https://codereview.chromium.org/1689453005 Cr-Commit-Position: refs/heads/master@{#374793}
-
loyso authored
Disclaimer: This CL is only about moving files and sections of code. We: - Remove Web prefixes on files/classes and add Compositor prefix where necessary. - Move exported/WebTransformKeyframe.cpp and exported/WebFilterKeyframe.cpp to animation/ to group them with their headers. - Move CompositorFilterOperations not to animation/ but to graphics/ folder, because it's a property of WebLayer. - Introduce CompositorFactory singleton (works as Platform) to create CC objects in blink. All animation methods are moved from CompositorSupport to CompositorFactory. Other methods are also expected to be moved there. - Decouple WebLayer and WebCompositorAnimation interfaces by using cc::Animation class. It allows us to make WebCompositorAnimation non-public. WebLayer animation dependencies will go away when we erase the old animation system (it's already disabled). http://crbug.com/575041 - Move static asserts from content/child/assert_matching_enums.cc to Source/platform/WebCompositorAnimation.cpp (so the enum becomes non-public). What's next (separate CLs): - Remove virtual functions (when gmock-based tests erased) - Remove redundant enum declarations (using alias). - Erase the animation delegate adapter. BUG=577016 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1616653002 Cr-Commit-Position: refs/heads/master@{#374792}
-
thakis authored
BUG=none Review URL: https://codereview.chromium.org/1683123002 Cr-Commit-Position: refs/heads/master@{#374791}
-
nacl-deps-roller authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/49db56d2728a..cc49e1df2b55 $ git log 49db56d27..cc49e1df2 --date=short --no-merges --format='%ad %ae %s' 2016-02-10 mseaborn Cleanup: Remove NaClAppShutdown(), which is no longer used 2016-02-10 mseaborn Cleanup: Remove src/trusted/service_runtime/'s last dependency on SRPC CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build TBR=mseaborn@chromium.org Review URL: https://codereview.chromium.org/1683333002 Cr-Commit-Position: refs/heads/master@{#374790}
-
scottmg authored
Was only required for different |HostDesktopType|s which are being removed. R=benwells@chromium.org BUG=558054 Review URL: https://codereview.chromium.org/1682183002 Cr-Commit-Position: refs/heads/master@{#374789}
-
jam authored
Add comments for struct members that were changed from size_t to uin32_t or uint64_t for IPC safety. Also add a few checked_cast for places where we converted from size_t and we're sure that it's safe. BUG=581409 Review URL: https://codereview.chromium.org/1684793003 Cr-Commit-Position: refs/heads/master@{#374788}
-
meacer authored
BUG=557558 Review URL: https://codereview.chromium.org/1544803004 Cr-Commit-Position: refs/heads/master@{#374787}
-
ccameron authored
This papers over the asserts that are occurring on the trybots by changing the failing DCHECKs to not fail the reason for the failure was IOSurfaceIsInUse returning YES unexpectedly. This lets the asserts stay (mostly, completely on non-Mac platforms) in place, but un-breaks the tryservers. BUG=577121 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1688953002 Cr-Commit-Position: refs/heads/master@{#374786}
-
davidben authored
https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/9cc4f2f79988..8eecac0feef4 $ git log 9cc4f2f79..8eecac0fe --date=short --no-merges --format='%ad %ae %s' 2016-02-09 davidben Remove use_system_libsrtp build knob. BUG=501318 Review URL: https://codereview.chromium.org/1685283002 Cr-Commit-Position: refs/heads/master@{#374785}
-
pilgrim authored
These proxy LayoutSVGInline and LayoutSVGTextPath, respectively. The LineLayoutSVGInline class currently has no proxied methods, but it is an ancestor for LineLayoutSVGTextPath, which has two new proxied methods, layoutPath() and calculateStartOffset(). Both methods are called from SVGTextLayoutEngine. There are no functional changes. BUG=499321 TBR=leviw Review URL: https://codereview.chromium.org/1665413003 Cr-Commit-Position: refs/heads/master@{#374784}
-
pkasting authored
Custom frames on Win 10 are just like custom frames on <10. BUG=none TEST=none Review URL: https://codereview.chromium.org/1683873003 Cr-Commit-Position: refs/heads/master@{#374783}
-
dschuyler authored
This CL wraps the edit dictionary page in .settings-box .block and indents the word list using .list-frame. BUG=512479 Review URL: https://codereview.chromium.org/1687753002 Cr-Commit-Position: refs/heads/master@{#374782}
-
jbudorick authored
The bot was removed a while ago. BUG= TBR=martiniss@chromium.org,stip@chromium.org Review URL: https://codereview.chromium.org/1691563002 Cr-Commit-Position: refs/heads/master@{#374781}
-
slan authored
Chromecast code depends on media:: alsa code, so enable it by default. use_pulseaudio will continue to be false when is_chromecast=true. BUG= b/27105215 TEST= Builds on several Cast platforms. Review URL: https://codereview.chromium.org/1678103007 Cr-Commit-Position: refs/heads/master@{#374780}
-
zentaro authored
For provided file systems; a) Directory tree only navigates open nodes. b) Tree closes child nodes when parent closes. c) Expander arrows are always added rather than traversing the children to determine if needed. d) Expander arrows will disappear if expanded and there is no content. BUG=584404 Review URL: https://codereview.chromium.org/1667163003 Cr-Commit-Position: refs/heads/master@{#374779}
-
reillyg authored
This change removes the code to create a Mojo app containing device services (currently only USB) and instead makes the Mojo bindings for //device/usb part of that directory. The Mojo service implementation is still in a separate //device/usb/mojo target but this will eventually merge into its parent directory as the Mojo interface becomes the only public interface for //device/usb. BUG=None Review URL: https://codereview.chromium.org/1682363002 Cr-Commit-Position: refs/heads/master@{#374778}
-
dyen authored
R=kbr@chromium.org BUG=584872 Review URL: https://codereview.chromium.org/1684203002 Cr-Commit-Position: refs/heads/master@{#374777}
-
Walter Korman authored
https://chromium.googlesource.com/chromium/src/+/0c7e2f7bc BUG=581355 TBR=fmalita@chromium.org Review URL: https://codereview.chromium.org/1690803002 . Cr-Commit-Position: refs/heads/master@{#374776}
-
Walter Korman authored
https://chromium.googlesource.com/chromium/src/+/0c7e2f7bc BUG=581355 TBR=fmalita@chromium.org Review URL: https://codereview.chromium.org/1687093005 . Cr-Commit-Position: refs/heads/master@{#374775}
-
rajendrant authored
DataUse UI message strings shown in snackbars and interstitial dialogs, should be changeable via Finch. Since the UI string overrides in Finch are not accessible from java localization API, a JNI wrapper is used to get the overrides from C++ to java. BUG=485160 Review URL: https://codereview.chromium.org/1678943002 Cr-Commit-Position: refs/heads/master@{#374774}
-
hubbe authored
BUG=514719 Review URL: https://codereview.chromium.org/1670753003 Cr-Commit-Position: refs/heads/master@{#374773}
-
sigbjornf authored
TBR=oilpan-reviews BUG=552289 Review URL: https://codereview.chromium.org/1689773002 Cr-Commit-Position: refs/heads/master@{#374772}
-
erikchen authored
Revert of Clean up public interface of AttachmentBrokerUnprivileged. (patchset #4 id:80001 of https://codereview.chromium.org/1679763002/ ) Reason for revert: c:\b\build\slave\win\build\src\remoting\host\remoting_me2me_host.cc(937) : error C2065: 'attachment_broker_' : undeclared identifier http://build.chromium.org/p/chromium/builders/Win/builds/40168 Original issue's description: > Clean up public interface of AttachmentBrokerUnprivileged. > > In the old interface, a static factory method returns a scoped_ptr, and the > caller had to manage the lifetime. Since this is a global object with minimal > memory footprint, and is required to outlive every IPC::Channel, it's much > easier for the global to never be destroyed. This also matches the interface for > AttachmentBrokerPrivileged. > > BUG=584297 TBR=tsepez@chromium.org,avi@chromium.org,mseaborn@chromium.org,sergeyu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=584297 Review URL: https://codereview.chromium.org/1688433005 Cr-Commit-Position: refs/heads/master@{#374771}
-
tridgell authored
All methods used for generating the underlying matrix in asMatrix are in MatrixTransformComponent.cpp Constructs each MatrixTransformComponent for use in asMatrix methods manually, rather than using inbuilt methods to avoid unnecessary matrix multiplication. (With the exception of rotate and rotate3d, as they require far more complex calculations.) Note: asMatrix for a MatrixTransformComponent returns a clone. BUG=545318 Review URL: https://codereview.chromium.org/1648853002 Cr-Commit-Position: refs/heads/master@{#374770}
-
jzern authored
improves performance ~11-22% depending on the device and whether the image was lossless or lossily compressed. BUG=416951 Review URL: https://codereview.chromium.org/1657113002 Cr-Commit-Position: refs/heads/master@{#374769}
-
shess authored
Replace dependencies on SQLite's Pager and DbPage structures with local wrappers, in preparation for rewriting those wrappers in terms of sqlite3_file. The primary substantive change is that RecoverPager is an owned reference, while Pager was a reference shared with SQLite at large. DbPage already needed ref-counting so RecoverPage matches that. BUG=584407 Review URL: https://codereview.chromium.org/1671043003 Cr-Commit-Position: refs/heads/master@{#374768}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/26c72b54..4e3834b0 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1685193002 Cr-Commit-Position: refs/heads/master@{#374767}
-
miu authored
This change renames WebRtcLocalAudioRenderer to TrackAudioRenderer and re-purposes it for rendering all local MediaStream audio tracks, and non-PeerConnection/WebRTC-sourced remote audio tracks (e.g., Cast Streaming). In addition, a number of small functional changes were made to fix audio glitching, especially surrounding Start/Stop/Mute operations: 1. Improved accuracy of GetCurrentRenderTime(), based on audio sample counts rather than using the system clock. 2. Removed the stopping of audio render on mute. This would cause the video player to freeze the video unintentionally. 3. Drop/re-create AudioShifter on any pause-then-play, audio format change, or output device change. The existing Flush() mechanic was causing weird time-shifting effects when the audio data flow was restarted due to retaining the old timing data history. 4. Corrected a timing calculation in the playout_time passed to AudioShifter::Pull(). Since the playout_time is supposed to be "in the future," the correct timestamp should be "now plus audio delay" and not "now minus audio delay." 5. Removed legacy call to GetOptimalBufferSize() for the audio output buffer size. After reviewing the history on this code, I believe it was probably just masked issues that were recently resolved by AudioShifter. Testing demonstrated the extra buffering was not needed. Other changes: Clarified and refreshed documentative code comments. Code clean-ups in media_stream_renderer_factory_impl.cc (e.g., removed output argument in favor of a return value). Testing: 1. Connected a chrome.tabCapture.capture() MediaStream to a local VIDEO element and confirmed reliable playback with good AV sync. 2. Using https://webrtc.github.io/samples/src/content/peerconnection/pc1/ to confirm the WebRTC use case was not broken. 3. Cast Streaming loopback testing (using a simple test extension). BUG=577881, 577874 Review URL: https://codereview.chromium.org/1633423002 Cr-Commit-Position: refs/heads/master@{#374766}
-
pmonette authored
Review URL: https://codereview.chromium.org/1685233002 Cr-Commit-Position: refs/heads/master@{#374765}
-