- 26 Aug, 2016 40 commits
-
-
pkalinnikov authored
This CL fixes the bug where UnindexedRulesetWriter doesn't trim the CodedOutputStream on Finish, resulting in the output having some extra uninitialized bytes at the end. BUG=609747 Review-Url: https://codereview.chromium.org/2279803002 Cr-Commit-Position: refs/heads/master@{#414762}
-
ellyjones authored
BUG= Review-Url: https://codereview.chromium.org/2282793002 Cr-Commit-Position: refs/heads/master@{#414761}
-
qinmin authored
When download snackbar shows up, clicking the open button will open download home for offline page. This CL corrects that behavior so that the corresponding offline page will be opened. BUG=641262 Review-Url: https://codereview.chromium.org/2274573008 Cr-Commit-Position: refs/heads/master@{#414760}
-
dcastagna authored
When a fullscreen quad is promoted to overlay, it should be removed from quad_list to be GL composited. This CL fixes a bug where OverlayStrategyFullscreen assumed that the first quad would always be the one to remove. BUG=b/29430506 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2280823002 Cr-Commit-Position: refs/heads/master@{#414759}
-
ortuno authored
BluetoothChooserController, which is in chrome/, was including BluetoothMetrics which is in content/. To avoid this we create a new histogram specifically for interactions with the chooser. BUG=641105 Review-Url: https://codereview.chromium.org/2278003003 Cr-Commit-Position: refs/heads/master@{#414758}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/9b57ec9ff50a..3e98158a6c47 $ git log 9b57ec9ff..3e98158a6 --date=short --no-merges --format='%ad %ae %s' 2016-08-26 tonikitoo Extend pdfium_test capability so that more Javascript can be executed TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2281053002 Cr-Commit-Position: refs/heads/master@{#414757}
-
csharrison authored
This change adds a StyleSheetResourceClient on all CSS preloads. The client holds a CSSPreloadScanner which receives the stream of CSS as it comes in. This is guarded by two Blink settings, cssExternalScannerPreload and cssExternalScannerNoPreload. The former allows for scanning and preloading and the latter just allows for scanning, as a baseline for the overhead of the feature. This is partially a reland of https://codereview.chromium.org/1819593002, which was reverted manually here: https://codereview.chromium.org/1947053002/ The revert was due to a crash and some faulty logic with regard to all css preload requests being considered "referenced". This CL attempts to fix that by adding an enum to mark a ResourceClient as "passive". BUG=610437,596676 Review-Url: https://codereview.chromium.org/1976463003 Cr-Commit-Position: refs/heads/master@{#414756}
-
bgoldman authored
This is an initial Blimp integration test that exercises navigation history. The purpose is to test the integration with WebContentsImpl and NavigationControllerImpl, as well as the proper flow of Blimp's NavigationStateChangeMessage protobuf across the client-engine network connection. The test visits two different web pages and then goes back to the first one. Additional supporting changes: * Moving some setup code from the initial LoadUrl test into SetUpOnMainThread. * Helper method ExpectPageLoad, which sets mock expectations for a page load, and can be used with the helper method RunAndVerify to wait for Blimp to load a page. * Always storing the latest page title when it changes on the client side, making it easier to assert about what page was most recently loaded. Review-Url: https://codereview.chromium.org/2272513003 Cr-Commit-Position: refs/heads/master@{#414755}
-
zqzhang authored
Notification PendingIntents having the same name will conflict with each other. This CL fixes the conflict for MediaNotification stop button and swipe away, which now fire different actions but we treat both as ACTION_STOP. BUG=640301 Review-Url: https://codereview.chromium.org/2279263002 Cr-Commit-Position: refs/heads/master@{#414754}
-
rbyers authored
Remove the mostly useless CountBits abstraction and better align the generic feature and CSS property usage tracking. Also a couple other minor cleanups and comments warning of outstanding issues. BUG=597963 Review-Url: https://codereview.chromium.org/2284503002 Cr-Commit-Position: refs/heads/master@{#414753}
-
ellyjones authored
The main use of these by end-users is to disable cursor blink by setting them to extremely large values. BUG=500168 Review-Url: https://codereview.chromium.org/2282533002 Cr-Commit-Position: refs/heads/master@{#414752}
-
lukasza authored
Also tighten up the matcher to also require that |value| field: - is public, - is inside a struct-or-class that doesn't have any methods. BUG=640749 Review-Url: https://codereview.chromium.org/2283553002 Cr-Commit-Position: refs/heads/master@{#414751}
-
danakj authored
This was mostly tracked because while lost the main thread Renderer capabilities would not be valid. However a few things have changed now: 1) No more renderer capabilities. So 2) We don't care if we main frame without an output surface. 3) We don't defer commits on the main thread so we wouldn't try to start a frame on the main thread while the output surface is lost anyways. The only exception is SingleThreadProxy needs to know to request and output surface when doing synchronous composite things. So it does that itself now. R=enne BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2270573002 Cr-Commit-Position: refs/heads/master@{#414750}
-
chili authored
BUG=635644 Review-Url: https://codereview.chromium.org/2273373003 Cr-Commit-Position: refs/heads/master@{#414749}
-
moshayedi authored
This CL: * Uses Mus' IMEServer to do the IME logic in InputMethodMus. * Adds unittests to test InputMethodMus. * Starts test_ime_driver on mus+ash session startup. * Modifies test_ime_driver to not-handle non character events. BUG=548407 Review-Url: https://codereview.chromium.org/2230393002 Cr-Commit-Position: refs/heads/master@{#414748}
-
jeffcarp authored
(This is my first CL so please let me know if I'm doing something wrong) BUG=614963 Review-Url: https://codereview.chromium.org/2273363004 Cr-Commit-Position: refs/heads/master@{#414747}
-
mcchou authored
The copy constructor was trying to call DeepCopy() against a nullptr. This adds a check if the type is NULLTYPE and return base::Value() if so. BUG=b:30963813 TEST=call the copy constructor with a NULLTYPE instance to see if it crashes Review-Url: https://codereview.chromium.org/2284713002 Cr-Commit-Position: refs/heads/master@{#414746}
-
ikilpatrick authored
NGConstraintSpace now has a backing NGPhysicalConstaintSpace and provides abstract coordinate system accessors for everything. Makes NG*ConstraintSpace GarbagedCollected as well as we'll need this once we move to a state machine / for caching fragment results. BUG=635619 Review-Url: https://codereview.chromium.org/2267383003 Cr-Commit-Position: refs/heads/master@{#414745}
-
yzshen authored
BUG=None Review-Url: https://codereview.chromium.org/2277903004 Cr-Commit-Position: refs/heads/master@{#414744}
-
johnme authored
BUG=641400 TBR=michaelpg@chromium.org NOTRY=true NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2284823002 Cr-Commit-Position: refs/heads/master@{#414743}
-
fdoray authored
This CL removes calls to these methods from gpu/ files: - MessageLoop::PostTask - MessageLoop::PostDelayedTask - MessageLoop::ReleaseSoon - MessageLoop::DeleteSoon - MessageLoop::Run - MessageLoop::RunUntilIdle BUG=616447 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2274213004 Cr-Commit-Position: refs/heads/master@{#414742}
-
robpercival authored
BUG=631087 Review-Url: https://codereview.chromium.org/2183073002 Cr-Commit-Position: refs/heads/master@{#414741}
-
einbinder authored
This is in preperation for CodeMirror-based console BUG=607690 NOTRY=true Review-Url: https://codereview.chromium.org/2271683003 Cr-Commit-Position: refs/heads/master@{#414740}
-
kraynov authored
Integration between newly indroduced trace buffer writer and proto generated stubs. BUG=608719 Review-Url: https://codereview.chromium.org/2281903002 Cr-Commit-Position: refs/heads/master@{#414739}
-
mvanouwerkerk authored
BUG=637257 Review-Url: https://codereview.chromium.org/2275693003 Cr-Commit-Position: refs/heads/master@{#414738}
-
johnme authored
The following tests are flaky on all platforms: - DumpAccessibilityTreeTest.AccessibilityIframeTransform - DumpAccessibilityTreeTest.AccessibilityIframeCoordinates - DumpAccessibilityTreeTest.AccessibilityIframeCoordinatesCrossProcess - DumpAccessibilityTreeTest.AccessibilityIframeTransformCrossProcess http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=DumpAccessibilityTreeTest.AccessibilityIframe NOTREECHECKS=true NOTRY=true BUG=622387 TBR=dmazzoni@chromium.org Review-Url: https://codereview.chromium.org/2282903002 Cr-Commit-Position: refs/heads/master@{#414737}
-
jamescook authored
It's confusing whether to add new accelerators to AcceleratorController vs. AcceleratorControllerDelegateAura. Add some comments. BUG=none TEST=none Review-Url: https://codereview.chromium.org/2282853002 Cr-Commit-Position: refs/heads/master@{#414736}
-
lethalantidote authored
This CL reorganizes classes that derived from LocationArbitrator to instead derive from LocationProvider. There was a quite a bit of overlap between the two interfaces, and merging the two in favor of LocationProvider makes later work with Blimp much easier. Other work included: *Addresses TODO to remove CreateArbitrator in favor of SetArbitratorForTest BUG=614486, 637869 Review-Url: https://codereview.chromium.org/2226143002 Cr-Commit-Position: refs/heads/master@{#414735}
-
gogerald authored
BUG=b/31003541 Review-Url: https://codereview.chromium.org/2284563004 Cr-Commit-Position: refs/heads/master@{#414734}
-
jdufault authored
BUG=616112 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2258553004 Cr-Commit-Position: refs/heads/master@{#414733}
-
edchin authored
Change makes for more modular architecture. This allows the user of the webserver to build layers of ResponseProviders instead of creating a single monolithic provider. BUG=none Review-Url: https://codereview.chromium.org/2285773002 Cr-Commit-Position: refs/heads/master@{#414732}
-
estade authored
Overview mode is probably more useful to people who are trying to use a touch screen. Simply no-op on Alt+Tab when the virtual keyboard's showing. BUG=638269 Review-Url: https://codereview.chromium.org/2256283003 Cr-Commit-Position: refs/heads/master@{#414731}
-
fs authored
Synchronize hit-testing code with rendering code with regards to how the coordinate space is handled (for userSpaceOnUse <clipPath>s), and how the reference boxes is computed. Also "straighten" out code-flow a bit while here. BUG=418484 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2280963002 Cr-Commit-Position: refs/heads/master@{#414730}
-
rdsmith authored
BUG=572740 R=davidben@chromium.org Review-Url: https://codereview.chromium.org/2282523002 Cr-Commit-Position: refs/heads/master@{#414729}
-
mustaq authored
Covered both unconditional firing and firing for captured pointer ids. BUG=640637 TBR=isherman@chromium.org Review-Url: https://codereview.chromium.org/2274253002 Cr-Commit-Position: refs/heads/master@{#414728}
-
siggi authored
R=chrisha@chromium.org TBR=primiano@chromium.org BUG=641242 Review-Url: https://codereview.chromium.org/2282763002 Cr-Commit-Position: refs/heads/master@{#414727}
-
tkent authored
This is a preparation to remove WTFLogAlwasy() from Node.cpp. This CL has no behavior changes. BUG=638849 Review-Url: https://codereview.chromium.org/2282683002 Cr-Commit-Position: refs/heads/master@{#414726}
-
rdevlin.cronin authored
In the renderer, we need to parse the extension schema string and pass it to JS in order to create our bindings. However, right now, we first parse this into a DictionaryValue, and then convert it into a v8::Object. However, now that we fully generate all the schema code, we should be able to parse it directly from a string into a v8::Object. BUG=640247 Review-Url: https://codereview.chromium.org/2271813003 Cr-Commit-Position: refs/heads/master@{#414725}
-
treib authored
BUG=638930 Review-Url: https://codereview.chromium.org/2282743002 Cr-Commit-Position: refs/heads/master@{#414724}
-
rdevlin.cronin authored
BUG=497340 Review-Url: https://codereview.chromium.org/2279753004 Cr-Commit-Position: refs/heads/master@{#414723}
-