- 05 Oct, 2018 40 commits
-
-
Christian Biesinger authored
We should also consider inlining most of the rest of the functions, but as that requires including layout_box.h in the header I wasn't sure if I should do that in this CL. R=eae@chromium.org, mstensho@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia11009965653f57144ff6937c3e1b9265d44fe6e Reviewed-on: https://chromium-review.googlesource.com/c/1265124Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#597279}
-
Min Qin authored
This CL allows us to create the network service when service manager is running, and sets the URLLOaderFactoryGetter for InProgressManager. This should allow download to resume without browser process. BUG=842245 Change-Id: Id985b5d6adc4144f4b51588ba4659f57cf607e31 Reviewed-on: https://chromium-review.googlesource.com/c/1264523Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#597278}
-
Boris Sazonov authored
This CL adds a wrapper around ImageViewCompat.setImageTintList that sets the tint mode to default (PorterDuff.Mode.SRC_IN) if there's no tint mode yet. This is necessary because tint mode is checked by ImageViewCompat.setImageTintList to trigger a workaround for a bug in Android L. Bug: 891609 Change-Id: Ia799bdfd5fa597e6e10622784544ae1fa9a3d842 Reviewed-on: https://chromium-review.googlesource.com/c/1264756Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#597277}
-
Chris Lu authored
Creates new NativeActivityOverlayCoordinator that presents a NativeActivityOverlayViewController to show the activity indicator. Presents it from ClearBrowsingDataTableViewController before executing remove browsing data, and removes it in the callback. Video: https://drive.google.com/file/d/1qWKW7L4Q1K_SWRkJirl1oogPvjRxgfLh/view?usp=sharing https://drive.google.com/file/d/1cZ43c6iJA9mhbr_95DgJXGHS33zGCvAO/view?usp=sharing Bug: 760598 Change-Id: I4b4bde0811502691438e520c87e128496cdd0e1b Reviewed-on: https://chromium-review.googlesource.com/c/1259483 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#597276}
-
Francois Doray authored
No need to create a TaskRunner to do a one-off PostTaskAndReplyWithResult(). Change-Id: Icb3f731906863431b03b9e932baf39dbe9d74218 Reviewed-on: https://chromium-review.googlesource.com/c/1230700 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#597275}
-
Kevin McNee authored
This reverts commit 93aa458f. Reason for revert: Suspect for build failure https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-rel/2802 Original change's description: > Android build: moved proguarding into dex() for most cases > > This is to allow R8 to proguard and dex in one call, since it has some > optimizations that only work when doing everything in one shot. > > Bug: 872904 > Change-Id: Id2c75dac4d9feecae461a0b1e279056253f1b71b > Reviewed-on: https://chromium-review.googlesource.com/c/1227142 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Commit-Queue: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#597257} TBR=yfriedman@chromium.org,agrieve@chromium.org,smaier@chromium.org Change-Id: Idf8f855094fb1bf4c4e1b47326b76166a158c1e8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 872904 Reviewed-on: https://chromium-review.googlesource.com/c/1265559Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#597274}
-
Ken Rockot authored
This changes views::RemoteViewHost and ws::ServerRemoteViewHost slightly, such that they are attached to an aura window as soon as possible (upon addition to a widget) rather than waiting for the initiation of an embed request. Bug: 854367 Change-Id: I684abe7568318b0ced412e1bc6bdb52a866aa9b5 Reviewed-on: https://chromium-review.googlesource.com/c/1255460 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#597273}
-
Kevin McNee authored
The wrong union member is written to during deserialization of the contact_size. A few tap types have been added in switch statements where they were missing. Bug: None Change-Id: I7f1b389070bd42b540ed78cfaff40cc463827d79 Reviewed-on: https://chromium-review.googlesource.com/c/1252633Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#597272}
-
Stephen Martinis authored
Bug: 892366 Change-Id: I091de0ff478bf4d6a955b2fcab57dff4e4429d75 Reviewed-on: https://chromium-review.googlesource.com/c/1265503 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#597271}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4e9584b32dfe..89a5e559a7c9 Created with: gclient setdep -r src-internal@89a5e559a7c9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:892125 TBR=mmoss@chromium.org Change-Id: I25a39107cdbc9bad3867f61d6ddf3bbbbe202f98 Reviewed-on: https://chromium-review.googlesource.com/c/1265044Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597270}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/de52d9ad295e..4fc4281d2152 git log de52d9ad295e..4fc4281d2152 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 benjhayden@chromium.org Update benchmark_owner_emailer to new alerts API. Created with: gclient setdep -r src/third_party/catapult@4fc4281d2152 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ic609848dddbc3b56183c399aa7c8793faf54eb8c Reviewed-on: https://chromium-review.googlesource.com/c/1265043Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597269}
-
Marijn Kruisselbrink authored
This test is flaky on at least windows and linux. Bug: 892032 Change-Id: If541fa6c5a4ad118c3c5ab143bfd7fe5aec177e6 Tbr: sahel@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1265499Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#597268}
-
Sigurdur Asgeirsson authored
Bug: 891310 Change-Id: Ie3aeb33c2f6031bdafd2ded0131cc54e1ee496cf Reviewed-on: https://chromium-review.googlesource.com/c/1256907Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#597267}
-
Morten Stenshorne authored
The paint code doesn't like anonymous scrollable containers, so just disable non-visible overflow support for LayoutNGFieldset. Bug: 875235 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ice03f866bd3e61d8b0b8137089c4de254c0b81f5 Reviewed-on: https://chromium-review.googlesource.com/c/1264661Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#597266}
-
Sergey Poromov authored
Increasing from 3 to 10 seconds as it now takes around 3 seconds to show the screen on the slow devices. This is an easy temporary fix. Perfectly, controller should start timer only when splash screen is actually shown. Bug: 890368 Change-Id: I2048a54c1df7f2474cc29eb1d00e06bac3ff1e7f Reviewed-on: https://chromium-review.googlesource.com/c/1264635Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#597265}
-
Etienne Pierre-doray authored
Adds kVAWidth to Elf32Traits and use it in DisassemblerElfIntel::MakeReferenceGroups as the width of kReloc and kAbs32 reference types. Bug: 892359 Change-Id: I28930b8978393c16ee29051c48496e4f696a3fcd Reviewed-on: https://chromium-review.googlesource.com/c/1264816 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#597264}
-
Gabriel Marin authored
Original CL: - https://codereview.chromium.org/295583002 tcmalloc: Honor HEAPPROFILE envvar only in profiling=1 builds. Several systems in chromium (about:tracing, some code in blink) use tcmalloc's heap profiler, so keep most of it around. Do disable support for the HEAPPROFILE envvar, and for the exit-time dump to "Exiting" (unless in profiling=1 builds), as that causes a static initializer. BUG=94925 R=willchan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271415 BUG=724399,b:70905156 Change-Id: Ib80ec045a2cdadb714bd1f9c3daab2c63be9874b Reviewed-on: https://chromium-review.googlesource.com/c/1130806Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#597263}
-
A Olsen authored
src/chrome/browser/chromeos/settings OWNERS should also own src/chromeos/settings, so now they do. Moved the OWNERS file to chromeos/settings, and c/b/chromeos/settings OWNERS inherits from there. Bug: 446937 Change-Id: I72202017fa2c0c6fd3f4a322b8ea38dfb3bc6c04 Reviewed-on: https://chromium-review.googlesource.com/c/1264584 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#597262}
-
Jun Choi authored
Connected Bluetooth FidoAuthenticator can be in pairing mode when discovered by the browser, or device can change to pairing mode anytime during the lifetime of FidoDiscovery. As so add function to notify embedder when connected FidoAuthenticator changes its state to pairing mode. Bug: 877344 Change-Id: I3dc46e67064fdf7361b6cf2ef144d7daa907e92a Reviewed-on: https://chromium-review.googlesource.com/c/1246596 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#597261}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8efa341839a6..78df3362ac21 git log 8efa341839a6..78df3362ac21 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 oetuaho@nvidia.com Fix clearing out-of-range default FB drawbuffer Created with: gclient setdep -r src/third_party/angle@78df3362ac21 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: If6e4b8e98a5ff007e4f33f6c0f5ce582394fd6d7 Reviewed-on: https://chromium-review.googlesource.com/c/1265046Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597260}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/96a0f6191781..ef8a3eb5221c git log 96a0f6191781..ef8a3eb5221c --date=short --no-merges --format='%ad %ae %s' 2018-10-05 niklas.enbom@webrtc.org Include NTP value in playout path. 2018-10-05 srte@webrtc.org Removes initial window field trial. 2018-10-05 phensman@webrtc.org Reland "Tidy up and increase exception handling in compare_videos" 2018-10-05 srte@webrtc.org Adds Clamping functions for DataRate. 2018-10-05 srte@webrtc.org Removes logging spam from congestion window. 2018-10-05 aleloi@webrtc.org Reland of 'Bug in histogram metric reporting.' 2018-10-05 brandtr@webrtc.org Remove old data files. 2018-10-05 stefan@webrtc.org Move FecController to RtpVideoSender. 2018-10-05 brandtr@webrtc.org Remove old video_bitrate_allocator.h 2018-10-05 phoglund@webrtc.org Use Chromium's code for locating the src dir. 2018-10-05 stefan@webrtc.org Add UMA metric and logging of frames dropped in the render queue. Created with: gclient setdep -r src/third_party/webrtc@ef8a3eb5221c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:b/80195113 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0e8a33a6699e93da12bdc99774a3b662d0ef7d0b Reviewed-on: https://chromium-review.googlesource.com/c/1265355Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597259}
-
bsheedy authored
Adds support for fake controller input when using OpenVR in the VR browser tests. This is done by adding several new functions and structs to the existing test hook and Mojo interface so that controller data set by a test is retrievable by the fake OpenVR implementation. Bug: 863487 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib9da6756df51093126d641e69fbf96ec05f2270b Reviewed-on: https://chromium-review.googlesource.com/c/1220806 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#597258}
-
Sam Maier authored
This is to allow R8 to proguard and dex in one call, since it has some optimizations that only work when doing everything in one shot. Bug: 872904 Change-Id: Id2c75dac4d9feecae461a0b1e279056253f1b71b Reviewed-on: https://chromium-review.googlesource.com/c/1227142Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#597257}
-
Daniel Bratell authored
The DEPS system and gn will enforce some kind of dependency on //crypto if code needs to use crypto/wincrypt_shim.h. Now, that header file will not in itself indicate a dependency on actual code in //crypto so the dependency becomes a bit unexpected. By moving it to base/win, code can avoid depending on //crypto just to use that header file. This became an issue when //printing needed to use wincrypt_shim.h Change-Id: I68a3b8263da0d4307907a0b242444402675072a4 Reviewed-on: https://chromium-review.googlesource.com/c/1261024Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#597256}
-
Xi Han authored
This is a follow up CL for: https://crrev.com/c/1115783. In this CL, we use ScopedExecutionFence to prevents tasks running between the peorid from BrowserMainRunner is instantiated to BrowserMainLoop::CreateThreads() is called. Bug: 846846 Change-Id: I9dec8415e45f901c5883c196ab867c0ea4928594 Reviewed-on: https://chromium-review.googlesource.com/c/1174955 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#597255}
-
Steven Bennetts authored
Bug: 752315 Change-Id: Iaee8b7f66471482f08dc3c310523e6fb88bb7a50 Reviewed-on: https://chromium-review.googlesource.com/c/1260015Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#597254}
-
Robert Ogden authored
Looks like I missed two things in implementation: * The preview security icon should be Modern Blue 600 * I switched the two colors, making Blue 300 primary instead of Blue 600 Bug: 871839 Change-Id: I3fe0ebaf0fb230a491bcae891ef3f29b4286c00b Reviewed-on: https://chromium-review.googlesource.com/c/1265021Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#597253}
-
Lambros Lambrou authored
In the per-frame statistics, instead of sending raw frame quantizer values from the VPX encoder (from 0-63), this sends a simple measure of frame quality, from 0-100, with 100 being a lossless frame. Bug: 888833 Change-Id: I9e869f2f302232d10311719a209c79e2492579b7 Reviewed-on: https://chromium-review.googlesource.com/c/1263560 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#597252}
-
Jun Choi authored
Expose BluetoothDevice::Pair() function to WebAuthN embedder layer via BleAdapterManager. Previously named BleAdapterPowerManager(which only handled notifying BluetoothAdapter power changes to the embedder) is now renamed to BleAdapterManager and it handles both a) Handling pairing events received from the UI layer. b) Handling events related to triggering/notifying BluetoothAdapter changes. Bug: 877344 TBR: ortuno@chromium.org Change-Id: I078f60cd4b0d491973276a3279503642c94d8d9d Reviewed-on: https://chromium-review.googlesource.com/c/1239621 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#597251}
-
Carlos IL authored
After crrev.com/c/1262637 interstiitals will link to a different support URL for Symantec errors, check against that one too in ConnectionHelpTabHelper. Change-Id: I1318534ad3db2235b1e8f5f383d7c69ad74db65c Reviewed-on: https://chromium-review.googlesource.com/c/1265081Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#597250}
-
danakj authored
When a renderer creates a new frame (via window.open()) it goes through a request to WebContentsImpl to ShowCreatedWindow(). This adds comments to that path, improves code style, changes variable names from "popup" to not confuse this path with popup widgets which are not frames/windows, and changes types to WebContentsImpl instead of WebContents to avoid some casting. Note that some of content does refer to frames/windows opened with window.open() as popups even though they are not popup widgets (ie WebPagePopup in the renderer). R=ajwong@chromium.org, avi@chromium.org Bug: 419087 Change-Id: I76e77a64669ad59577f9681d5bfff13b48830e52 Reviewed-on: https://chromium-review.googlesource.com/c/1262923 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#597249}
-
Tom Anderson authored
This is a followup to r596815 which added pipewire packages to sysroot-creator-sid.sh. That CL's author does not have write permission on the appropriate GCS bucket to upload the new sysroots, so this CL rolls the sysroots. R=thestig CC=tomas.popela@gmail.com Change-Id: Ia9af1c3c490bd0f60f4e0e0b4d32ad0cf09ace72 Reviewed-on: https://chromium-review.googlesource.com/c/1263579Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#597248}
-
Joanmarie Diggs authored
Child elements with role="presentation" and an explicit ARIA names (e.g. an aria-label value) were not participating in the name calculation due to the presentational role trumping the ARIA property value. The ARIA specification states that global ARIA properties trump the role. Fix this by having AXObject::DetermineAriaRoleAttribute() return kUnknown for presentational objects where AXObject::SupportsARIAAttributes() returns true. Change name of SupportsARIAAttributes() to HasGlobalARIAAttribute() as that is what the method appears to for. Also add missing global ARIA attribute to those being checked. In order to be more performant, iterate through all attributes and do a string match, removing sanity checks (e.g. on certain attribute values). This also makes the method more consistent with its new name, namely just checking the presence of a global ARIA attribute. Lastly, ensure that a space character gets inserted between inline block flow children when the text used for a child comes from a text alternative, such as an ARIA label, or a title or alt attribute. This insertion is specified in the Accessible Name and Description Computation specification and also consistent with what other user agents do. Bug: 891731 Change-Id: Ib906acc89ea6d0517288fe0d81e0b74f1abfa583 Reviewed-on: https://chromium-review.googlesource.com/c/1259124 Commit-Queue: Joanmarie Diggs <joanmarie.diggs@gmail.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#597247}
-
Jun Mukai authored
It's been flaky as far as I see in the FYI bot log. Bug: 892263 Test: none Change-Id: I5caf4329168d193d485bca908432f90c7b87ddd2 Reviewed-on: https://chromium-review.googlesource.com/c/1262415Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#597246}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Id19c417438950bb28415db1fb1e91abae23b9a8c Reviewed-on: https://chromium-review.googlesource.com/c/1265419Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597245}
-
Tommy Steimel authored
This CL updates the volume slider length to be shorter in order to fix an issue where the slider is too long for the default audio controls length. Bug: 892048 Change-Id: I545fd2395ec277125f7c6edbfbdc56aa03b2580f Reviewed-on: https://chromium-review.googlesource.com/c/1265057Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#597244}
-
Mounir Lamouri authored
Bug: 892483 Change-Id: Ia0a8347c1f31ba087759c2f53bea156f9d091d41 Reviewed-on: https://chromium-review.googlesource.com/c/1264818Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#597243}
-
Mounir Lamouri authored
This changes follow the spec with regards to pausing a video when it leaves a document: when a video leaves a document, the removal process should continue and, asynchronously, Blink checks that the video is still in an active document. It allows a video to move from one part of the document to another without pausing. Moving into a document or into two different outside of the document trees will also not pause. This is following the specification and Edge/Safari/Firefox implementations. Bug: 382879, 490511 Change-Id: I48abdaa5f81790e2cae7edc7b0bfb444f6ee7787 Reviewed-on: https://chromium-review.googlesource.com/c/1074808 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#597242}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/64626344db73..942603d49e30 git log 64626344db73..942603d49e30 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 ihf@chromium.org Add betty-arcnext to pre-cq. Created with: gclient setdep -r src/third_party/chromite@942603d49e30 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I0660fda5253a32c71f5109b81b8413778e095779 Reviewed-on: https://chromium-review.googlesource.com/c/1265045Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597241}
-
James Wallace-Lee authored
Pass mouse events to chromevox's mouse_handler.js, and fire hover events on mousemove. This allows mousemove events to cause spoken feedback using the same functions as touch exploration. Mouse events are only rewritten if the chromevox option speakTextUnderMouse is enabled. Note: chromevox only receives mousemove events when the mouse is down. Temporarily, this functionality is used by holding the mouse button down and moving the pointer around the page. Bug: 853581 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I2feb14a1f5d765296fde9a923b862c99f45b41bb Reviewed-on: https://chromium-review.googlesource.com/c/1234260Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Cr-Commit-Position: refs/heads/master@{#597240}
-