GitLab

Test=Manual
Bug=None
TBR=zmo

Review URL: https://chromiumcodereview.appspot.com/9706039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126897 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:27837
TEST=ran try


Review URL: http://codereview.chromium.org/9699067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126896 0039d316-1c4b-4281-b951-d872f2087c98

BUG=30704,118384
TBR=dhollowa
Review URL: https://chromiumcodereview.appspot.com/9702069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126895 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126893 0039d316-1c4b-4281-b951-d872f2087c98

TBR=abarth

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9699066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126892 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/9700011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126891 0039d316-1c4b-4281-b951-d872f2087c98

I found a need to look at the implementation to confirm that process_handle would never be assigned to if the call failed. So I added a comment for future readers.

While doing so, I found an edge case where I think the process handle could be leaked.

BUG=None
TEST=Ask a random developer whether they must check process_handle if LaunchProcess returns false. If they look at process_util_*.cc, fail.


Review URL: http://codereview.chromium.org/9689081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126890 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92608
TEST=


Review URL: http://codereview.chromium.org/9203001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126889 0039d316-1c4b-4281-b951-d872f2087c98

So it can self-destruct if Chrome (or Chrome Frame) was the last Omaha-managed product on the system.

BUG=114786
TEST=Install Google Update 1.3.21.105 or later and Chrome w/ --verbose-logging.  Uninstall Chrome and see that Google Update vanishes immediately.  Take a look at chrome_installer.log and look for messages related to Launching Google Update's uninstaller.


Review URL: http://codereview.chromium.org/9693055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126888 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126887 0039d316-1c4b-4281-b951-d872f2087c98

BUG=100235,106104,109485,111371,113638,84779,87094,87408,90967
TEST=http://chromium-build-logs.appspot.com/suppression_query?suppression_query=bug_XXX rocks!
TBR=dhollowa
Review URL: https://chromiumcodereview.appspot.com/9702066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126886 0039d316-1c4b-4281-b951-d872f2087c98

R=jkummerow@chromium.org


Review URL: http://codereview.chromium.org/9703055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126885 0039d316-1c4b-4281-b951-d872f2087c98

It appears to be a common pattern that extensions don't invoke the
responseCallback, and so the port objects leak. Register a callback that
triggers when the responseCallback is finalized to free up these resources.

BUG=114738, 93566
TEST=manual

Review URL: http://codereview.chromium.org/9693048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126884 0039d316-1c4b-4281-b951-d872f2087c98

This might come at a performance price but I don't think this is important for valgrind.sh
(please note the tests on the bots are started using a different runner)

BUG=113513
TEST=http://code.google.com/p/chromium/issues/detail?id=113513#c8

Review URL: http://codereview.chromium.org/9666056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126883 0039d316-1c4b-4281-b951-d872f2087c98

Removed the key-checksum field (which is unnecessary), and added the
online-only field.

BUG=chromium-os:25463
TEST=All works as before


Review URL: http://codereview.chromium.org/9691046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126882 0039d316-1c4b-4281-b951-d872f2087c98

On Android we use the native download manager (and this is causing link
errors).

BUG=117407
TEST=


Review URL: http://codereview.chromium.org/9689058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126881 0039d316-1c4b-4281-b951-d872f2087c98

BUG=118371
TEST=
TBR=markusheintz@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9702065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126880 0039d316-1c4b-4281-b951-d872f2087c98

BUG=118370
TBR=dhollowa
Review URL: https://chromiumcodereview.appspot.com/9704051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126879 0039d316-1c4b-4281-b951-d872f2087c98

Revert 126866 - Added SetPrinterInfo to include information about printer driver. This information will be added by Chrome (in different CL) just before performing error-prone printer related operations.

BUG=108194
TEST=none

Review URL: http://codereview.chromium.org/9600060

TBR=vitalybuka@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126878 0039d316-1c4b-4281-b951-d872f2087c98

BUG=118365,118367
TBR=dhollowa
Review URL: https://chromiumcodereview.appspot.com/9702064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126877 0039d316-1c4b-4281-b951-d872f2087c98

Making the selectedIndex property setters of ListSelectionModel and ListSingleSelectionModel behave consistently.

Also now language list has leadItem when appears first time.

BUG=chromium:117883
TEST=Test single selection lists: cookies, languages, profiles.

Review URL: https://chromiumcodereview.appspot.com/9705015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126876 0039d316-1c4b-4281-b951-d872f2087c98

BUG=108277
TEST=OutOfProcessPPAPITest.TCPServerSocketPrivate


Review URL: http://codereview.chromium.org/9669038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126873 0039d316-1c4b-4281-b951-d872f2087c98

Also move related test files.

Move WriteNode::UpdateEntryWithEncryption to nigori_util.h.

Clean up defines and dependencies.  In particular, get rid of SYNC_ENGINE_VERSION_STRING and hard-code the string in the single place it's used.

Rename data_encryption.* to data_encryption_win.* and add a pragma for crypt32.lib.

Clean up exit-time constructor warnings in sync{able,er}_unittest.cc.

Remove some unused files.

BUG=117585
TEST=
TBR=jhawkins@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9699057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126872 0039d316-1c4b-4281-b951-d872f2087c98

In the initial step, forwarding headers are left in net/base/cookie_*h . After all clients are updated these will be removed and erikwright will be removed from net/base/OWNERS

BUG=70818
TEST=compilation


Review URL: http://codereview.chromium.org/9703011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126871 0039d316-1c4b-4281-b951-d872f2087c98

Benchmark results of copying a 1280 x 800 pixels using CopyFromCompositingSurface or CopyFromBackingSurface are as follows.
FromCompositingSurface: 40.00 ms
FromBackingStore: 2.12 ms

I'm prepareing the following CLs and these will come soon,
- Support Mac and Chrome OS (Aura)
- Reduce the number of pixels to copy from the compositing surface for performance improvement

BUG=96351
TEST=Manual

Review URL: http://codereview.chromium.org/9582003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126870 0039d316-1c4b-4281-b951-d872f2087c98

TEST=tested by hand
BUG=none

R=apatrick@chromium.org


Review URL: http://codereview.chromium.org/9706042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126869 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126868 0039d316-1c4b-4281-b951-d872f2087c98

Added SetPrinterInfo to include information about printer driver. This information will be added by Chrome (in different CL) just before performing error-prone printer related operations.

BUG=108194
TEST=none

Review URL: http://codereview.chromium.org/9600060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126866 0039d316-1c4b-4281-b951-d872f2087c98

Also make BaseTestServer's dtor virtual protected to prevent the BaseTestServer pointer being directly deleted.

BUG=None
TEST=net_unittests should pass.
Review URL: https://chromiumcodereview.appspot.com/9704008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126865 0039d316-1c4b-4281-b951-d872f2087c98

pages to make re-initialization work as expected. Additionally, ignore some
events that might get us into a wasteful scenario.

BUG=117671
TEST=Session restore or re-clicking same nav item loads settings correctly,
no regressions.
R=csilv,estade,mirandac,kevers

Review URL: https://chromiumcodereview.appspot.com/9693032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126864 0039d316-1c4b-4281-b951-d872f2087c98

BUG=118036
TEST=open 2 composited tabs that draw (e.g. flash video), quick swap between them with ctrl-tab, observe no hang.


Review URL: http://codereview.chromium.org/9703044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126863 0039d316-1c4b-4281-b951-d872f2087c98

IME benefits from knowing what portion of text is selected inside a text editing plugin.
This change is to implement a Pepper API for doing it. It consists of three API functions:

1. Browser asks plugins by PPP_TextInput_Dev::RequestSurroundingText() to send such info.
2. Plugin must reply the query by PPB_TextInput_Dev::UpdateSurroundingText().
3. Additionally, plugin notifies the browser by PPB_TextInput_Dev::SelectionChanged() that the selection is changed. Typically triggers the steps 1->2.

Intention of the API design is (1) to avoid synchronous IPC, and (2) to keep the room to implement it in an optimal and right way, that is, expensive send of selection text happens only when needed (= "IME requiring the info is on" + "selection indeed changed in the plugin"), though the current impl in the patch is not necessary like that (for sake of simplicity).

The changes in the API is in:
* ppapi/c/dev/ppb_text_input_dev.h
* ppapi/c/dev/ppp_text_input_dev.h

The browser side implementation mostly resides in:
* content/renderer/render_view_impl.cc
* content/renderer/pepper/pepper_plugin_delegate_impl.{h,cc}
* webkit/plugins/ppapi/ppapi_plugin_instance.{h,cc}

The other files are for wiring necessary cables.

BUG=101101
TEST=Manual: make ppapi_example_ime and run ./your/chrome --register-pepper-plugins=\ 
"/path/to/ppapi_example_ime.plugin;application/x-ppapi-example-ime" \
--ppapi-out-of-process \
file:///path/to/ppapi/examples/ime/ime.html 
Try some IME that supports reconversion (e.g., Google Japanese Input on Windows).

Review URL: http://codereview.chromium.org/8769003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126862 0039d316-1c4b-4281-b951-d872f2087c98

TBR=estade
BUG=None?
TEST=Delete buttons in lists actually do something.
NOTRY=true

Review URL: http://codereview.chromium.org/9706052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126861 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/9703013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126860 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:16557
TEST=build success


Review URL: http://codereview.chromium.org/9702005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126859 0039d316-1c4b-4281-b951-d872f2087c98

1) text in bubble should be black (title can stay blue)
 -> Made radio buttons and checkbox explicitly black.

2) fix alignment of radios/checkboxes (work w/ roma@)
    align checkbox to left of text (“S” in “Send” in title)
 -> Add local CheckboxNativeThemeBorder without left/right insets, removed padding column.

3) when you hit [Send] button ->
    change button text to “Sending...” (disable Send and Cancel button)
    button size should not change
 -> Set Sending... text in disabled Send button during animation.

4) then “Sent!” (disabled Send and Cancel buttons) (for a few seconds)
    then dismiss the bubble automatically
    ideally, we would add the error message to this bubble inline instead of showing a new bubble (not gating for launch)
 -> Set Sent/Error text in Send button; close after 3s (on success), add red error message on failure.

BUG=102709
TEST=Updated bubble looks as prescribed.

Review URL: https://chromiumcodereview.appspot.com/9702016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126858 0039d316-1c4b-4281-b951-d872f2087c98

The new interface is C-based so the CreateMemoryObject() callback now
takes an int rather than a bool.  I have opted to wrap
content::MakeSharedMemorySegmentViaIPC() rather than change the types
in the "content" tree: arguably NaCl's use of a C interface here
should not spill over too far into Chromium's C++ code.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=2651
TEST=nacl_integration

Review URL: https://chromiumcodereview.appspot.com/9695062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126855 0039d316-1c4b-4281-b951-d872f2087c98

LoadURL and DidStartLoading.

Failing test has no DidStartLoading (in RVHImpl) in failing test, so the request must be lost somewhere. This will tell us where the request gets lost.

BUG=chromium-os:26646
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9709001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126854 0039d316-1c4b-4281-b951-d872f2087c98

It seems it needed to be added to api_page_generator.js. Also, renamed
experimental.fonts.json to experimental.fontSettings.json for consistency.

BUG=114148
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9689054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126853 0039d316-1c4b-4281-b951-d872f2087c98

Uploading counterpart of http://crrev.com/124146. Provide a method for
the users of URLFetcher to obtain upload progress.

Different from the download case, even the internals of URLFetcher
(= URLRequest) doesn't provide callback mechanism for upload progress.
So the current implementation runs a timer and poll the progress status.

BUG=chromium-os:27370
TEST=content_unittests --gtest_filter='*URLFetcher*'

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126589
Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=126611
(XP test bots hung at URLFetcher test)

Review URL: https://chromiumcodereview.appspot.com/9618051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126850 0039d316-1c4b-4281-b951-d872f2087c98