- 02 Oct, 2018 40 commits
-
-
Xi Cheng authored
Bug: 888716, 851163 Change-Id: I0fce8657b8ab41c0ac57bff548a029bab302c8b3 Reviewed-on: https://chromium-review.googlesource.com/c/1256106Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#595901}
-
Daniel Rubery authored
Bug: 882927 Change-Id: I7217526edbe448fd9588ef0b8a2554e1e969651e Reviewed-on: https://chromium-review.googlesource.com/c/1255725 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#595900}
-
Ahmed Fakhry authored
Gesture scrolling starts before top-chrome starts sliding. During that small period, the `DoBrowserControlsShrinkRendererSize` bit should remain unchanged. This CL fixes this issue and adds a test to verify the state of the browser while top-chrome sliding is in progress. BUG=884440, 867063 TEST=Added new test Change-Id: I0737b5b38c727dd77fc522d9a52537f70abb16bd Reviewed-on: https://chromium-review.googlesource.com/c/1249729Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#595899}
-
Mason Freed authored
Previous to this CL, these autoscroll/animation tests passed only because there is a default surface deadline (typically 4 frames) in place. Surface activation does not happen automatically, because in layout test mode, rasterization is not performed until the very end of the test, for image capture. For the tests in question, that deadline was previously always being hit, causing the surface to be activated, triggering the monitored scroll events and passing the test. When the --enable-display-compositor-pixel-dump flag is enabled, however, the default surface activation deadline is changed to be infinite (no deadline). As a result, all such autoscroll/animation tests fail. With this CL, those tests that looked at animation behavior have been modified to call a new continuouslyRunAnimations() javascript method, which sets a flag that causes full rasterization to be included in the lifecycle update that was already taking place. This triggers surface activation, and runs the animations, allowing these tests to pass even with an infinite deadline. Bug: 883547, 874162 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0d9e1ae7d10fab186207cdfbc8e2f85f60d99f35 Reviewed-on: https://chromium-review.googlesource.com/c/1229354 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#595898}
-
Marcin Wiacek authored
This is a reland of 4b3c7082 (https://chromium-review.googlesource.com/c/chromium/src/+/1154527) after merging https://chromium-review.googlesource.com/c/chromium/src/+/1185461 fixing https://bugs.chromium.org/p/chromium/issues/detail?id=875909 Original change's description: > Replace enum with @IntDef (javatests) > > @IntDef/@StringDef annotation are preferred way for declaring > set of String/int values. > > 1. they need less space in APK than enum, see > https://developer.android.com/topic/performance/reduce-apk-size#remove-enums > 2. they give more control over allowed values than "static final" values > > Main goal of patch is writing "static final" values, enum > and some classes in one common @IntDef/@StringDef form: > > 1. with @IntDef/@StringDef first, @Retention second > and related @interface third > 2. with values inside @interface > 3. with NUM_ENTRIES declaring number of entries if necessary > 4. with comment about numbering from 0 without gaps when necessary > 5. with @Retention(RetentionPolicy.SOURCE) > 6. without "static final" in the @interface > > Change-Id: I6aeb3571f6e72dd3599a4a6055189a227312d5c4 > Reviewed-on: https://chromium-review.googlesource.com/1154527 > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Amirhossein Simjour <asimjour@chromium.org> > Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> > Cr-Commit-Position: refs/heads/master@{#584198} BUG=875909 TBR=agrieve@chromium.org,tedchoc@chromium.org,asimjour@chromium.org Change-Id: I11a6acd33b6363ddf792eadfeaac01e0d8513a01 Reviewed-on: https://chromium-review.googlesource.com/c/1189642 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#595897}
-
Eric Aleshire authored
Instead of using a "fake" select field, we integrate it more naturally as per Moe's comments by implementing a select for the month field. See: https://chromium-review.googlesource.com/c/chromium/src/+/1240913 Bug: 881096 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I467c0c9c33ef4f4239f39743672d22de6bf66d06 Reviewed-on: https://chromium-review.googlesource.com/1256067Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: ericale <ericale@chromium.org> Cr-Commit-Position: refs/heads/master@{#595896}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9e92782016c4..9f9c2ea4282f git log 9e92782016c4..9f9c2ea4282f --date=short --no-merges --format='%ad %ae %s' 2018-10-02 bungeman@google.com Don't set kCTFontSymbolicTrait. 2018-10-02 borenet@google.com [infra] Add missing symlink target in go_deps asset 2018-10-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 def1ba96cba4..16c20140e05e (1 commits) 2018-10-02 mtklein@google.com clamp gamut if needed in SkConvertPixels 2018-10-02 mtklein@google.com missed a spot to clamp to gamut 2018-10-02 mtklein@google.com remove DM timestamps 2018-10-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 9d597f8a3a1e..def1ba96cba4 (1 commits) 2018-10-02 jvanverth@google.com Check for degenerate path when calculating shadow transform 2018-10-02 rmistry@google.com [Android compile bot] Break out of loop if JSON successfully loads 2018-10-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 996628a4a1fd..9d597f8a3a1e (1 commits) 2018-10-02 kjlubick@google.com Have pathkit use libpathkit.a for faster builds 2018-10-02 brianosman@google.com Reland "Reland "Reland "Preserve colorType and alphaType in SkImage::makeColorSpace""" 2018-10-02 rmistry@google.com Add direct log links on milo page for Android compile bot 2018-10-02 rmistry@google.com Update trigger_wait_ac_task.py to use GCS instead of webhooks Created with: gclient setdep -r src/third_party/skia@9f9c2ea4282f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: Icddac9ed8c8b8cfc2ca538496b51870b03d8cd84 Reviewed-on: https://chromium-review.googlesource.com/c/1257142Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595895}
-
Chris Harrelson authored
Bug: 823796 Change-Id: Id2f733f1823c03300c343386ad01573ff0b6d69f Reviewed-on: https://chromium-review.googlesource.com/1252326Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595894}
-
Matthew Jones authored
This patch moves the IPH bubble for duet from pointing at the top toolbar to pointing at the bottom. As a result, the special case for the NTP has been removed. Change-Id: Icbe86c1c19dde17de069d1514f9833243be5e32d Reviewed-on: https://chromium-review.googlesource.com/1249816 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#595893}
-
Mikel Astiz authored
As suggested in recent reviews, it's desirable to keep the sync-related source code in a dedicated directory, with separate OWNERS file. The files still belong to the same build targets, because there would be cyclic build dependencies otherwise. While moving the files, various trivial changes are introduced to avoid presubmit and linter errors. Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I8ce0070e2449f4285c3ccaa85e9d550d61433744 Reviewed-on: https://chromium-review.googlesource.com/1256809Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/38f24ee666e1..0da73fedd900 git log 38f24ee666e1..0da73fedd900 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 jmadill@chromium.org Vulkan: Add dumping of the command graph to GraphViz. Created with: gclient setdep -r src/third_party/angle@0da73fedd900 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I6743cae4f182c0795f2e11819b40d8199b8f1411 Reviewed-on: https://chromium-review.googlesource.com/1257186Reviewed-by:
-
Lily Chen authored
This change avoids erroneously deleting an equivalent pre-existing (insecure) cookie when attempting to add a new insecure cookie that path-matches a pre-existing secure cookie. Previously, the pre-existing insecure cookie would be deleted because it is equivalent to the new cookie, even if a matching secure cookie was encountered and skipped. This change adds a check that no secure cookie was skipped while attempting to add the new cookie. Bug: 703627 Change-Id: I471f5887fecd84afc4b746ae78bb73fbf4449cdf Reviewed-on: https://chromium-review.googlesource.com/1252866 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#595890}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/48348e91f2d7..a115d8de1c98 git log 48348e91f2d7..a115d8de1c98 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 achuith@chromium.org cros_unittest: Update test gaia account. Created with: gclient setdep -r src/third_party/catapult@a115d8de1c98 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:879353 TBR=sullivan@chromium.org Change-Id: Ibe3bc0fe3b14f5f805d4bf4b0421dbd07a7c575d Reviewed-on: https://chromium-review.googlesource.com/1256081Reviewed-by:
-
Josh Pratt authored
Updates the string for kErrorStartingTermina and adds strings for kErrorOffline, kErrorFetchingSshKeys and kErrorMountingContainer. Change-Id: I0a1fba8179d4f32f99cb376922633578b332a912 Reviewed-on: https://chromium-review.googlesource.com/1255762 Commit-Queue: Josh Pratt <jopra@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#595888}
-
Fabrice de Gans-Riberi authored
The test launcher creates a /data directory for each of its children. This is implemented as a directory with a unique number in its name. Access to the number was not thread-safe, which this CL fixes by using atomic operations to increase the number. This is a potential fix for the content_unittests failure seen here: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/fuchsia_x64/117497 Change-Id: I42614b0de36e65ffb8bc811813132a8781036896 Reviewed-on: https://chromium-review.googlesource.com/1255926Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#595887}
-
Pete Williamson authored
This also adds a unit test for existing headers. To make the testing easier, we added a languages parameter to the call to UpdateCatalogFromNetwork. Change-Id: I871b8461afcd31c6e74d6bab9682134cf5e26943 Reviewed-on: https://chromium-review.googlesource.com/1256008 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#595886}
-
Xida Chen authored
This CL corrects a typo in input_router_impl.cc, it doesn't introduce any behavior change. TBR=nzolghadr@chromium.org Bug: None Change-Id: I899b936cafbd61215a30f39f53d2514b570fcda2 Reviewed-on: https://chromium-review.googlesource.com/1255572Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#595885}
-
Aldo Culquicondor authored
Bug: 884803 Change-Id: I20378649418949c2d00097ff8ca204972c54b2ab Reviewed-on: https://chromium-review.googlesource.com/1240169Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#595884}
-
Khushal authored
This reverts commit 7f6cb854. Reason for revert: We have the diagnostic data we needed. Original change's description: > android: Add diagnostic crash dump for GPU OOM crashes. > > R=cpu@chromium.org > > Bug: 879259 > Change-Id: I4ad88bcf863be355a286b6e0271a08dc470d1cda > Reviewed-on: https://chromium-review.googlesource.com/1220769 > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Carlos Pizano <cpu@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Commit-Queue: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590562} TBR=boliu@chromium.org,cpu@chromium.org,khushalsagar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 879259 Change-Id: Icc66bdc3d72fa396cbb107ba86c266ef79ab0ad7 Reviewed-on: https://chromium-review.googlesource.com/1257242Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#595883}
-
Alexei Filippov authored
BUG=889545 Change-Id: I880fae90be175883b70915e1d992ea00a4363cc4 Reviewed-on: https://chromium-review.googlesource.com/1252365Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#595882}
-
Filip Gorski authored
* Adding ability to configure values requested by the Feed team, except 2 that are not available in Configuration class. * Updating FeedProcessScopeFactory to consume configuration. * Adding javatests to cover the code. Bug: 886972 Change-Id: Ib38fe2ea062fa7014ff5e4ecff02150f24e96f67 Reviewed-on: https://chromium-review.googlesource.com/1248121Reviewed-by:
-
Ovidio Henriquez authored
This change adds a new policy template for WebUsbAllowDevicesForUrls. The new policy will allow a list of devices to be automatically granted permission to be used for a list of URL patterns. This change also adds a policy handler to validate the policy value and add the validated value to Preferences using the pref name defined for this policy. The design document for the new WebUSB policy is located at: https://docs.google.com/document/d/1MPvsrWiVD_jAC8ELyk8njFpy6j1thfVU5aWT3TCWE8w/ Bug: 854329 Change-Id: I03657906834ba12f43735d7339a8ca404dc50718 Reviewed-on: https://chromium-review.googlesource.com/1225692 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#595880}
-
Sami Kyostila authored
TBR=nyquist@chromium.org Bug: 879922 Change-Id: If59565e8610e6307868f9f7ad5ffe8cba54d5f1e Reviewed-on: https://chromium-review.googlesource.com/1256946Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#595879}
-
Yves Arrouye authored
When the management server sends this new option, wire it to an unescapable Zero-Touch flow. Bug: chromium:891281 Test: N/A for now as the server doesn't return this option Change-Id: Iaaa3dd531ccb8f8a5fb2788ca61171ad8abc487e Reviewed-on: https://chromium-review.googlesource.com/1256906Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#595878}
-
Lei Zhang authored
Remove a comment that was suppose to be useful. It instead split the list in two, which in turn allowed developers to randomly put files in either list. Change-Id: Ib65a4505ef7e7e18a0e4a8bb462bdf894d7f4d09 Reviewed-on: https://chromium-review.googlesource.com/1256369Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#595877}
-
Vasilii Sukhanov authored
Bug: 887914 Change-Id: I76658cd1d001653da0f32f2d955646f8cd365d64 Reviewed-on: https://chromium-review.googlesource.com/1256777Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#595876}
-
Ben Pastene authored
This is now done automatically after crrev.com/c/1252005 Change-Id: Iddcd43de19376bf2d6d522dd2ceed5060b880bf6 Reviewed-on: https://chromium-review.googlesource.com/1256102Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#595875}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e928488baf66..aa7c7ba5051f Created with: gclient setdep -r src-internal@aa7c7ba5051f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8be04c9c99939ac8467ce3e8c0456d3c48978a8f Reviewed-on: https://chromium-review.googlesource.com/1256903Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595874}
-
Mike Klein authored
Change-Id: Idb6e66c655015000df132ac357f07b7bea7a9cdc Reviewed-on: https://chromium-review.googlesource.com/1254442 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#595873}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/146eb3bdcf5b..a77bb2e54b35 git log 146eb3bdcf5b..a77bb2e54b35 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 alanbaker@google.com Add validation for execution modes Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@a77bb2e54b35 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic098caa47274dd4af11d79272383ab7c95ef2502 Reviewed-on: https://chromium-review.googlesource.com/1256079Reviewed-by:
-
Mustaq Ahmed authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I81d8e42cfe0b1affe5568c694f3526df6e273fc8 TBR: jbroman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1252261 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#595871}
-
Andrey Kosyakov authored
Network conditions management is now done in content, so support for this in headless is redundant. This is a re-land of https://chromium-review.googlesource.com/c/chromium/src/+/1255610 fix network_dp.{h,cc} being removed from BUILD.gn. Change-Id: I6903c58f72bfc20588bf795da7b9f2e647dd0801 Reviewed-on: https://chromium-review.googlesource.com/1255726Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#595870}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a2be8456. With Chromium commits locally applied on WPT: 92605c16 "[Unified Plan] Remote MediaStreamTracks should be muted by default." a9d61b8e "Implement RTCIceTransport.onselectedcandidatepairchange" 3e89d0d3 "Revert "Implement RTCIceTransport.onselectedcandidatepairchange"" 8c84af9b "Update beacon WPTs" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25751 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bjonesbe@adobe.com: external/wpt/css/css-shapes jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Iba3bbb64fe5b0f19b175d6b72ca85372cedd92c1 Reviewed-on: https://chromium-review.googlesource.com/1256627 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#595869}
-
Clark DuVall authored
Browser initiated requests were getting the "main_frame" type in the web request listener details, this gives them the correct "other" type. Bug: 888672 Change-Id: Ie5e24c6f51c21ad57babb710e54cc5af47bb02c2 Reviewed-on: https://chromium-review.googlesource.com/1256562Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#595868}
-
Hans Wennborg authored
The new Clang warning points out that the class can't be copy assigned because the current_ member is const. Copy or move constructing it is fine though, and that's all that's needed. Bug: 890307 Change-Id: I3f4d5e69485b84166ba4dd2356cc7973a5e58da6 Reviewed-on: https://chromium-review.googlesource.com/1255613Reviewed-by:
-
Devlin Cronin authored
Move the mediaGalleries API out of extensions code and into apps code. This includes the API implementation, schema definition, features entries, and API permission info. Bug: 877240 Change-Id: I8b750143cdcd36700f36d9da088ebaec4abd4cfe Reviewed-on: https://chromium-review.googlesource.com/1255584Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595866}
-
Florin Malita authored
Manual rebaseline for some layout tests left in a bad state after https://chromium-review.googlesource.com/c/chromium/src/+/1254341. TBR=reed Bug: 891230 Change-Id: I8e2c43c972d63f1d3eeb44ecbcaeffea2242fb34 Reviewed-on: https://chromium-review.googlesource.com/1256085Reviewed-by:
-
Mugdha Lakhani authored
Bug: 616321 Change-Id: I6a9f570f7f100fa8e1515f7736b6294644483f83 Reviewed-on: https://chromium-review.googlesource.com/1234475 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#595864}
-
Torne (Richard Coles) authored
Several places in the code convert between Java byte arrays and C++ std::string, and some had implemented a local helper function for this. Add a generic helper for this to base instead, and convert existing places that do this to use the helper. Test: base_unittests Change-Id: Ia56fb6333bd6c453207814b0bcb5ac58b5488c20 Reviewed-on: https://chromium-review.googlesource.com/1255342 Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
-
Fabio Tirelo authored
This was requested during UI review for the Autofill settings toggle split, because the new proposed order (passwords, payment methods, addresses) is more useful. Screenshot linked in the bug. Bug: 891305 Change-Id: Iabd587538b54fd579837c4aec8c762d91e1cfb8d Reviewed-on: https://chromium-review.googlesource.com/1256084Reviewed-by:
-
