- 01 Dec, 2020 40 commits
-
-
Elly Fong-Jones authored
Bug: 1154345 Change-Id: I9294122e63a9d319fae7c1b4200eff08d2b6d640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568261 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#832523}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4f7b9247..ac41b8da Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I42dd6789990f19c30f5012562a041674f4feb446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567495Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832522}
-
Joel Riley authored
Also created two new window layers, positioning the focus ring and the highlight layers below the select-to-speak panel components. AX-Relnotes: N/A Bug: 1143814 Change-Id: I37c9c6eb4fda6326ac78e82550fdc3ea02d116b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553981 Commit-Queue: Joel Riley <joelriley@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#832521}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6c54473c3710..684460d29eb4 2020-12-01 msavigny@google.com Add remote-disabled support for reclient in autoninja. 2020-12-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1149386 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ied0e4f6a2c014f6ff5c34aa4da16db4b54911e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568134Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832520}
-
Xiaoqian Dai authored
Bug: 1153877 Change-Id: I4140a53d43aac2e2eae377c9108ce27b9b3d5597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566301 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#832519}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606802354-186e0b734d39b05126048ed00a5f975d199f5c7c.profdata to chrome-win64-master-1606834243-e828e7c1abf6992c40e6e24872b0e913b727a4f7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1885226bffda23181ea02c000cad96adb96ac0b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567821Reviewed-by:
-
Dave Tapuska authored
Remove some springboards RenderWidget was used to call into blink. The callees can do it directly themselves. Remove RenderWidgetDelegate it does nothing anymore. Use GetLocalRootWebFrameWidget() instead of GetLocalRootRenderWidget()->GetWebWidget() BUG=1097816 Change-Id: Iea3bf7936aae4f01220dcd425c38daadad999212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562788 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#832517}
-
Michael Bai authored
No functionality change Bug: 1151542 Change-Id: I5c3acb2dc12e84bf4c9d3a1d01fb5c4b7e64ab39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566336Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#832516}
-
Yusuke Sato authored
This is a follow-up CL for https://chromium-review.googlesource.com/c/chromium/src/+/2559533 BUG=None TEST=try Change-Id: I8b0624083dfd94110ede99b4f79ed0011d832727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561048Reviewed-by:
Willie Koomson <wvk@google.com> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#832515}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/df873e5fa6d3..0c47015b57a0 2020-12-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 9dff6a3bb595 to bfb211914759 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: Ibf1d40d67f9a1ab663d2b55f4ffc41fc69c49d35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566363Reviewed-by:
-
Andrew Xu authored
The bug was introduced by https://crrev.com/c/2542925 The problem is: the contents view's insets are ignored when setting a menu item's height. To solve this bug, all constants related to multipaste menu views are grouped in one file. It increases the code readability. Bug: 1154070 Change-Id: Ie44ecf40afd1796ce6d18ccd8be921c29ee79199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566448Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#832513}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/356cef301b81..0c2cc2356170 2020-12-01 mtklein@google.com rearrange types in SkRuntimeEffect program_fn() 2020-12-01 herb@google.com use SkGlyphRect to record subrun bounds 2020-12-01 csmartdalton@google.com Extract reusable functions from stroke tessellation shaders 2020-12-01 mtklein@google.com disambiguate skvm::bit_cast() 2020-12-01 ethannicholas@google.com Allow SkASSERTF to take zero varargs parameters 2020-12-01 mtklein@google.com remove "half" term from SkVM If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: Ibb28e22d160aa26545d22337452060844e5b9bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568370Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1606823843-898956163ed2fa02f28039f4033baf36c9ffa10d.profdata to chrome-linux-master-1606845551-c0991c25d04e0fb7cdc34afe442412c8219bff33.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I666dfd585e6944b56aaf70ac5418fce90820c450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567048Reviewed-by:
-
Elly Fong-Jones authored
Bug: 1154345 Change-Id: I87e53f807e7682a171a5e5f9850e9e09d96649d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568436 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#832510}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1606823843-0f5277758f530be04bbb2f9dce57100bc533b372.profdata to chrome-mac-master-1606845551-f7436cdc1d8a17c203d7167ce8ba0cc00b1d3773.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8e002f119c3fde36344ab1a77469653e12978749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568410Reviewed-by:
-
Dave Tapuska authored
Since ScheduleAnimation has moved inside blink we no longer need the intermediate RenderWidget for WebPagePopups anymore. BUG=1097816 Change-Id: Icba7c74a025f5bb7edb5b4f1baf38f75f2417555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562959Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Aleks Totic authored
This fix makes Legacy match TablesNG/FF. It fixes a corner case: - when cell percentage width is equal to percentage to total percentage width do not use cell's percentage to compute table's intrinsic width. Bug: 958381 Change-Id: Icc8fac3678cf40ea8ae693a2a19735a74bf24c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568262Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#832507}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/42433abb9596..6d300e3738db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iae65cfc4950d5c072376fb1df4f556976a15be4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568214Reviewed-by:
-
Max Curran authored
page load. This CL adds tracking of translate errors over the course of a page load. This summary includes the first translation error and the total number of errors. This information will be later added to the new Translate UKM (see design doc for full details). Full design doc: https://docs.google.com/document/d/1dyWh1Xw5VgUA00VA-5PTgKQ6ItziPBnSyeDR8saJ9vM/edit?usp=sharing Bug: 1114868 Change-Id: I92b4912cd175c6e5943c24e095d42eb8091c2e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556339 Commit-Queue: Max Curran <curranmax@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#832505}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/efb716af67f6..225d4f420c39 2020-12-01 changhaohan@chromium.org Sort HAR exported logs by startedDateTime If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If4561a515bc41274311ccabbfa4784d2189ed6ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567743Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3c1a040a0ffb..d7b599b52009 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC japhet@google.com,gab@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: japhet@google.com,gab@google.com Change-Id: I97a49ddd8165090e41050266153d2804a9559c8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567741Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832503}
-
Josh Nohle authored
Records whether or not a Bluetooth MAC address is set in the local device's private certificate metadata during certificate creation. Note: A missing Bluetooth MAC address is currently not considered necessary for a certificate, and certificate creation can succeed without one. Bug: 1122641, 1105579 Change-Id: I78fa2a1225568a4912db1e995c247bdd7d27ce46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563677 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#832502}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a3bcd1c0e2e9..6d300e3738db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I58d1b402b48ad5d975e58b40e9def6f3b5f23650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568255Reviewed-by:
-
Peter Wen authored
This reverts commit 625caaa3. Reason for revert: Failed https://ci.chromium.org/ui/p/chromium/builders/ci/android-archive-rel/17017/overview Original change's description: > Android: Reduce deps for prebuilts > > Prebuilt jars do not need the full classpath since they are either jars > ready to be passed to ijar, or they just need a dep on a non-java target > to unzip the jar from its aar. > > Previously header jars could depend on impl jars due to passing the full > classpath for prebuilt jars, but this should not happen as it defeats > the purpose of header jars being fast to compile. Added a regression > test to ensure chrome_java__header doesn't depend on base_java__impl. > > Bug: 1154302 > Fixed: 1154302 > Change-Id: I896490bf99bf62777c083f0766064c734484977b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567618 > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Commit-Queue: Peter Wen <wnwen@chromium.org> > Auto-Submit: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832488} TBR=wnwen@chromium.org,cduvall@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ib4032d0a2ee8cedf8e5f5a645d25824a1adaeda3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1154302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566305Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#832500}
-
Gordon Seto authored
Create cellular setup iconset and move activation code page icons into the iconset. Bug: 1093185 Change-Id: I06fe411ecf059d180b3f999279052e87b888bbf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566354 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#832499}
-
Natalie Chouinard authored
TBR=fhorschig@chromium.org Bug: 1154362 Change-Id: I087f1a05e800144414051c01bd9f9e09d1b53a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567499Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#832498}
-
Xing Liu authored
Use the Reading list folder icon on bookmark bottom sheet and main bookmark UI. Bug: 1149664 Change-Id: I4a28f62df8f678a1a72c422576b76b5ffdc42eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553341 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#832497}
-
Jamie Madill authored
Revert "Fix readPixels incorrectly allowing RGBA / UNSIGNED_SHORT without EXT_texture_norm16 support" This reverts commit 80b096ab. Reason for revert: Causing failure on ANGLE bots. See bug. Bug: chromium:1154356 Original change's description: > Fix readPixels incorrectly allowing RGBA / UNSIGNED_SHORT without EXT_texture_norm16 support > > Add readPixels validation for RGBA / UNSIGNED_SHORT combination. This is > only valid with EXT_texture_norm16 extension enabled. > > Bug: 1152259 > Change-Id: I0e10b7d29f3b362c4054500270bbad87dcde599f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559797 > Commit-Queue: Shrek Shao <shrekshao@google.com> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832141} TBR=kbr@chromium.org,jdarpinian@chromium.org,shrekshao@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: If71af6582a51aeee39541a4e1a0c693162ba7f12 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1152259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568438Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#832496}
-
Vladimir Levin authored
This patch ensures that we property check that hidden-matchable children should be skipped. This only affects hidden-matchable, because hidden hides everything to the buggy if statement would work and auto allows all activations so the result of the buggy return is the same as it would have been without the bug. The effect of this bug is that hidden-matchable children are exposed to accessibility, which they shouldn't be. R=chrishtr@chromium.org, jarhar@chromium.org Change-Id: I863889889cb28e4d3ab075f599f7660dc8637cff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567342Reviewed-by:
Joey Arhar <jarhar@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#832495}
-
Karthika Pai authored
This is part of a migration that replaces the old <histogram-suffixes> syntax that was used to denote groups of histogram to the new patterned histogram syntax. Bug: 758782 Change-Id: I6cde5e15fb8d43b58006569ca01cab5765fb79e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552631Reviewed-by:
-
Ben Wagner authored
I happened to notice while running this benchmark locally that the "Call" button was still active and the "Hang Up" button was inactive. After investigating the original test page, this indicates the benchmark wasn't actually testing anything. I checked at a revision before https://chromium-review.googlesource.com/c/chromium/src/+/2560261 was submitted and saw the same thing. This story now appears to work correctly when running locally on Mac. Change-Id: I700d1a25b9b58caed5109575d12c18b84bafd519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563662 Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#832493}
-
Jesse Schettler authored
Limit the arc_property_util_expand_property_contents_fuzzer input size to avoid timing out on ClusterFuzz. Bug: 1153405 Change-Id: Id1ea39f7544fc95355fd39b5a291f9538d68a137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567817 Auto-Submit: Jesse Schettler <jschettler@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#832492}
-
Xianzhu Wang authored
Previously during a translation animation, as the animation didn't have scale, we would fallback to use the native scale. In cases that the animating element had a big accumulated scale from ancestors, the scale would be too small compared to the ideal scale. Another failure case was that when a big animation scale would cause the rasterized layer to be larger than the viewport, we would also fallback to use the native scale, which might be also too small if the layer had a big accumulated scale from ancestors. Now don't adjust scale for transform animation if the animation doesn't animate scale. And don't fallback to native scale when the scale is too big, but calculate a scale that just makes the rasterized layer not larger than the viewport. Bug: 1153428 Change-Id: I4a4f3133b01099752629f6710c8375a7b715ab0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566053Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#832491}
-
Michael Thiessen authored
We need to actually launch Settings for the workaround to work, so to make sure later tests don't fail because the settings workaround was already applied, we need to return to the launcher after launching settings. I'm not actually sure about anything I just said though, as these flakes are like 1/100 and while I couldn't repro locally after this fix they could still be present. Example flake here on MainSettingsFragmentTest: https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/28012 Bug: 1152413 Change-Id: I1dd77366c2eb9c422dbe75e3efecb3e29ed00920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566352 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#832490}
-
Peter Kotwicz authored
This CL introduces android_nocompile_test_suite() and android_nocompile_library() build rules. The android_nocompile_test_suite() template tries to compile its dependent android_nocompile_library() targets and checks that: - The compile fails - The compile output contains the error message specified in the android_nocompile_library() template. The android_nocompile_library() uses a temporary output directory so that compiling "all" still works. The CL converts |errorprone_plugin_tests| to use android_nocompile_test_suite(). BUG=1132014 Change-Id: I80a372a06a1fa7fa54546ac3ca0a1c48e8ee96ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538313Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#832489}
-
Peter Wen authored
Prebuilt jars do not need the full classpath since they are either jars ready to be passed to ijar, or they just need a dep on a non-java target to unzip the jar from its aar. Previously header jars could depend on impl jars due to passing the full classpath for prebuilt jars, but this should not happen as it defeats the purpose of header jars being fast to compile. Added a regression test to ensure chrome_java__header doesn't depend on base_java__impl. Bug: 1154302 Fixed: 1154302 Change-Id: I896490bf99bf62777c083f0766064c734484977b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567618Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#832488}
-
Lukasz Anforowicz authored
This CL removes code that used to log the 'Navigation.TimeToCommit' UMA metrics which have expired on 2018-03-30 (in favor of Navigation.StartToCommit variants). This CL also removes code that used to log the 'Navigation.TimeToURLJobStart' UMA metrics which have expired in M85. This CL removes fields that were used for supporting the removed UMA metrics, including the `url_job_start_time_` field. Since unit tests would never simulate NavigationURLLoaderDelegate::OnRequestStarted they would always exit early from Navigator::RecordNavigationMetrics. After removal of the field, the early exit no longer happens in unit tests, which makes them more closely follow/simulate the behavior of the production code. This CL also introduces a small change in behavior of the production code related to logging an "Unload" UKM event during session restore. This change seems okay, since that both before and after this CL, that UKM event would be logged when restoring a tab, when navigating an empty tab via omnibox, and in other scenarios where there is no real "unload" event (i.e. it seems okay not to special-case session restore here). The removal also covers the 6 suffixes and so also removes: Navigation.TimeToCommit_SessionRestored_BeforeUnloadDiscounted Navigation.TimeToURLJobStart_SessionRestored_BeforeUnloadDiscounted Navigation.TimeToCommit_NewRenderer_BeforeUnloadDiscounted Navigation.TimeToURLJobStart_NewRenderer_BeforeUnloadDiscounted Navigation.TimeToCommit_ExistingRenderer_BeforeUnloadDiscounted Navigation.TimeToURLJobStart_ExistingRenderer_BeforeUnloadDiscounted The removal should help consolidate the content::RestoreType::CURRENT_SESSION and content::RestoreType::LAST_SESSION enum values (because code logging the metrics was the only place that distinguished these values). Bug: 1150940 Fixed: 1030145, 1030141 Change-Id: I2036e6884b90dccfc5cc6588e3b8a5a867ee7670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551736 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#832487}
-
Robert Ma authored
This only affects the Chromium log formatter of wptrunner. We want to produce a valid metadata and full logs separately, the former as the "-expected.txt" artifact and the latter as "-stderr.txt". Bug: 1154085 Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I059e05005d2b5f72708c783c5c81deaa86f8b417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567094 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#832486}
-
James Cook authored
Make the path sanitization code in DownloadPrefs more closely match the version used by ash-chrome (existing chrome for chromeos). There's still more refactoring work to do to make the behavior match exactly, but this lets users have a bit more flexibility with their download location. Bug: 1148848 Test: added to unit_tests Change-Id: I54048b60db3191f49187bf7645384f4d2a95218d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566360Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#832485}
-
Ivan Murashov authored
Using auto for a type in declaration of a constant previously declared with a clearly specified type considered by GCC as a type mismatch. An error example: ../../base/threading/hang_watcher.cc:44:39: error: conflicting declaration 'constexpr const auto base::HangWatchScopeEnabled::kDefaultHangWatchTime' ../../base/threading/hang_watcher.h:68:32: note: previous declaration as 'const base::TimeDelta base::HangWatchScopeEnabled::kDefaultHangWatchTime' Now the declaration of kDefaultHangWatchTime in the cc file matched to the declaration in the header file. Bug: 819294 Change-Id: I108a771f9c8023cb13470ba0a4eaf6207e32b522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565578Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Oliver Li <olivierli@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#832484}
-
