- 29 Jun, 2020 40 commits
-
-
Lei Zhang authored
In build/build_config.h, the #define for OS_ASMJS is inconsistent with the surround OS_* defines. Make it consistent. Then use it in base/numerics/safe_math_shared_impl.h instead of using __asmjs__ directly. Change-Id: Id4605afcbdcff14fa64183eed6be46422c2e4066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269764Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#783676}
-
Kevin Ellis authored
This patch performs a lazy calculation of the before change style once it has been determined that a transition is being retargeted. In doing so, the current position is correctly updated to reflect changes made via the web-animation API. The path also addresses a bug in the calculation of current time, in the case of a paused or play-pending animation. Bug: 1082401, 888661, 547609 Change-Id: I4b76879d840b482da8ebf23c1aad41b881fafce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220263Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#783675}
-
David Van Cleve authored
It turns out the command line "create an origin trial token" tool defaults to 42-day expiry. It's been 42 days since landing this test and, surprise, it's broken! This CL fixes the test by replacing the origin trial token with one that expires in 2047. Apologies in advance to the sheriff 27 years in the future. TBR=csharrison Fixed: 1100405 Change-Id: I0521ad992eae89f62238621f8d0a7d7b376ac855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274238Reviewed-by:
David Van Cleve <davidvc@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#783674}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I7337b3860b0396930c6d62b45bf4eaef447f3971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273600Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#783673}
-
Quinten Yearsley authored
Using more specific names, like "allowlist" and "ignorelist" instead of "whitelist" and "blacklist". (See go/allowlist). Change-Id: I018633aef56470d40f3ecbe5fa429ea95925fc24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274079Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#783672}
-
Elly Fong-Jones authored
This change renames: * master_prefs::MasterPrefsPath -> initial_prefs::InitialPrefsPath * first_run::internal::MasterPrefsPath -> ...::InitialPrefsPath This is the first part of renaming the "master preferences" file and all the code referencing it. A file in a platform-dependent location named "master_preferences" or similar has historically been the documented way to impose initial preferences in newly-created profiles. Removing support for the old name would break backward compatibility, so this sequence of CLs will instead: 1) Rename the concept from "master preferences" to "initial preferences" throughout the codebase *without* changing the name of the actual initial preferences file on disk 2) Add support for a secondary initial preferences file, named "initial_preferences" 3) Update all public documentation to refer to the new "initial_preferences" file instead It is not likely that it will ever be possible to drop support for the old filename, given its likely wide use, but this will at least improve things. Bug: 1097204 Change-Id: Ic4b3ed62c32171c505b287171fb4213a0950a91f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267422 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#783671}
-
Dirk Pranke authored
In the GN generate_wrapper() template, it turns out there is an ambiguity with the @WrappedPath() syntax: if you pass in something (say, @WrappedPath(./foo)) that ends up resolving to the current directory, it's unclear if the resolved path should be './foo' or 'foo'. The prior code would resolve it to 'foo', but that causes a problem for scripts like test_env.py that want to invoke the path as an executable; passing the result to something like os.Popen() will cause the interpreter to search $PATH for 'foo', rather than invoking './foo' directly, and if '.' isn't in PATH, you get an error as a result. This CL changes the logic to return './foo' instead; hopefully there are no cases where the value needs to be 'foo'. If there are; we'll need to adopt a different approach. Change-Id: I4905eba1280ed39e79140a6a850ef8139279dfdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264931 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#783670}
-
Elly Fong-Jones authored
Bug: None Change-Id: Ia1c1d9bed36c1572346fff1c886216f440f2e3f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270600 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#783669}
-
Kyle Horimoto authored
We have many observer functions which followed the pattern of removing search tags, then re-adding them if appropriate. This worked, but it had two issues: (1) It was inefficient, since we'd often remove tags which were re-added moments later. This resulted in extra memory usage and unnecessary adding/removing of tags. (2) It generated too many observer events, since we fire an event every time the settings availability changes. This resulted in laggy search UI. This CL fixes these issues by introducing the ScopedTagUpdater concept, which ensures that tags are only added/removed when appropriate by delaying the adding/removing until the object goes out of scope. Fixed: 1100250 Change-Id: Ic43791653f57b0c63ad529ecd9aad6dc4ddd3793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274077Reviewed-by:Regan Hsu <hsuregan@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#783668}
-
Xinghui Lu authored
Server-side: http://cl/318556638 Bug: 1070836 Change-Id: I8fb12dd2ce7acf13a6c6c36341fd9d5f962e76e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271158 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Auto-Submit: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#783667}
-
Emily Stark authored
This CL adds a field trial option to elide not just the path, but also subdomains beyond the registrable domain. To support this option, the animation has to get fancier: we can now longer fade the color of the path, but must instead animate the display rect and offset. (The mocks also have a fade that happens while the display rect is changing, but I haven't implemented that yet.) I've replaced PathFadeAnimation with ElideAnimation that elides or unelides to a particular range of the string. Because the animation sets and can query state on the RenderText (the display rect and display offset), we can collapse the hover fade-in and fade-out animations into one animation. I've also cleaned up a couple other things along the way, mostly removing the extra has_started_ state on the animation and replacing it with GetCurrentValue(). Bug: 1090393 Change-Id: Iccd3ba52b74152bf207c440a549a8314da3da704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261893 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#783666}
-
Monica Basta authored
This CL adds 'ProfilePickerHandler' as well as 'ManageProfilesBrowserProxy'. Bug: 1063856 Change-Id: I185a43c5e0efe5d7e089aefe46b2f1f3f9a630c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273189 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#783665}
-
Natasha Lee authored
HandleRequestAdapter was returning kContextLost error when there was lack of adapters. It should just return nothing. Bug: chromium:1100380 Change-Id: I1ff047e3e654a40a4718684b3c7f9fd09fd92e50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251200Reviewed-by:
Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Natasha Lee <natlee@microsoft.com> Cr-Commit-Position: refs/heads/master@{#783664}
-
rbpotter authored
This file frequently needs to be modified for JS/front end only changes because: - IN_PROC_BROWSER_TEST_F calls are located there, rather than in a separate JS file as is the case for other Web UIs. - Several tests in this file work by executing inline JS strings, rather than executing the contents of a separate JS file As a result, adding some Web UI OWNERs for this file, so that a separate reviewer does not have to be added for these types of changes. Change-Id: I05ae96abc55a87a6d9f820d47d58aba50cde4882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274178Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#783663}
-
Abhijeet Singh authored
This CL modifies the way users can gain keyboard focus to Quick-Answers related views by pressing the Up key after a menu has been opened. Currently, pressing the Up key selects the last menu-item in the active menu, from which QuickAnswersView can be accessed by pressing the Down key again. Bug: b:152057976 Test: Tested on Chrome OS VM. Change-Id: Ib435d867ca7b70017531d5b8a1b3f5aa6cd577b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271071 Commit-Queue: Abhijeet Singh <siabhijeet@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#783662}
-
Rakib M. Hasan authored
This CL is a follow up to crrev.com/c/2268883. It removes further spawning of subprocesses by removing calls to run_gpu_integration_tests.main. Bug: chromium:960606 Bug: chromium:952105 Change-Id: I2120da203b5048c7fe6007a16769058e8e551db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273620Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#783661}
-
bttk authored
Bug: 1096085 Change-Id: I61a2da14f9d6e38fea75f5003b36d99d2c941429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264928Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: who/bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#783660}
-
Philip Rogers authored
Bug: 1100139 Change-Id: Iffcd8b2148cea9fa295ae2f93c45ec4774087c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273500 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
-
ckitagawa authored
Follow-up to crrev.com/c/2261262 to merge |is_same_document_navigation| and |did_create_new_document| to be one argument to RFHI::DidNavigate. Bug: 1098283 Change-Id: Ied1f6ef9cb96368092065ccd4518b10dbb7d435b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267917Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#783658}
-
Xida Chen authored
This CL converts base::Bind to base::BindRepeating in the chrome/browser/a11y. This CL is a code health CL, there is no behavior change. Bug: 1007635 Change-Id: I2be6f377475c937b26e096649abc5b1e6bf3e4e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272613 Auto-Submit: Xida Chen <xidachen@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#783657}
-
Shengfa Lin authored
Added helper function to get first rect that has height and width greater than 0; otherwise, fall back to first one. Added unit tests. Bug: chromedriver:3401 Change-Id: Iae7c24c9b17582ecdd355a8286f5f92c6c0df56e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272494Reviewed-by:
John Chen <johnchen@chromium.org> Auto-Submit: Shengfa Lin <shengfa@google.com> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#783656}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6fb7004f33ae..096c0b0921ee 2020-06-29 tommi@webrtc.org Post stats updates in RtpSenderEgress to the worker. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2037d5f8c65e64e37a77ed1d3774564aa5561ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273811Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783655}
-
Jeffrey Young authored
https://screenshot.googleplex.com/wUjGAuhFgAR.png Bug: b/159940757 Change-Id: I07406d7c64ce5f42b99d70a7737400e546e6ba3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270485Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@google.com> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#783654}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6e6c67d0eac4..c7eed83f9616 2020-06-29 dpranke@google.com Add a Str() function to gclient for use in DEPS files. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1099242 Tbr: agable@chromium.org Change-Id: Ibf501dcb7f78061816cc2bc2f5ee4418d8c44ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273808Reviewed-by:
-
Anastasia Helfinstein authored
This is a remnant from before the menu refactor, when entering a group took a different path from other actions the user could perform. AX-Relnotes: n/a. Bug: None Change-Id: Ie9c65fb5a1e166581280c8f4de34a33cb1bc7722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271237 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#783652}
-
Etienne Pierre-doray authored
Track global pointer to main thread sampler to access from ChromeContentRendererClient. Bug: 1077046 Change-Id: Icf575c7a03905c844ce2bd8065129a0df341a9a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251087Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#783651}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I439faf009dfa53834a14c2e771e6e8b07a84ffb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272938Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#783650}
-
Lukasz Anforowicz authored
After recent CLs there are no more callers of blink::Platform::CreateDefaultURLLoaderFactory - let's remove this method. This CL helps ensure that Blink code should always go through a frame-specific URLLoaderFactory. After this CL, https://crbug.com/891872 can be marked as fixed, although there are some follow-up work items for the remaining process-wide factory usage - these can be tracked in https://crbug.com/1098938 going forward. Fixed: 891872 Change-Id: I2c42031a1c6c92f049dc975b880184eaa3a68bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264503 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#783649}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/666c4c42..f6008bf3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8d0f82d496ce1f64210d82ea0422752d5ba6f971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273818Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783648}
-
Steven Bennetts authored
Some minor re-factoring in development broke PII scrubbing for the debug UI when the JS option was renamed but the C++ code was not updated. Bug: 921726 Change-Id: I1ea2a36f061f7e83c30476fe92db5741736442af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274141Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#783647}
-
Xinghui Lu authored
This policy is used for enabling enterprise real time URL check for WebProtect users. It can only be set from CBCM. Use an enum policy instead of a boolean policy for flexibility, because we may want to support other options(e.g. checking sub-frame URLs) in the future. Design doc: go/chrome-protego-enterprise-dd Bug: 1085263 Change-Id: Id38ffaf96d6ae3aac89a15bbc9514f6fa5560457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265448 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
Bug: 1018465, 1100119 Change-Id: Ib12125c6e0756a29f137c0e532bd4cfbec403ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270153 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#783645}
-
Guido Urdaneta authored
This reverts commit 1df9d4d7. Reason for revert: Causes consistent failure in WebRTC Chromium Mac Tester bot. First failure: https://ci.chromium.org/p/chromium/builders/webrtc/WebRTC%20Chromium%20Mac%20Tester/20103 Sample logs: [10417:775:0629/092233.325453:ERROR:gl_image_io_surface_egl.mm(227)] eglCreatePbufferFromClientBuffer failed, EGL error is 12292 [10417:775:0629/092233.325481:ERROR:shared_image_backing_factory_gl_texture.cc(955)] Failed to bind GLImage to target [10417:775:0629/092233.330225:ERROR:gl_surface_egl.cc(741)] EGL Driver message (Error) eglCreatePbufferFromClientBuffer: Bad attribute. [10417:775:0629/092233.330291:ERROR:gl_image_io_surface_egl.mm(227)] eglCreatePbufferFromClientBuffer failed, EGL error is 12292 [10417:775:0629/092233.330329:ERROR:shared_image_backing_factory_gl_texture.cc(955)] Failed to bind GLImage to target [10417:775:0629/092233.428693:ERROR:gl_surface_egl.cc(741)] EGL Driver message (Error) eglCreatePbufferFromClientBuffer: Bad attribute. [10417:775:0629/092233.428757:ERROR:gl_image_io_surface_egl.mm(227)] eglCreatePbufferFromClientBuffer failed, EGL error is 12292 [10417:775:0629/092233.428794:ERROR:shared_image_backing_factory_gl_texture.cc(955)] Failed to bind GLImage to target Failed test: WebRtcInternalsPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsVp9Profile2 Locally verified that this CL is the culprit. Reverting makes the test pass. Original change's description: > SharedImageBackingGLImage: Bind texture lazily > > There are advantages to not binding a GLImage-backed SharedImage > to a GL texture immediately. In the case of Metal or software > raster, we will not actually need a GL texture. > > Lazy-binding GLImages to textures was prevented by a bug whereby > other binding paths exposed through the command buffer would not > update the GLImage's internal binding state, resulting in > DCHECKs. > > Fix the command buffer bug, and remove the early bind from > SharedImageBackingGLImage. > > Bug: 1092155 > Change-Id: I201f901722b93e6a73e866bf8249130148c5673e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255312 > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: ccameron <ccameron@chromium.org> > Cr-Commit-Position: refs/heads/master@{#783187} TBR=ccameron@chromium.org,geofflang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1092155 Change-Id: I5c22cb5603c9ab137cd26cc399e53e1be08019db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273069Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#783644}
-
Haiyang Pan authored
This reverts commit 4ddee1ed. Reason for revert: Seems causing the failures in content_browsertests on https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/19138 The failure causes high pending time on mac CQ bots. See http://irm/i_LXENzi5ECSDZohFBvRcz Original change's description: > [issues] Report CSP issues of URL violation type. > > This CL reports information about CSP URL violations to the front-end > of DevTools. > > Doc: https://docs.google.com/document/d/1hmC2R-f2_024I3urdEpKm34V5tSWeIk8MuRts7rggso/edit# > Bug: chromium:1082628 > Change-Id: Ibd3af2bf0bfb867c858802bfd6b14f491354c13e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206793 > Commit-Queue: Kateryna Prokopenko <kprokopenko@google.com> > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#783560} TBR=sigurds@chromium.org,mkwst@chromium.org,andypaicu@chromium.org,szuend@chromium.org,kprokopenko@google.com Change-Id: Icc980f16d772b1e4d4c57bb89ef66064e5b1284f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1082628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274360Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#783643}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If96a3e50e8cc0bc39a51c7996c769a495c15bf4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273760Reviewed-by:
-
Ella Ge authored
Bug: 1007641 Change-Id: Ia8647e2332dc55b04e53fb47a70d4d70f2699102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273897 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#783641}
-
James Cook authored
A few files from non-extensions directories were left in this file as part of the GYP-to-GN transition. Move them to the appropriate BUILD.gn files. Bug: none Change-Id: I2af2e0f35e192802fea7036fab55923b9bd2ca95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272279 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#783640}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1593431166-98616a9faa035d5b81c8c029b0f54ea85ab01ed9.profdata to chrome-mac-master-1593453566-5a3b62176029046ef3c78ea8aa3bef37e9aa6907.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ibf2803e73239ebad1bee18b8335eafe98ad55a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273979Reviewed-by:
-
Oriol Brufau authored
This patch prepares LayoutListItem for handling LayoutInsideListMarker and LayoutOutsideListMarker. These classes are currently unused, but will be utilized for markers with non-normal 'content' in legacy layout. BUG=457718 Change-Id: Ife525eaae720543592dfb935bde276469758fd7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252041Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#783638}
-
Denis Kuznetsov authored
Bug: 1067260 Change-Id: Iebbf735de9f413a31045710fe4479d0e86dcd6bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266616Reviewed-by:
Renato Silva <rrsilva@google.com> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#783637}
-
