GitLab

BUG=269006

Review URL: https://chromiumcodereview.appspot.com/22751002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217082 0039d316-1c4b-4281-b951-d872f2087c98

There is no longer an Instant overlay that needs controlling, so we can
remove InstantOverlayController. Mac's view code is warped around the
existence of an overlay, so cut out as much of the dead Instant code as
possible without removing OverlayableContentsController; I'm not a Cocoa
expert and don't know the best way to do that.

BUG=251262
TEST=None.
TBR=erg@chromium.org, rsesek@chromium.org, samarth@chromium.org

Review URL: https://codereview.chromium.org/22694002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217079 0039d316-1c4b-4281-b951-d872f2087c98

$./build/sanitize-png-files.sh -o2 remoting/resources
 Processed 1 files (out of 6 files) in 00:00:50s
 Result : 3436 => 691 bytes (2745 bytes : 79 %)

BUG=271299
TBR=garykac@chromium.org

Review URL: https://codereview.chromium.org/22907003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217078 0039d316-1c4b-4281-b951-d872f2087c98

Change rAc suggestion text to return two string values, one which is preferred (but may not fit horizontally) and one which is a fallback (which has a better chance to fit horizontally).

BUG=264973

Review URL: https://chromiumcodereview.appspot.com/21724002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217076 0039d316-1c4b-4281-b951-d872f2087c98

chromebox died after completion, and lost the result. Sorry.

BUG=271299
TBR=msw@chromium.org

Review URL: https://codereview.chromium.org/22896004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217074 0039d316-1c4b-4281-b951-d872f2087c98

BUG=242299

Review URL: https://chromiumcodereview.appspot.com/21777003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217073 0039d316-1c4b-4281-b951-d872f2087c98

Monkey test has its own timeout which varies by the number of events, so pass None for the test_dispatcher timeout.

NOTRY=True
BUG=

Review URL: https://chromiumcodereview.appspot.com/22939002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217072 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217071 0039d316-1c4b-4281-b951-d872f2087c98

Moved from https://codereview.chromium.org/21052007/

Currently the ContextFactory is outliving the compositor thread in 
tests, which is bad since the contexts in there can be bound to the 
compositor thread. Then we end up reusing those contexts and bad 
things happen. 

This enforces ordering for initializing and destroying the 
compositor as follows: 

Initialize ContextFactory 
..Compositor::Initialize 
....Create Compositor instances 
....Delete Compositor instances 
..Compositor::Terminate 

The Compositor::Terminate call also destroys the ContextFactory. 

The ContextFactory can be initialized in one of two ways: 
1. ImageTransportFactory::Initialize will set up the 
ContextFactory. This is used by things that invoke all of 
content/browser/. 
2. Compositor::InitializeContextFactoryForTests() must be 
explicitly called by any unit tests that create a compositor. 

Since some tests want a real GL context and some don't, this 
does away with the misnomer of initializing the Compositor once 
for the entire test suite, and then re-initializing somewhere 
in the middle of the test suite. Instead, each test must 
Initialize/Terminate the compositor with the ContextFactory 
type of its choice. 

Incidently, this test enables 20 tests on aura or win_aura that 
were previously being skipped. 

TBR=piman@chromium.org
BUG=258625

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216780

Review URL: https://chromiumcodereview.appspot.com/22293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217069 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217068 0039d316-1c4b-4281-b951-d872f2087c98

TBR=asargent
BUG=268481

Review URL: https://chromiumcodereview.appspot.com/22895002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217066 0039d316-1c4b-4281-b951-d872f2087c98

This also closes the app. If the app crashes in the background,
it might interfere with subsequent instrumentation tests.

BUG=271071
R=craigdh@chromium.org

Review URL: https://codereview.chromium.org/22767002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217065 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217064 0039d316-1c4b-4281-b951-d872f2087c98

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/22891003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217063 0039d316-1c4b-4281-b951-d872f2087c98

On Linux, right clicking in the omnibox does not give it focus, so
right-clicking and pasting can change the contents without focus in
the omnibox. Take out the DCHECK that assumes this cannot happen.

Also, change the focus_source_ to assume the source was OMNIBOX in these cases.

BUG=271462
R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/22795005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217062 0039d316-1c4b-4281-b951-d872f2087c98

Reset page scale factor to 1.0f

This first time we tried to land this (https://codereview.chromium.org/17830003/)
it ran into problems with layout tests that incorrectly handled setPageScale. This
has since been fixed in https://codereview.chromium.org/18546003/, so we will try
to re-land this.

TBR=jamesr
BUG=162482

Review URL: https://chromiumcodereview.appspot.com/22848002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217061 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=True
BUG=264859
TEST=
1) Uninstall Chrome.
2) Put mini_installer.exe in the same folder as test_installer.py.
3) Run "python test_installer.py config\config.config".
4) The script will install Chrome and then uninstall Chrome.  At each state, it will check that a registry entry for Chrome exists (or doesn't exist). You should see output similar to the following:

"Test: clean -> install chrome -> chrome_installed -> uninstall chrome -> clean ... ok

----------------------------------------------------------------------
Ran 1 test in 12.345s"

Review URL: https://chromiumcodereview.appspot.com/22480002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217059 0039d316-1c4b-4281-b951-d872f2087c98

One http request field name wasn't correct.

NOTRY=true

BUG=271021

Review URL: https://chromiumcodereview.appspot.com/22532013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217058 0039d316-1c4b-4281-b951-d872f2087c98

BUG=166165
Test=WebViewTest.*, WebViewInteractiveTest.*
TBR=cdn@chromium.org for removing IPCs in browser_plugin_messages.h
NOTRY=true, previous patch worked, just merging.

Review URL: https://chromiumcodereview.appspot.com/21297005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217057 0039d316-1c4b-4281-b951-d872f2087c98

Add tests for: (all for editable and noneditable text)
Long-press on text shows selection handles.
Dragging selection handle changes selected text.
Single-click dismisses selection handles.
Long-press on text shows ActionMode with correct actions.
Single click dismisses ActionMode.

BUG=155548

Review URL: https://chromiumcodereview.appspot.com/21044008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217056 0039d316-1c4b-4281-b951-d872f2087c98

Moved binary from other CL for separate force-commit because of a bug that prevents CQ from applying binary patches.

BUG=103846
TBR=estade@chromium.org

Review URL: https://codereview.chromium.org/22877004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217055 0039d316-1c4b-4281-b951-d872f2087c98

Nothing depends on this, although some webkit_unit_tests still depend on
--expose-gc.

Review URL: https://chromiumcodereview.appspot.com/22723005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217054 0039d316-1c4b-4281-b951-d872f2087c98

(this will be merged on a dedicated canary)

> Make sure unexpected exit paths generate crash dumps for the browser.
> 
> Right now it is possible for some random code to directly terminate the
> browser process without generating a crash dump. This CL should fix that.
> 
> BUG=none
> TEST=none
> R=jam@chromium.org
> 
> Review URL: https://codereview.chromium.org/22264015

TBR=rvargas@chromium.org

Review URL: https://codereview.chromium.org/22877003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217053 0039d316-1c4b-4281-b951-d872f2087c98

  -o1 is used because some of files are too big to process in time.
 I'll ether black-list these files or add threshold to skip applying o2.

./build/sanitize-png-files.sh chrome/app/theme/default_200_percent
Processed 14 files (out of 746 files) in 01:03:25s
Result : 80573 => 70634 bytes (9939 bytes : 12 %)

BUG=271299
TBR=msw@chromium.org

Review URL: https://codereview.chromium.org/22875006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217052 0039d316-1c4b-4281-b951-d872f2087c98

If native side has been destroyed, then early out in
ImeAdapter.finishComposingText.

BUG=internal b/10143869
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/22882002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217051 0039d316-1c4b-4281-b951-d872f2087c98

Add string for case when supervised user creation is disabled due to "only these users can log in" resitrictions.

BUG=263610
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/22856002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217050 0039d316-1c4b-4281-b951-d872f2087c98

Right now it is possible for some random code to directly terminate the
browser process without generating a crash dump. This CL should fix that.

BUG=none
TEST=none
R=jam@chromium.org

Review URL: https://codereview.chromium.org/22264015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217049 0039d316-1c4b-4281-b951-d872f2087c98

This is needed since the Python script runs these programs:
/usr/bin/xrandr
/usr/bin/xdpyinfo
/usr/bin/xauth

BUG=271574
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/22854007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217048 0039d316-1c4b-4281-b951-d872f2087c98

A previous fix (https://chromiumcodereview.appspot.com/22674008/) regressed the behaviour of RVDTAH on navigation.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/22824002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217047 0039d316-1c4b-4281-b951-d872f2087c98

On linux aura, a supervised user may get the native theme
as default theme, which is also represented by a
CustomThemeSupplier. When checking if a custom theme is already
installed we therefore need to check if it is an extension type.

BUG=265387
TEST=Create a supervised user on linux aura and check
     if it gets the managed user theme.
TBR=pkotwicz@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22796002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217046 0039d316-1c4b-4281-b951-d872f2087c98

BUG=247814

Review URL: https://chromiumcodereview.appspot.com/22441006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217045 0039d316-1c4b-4281-b951-d872f2087c98

R=tonyg@chromium.org
BUG=245358

Review URL: https://codereview.chromium.org/22884003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217042 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217041 0039d316-1c4b-4281-b951-d872f2087c98

The big change is initial support for ARCHS / fat binaries with ninja on mac.

1683: On Windows, don't try to create relative paths across different drives
1684: Fix typo in r1683.
1685: ninja/mac: GCC_C_LANGUAGE_STANDARD ansi is -ansi, not -std=ansi
1686: ninja/mac: Simplify slightly, no behavior change
1687: ninja/mac: Don't write emtpy postbuild variable for non-bundle links.
1688: ninja: Reduce scope of a variable, no behavior change
1689: ninja: Give WriteSources() and WriteLink() an explicit ninja_file parameter.
1690: ninja: Let WriteLink() return the linked binary, no behavior change.
1691: Linux: make ninja respect environment: CFLAGS, CXXFLAGS, LDFLAGS
1692: ninja/mac: Support multi-arch builds via ARCHS
1693: ninja/mac: Warn on conditional keys.

BUG=90185
TBR=scottmg

Review URL: https://chromiumcodereview.appspot.com/22825003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217040 0039d316-1c4b-4281-b951-d872f2087c98

NOTE: this change modifies only files that are manually tested, and therefore do not need to be try'd against Chromium or NaCl SDK.

BUG=none
R=eliben@chromium.org

Review URL: https://codereview.chromium.org/22503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217039 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217038 0039d316-1c4b-4281-b951-d872f2087c98

$ git log $(git svn find-rev r213621)..$(git svn find-rev r217028) --format="%an %ai %s" | sed 's/\+0000 //' | sed 's/@chromium\.org//'
phajdan.jr 2013-08-12 17:38:13 Use even less jobs for heavy tasks.
maruel 2013-07-27 00:09:27 Get rid of chromium_default_blacklist().
maruel 2013-07-25 20:01:20 Move zip_profiler.py under tools since it's not a primary tool.
maruel 2013-07-25 18:57:49 Add --trace-blacklist support to isolate_test_cases and fix_test_cases.
maruel 2013-07-25 18:54:57 Separate more chromium functionality.
maruel 2013-07-25 17:18:36 Refactor more chromium specific code out of the normal code path.
maruel 2013-07-25 16:02:23 swarm_trigger_step: Split chromium specific code into a separate function.
maruel 2013-07-25 15:51:48 Strip or separate many chromium-specific things.
maruel 2013-07-25 15:18:11 Fix a case where no test is run causing an internal exception.

R=csharp@chromium.org
BUG=
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/22897002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217037 0039d316-1c4b-4281-b951-d872f2087c98

> Pepper: Move FileRef to the "new" resource proxy.
> 
> This change moves the FileRef implementation from the previous one in the "old"
> resource model (ppb_file_ref_impl.cc) to the "new" resource model
> (pepper_file_ref_host.cc), and from the renderer to the browser.
> 
> As many as possible of the supporting changes were split off to other changes
> to minimize the size of this change. Unfortunately, a lot of changes for
> URLLoader had to be rolled into this change.
> 
> The data structures for CreateInfo have changed, and all users of FileRef have
> to be moved over, which is what causes this change to be so large.
> 
> TBR=dmichael@chromium.org, jschuh@chromium.org, yzshen@chromium.org
> BUG=225441
> 
> Review URL: https://codereview.chromium.org/21966004

TBR=teravest@google.com

Review URL: https://codereview.chromium.org/22903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217036 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://chromiumcodereview.appspot.com/22817003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217035 0039d316-1c4b-4281-b951-d872f2087c98

BUG=268271
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/22896002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217034 0039d316-1c4b-4281-b951-d872f2087c98