- 27 Nov, 2019 40 commits
-
-
mark a. foltz authored
Remove myself from: - media_remoting - tab_capture TBR=miu@chromium.org Change-Id: I259e709b1ce00f01cfdeecc177fb0d34f1fd4db5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941052Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#719787}
-
Joe DeBlasio authored
Based on more crash data, we can now safely exclude: - context-menu-inititated page-saves, - the extension download API, - extension installs, - Chrome-initiated top-level navigations, - reloads, and - anything triggered directly from the address bar. Bug: 1029003 Change-Id: I8a45fb27172dea211c5f2177306144d6a35a58a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940997 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#719786}
-
danakj authored
Use OnceCallback where possible, and BindRepeating where it is meant to be called more than once. TBR=nasko@chromium.org Bug: 1007760 Change-Id: I7d8fb46c331a68ffa9567cd6ffa4c74a8529b19e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940384 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#719785}
-
Yi Gu authored
The unique pointer params.hit_test_data_provider has been moved before we check whether it's null. Some unit tests which are supposed to test both v1 and v2 paths do not actually implement the v2 version. This bug was not exposed until the incorrect DCHECK was found. Bug: 1029012 Change-Id: I1dc8f8a0b2c0e355e6b578cd387c13b101a7039a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938828 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#719784}
-
Yi Gu authored
params.hit_test_data_provider should only be used in V1. Without the feature check, AsyncLayerTreeFrameSink will use the V1 path even if V2 is enabled. Bug: 1029014 Change-Id: Iad1c3bcdf4f1dcbf86b12e01561139a527684666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938727Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#719783}
-
Ted Choc authored
This reverts commit f8030cb2. Reason for revert: crbug.com/1028641 - Breaks bottom toolbar hiding for the Duet experiment on Android. Original change's description: > viz: Remove unused bottom-controls data from compositor frame. > > The bottom_controls_height and bottom_controls_shown_ratio fields > in CompositorFrameMetadata are currently unused. Their usage has been > replaced by the same fields in RenderFrameMetadata. So remove these > fields. > > BUG=none > > Change-Id: I96af75cc5f933821cfb486fdeb1e314daa2a7030 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927973 > Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#717874} TBR=sadrul@chromium.org,dcheng@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: none Change-Id: If66edb5c9184b8041c79dc9215bd725eb9f2cece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940490Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#719782}
-
Erik Staab authored
TBR=jam@chromium.org Bug: 1007791 Change-Id: I032614bf31a6428dae9e974968d8889fabb39587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935179Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#719781}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2559fc0b842c..00b1e38f3b09 git log 2559fc0b842c..00b1e38f3b09 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 rharrison@chromium.org Re-enable spirv-cross fuzzers Created with: gclient setdep -r src/third_party/dawn@00b1e38f3b09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ie1330a5ad7ea3c393befe7144a2c1452cff7ef36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940491Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719780}
-
Xiaocheng Hu authored
While clipboard markup is allowed to carry style sheets to style the elements to be pasted (e.g., when copying from Excel), @import rules should be disabled for security reasons. This patch disables @import rules when sanitizing the markup in a dummy document to make sure we don't initiate any stylesheet loading during the process. Bug: 1017871 Change-Id: I484341dc34e2ceea1891a18ac158ed2cc4920c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935429 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#719779}
-
Mark Cogan authored
TabModel was only used inside BrowserCoordinator to pass into the PageInfoLegacyCoordinator, which only needs a WebStateList. BrowserCoordinator has a public Browser property, which means any code that actually needs the TabModel can get it from that. That's what BrowserCoordinator now does. All usage of TabModel in BrowserCoordinator is thus removed. Change-Id: I3db57f468659ec07d4b7cbe013dc8e5fa326dafc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939980 Auto-Submit: Mark Cogan <marq@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#719778}
-
Jeremy Roman authored
Bug: 964481 Change-Id: I4551e1eeb3de15239b9a0f46778d6c81594b7992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940967 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#719777}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e60e76b2. With Chromium commits locally applied on WPT: 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 8a0ae33c "Add `Sec-Fetch-Dest: empty` header for application cache." 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I16f105966a17cf90bb2c9d498abddf06d6d8de1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940133Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719776}
-
danakj authored
Use OnceCallback where possible, and BindRepeating where it is meant to be called more than once. TBR=avi@chromium.org Bug: 953861, 1007763 Change-Id: I2aa07b6b7541aae252347628759be6f0fa80814f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940875Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#719775}
-
Collin Baker authored
This is a reland of 26ae2ec0 The original CL was reverted due to the test uncovering existing bug 1029086. This reland includes the fix for the uninitialized read. Original change's description: > Re-focus View on tab strip close > > When the WebUI tab strip's WebContents gains focus, the focused > TextInputClient changes while the focused View does not. This causes > text input to stop working in the omnibox despite it having Views-focus. > > This blurs and re-focuses the currently focused View. For the Omnibox, > this makes it re-install itself as the focused TextInputClient. > > This is a workaround and should be removed once bug 994350 is fixed. > > Bug: 1027375, 994350 > Change-Id: I2be055110535dc6164a7d31a64a3cf503fae7a7b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935729 > Reviewed-by: Dana Fried <dfried@chromium.org> > Commit-Queue: Dana Fried <dfried@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719473} Bug: 1027375, 994350, 1029086 Change-Id: I7f12945c9df64190df2d3d30726acd38d3457834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940869Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#719774}
-
Ted Meyer authored
Turns out I missed a double serialization! Bug: 1027412 Change-Id: I0a79c7fcc4cdba9df54f08d46fd8e422c5f4c14e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938465 Auto-Submit: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#719773}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/29815810c944..46665521b3e1 Created with: gclient setdep -r src-internal@46665521b3e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None,chromium:None,chromium:1024588,chromium:None Tbr: jbudorick@google.com Change-Id: I48a2430a62edc17265728074ad2aae864f519fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939836Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719772}
-
Meilin Wang authored
This CL fixed the bug that embedded UI will show on top of any newly opened window instead of dismissing in tablet mode. Right now in tablet mode the Assistant UI will dismiss when tapping on empty space within AppList, or when other new window opens. Tapping on the shelf will *not* hide Assistant UI by default, as we aim to keep the behavior consistent among AppList pages (e.g. search result page doesn't dismiss when tapping on shelf). Misc: Fix linter warning. Bug: b/142549681 Test: run unittests added in this change. Change-Id: I18a2424903f0523489a5fdea86cd29356623e0df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925368 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#719771}
-
Manu Cornet authored
Some classes (crostini, internal app context menus) already use the "shelf" terminology instead of the older "launcher" one. This makes things a little more consistent across the board. This change was prepared mainly with some shell commands to batch replace certain string patterns. This is a pure rename and has no expected behavioral change. Bug: 1011130 Change-Id: I1d2b462446b670f46f73c5a193b4339eb7365715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940550Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#719770}
-
Jasper Chapman-Black authored
This is part of adding support for sparse .size files, including only a subset of symbols. Historically padding has been derived on file load from consecutive symbol addresses and symbols, but this obviously is impossible if not all symbols are present in the .size file. Change-Id: I7d6c035e6abfca4c31fd6e77b4e9ecd9cfe840ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940530 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#719769}
-
Ayu Ishii authored
Bug: 1007678 Change-Id: I3d0d9155f3a11f73fea58f711889898a77427d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940879 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#719768}
-
Erik Chen authored
Change-Id: Iae9f38b6af03403ca9ab30223dc0f2ec0ef4a3b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938449 Commit-Queue: Erik Chen <erikchen@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#719767}
-
Jasper Chapman-Black authored
Follow-up to 1940530. Change-Id: I56a59f0ec561075c250b4d36b1cc327d61be6cc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939959Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Cr-Commit-Position: refs/heads/master@{#719766}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b6148c3af63e..2ed71c811da7 git log b6148c3af63e..2ed71c811da7 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 jmadill@chromium.org Vulkan: Isolate DisplayVk.h from Display.cpp. 2019-11-27 jonahr@google.com Add EGLSurfaceTest.ResizeWindowWithDraw 2019-11-27 jmadill@chromium.org Suppress -Wsizeof-array-div in dEQP. Created with: gclient setdep -r src/third_party/angle@2ed71c811da7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I3b66989afc814a4fcde5c99dc59ae03a807a8aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939832Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719765}
-
Sergey Ulanov authored
Flush() was taking base::Closure, which is deprecated. Replaced with OnceClosure. Bug: 751838 Change-Id: I87825cfc58b92e32d6a7e3fff1cf062597fac396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940878 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#719764}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4d6c84bf8985..bf46a27cdd73 git log 4d6c84bf8985..bf46a27cdd73 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 benjaminwagner@google.com [infra] Update Win10 in Skolo 2019-11-27 bungeman@google.com Reland "Replace CGFontCreate with CTFontManagerCreate." 2019-11-27 brianosman@google.com Add particle entry points to externs.js to fix missing symbols 2019-11-27 bsalomon@google.com Changes to GrCoordTransform and local coords 2019-11-27 bungeman@google.com Revert "Replace CGFontCreate with CTFontManagerCreate." 2019-11-27 bungeman@google.com Replace CGFontCreate with CTFontManagerCreate. Created with: gclient setdep -r src/third_party/skia@bf46a27cdd73 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: I2fd819ca49a45d6aebfcf2ce8839a7f06a42998c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939833Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719763}
-
mark a. foltz authored
Migrate the OpenScreen MRP to use the new namespace for OSP-specific types. Bug: openscreen:90 Change-Id: I1c8e315c61ca97c96507e5379b4f20bb52fa57ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940872 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Auto-Submit: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#719762}
-
Shawn Gallea authored
This adds an early out to prevent observation of a null WebContents Bug: Internal b/145212654 Test: Build cast_shell Change-Id: I1bb2ff54246f842997130053f34f5d762cbec985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940717Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Shawn Gallea <sagallea@google.com> Cr-Commit-Position: refs/heads/master@{#719761}
-
Ben Kelly authored
Bug: 1007272 Change-Id: I38886607963d18d39cd94f3308cc0ea31371f125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940134Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#719760}
-
danakj authored
Use OnceCallback where possible, and BindRepeating where it is meant to be called more than once. R=boliu@chromium.org Bug: 1007760 Change-Id: Ibd0da08a74d9a68d8f3b9a5e47afa370f7e97e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940883 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#719759}
-
danakj authored
After running the callback, the method is done. If it continues it will crash when it tries to use the |gpu_channel_host| or the |callback|. R=boliu@chromium.org Bug: 1007763 Change-Id: I927ad13f113d6702e83257418f6b1ec3240f9d39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940877Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#719758}
-
Finnur Thorarinsson authored
The background for the Zoom icon is placeholder (haven't received the 9patch image yet). Animations between states will be included in a follow-up CL. Bug: 1029056, 656015 Change-Id: Ic5657246ca21f7d6a1fcf26a42e2148d0771a05d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936770 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#719757}
-
Istiaque Ahmed authored
With SW lifetime fix CL (https://chromium-review.googlesource.com/c/chromium/src/+/1832714), this test should not fail/flake anymore. This is also evident as retrying the test thousand times locally doesn't fail. Bug: 1003597 Change-Id: I31f467b10e90e10835f60ebedf6320d40cc7b864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933410Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#719756}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cf59b855..1b6546d2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibfc4571f4018c71bba1bfb2f47fadd62e9320b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940132Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719755}
-
Michael Spang authored
This throws an exception if xkbcommon wasn't built already (oops): Traceback (most recent call last): File "../../../../../third_party/instrumented_libraries/scripts/download_build_install.py", line 528, in <module> main() File "../../../../../third_party/instrumented_libraries/scripts/download_build_install.py", line 525, in main builder.download_build_install() File "../../../../../third_party/instrumented_libraries/scripts/download_build_install.py", line 189, in download_build_install self.build_and_install() File "../../../../../third_party/instrumented_libraries/scripts/download_build_install.py", line 298, in build_and_install self.install_packaged_libs() File "../../../../../third_party/instrumented_libraries/scripts/download_build_install.py", line 313, in install_packaged_libs os.unlink(dest_path) OSError: [Errno 2] No such file or directory: '/ssd/src/chromium/src/third_party/instrumented_libraries/scripts/out/Instrumented-asan-trusty/instrumented_libraries/asan/lib/libxkbcommon-x11.so.0' Bug: 1027853 Change-Id: Ie759fa2f16dfd3c3a89c6c96e721689db8804ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940886Reviewed-by:
Evgenii Stepanov <eugenis@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#719754}
-
Peter Kotwicz authored
This CL: - Makes WebappActivity use CustomTabTaskDescriptionHelper - Removes logic for chrome://newtab from CustomTabTaskDescriptionHelper - Fixes WebappSplashScreenTest.testThemeColorWhenNotSpecified() (Thanks to changes to BaseCustomTabActivity) BUG=989912, 1028628 TEST=CustomTabTaskDescriptionHelperTest.* Change-Id: I64e90c1190019356aa7587bb0d47333d6be1463a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914966 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#719753}
-
Peng Huang authored
This CL makes DisplayResourceProvider::ScopedReadLockSharedImage non-copyable to avoid double release problem. Bug: 1023971 Change-Id: I6b75a5e70e5805ea875c3281c17c8542c9ce731f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940529 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#719752}
-
Lukasz Anforowicz authored
This CL reverts 2 CLs that landed during M79: - r700364: Remove ChromeExtensionsRendererClient::ShouldFork. - r705362: Remove ContentRendererClient::ShouldFork. The revert skips (i.e. doesn't restore) obsolete tests in: - ///chrome/browser/prerender/prerender_browsertest.cc (PrerenderBrowserTest.PrerenderCrossProcessClientRedirect) - //content/renderer/render_view_browsertest.cc (AlwaysForkingRenderViewTest.*) The revert only restores the extension-specific part of ChromeContentRendererClient::ShouldFork (e.g. doesn't revert r705290 and r705329). The motivation for the revert is https://crbug.com/1027719 where we discovered that removing ShouldFork affected whether the Omnibox VS the web content get the focus after certain navigations. We should consider relanding the removal of ShouldFork (i.e. reverting the current revert) once we have regression tests and a fix for focus behavior. Bug: 883549, 1027719 Change-Id: I7ee44ca420fe813ae3f4a2b696fb9645de62f808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940449Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#719751}
-
haozhe authored
Both Chrome and Firefox pass Bug: 900581 Change-Id: Ic686da5cf98667dd8c2be2e004c7f9b368a5d03d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940871Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Hao Sheng <haozhes@chromium.org> Cr-Commit-Position: refs/heads/master@{#719750}
-
Mike Wittman authored
Coalesces all the chrome level support code in preparation for the addition of new support code for Android. Bug: 1027654 Change-Id: I32312c7616462939a0ccb8ba06f6ef2f75469586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940710 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Mike Wittman <wittman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#719749}
-
David Bertoni authored
After testing 1000 iterations on the trybots, there were no failures. The assumption is that recent work the the ServiceWorkerTaskQueue has fixed the flaky behavior. Bug: 997686 Change-Id: I836b23d13eb0994c3a6e3fbf319b95106bc22675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929435Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#719748}
-