GitLab

Change-Id: Ie28c6659ff11b1f2137ffc53323b4569d5283965
Reviewed-on: https://chromium-review.googlesource.com/c/1487197Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635630}

The backend team has asked that we send the total count of files and
directories within archives. This CL adds this information to the
download ping for RAR archives.

Bug: 926586
Change-Id: Id24838c5984a72740ff3776dd26ef49965113d7b
Reviewed-on: https://chromium-review.googlesource.com/c/1487193Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635629}

Change-Id: I6972e64eccf682e9028dcf69991450dd3ecd8319
Reviewed-on: https://chromium-review.googlesource.com/c/1488019
Auto-Submit: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635628}

Postmortem Bug: https://monorail-staging.appspot.com/p/chromium/issues/detail?id=899293

Bug: 931710
Change-Id: I94c3e321d77890c59987894ce00f16a3d7ec2128
Reviewed-on: https://chromium-review.googlesource.com/c/1479910
Commit-Queue: Brian White <bcwhite@chromium.org>
Auto-Submit: Brian White <bcwhite@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635627}

This patch improves the logic in PaintTextChild so that:
1. Move DrawingRecorder code after the check of
   ShouldPaintTextFragment and have_selection. This matches
   to InlineTextBoxPainter logic order, avoiding
   instantiation of DrawingRecorder if nothing are painted.
2. Check LayoutObject::IsSelected before
   ComputeLayoutSelectionStatus. This matches to legacy
   InlineTextBoxPainter, avoiding a few unnecessary function
   calls when there is no selection on the LayoutObject.

These are not the primary goal of issue 936024, but found
during the review and has positive impacts on blink_perf:
https://pinpoint-dot-chromeperf.appspot.com/job/1184c765340000

Bug: 936024
Change-Id: Idda53c9f41476d6024c6f5855594b3bd7dd35418
Reviewed-on: https://chromium-review.googlesource.com/c/1487432Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635626}

This configures cookie settings in the NetworkContext, based on
non-service code path (defined in WebView's CookieManager). This
refactors the cookie-path logic to a shared location in
AwBrowserContext.

Specifically, this configures the following:

 * save and restore session cookies
 * cookies should persist to disk

This also does some minor refactoring for the HTTP cache, for
consistency.

Bug: 933456, 933457, 902641
Test: None
Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo
Change-Id: Ib53d4cbab8ccdf2f916a256f6d549bea644b6611
Reviewed-on: https://chromium-review.googlesource.com/c/1385492
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635625}

This reverts commit 60cd9d98 now that we
don't need to work around the VC++ bug.

The array was subsequently changed from char[] to StringPiece so it's
not really a revert but an adding back of const to where it used to be,
with somewhat different semantics.

Bug: 934323
Change-Id: I821025578923e91218b8827d1d6cdd3553c252b2
Reviewed-on: https://chromium-review.googlesource.com/c/1484415
Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635624}

Bug: 932135
Change-Id: I7a80eb9717914b2b092714146e2c15727cc9f546
Reviewed-on: https://chromium-review.googlesource.com/c/1477917Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Paul Meyer <paulmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635623}

Added test for supported patterns.

Updated AXPlatformNodeTest::Init to take from 1 to 12 nodes

Bug: 847971
Change-Id: Ifc40a52f8a3c6299616e8e75fc42222c007d6f00
Reviewed-on: https://chromium-review.googlesource.com/c/1488067
Commit-Queue: Jacques Newman <janewman@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635622}

Change-Id: I482f1700acd480dca9f5818762b2769a831f6c0e
Reviewed-on: https://chromium-review.googlesource.com/c/1488187
Auto-Submit: Jared Saul <jsaul@google.com>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635621}

This CL adds an accessibility text to SyncAndServicesPreferences that is
only used when this screen is opened from the sign-in screen.

Bug: 924359
Change-Id: I721a8e3c0c333f224a48e05f10ce67cd24dd2164
Reviewed-on: https://chromium-review.googlesource.com/c/1474667
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635620}

WebContentCaptureClient is an interface that is used by ContentCapture
to communicate with chromium's components peer, it provides methods to
- Check if ContentCapture enabled.
- Send the captured content to chromium peer.

This patch replaced ContentCaptureClient with WebContentCaptureClient
to avoid the unnecessary wrapper.

Bug: 924681

Change-Id: Icf22bfb416843888dfc3e63ed9a5b39103573fe4
Reviewed-on: https://chromium-review.googlesource.com/c/1468598Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635619}

This patch does not update fooder, i.e. the suggestion chips during
voice query.

Bug: 924624
Test: manual
Change-Id: Idaae11a321d0d7571aa4d1d4d467066bfc34c0f1
Reviewed-on: https://chromium-review.googlesource.com/c/1487799Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635618}

During the name fix flow, the cardholder name is empty at times (reason unknown,
but mostly because of sync)
In such a scenario, we should have the save card button on the dialog
disabled by default

Bug: 929421
Change-Id: I195422134a263bc201caec2059f4834f7476eb43
Reviewed-on: https://chromium-review.googlesource.com/c/1487144Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Siddharth Shah <siashah@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635617}

Manually import all WPT WebDriver tests without two-way syncing with the upstream
WPT Webdriver tests. This test suit will be maintained manually until the two-sync infrastrcuture
is created in the subsequently CLs.

The WPT WebDriver tests result in linux_rel roughly aligns with the result in upstream - https://staging.wpt.fyi/results/webdriver?label=master&product=chrome%5Bexperimental%5D&product=edge&product=firefox%5Bexperimental%5D&product=safari%5Bexperimental%5D&aligned

No-Export: True
Bug: 881513
Change-Id: Ie25710416d611a819d643024de40d3ebde558997
Reviewed-on: https://chromium-review.googlesource.com/c/1459922
Commit-Queue: Kyle Ju <kyleju@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635616}

Fixes a race between sampling Now() on an idle content_unittests helper
thread and ~ScopedTimeClockOverrides. TSAN log:
https://paste.googleplex.com/6136256530481152

Attempt to avoid requiring TSAN suppression @
https://chromium-review.googlesource.com/c/chromium/src/+/1488877

R=kylechar@chromium.org

Bug: 910524
Change-Id: Ida3a3d8fe689a3d51a6f6f6d6870e2dca443f5d1
Reviewed-on: https://chromium-review.googlesource.com/c/1489297Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635615}

https://chromium.googlesource.com/chromium/llvm-project/compiler-rt/lib/fuzzer.git/+log/178ac93d6e98..538f9f9de3d6

$ git log 178ac93d6..538f9f9de --date=short --no-merges --format='%ad %ae %s'
2019-02-26 metzman [libFuzzer] Remove extra semicolons

Created with:
  roll-dep src/third_party/libFuzzer/src

Bug: 935572
Change-Id: I747ed63183914e3bbd9f7039304e01c70f8c637f
Reviewed-on: https://chromium-review.googlesource.com/c/1489473
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Auto-Submit: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635614}

[Sheriff] Mark external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/counter-styles-3/system-cyclic-invalid.html as failure on Mac

Bug: 935689
Tbr: xiaochengh@chromium.org
NoTry: True
Change-Id: I58d01d3aeac71a3fdeb6b18c5f13b26eac482b0c
Reviewed-on: https://chromium-review.googlesource.com/c/1489534Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635613}

Bug: 926235
Change-Id: I1c9f46a30392258e553a51d1033fde4d41e04210
Reviewed-on: https://chromium-review.googlesource.com/c/1489180
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635612}

Tbr: jdufault@chromium.org
NoTry: True
Bug: 936041
Change-Id: I902079d170183936b331d7d187baa2ec039748a0
Reviewed-on: https://chromium-review.googlesource.com/c/1489532Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635611}

Bug: 934227
Change-Id: I071dca790484580d1e499b9fe36e7f74aeb5cf42
Reviewed-on: https://chromium-review.googlesource.com/c/1489205Reviewed-by: Emily Hanley <eyaich@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635610}

Makes Primary Toolbar contain Location Bar to get the view events at
the correct times.
Also clears selection when the omnibox is disappearing to prevent the
selection handles from showing in the tab grid.

Bug: 823423
Change-Id: I848ee9b7ba00bf83614e20fbbd37fe971a92caa7
Reviewed-on: https://chromium-review.googlesource.com/c/1429989
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635609}

Change-Id: I1c2903e46e002a5a0f3bd3507563b56d66b6b7ea
Reviewed-on: https://chromium-review.googlesource.com/c/1484589Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635608}

This CL will rework the attaching logic for frame-based
MimeHandlerViewGuest. The notable change is the addition of a new public
API to RenderFrameHost which will (asynchronously) prepare the
FrameTreeNode for attaching an inner WebContents so that its usage with
the attaching API, WebContents::AttachToOuterContentsFrame is safe.
Previously this was achieved by navigating the current RenderFrameHost
to "about:blank" but that proved to have certain issues such as
navigation races as well as inefficient handling of the 'beforeunload'
handlers (from outside content layer it is nearly impossible to determine
whether a beforeunload modal is shown and is blocking the
navigation).

In summary, with this CL:
  1- There is no longer a need for a navigation to about:blank for
  every embedded PDF.
  2- There is no need for adding navigation throttles.
  3- beforeunload is properly addressed (an improvement over the
  previous approach of waiting for a timeout to decide navigation was
  actually blocked).
  4- Less lines of code and a more tractable attaching code.

Bug: 659750, 911161
Change-Id: Ib8981744b5683bb1cb8d557322bfc40f08bb4ccb
Reviewed-on: https://chromium-review.googlesource.com/c/1407596
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635607}

Bug: none
Change-Id: I36d0ac15f4852bada843e2bc4e4330f6f4c082d4
Reviewed-on: https://chromium-review.googlesource.com/c/1489240
Auto-Submit: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635606}

The current check fail message for ~TestBrowserThreadBundle can be augmented
by listing all pending tasks. This should make it easier to diagnose flakes.

I've seen this happen in ParentAccessServiceTest.NoValidConfigAvailable

Bug: 935515
Change-Id: If88ce656091ba4176cfdbf2c7313a7861b64379a
Reviewed-on: https://chromium-review.googlesource.com/c/1486352Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635605}

Using wpt-import in Chromium addb1c72.
With Chromium commits locally applied on WPT:
14c11107 "Implement `Sec-CH-Lang`"
df760ab0 "Don't skip past auto-height flexboxes in quirks mode."
cd40220a "Fix as=fetch preload where preload is used before response arrives"
1d89521e "[LayoutNG] Force relayout when constraint spaces change."
98e7141b "Fix 2_tracks, 3_tracks wpt/webvtt tests"
68d5240e "[ChromeDriver] Set key modifiers with mouse actions"
359fd7da "[PE] Fix rendering issue with effect escaping in pre-CompositeAfterPaint"
3685447d "[WPT] Move subresource_path from generator to referrer-policy-test-case.js"
4ea68472 "Creates an ICE transport object at DTLS transport initialization."
32a115f8 "[css-flexbox] ChildIntrinsicLogicalWidth needs to constrain by min/max"
ec3bf6e6 "Fix class_white-space_[normal|pre-line]_wrapped.html wpt/webvtt tests"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
domenic@chromium.org, ricea@chromium.org:
  external/wpt/streams

NOAUTOREVERT=true
TBR=lukebjerring

No-Export: true
Change-Id: Id011535f7d12e4e1cc159c5334c5a63d68e0961a
Reviewed-on: https://chromium-review.googlesource.com/c/1488507Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#635604}

Bug: 931156
Change-Id: I5be7fee2867371ef77d300013cf021e8be4e9203
Reviewed-on: https://chromium-review.googlesource.com/c/1488112Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635603}

This is the second out of two CLs that switch Blink to using
downcast helpers (t_p/blink/renderer/platform/wtf/casting.h)
instead of the macro-based ToLocalFrame helper.

R=jbroman@chromium.org
CC=blink-reviews-vendor@chromium.org

BUG=891908

Change-Id: I19f6196293812b94e123390550b73a63f6d617af
Reviewed-on: https://chromium-review.googlesource.com/c/1489211
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635602}

https://webrtc.googlesource.com/src.git/+log/0bf4c298529b..12ae4f4d50b0


git log 0bf4c298529b..12ae4f4d50b0 --date=short --no-merges --format='%ad %ae %s'
2019-02-26 mbonadei@webrtc.org Introduce possibility to poll stats and notify analyzers.
2019-02-26 danilchap@webrtc.org Test default TaskQueue implementation via TaskQueueBase interface
2019-02-26 phensman@webrtc.org Remove Legacy ADM from AppRTC mobile


Created with:
  gclient setdep -r src/third_party/webrtc@12ae4f4d50b0

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Iad533d662b420d13bb5442f1931af408d2228b7e
Reviewed-on: https://chromium-review.googlesource.com/c/1489066Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#635601}

Bug: 935758

Change-Id: Icb10d092a1e7c7849d89646fe5337e7b6efe4449
Reviewed-on: https://chromium-review.googlesource.com/c/1487810
Commit-Queue: Suman Kancherla <sumankancherla@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635600}

We generalize CustomizeBrowserOptions() to be able to customize all options.
New function will be call CustomizeOptions(). We do it in 3 steps:
1) Add CustomizeOptions() method to Benchmark.
2) Overload it in PerfBenchmark, instead of CustomizeBrowserOptions().
3) Remove CustomizeBrowserOptions() method from Benchmark.

This is step 2.

Bug: 801528
Change-Id: Ia1db40a04d5fddf1c634074bbd8f92ba4ccfc6f7
Reviewed-on: https://chromium-review.googlesource.com/c/1479965
Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635599}

On platforms like android webview where the decision to enable wide
color gamut on a capable device/os is not controlled by chromium, it is
important to query Window.isWideColorGamut in order to set the right
color space.

This is fundamentally incompatible with the rest of chromium platforms
where window wide gamut state matches that of the display. It's also
more complicated since there can be multiple windows in the same display
with different wide gamut state.

This is somewhat of a hack to get a "display" from WindowAndroid that
has the color space info that matches the window rather than the
display.

Note wide color gamut is still disabled so this CL by itself should
be no-op.

Bug: 924588
Change-Id: I80277d1b72538e038d236753e399f048bdaa0aa6
Reviewed-on: https://chromium-review.googlesource.com/c/1484817
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635598}

Test: None
Bug: 934344
Change-Id: Ia0ce9b0428f8cff1fca654ee076303402f49bb74
Reviewed-on: https://chromium-review.googlesource.com/c/1487871Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635597}

https://android.googlesource.com/platform/external/perfetto.git/+log/ab2257c7e108..c1b9ea5f3400


git log ab2257c7e108..c1b9ea5f3400 --date=short --no-merges --format='%ad %ae %s'
2019-02-26 fmayer@google.com Merge "Set receive timeout on sockets."
2019-02-26 hjd@google.com Merge "perfetto-ui: Send state updates as patches"


Created with:
  gclient setdep -r src/third_party/perfetto@c1b9ea5f3400

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Id72ce0918b7def5ab508e0d1d15156268a384931
Reviewed-on: https://chromium-review.googlesource.com/c/1489253Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#635596}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/264b7c18a357..c9b534ba2cb9


Created with:
  gclient setdep -r src-internal@c9b534ba2cb9

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ifdecb00eceff0a8b0b3f784ca8527241cee8c233
Reviewed-on: https://chromium-review.googlesource.com/c/1489067Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#635595}

Canonical fix:
- Model liveness through OscillatorNode (AudioNode), i.e., keep alive
  listener from there.
- Change off-thread handler to use a weak root

This works as AudioNode disposes the handler in the pre-finalizer.

This fixes webaudio/Oscillator/osc-low-freq.html for unified heap
running with leak detection.

Bug: 928781, 843903
Change-Id: I58a76bb0d5a47e65e91516cde6c4fe77044cb8ae
Reviewed-on: https://chromium-review.googlesource.com/c/1488922
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635594}

Add a convenience method GetKeyBundle() to CryptAuthKeyRegistry that
returns a const pointer to the key bundle in the registry if it exists.
If no key bundle is found, nullptr is returned.

We clean up the unit tests by using this method. Also, we make sure
EXPECT_EQ has the form EXPECT_EQ(<expected>, <actual>).

Bug: 899080
Change-Id: I7d2ca0d8ccfe0fc2a091a90cba794dbd1ad15780
Reviewed-on: https://chromium-review.googlesource.com/c/1474646
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635593}

Expand CryptAuthEnrollmentResult::ResultCode enum to accommodate more
fine-grained error codes as well as error codes relevant to the
enrollment manager, such as kErrorGcmRegistrationFailed and
kErrorClientAppMetadataFetchFailed.

We also overload the << operator for ResultCode printing.

Bug: 899080
Change-Id: I69a3e97e6987d4e3e54444febdecde3ef40137c9
Reviewed-on: https://chromium-review.googlesource.com/c/1488116
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635592}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I0eaf0e583bffa4a025a354433675b8d2788b17b9
Reviewed-on: https://chromium-review.googlesource.com/c/1489065Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#635591}