GitLab

BUG=None
TEST=manual
NOTRY=True

Review URL: https://codereview.chromium.org/257803010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266324 0039d316-1c4b-4281-b951-d872f2087c98

clang writes two of these for some reason, and due to the script not
printing these it took me a while to figure out why clang has initializers
for two more files.

BUG=360311
NOTRY=true

Review URL: https://codereview.chromium.org/251873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266323 0039d316-1c4b-4281-b951-d872f2087c98

Parse DEPS file manually if execfile fails. Some DEPS files pull in a bunch of libraries, so execfile fails. If it does, we'll manually parse out revisions from the vars section.

NOTRY=true
BUG=366392


Bisect could not reproduce a change in the not/valid metric.

Confidence in Bisection Results: 0%

To reproduce locally:
$ echo android-chrome

Tested commits:
         Depot                                        Commit SHA                                    Mean       Std. Error       State    
     android-chrome                    0000000000000000000000000000000000000000                     1.00         +-0.00                  
        chromium                       0000000000000000000000000000000000000000                     0.00         +-0.00                  
        chromium         http://src.chromium.org/viewvc/chrome?view=revision&revision=265919        0.00         +-0.00                  
        chromium         http://src.chromium.org/viewvc/chrome?view=revision&revision=265917        0.00         +-0.00                  
        chromium         http://src.chromium.org/viewvc/chrome?view=revision&revision=265912        0.00         +-0.00                  
        chromium         http://src.chromium.org/viewvc/chrome?view=revision&revision=265904        0.00         +-0.00                  
     android-chrome                    0000000000000000000000000000000000000000                     0.00         +-0.00                  

Average build time : 0:00:00
Average test time  : 0:00:00

WARNINGS:
  !!! Due to build errors, regression range could not be narrowed down to a single commit.
  !!! Tests were only set to run once. This may be insufficient to get meaningful results.
  !!! Confidence is 0%. Try bisecting again on another platform, with increased repeat_count or on a sub-metric that shows the regression more clearly.

Review URL: https://codereview.chromium.org/256593004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266322 0039d316-1c4b-4281-b951-d872f2087c98

- add cloud_print_unittests, cacheinvalidation_unittest,
  libaddressinput_unittests, and libphonenumber_unittests
  to chrome_tests.py so they can run under Valgrind or Dr.Memory.

R=bruening@chromium.org, thakis@chromium.org
NOTRY=true
BUG=NONE

Review URL: https://codereview.chromium.org/251683005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266321 0039d316-1c4b-4281-b951-d872f2087c98

Use this in place of the deprecated set_sample_rate_hz(). Similarly,
switch sample_rate_hz() to input_sample_rate_hz().

TESTED=apprtc sounds as expected with constraints enabled/disabled.

Review URL: https://codereview.chromium.org/259663005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266320 0039d316-1c4b-4281-b951-d872f2087c98

Fixed screen capture confirmation dialog to be either system- or window-modal depending on where it got initiated from. Previous implementation created window-modal with no parent window which allowed it to hide underneath its browser window.

Fixed handling of window-modal dialogs. Modal dialogs and their toplevel parent windows weren't properly activated on events (i.e. mouse click) that happen in toplevel parent windows area but outside of the modal dialog.

TEST=added WindowModalityControllerTest.EventsForEclipsedWindows, manual: start go/present/<whatever>, try to alt-tab away from the pop up dialog, try to eclipse it with another browser window
BUG=366956

Review URL: https://codereview.chromium.org/252673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266319 0039d316-1c4b-4281-b951-d872f2087c98

This CL contains only style-related clean-up.
The purpose is to allow other CLs (like https://codereview.chromium.org/231283003/) make whole-file clang-format without inducing many unrelated changes.

Putting Ilya in TBR, because of https://codereview.chromium.org/231283003/diff/200001/components/autofill/content/renderer/password_autofill_agent.cc#newcode280

TBR=isherman@chromium.org
BUG=347927

Review URL: https://codereview.chromium.org/254573005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266318 0039d316-1c4b-4281-b951-d872f2087c98

- getegid, geteuid, getgid, and getuid now return EPERM
  instead of raising SIGSYS. This simplifies the test code.
- Define a macro for sandbox tests for syscalls which return
  EPERM to reduce the size of not interesting test cases.
- Pass five zeros after syscall number to syscall() so that
  tests will not be flaky due to uninitialized values on stack.

BUG=359285
TEST=nacl_loader_unittests, trybots

Review URL: https://codereview.chromium.org/248633004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266317 0039d316-1c4b-4281-b951-d872f2087c98

The code that inserts SPS & PPS NAL units into keyframes wasn't properly
handling frames that start with AUD NAL units. This patch adds code to
make sure the configuration data is inserted after the AUD NAL units as
the H.264 spec mandates.

I've also added AVC::IsValidAnnexB() DCHECKS to verify that our
code generates proper Annex B data that conforms to the NAL unit
ordering rules outlined in the spec. These DCHECKS caught the old bad
behavior and should help prevent future regressions.

BUG=364925
TEST=AVCConversionTest.NALUSizeTooLarge, AVCConversionTest.NALUSizeIsZero, AVCConversionTest.ValidAnnexBConstructs, AVCConversionTest.InvalidAnnexBConstructs, AVCConversionTest.InsertParamSetsAnnexB

Review URL: https://codereview.chromium.org/246853005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266316 0039d316-1c4b-4281-b951-d872f2087c98

The underlying infrastructure isn't ready for this to crash the GPU
process 30 times in a row. Change back to running this test once to
address continued flakiness on the bots.

BUG=365904
NOTRY=true
TBR=bajones@chromium.org

Review URL: https://codereview.chromium.org/252793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266315 0039d316-1c4b-4281-b951-d872f2087c98

Oops.

R=yzshen@chromium.org

Review URL: https://codereview.chromium.org/257763009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266314 0039d316-1c4b-4281-b951-d872f2087c98

This change introduces static initializers (the two
static const std::string Type constants).

Static strings should be declared as char * instead.

> 1. Handle the case of empty embedder_extension_id in    guestview.h.
> 
> 2. Introduce a template class GuestView<T> to handle the    *guestview-specific functions in guestview.h:
>    . Rename GuestView to GuestViewBase, introduce GuestView<T> class, and move *ViewGuest-specific functions to     GuestView<T>:
>         -- FromWebContents<T>(...)
>         -- From<T>(...).
>    . Introduce a template member function As() in      GuestViewBase to replace all of the As*View functions.
> 
> 3. In each derived *ViewGuest class , e.g., WebViewGuest &    AdViewGuest, define a static variable to show its view type    (string).
> 
> 
> BUG=351824
> 
> Review URL: https://codereview.chromium.org/237533008

TBR=hanxi@chromium.org

Review URL: https://codereview.chromium.org/252773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266313 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
TBR=earthdok@chromium.org
BUG=

Review URL: https://codereview.chromium.org/254773004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266312 0039d316-1c4b-4281-b951-d872f2087c98

Assuming this might also fix 'Out of Memory' issue on Windows bisect bot
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/253573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266311 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/259503005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266310 0039d316-1c4b-4281-b951-d872f2087c98

There're web apps served over HTTPS but are using insecure WebSockets.
To improve security, we're going to prohibit that, but should provide
an option to turn off the check until everyone finishes fixing their apps
to get ready for stopping use of insecure WebSockets from HTTPS origin.

The shield page action allows users to manually turn off mixed content
check, but for apps designed to open new windows frequently, this
workaround is too bothering.

So, we'll provide a chrome://flags item which turns off the mixed
content check (only for WebSocket). This flag is scheduled to go away
when everyone should be ready for accepting this security check.

This CL depends on this Blink side CL:
https://codereview.chromium.org/246893014/

BUG=85271

Review URL: https://codereview.chromium.org/248863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266309 0039d316-1c4b-4281-b951-d872f2087c98

Re removed touch resources, but didn't remove the code that changes the layout. This CL removed all touch layouts.

BUG=362633

Review URL: https://codereview.chromium.org/247193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266305 0039d316-1c4b-4281-b951-d872f2087c98

To be consistent with the rest of the artifacts in the component updater,
the non-blocking calls for the CrxDownloader take a callback to be called
when the non-blocking call completes.

This change allows adding further callbacks besides the completion
callback, such as a callback to be called when download progress is made.

This change is a pure refactoring and it should be a NOP in terms of
existing functionality.

BUG=366388

Review URL: https://codereview.chromium.org/250383008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266304 0039d316-1c4b-4281-b951-d872f2087c98

There is no need to explicitly check whether the profile is managed when
trying to start the TiclInvalidationService. The service will refuse to
start up anyway because managed profiles never have a signed-in account.

BUG=358696
TEST=Manual

Review URL: https://codereview.chromium.org/258503006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266303 0039d316-1c4b-4281-b951-d872f2087c98

Merged devtools_android_bridge_browsertest.cc logic into adb_client_socket_browser_test.cc.
Made inspect_ui_browsertest.cc use MockAdbServer instead of a mock DeviceProvider.

BUG=None

Review URL: https://codereview.chromium.org/257563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266302 0039d316-1c4b-4281-b951-d872f2087c98

TSan is using instrumented libc++ now, so these false positives aren't reported anymore.

BUG=181502
TBR=earthdok@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/257773005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266301 0039d316-1c4b-4281-b951-d872f2087c98

Test videos can be found in chrome/test/data/extensions/api_test/cast_streaming/test_video_*fps.webm

Review URL: https://codereview.chromium.org/257703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266300 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chrome-os-partner:28303

Review URL: https://codereview.chromium.org/250863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266299 0039d316-1c4b-4281-b951-d872f2087c98

Causing failures in browser_tests.

R=rmsousa@chromium.org
NOTRY=true
BUG=NONE

Review URL: https://codereview.chromium.org/256763005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266298 0039d316-1c4b-4281-b951-d872f2087c98

2. Introduce a template class GuestView<T> to handle the    *guestview-specific functions in guestview.h:
   . Rename GuestView to GuestViewBase, introduce GuestView<T> class, and move *ViewGuest-specific functions to     GuestView<T>:
        -- FromWebContents<T>(...)
        -- From<T>(...).
   . Introduce a template member function As() in      GuestViewBase to replace all of the As*View functions.

3. In each derived *ViewGuest class , e.g., WebViewGuest &    AdViewGuest, define a static variable to show its view type    (string).


BUG=351824

Review URL: https://codereview.chromium.org/237533008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266297 0039d316-1c4b-4281-b951-d872f2087c98

BUG=254066

Review URL: https://codereview.chromium.org/253523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266293 0039d316-1c4b-4281-b951-d872f2087c98

BUG=365663

Review URL: https://codereview.chromium.org/254523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266292 0039d316-1c4b-4281-b951-d872f2087c98

BUG=342662
TBR=jiayl@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/252563006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266291 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=jschuh@chromium.org, sievers@chromium.org

Review URL: https://codereview.chromium.org/256713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266290 0039d316-1c4b-4281-b951-d872f2087c98

There is now a limit on number of events per proto (AggregatedFrameEvent
and BasePacketEvent). There is also a limit on number of packets per
frame (i.e. number of BasePacketEvent in AggregatedPacketEvent). If
either limit is exceeded, a new proto will be created for that frame.

The underlying implementation of EncodingEventSubscriber is also
changed. When the internal map reaches a certain size, its old entries
will be transferred to a vector for storage. This is done to keep the
map small and lookup fast.

A proto will also be
transferred to storage if adding an event to it would result in
exceeding the limit stated above. The scheme is not perfect, but such
situation rarely happens in practice.

Also changed deserialization to be able to merge protos of the same
frame.

This is done to keep protos size in check. Also, LogSerializer will now
fail DCHECK if the protos exceed the maximum size 2^16 - 1. (Because
we encode size as 16 bits).


BUG=

Review URL: https://codereview.chromium.org/241833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266289 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/258563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266288 0039d316-1c4b-4281-b951-d872f2087c98

doesn't pass a third argument to chrome.send('removeException');

R=thestig@chromium.org
BUG=362362

Review URL: https://codereview.chromium.org/243803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266287 0039d316-1c4b-4281-b951-d872f2087c98

Linux Breakpad: Keep reading from the crash upload progress until a complete crash id has been received.

BUG=363660

Review URL: https://codereview.chromium.org/248653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266286 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266285 0039d316-1c4b-4281-b951-d872f2087c98

Chromium NaCl scripts now uses package_version to extract.

Now that we have split up the toolchain into multiple tars, we should
use the package versioning script to manage which tars to extract.
Unfortunately, currently the SDK uses different directory names compared
to what the NaCl toolchain directories normally use, so we also must map
and move the toolchain directories to the SDK ones.

BUG=365817
TEST= trybots

Review URL: https://codereview.chromium.org/249153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266284 0039d316-1c4b-4281-b951-d872f2087c98

wm.gyp:wm depends on aura.gyp:aura, so this ensures that any gyp
use_aura guards also guard wm.gyp. Also fix some toolkit_views/use_aura
gyp usage, and add mac stubs for ui/base/dragdrop so the gyp conditions
don't explode (they will be needed later).

BUG=366007

Review URL: https://codereview.chromium.org/248893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266283 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/250653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266282 0039d316-1c4b-4281-b951-d872f2087c98

R=tonyg@chromium.org
BUG=360204

Review URL: https://codereview.chromium.org/255603003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266281 0039d316-1c4b-4281-b951-d872f2087c98

To use:
1) Run gyp with GYP_DEFINES="enable_resource_whitelist_generation=1", build.
2) Pipe the build output into find_used_resources.py to generate a whitelist.
3) Run gy with GYP_DEFINES="enable_resource_whitelist_generation=1  repack_options="--whitelist...", build.
4) Pipe the second build output into list_resources_removed_by_repack.py.

Requires grit-i18n r167 to generate the unused resource list in step 3.

BUG=338759
NOTRY=true

Review URL: https://codereview.chromium.org/248173004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266280 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/259523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266278 0039d316-1c4b-4281-b951-d872f2087c98