GitLab

Revert of Dont post delayed DoWork for disabled queues. (patchset #9 id:160001 of https://codereview.chromium.org/2572893002/ )

Reason for revert:
Speculative revert.  Might be causing renderer hangs.

Original issue's description:
> Dont post delayed DoWork for disabled queues. We could do this for fences too but don't
> because that would break the throttling logic which needs to know when the next delayed
> task is due to be run.
>
> BUG=671669
>
> Committed: https://crrev.com/cab9842ac55e5b9dab766f11c6e412949d854483
> Cr-Original-Commit-Position: refs/heads/master@{#438962}
> Review-Url: https://codereview.chromium.org/2572893002
> Cr-Commit-Position: refs/heads/master@{#447591}
> Committed: https://chromium.googlesource.com/chromium/src/+/9a8a61516e750796f74869167bb919a05551d4dd

TBR=skyostil@chromium.org,haraken@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=671669, 688426, 688422

Review-Url: https://codereview.chromium.org/2674903003
Cr-Commit-Position: refs/heads/master@{#448046}

This changes the rule about testharness test results to make
it less conservative and simpler - so that newlines and text
in the output are OK, and the test is considered passing as
long as there's at least one PASS and no FAIL.

BUG=687492

Review-Url: https://codereview.chromium.org/2668973002
Cr-Commit-Position: refs/heads/master@{#448045}

The test shouldn't explicitly import load_time_data.js, because in Vulcanized
mode it ends up importing that file twice, whcih throws an error. Instead the
element being tested should depend on i18n_setup.html in the first place.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2675863003
Cr-Commit-Position: refs/heads/master@{#448044}

The blocking pool is being deprecated in favor of TaskScheduler.

BUG=667892
R=stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2676003002
Cr-Commit-Position: refs/heads/master@{#448043}

Newly written test reproduces crbug.com/681434 and currently disabled
because of this bug.

BUG=681434

Review-Url: https://codereview.chromium.org/2672893003
Cr-Commit-Position: refs/heads/master@{#448042}

Wait until new Tab is open after opening it using DOM.
|waitForPageToFinishLoading| does not wait for the new Tab.

BUG=None

Review-Url: https://codereview.chromium.org/2671613006
Cr-Commit-Position: refs/heads/master@{#448041}

The previous code caused that dismissing the ToolMenu would dismiss the whole Tab
(Toolbar+content view) and left the App in a corrupted state. (The coordinators were
not stopped but their VC was dismissed).

This is a temporary fix. Marq will submit a more robust solution to this problem later on.

BUG=

Review-Url: https://codereview.chromium.org/2667873002
Cr-Commit-Position: refs/heads/master@{#448040}

When generating IDL bindings for the Window interface, the bindings
will now downcast to LocalDOMWindow if the access is a same-origin
accesses. This allows for simplification of DOMWindow and its
subclasses to be simpler and easier to understand:

- Cross-origin behavior is more clearly highlighted as the shared base
  class only has a few virtual methods now.
- Same-origin behavior is moved completely into LocalDOMWindow.
- RemoteDOMWindow no longer has several dozen methods that simply
  ASSERT_NOT_REACHED().
- Partial window interfaces are now correctly anchored off
  LocalDOMWindow rather than requiring all implementations to downcast

BUG=none

Review-Url: https://codereview.chromium.org/2668753006
Cr-Commit-Position: refs/heads/master@{#448039}

s/HTTP2_SESSION_RST_STREAM/HTTP2_SESSION_RECV_RST_STREAM/ to make it obvious
that a frame is received.  Sending event is already called _SEND_RST_STREAM.

Split NetLogSpdyRstCallback() into NetLogSpdyRecvRstStreamCallback() and
NetLogSpdySendRstStreamCallback(), and remove |description| argument from
NetLogSpdyRecvRstStreamCallback().  (This is leftover from earlier SPDY versions
that allowed RST_STREAM fields to carry a description.  HTTP/2 does not allow
this, and NetLogSpdyRstCallback() was always called with an empty description
when a RST_STREAM frame was received.)

Similarily, s/HTTP2_SESSION_GOAWAY/HTTP2_SESSION_RECV_GOAWAY/.  Note that there
is no HTTP2_SESSION_SEND_GOAWAY: instead a HTTP2_SESSION_CLOSE is logged.

Since there were already five HTTP2_SESSION_RECV_ events and this CL adds two
more, also change _RECEIVED_ to _RECV_ in HTTP2_SESSION_RECEIVED_WINDOW_UPDATE_FRAME.

Since there were already four HTTP2_SESSION_SEND_ events, also change _SENT_ to
_SEND_ in HTTP2_SESSION_SENT_WINDOW_UPDATE_FRAME.

Since there are event names for HEADERS, SETTINGS, RST_STREAM, PING, GOAWAY,
DATA, and PUSH_PROMISE frames without _FRAME suffix, also remove such suffix from
HTTP2_SESSION_RECV_WINDOW_UPDATE_FRAME and HTTP2_SESSION_SEND_WINDOW_UPDATE_FRAME.

Review-Url: https://codereview.chromium.org/2675723003
Cr-Commit-Position: refs/heads/master@{#448038}

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

This CL migrates most, but not all references to add(). A future CL
will complete the migration and remove the add() method altogether.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2671933002
Cr-Commit-Position: refs/heads/master@{#448037}

These bots are gone and we don't need to filter them out.

BUG=683336

Review-Url: https://codereview.chromium.org/2657623003
Cr-Commit-Position: refs/heads/master@{#448036}

This resolves some TODOs left over from shelf refactoring.

Eliminate various GetAlignment() utility functions and instead call into
WmShelf::GetAlignment() directory.

Prefer WmShelf::IsHorizontalAlignment() to the bare utility fuction.

Fix IWYU violations.

BUG=635963
TEST=ash_unittests
TBR=dmazzoni@chromium.org for IWYU in c/b/chromeos/accessibility

Review-Url: https://codereview.chromium.org/2676673005
Cr-Commit-Position: refs/heads/master@{#448035}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5de4d94e..f6fe1e8f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2673063002
Cr-Commit-Position: refs/heads/master@{#448034}

Since __DATE__, __TIME__, and __TIMESTAMP__ has been set during the
build, flatc now become deterministic.

BUG=314403

Review-Url: https://codereview.chromium.org/2674823002
Cr-Commit-Position: refs/heads/master@{#448033}

In Network Quality Estimator (NQE), do not record the correlation
metric if any of the underlying metric is unavailable. Also, do not
record the correlation metric if there was a connection change
recently. These changes ensure that the metric is recorded only when
valid values were available.

BUG=688198
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2668403003
Cr-Commit-Position: refs/heads/master@{#448032}

BUG=686632

Review-Url: https://codereview.chromium.org/2675763004
Cr-Commit-Position: refs/heads/master@{#448031}

BUG=679905
R=foolip

Review-Url: https://codereview.chromium.org/2670653003
Cr-Commit-Position: refs/heads/master@{#448030}

Revert of Set the Ash browser frame color for MD WebUI (Settings) (patchset #3 id:40001 of https://codereview.chromium.org/2676673003/ )

Reason for revert:
Broke this builder:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/83127

Original issue's description:
> Set the Ash browser frame color for MD WebUI (Settings)
>
> Currently Settings is the only Web IU we show in a dedicated browser
> window on Ash (Chrome OS).
>
> BUG=684129
>
> Review-Url: https://codereview.chromium.org/2676673003
> Cr-Commit-Position: refs/heads/master@{#448024}
> Committed: https://chromium.googlesource.com/chromium/src/+/31dc779f1ecd8dabd26dfed11bef773c95ae5b47

TBR=sky@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=684129

Review-Url: https://codereview.chromium.org/2672083002
Cr-Commit-Position: refs/heads/master@{#448029}

https://skia.googlesource.com/skia.git/+log/113628d76176..20f00784b850

$ git log 113628d76..20f00784b --date=short --no-merges --format='%ad %ae %s'
2017-02-02 mtklein Restore ios_flavor.
2017-02-03 bsalomon Make shadow tessellators fail gracefully and add unit test for this.
2017-02-03 senorblanco GrTessellator (AA): Fix for missing fill artifacts.
2017-02-03 jvanverth Initialize some more variables in SpotShadowTessellator
2017-02-02 reed experimental tight-bounds

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=halcanary@google.com

Review-Url: https://codereview.chromium.org/2674573009
Cr-Commit-Position: refs/heads/master@{#448028}

BUG=688004

Review-Url: https://codereview.chromium.org/2669263002
Cr-Commit-Position: refs/heads/master@{#448027}

BUG=

Review-Url: https://codereview.chromium.org/2651623005
Cr-Commit-Position: refs/heads/master@{#448026}

https://boringssl.googlesource.com/boringssl/+log/772a5bed7d5065b301c3979c325248689d36b92c..5fa2cdf1ed4069be359038107e144cd7c7506dca

This picks up the CPU flag fix.

BUG=688384

Review-Url: https://codereview.chromium.org/2672603005
Cr-Commit-Position: refs/heads/master@{#448025}

Currently Settings is the only Web IU we show in a dedicated browser
window on Ash (Chrome OS).

BUG=684129

Review-Url: https://codereview.chromium.org/2676673003
Cr-Commit-Position: refs/heads/master@{#448024}

base::Time and base::TimeTicks interfaces expose a is_null() method. Unfortunately
in current implementation is_null() == is_zero() which means that it is possible
to write code that produces valid zero time but is confused with null time.
So depending on this API can lead to brittle and buggy code. There is also a desire
to eventually get rid of |is_null()| in base/ interface.

Given above we shouldn't depend on this behavior in Blink. Any code that needs to have
a "null" or "invalid" time value can use WTF::Optional<WTF::Time> instead which
is more readable and explicit.

BUG=625680

Review-Url: https://codereview.chromium.org/2656843003
Cr-Commit-Position: refs/heads/master@{#448023}

Previously the GCMKeyStore tests used net/ EXPECT_DFATAL(), which avoids forking but is designed to expect LOG(DFATAL) in net/ code, rather than DCHECKs.

The InkDropImplTest used ASSERT_DEATH_IF_SUPPORTED but ran conditional on DCHECK_IS_ON(), whereas EXPECT_DCHECK_DEATH() is implicitly executed only if DCHECK_IS_ON().

BUG=596231

Review-Url: https://codereview.chromium.org/2642173002
Cr-Commit-Position: refs/heads/master@{#448022}

Revert of binding: Makes xss-DENIED-window-name-navigator deterministic. (patchset #2 id:20001 of https://codereview.chromium.org/2673583003/ )

Reason for revert:
Builds on https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29 have been consistently failing since this CL was landed.  Reverting for that reason.

Original issue's description:
> binding: Makes xss-DENIED-window-name-navigator deterministic.
>
> Makes the test result of xss-DENIED-window-name-navigator.html
> deterministic and fixes the flakiness.
>
> BUG=686470
>
> Review-Url: https://codereview.chromium.org/2673583003
> Cr-Commit-Position: refs/heads/master@{#447958}
> Committed: https://chromium.googlesource.com/chromium/src/+/114e65b6ddfd281fadd15c8ee43894b40b984b91

TBR=haraken@chromium.org,yukishiino@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=686470

Review-Url: https://codereview.chromium.org/2673833004
Cr-Commit-Position: refs/heads/master@{#448021}

TBR=wangxianzhu@chromium.org

Review-Url: https://codereview.chromium.org/2674963002 .
Cr-Commit-Position: refs/heads/master@{#448020}

BUG=687976

Review-Url: https://codereview.chromium.org/2678463002
Cr-Commit-Position: refs/heads/master@{#448019}

If we cannot instantiate a shader (due to e.g. a non-invertible local
matrix), the expectation is to not draw anything.  We're currently
filling with black.

This unblocks https://skia-review.googlesource.com/c/7885/, which
prevents creation of shaders with non-invertible matrices.

R=reed@google.com

Review-Url: https://codereview.chromium.org/2677633004
Cr-Commit-Position: refs/heads/master@{#448018}

- Have native pass app button presses up to the UI.
- The UI decides whether or not to be in menu mode.
- The UI may call back down to native to pause content, if desired.

BUG=644565
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2664973002
Cr-Commit-Position: refs/heads/master@{#448017}

This allows listing the QR Code scanner entry directly in the .plist listing the
force touch actions, as opposed to adding it at runtime,

BUG=675625

Review-Url: https://codereview.chromium.org/2676803002
Cr-Commit-Position: refs/heads/master@{#448016}

BUG=629123

patch from issue 2244283002 at patchset 1 (http://crrev.com/2244283002#ps1)

Review-Url: https://codereview.chromium.org/2675753004
Cr-Commit-Position: refs/heads/master@{#448015}

Fix for an issue where the tabstrip animates out when you're still
cycling between tabs.

BUG=591776

Review-Url: https://codereview.chromium.org/2672913002
Cr-Commit-Position: refs/heads/master@{#448014}

BUG=686803

TBR=reillyg@

Review-Url: https://codereview.chromium.org/2675963003
Cr-Commit-Position: refs/heads/master@{#448013}

Fake identity service is not a mock, and it shouldn't use mocks when possible.
Those mocked methods were never overriden anyway.

BUG=None

Review-Url: https://codereview.chromium.org/2670843003
Cr-Commit-Position: refs/heads/master@{#448012}

Revert of Use trace-pc-guard for libFuzzer. (patchset #1 id:1 of https://codereview.chromium.org/2672853002/ )

Reason for revert:
Still borked on bots.

Original issue's description:
> Reland of Use trace-pc-guard for libFuzzer. (patchset #1 id:1 of https://codereview.chromium.org/2668093004/ )
>
> Reason for revert:
> Got upgraded builders.
>
> Original issue's description:
> > Revert of Use trace-pc-guard for libFuzzer. (patchset #1 id:1 of https://codereview.chromium.org/2665243002/ )
> >
> > Reason for revert:
> > causing build failures: https://crbug.com/687570
> >
> > Original issue's description:
> > > Use trace-pc-guard for libFuzzer.
> > >
> > > BUG=651540
> > >
> > > Review-Url: https://codereview.chromium.org/2665243002
> > > Cr-Commit-Position: refs/heads/master@{#447392}
> > > Committed: https://chromium.googlesource.com/chromium/src/+/002dca9ca557b96939ed99ae9450dcb42f5d1620
> >
> > TBR=inferno@chromium.org,kcc@chromium.org,aizatsky@chromium.org,mmoroz@chromium.org,dpranke@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=651540
> >
> > Review-Url: https://codereview.chromium.org/2668093004
> > Cr-Commit-Position: refs/heads/master@{#447552}
> > Committed: https://chromium.googlesource.com/chromium/src/+/23d6de2177b812285946bce6f459815799d825c5
>
> TBR=inferno@chromium.org,kcc@chromium.org,aizatsky@chromium.org,mmoroz@chromium.org,dpranke@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=651540
>
> Review-Url: https://codereview.chromium.org/2672853002
> Cr-Commit-Position: refs/heads/master@{#447825}
> Committed: https://chromium.googlesource.com/chromium/src/+/28fbc2f08338a66ed15e96fd2841c66cbbda212f

TBR=inferno@chromium.org,kcc@chromium.org,aizatsky@chromium.org,mmoroz@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=651540

Review-Url: https://codereview.chromium.org/2675983002
Cr-Commit-Position: refs/heads/master@{#448011}

The histograms "Session.ClosedTabCounts", "Session.NewTabCounts" and
"Session.OpenedTabCounts" have never been documented and cannot be
easily be checked on uma. Document them to fix this.

BUG=None

Review-Url: https://codereview.chromium.org/2671993003
Cr-Commit-Position: refs/heads/master@{#448010}

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2672643004
Cr-Commit-Position: refs/heads/master@{#448009}

Since Wallet addresses don't have an email address, the signed-in
user's email address should be used if the Wallet address is not
merged into an existing local profile.

BUG=680182

Review-Url: https://codereview.chromium.org/2671813005
Cr-Commit-Position: refs/heads/master@{#448008}

BUG=none

Review-Url: https://codereview.chromium.org/2677683002
Cr-Commit-Position: refs/heads/master@{#448007}