- 21 May, 2020 23 commits
-
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590004011-c7e121da0d5a86abd485d92fadbd2d4beb7d781b.profdata to chrome-mac-master-1590019092-0150ca95063dc0ad33468a89535d4804f9e0bc6b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I8aace7ab099334863d49d655e97c004cd047958f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211029Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770875}
-
Devlin Cronin authored
We still need it around. Extend it through M87. Bug: 1085244 Change-Id: I61c18a1968687d4cf822ea8f8fcd684a98bf6340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210447Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770874}
-
Takashi Toyoshima authored
This reverts commit c24f6f28. Reason for revert: enabled back again. Original change's description: > OOR-CORS: Disable by default on Android for safe WebView launch at M83 > > Disable OOR-CORS by default on Android again to mitigate risks on > launching the feature on WebView M83. > > Bug: 1084380 > Change-Id: Idd1a1aa9ef2ce813de78fe7d6ea3d5835bf8f2e5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206565 > Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#769990} TBR=kinuko@chromium.org,toyoshim@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1084380 Change-Id: Ia5d8477fffaa77eaf5181d8106c734f1c5529cdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210178Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#770873}
-
Michael Hansen authored
Adds the FastInitiationManager class which will broadcast advertisements with the service UUID 0xFE2C. The broadcast data will be 0xFC128E along with 2 additional bytes of metadata at the end. Some remote devices background scan for Fast Initiation advertisements, as a signal to begin advertising via Nearby Connections. Bug: b:154846208 Change-Id: I73667d99993e289488b7719e10467c9344b7b3fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190743Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#770872}
-
Adam Langley authored
With all the changes recently to handle known key types, this change adds a test to ensure that RPs and authenticators can still negotiate an unknown public key algorithm and the key will pass through successfully. Change-Id: Ia63cdc89beef9182835a02ab28b9f64164917c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204086Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#770871}
-
Allen Bauer authored
NotificationOverflowView Bug: 1044687 Change-Id: I4625c0c13447b930c7f1c87b8ea33cdcc3d10f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209301Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#770870}
-
Jeff Yoon authored
* mb configs are set in mb_config.pyl * *.star changes are for setting the recipe to Chromium * the release branches use the mac_ios_builder definitions, so we cannot set recipe:Chromium as default. Will do this after M83. * tests are defined under testing/buildbot * crashpad tests have been left out as they were unable to be migrated to EG/EG2 formats, per conversation w/ rohitrao@ Bug: 1078906,912681 Change-Id: I65c9db47f9173f542ddd4d0e28757f8a54c06367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188234 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#770869}
-
David Bertoni authored
GetAuthTokenFunctionPublicSessionTest.Whitelisted was disabled for flakiness in 2018. I tested this on both release and debug configurations of ChromeOS and it passed 3000 iterations. Bug: 830052 Change-Id: Ibdca8b58eb9800946791c919f098dd16284e22bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209388Reviewed-by:
Archana Simha <archanasimha@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#770868}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/008b71ab1384..d3affaa62488 2020-05-20 sokcevic@google.com Use OS level locking in git_cache.py If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1049610 Tbr: agable@chromium.org Change-Id: I72cbbaecc3ab7ebd9f5dd5b767d7f05738d379ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211023Reviewed-by:
-
Thomas Guilbert authored
This CL adds new video.requestVideoFrameCallback tests, that verify the behavior of the API when it is used on elements that are not visible, or that have been removed from the DOM. The CL also adds videos created in existing tests into the DOM, which makes the tests closer to the expected usage of the API. This addresses the following github issue: https://github.com/WICG/video-rvfc/issues/30 Bug: 1012063 Change-Id: Ic9bf3fc1a09fd77b20abbfdcfb39bbd1851da99e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207947 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#770866}
-
Joel Hockey authored
Turning on DesktopPWAsWithoutExtensions flag in crrev.com/c/2208319 has caused a crash when logging into CrOS. Bug: 1084846 Change-Id: Iaddf78f84231b1ed4ef103c9961b411e1dab6171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210195 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#770865}
-
Alice Boxhall authored
Bug: 1051141 Change-Id: I1566eb705f583ee44fcf627b38a7bd99895f83de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208807 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#770864}
-
Brian Sheedy authored
Carries over a pixel test suppression specific to Intel HD 630 GPUs to Intel UHD 630 GPUs, as the same failure is showing up on the newer GPUs. TBR=ynovikov@chromium.org Bug: 1053803, 997313 Change-Id: Ica3dbfec3f0041a0726a76a008da7272500c0912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202784Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#770863}
-
Clark DuVall authored
We were recreating the AutofillProvider every time TabImpl.updateFromBrowser() was called, which cancels the current autofill request. updateFromBrowser() is called for various reasons, and can be called multiple times with the same context. Bug: 1083051 Change-Id: I7336566002b20f4dbcbaa5c489e4bfa92d1c4ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211041Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#770862}
-
Eric Lawrence authored
Logging calls to NetLog in the SpdyStream object were inconsistent and overly verbose. This patch makes them simpler and consistent. There should be no functional change. Change-Id: I689dcdbcea4673223c5a34c173065b72125e6686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210553 Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#770861}
-
François Degros authored
Added tests showing that the zip-no-nacl flag has no impact on Files App at the moment. BUG=912236 TEST=browser_tests --gtest_filter="ZipFiles/*" --gtest_list_tests TEST=browser_tests --gtest_filter="ZipFiles/*" Change-Id: I40d3bc780e75b90407e07fcecc4e90f3e0aea83a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203169 Commit-Queue: François Degros <fdegros@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#770860}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7f02db5d3be5..c256b1f2a5f3 2020-05-20 soxia@microsoft.com [DevTools Frontend] Add missing icons. 2020-05-20 sigurds@chromium.org Typescriptify HeapProfilerModel If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1079233 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8c7607af4677265cc63e82611ee7a6b809ba6548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211022Reviewed-by:
-
Hiroki Nakagawa authored
This CL modernizes the test using async/await, arrow functions etc for improving code readability. Bug: 1075582 Change-Id: I00b9da946299fd0e9e93204514e0857adc85ef93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208885Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#770858}
-
Jing Wang authored
- Record coverage metrics only when we show the suggestions - Change current coverage metrics to match metrics. - Add disabled metrics Previously we were recording coverage metrics for personal info in a wrong place. Now we moved it to the correct place and added a new metric for all the match scenarios. Add disabled metrics for cases where we could show suggestion but the feature is turned off. For personal info suggester, we only record coverage metrics when we first show a suggestion so that we won't record dup metrics when the user keeps typing with suggestion shown. Test: tested with Chrome on Linux Bug: 1042084 Change-Id: I6559d81f8d3fc5fa2f9385a4df617f0ac06c5848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208577Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#770857}
-
Will Cassella authored
base::TimeDelta will fail a DCHECK if you ever try to add -INF and +INF time deltas. A consequence of this is if you have a video with a -INF start_time and you try to seek to +INF, the current code will trigger that DCHECK. This CL fixes that by settings -INF start times to 0. This is consistent with how +INF start times are handled. Bug: 1077685 Change-Id: I4e7fd453aab7a6b15befbb52b708d56febb943ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194917Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#770856}
-
Brian Liu Xu authored
This changelist includes the following to make |TreeView| explorable: - Replaces the |kInvisible| state with the |kIgnored| state for unshown root nodes. This allows IAccessible2 clients to enter the tree to access individual tree items. - Bridges accessibility hit testing from Views to virtual views so that pointer-based assistive technologies can access individual tree items using screen coordinates. items inside tree views. AX-Relnotes: In Views, assistive technologies can now hit test tree Bug: 811277 Change-Id: I56788354aa51b3598ff1afc96cb7214b12d04a85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134415 Commit-Queue: Brian Liu Xu <brx@microsoft.com> Reviewed-by:Scott Violet <sky@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#770855}
-
Maggie Chen authored
We no longer run finch for underlays. Underlays are enabled by default. Bug: 868561 Change-Id: I2a2097a03a0aac32a32bb509fc686e2d15c3086c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207971Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#770854}
-
Maxime Charland authored
Previously, scrollToTop while the omnibox is focused would scroll to the top and 2 omnibox would be visible. Now, first unfocus omnibox, then allow scrollToTop. Before: https://drive.google.com/file/d/1zn69R672sRTRe6GG3s4Mc7WVo2Q6G4xo/view?usp=sharing After (Patchset 1-6) : https://drive.google.com/file/d/1fiiZZBwWfXb7gb66dCfOwW6yGSBemayi/view?usp=sharing After stuttering fix (Patchset 7+) : https://drive.google.com/file/d/1A2FavkilxFqFVFjh2A5wN0SATsrMENGx/view?usp=sharing Change-Id: I3c026bb800a243ef0bab150cfac4f696bbb14c40 Bug: 965473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201896 Commit-Queue: Maxime Charland <mcharland@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#770853}
-
- 20 May, 2020 17 commits
-
-
Regan Hsu authored
This CL changes the aria label from simply "Back." to something more descriptive to the screen reader user: "[Subpage title] back button", with the role description: "Click to navigate away from [Subpage title] page" so that the user is aware that they are currently at the "[name of subpage]" subpage, and that activating the back button will cause a route change to the previous page. Videos: https://drive.google.com/drive/folders/14JjstEYIC3-la2gIlGzo1pRa__NXDYBm?usp=sharing Bug: 1071284 Change-Id: I4bd6e4400c84b63fe89ad2fe68f62e6d6f468657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200144 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#770852}
-
Brian Liu Xu authored
Implements virtual view targeting for accessibility actions for |TreeView| nodes so that they may be activated using the accessibility review cursor. Previously, all actions were routed to the selected node, even if the review cursor was on a different element. Since focus is an accessible action, this changelist also includes improvements to how accessibility focus events get fired around virtual views: - If a focused virtual descendant is set when |FocusManager| gives focus to the owner view, the descendant (instead of the owner view's accessible object) now fires the accessibility focus event. - Consequently, by setting the |TreeView|'s focused virtual descendant, ahead of time, TreeView::OnFocus() no longer needs to redirect focus to a virtual view via ViewAccessibility::OverrideFocus(). This avoids firing multiple accessibility focus events for a single focus change. inside tree views. AX-Relnotes: In Views, assistive technologies can now select tree items Bug: 811277 Change-Id: I232c2acf2f4fec79ea30dbe82b5f077a4f9c32b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135205 Commit-Queue: Brian Liu Xu <brx@microsoft.com> Reviewed-by: -
wutao authored
Previously we allow to prefetch any preset number of images, but this is not required and increases the complexity of code. This patch simplifies the photo refresh logic. We only prefetch one more image than displayed, which is used for photo transition animation. Bug: b/156271483 Test: new unittests. Change-Id: I0222c8f4db80d98dbd8f65453b4f8fe07bcb59e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209538Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#770850}
-
Nate Chapin authored
Bug: 1084831 Change-Id: Ia145d711cc71fdfc698e560ad67e1723390025c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210005Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#770849}
-
Joel Hockey authored
Bug: 1083825 Change-Id: I9272bb8031e73b48b23b72822d86844a157b9cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210173Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#770848}
-
David Tseng authored
R=dmazzoni@chromium.org AX-Relnotes: n/a Change-Id: Id9be642689ddd4898d7d062fad51408642fed204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204844 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#770847}
-
Mohamed Amir Yosef authored
This CL adds support to the Combobox model to show different text and icon inside the combobox from that shown inside the dropdown menu. Bug: 1044038 Change-Id: Iad33be358e24f212db92fd5e774d52ec9bdd772d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207168 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#770846}
-
Xiaohan Wang authored
The logs in media_drm_bridge.cc is critical in investigating issues on cast receivers on Android TV. So include logging_override_if_enabled.h so that the DVLOGs are overridden if enabled. Bug: b/153475498 Change-Id: Iced008defa05339111a394e1f1a9d396e351b21c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210790Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#770845}
-
Nate Chapin authored
Bug: 1085075 Change-Id: I0ffcd576cfec8545d466b2d24187e6d3be75160d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209607 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Yi Xu authored
Bug: 1071659 Change-Id: Ife29376566fc1c6cadabef2f8a9040bbd208842f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209522Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#770843}
-
James Cook authored
The mash/mustash project was shut down over a year ago. Clean up some obsolete comments and DEPS. Bug: none Change-Id: I9d9ce137a4cf42330eb104be7c9613a4c4ab0675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210631Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#770842}
-
Thomas Guilbert authored
This CL replaces VideoTrackReader's ReadableStream with an output callback, to be passed in at construction time. Switching VTR to use a callback aligns it with the general direction of WebCodecs. It also works because there isn't the need for backpressure when using getUserMedia(). Additionally, a change in constraints to the MediaStreamTrack would mean that we might have to flush the unread frames from ReadableStream. This shouldn't happen with a callback (but we don't invalidate pending frames when constraints change, for now). Bug: 1080834 Change-Id: I5ff424f9440660dadc52ba6d4d76d14b5840a6d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191204 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#770841}
-
Kartik Hegde authored
Add a routine to determine whether the current network has nameservers available for DNS resolution. BUG=chromium:956783 TEST=unit_tests --gtest_filter=ResolverPresentRoutineTest.* Change-Id: Ic9055f2bdce2df0e5bd8c3e147a635cd0e6a31c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151676Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#770840}
-
Esmael El-Moslimany authored
Bug: 1084640 Change-Id: I21e89cbe3429c25f8a01f2cc0b79d5b5020c9024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209237 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#770839}
-
Rahul Arakeri authored
A "mouse click" is comprised of a mousedown and a mouseup. During a mousedown on a scrollbar arrow, a GSB and a GSU are queued up in the CompositorThreadEventQueue. On mouseup, a GSE gets added to the queue. These gesture events are VSync aligned. However, if the user is rapidly clicking on the arrow, we will get another mousedown before the queued up GSE (from the first mouse click) has had a chance to be processed. This new mousedown now ends up calling InputHandlerScrollEnd and that in turn sets handling_gesture_on_impl_thread_ to false. When the queued up GSE from the first mouse click finally gets dispatched, it notices that handling_gesture_on_impl_thread_ is false and hence, leads to DCHECK(!currently_active_gesture_device_.has_value()) failing. This CL fixes the bug by clearing currently_active_gesture_device_ when the ongoing scroll ends. Bug: 1068062 Change-Id: Ie953c1336c2b74895dd0853da7c229928e137fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191198 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#770838}
-
Xing Liu authored
This reverts commit 8a79ddf4. Reason for revert: Breaks the build. https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8879743677570880208/+/steps/compile/0/stdout Need to investigate gn/build issue. Original change's description: > Android: New build target chrome/browser/contextmenu > > This CL moves some interfaces for context menu under > chrome/browser/contextmenu and defines a new modularized target. > > This allows TabDelegateFactory class to chrome/browser/tab, and > put |TabImpl.updateAttachment| back to Tab interface. > > Bug: 952703 > Change-Id: Ie5534ce07c8e84593e6033141501e3f3a0ba4704 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201796 > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770805} TBR=nyquist@chromium.org,tedchoc@chromium.org,twellington@chromium.org,jinsukkim@chromium.org Change-Id: I7e86f199aa960b5c3b4bb00609f6d51c1aed1856 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 952703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211076Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770837}
-
Ben Kelly authored
Bug: 1035448 Change-Id: Ib029e2c3115a5f0d8e9d3c9dcfd014e5851f827b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209339Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#770836}
-
