GitLab

After r170314, the HTML parser thread allocates on-heap objects such as CSSValues. So this CL supports the HTML parser thread in oilpan. Also this CL marks the CSSValue hierarchy with ThreadAffinity=AnyThread because CSSValue can be allocated by both main thread and parser threads.

BUG=340522

Review URL: https://codereview.chromium.org/216203006

git-svn-id: svn://svn.chromium.org/blink/trunk@170564 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/aLpDg8pviU0/dUbUt7jsvT4J

javascriptURL-execution-context-frame-location-htmldom.html was
identical to javascriptURL-execution-context-frame-src-htmldom.html
apart from the attribute set, so remove it.

javascriptURL-execution-context-frame-location-htmldom-uncaught.html
tests code that was removed in V8HTMLFrameElementCustom.cpp and does not
have a counterpart for the src attribute, so remove it too.

BUG=358505

Review URL: https://codereview.chromium.org/220563002

git-svn-id: svn://svn.chromium.org/blink/trunk@170563 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=eustas, lushnikov, pfeldman
BUG=358098
NOTRY=true

Review URL: https://codereview.chromium.org/220763004

git-svn-id: svn://svn.chromium.org/blink/trunk@170562 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There have been discussions about removing foreignObject and instead
allow an html element with position and dimensions inside svg. Knowing
how popular foreignObject is may be useful in such discussions.

Review URL: https://codereview.chromium.org/220713003

git-svn-id: svn://svn.chromium.org/blink/trunk@170561 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These calls were for non-Chromium port of WebKit to get/set cookies on
WebSocket opening handshake. In Blink, they're no longer necessary.
Chromium intercepts handshakes in the browser process and add/remove
cookies. Any cookie header added by Blink is ignored. Set-cookies are
stripped before forwarded to Blink.

BUG=none

Review URL: https://codereview.chromium.org/209823002

git-svn-id: svn://svn.chromium.org/blink/trunk@170560 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=vsevik@chromium.org, vsevik
BUG=357614

Review URL: https://codereview.chromium.org/216183003

git-svn-id: svn://svn.chromium.org/blink/trunk@170559 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357520

Review URL: https://codereview.chromium.org/219333007

git-svn-id: svn://svn.chromium.org/blink/trunk@170558 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds a Ctrl-D shortcut to the devtools editor which selects
the next occurrence of word or selection. Implementation is based
on CodeMirror v4 multiple cursor capabilities.

BUG=356878

Review URL: https://codereview.chromium.org/219583002

git-svn-id: svn://svn.chromium.org/blink/trunk@170557 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=haraken@chromium.org, oilpan-reviews@chromium.org, wibling@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/220763005

git-svn-id: svn://svn.chromium.org/blink/trunk@170556 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch allows the validator checks to handle types declared as
/** @constructor */ var MyType = function() {}

R=pfeldman, sergeyv

Review URL: https://codereview.chromium.org/218993012

git-svn-id: svn://svn.chromium.org/blink/trunk@170555 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=341815

Review URL: https://codereview.chromium.org/220893002

git-svn-id: svn://svn.chromium.org/blink/trunk@170554 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make ImageFrame store an SkBitmap directly instead of indirectly via
NativeImageSkia.
The direct effect is less indirections in ImageFrame, but this allows
making NativeImageSkia more immutable-looking since the SkBitmap&
accessor and setDataComplete() method can be removed.

Review URL: https://codereview.chromium.org/170463002

git-svn-id: svn://svn.chromium.org/blink/trunk@170553 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This shorthand sets the values for the grid-template-columns, 
grid-template-rows and grid-template-areas, so the 
implementation tries to reuse as much available parsing 
functions as possible.

The "parsingGridTrackList" was refactored to return a 
CSSValue and let the "parseValue" function to assign the 
property value. The "forwardSlash" operator is now valid 
when the track-list clause is part of a shorthand. The  
"parseValue" function checkouts that only additional 
clauses are allowed when processing shorthands; the 
grid-columns-rows-get-set.html tests was modified to verify 
this.

The "parseGridTemplateAreas" was refactored too, in order 
to process single areas's rows. This is very useful for the 
gris-template secondary syntax, which mixes areas and rows 
values.


Finally, the "parseGirdLineNames" function was modified as 
well by defining an new argument to concatenate head/tail 
custom-ident elements and ensure the identList is at the 
heading index, since it's now possible the parseList was 
rewound.

The implementation of the grid-template shorthand tries 
first to match the <grid-template-columns> / <grid-template-rows> 
syntax, failing back to the secondary syntax if needed. 
This approach requires to rewind the parseList but it 
produces a clearer code.
 
TEST=fast/css-grid-layout/grid-template-shorthand-get-set.html

BUG=79180

Review URL: https://codereview.chromium.org/149373004

git-svn-id: svn://svn.chromium.org/blink/trunk@170552 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This matches Firefox's behavior (see [1]). Hooray for interoperation!

Intent to Ship thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/rCiwMvGG8IY/MgRtHrkQfgMJ

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=979580

Review URL: https://codereview.chromium.org/220343005

git-svn-id: svn://svn.chromium.org/blink/trunk@170551 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[Oilpan]: Move CSSPropertySourceData, InspectorStyleProperty, CSSStyleSourceData, and CSSRuleSourceData to the oilpan heap using transition types.

Also removed unsused emptyCSSPropertySourceData (adding apavlov as reviewer to verify).

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=341815

Review URL: https://codereview.chromium.org/216553004

git-svn-id: svn://svn.chromium.org/blink/trunk@170550 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This adds the console message APIs to WebFrameClient.

BUG=304341

Review URL: https://codereview.chromium.org/217283004

git-svn-id: svn://svn.chromium.org/blink/trunk@170549 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This adds a timeline mode for recording a trace and a very basic trace
viewer based on FlameChart.

BUG=

Review URL: https://codereview.chromium.org/212683005

git-svn-id: svn://svn.chromium.org/blink/trunk@170548 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Implements perspective-origin as defined in CSS Transforms[1]. Behavior is
similar to -webkit-perspective-origin, however perspective-origin is not a 
shorthand. New parsing and serialization (mostly matching Gecko) has been 
introduced.

The animation system is modified to avoid running animations and 
transitions on both the prefixed and unprefixed variants at the same 
time. Internally, animations are mapped to the unprefixed variant. 
As animations operate directly on the RenderStyle storage the result 
of specifying an animation on either -webkit-perspective-origin
or perspective-origin is the same.

However, support for independent animation/transition of 
-webkit-perspective-origin-* is removed. The X and Y coordinates now
always transition together.

Note, this property and changes in behavior are guarded by the
CSSTransformsUnprefixed runtime feature (enabled only for testing).

[1] http://www.w3.org/TR/css3-transforms/

BUG=154772

Review URL: https://codereview.chromium.org/212673002

git-svn-id: svn://svn.chromium.org/blink/trunk@170547 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now that https://src.chromium.org/viewvc/chrome?view=rev&revision=260247
and https://src.chromium.org/viewvc/chrome?view=rev&revision=260719
have landed, this change removes the temporary failure expectations
related to changes in Chromium behavior added for bug 351166 in
https://src.chromium.org/viewvc/blink?view=rev&revision=170209 and for
bug 249422 in
https://src.chromium.org/viewvc/blink?view=rev&revision=170398.

TBR=acolwell@chromium.org
BUG=249422,351166
TEST=All MSE layout tests pass locally on Linux

Review URL: https://codereview.chromium.org/220473006

git-svn-id: svn://svn.chromium.org/blink/trunk@170546 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=dstockwell@chromium.org, haraken@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/220663003

git-svn-id: svn://svn.chromium.org/blink/trunk@170545 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Re-land Blink r158626.

Initial patch is from WebKit r155571 by Anders Carlsson <andersca@apple.com>

Allow rehashing to track a hash bucket and return the new pointer
to it, thus avoiding having to do a copy of a hash table bucket as
well as an extra hash lookup.

The patch had been reverted because of a layout test crash
on ASAN build: http://code.google.com/p/chromium/issues/detail?id=310975

The actual crash root cause is fixed now with r170150, so the patch can be re-landed.

Review URL: https://codereview.chromium.org/203413003

git-svn-id: svn://svn.chromium.org/blink/trunk@170544 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Protect EventListener from being deleted before it is passed into InspectorInstrumentation::didRemoveEventListener

BUG=358467

Review URL: https://codereview.chromium.org/220693002

git-svn-id: svn://svn.chromium.org/blink/trunk@170543 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Speeds up blink compilation ~ 1.5%

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170466

Review URL: https://codereview.chromium.org/218583007

git-svn-id: svn://svn.chromium.org/blink/trunk@170542 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=dstockwell@chromium.org, haraken@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/220833002

git-svn-id: svn://svn.chromium.org/blink/trunk@170540 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Accessing the hash table in every ::detach call is a lot of overhead since
in the common case the Element is not even in the hash table. We should
check the needsStyleInvalidation() bit first.

Review URL: https://codereview.chromium.org/217423012

git-svn-id: svn://svn.chromium.org/blink/trunk@170539 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Instead of falling back to full subtree recalcs for invalidation sets
affected by custom pseudo elements, use a flag in the invalidation set
saying that custom pseudo elements need to be invalidated. Can be extended
to invalidate specific custom pseudo element types, but it will probably not
be necessary.

The reason for optimizing this in the first place is to make it possible to
use invalidation sets for :hover/:active/:focus changes where descendants
are affected by changes to those states. The UA stylesheet contains
selectors for :hover/:active/:focus where such state changes affect
descendants and the rightmost compound selector has a custom pseudo element
as its only sub-selector.

R=esprehn@chromium.org
BUG=351613

Review URL: https://codereview.chromium.org/219193004

git-svn-id: svn://svn.chromium.org/blink/trunk@170538 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Implements transform-origin as defined in CSS Transforms[1]. Behavior is
similar to -webkit-transform-origin, however transform-origin is not a 
shorthand. New parsing and serialization (mostly matching Gecko) has been 
introduced.

The animation system is modified to avoid running animations and 
transitions on both the prefixed and unprefixed variants at the same 
time. Internally, animations are mapped to the unprefixed variant. 
As animations operate directly on the RenderStyle storage the result 
of specifying an animation on either -webkit-transform-origin
or transform-origin is the same.

However, support for independent animation/transition of 
-webkit-transform-origin-* is removed. The X, Y and Z coordinates now
always transition together.

Note, this property and changes in behavior are guarded by the
CSSTransformsUnprefixed runtime feature (enabled only for testing).

[1] http://www.w3.org/TR/css3-transforms/

BUG=154772

Review URL: https://codereview.chromium.org/212483003

git-svn-id: svn://svn.chromium.org/blink/trunk@170537 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- We want to use DatabaseTaskSynchronizer in the HTML parser thread in a follow-up CL. In preparation for that, this CL renames DatabaseTaskSynchronizer to TaskSynchronizer and moves it to platform/.

BUG=340522
R=ager@chromium.org, tkent@chromium.org, wibling@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170532

Review URL: https://codereview.chromium.org/198673002

git-svn-id: svn://svn.chromium.org/blink/trunk@170536 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The parameter to didActivateCompositor() is meaningless. Hence, removed it. The other chromium side changes are here
https://codereview.chromium.org/137893025/

BUG=None

Review URL: https://codereview.chromium.org/138523003

git-svn-id: svn://svn.chromium.org/blink/trunk@170535 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I miscommitted r170532 with unnecessary changes.
(r170532 was a sum of https://codereview.chromium.org/198673002 and https://codereview.chromium.org/216203006/,
but I should land only https://codereview.chromium.org/198673002.)
I'll reland those CLs separately.

> Rename DatabaseTaskSynchronizer to TaskSynchronizer and move it to platform/
> 
> - We want to use DatabaseTaskSynchronizer in the HTML parser thread in a follow-up CL. In preparation for that, this CL renames DatabaseTaskSynchronizer to TaskSynchronizer and moves it to platform/.
> 
> BUG=340522
> R=ager@chromium.org, tkent@chromium.org, wibling@chromium.org
> 
> Review URL: https://codereview.chromium.org/198673002

TBR=haraken@chromium.org

Review URL: https://codereview.chromium.org/213673004

git-svn-id: svn://svn.chromium.org/blink/trunk@170534 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=354445

Review URL: https://codereview.chromium.org/206503004

git-svn-id: svn://svn.chromium.org/blink/trunk@170533 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- We want to use DatabaseTaskSynchronizer in the HTML parser thread in a follow-up CL. In preparation for that, this CL renames DatabaseTaskSynchronizer to TaskSynchronizer and moves it to platform/.

BUG=340522
R=ager@chromium.org, tkent@chromium.org, wibling@chromium.org

Review URL: https://codereview.chromium.org/198673002

git-svn-id: svn://svn.chromium.org/blink/trunk@170532 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL just copies a file just to make the diff of
https://codereview.chromium.org/198673002/ saner.

TBR=tkent
NOTRY=true

Review URL: https://codereview.chromium.org/220703002

git-svn-id: svn://svn.chromium.org/blink/trunk@170531 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I was looking at how to port the BisonCSSParser and CSSParserObserver to the oilpan (GC) heap and noticed that we had a pointer from the BisonCSSParser back to the stack allocated CSSParserObserver/StyleSheetHandler. While it worked correctly making the BisonCSSParser stack allocated will IMO simplify the lifetime reasoning and make it less likely that we introduce errors.
This comes at the "expense" of always allocating a comment parser in the StyleSheetHandler. It is only used in the Inspector code so I am hoping that is okay.

R=ager@chromium.org, erik.corry@gmail.com, eseidel@chromium.org, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/216433003

git-svn-id: svn://svn.chromium.org/blink/trunk@170530 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none

Review URL: https://codereview.chromium.org/211093005

git-svn-id: svn://svn.chromium.org/blink/trunk@170529 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=vegorov@chromium.org
BUG=356118

Review URL: https://codereview.chromium.org/218683007

git-svn-id: svn://svn.chromium.org/blink/trunk@170528 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Implements transform as defined in CSS Transforms[1]. Behavior is similar
to -webkit-transform, but the perspective() function is not allowed to
contain numbers without units. Like -webkit-transform and other user
agents, the resolved value of transform is not the computed value as 
currently defined by css-transitions[2]. 

The animation system is modified to avoid running animations and 
transitions on both the prefixed and unprefixed variants at the same 
time. Internally, animations are mapped to the unprefixed variant. 
As animations operate directly on the RenderStyle storage the result 
of specifying an animation/transition on either property is the same. 

Note, this property is guarded by the CSSTransformsUnprefixed runtime 
feature (enabled only for testing). 

[1] http://www.w3.org/TR/css3-transforms/
[2] http://lists.w3.org/Archives/Public/www-style/2013Dec/0317.html 

BUG=154772

Review URL: https://codereview.chromium.org/212543003

git-svn-id: svn://svn.chromium.org/blink/trunk@170527 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We missed the compile assert in the VectorDestructor's clear method when having vectors where elements were only added.
This should fix that. It also caught a few places where we had to define a new trait.

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/219243003

git-svn-id: svn://svn.chromium.org/blink/trunk@170526 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This avoids a "deprecated directive, use ‘%pure-parser’ [-Wdeprecated]"
warning in css/CSSGrammar.y and xml/XPathGrammar.y when building with
Bison 3.

Review URL: https://codereview.chromium.org/217423011

git-svn-id: svn://svn.chromium.org/blink/trunk@170525 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The method's behavior is very similar to element.scrollIntoView().
This is just a another version about path on canvas.
('path' means both current default path and path object)
This is especially useful on devices with small screens,
where the whole canvas might not be visible at once.

Intent to Implement:
  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/KLFSBeP42VQ

The spec reference is:
  http://www.w3.org/TR/2dcontext/#dom-context-2d-scrollpathintoview
  http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-scrollpathintoview

BUG=351696

Review URL: https://codereview.chromium.org/196243007

git-svn-id: svn://svn.chromium.org/blink/trunk@170524 bbb929c8-8fbe-4397-9dbb-9b2b20218538