- 03 Jun, 2019 40 commits
-
-
Rohan Pavone authored
Handles promises according to W3C-spec (https://w3c.github.io/webdriver/#execute-async-script) for asynchronous user scripts. This removes the global "result" object that contains results of the latest script to execute and allows for scripts to wait until results are ready before returning (instead of polling for results after the script completes). run_py_tests.py. Tested: WPTs webdriver/test/execute_async_script, and python Bug: chromedriver:2398 Change-Id: I9f6cdeb5b3e93fcfd3e63090ce8b3aed275d71be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636627 Commit-Queue: Rohan Pavone <rohpavone@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#665589}
-
Steve Kobes authored
This avoids spurious layout shift reports when a static-positioned element loses its PaintLayer and cc::Layer at the same time (a common scenario at the end of a transition animation). Bug: 960614 Change-Id: I0ab8b693dbb764880090d1b078cb138f4ca1ddb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636403 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#665588}
-
Paul Miller authored
BUG=968636 Change-Id: Ic838ed2cbb1c0725cc7c579c10c77e7a5323428e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639106 Commit-Queue: Paul Miller <paulmiller@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#665587}
-
Owen Min authored
The scheduler will 1) Check browser status to decide if cloud reporting can be enabled. 2) Listen for the policy changes. 3) Schedule next report with a timer. 4) Update lastUploadTimestamp in local_state. Bug: 956237 Change-Id: I18dc5bd763417980053a9c63857a66dab062ea54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623459 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#665586}
-
David Tseng authored
On trunk, we currently fire (infer) a focus event when the focused node changes. For events originating from Blink, it is not reliable to infer focus events because |event_from| cannot be properly associated with the generated or inferred event or even the set of node updates. This issue only comes up when repeated accessibility actions are performed, quickly. The change will fix firing of some focus events that contain the wrong event from value. The user visible change is that ChromeVox will not sync focus (thinking it is not a focus triggered from its own action). Change-Id: I9926e1d0a03f8a70011c7d38d709eb1c77baee26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640141 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#665585}
-
James Hawkins authored
Likely fixes crashes during shutdown seen in Smart Lock. R=hansberry@chromium.org Bug: 969142 Fixes: 969142 Test: none Change-Id: I9c55e5995c27c2a93005e549a98b319f056123a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639320 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#665584}
-
Sinan Sahin authored
Bug: 958414 Change-Id: I5fe989239f165cc5a8ce28f8e1fb6e11f18b04e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604423 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#665583}
-
chrome://proximity-authJosh Nohle authored
This fixes segfaults that occur on the chrome://proximity-auth page when there is no local device metadata. This can happen if a successful DeviceSync hasn't completed yet. Bug: 945991 Change-Id: I9d767e6e26982360d685faba6126720787624951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640368 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#665582}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6e80eaeb0400..062420146dfd git log 6e80eaeb0400..062420146dfd --date=short --no-merges --format='%ad %ae %s' 2019-06-03 dburger@chromium.org Add grunt-unittest-only-postsubmit ignored in config skew check Created with: gclient setdep -r src/third_party/chromite@062420146dfd The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Ic493b61bbe9fa491dd8d1b759d187cc35707d0d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641214Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665581}
-
Marc Treib authored
With this change, pseudo-USS types will continue tracking metadata when Sync is stopped temporarily (i.e. SyncStopDataFate::KEEP_DATA). This brings pseudo-USS a bit closer to real USS, and it will allow us to actually shut down Sync when we're in the "Sync paused" state. Bug: 906995 Change-Id: I92fe4b6c6aab2c99eb2c7335aea18325b9b98d4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538285 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#665580}
-
Kurt Horimoto authored
This test is failing on iPad for the slim nav bot. TBR=eugenebut@chromium.org NOTRY=true Bug: 968296 Change-Id: I231bf42f8c8fa3aa2f1bf3195e31f9b69a085543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639086 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#665579}
-
Jenna Himawan authored
Bug: 949001 Change-Id: I99209797e6a6a2d70e60828034d66776f20a5c30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640780Reviewed-by:
-
Evan Stade authored
ShowErrorMessage and ClearErrors are deleted, as they've remained unimplemented for over a year. SetShowGuestButtonInOobe and SetShowParentAccessButton are renamed and moved to LoginScreen. SetShowParentAccessDialog is removed as part of the public API since it is never called from Chrome. TBR=tsepez@chromium.org Bug: 958206 Change-Id: Ibde235d3dd1013a33855874247231613d0fd4da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639459Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#665577}
-
Dan Sinclair authored
There is a dependency between these two, roll together. TBR=dneto@google.com Change-Id: Ibfe6c66eba3d56f7b887f01f71814f81ba31e6e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639843Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#665576}
-
Alexander Timin authored
All interfaces should use scoped_refptr<SequencedTaskRunner> for passing refcounted objects, which includes the task runners. This is due to the fact that the embedder should be able to return the only reference to the object and should not be forced to keep it alive. R=clamy@chromium.org,gab@chromium.org TBR=ddorwin@chromium.org BUG=937336 Change-Id: I61a7b3c6e97b3c1ede4a2b462a2204d5437d1ed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634866Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#665575}
-
Rune Lillesveen authored
This changed in [1]. However, there are pseudo elements which do not have corresponding PseudoElements. Change DCHECK documentation accordingly. [1] https://crrev.com/90351b8f23ad3c9195d54e741747a85d95755987 Change-Id: Ib88155e8a846d790367704207f7bc796863bce77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640638 Auto-Submit: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#665574}
-
Alexander Timin authored
No good deed goes unpunished. R=carlscab@google.com CC=alexclarke@chromium.org,skyostil@chromium.org Change-Id: Iad8e017028a58ef128d637069e2972b9b07527f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640405Reviewed-by:
Carlos Caballero <carlscab@google.com> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#665573}
-
Mugdha Lakhani authored
Limit access to Periodic Sync on Android as follows: 1. If a TWA is installed for the origin that's requesting access to the API, then grant permission. 2. If a PWA is installed for the origin that's requesting access to the API, then grant permission iff the Background Sync site setting has been granted for that origin. Bug: 925297 Change-Id: I4b6cd9c37f303f3e8dd0db7f593b8a523ae374f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619807 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#665572}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1df841d446eb..d2a6686a1066 git log 1df841d446eb..d2a6686a1066 --date=short --no-merges --format='%ad %ae %s' 2019-06-03 chxg@google.com Add RtpPacketInfo to hold information about a received RtpPacket. Created with: gclient setdep -r src/third_party/webrtc@d2a6686a1066 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If80bd4a6a579a1ccb96c7c22904426e8cd7a63e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641215Reviewed-by:
-
Hongchan Choi authored
AudioCallbackMetricReport does: - Calculate the expected platform callback interval. - Calculate the running callback interval. - Calculate the weighted mean/variance (smoothed) of callback interval. In all, this will help developers see the quality of audio callback for Web Audio API renderer via DevTools. Bug: 966930 Change-Id: I3eef0c95ea7bff067b2cb2ddba79cf6f9f95a00e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629179 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#665570}
-
Shu Chen authored
This is a reland of 6700540d The Windows Dbg bot failure should have been fixed by the cl: http://crrev.com/c/1635772. Original change's description: > Reland "Removes ui/platform_window/mojo as it is not used by anyone." > > This is a reland of 6eb61402 > > Original change's description: > > Removes ui/platform_window/mojo as it is not used by anyone. > > > > This is to remove the ref to some types under ui/base/ime/mojo, which will be removed later. > > > > Bug: 965908 > > Change-Id: I7979524066104c829b4f4e287a0ab87c9365f124 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626055 > > Reviewed-by: Dominick Ng <dominickn@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Commit-Queue: Shu Chen <shuchen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#662924} > > Bug: 965908 > Change-Id: I6bb1c6d081ce235c959cc30e53d20b57dd0e1459 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626841 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Shu Chen <shuchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#663381} Bug: 965908 Change-Id: Ibfed1d3a64c45c5ba64bbd5f97313f5decc50bc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630787 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#665569}
-
Lan Wei authored
In order to run the web-platform-tests automatically, we will use testdriver Action API in all the wpt to simulate inputs. Here we are changing one pointerevent input test which has "touch-action: none" on the table's row and cell, which tests that touch-action does not apply to table rows, row groups, table columns, and column groups. This is the ninth CL that changes part of the pointerevent input tests. Bug: 606367 Change-Id: Ie3b1d4a192c5c538f0de4c60ab5c9c492185d561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639080 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#665568}
-
Christopher Grant authored
The APK merger script originally composed a combined APK from pure 32- and 64-bit versions, but it doesn't do that anymore. Today, its job is simply to make the 32-bit portions consistent between a pure 32-bit build and a multi-arch 64-bit build that includes 32-bit. Based on this, we can simplify the script by: - Not specifying any native library names as script arguments. We'll see which libs are in the 32-bit version, and simply copy them all over. This makes handling feature-specific libraries much easier. - Combining the notion of "expected" merge files and "exclude from 64-bit" files. These are the same concept, and don't need to be separate lists. - Centralizing control of uncompressed native libraries. There is no need to track compression needs on a per-file basis. Bug: 962477 Change-Id: If3bcc8379508a1f7407a890fa042f8fd3ab27320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634388Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#665567}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f345bb32. With Chromium commits locally applied on WPT: e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" abf2ac5e "webrtc wpt: avoid race conditions" 1bbbd106 "Add feature policy for client hints, used for third-party subresources." ab94a58b "Add the remaining Client Hints to Feature Policy." 3285c7d5 "Reland "Reland "Adding support to bitmaprenderer in OffscreenCanvas""" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I0ea63f84748d3341021dff6bf161d0d861f5b974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640153Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665566}
-
Katharine Daly authored
Bug: 969229, 878582 Change-Id: I01dfb6f85bb4dca20bfa62f79fcfaec9c9039e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639242 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#665565}
-
Austin Eng authored
Bug: dawn:7 Change-Id: I54979b37d1277a716a55d08120bcc9e42574c1c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637193 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#665564}
-
Patrick Meenan authored
Lower the priority of late-body stylesheets to match late-body blocking scripts (to Medium from VeryHigh). Now that in-body stylesheets no longer block render they should be loaded like late-body scripts. This will prevent them from being considered "render blocking" for loading from the network perspective and will cause them to load in-order with scripts (which is the desired behavior). Bug: 945841 Change-Id: Ib3578d0b900ef25080f2340ff0fd133e0e8117c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638900Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Patrick Meenan <pmeenan@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Patrick Meenan <pmeenan@chromium.org> Cr-Commit-Position: refs/heads/master@{#665563}
-
Nico Weber authored
No behavior change. Bug: none Change-Id: Icd4a8f7cfece1cb1d07902adda3e78ad872c84d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639153 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#665562}
-
Aga Wronska authored
Shelf should not be visible on Kiosk Next home screen. Starting drag gesture during transition to home screen can cause shelf remaining stuck and visible. To prevent that cancel drag gesture when home screen animation is finished. Bug: 968635 Change-Id: I89cfaebbfc9eed0e8ef916b382fdb88f470399f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638917 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
-
Anton Bikineev authored
Bug: 968707, 967258 Change-Id: Ib84a62f3484e0444d555d48c5f8fa5b28fc47389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638528Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Sebastien Marchand authored
The cache is the equivalent of the LocalSiteCharacteristicsDataStore, there'll be one per profile. Bug: 961336 Change-Id: I1c55ac7283dea6e20ea853025c64c801fe9e9740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627661 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#665559}
-
kylechar authored
Remove some usage of deprecated callback types in ui/ozone/*. Where possible convert to the corresponding once type, otherwise replace with the repeating type. Also update PRESUBMIT so that deprecated callback types are banned in ui/ozone/*. Bug: 714018 Change-Id: Ida5c8c028435a220344981d09e508f3e0dd711b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637399 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#665558}
-
Stephane Zermatten authored
happen. Before this change, ConfigureBottomSheetAction would return immediately after asking for the viewport to be resized. Depending on how quickly that happened, a Focus action following ConfigureBottomSheetAction might see the window height before the resize and not be able to focus. The current workaround for that is to wait after resizing the viewport before focusing on an element, but the time it takes varies a lot. With this change, ConfigureBottomSheetAction waits until the viewport resize has been seen from the Javascript side, so we don't wait longer than strictly necessary. A maximum wait time avoids scripts getting stuck in this action. Bug: b/133665079 Change-Id: Ia37076710634542bb4f15c77f30275c234383cb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640408 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#665557}
-
Colin Blundell authored
DeviceOAuth2TokenServiceDelegate currently overrides OAuth2TokenServiceDelegate::RefreshTokenIsAvailable() but doesn't override OAuth2TokenServiceDelegate::GetAccounts(). The latter has a default implementation that returns an empty set of accounts. We have a goal of implementing OAuth2TokenService::RefreshTokenIsAvailable() on top of OAuth2TokenService::GetAccounts() as a means of enforcing semantic invariants around the relationship between these two methods (see bug for details). As a step toward enabling this enforcement, this CL changes DeviceOAuth2TokenServiceDelegate to implement GetAccounts() and implement RefreshTokenIsAvailable() in terms of GetAccounts(). As O2TSDelegate::RefreshTokenIsAvailable() is marked const but O2TSDelegate::GetAccounts() is not, this requires a bit of tap-dancing in the implementation. This tap-dancing will go away in the followup, which will change OAuth2TokenService to implement RefreshTokenIsAvailable() directly rather than via the delegates. This CL should have no behavioral impact, as an analysis done for separate reasons showed that GetAccounts() is never invoked on DeviceOAuth2TokenService: https://docs.google.com/document/d/1IeaTv_BQZfpYDgEeenozB-8W65vW2cpZsTeADeXt8RU/edit#heading=h.pukrhlvsi449 Bug: 919793 Change-Id: I628fbc6eded0fee8b460006a746b59ceeecac4ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640978Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/eca66b32fdb9..fec9b902a626 git log eca66b32fdb9..fec9b902a626 --date=short --no-merges --format='%ad %ae %s' 2019-06-03 mtklein@google.com add unit scaling mode to benchmark/nanobench 2019-06-03 borenet@google.com [infra] Stop isolating the Android NDK 2019-06-03 jcgregorio@google.com Add 'modules' to doxygen generation. 2019-06-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). 2019-06-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 0a56f0e3d22d..98f2167125a8 (8 commits) 2019-06-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader c0d7ee45d45f..bb575d48d5f9 (3 commits) 2019-06-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 8e522297..f75363e4 (402 commits) Created with: gclient setdep -r src/third_party/skia@fec9b902a626 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Change-Id: Ie75fc529cdc951b659d9c9b7f6f11e018fccb865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641210Reviewed-by:
-
Ella Ge authored
When mouse events are captured, we use the capturing element instead of doing hit test. The local_point is computed by AbsoluteToLocalPoint, but we didn't apply transfroms. This is wrong and causes selection incorrect when there is transform. This CL removes the incorrect kIgnoreTransforms. Bug: 969695 Change-Id: Icfcaf627f58999f037b793feeb3fe712a827ca8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634719 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#665554}
-
Scott Violet authored
This code was necessary to avoid forcing a remote client to be visible until occlusion tracking was enabled. Now that mash is no more, there are no remote clients and this can be removed. BUG=961763 TEST=none Change-Id: I05d9603b82a14a1b394287540747e6b84269cb28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635292 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#665553}
-
Ryan Sturm authored
Change-Id: I4830739df4bf4458d9299cc9cc860f69bb4553c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636571Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#665552}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=sdefresne@chromium.org Change-Id: I6981ec15a6730394d64090021a8c58ce88f7ec3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636191Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#665551}
-
Henrique Ferreiro authored
This is a step in eliminating the inheritance relationship between SigninManager and SigninManagerBase, as motivated in this design doc: https://docs.google.com/document/d/15y-Db27BV08vrIyelHB-3CwiAfDYh-FigNKGXrqSWto/edit#heading=h.8jjdy95t6p7x and described concretely here: https://docs.google.com/document/d/15y-Db27BV08vrIyelHB-3CwiAfDYh-FigNKGXrqSWto/edit#heading=h.mbkrv9nkb93w The functionality is ifdef-d out on ChromeOS, as it is currently not used on that platform. However, in the near term we will enable it on ChromeOS as part of unifying the flow of setting the primary account between ChromeOS and desktop. Bug: 952766 Change-Id: I4b408b0a9ead28367ef07fb06f7950609be4b369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565315 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#665550}
-
