GitLab

BUG=None

Review URL: https://codereview.chromium.org/417503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285066 0039d316-1c4b-4281-b951-d872f2087c98

chrome.logPrivate.dumpLogs(function(fileEntry) {...});
  
- dumps all system logs as |fileEntry| (a .tgz file)


chrome.logPrivate.startEventRecorder(type, function(){});
chrome.logPrivate.stopEventRecorder(type, function(){});

- start/stop additional log collection for dumps generated with chrome.logPrivate.dumpLogs(). 

TEST=LogPrivateApiTest.*
BUG=385289

Review URL: https://codereview.chromium.org/329853010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285065 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396752
R=estade@chromium.org

Review URL: https://codereview.chromium.org/414753004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285064 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395430
NOTRY=True

Review URL: https://codereview.chromium.org/406933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285056 0039d316-1c4b-4281-b951-d872f2087c98

Comment the breakpad gyp file.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/413863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285055 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285054 0039d316-1c4b-4281-b951-d872f2087c98

This gets the "no chromium code" flag for the GN build.

R=dalecurtis@chromium.org
TBR=dalecurtis

Review URL: https://codereview.chromium.org/417783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285053 0039d316-1c4b-4281-b951-d872f2087c98

As explained in the long comment in ninja_copy_target_writer.cc, writing implicit deps for the copy command is both unnecessary and causes problems given the way Chrome specifies the command.

This also updates the expectations for the binary output given the new variables added in a previous patch (this test isn't being run on the bot yet).

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/418573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285052 0039d316-1c4b-4281-b951-d872f2087c98

Many win32 APIs take non-const string pointers. I checked that MSDN documents
them as _In_ and says that they are inputs, and then added const_cast<>s at
the calling sites. (In one test, I introduced a helper struct so that there
can be fewer casts.)

This wasn't just busywork, I found one function that we were handing string
literals where the documentation explicitly said that that's not valid
(filed http://crbug.com/396705).

I didn't change the DECLARE_REGISTRY_APPID_RESOURCEID() call in cloud_print;
it sounds like that'll fix itself when we update to the 2014 sdk:
http://connect.microsoft.com/VisualStudio/feedback/details/806376/atl-hindrances-to-adopting-new-strictstrings-conformance-option-in-vs2013

BUG=396705,82385
R=rnk@chromium.org, rsleevi@chromium.org, sergeyu@chromium.org, vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/413763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285051 0039d316-1c4b-4281-b951-d872f2087c98

See [1].

[1] http://developer.android.com/reference/android/hardware/Camera.html#setParameters(android.hardware.Camera.Parameters)

BUG=b/16370110

Review URL: https://codereview.chromium.org/400933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285050 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391473
TEST=Follow a link from Gmail or hold shift when clicking a link. A new activity following the link is created.

Review URL: https://codereview.chromium.org/398603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285049 0039d316-1c4b-4281-b951-d872f2087c98

Paste popup should be hidden from the corresponding
input box whenever there is a change in focus.This
change takes care of hiding the paste popup when
focus is changing from edit field to URL bar.

BUG=396620

Review URL: https://codereview.chromium.org/416493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285047 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372607

Review URL: https://codereview.chromium.org/408493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285045 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396184
NOTRY=true

Review URL: https://codereview.chromium.org/410703003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285043 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scottmg

Review URL: https://codereview.chromium.org/415743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285042 0039d316-1c4b-4281-b951-d872f2087c98

The Linux hidraw interface expects the buffer written to the device to
always have the report ID as the first byte. Remove the conditional that
only added this data when the report ID was non-zero.

BUG=
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/411463005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285041 0039d316-1c4b-4281-b951-d872f2087c98

Destroying an Aura window generates a synthetic mouse move event if the mouse
is inside the window.  This causes the InputRouter to get stuck in a state
where it is waiting for the renderer to ack the mouse move.

BUG=395737
R=sky@chromium.org

Review URL: https://codereview.chromium.org/405253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285040 0039d316-1c4b-4281-b951-d872f2087c98

These cards either do not support D3D11 fully, or interact with an
unknown ANGLE bug to cause black screens and an unusable browser.
Force off D3D11 until we can diagnose if a fix is possible.

BUG=395861

Review URL: https://codereview.chromium.org/409223004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285039 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds const versions of operator* for layer iterators, so
that we can use them for sorting/heapifying the iterators.

R=reveman

Review URL: https://codereview.chromium.org/413603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285038 0039d316-1c4b-4281-b951-d872f2087c98

This method is never called from Blink ("web components" are always enabled).

Review URL: https://codereview.chromium.org/408053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285037 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=keybuk@chromium.org
TBR=keybuk@chromium.org

Review URL: https://codereview.chromium.org/401953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285036 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285031 0039d316-1c4b-4281-b951-d872f2087c98

R=nick@chromium.org
TBR=brettw@chromium.org,nick@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/371313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285030 0039d316-1c4b-4281-b951-d872f2087c98

In addition to a developer-readable string for inline install failures, include
a stable error code. This isn't perfect, since a) the function prototype of
function(error, errorCode) isn't great, and b) we kind of lose track of what
went wrong after a certain point in the install process. Unfortunately, to fix
a) requires either a breaking change or a revamp to our whole error reporting,
and fixing b) requires stable error values at every point in our install
process (which we don't have, and won't anytime soon).

BUG=331887
TBR=benwells@chromium.org (app_list)
TBR=yoshiki@chromium.org (file_manager)

TBRs for trivial, no-functionality changes.

Review URL: https://codereview.chromium.org/384823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285029 0039d316-1c4b-4281-b951-d872f2087c98

This change puts nexe information in the parameters for starting a NaCl
plugin instead of sending that information over SRPC. This may remove the
need for that IPC round trip entirely; perhaps we could report load failure
as part of the RPCs for starting sel_ldr or performing StartModule().

nacl_defines.gypi as added as a dependency in components/components_tests.gyp
because nacl_process_host.h now includes
"native_client/src/public/nacl_file_info.h", which requires nacl_defines.

BUG=333950
R=bbudge@chromium.org, brettw@chromium.org, hidehiko@chromium.org, jschuh@chromium.org, mseaborn@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/332463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285028 0039d316-1c4b-4281-b951-d872f2087c98

Fix libxml clang warnings.

Add ppapi_unittest_shared target.

Rename ipc:test_support_ipc to ipc:test_support and use this target when needed (the places that wanted this incorrectly specified only "ipc".

R=hclam@chromium.org

Review URL: https://codereview.chromium.org/418453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285027 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396385
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/406143003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285025 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/409793007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285024 0039d316-1c4b-4281-b951-d872f2087c98

BUG=328119

Review URL: https://codereview.chromium.org/401723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285023 0039d316-1c4b-4281-b951-d872f2087c98

Check in perf-to-tracing conversion script. This lets the --perf command
line switch actually produce trace files that can be loaded by Trace
Viewer.

The conversion script was originally written by Victor Miura
<vmiura@chromium.org> in https://codereview.chromium.org/296623002/.

TEST=PerfControllerTest
BUG=375754

Review URL: https://codereview.chromium.org/404543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285022 0039d316-1c4b-4281-b951-d872f2087c98

In a previous change, an improved test subclass of
GetAuthTokenFunction was created for multi-login tests. All
chrome.identity.getAuthToken browser tests now use this class, and the
original test class has been removed.

The new class does not have any mock methods since the originals were
not testing anything interesting anyway, and does not need to be a
friend of its base class.

This change also adds some coverage for error cases in getAuthToken,
for requests specifying a non-primary account ID.

BUG=364203

Review URL: https://codereview.chromium.org/410553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285020 0039d316-1c4b-4281-b951-d872f2087c98

Getting the value is fine and fast, but returning a reference has the
advantage of allowing you to pass &handle.value() to anything taking a
|const MojoHandle*| (without needing to save to a temporary variable).

R=sky@chromium.org

Review URL: https://codereview.chromium.org/417583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285019 0039d316-1c4b-4281-b951-d872f2087c98

This is a rare codepath used only by Chrome Frame uninstalls. It's rare
that it will be hit now, but leave correct code in place until the great
installer GCF cleanup rather than remove this one small piece now.

BUG=NONE
R=gab@chromium.org

Review URL: https://codereview.chromium.org/410923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285017 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285016 0039d316-1c4b-4281-b951-d872f2087c98

broke win64 build:

FAILED: C:\b\depot_tools\python276_bin\python.exe gyp-win-tool action-wrapper environment.x64 aot_target_build_newlib_x86_32_nonsfi_nlib__via_pnacl__363af64d0619df24e45ee3bc5549531a..rsp ..\..\ppapi\native_client\src\untrusted\pnacl_irt_shim
error: unable to open output file '../../../../../out/Debug_x64/obj/ppapi/native_client/src/untrusted/pnacl_irt_shim/aot.gen/pnacl_newlib_x86_32-nonsfi/aot/irt_shim_ppapi.o---irt_shim_ppapi.c---.po': 'Error opening output file '../../../../../out/Debug_x64/obj/ppapi/native_client/src/untrusted/pnacl_irt_shim/aot.gen/pnacl_newlib_x86_32-nonsfi/aot/irt_shim_ppapi.o---irt_shim_ppapi.c---.po': The system cannot find the path specified'
1 error generated.
..\..\..\..\..\out\Debug_x64\gen\sdk\win_x86\pnacl_newlib\bin\pnacl-clang -c irt_shim_ppapi.c -o ../../../../../out/Debug_x64/obj/ppapi/native_client/src/untrusted/pnacl_irt_shim/aot.gen/pnacl_newlib_x86_32-nonsfi/aot/irt_shim_ppapi.o -MD -MF ../../../../../out/Debug_x64/obj/ppapi/native_client/src/untrusted/pnacl_irt_shim/aot.gen/pnacl_newlib_x86_32-nonsfi/aot/irt_shim_ppapi.o.d --target=i686-unknown-nacl --pnacl-allow-native --pnacl-allow-translate -arch x86-32-nonsfi -O2 -g -Wall -fdiagnostics-show-option -Werror -DPNACL_SHIM_AOT -Wno-unused-function -Wno-char-subscripts -Wno-c++11-extensions -Wno-unnamed-type-template-args -Wno-extra-semi -Wno-unused-private-field -Wno-char-subscripts -Wno-unused-function -D__linux__ -D__STDC_LIMIT_MACROS=1 -D__STDC_FORMAT_MACROS=1 -D_GNU_SOURCE=1 -D_BSD_SOURCE=1 -D_POSIX_C_SOURCE=199506 -D_XOPEN_SOURCE=600 -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DDYNAMIC_ANNOTATIONS_PREFIX=NACL_ -DNACL_BUILD_ARCH=x86 -DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -DNOMINMAX -DPSAPI_VERSION=1 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -D_ATL_NO_OPENGL -D_SECURE_ATL -DCHROMIUM_BUILD -DTOOLKIT_VIEWS=1 -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DNO_TCMALLOC -DENABLE_EGLIMAGE=1 -D__STD_C -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -DNTDDI_VERSION=0x06020000 -D_USING_V110_SDK71_ -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static -DCLD_DATA_FROM_STATIC -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DWIN_PDF_METAFILE_FOR_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_WIFI_BOOTSTRAPPING=1 -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_NONSTDC_NO_DEPRECATE -DNACL_WINDOWS=0 -DNACL_OSX=0 -DNACL_LINUX=0 -DNACL_ANDROID=0 -I../../../../../out/Debug_x64/gen/tc_pnacl_newlib/include -I../../../../.. -I../../../../../out/Debug_x64/gen -I../../../../../third_party/wtl/include -std=gnu99

FAILED: Command '..\..\..\..\..\out\Debug_x64\gen\sdk\win_x86\pnacl_newlib\bin\pnacl-clang -c irt_shim_ppapi.c -o ../../../../../out/Debug_x64/obj/ppapi/native_client/src/untrusted/pnacl_irt_shim/aot.gen/pnacl_newlib_x86_32-nonsfi/aot/irt_shim_ppapi.o -MD -MF ../../../../../out/Debug_x64/obj/ppapi/native_client/src/untrusted/pnacl_irt_shim/aot.gen/pnacl_newlib_x86_32-nonsfi/aot/irt_shim_ppapi.o.d --target=i686-unknown-nacl --pnacl-allow-native --pnacl-allow-translate -arch x86-32-nonsfi -O2 -g -Wall -fdiagnostics-show-option -Werror -DPNACL_SHIM_AOT -Wno-unused-function -Wno-char-subscripts -Wno-c++11-extensions -Wno-unnamed-type-template-args -Wno-extra-semi -Wno-unused-private-field -Wno-char-subscripts -Wno-unused-function -D__linux__ -D__STDC_LIMIT_MACROS=1 -D__STDC_FORMAT_MACROS=1 -D_GNU_SOURCE=1 -D_BSD_SOURCE=1 -D_POSIX_C_SOURCE=199506 -D_XOPEN_SOURCE=600 -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DDYNAMIC_ANNOTATIONS_PREFIX=NACL_ -DNACL_BUILD_ARCH=x86 -DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -DNOMINMAX -DPSAPI_VERSION=1 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -D_ATL_NO_OPENGL -D_SECURE_ATL -DCHROMIUM_BUILD -DTOOLKIT_VIEWS=1 -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DNO_TCMALLOC -DENABLE_EGLIMAGE=1 -D__STD_C -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -DNTDDI_VERSION=0x06020000 -D_USING_V110_SDK71_ -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static -DCLD_DATA_FROM_STATIC -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DWIN_PDF_METAFILE_FOR_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_WIFI_BOOTSTRAPPING=1 -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_NONSTDC_NO_DEPRECATE -DNACL_WINDOWS=0 -DNACL_OSX=0 -DNACL_LINUX=0 -DNACL_ANDROID=0 -I../../../../../out/Debug_x64/gen/tc_pnacl_newlib/include -I../../../../.. -I../../../../../out/Debug_x64/gen -I../../../../../third_party/wtl/include -std=gnu99' returned non-zero exit status 1

ninja: build stopped: subcommand failed.

http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28dbg%29/builds/1055/steps/compile/logs/stdio

> NaCl: Update revision in DEPS, r13506 -> r13511
> 
> This pulls in the following Native Client changes:
> 
> r13507: (noelallen) Reapply patch which was reverted due to conflict.
> r13508: (dschuff) PNaCl Driver: do not generate temp file names beyond Windows' MAX_PATH limit
> r13509: (jvoung) Add a flag to pnacl-finalize that allows users to keep function names.
> r13510: (dschuff) Disable flaky sandboxed translator tests on mac
> r13511: (dschuff) Update revision for PNaCl r13466->r13509
> 
> BUG=none
> TEST=browser_tests and nacl_integration
> CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_nacl_sdk_build
> (linux_rel_precise32,linux_arm_cross_compile omitted because they are currently broken)
> 
> R=jvoung@chromium.org
> 
> Review URL: https://codereview.chromium.org/409113009

TBR=dschuff@chromium.org

Review URL: https://codereview.chromium.org/418583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285015 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395244

Review URL: https://codereview.chromium.org/410083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285014 0039d316-1c4b-4281-b951-d872f2087c98

Compositor touch hit testing was re-enabled on Android webview back in February
(https://codereview.chromium.org/183943002) and we haven't had any complaints
since. It's probably safe to remove the flag and related code now.

This is part 1 of 2, will be followed by:
https://codereview.chromium.org/406053002

BUG=304518

Review URL: https://codereview.chromium.org/399953004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285013 0039d316-1c4b-4281-b951-d872f2087c98

This adds a link_followed parameter to CustomContextMenuContext. This object is sent back to the renderer process when a context menu is closed, allowing us to provide sufficient information to send pings if appropriate.

BUG=257281

Review URL: https://codereview.chromium.org/384243004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285011 0039d316-1c4b-4281-b951-d872f2087c98

Set up a counter in LayerTreeImpl to indicate whether a recent frame has
been pushed from main thread. Since missing and incomplete tiles are
compositor side concept, only track those numbers on compositor side.

BUG=381695

Review URL: https://codereview.chromium.org/411693004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285010 0039d316-1c4b-4281-b951-d872f2087c98

If the chrome library is loaded directly from inside the APK the android stack trace will give the on device name of the APK in the stack trace. Try to find the symbols in this case by mapping to the appropriate library name.

BUG=390618

Review URL: https://codereview.chromium.org/401003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285009 0039d316-1c4b-4281-b951-d872f2087c98