- 07 Dec, 2018 40 commits
-
-
James Cook authored
The chromeos_* unit test suites are designed to run on Linux, not on real hardware or in VMs. On the Chromium waterfall they are built with the linux-chromeos configuration. Developers using the "cros chrome-sdk" sometimes think they need to build these targets and run them, either on their host workstation or on device. The tests aren't expected to work in these environments, so prevent them from being built. Bug: 909073, 865693 Test: ninja -C out_eve/Release chromeos_unittests won't compile Change-Id: Idf8c366f7001ea5bbc744ccba6e627d70f5efebb Reviewed-on: https://chromium-review.googlesource.com/c/1358509 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#614763}
-
Hiroshige Hayashizaki authored
To reduce GetDocument() usage. As https://github.com/w3c/webappsec-csp/issues/146 has already been closed and the Blink implemetation has been changed, this UseCounter is no longer needed. Bug: 878274 Change-Id: Icb55058d369b29992436229a9b971bc6f0b8f2a6 Reviewed-on: https://chromium-review.googlesource.com/c/1192303Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#614762}
-
Madeleine Barowsky authored
We can significantly speed up WebP rendering and reduce memory footprint per image by decoding and storing lossy WebP images into their native YUV format instead of unnecessarily converting to RGB. This flag will be used to safely hide changes to the image decoding paths until the feature is completely landed. See bit.ly/webp-decoding-into-yuv for the design document and crrev.com/c/1338461 for a working prototype CL in the GPU rasterization case. Bug: 900264 Change-Id: I611d17199cae4724332d73a5606f20d4eedf9010 Reviewed-on: https://chromium-review.googlesource.com/c/1366858 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#614761}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/6f0e1f9d8235..67737f1d4a6c git log 6f0e1f9d8235..67737f1d4a6c --date=short --no-merges --format='%ad %ae %s' 2018-12-07 cwallez@chromium.org WireServer: Don't allow freeing the Device 2018-12-07 cwallez@chromium.org WireServer: on destruction, free all objects. Created with: gclient setdep -r src/third_party/dawn@67737f1d4a6c The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:907278,chromium:911155 TBR=cwallez@chromium.org Change-Id: I5bd2d58ab3b7c21546f6cd52baa9f60eda9bba87 Reviewed-on: https://chromium-review.googlesource.com/c/1368204Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614760}
-
Ben Wagner authored
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/6ad3fcddaf2b..59345cdef38c $ git log 6ad3fcdda..59345cdef --date=short --no-merges --format='%ad %ae %s' 2018-12-06 ariza [CFF] Refix oss-fuzz 11714: set_blends (PR #1458) (#1460) 2018-12-06 behdad Fix likely check 2018-12-06 behdad Add default value to first argument of sub_array() 2018-12-06 behdad Add sub_array to hb_vector_t 2018-12-06 behdad Add default-value for second arg of sub_array() Created with: roll-dep src/third_party/harfbuzz-ng/src R=bashi@chromium.org,behdad@chromium.org,behdad@google.com,drott@chromium.org,eae@chromium.org,jshin@chromium.org Change-Id: I43da06c24f22509b8ad010191c630e833a15a235 Reviewed-on: https://chromium-review.googlesource.com/c/1368044 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#614759}
-
Alexei Svitkine authored
Bug: 912320 Change-Id: I2f6367902a43a211459442897ec277effd8fc402 Reviewed-on: https://chromium-review.googlesource.com/c/1368032 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#614758}
-
Xianzhu Wang authored
The BGPT result is correct, though with subpixel differences along rounded corners. Before BGPT, the bottom-left corner was not clipped with rounded border. Change-Id: I17fd469f5ed29354a6d1dcd76970b07c88bbe4ea Reviewed-on: https://chromium-review.googlesource.com/c/1366768 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#614757}
-
yileili authored
This is a reland of 29dca9fe Remove an unnecessary include to fix the compile break: ../../chromeos/services/assistant/assistant_manager_service_impl.cc:27:10: fatal error: 'chromeos/services/assistant/assistant_warmer_welcome_log.pb.h' file not found #include "chromeos/services/assistant/assistant_warmer_welcome_log.pb.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Bug: None. Test: Compiled Original change's description: > Enable warmer welcome during Assistant launch. > > 1. It is guarded by a finch flag AssistantWarmerWelcome. > 2. WW only shows 3 times. > > Bug: b:112495005 > Test: Manual > > Change-Id: I80cbcfd4104c17172939d36b986be65077bf0bb3 > Reviewed-on: https://chromium-review.googlesource.com/c/1355174 > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Yilei Li <yileili@google.com> > Cr-Commit-Position: refs/heads/master@{#614553} Bug: b:112495005 Change-Id: I9c67fd0c85b216e17408056c6d7df35e6f205c6f Reviewed-on: https://chromium-review.googlesource.com/c/1367185Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yilei Li <yileili@google.com> Cr-Commit-Position: refs/heads/master@{#614756}
-
Jeremy Roman authored
Previously, AudioNodeOutput::RemoveInput could call AudioHandler::BreakConnectionWithLock at a time when one of the mutual sets of raw pointers has been updated but the other has not. This causes the Disable logic to go awry, leading to DCHECK failures and, after another recent change, ASAN violations, since it can be entered as part of AudioHandler::DisableOutputsIfNecessary during BreakConnectionWithLock. This was not obvious by inspection in part because this logic was distributed across several methods in different classes. To make the order in which these adjustments are made more clear, factor out the wiring logic from AudioNodeInput and AudioNodeOutput (and strictly for consistency, AudioParamHandler) into a collection of dedicated functions. Call sites are rewritten to call this code, which manages all changes to inputs_, outputs_ and disabled_outputs_ centrally. Bug: 910098 Change-Id: Ide367d89cf6601e823169082833d7a41f1019f81 Reviewed-on: https://chromium-review.googlesource.com/c/1359134 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#614755}
-
Zhuoyu Qian authored
As the comment left by jsbell@, replace IndexedDBContext::GetFilePathForTesting to use url::Origin instead of GURL. Change-Id: I50de11bbbc4b4bd582d3c7ad0031e43734c567c3 Reviewed-on: https://chromium-review.googlesource.com/c/1364992 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#614754}
-
Nicolas Pena authored
The timeout used to bail out early is causing flakiness, so this change removes that timeout since it is not needed for the test. It also increases the timeout used in cross-origin-iframe-element.html to give chance for the entry to be dispatched. Since this test passes when such entry is NOT dispatched, that test is not currently flaky. Bug: 879270, 896765 Change-Id: Ie02a9787d721e6c0d1f347b0d08dd9dbd985ca79 Reviewed-on: https://chromium-review.googlesource.com/c/1363960Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#614753}
-
Sam Maier authored
Bug: 908988 Change-Id: I170702d077cd0d3f07894afb084a1d3a20a87de1 Reviewed-on: https://chromium-review.googlesource.com/c/1367934Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#614752}
-
Xiaohui Chen authored
Increase the contrast for a11y. Bug: 910560 Test: locally build and run Change-Id: I1b8bb4d000902cd2db7349a4ca6cc63fd02f6853 Reviewed-on: https://chromium-review.googlesource.com/c/1366324Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#614751}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6df6194db8b5..7c38fee64ace git log 6df6194db8b5..7c38fee64ace --date=short --no-merges --format='%ad %ae %s' 2018-12-07 zoddicus@users.noreply.github.com Restrict mask bits for memory semantics in WebGPU (#2180) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@7c38fee64ace The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Icf2a54dc52cae0bb288bfac7e7ef8890cf1960a1 Reviewed-on: https://chromium-review.googlesource.com/c/1367868Reviewed-by:
-
Xianzhu Wang authored
Some tests have already been passing since BlinGenPropertyTrees is promoted to experimental. Change-Id: I3f99c22550461b096199cef9bbda458f5fcac1d8 Reviewed-on: https://chromium-review.googlesource.com/c/1366277 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5f7ba919cedb..92795e7e949d Created with: gclient setdep -r src-internal@92795e7e949d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7be99a4a0ca55640be8b582e31d5f2d5ee09bcc5 Reviewed-on: https://chromium-review.googlesource.com/c/1367869Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614748}
-
Akihiro Ota authored
This change only reflects updates to Android-specific code. Substituting recently implemented AXNode::GetPosInSet() and AXNode::GetSetSize() functions when posinset and setsize computations are necessary. Change-Id: I6cd876921cd1ab8cc6f47f058dcfc88d7c365897 Reviewed-on: https://chromium-review.googlesource.com/c/1361654 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#614747}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3f10ca8145d9..10b051083c0d git log 3f10ca8145d9..10b051083c0d --date=short --no-merges --format='%ad %ae %s' 2018-12-07 mbonadei@webrtc.org Disable hermetic toolchain when building on macOS 10.14. Created with: gclient setdep -r src/third_party/webrtc@10b051083c0d The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I696e0aa56bd9afd0f8548ce08d25bca532a52332 Reviewed-on: https://chromium-review.googlesource.com/c/1367965Reviewed-by:
-
Ben Pastene authored
And add a test notification for a couple builders. R=nodir, tandrii Bug: 903591 Change-Id: Ic034e8729a9dfdea522ea720e26bddc7466fd6cf Reviewed-on: https://chromium-review.googlesource.com/c/1367113 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#614745}
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/8e13fe5e8564..e7e4b386a365 git log 8e13fe5e8564..e7e4b386a365 --date=short --no-merges --format='%ad %ae %s' 2018-12-07 jchinlee@chromium.org Move vpython dependency declaration higher. Created with: gclient setdep -r src/native_client@e7e4b386a365 The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:912379 TBR=mseaborn@chromium.org Change-Id: I109f8ccfa8a3b1cbe2e29bbf89950e3a1c92f294 Reviewed-on: https://chromium-review.googlesource.com/c/1367967Reviewed-by:
-
Yuly Novikov authored
conformance/glsl/constructors/glsl-construct-ivec4.html on Android Nvidia conformance/glsl/constructors/glsl-construct-mat2.html on Nexus 5X TBR=kbr@chromium.org Bug: 912161 Change-Id: I9d772e5defe1f76fbb1235a1af924ae2a7a7e059 Reviewed-on: https://chromium-review.googlesource.com/c/1367932Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#614743}
-
bsheedy authored
Makes the environment variable paths set by XR browser tests relative to the test binary's location instead of the current working directory. This makes the tests runnable from any directory instead of only from the output directory. Bug: 912392 Change-Id: I0f6ef8e2019add1457807b3d645d18e6b413b1de Reviewed-on: https://chromium-review.googlesource.com/c/1367101Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#614742}
-
khachatryan authored
Checking if Chrome version is compatible with ChromeDriver version.. Change-Id: Ib7f9be9133e69b2c670b94fc6fec20a9598aed65 bug: chromedriver:2685 Reviewed-on: https://chromium-review.googlesource.com/c/1363687Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#614741}
-
James Cook authored
This eliminates calls to AXAuraObjCache::GetInstance() and is a step towards making the cache not be a singleton. Bug: 888147 Test: views_unittests Change-Id: I94dee9693881ff760be1c32b084072379e5d803b Reviewed-on: https://chromium-review.googlesource.com/c/1359093 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#614740}
-
Stefan Zager authored
This reverts commit 2d343ac8. Reason for revert: Compile failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-rel/5323 Original change's description: > [Feed] Import feed@8f0baf678cd55565412717d583f036a9b529bfdc > > +62,280 bytes main lib size > +479,128 bytes main dex size > +771,550 bytes normalized apk size > +295,224 bytes APK size > +855,804 bytes Estimated installed size (Android Go) > +2,230,901 bytes Estimated installed size > InstallBreakdown (+2,229,176 bytes): > +2,802 bytes unwind_cfi (dev and canary only) size > +2,718 bytes Non-compiled Android resources size > +62,280 bytes Native code size > +551 bytes Package metadata size > +2,145,521 bytes Java code size > +15,304 bytes Compiled Android resources size > +2,448 entries fields > +3,462 entries methods > +789 entries types > +1,727 entries strings > > Specifics: > InstallSize: > Dex: > Change-Id: Iee99df34b6c2fe177619c9d8978b10351b7a6375 > Reviewed-on: https://chromium-review.googlesource.com/c/1367364 > Reviewed-by: Filip Gorski <fgorski@chromium.org> > Commit-Queue: Sky Malice <skym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614728} TBR=fgorski@chromium.org,skym@chromium.org Change-Id: I70d82a859a0dc8ad2cd2547d386874176ff2bd68 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1368047Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#614739}
-
Peng Huang authored
This reverts commit 1808a743. Reason for revert: Null-dereference READ in gpu::gles2::ContextState::api https://crbug.com/912981 Original change's description: > Share one GLContext for all RasterDecoder when virtual context is used. > > With this CL, we will create a GLContextVirtual in RasterDecoderContextState, > and share it with all raster decoders, display compositoer, etc. It is a > temporary solution. In follow up CLs, we will share the one GLContext with > GLES2 as well. In that case, we will use GLContext directly instead of > GLContextVirtual. > > Change-Id: If9b8d1f32e58b32a9d9f8cd07aa10c30432e3183 > Bug: 902904 > Reviewed-on: https://chromium-review.googlesource.com/c/1357463 > Commit-Queue: Peng Huang <penghuang@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614694} TBR=penghuang@chromium.org,piman@chromium.org Change-Id: I2eb66f211d408988f30bfb870425da80e0eb7a4b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 902904 Reviewed-on: https://chromium-review.googlesource.com/c/1368284Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#614738}
-
Robert Liao authored
If there is no MessageLoop and SingletonHwnd is receiving messages, this means it is receiving messages via an external message pump such as COM Uninitialization. It is unsafe to forward these messages as observers may depend on the existence of a MessageLoop to proceed. BUG=912626 Change-Id: I9d6e76a03931db59450ac4b3d17c6aeaa365061b Reviewed-on: https://chromium-review.googlesource.com/c/1366278Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#614737}
-
Mason Freed authored
TBR=masonfreed@chromium.org NOTRY=true Bug: 912748 Change-Id: Ifd814b53adc325737cc5f688551e6fe9c64d910f Reviewed-on: https://chromium-review.googlesource.com/c/1368164Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#614736}
-
Vasilii Sukhanov authored
It can contain URL and it's undesired to truncate its end. Bug: 910681 Change-Id: I187831c2295c8b964239880cb27ce1b426322658 Reviewed-on: https://chromium-review.googlesource.com/c/1367673Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#614735}
-
Philip Rogers authored
This patch removes a bad baseline added in https://crrev.com/614470 and marks the test as passing. Bug: 912380 Change-Id: Ia4cab4002371ff23e75c82f717a12689c7dfdf2a Reviewed-on: https://chromium-review.googlesource.com/c/1367931 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#614734}
-
braveyao authored
With a recent change, the webrtc::DesktopFrame is created and initialized with 0. So it's not necessary to call memset() to the frame again any more. Bug: webrtc:9703 Change-Id: Id3b37940ad3a1e989725db578f743670c786e681 Reviewed-on: https://chromium-review.googlesource.com/c/1366785Reviewed-by:
Julien Isorce <julien.isorce@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#614733}
-
Kazuhiro Inaba authored
This reverts commit 1ceb0793. Reason for revert: ARC and Crostini on ARM broken (crbug.com/896945#c17) Original change's description: > Reland "viz: Turn off or crop primary plane when possible" > > This is a reland of I7946d7acab334bffdf2bb49a1d9c424cf46fc610 and > the following bug fixes as follows; > "viz: Fix wrong uv_rect calculation" 4bf9d01d > "viz: add unittests for CL:1291590" f8dfbe74 > > Additional fix: > - Fix the flickering issue because of primary |uv_rect| cropping even though > an overlay attemption fails mainly due to limited pixel rate (e.g. 4k video). > - Fix wrong |uv_rect| calculation which causes atomic page flip failures with > "No space left on device (28)" error. > > Original change's description: > > viz: Turn off or crop primary plane when possible > > > > For many fullscreen cases, the rest of the renderpass quads are solid > > black quads. In that case, we can turn off the primary plane, and not > > having to scan out an full screen of black pixels saves a good deal of > > power. In other cases, we can crop down the primary plane down to the > > content rectangle (youtube channel logo, for example) and save power. > > > > Averaging battery draw measurement over about a minute of play back > > for a fullscreen youtube video, power savings for soraka is around > > 500mW (6.5W to 6.0W) and 300mW for kevin (4.4W to 4.1W), when we > > turn off the primary plane. > > > > Change-Id: I7946d7acab334bffdf2bb49a1d9c424cf46fc610 > > Reviewed-on: https://chromium-review.googlesource.com/c/1045256 > > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > > Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com> > > Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#600415} > > TEST=SingleOverlayOnTopTest.AllowVideoNormalTransformWithOutputSurfaceOverlay > > Bug: 896945, 900373 > Change-Id: I88db118dbc3ca2fed8c8eaf1f9a4337cdae12990 > Reviewed-on: https://chromium-review.googlesource.com/c/1346997 > Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com> > Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com> > Reviewed-by: Kristian H. Kristensen <hoegsberg@chromium.org> > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611484} TBR=dongseong.hwang@intel.com,dcastagna@chromium.org,hoegsberg@chromium.org Bug: 896945, 900373 Change-Id: Iec6d2812d94c286c495d90d8952b65ecffa4c010 Reviewed-on: https://chromium-review.googlesource.com/c/1363734Reviewed-by:
Kazuhiro Inaba <kinaba@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#614732}
-
James Cook authored
Bug: none Change-Id: Icf58036bec43cd560ca8119428bcf6b5d2e17004 Reviewed-on: https://chromium-review.googlesource.com/c/1367656Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#614731}
-
Sahel Sharify authored
Revert "Register fling scheduler on GSB instead of GFS." and Revert "Fixed fling regression from registering observer on GSB instead of GFS." This reverts the following two commits: 0b48b62c 0e58f2ca The reason for reverting is that registering fling scheduler observer on GSB instead of GFS does not fix the one frame jank at the beginning of the fling. This change also caused some performance regressions and touchpad scrolling regression on eve. Bug: 882907,911975,911334,903161,903156,903155 Change-Id: I6aba2c0314eeab616fcb1c18c448c0b3c075d4e6 Reviewed-on: https://chromium-review.googlesource.com/c/1363893Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#614730}
-
Eric Karl authored
This chnage causes RenderWidget to invalidate its current LocalSurfaceId whenever it sends WidgetHostMsg_TextInputStateChanged, causing a new RenderFrameMetadata to be sent for the given frame. This ensures that CursorAnchorInfoController receives updates on any frame with a text change. Bug: 912309 Change-Id: Ia1b0faa8bbb0208187d31f0024a17ffdd75bda16 Reviewed-on: https://chromium-review.googlesource.com/c/1364164 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#614729}
-
Sky Malice authored
+62,280 bytes main lib size +479,128 bytes main dex size +771,550 bytes normalized apk size +295,224 bytes APK size +855,804 bytes Estimated installed size (Android Go) +2,230,901 bytes Estimated installed size InstallBreakdown (+2,229,176 bytes): +2,802 bytes unwind_cfi (dev and canary only) size +2,718 bytes Non-compiled Android resources size +62,280 bytes Native code size +551 bytes Package metadata size +2,145,521 bytes Java code size +15,304 bytes Compiled Android resources size +2,448 entries fields +3,462 entries methods +789 entries types +1,727 entries strings Specifics: InstallSize: Dex: Change-Id: Iee99df34b6c2fe177619c9d8978b10351b7a6375 Reviewed-on: https://chromium-review.googlesource.com/c/1367364Reviewed-by:Filip Gorski <fgorski@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#614728}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e14feaf5b9aa..0c2dc8c378bb git log e14feaf5b9aa..0c2dc8c378bb --date=short --no-merges --format='%ad %ae %s' 2018-12-07 syoussefi@chromium.org Vulkan: Fix dirty default attributes handling Created with: gclient setdep -r src/third_party/angle@0c2dc8c378bb The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I1ed90b16d53425d64953254fb485c076b7389fe1 Reviewed-on: https://chromium-review.googlesource.com/c/1367964Reviewed-by:
-
sebsg authored
Bug: 907929 Change-Id: I5327254e20e4e6bbbfd0d8fc35d24e1dd5814917 Reviewed-on: https://chromium-review.googlesource.com/c/1366374Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#614726}
-
Xida Chen authored
This CL adds a AddPaintWorkletImage which is used in the GatherDiscardableImages when we update a display item list after recording. Essentially this makes the recording source aware of a cc::PaintImage that is backed by a PaintWorkeltInput. Two unit test are added to make sure the correctness. Bug: 907897 Change-Id: I2144a5c729e41b15ae4083ae3b8fcaf4a2ea204d Reviewed-on: https://chromium-review.googlesource.com/c/1365878Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#614725}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dddb0585df2c..5f7ba919cedb Created with: gclient setdep -r src-internal@5f7ba919cedb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I234c7aff71cd2dc8f312c1fddbd58ae3d9df8db4 Reviewed-on: https://chromium-review.googlesource.com/c/1367866Reviewed-by:
-
