GitLab

When an entry on the history page is deleted, we create history
deletion directives that are sent through sync. These are required to
support offline history deletions, and make sure these are properly
propagated. However, these deletion directives rely on exact matches in
timestamps, which are in microseconds since the epoch.

The History page on Android converted microsecond timestamps to
millisecond timestamps for Java compatibility, but when these
timestamps were handed to the logic that created history deletion
directives, they were now slightly off. This change simply plumbs
through microsecond timestamps through the java code and back.

BUG=729020

Review-Url: https://codereview.chromium.org/2935783002
Cr-Commit-Position: refs/heads/master@{#478756}

I'm adding support in Chrome for the Android spellcheck menu in
https://codereview.chromium.org/2931443003. When a user taps on a misspelled
word, I need to highlight the word in a color based on the color of the
spellcheck underline (we add some transparency). We're trying to avoid
hard-coding the spellcheck color in editing code. Therefore, we think it makes
sense to move the colors for spelling/grammar markers out of
InlineTextBoxPainter into LayoutTheme, so other code can make use of them.

BUG=715365
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2932913002
Cr-Commit-Position: refs/heads/master@{#478755}

Add a section about binary size sheriffing.

Bug: None
Change-Id: I1bca09d9c3148395c896b406ecbb9bff217988a7
Reviewed-on: https://chromium-review.googlesource.com/531565
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478754}

This CL:

1) Set page count to unknown for PrintDocumentInfo in onLayout
stage since we don't need to report pages count of a file. Android
framework will get page count from the file produced from onWrite
stage. This change will fix crbug/593387.

2) Removed printing jobs started from onLayout. We don't need to
report pages count of the file at that stage, hence no need to
start printing jobs from onLayout. As a replacement, starting all
printing jobs from onWrite. It is related to crbug/612315, but
crbug/612315 is not really true about saving file generating time
since we didn't generate a file twice.

3) With other cleanup because variables such as mLastKnownMaxPages
is not useful anymore.

Bug: 593387, 612315
Change-Id: Ic52d9aa12b4aeb659156e1e2eb21f2f11afbd60c
Reviewed-on: https://chromium-review.googlesource.com/521205
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478753}

BUG=672225
R=skym@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2920853004
Cr-Commit-Position: refs/heads/master@{#478752}

Include host IP address and port and net_error for requests in callbacks for PageLoadMetricsObservers

Currently, the ChromeResourceDispatcherHostDelegate does not pass a request's host IP address and port or network error status to the MetricsWebContentsObserver for use by PageLoadMetricsObservers. We are trying to write an observer that examines local network requests from non-local pages and would need the host IP address and port and error status to collect our metrics. The GURL object passed to the MetricsWebContentsObserver contains the hostname as a domain name, but the domain name is insufficient for distinguishing between local network and public requests without additional network calls to a DNS server. The host IP address and error status information we pass could also potentially be useful for other page load metrics observers.

This CL refactors ChromeResourceDispatcherHostDelegate, MetricsWebContentsObserver, and PageLoadMetricsObserver::ExtraRequestCompleteInfo to include the HostPortPair for the hostname and port for completed requests. The hostname and port for completed requests are taken from URLRequest.GetSocketAddress() if the request was successful, and from URLRequest::GetRemoteEndpoint if URLRequest::GetSocketAddress returns an empty value, which can happen if the request failed or was canceled.

This CL also updates all unit tests and test harnesses that create mock ExtraRequestCompleteInfo objects and/or invoke the request complete callbacks in ChromeResourceDispatcherHostDelegate or MetricsWebContentsObserver.

BUG=

Change-Id: I56be75c23cba543ff82f16e639676e5e112c61a8
Reviewed-on: https://chromium-review.googlesource.com/526478
Commit-Queue: U Thakore <uthakore@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478751}

To fix base_unittests in
https://build.chromium.org/p/chromium.fyi/builders/Fuchsia%20(dbg)

Bug: 706592
Change-Id: I22a305103dc54f2a5fde3e4d8e903db1586d8941
Reviewed-on: https://chromium-review.googlesource.com/528542Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478750}

LayerTreeHost didn't keep track of the number of surface layers for each
SurfaceId. When there are multiple SurfaceLayers for the same SurfaceId
both SurfaceLayerIds() and needs_surface_ids_sync() were potentially
wrong.

Make LayerTreeHost track the number of layers for each SurfaceId. Also
add tests for this case.

Bug: 731263
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ifd6efe1b02c9ec4f728490b4487756b5319b681f
Reviewed-on: https://chromium-review.googlesource.com/529566Reviewed-by: enne <enne@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478749}

This will need to be reimplemented later using
__sanitizer_cov_trace_pc_guard.

BUG=728684,729822

Change-Id: I1f979b3ceac8a59e27f96428b77ec1d983ac4cef
Reviewed-on: https://chromium-review.googlesource.com/529972Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Oliver Chang <ochang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478748}

Bug: 728324
Change-Id: Id007d43ea6468ce3ed8601c4e848861c224ef578
Reviewed-on: https://chromium-review.googlesource.com/529684
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478747}

https://skia.googlesource.com/skia.git/+log/ffaa47e0fe5f..7a8c84c6c925

$ git log ffaa47e0f..7a8c84c6c --date=short --no-merges --format='%ad %ae %s'
2017-06-12 ericrk Reland DeferredTextureImageData low-bit-depth/dithering support
2017-06-12 msarett Revert "Revert "Disable F16-nullptr sources""
2017-06-12 mtklein fix f16 encoding
2017-06-12 csmartdalton Convert SkClassifyCubic to double precision
2017-06-12 senorblanco GrTessellator: fix two NaN issues.
2017-06-12 benjaminwagner [infra] Isolate tasks don't need compile task.
2017-06-12 reed enable rasterpipeline for android

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=rmistry@chromium.org

Change-Id: I343d7c3cbe318abc3deb57ee0df53931ab90397d
Reviewed-on: https://chromium-review.googlesource.com/531800Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478746}

BUG=726972

Review-Url: https://codereview.chromium.org/2924413002
Cr-Commit-Position: refs/heads/master@{#478745}

This allows us to enable and disable the passthrough command decoder
globally with small changes.

BUG=602688

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I56c9cdea929f62748575fc67016e6de8fa03ac5f
Reviewed-on: https://chromium-review.googlesource.com/531344Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478744}

Bug: 732474
Change-Id: Ibe686ac089ec53cda5b4a21705e2006445eabbb6
Reviewed-on: https://chromium-review.googlesource.com/531854Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Commit-Queue: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478743}

Currently, in JS bindings, we pass the event filter to JS, and then pass
it back to C++ to find matching event listeners. This can cause problems
because the object could be tweaked by monkey-patching, and we aren't
correctly checking.

Instead of updating the checks to safely interact with the object, just
avoid passing it to JS altogether. Instead, pass the ids of the relevant
listeners directly to JS. This avoids the security issue and is also
more performant.

Add a regression test.

BUG=702946

Review-Url: https://codereview.chromium.org/2924683002
Cr-Commit-Position: refs/heads/master@{#478742}

BUG=730073

Review-Url: https://codereview.chromium.org/2929483002
Cr-Commit-Position: refs/heads/master@{#478741}

This will allow it to be shared with the network service, and makes it
easy to pass all relevant arguments to the network service as well.

May add handling for command line arguments that affect more than just
the HttpNetworkSession::Params there as well in a future CL, to enable
further code sharing.

TBR=lcwu@chromium.org,rkc@chromium.org
BUG=727812

Review-Url: https://codereview.chromium.org/2914893002
Cr-Commit-Position: refs/heads/master@{#478740}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2933123002
Cr-Commit-Position: refs/heads/master@{#478739}

When a user is in the holdback experiment, data saver's proxy server is
not actually used, so a pingback was not actually sent to the server in
that case. However, for sake of comparing similar page loads, a pingback
should now be sent for the holdback user when it is likely they would
have used data reduction proxy. The pingback also needs to indicate that
the specific page load is a holdback experiment page load.

BUG=731180

Review-Url: https://codereview.chromium.org/2934543002
Cr-Commit-Position: refs/heads/master@{#478738}

Cr-Commit-Position: refs/heads/master@{#478737}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2933823002
Cr-Commit-Position: refs/heads/master@{#478736}

The fallback logic in GetActiveUserOrOffTheRecordProfileFromPath
should cover the case when the user profile loading has not started.
So that it does not creates/loads user profile accidentally without
going through UserSessionManager.

BUG=728683,718734
TEST=ProfileManagerTest.UserProfileLoading

Review-Url: https://codereview.chromium.org/2918203002
Cr-Commit-Position: refs/heads/master@{#478735}

BUG=729106

Review-Url: https://codereview.chromium.org/2928653003
Cr-Commit-Position: refs/heads/master@{#478734}

The issue (crbug.com/719011) indicate that it is hard to interact with
the content under the the scrollbar because the scrollbar will fade in
while mouse moves in the hover fade in region of scrollbar.

In this patch, we prevent fade in overlay scrollbar when user mouse
down. 3 behaviors changed:

1. When mouse move in hover fade in region of scrollbar with mouse
   press, we don't trigger delay fade in.
2. When mouse down after a delay fade in triggered, cancel the delay
   fade in.
3. When mouse up in hover fade in region of scrollbar, trigger a delay
   fade in.

BUG=719011
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2931703002
Cr-Commit-Position: refs/heads/master@{#478733}

Bug: 732432
Change-Id: Id9b1ef6f89c03b3bddc2d3b5a4a8ed1d901dae98
Reviewed-on: https://chromium-review.googlesource.com/531664
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478732}

Most callers already call through WebLocalFrame (sometimes without
realizing this, so the CL changes types to WebLocalFrame in a few
places).  The only exception is in CapturePixelsForPrinting function
in content/shell/test_runner/pixel_dump.cc - the CL adds a CHECK to
verify that layout tests do not run into a scenario unsupported by
the current layout tests harness.

Additionally this CL renames PrintPagesWithBoundaries method
into PrintPagesForTesting.

No intended behavior change.

BUG=416660

Review-Url: https://codereview.chromium.org/2923343005
Cr-Commit-Position: refs/heads/master@{#478731}

SHA-1 was successfully disabled by default in M56 for publicly trusted
CAs. Remove the metrics that measured the impact of that disabling.

BUG=703458

Review-Url: https://codereview.chromium.org/2931313003
Cr-Commit-Position: refs/heads/master@{#478730}

A WebState attempts to cancel its dialogs in its destructor.  However,
the BVC uninstalls itself as the WebStateDelegate before the WebState
is deallocated, so the WebStateImpl doesn't have access to its
JavaScriptDialogPresenter to handle the cancellation.

This CL adds a call to |-cancelDialogForWebState:| when the delegates
are uninstalled for a Tab to ensure that alerts aren't queued in the
DialogPresenter for WebStates that have been deallocated.

BUG=720778

Review-Url: https://codereview.chromium.org/2926413004
Cr-Commit-Position: refs/heads/master@{#478729}

Currently SavePackage uses DownloadJobImpl as its DownloadJob implementation.
However, DownloadJobImpl will be refactored to handle all regular downloads.
So SavePackage should have its own DownloadJob implementation.

BUG=726487

Change-Id: I18b842982c9fe89226868f822030463128cbc4b0
Reviewed-on: https://chromium-review.googlesource.com/528497Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478728}

This patch changes ShapingLineBreaker behavior when there is no break
opportunity within the range, and all glyphs can fit in the available
space.

NGLineBreaker expects the ShapeResult to the end of the range, and
handles breakability between the next item by itself in such case.

It used to expect whether there's a break opportunity at the end or not,
and the mock computed it anyway. The semantics was changed since
ShapingLineBreaker does not produce as part of other computation.

This patch enables ShapingLineBreaker by default, while keeping the mock
under #ifdef to ease the isolation of problems.

Most of test failures are ignorable, crashes turn to failures, minor
differences in measuring widths, or caused by other problems (e.g.,
innerText.)

spelling-huge-text.html looks problematic. ShapingLineBreaker is more
than 10 times slower for long lines (30k characters in single text node
in this case.) I have some hypothesis, but I'd like to defer the perf
until we get more real safe-to-break. Current mock safe-to-break
requires to reshape a lot, which is good to test reshape code, but is
not appropriate to look at the perf problems.

BUG=636993

Review-Url: https://codereview.chromium.org/2879093002
Cr-Commit-Position: refs/heads/master@{#478727}

Back in the mists of time, Indexed DB in the browser
ran on a "webkit thread". We slimmed that down to being
a dedicated IDB thread, but it's now possible to ditch
that and use the task scheduler APIs, e.g. to avoid
thrashing.

BUG=552552

Review-Url: https://codereview.chromium.org/1504033007
Cr-Commit-Position: refs/heads/master@{#478726}

A regression was introduced in [1] where LayerTreeHost::ApplyViewportDeltas
would not apply inner viewport scroll deltas due to an extra "!" and no
existing tests of this code.

I confirmed this unbreaks scrolling with viewport hiding locally. A patch
will follow with a test.

[1] https://chromium-review.googlesource.com/c/527346

Bug: 732327
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I8f69ea90a6793348cf1f35a5d616988ea48a6d8c
Reviewed-on: https://chromium-review.googlesource.com/531650Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478725}

This patch adds initial support for letter-spacing and word-spacing.

ShapeResultSpacing is templatized to share the code with TextRun.

This patch does not support ShapingLineBreaker yet. When it reshapes,
we need to apply spacing to reshaped parts. I'll work on it in following
patches.

Justification in LayoutNG is not supported yet either. It will be
following work too.

BUG=636993

Review-Url: https://codereview.chromium.org/2924263003
Cr-Commit-Position: refs/heads/master@{#478724}

This will ease reuse of this code in other classes.

Bug: 730170
Change-Id: I13b59fa864c0b1ddecef5e66d4ff0cf6a14d6fcb
Reviewed-on: https://chromium-review.googlesource.com/530984
Commit-Queue: Francois Doray <fdoray@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478723}

We are monitoring grid container's style change to detect cases where
some grid items may be shrunk or stretched. In those cases we are
marking the item for layout, which implies a considerable impact on
performance.

Current code assumes, wrongly, that if grid container's old style had
'stretch' as value for its align-items property it may affect some of
its children's Self Alignment properties. This assumption led to an
unnecessary overhead of evaluating every child's align-self property
to detect stretching or shrinking behaviors.

It's obvious that if grid container's Default Alignment change didn't
imply stretching or shrinking, we don't need to evaluate its children
at all.


Bug: 729236
Change-Id: I0b21f09b1d1c16e06374c2d20d150fd2829711f0
Reviewed-on: https://chromium-review.googlesource.com/524043
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#478722}

https://swiftshader.googlesource.com/SwiftShader.git/+log/399a298..3b9e1ea

BUG=swiftshader:62
BUG=swiftshader:64

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: Iac2a755683e27f0c01014e55ea9ca9fbe2cb1821
Review-Url: https://codereview.chromium.org/2930373002
Cr-Commit-Position: refs/heads/master@{#478721}

The existing ChromiumEnv class retries several methods on failure for a
bit, this CL adds that same retry logic to the new MojoEnv leveldb env.

Bug: 586194
Change-Id: I6d3805ed8e0db6cbd1363a85b087ee0753000cfb
Reviewed-on: https://chromium-review.googlesource.com/528294
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Michael Nordman <michaeln@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478720}

This will prevent the accumulation of translate events when UMA recording is not enabled.

Also:
 - clear the event_cache when recording is disabled.
 - Change 'return' to 'continue' in translate_ranker_metrics_provider in case only a subset of browser states don't have a valid ranker.

BUG=730032

Review-Url: https://codereview.chromium.org/2930433004
Cr-Commit-Position: refs/heads/master@{#478719}

Bug: 635031
Change-Id: If116b73922b27263fc5934f85939a95ad861ffd0
Reviewed-on: https://chromium-review.googlesource.com/528374
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478718}

SequenceLocalStorageMap allows storing and then retrieving arbitrary values to/from a sequence.
It stores the values itself and their destructors. When the SequenceLocalStorageMap object is
destroyed, the values are also destroyed by their associated destructors.

This change will make it easier to migrate from SingleThreadTaskRunner
to SequencedTaskRunner for components that use thread-local-storage.

Reference: https://chromium-review.googlesource.com/c/525834/

Bug: 695727
Change-Id: I4f8558cd21aa30e7932bdd039ca618c6ff9c6de9
Reviewed-on: https://chromium-review.googlesource.com/527299
Commit-Queue: Jeffrey He <jeffreyhe@google.com>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Francois Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478717}