- 03 Mar, 2020 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7e2188de..189353b3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6e68b952753daefd30bbbfbecb4d6dcdac98a52c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084511Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746350}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: Ie729809d9a64635b28828461aaf84d01105b0719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083448Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746349}
-
Javier Ernesto Flores Robles authored
Adds the screen to be shown when the passwords are erased due a sign out. The current image is a placeholder while the final version is ready. Bug: 1045452 Change-Id: Ifccdbd64618e28d8c670aa80adf6b02b76e90b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084593 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#746348}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9ee726959e1f..e36af5c1ab9b Created with: gclient setdep -r src-internal@e36af5c1ab9b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ic33623039df13345f92a406a8927d3b3dc21a65a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083960Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746347}
-
Paul Lewis authored
Bug: 1032561, 1046784 Change-Id: I8de085643cd605e3f12b7640b703157f9bfbb176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082386Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#746346}
-
Nico Weber authored
MSVC_PUSH_DISABLE_WARNING (and MSVC_POP_WARNING) had a few (no-op) uses that needed cleaning up. MSVC_DISABLE_OPTIMIZE (and MSVC_ENABLE_OPTIMIZE) have no uses and can just be removed. Bug: 1053958 Change-Id: Ic4e3a4c7443988d4621d79e02b348f1a3628730f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082353 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#746345}
-
Rune Lillesveen authored
Sub-pixel size changes to the root element font-size did not update rem unit lengths if the px rounded root element font-size did not change. Bug: 928371 Change-Id: Id9fab5ac4ab5a126b39a0d2bd7373d01802d29fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083175Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#746344}
-
Nohemi Fernandez authored
Show an activity indicator animation when the sign-in operation is in progress and remove it if the user cancels the operation while it has not yet been completed. Bug: 971989 Change-Id: I0578f79318e7b0476c4d159ee163d00bbabb461d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079111Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#746343}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b19408040143..853789cdfe3c git log b19408040143..853789cdfe3c --date=short --first-parent --format='%ad %ae %s' 2020-03-03 borenet@google.com [recipes] Refactor nanobench flags Created with: gclient setdep -r src/third_party/skia@853789cdfe3c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: Iac597da19376331ea6a394c134c40c61579ff728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083957Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746342}
-
Tobias Sargeant authored
SelectionPopupController uses ActionMode.getMenuInflater to instantiate a MenuInflater that uses an appropriately themed context. However this can never work for WebLayer, because it relies on the wrapped context as the only means of accessing its assets/resources. WebLayer cannot rely on the current implementation because reaching the fallback is dependent on the embedding application not having defined a resource with the same ID. WebView, on the other hand, must continue to use the current approach, because it injects its assets and resources into the activity context and can make use of activity themes, but in some cases may have to fall back to the WebContents context because on sokme Android versions and in some circumstances the ActionMode object has a context that has not had webview resources injected. Bug: 1057816 Change-Id: I417bea202ffb439fcc3960c3c5e28360b16fe9d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083476Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#746341}
-
Hans Wennborg authored
Bug: 993206 Change-Id: I2d010d65ae5b6007b7c065dc45ae8dd2a36d1dee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083183Reviewed-by:
-
Tim van der Lippe authored
Requires the same LLVM_ENABLE_PROJECTS arg specified. I also removed the duplication for the Ninja build instructions. R=hans@chromium.org Bug: 993206 Change-Id: I96d278120be62813a62b8c1f930b5ff55e2f34cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082924 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
Maksim Moskvitin authored
This CL is a part of ObjectID -> Topic API migration. It replaces ObjectID with Topic in InvalidationLogger and its dependencies. There should be only one behavioral change: chrome://invalidations page would expose 0 as an ObjectID::source for any subscription. It's not a real change, because |source| was already deprecated and the same value used. In the future chrome://invalidations should be updated to use Topic instead of ObjectID. chrome.invalidations.logInvalidations now receives TopicInvalidationMap::ToValue() instead of ObjectIDInalidationMap::ToValue(), but their ToValue() implementations are the same, so there should be no changes. Bug: 1029698 Change-Id: I17f36f7c43b664185bf87da4edb8d7d99a0afec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074877 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#746338}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e8a277b7c74b..d5ae9bf042df git log e8a277b7c74b..d5ae9bf042df --date=short --first-parent --format='%ad %ae %s' 2020-03-03 szuend@chromium.org [utilities] Remove a use-site of Array#remove in RequestCookiesView 2020-03-03 szuend@chromium.org [utilties] Replace use-site of Array#remove with Array#filter 2020-03-03 tvanderlippe@chromium.org Add tsc.js to inputs of ts_library 2020-03-03 liviurau@chromium.org Retry rmtree on windows Created with: gclient setdep -r src/third_party/devtools-frontend/src@d5ae9bf042df If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1050549,chromium:1057642 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia4930b2a1edf63f4c1d366b30d5ad82bc82e0a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083958Reviewed-by:
-
Mihai Sardarescu authored
This CL extends the lifetime of histogram FirstRun.SignIn as it is a critical histogram used to log the way the user interacts with the sign-in screen shown during the first run. Bug: 1052986 Change-Id: I061d1257b006256af095ecb7ecc46f798da813ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083471Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#746336}
-
Himanshu Jaju authored
Bug: 1002436 Change-Id: Ia114dfb35767ac63a2ca3462d13c04cd7e64837c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082514Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#746335}
-
Tim van der Lippe authored
Clang-format is now part of the GitHub repository at https://github.com/llvm/llvm-project/tree/master/clang and requires the `clang` project to be enabled in the cmake command. R=hans@chromium.org Bug: 993206 Change-Id: I6527fd41050550f979836b76b5b86cda2dd36d95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081425 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
-
Yifan Luo authored
This CL add an extended attribute in the WebIDL compiler named `TrustedType` and change the current ScriptString, ScriptURLString and HTMLString types in the idl files into DOMString type with a TrustedType=TrustedScript|TrustedScriptURL|TrustedHTML attribute. Bug: 1043136 Change-Id: If23c81b59018ede2ef68bc785cde3f70ed9ee981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012284Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/master@{#746333}
-
Henrique Ferreiro authored
The scale factor refers to the cursor bitmap, not to a property of a device, so the new name seems more appropriate. Bug: 1040499 Change-Id: Ia203025d9976c7b8393185ce23dc29cf02caef83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078266 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#746332}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/194c399f9673..9ee726959e1f Created with: gclient setdep -r src-internal@9ee726959e1f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1049638 Tbr: jbudorick@google.com Change-Id: Id566a85598a7f264aa2955e4b72118841fea2627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084443Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b84969ad69c3..c3655c3a7d55 git log b84969ad69c3..c3655c3a7d55 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 416d37452275..176f3a3dbbc9 (2 commits) 2020-03-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src cb689b0b1d30..f32bf1c930c8 (8 commits) Created with: gclient setdep -r src/third_party/angle@c3655c3a7d55 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: I717ece8e4d298674a3720b5a0a39e9b9378e34a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084441Reviewed-by:
-
Julie Jeongeun Kim authored
This is a reland of 52dbe8bb It adds kMaxInsecureRequestPolicy to avoid VALIDATION_ERROR_UNKNOWN_ENUM_VALUE as InsecureRequestPolicy is a bitfield and could have (kUpgradeInsecureRequests | kBlockAllMixedContent). Original change's description: > Move WebInsecureRequestPolicy values to mojom > > This CL is a precursor to converting > FrameMsg_EnforceInsecureRequestPolicy to blink RemoteFrame mojom. > It moves WebInsecureRequestPolicy values to mojom to use the values > in content and blink and removes WebInsecureRequestPolicy. > > Bug: 1047284 > Change-Id: If030952dbd0c9e98bb0c4a11479ea175ade91fc5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045293 > Commit-Queue: Julie Kim <jkim@igalia.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743880} Bug: 1047284 Change-Id: I51d1e126db9a935d9065c0ff539a86f761885d50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071164Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b6cad595a9df..e8a277b7c74b git log b6cad595a9df..e8a277b7c74b --date=short --first-parent --format='%ad %ae %s' 2020-03-03 sigurds@chromium.org [deps] Roll protocol changes from v8 and chromium 2020-03-03 szuend@chromium.org [utilities] Use Set instead of an Array in EmulatedDevicesList 2020-03-03 almuthanna@chromium.org Move all helper functions to one folder Created with: gclient setdep -r src/third_party/devtools-frontend/src@e8a277b7c74b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1050549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie10dfa763d455a480c81eb7c28330efb0367decb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084442Reviewed-by:
-
Sami Kyostila authored
Bug: 1057975 NOTRY=true TBR=crouleau@chromium.org Change-Id: I5004fbf639d4a77babb5a458339a13855fc9f7da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081424Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#746327}
-
Sam Maier authored
A few libraries are using different versions: auth-api-phone: 17.0.1 vision-common: 18.0.0 vision: 18.0.0 Change-Id: I5586ee0123501d64bcf0ab095e59f79b93f72803 Binary-Size: This increase does not impact the shipped to users .apk Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083221 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#746326}
-
Renato Silva authored
- Improvements to the HID detection screen style. - New popup dialog for PIN input according to specs. - Removed all the logic from the screen handler ans JS side. Fixed: 852046 Change-Id: Ie913390658243a1867904a9f2d33856a303b7abf Bug: 852046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030871Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#746325}
-
Alice Wang authored
This CL removes the Android EDU support. Bug: 1044616 Change-Id: I4f63772cbb2c5f9da6c5b632a583572f6a85adec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072222 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#746324}
-
Andrew Solovey authored
Fix a problem when the primary Unicorn account could be force logged out in case secondary account becomes unauthenticated. Force log out only when primary account has errors with its refresh token. R=droger@chromium.org, emaxx@chromium.org, sinhak@chromium.org Bug: b/146461662 Change-Id: I22f2da65e2b208f47d791cd1c6c3d9b0235a9af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058958Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Andrei Salavei <solovey@google.com> Cr-Commit-Position: refs/heads/master@{#746323}
-
Maksim Moskvitin authored
This CL is a part of ObjectId -> Topic API migration. It's a pure refactoring and there should be no behavioral changes. This CL replaces ObjectID with Topic for public interfaces of components/invalidation. It removes all the occurrences of ObjectID from chrome/browser/policy, chrome/browser/chromeos/policy, components/sync (except java counterpart) and components/drive. components/invalidation/public still exposes ObjectID in some places, because it has internal usages (will be addressed in follow-up patches), so build dependencies are not updated yet (cacheinvalidation should be only used internally in the future). Bug: 1029698 Change-Id: Ibd152e2185a9f63bb9f3667bbff7ab0b70720eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066917Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
-
Christopher Cameron authored
Specify RGBX_8888 when alpha is not needed, so that DXGI_ALPHA_MODE_IGNORE will be specified in DirectCompositionChildSurfaceWin. Bug: 1057163 Change-Id: Ief415035f268b0d56a03342d9adf1948eda6b774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082552 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#746321}
-
Eriko Kurimoto authored
This CL modifies the comment in dedicated-worker-parse-error.html. Change-Id: I671c28c08101dfb36d3a439897e64d7da12ae853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083982Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#746320}
-
Hiroki Nakagawa authored
Bug: n/a Change-Id: Ifba3512fa358617373c8da6f3353d3fe96ac7660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084334Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#746319}
-
Jérôme Lebel authored
This test has been disabled for a timeout raison. This cannot be reproduced. The test failed twice on ios13-beta-simulator in setup phase which is not related to the test. So the test can be re-enabled. Fixed: 1055457 Change-Id: Ib51ab730bb08171fe1c57896ea558bb9ba4a0375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083472 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#746318}
-
Mahmoud Gawad authored
Allow mojo_utils in wilco_dtc_supportd to use ScopedAllowBlocking's private ctor. GetStringPieceFromMojoHandle() runs in the browser process and has DCHECK errors. This is because GetStringPieceFromMojoHandle() uses base::file::Fstat() that is marked with ScopedBlockingCall. Background: Referring to the discussion in https://chromium-review.googlesource.com/c/chromium/src/+/2042611, the ideal solution to this problem is to upgrade mojo library in chromeos (mojo library in chromeos is 1-2 years older than chrome). Doing that, the new shmem builtin types can be used and we won't need to get the handle's length in the first place. The problem with that is upgrade will take time. So, as a temporary solution, allow mojo_utils in wilco_dtc_supportd to use ScopedAllowBlocking's private ctor by making the class friend with ScopedAllowBlocking. The justification as per alexilin@ is that: Fstat() shouldn't be blocking for shared memory descriptors (i.e. mojo handle). Fstat() will read tmpfs metadata that is always stored in RAM. That metadata is never swapped to disk since it's part of kernel-allocated memory that is never swapped out. Bug: 1055467,b:146119375 TEST=building and running unittests Change-Id: Iba688b7f311c07b051687a1f619b594475892178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070160 Commit-Queue: Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
Pâris MEULEMAN authored
This works around crashes that surfaced in Cross-origin-opener-policy WPT tests. Two possible crashes happened: 1 - The |RenderView| that created the |BlinkTestRunner| used as a delegate got deleted. Later a new |RenderView| is created, followed by its |RenderFrame|. The creation of the |RenderFrame|'s associated |WebFrameTestClient| crashes as |TestInterfaces::delegate_| is now uninitialized (DCHECK in |WebFrameTestClient| ctor). 2 - Two |RenderViews| are created, both create a |BlinkTestRunner|, the first one created is used for |TestInterfaces::delegate_|. Then |WebFrameTestClient|s are created, and take a pointer to this |delegate_|. Later the |RenderView| associated to the delegate is deleted, deleting the delegate. Leading to UAFs by |WebFrameTestClient|s under the other |RenderView|. This failures happen in COOP tests as multiple tests opening and closing popups are ran simultaneously from the same window. A bit more context: The creation of the |RenderView|, instrumentalized for tests through |CreateWebViewTestProxy| creates a new |BlinkTestRunner| and a child class of |RenderView|: |WebViewTestProxy|. The first execution of |CreateWebViewTestProxy| registers the |BlinkTestRunner| using |TestInterfaces::SetDelegate|. The |RenderView| destruction updates |TestInterfaces::delegate_| to nullptr. Likewise, the creation of |RenderFrame| through |CreateWebFrameTestProxy| creates a |WebFrameTestProxy| and closely related |WebFrameTestClient|. The latter saves a pointer to |TestInterfaces::delegate_|. To Prevent these crashes, this CL changes: - When a |RenderView| is created and no delegate exists, i.e. |TestInterfaces::delegate_| is nullptr, use the newly created |BlinkTestRunner| as the delegate_. This avoids 1-. - When a |RenderView| is deleted and another exists, switch to that one's |BlinkTestRunner| as the |TestInterfaces::delegate_|. - |WebFrameTestClient| to not hold a pointer to |TestInterfaces::delegate_| and instead access it through the |WebViewTestProxy| pointer it already had: |web_view_test_proxy_->test_interfaces()->GetDelegate()|. These two combined avoid 2-. Bug: 922191 Change-Id: I83e16a4064afca1c595b04c5ccbb46f1488188f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074482 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#746316}
-
Kent Tamura authored
This CL relands a part of http://crrev.com/c/2074840. In order to fix crbug.com/1056094, we'd like to add new pointer field to ChildrenChange. However, just adding the field regresses appendChild performance significantly on some perf bots (crbug.com/1057282). So, this CL also does the following changes to reduce memory cost and code size cost: - Make ChildrenChangeType and ChildrenChangeSource scoped enums, and they are based on uint8_t. - Move |by_parser| field next to |type| These two changes make it possible to pack |type| and |by_parser| - Introduce ChildrenChange:ByParser() to simplify the code This CL has no user-visible behavior changes. Bug: 1056094, 1057282 Change-Id: I1fd99c1779f26358e277dba521395e39b9751217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082428Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#746315}
-
Maksim Moskvitin authored
UpdateCryptographerFromKeystoreNigori() and UpdateCryptographerFromNonKeystoreNigori() had already shared logic and we have plans to make their logic even more common: - accept different keys for decryption of keystore Nigori - validation of these keys (e.g. current default key is acceptable for any passphrase types, but it's better to avoid it after passphrase type change) - validation of remote keybag after encryption - differences related to going out of |pending_keys| state seem wrong There are still several redundant if's, which change behavior based on passphrase type, introduced in this CL. They will be removed in follow-up CLs and introduced to avoid behavioral changes. This CL is a pure refactoring and doesn't introduce any behavioral changes. Bug: 1020084, 1057655 Change-Id: I99ce31ac1c6ca3ca42e017c3a61ede731a48dc54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944487 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#746314}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/03a5e99059af..f6edc90900fe git log 03a5e99059af..f6edc90900fe --date=short --first-parent --format='%ad %ae %s' 2020-03-03 ting.shao@intel.com [Telemetry] Add logs for loading the server and request handler 2020-03-03 fancl@chromium.org sheriff-config add /warmup for config caching Created with: gclient setdep -r src/third_party/catapult@f6edc90900fe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1019097 Tbr: skyostil@google.com Change-Id: Ie2d67bb98821dfda501cf50a49c0c54c2d706b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084439Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I4d59d6d2f15a90c4dc1e207a06bd114e0133a23b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084440Reviewed-by:
-
Mark Cogan authored
This CL refactors the BroswerState keyed service that handles enabling and disabling web states (WebStateListWebUsageEnabler) to be a Browser Agent. The API is unchanged, aside from accessing the agent via FromBrowser() instead of FromBrowserState(). The URLLoadingService unittest needed to be heavily updated for this change: - The unused TabModel mocks were removed. - The test was updated to do work in the constructor and destructor, rather than SetUp and TearDown. Thins includes moving most of the member init to an init list. - The test now uses no-parameter TestBrowser constructor which creates and owns its browser state and web state list. The accessory classes for WebStateListWebUsageEnabler (the factory and abstract base class) are also removed. Bug: 1032556 Change-Id: Ib973d31253c5c92586184089db31d780083a8fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062970 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#746311}
-
