- 23 Sep, 2020 40 commits
-
-
Ian Clelland authored
With an upcoming change to Feature/Permissions Policy, the header alone will no longer be sufficient to delegate permissions to use powerful features in subframes. The iframe allow attribute must be used in conjunction with it. The header can still be used to block delegation. This change updates the WebUSB WPTs to use the allow attribute for delegation. Bug: 1095641 Change-Id: I278d5f3b9a105b5ed0ac556223908dc83524ef7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424634 Commit-Queue: Ian Clelland <iclelland@chromium.org> Auto-Submit: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#809826}
-
Nektarios Paisios authored
This is a reland of dc3f7433 After talking with dmazzoni@, we decided to temporarily disable the failing test AXPlatformNodeAuraLinuxTest.TestAtkPopupWindowActive Original change's description: > Reland: Enhances editing event intents by surfacing the input event type from Blink > > This patch was reverted because it was believed that it had caused > a failure on the Linux Ozone bots. > However, after running this patch through all the Ozone bots, no failures were detected. > > Original description: > > For every editing operation in Blink, this patch exposes to the browser and to automation clients > the "type" property of its input event from Blink. > > The enumeration listing event intents was too long, and it included > intents such as paste, type and replace. > To make using intents simpler, the list of commands is now trimmed down to a few > generic ones, such as insert, delete, format and SetSelection. > For intents attached to text changed and text attributes changed events, more information > is now provided in the intent's input_type member. > Values are provided by a new enumeration that uses the same members as the > W3C Input Events Specification. > This makes the information more detailed, accurate, as well as standard's based. > > The TextBoundary and MoveDirection enums were also modified to add the "kNone" member > so that event intents such as "kClearSelection" that have no boundary information and no directionality > need not use them. > > Finally, the equivalent struct that is used by WebKit for event intents on Mac was added, as well as a conversion function. > > AX-Relnotes: n/a. > > Change-Id: I7bc25347e51fc18b730aab84ca01a9eddad8d54f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416459 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808849} TBR=dmazzoni@chromium.org, aleventhal@chromium.org, dtseng@chromium.org, rsesek@chromium.org Bug: 989156 AX-Relnotes: n/a. Change-Id: Ia9871471a0069aef9bd2e94172f04268a53371cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424166Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#809825}
-
Kevin McNee authored
The need to access the WebContents when selecting the UKM source id for ContactsManagerImpl appears to be from before the introduction of RenderFrameHostImpl::GetPageUkmSourceId. The WebContents is now only used to check whether there is a native window. This logic seems unrelated to UKM source id selection, since there is already code that checks for the existence of the native window to show a dialog in ContactsProviderAndroid. Noticed while auditing uses of WebContents::FromRenderFrameHost. Bug: None Change-Id: I68f652ad3c3cb2c40571bde59c7ea3e50618f7b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422484Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#809824}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ifebf3b167a1bcfaa06ed9e684af5815ead2f38b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426293Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809823}
-
Peter Kasting authored
Bug: 772945 Change-Id: I56e6861493cf4c28f655c4eab277b4172911bf91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425152Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#809822}
-
rbpotter authored
Note: in_files lists were generated (other than OS specific exceptions) using a local script, from settings_resources_v3.grdp Bug: 1128583 Change-Id: I202863a667f706166abe150decd36fd82df10143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424902Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#809821}
-
Thomas Tellier authored
Bug: 1006433 Change-Id: I314c0a76c080a59322c72ee388b4b50a1d88b6bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422943 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#809820}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d937502d15b9..06f3474ec4dc 2020-09-23 hjd@google.com Merge "Revert "Make GuessTraceType more selective about proto traces"" 2020-09-23 hjd@google.com Merge "Make GuessTraceType more selective about proto traces" 2020-09-23 lalitm@google.com Merge "perfetto: bump integration test timeout" 2020-09-23 fmayer@google.com Merge "Allow to specify separate sampling interval per heap." 2020-09-23 taylori@google.com ui: Fix logs panel If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:169121849 Tbr: perfetto-bugs@google.com Change-Id: I6a125e9a56f643aa737f31f45d5b7f7abeb8d0ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426289Reviewed-by:
-
Asanka Herath authored
UseCounter names may be reused for multiple APIs. However for the purposes of the identifiability study, we need to keep samples from different APIs in distinct buckets. Bug: 973801 Change-Id: I4ee69e6c5317a177e636f4627fa1326aa9a180e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426725 Auto-Submit: Asanka Herath <asanka@chromium.org> Reviewed-by:
Dylan Cutler <dylancutler@google.com> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#809818}
-
Domenic Denicola authored
Cross-origin access *via* document.domain is automatically prohibited by the rest of the Chromium infrastructure. However, the other effects of document.domain need to be explicitly no-op'ed. Bug: 1042415 Change-Id: I1957c924f31c985d988988c06368323aa508a19c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419144Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#809817}
-
Matt Falkenhagen authored
Support from throttling was added in r782103, so update the network annotation about policies. This copies the annotation code and text from NavigationURLLoaderImpl, etc. Bug: 1095842 Change-Id: I9ed3baf495eafc16ed375bd23493f2e855fd8313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425689 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#809816}
-
danakj authored
The Convert*ToDIP() and Convert*ToPixel() functions are problematic in that they hide what decision is being taken in the underlying code when moving from floating point to integer, and consumers should be thinking about what they want for correctness. They also act in inconsistent ways when converting a Rect vs its components. This removes the functions that perform float->int conversions in order to have callers show what they intend to happen and make it clear that data is being lost in some fashion. R=sky@chromium.org Bug: 1130050 Change-Id: I2bbe5ff2b85cc4c643ec66fe09a8208e643c3329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418568 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#809815}
-
Joshua Pawlicki authored
Callers ought to call --install and then register over IPC. Bug: 1131080 Change-Id: Iacdebfcc0eb8e1ebee8877459d83e06c819bef33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424149 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#809814}
-
Tanmoy Mollik authored
ProfileDataCache attempts to access ProfileData from ProfileDataSource without first registering an observer. Detailed stack trace is linked to the bug. Bug: 1131499 Change-Id: Ifdfcedf1c4974a2cb3812ecaef93c4f490a01e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426503 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#809813}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/aac41bd6780a..81d691852dc8 2020-09-23 asapersson@webrtc.org SsrcEndToEndTest: Configure bitrate via VideoEncoderConfig. 2020-09-23 alessiob@webrtc.org AGC2 saturation protector: extra margin added by level estimator If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9983dea6a4a720e7c59e191d2f163737fef15f75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426288Reviewed-by:
-
Saurabh Nijhara authored
The OOBE screen priority feature (kOobeScreensPriority) has been kept enabled by default for a couple of releases. This CL removes the feature flag as it seems safe to do so now. Bug: 1064271 Change-Id: I3becf0a1375cfd1a302a71917d8b308199747df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424222 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#809811}
-
Ian Clelland authored
This is in preparation for the change in feature policy header semantics, where the default behaviour will be different when only the header (and not the allow attribute) is used. To make the changes clearer, the two cases are split now. The comments for the combined header+allow policy tests are updated to clarify why each case is returning true or false as well, so that future changes will be more easily understood. Bug: 1095641 Change-Id: Ic615558e19d47e1aee699ec4ac2c3eb8614339a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424657 Commit-Queue: Charlie Hu <chenleihu@google.com> Auto-Submit: Ian Clelland <iclelland@chromium.org> Reviewed-by:
-
Olivier Yiptong authored
There is a chance that RFHI may be gone when the static method FromID is called. This guards against that eventuality. Bug: 1043306 Change-Id: Ief88320e139a7ae69a4f4ec9a60e914809875c15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425171 Commit-Queue: Nasko Oskov <nasko@chromium.org> Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#809809}
-
DongJun Kim authored
This patch implements WebContentsUserData in PaymentAppProviderImpl include below changes. - PaymentAppProviderImpl will be owned WebContents rather than it being a singleton. - GetSourceIdForPaymentAppFromScope, IsValidInstallablePaymentApp are moved out PaymentAppProviderUtil class. This is a simple helper class that is not related WebContents. Bug: 1075687 Change-Id: I62d212a53506e40bc104e59a18540898fd591946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282824Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: DongJun Kim <djmix.kim@samsung.com> Cr-Commit-Position: refs/heads/master@{#809808}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3eb813e0cc13..18f4b1c7e31a 2020-09-23 adlai@google.com Revert "Migrate metal tools away from GrContext" 2020-09-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from f39e0f01aa1f to 2a09e89113af (18 revisions) 2020-09-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 1d6daec3 to 9a7bc8d5 (510 revisions) 2020-09-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 52a588f3c9ba to 0b29732cd84f (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: csmartdalton@google.com Test: Test: Test: CQTest: Test: DrawCallPerfBenchmark.Run/vulkan_nullTest: Test: EGLContextASANTest.DestroyContextInUse/ES3_Vulkan Change-Id: Ibd901cf6be8c41d26ea48ba9bcb5acf93d798d7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425902Reviewed-by:
-
Dominic Mazzoni authored
After r808115 (http://crrev.com/c/2415928) there was a corner case where the WebContentsAccessibilityAndroid could change, but the root BrowserAccessibilityManagerAndroid wouldn't be pointing to it. This would manifest as TalkBack not speaking in response to the page changing. Bug: 1126657, 1131356 Change-Id: I99041aeae4e0fc0d643b86c3e99212dce626b9f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425292Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#809806}
-
Lei Zhang authored
Reduce the scode of `kRequiredAbsMtCodes` to a local scope, so it is initialized on first use. Also remove an unneeded included. Bug: 537099 Change-Id: I984919c41d51a04ecbe6a85ddc56bffa9db833ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419916 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#809805}
-
Jesse Schettler authored
Since there's no benefit of passing lorgnette::ScannerCapabilities by value (e.g. copy elision), pass it by const reference. Bug: None Change-Id: Ia9457c83c6aafbf7a52e32bfc1d350100d8e64fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424743Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#809804}
-
Sebastien Marchand authored
This is a reland of 4be5a8c2 Fix: Disabled PGO for the LaCrOS builds as we don't know if it's what we want (vs AFDO). If we decide to use PGO for LaCrOS then we'll do it in a separate CL. Original change's description: > Switch the Linux official build to PGO (from AFDO). > > This switches the Linux official build from AFDO to PGO. This yield some > 3-4% performance gains on Speedometer and help unifying our desktop > build configurations, PGO is already used on Win and Mac. The PGO > profiles for Linux are generated by a continuous bot and are rolled in > Chrome once or twice per day (AFDO is based on the Android profiles). > > This increases binary size by ~3-4%. > > Bug: 1111437 > Change-Id: I565eb336fa5ad9480e99808ed49246634255b82d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404620 > Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809040} Bug: 1111437 Change-Id: I3eb551007d66edb4c9ff326c801dda7e0ddd593c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424669Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#809803}
-
Yves Arrouye authored
Replace login events with regular warning logs (which are needed for debugging, as info logs are considered spam). The current logs going to the login log means that debugging issues with zero-touch enrollment or the license packaging OOBE requires one to login, go to chrome://device-log and select login events. This is rarely possible. Moreover, login logs are not available through debug logs sent by customers, making debugging very complicated. Bug: chromium:1128982 Test: Reset a device to factory state, observe proper logging Change-Id: Ie38506c374187e3dee62ecfe395951b3294b9a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414610 Commit-Queue: Yves Arrouye <drcrash@chromium.org> Reviewed-by:
-
Ian Clelland authored
With an upcoming change to Feature/Permissions Policy, the header alone will no longer be sufficient to delegate permissions to use powerful features in subframes. The iframe allow attribute must be used in conjunction with it. The header can still be used to block delegation. This change updates the Origin Policy WPTs to use the header to block features, rather than to implicitly allow them, which as a test mechanism, will work both before and after the behaviour change. Bug: 1095641 Change-Id: I3e40480a23ebaea942df661b9a3ff233d108e495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425003Reviewed-by:
Domenic Denicola <domenic@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#809801}
-
Elly Fong-Jones authored
Bug: 1131496 Change-Id: If7089f0f68571ab61b47110de9767c8ffd526c8d Tbr: alemate@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425393Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#809800}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ee7ae7aba2c9..edea3d95c996 2020-09-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from d19622688af4 to e7fcc14d450b (1 revision) 2020-09-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 0a863bc36554 to ae8b33cdea62 (1 revision) 2020-09-23 jmadill@chromium.org Isolated script args in restricted trace tests. 2020-09-23 jmadill@chromium.org Suppress two more compute shader tests. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I9a3e903c0b98632dd490025a94195d278e9c1f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426285Reviewed-by:
-
Allen Bauer authored
Bug: <none> Change-Id: Idb6a8fe933c0e71ce4a02e7f4ac5de4241367725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424832Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#809798}
-
Stephen Nusko authored
This has increased to a 7% flaky rate so disable for now. Bug: 1104211 Change-Id: Ie2413d02e00675892ee8956ac411b426773c3c77 No-Try: True TBR: johnchen@chromium.org CC: mythria@chromium.org,tmrts@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426487Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#809797}
-
Andrew Grieve authored
And add some color :) Bug: None Change-Id: I9c5be022139b4732572e16637ab7d29b0b22b36f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424826 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#809796}
-
Christian Biesinger authored
These tests were written by Mozilla. R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1045668 Change-Id: Ic677aa61807a03783c8a70e93dac57de89c7428a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425845 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#809795}
-
Joshua Pawlicki authored
Specifically, the test app should install and register itself by: 1. Call --install on its bundled updater. 2. Use IPC registration to register the test app's presence. Also, this CL unifies the test app appid on Win and Mac, and fixes ownership / initialization issues associated with the test app initializing services prior to updater installation. There are also some minor code cleanups around repeated vs once callbacks. Change-Id: Ib033be4479ded6b83637f24b133eea4f38004fac Bug: 1122773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422138 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
-
Esmael El-Moslimany authored
Bug: 1116329 Change-Id: Idad6c2885c852c6044a591e0a2a3112adead8d7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424383Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#809793}
-
Stephen Nusko authored
This fails ~10% of the time, trying to take a memory dump. Disable until this is investigated. No-Try: True TBR: johnchen@chromium.org CC: eirkchen@chromium.org,ssid@chromium.org Bug: 1095610 Change-Id: I7303d2b91e7ed6c7addf4be0a19bf6fd0e9336d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426606Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#809792}
-
Findit authored
This reverts commit 7ff62f12. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 809777 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzdmZjYyZjEyMGUyNTUzMmRmYWU2NjAzNTE0NTJiN2JkODM3MzM3NjQM Sample Failed Build: https://ci.chromium.org/b/8868354221177409968 Sample Failed Step: compile Original change's description: > Report installation stages in increasing order > > This CL reports the installation stages for force installed extensions > in an increasing order. This is done in order to investigate > the extensions stuck in CREATED stage. > > Bug: 989526 > Change-Id: I82e07f30c6768c7bde30a76b61b9987173f76fbd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421375 > Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> > Reviewed-by: Oleg Davydov <burunduk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809777} Change-Id: I692551b411e6f50b1a75e54c9d941920e0a370c2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 989526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424816 Cr-Commit-Position: refs/heads/master@{#809791}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I2573d65f79ca9371e00ec1aa9f2c23f4a0c26b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425355Reviewed-by:
-
danakj authored
The Convert*ToDIP() and Convert*ToPixel() functions are problematic in that they hide what decision is being taken in the underlying code when moving from floating point to integer, and consumers should be thinking about what they want for correctness. They also act in inconsistent ways when converting a Rect vs its components. This removes the functions that perform float->int conversions in order to have callers show what they intend to happen and make it clear that data is being lost in some fashion. R=sky@chromium.org Bug: 1130050 Change-Id: I5fc16143e7425d84ee0d6cfc55b863063d725f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418805Reviewed-by:
-
Yoshifumi Inoue authored
This patch makes |NGInlineNode::ShapeText()| not to reuse partial |ShapeResult| with letter-spacing to avoid applying letter spacing multiple times. In the CL[1], we stop reusing full |ShapeResult| with letter spacing but we reuse partial |ShapeResult|, e.g. before/after replaced text. [1] http://crrev.com/c/2397105 Make NGInlineNode::ShapeText() not to reuse ShapeResult for letter-spacing Bug: 1124446, 1130611 Change-Id: I6132d0106038cb7d8ba8cf6ac02493e903804f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423648 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Gang Wu authored
This reverts commit 9183c032. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester Original change's description: > Make LayoutManager observer notification async > > The process of supplying OverviewModeBehavior is now async to prevent re-entrancy in OneshotSupplier (as of https://crrev.com/c/2321067). Since observer notification in LayoutManager is synchronous, this creates a race condition where observers miss an update because an event (e.g. a touch event, as in the linked bug) queued before the call to set() can trigger synchronous observer notification before observers can add themselves. > > Bug: 1129783 > Change-Id: Ia482a109576539d54f171950468e490972e72bc1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418981 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Xi Han <hanxi@chromium.org> > Commit-Queue: Patrick Noland <pnoland@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809386} TBR=dtrainor@chromium.org,hanxi@chromium.org,pnoland@chromium.org Change-Id: Ic1028b99d727da8bf2b85955745068de1eaa45bd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1129783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426724Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809787}
-
