GitLab

This change passes the basic auth information to android mediaplayer to solve the issue that media with basic auth is not able to play.
Previously MediaInfoLoader and MediaResourceGetter could be ran at the same time. 
However, MediaResourceGetter could miss the credential info if we do that. 
As a result, we should wait until MediaInfoLoader finishes before creating the browser side MediaPlayer.

BUG=319885

Review URL: https://codereview.chromium.org/405663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284535 0039d316-1c4b-4281-b951-d872f2087c98

Enable DCHECKs in Lock and ConditionVariable when compiled
with dchecks_always_on.

Note the correctness of DCHECKs relies on DCHECKs enabled
in both Lock and ConditionVariable. This CL keeps the
condition to enable DCHECKs in ConditionVariable the
same as Lock, to avoid any issues here.

BUG=

Review URL: https://codereview.chromium.org/403803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284534 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369643
TEST=None

Review URL: https://codereview.chromium.org/408853005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284533 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284532 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r13457: (dyen) LLVM Regression tests check for build files instead of empty dirs.
r13458: (noelallen) Update and add GN files to build sel_ldr.
r13459: (jvoung) Remove env cleanser references to obsolete env vars.
r13460: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13461: (hamaji) Non-SFI Mode: Add prctl syscall wrapper
r13462: (hamaji) Non-SFI Mode: Implement IRT fstat
r13463: (hamaji) Correct the return type of TestSuite in timefuncs_test
r13464: (hamaji) syscall_test: Do not test st_atime in the test for fstat
r13465: (earthdok) Implement initial MSan support. Also, adjust ASan build flags.
r13466: (dschuff) pnacl-ld: Do not attempt to parse ELF or bitcode files as linker scripts
r13467: (jvoung) Remove NaClSrpcIsStandalone() function.
r13468: (dschuff) Make testing architecture explicit PNaCl toolchain buildbot script
r13469: (dschuff) Stub out pnacl-opt and pnacl-finalize tools for scons built_elsewhere=1
r13470: (dschuff) Update revision for PNaCl r13392->r13466
r13471: (noelallen) Build nacl_bootstrap_helper and test with GN scons
r13472: (dschuff) Build PNaCl with mingw again
r13473: (earthdok) Zap the NaClSignalContext struct in SignalCatch.
r13474: (dschuff) Update revision for PNaCl r13466->r13472
r13475: (sehr) Munge nacl_helper_bootstrap using python rather than libelf
r13476: (sky) Changes scan_sources not to output on bogus directory
r13477: (dschuff) Reduce debugging metadata for pexe builds in Chrome
r13480: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13481: (hidehiko) Align at 16 bytes for stack for created thread.
r13484: (jfb) Revert "Munge nacl_helper_bootstrap using python rather than libelf"
r13485: (ncbray) Fix untrusted.gypi and build_nexe.py
r13486: (teravest) Split nacl_defines to an importable .gni file.
r13487: (dyen) Actually make package_version include logs when argument is set.
r13488: (jfb) Update revision for PNaCl r13472->r13480
r13489: (hidehiko) Wrap irt_interfaces.h by extern "C".
r13490: (hidehiko) Non-SFI Mode: Implement irt_mprotect.
r13493: (jvoung) Revert "Non-SFI Mode: Implement irt_mprotect."
r13494: (noelallen) Add per-file OWNERS for .gn in this sub directory since per-file only works on the directory the OWNERS is in.
r13495: (noelallen) Fix vc_toolchain.py paths.
r13496: (noelallen) Revert of 7e955d3ab6159dc05a7f255c6daf03847809414a
r13497: (dyen) Implemented Exists for pynacl.LocalStorageCache.
r13500: (hidehiko) Non-SFI Mode: Make elf_loader usable from Chrome.
r13503: (jvoung) PNaCl: Update compiler-rt revision in pnacl/COMPONENT_REVISIONS
r13504: (sehr) Munge nacl_helper_bootstrap using python rather than libelf
r13505: (dschuff) Roll PNaCl toolchain revision back to r13466
r13506: (dschuff) Revert "Fix untrusted.gypi and build_nexe.py"

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_nacl_sdk_build
(omitting linux_rel_precise32 and linux_arm_cross_compile because they're currently broken)

Review URL: https://codereview.chromium.org/404663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284531 0039d316-1c4b-4281-b951-d872f2087c98

This broke compile on android:
http://build.chromium.org/p/chromium/builders/Android/builds/26268/steps/compile/logs/stdio

../android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java:794:
cannot find symbol
symbol  : class DisabledTest
location: class
org.chromium.android_webview.test.AwContentsClientShouldOverrideUrlLoadingTest
    @DisabledTest
     ^
1 error

> Disable a flaky test.
> 
> BUG=395817
> TEST=none
> TBR=joth
> 
> Review URL: https://codereview.chromium.org/408043002

TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/407003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284530 0039d316-1c4b-4281-b951-d872f2087c98

While writing some new tests I ran into some hard to track down failures
that were a result of:
  1) Using AudioBufferConverter due to different input/output rates
  2) Using "int" for all input/output frame counts

For example, DeliverRemainingAudio() would actually over-deliver since
it didn't take the ratio of input/output rates into account.

To help make things better, use the type system to differentiate between
input and output frame counts. In addition, use simpler input/output
rates to make it easier to calculate expected time and frame values.

BUG=370634

Review URL: https://codereview.chromium.org/403003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284529 0039d316-1c4b-4281-b951-d872f2087c98

Previously, the SSL interstitial only displayed this for the non-overridable pages. Now it displays it for all SSL errors.

BUG=

Review URL: https://codereview.chromium.org/407693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284528 0039d316-1c4b-4281-b951-d872f2087c98

Each GuestView derived type is now responsible for managing it's own construction.

BUG=none

Review URL: https://codereview.chromium.org/409603003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284527 0039d316-1c4b-4281-b951-d872f2087c98

Predictor is modified to call functions CanPredictNetworkActionsIO and
CanPredictNetworkActionsUI to comply with user preferences (and consider
network connection state).  This obsoletes Predictor::EnablePredictor.  Also,
bool members Predictor::preconnect_enabled_ and Predictor::predictor_enabled_
now depend solely on command line switches, therefore they are made const.

BUG=334602

Review URL: https://codereview.chromium.org/360733005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284526 0039d316-1c4b-4281-b951-d872f2087c98

Remove the remaining overrides of View::GetEventHandlerForRect()
and instead implement ViewTargeterDelegate::TargetForRect().
Make View::GetEventHandlerForRect() non-virtual.

BUG=391845
TEST=none

Review URL: https://codereview.chromium.org/403963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284525 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/391413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284524 0039d316-1c4b-4281-b951-d872f2087c98

BUG=278919
NOTRY=True

Review URL: https://codereview.chromium.org/375133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284523 0039d316-1c4b-4281-b951-d872f2087c98

This file is used by the cq to measure loads and other stats. We want
changes to it to result in a compile and test.

BUG=383609
TEST=none
R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/403393007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284522 0039d316-1c4b-4281-b951-d872f2087c98

RTCP sender report has a race condition when then current time is
submitted asynchronously (from another process). This caused the value
for DLRR to be negative.

This code is going to be removed it is fine to just suppress this
condition.

BUG=393042
NOTRY=true

Review URL: https://codereview.chromium.org/410433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284521 0039d316-1c4b-4281-b951-d872f2087c98

'WebURLRequest::TargetType' has been dropped in Blink in favor of
'RequestContext' and 'FrameType', matching the Fetch specification's
changes, and allowing both more granularity in various Blink-side checks
and more clarity around the thing that caused a request, and the frame
that the request affects.

This CL should have zero practical effect, as it's simply hoisting the
translation work that 'WebURLRequest::setTargetType' is already doing
up into the content layer to bring us one step closer to removing the
concept entirely.

There's still one call to 'ResourceType::FromTargetType' in
RenderFrameImpl that this CL doesn't remove: that method will be
converted to RequestContext in a future CL.

BUG=390497

Review URL: https://codereview.chromium.org/403323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284520 0039d316-1c4b-4281-b951-d872f2087c98

They were previously only disabled in static_library builds. This is believed
to have been due to problems with old MSVC versions, but it should work now.

This change is relevant for Clang, which currently doesn't support exceptions
on Windows.

Last time I attempted to do this, it broke some tests due to a debug assertion.
Gtest had previously been catching the exception, but with exceptions disabled
it crashed. Those tests were actually broken in static_library Debug builds
too, but we don't seem to have bots for that. After Blink r176189, we no longer
hit that debug assertion, so the tests now pass.

BUG=82385
TEST=blink_platform_unittests --gtest_filter=DateTimeFormatTest.CommonPattern,
     content_browsertests --gtest_filter=RenderViewImplTest.SetEditableSelectionAndComposition
     webkit_unit_tests

R=thakis@chromium.org

Review URL: https://codereview.chromium.org/404853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284519 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395817
TEST=none
TBR=joth

Review URL: https://codereview.chromium.org/408043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284518 0039d316-1c4b-4281-b951-d872f2087c98

> GN chrome/common build, rename enable_printing.
> 
> This adds the missing conditions to the chrome/common GN build file (previously
> only the basic files were there). Some refactoring of the GYP file to make this
> possible.
> 
> Renames the enable_printing flag to printing_mode since this is an integer
> tri-state.
> 
> Minor improvements to chrome/renderer
> 
> R=jamesr@chromium.org
> 
> Review URL: https://codereview.chromium.org/400243003

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/409543008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284517 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395726
TEST=none
TBR=miu

Review URL: https://codereview.chromium.org/410453006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284516 0039d316-1c4b-4281-b951-d872f2087c98

jingle_glue_test_util was added long time ago for P2P API in Pepper.
The API was removed long time ago and we no longer need
jingle_glue_test_util.

Review URL: https://codereview.chromium.org/400093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284514 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395796
TEST=none
TBR=elijahtaylor, asargent

Review URL: https://codereview.chromium.org/405233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284510 0039d316-1c4b-4281-b951-d872f2087c98

A check for unused variables was missing for some helper functions.
The main thing that this affects is the "config" function, where
people were confused when setting deps or configs didn't work the
way they expected (because they were unused).

BUG=392026
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/399143006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284509 0039d316-1c4b-4281-b951-d872f2087c98

This adds the missing conditions to the chrome/common GN build file (previously
only the basic files were there). Some refactoring of the GYP file to make this
possible.

Renames the enable_printing flag to printing_mode since this is an integer
tri-state.

Minor improvements to chrome/renderer

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/400243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284508 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394483

Review URL: https://codereview.chromium.org/398893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284507 0039d316-1c4b-4281-b951-d872f2087c98

This patch is mostly just moving code around. It moves the iterators
from tile manager to be in separate files, renames them to be queues.

It also adds a tile manager client interface for building the queues.

The rest is just fix ups for the tests.

R=reveman

Review URL: https://codereview.chromium.org/406543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284506 0039d316-1c4b-4281-b951-d872f2087c98

The second part of https://codereview.chromium.org/389933004 to disable
some failing unit tests on Windows.

BUG=393733

Review URL: https://codereview.chromium.org/403423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284505 0039d316-1c4b-4281-b951-d872f2087c98

Adds a class ScreenshotTester, which now adds an opportunity to take a screenshot while running a test and then
save it to a directory specified by some switch. it is now fully included in LoginUIVisible test.
Taking screenshots also requires waiting until all the animation finishes loading. To handle with it, a class AnimationDelayHandler
is implemented (in LoginUIVisible).
To turn taking screenshots on,  switch --enable-test-screenshots should be used. To specify the directory where all the screenshots will be
stored, use --screenshot-dest=value, where value is the full path to the directory.
It is planned that working with this class will have two modes: taking a new screenshot and saving it, and taking a screenshot and comparing
it with the previously stored one. Now only the first mode is implemented, and running it also requires a switch --update-golden-screenshots.
Pixel output is usually off in the tests, so before taking screenshots switches --enable-pixel-output-in-tests and --ui-enable-impl-side-painting should be also used. 

BUG=395653

Review URL: https://codereview.chromium.org/405093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284504 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393177
TEST=none
TBR=erg

Review URL: https://codereview.chromium.org/402213006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284502 0039d316-1c4b-4281-b951-d872f2087c98

Reverting in hopes of getting android telemetry_perf_unittests to
green. Here's output:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/14733/steps/telemetry_perf_unittests/logs/stdio

Unhandled exception while running file://scrollable_page.html

Traceback (most recent call last):
  _RunPage at tools/telemetry/telemetry/page/page_runner.py:533
    test.RunPage(page, page_state.tab, results)
  RunPage at tools/telemetry/telemetry/page/page_test.py:228
    self.WillRunActions(page, tab)
  WillRunActions at tools/perf/measurements/smoothness.py:26
    self._power_metric.Start(page, tab)
  Start at tools/perf/metrics/power.py:77
    self._browser.platform.StartMonitoringPower(self._browser)
  StartMonitoringPower at
  tools/telemetry/telemetry/core/platform/__init__.py:193
    self._platform_backend.StartMonitoringPower(browser)
  StartMonitoringPower at
  tools/telemetry/telemetry/core/platform/android_platform_backend.py:251
    self._powermonitor.StartMonitoringPower(browser)
  StartMonitoringPower at
  tools/telemetry/telemetry/core/platform/power_monitor/android_temperature_monitor.py:31
    self._power_monitor.StartMonitoringPower(browser)
  StartMonitoringPower at
  tools/telemetry/telemetry/core/platform/power_monitor/power_monitor_controller.py:29
    self._active_monitor.StartMonitoringPower(browser)
  StartMonitoringPower at
  tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py:33
    'Must call StopMonitoringPower().')
AssertionError: Must call StopMonitoringPower().


> Add FailureValue and wire it through PageTestResults.
> 
> BUG=392901
> 
> Review URL: https://codereview.chromium.org/399263003

TBR=chrishenry@google.com

Review URL: https://codereview.chromium.org/393713005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284497 0039d316-1c4b-4281-b951-d872f2087c98

To prepare for menus overlapping anchors, add the dismiss menu button to the menu.

BUG=375379
NOTRY=true

Review URL: https://codereview.chromium.org/381133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284496 0039d316-1c4b-4281-b951-d872f2087c98

This broke the linux gn bot:

http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/9676/steps/compile/logs/stdio

[824/4367 | 164.256] CXX
obj/media/video/capture/media_unittests.fake_video_capture_device_unittest.o
FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++
-Wl,--fatal-warnings -m64 -fPIC -Wl,-z,noexecstack -Wl,-z,now
-Wl,-z,relro -B../../third_party/binutils/Linux_x64/Release/bin
-Wl,--icf=none -pthread -Wl,-rpath=\\\$ORIGIN/lib/
-Wl,-rpath-link=lib/ -o ffmpeg_unittests -Wl,--start-group
@ffmpeg_unittests.rsp  -Wl,--end-group  -ldl -lasound -lX11
-lXcomposite -lXcursor -lXdamage -lXext -lXfixes -lXi -lXrender -lXss
-lXtst -lgmodule-2.0 -lgobject-2.0 -lgthread-2.0 -lrt -lglib-2.0
-lnss3 -lnssutil3 -lsmime3 -lplds4 -lplc4 -lnspr4 -lfontconfig
-lfreetype -lpangocairo-1.0 -lpango-1.0 -lcairo 
obj/media/base/media_test_support.test_data_util.o:../../media/base/test_data_util.cc:function
media::StartMediaHttpTestServer():error: undefined reference to
'net::BaseTestServer::kLocalhost'
obj/media/base/media_test_support.test_data_util.o:../../media/base/test_data_util.cc:function
media::StartMediaHttpTestServer():error: undefined reference to
'net::LocalTestServer::LocalTestServer(net::BaseTestServer::Type,
std::string const&, base::FilePath const&)'
obj/media/base/media_test_support.test_data_util.o:../../media/base/test_data_util.cc:function
media::StartMediaHttpTestServer():error: undefined reference to
'net::LocalTestServer::Start()'
clang:error: linker command failed with exit code 1 (use -v to see
invocation)
...

> Have media content and chrome browser tests load data from media/test/data
> 
> Update remaining encrypted media browser tests to use new player app.
> 
> (This is identical to r282795 which got reverted, i.e. revert of revert).
> 
> The fix was submitted separately in r283757
> 
> BUG=379314
> 
> Review URL: https://codereview.chromium.org/398823004

TBR=shadi@chromium.org

Review URL: https://codereview.chromium.org/405803007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284495 0039d316-1c4b-4281-b951-d872f2087c98

Second phase of extending the relocation packer for arm64.

Add elf_traits.h to define either Elf32 or Elf64 structs and functions
as ELF traits, depending on macro definitions.  Use ELF:: types in place
of Elf32_ (mechanical).

Widen leb128 to handle 64-bit unsigned values, and revise implementation
for better readability and efficiency (and to match sleb128, coming
later).

Change packer and run length encoder functions and function signatures
to handle the Elf types that represent the items they pack and encode
(mechanical).

Move elf_ assignment to the end of ElfFile::Load(), so that it is
assigned only if loading succeeds.

Factor out FindDynamicEntry() to improve readability.

Use ELF_R_INFO() to set r_info in relocations.

Print elf_errmsg() error string on failure to load.

Do full round-trip pack and unpack check with a single memcmp().

Still to do:
  - Add support for relative relocations with addends (RELA).
  - Add new packing strategy for RELA (requires sleb128).
  - Modify relocation_packer.gyp to build both configurations.
  - Extend unit tests to accommodate.

BUG=385553

Review URL: https://codereview.chromium.org/404553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284493 0039d316-1c4b-4281-b951-d872f2087c98

Previously, selection handles on Android were rendered using a PopupWindow
construct.  This is problematic for a number of reasons, the chief being poor
performance and responsiveness. As an alternative, support a native, composited
layer rendering pipeline for selection handles using the browser compositor.
Also port selection handle-related logic from Java to C++, using a
PopupWindow rendering fallback for WebView, lacking a proper browser compositor.

This change depends directly on selection update and visibility routing through
the compositor: https://codereview.chromium.org/300323005/

BUG=380781,135959,279489,393948

Review URL: https://codereview.chromium.org/335943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284491 0039d316-1c4b-4281-b951-d872f2087c98

BUG=387614
TBR=bauerb@chromium.org, tony@chromium.org, oshima@chromium.org

Review URL: https://codereview.chromium.org/402133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284490 0039d316-1c4b-4281-b951-d872f2087c98

Update remaining encrypted media browser tests to use new player app.

(This is identical to r282795 which got reverted, i.e. revert of revert).

The fix was submitted separately in r283757

BUG=379314

Review URL: https://codereview.chromium.org/398823004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284489 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284488 0039d316-1c4b-4281-b951-d872f2087c98

This picks up one new change:
 - "Don't track platform.xml"

Review URL: https://codereview.chromium.org/406013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284487 0039d316-1c4b-4281-b951-d872f2087c98

Profile_metrics doesn't log signed-in metrics for inactive profiles.
However, since mobile platforms never log active times, the signed-in
metrics never get logged.

Reference CLs: (introduced issue as of M35)
https://codereview.chromium.org/134863002/
https://codereview.chromium.org/141663004

BUG=392948

Review URL: https://codereview.chromium.org/405473004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284486 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392205
R=keybuk@chromium.org

Review URL: https://codereview.chromium.org/403343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284485 0039d316-1c4b-4281-b951-d872f2087c98