GitLab

ScriptLoader and related classes use two document.write()-related flags:
- Document::IsInDocumentWrite() at the time of PrepareScript():
  directly checked within PrepareScript() and used for multiple purposes.
- Document::IsInDocumentWrite() at the time of <script> element creation:
  plumbed from HTML parser to ScriptLoader::created_during_document_write_
  and used for DocumentParserTiming.

This CL merges the latter into the former:
- Moves ScriptLoader::created_during_document_write_ to
  PendingScript::created_during_document_write_ which is set to IsInDocumentWrite()
  at the time of PendingScript creation, which is within PrepareScript(), and
- Removes the plumbing of the flag from the HTML parser to ScriptLoader.

Thus this CL simplifies the code by reducing plumbing through ScriptLoader constructor.

Bug: 842349
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2b17dd098bb134a59b9c1ba2937c74bfa46b4c0f
Reviewed-on: https://chromium-review.googlesource.com/1053163
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560739}

In StylesSidebarPane, the 3-dot 'More tools' icon reveals a toolbar on hover.
On 'mouseenter', we set 'display: none' on it, so the following 'mousemove'
determines its bounding rect as {x: 0, y: 0, w: 0, h: 0}, and shows a tooltip
in the top-left of DevTools.

This CL removes the unnecessary tooltip and checks that an element is visible
before showing the tooltip.

Bug: 829342
Change-Id: Ib0268f70dccbb1190916796e1ca6aadaec763e5f
Reviewed-on: https://chromium-review.googlesource.com/1067784Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560738}

Previously we reused the spinner code in download location dialog, this
CL implements new UI in download location preference to use a custom
layout with radio button and text views.

We reuses the adapter to provide the underlying data used by the UI.

Bug: 842464,792775
Change-Id: Iaf68fa3e75d259c9c6e6fd6d79caa1845aaf18b3
Reviewed-on: https://chromium-review.googlesource.com/1062785
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560737}

BUG=none
TEST=none

Change-Id: I1663a6533941bd6fa078abfdf9452bd88652d9ed
Reviewed-on: https://chromium-review.googlesource.com/1069449Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560736}

Bug: 845473
Change-Id: Ib01509ba1ff14c4a693786912b70c79165165c16
Tbr: lushnikov@chromium.org
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1069418Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560735}

This provides an alternate API for starting the underlying
media analytics process. Eventually this will be used instead of
setState in production when most of the communication to the
service is replaced with a Mojo channel.

Bug: 842718, 799739
Change-Id: Ia0cb6c74d580bf2f9b442e2fff8a12d4878f214a
Reviewed-on: https://chromium-review.googlesource.com/1042363Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Luke Sorenson <lasoren@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560734}

This adds support for reporting muted watch time to UKM and UMA. Only
the All, Src, Mse, and Eme keys are reported to UMA, while in UKM the
full foreground keyset is reported with a new IsMuted boolean variable
that functions similarly to the existing IsBackground.

Specifically here are the new UMA keys:
Media.WatchTime.AudioVideo.Muted.All
Media.WatchTime.AudioVideo.Muted.MSE
Media.WatchTime.AudioVideo.Muted.EME
Media.WatchTime.AudioVideo.Muted.SRC

And the only new UKM key is IsMuted.

This functionality is implemented similarly to how background watch
time is reported: a nested WatchTimeReporter is used that is played
and paused when the volume transitions to and from the muted state.

BUG=779192
TEST=updated unittests.

Change-Id: I1127a5bb2e6c03f1a9bba1db94d028c5218a5cbc
Reviewed-on: https://chromium-review.googlesource.com/1056363Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560733}

This is in preparation of rolling iron-flex-layout.html to its latest version.

Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I25d400daa74fe9357a1be072fafaaa4237ed8dd3
Reviewed-on: https://chromium-review.googlesource.com/1068208Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560732}

https://pdfium.googlesource.com/pdfium.git/+log/366df7fd6e6b..7f472cd8abe4

$ git log 366df7fd6..7f472cd8a --date=short --no-merges --format='%ad %ae %s'
2018-05-22 thestig Remove useless CPDFSDK_Widget::SetDefaultValue().
2018-05-22 thestig Fix a regression with missing text.
2018-05-22 thestig Add test case for a font substitution regression.
2018-05-22 npm Order CHKs in alphabetical order within each file
2018-05-22 thestig Remove JBIG2_memcpy() and JBIG2_memset().
2018-05-22 thestig Remove return value from CJBig2_Image::SetPixel().
2018-05-22 thestig Fix method style in JBig2_Image.

Created with:
  roll-dep src/third_party/pdfium
BUG=chromium:820345,chromium:820345


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ie1d03549493d95c1387d28bf3ae85ccfb087aafa
Reviewed-on: https://chromium-review.googlesource.com/1069299
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#560731}

https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/08d5b1f33af8..145d05750b15

$ git log 08d5b1f33..145d05750 --date=short --no-merges --format='%ad %ae %s'
2018-05-21 jdennett Downgrade to C++98.
2018-05-21 jdennett Downgrade to C++98 code.
2018-05-11 steelskin Remove unused variable in Fuchsia.
2018-05-10 jdennett Add support for versioned standard libraries.
2018-05-10 jdennett Update generated code.
2018-05-10 jdennett Add unit test for CanonicalizeForStdLibVersioning.
2018-05-02 scottmg Fix gmock not building when -fno-rtti

Created with:
  roll-dep src/third_party/googletest/src

Bug: 756269
Change-Id: I785635e4cab1b511aed5715dd8b949d813dcf20e
Reviewed-on: https://chromium-review.googlesource.com/1069293Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560730}

That factory was only used for the thread-bouncing in OnModuleLoad(),
which is unnecessary given that the ModuleDatabase is a singleton that
never gets freed.

This fixes a crash where WeakPtrFactory::GetWeakPtr() was called from
multiple threads concurrently, even though it isn't thread-safe.

Bug: 845110
Change-Id: I071ab52d8938922c93eeac6adc4d592669d15ae7
Reviewed-on: https://chromium-review.googlesource.com/1069328
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560729}

Issue reported here: https://github.com/aawc/unrar/issues/11
Upstream fix: https://github.com/aawc/unrar/pull/12
Release: https://github.com/aawc/unrar/releases/tag/5.6.1.8.1

Bug: 750327
Change-Id: Ia418dab88b6215c7daaa0b226e10041e8cbeca3c
Reviewed-on: https://chromium-review.googlesource.com/1069408Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560728}

This reverts commit e6449839.

Reason for revert: Fix the test

Original change's description:
> Revert "Calculate PMF and Swap size in renderer OOM intervention helper"
> 
> This reverts commit 1944df7b.
> 
> Reason for revert: Breaks webkit unittests on Android CFI builder.
> 
> [ RUN      ] OomInterventionImplTest.CalculatePMFAndSwap
> [FATAL:oom_intervention_impl.cc(131)] Check failed: host_.
> [ERROR:test_suite.cc(301)] Currently running: OomInterventionImplTest.CalculatePMFAndSwap
> 
> https://ci.chromium.org/buildbot/chromium.memory/Android%20CFI/1302
> 
> Original change's description:
> > Calculate PMF and Swap size in renderer OOM intervention helper
> > 
> > Record memory footprint values in renderer process with OOM intervention
> > enabled. Make these files Android only.
> > The overhead of calculation is strictly less than 0.06ms. The actual value
> > is difficult to calculate because of trace event overhead being higher.
> > 
> > BUG=843419
> > 
> > Change-Id: Id863a33a9f09a1f6823801b00961939c479631aa
> > Reviewed-on: https://chromium-review.googlesource.com/1063258
> > Commit-Queue: Siddhartha S <ssid@chromium.org>
> > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
> > Reviewed-by: Kentaro Hara <haraken@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#560455}
> 
> TBR=bashi@chromium.org,haraken@chromium.org,ssid@chromium.org
> 
> Change-Id: I8fd58ea40474207b6f561680ce69a492ea117037
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 843419
> Reviewed-on: https://chromium-review.googlesource.com/1069069
> Reviewed-by: Balazs Engedy <engedy@chromium.org>
> Commit-Queue: Balazs Engedy <engedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560549}

TBR=engedy@chromium.org,bashi@chromium.org,haraken@chromium.org,ssid@chromium.org

Bug: 843419
Change-Id: Ic5ac3dd51660db99618f5d31c551cd7f7bfe8123
Reviewed-on: https://chromium-review.googlesource.com/1068083
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560727}

Previously the KeyboardLockServiceImpl would silently fail if the
keyboard lock request failed in some cases (we returned an error
for some scenarios but not all).

This change will ensure that if the keyboard.lock() promise succeeds,
the request was registered successfully.

BUG=680809

Change-Id: I65228603592a871173e6df4a1c265b14fc6a6d8f
Reviewed-on: https://chromium-review.googlesource.com/1066699
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560726}

Add a DCHECK in EmbeddedFrameSinkProviderImpl that HostFrameSinkManager
instance isn't null. This should avoid confusing stack traces happening
later when trying to access HostFrameSinkManager.

Bug: none
Change-Id: I44a3697aa47067663e1c3062f517d2101afdadc2
Reviewed-on: https://chromium-review.googlesource.com/1064718Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560725}

This is a reland of I23ef57eb52bfb1eb363682dadf98c571c12afcd1.

It was reverted in Ia548067acbf640010f4c8fbed29a0012a274af05. Reason for revert:
Findit (https://goo.gl/kROfz5) identified this CL at revision 557680 as the culprit
for introducing flakiness in the tests as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZmM5NTUwMWZiMjllM2U3NDg3ZmZmOThjMTdlNmFhYmExMDQ2YjMzMAw

The data race has been fixed in:
https://chromium-review.googlesource.com/c/chromium/src/+/1064450.

Original change's description:
> Create BrowserThread::IO thread before browser main loop to start
> ServiceManager.
>
> We need a thread to post/execute tasks when starting the
> ServiceManager. This thread needs to be created before the browser
> main loop is initialized, and will be registered as the
> BrowserThread::IO thread which is currently used by ServiceManager
> connections.
>
> The creation of such a thread is moved to service_manager::main via
> MainDelegate::CreateIOThreadAndGetTaskRunner(). Since it requires no
> thread created before calling fork() on posix, we also move the setup
> of sandbox before creating the IO thread.
>
> Bug: 740677, 729596
> Change-Id: I23ef57eb52bfb1eb363682dadf98c571c12afcd1
> Reviewed-on: https://chromium-review.googlesource.com/969098
> Commit-Queue: Xi Han <hanxi@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#557680}


Bug: 740677, 729596
Change-Id: I9afb0cdc0f11a1d437c2e9bd09c374503c3d5a4b
Reviewed-on: https://chromium-review.googlesource.com/1059949Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560724}

It seems I've missed regenerating the generated files which
happened after tweaking enum values only.

Bug: b/70666810
Test: manually
Change-Id: Ib819f0ac0c4e911ab161ad0c118978784e981623
Reviewed-on: https://chromium-review.googlesource.com/1068107
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560723}

We were calling the version of OpenMatch() that did not take an index,
which opened the result view that was "selected" (highlighted). But
with the tab switch button present, the user can click on a result
that is not the selected result. By passing the view's index, this
opens the specific URL that the user chose explicitly.

Bug: 780835
Change-Id: Ie60e28a2106f3ad581aa640dad7ee5d134dee4ed
Reviewed-on: https://chromium-review.googlesource.com/1069305Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560722}

Chrome will crash when the user removes the SD card on certain Android
devices while downloading file to SD card, since closing file
descriptor will throw error.

Instead, on Android, we should tolerate this error as same as other
linux kernel based OS.

Bug: 844148,792775
Change-Id: I293fdcb4fd5277394efab6bca72089feb287cee0
Reviewed-on: https://chromium-review.googlesource.com/1066185Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560721}

Bug: 844754
Change-Id: If928477917cc9c71c3533793959a143abd34ca7a
Reviewed-on: https://chromium-review.googlesource.com/1067759
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560720}

ScriptLoader and related classes use two start line numbers:
- ScriptLoader::PrepareScript()'s script_start_position argument
  == PendingScript::StartingPosition()
  == ScriptSourceCode::StartPosition().
- ScriptLoader::start_line_number_ which is set to
  GetScriptableDocumentParser()->LineNumber() at ScriptLoader construction, and
  which is used for CSP error reporting, and

This CL merges the latter into the former, because the former is more broadly used.

This is for consistency and code simplification.

Bug: 842349
Change-Id: I7fb945d7bf6ce40ac670234637e816a368c17c84
Reviewed-on: https://chromium-review.googlesource.com/1053159
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560719}

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ia0d0a387c21c683f2bf3882aaddc9b947a3e1375
Reviewed-on: https://chromium-review.googlesource.com/1069262
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560718}

Add Yahoo Mail and Viber as potential sources of external intents.

Bug: 844651
Change-Id: I3f197b600d60861abec29b4a5ab8f778a41496eb
Reviewed-on: https://chromium-review.googlesource.com/1066693Reviewed-by: Troy Hildebrandt <thildebr@chromium.org>
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560717}

Screenshot: https://imgur.com/a/e1J1Cyp

Bug: 803891
Change-Id: Ibc1ffb9990dcc76d16dce0128b0dc84b74b0c929
Reviewed-on: https://chromium-review.googlesource.com/1068264Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560716}

OfflinePageRequestJob and OfflinePageURLLoader (will be added in next
patch to support network servicification) will create and hold
OfflinePageRequestHandler. The specific behaviors for url request job
and url loader are encapsulated in OfflinePageRequestHandler::Delegate
which will be implemented accordingly.

OfflinePageRequestHandlerTest is also to pull out common testing code.
For now, only one type OfflinePageRequestJobBuilder is added to test
OfflinePageRequestJob. I will add a new type to test new URLLoader in
next patch.


Bug: 841617
Change-Id: I1cd9b8e03358bc18d6d08e2d038be579de10dc42
Reviewed-on: https://chromium-review.googlesource.com/1058449
Commit-Queue: Jian Li <jianli@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560715}

Adds message_center_unittests to the linux memory bots, and gn_unittests
to Mac Asan 64 on the memory waterfall.

Also adds both tests to many clang tot bots.

This is part of an effort to reduce the number of test configurations.
Originally reviewed as part of https://chromium-review.googlesource.com/1061795,
which I'm now landing in smaller pieces.

TBR=kbr

Bug: 843511
Change-Id: I245a4bad219239007126dbfd99a9b4d6efbdf8fd
Reviewed-on: https://chromium-review.googlesource.com/1069190Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560714}

This is the lowest priority when chosing a TTS voice in tts_controller_impl.

Tested using the TTS settings page with default English voice set to
Chrome OS Indian English, then running:
chrome.tts.speak('hi there i\'m a voice');  // Indian English
chrome.tts.speak('hi there i\'m a voice', {lang: "en-US"});  // US English

Bug: 823359
Change-Id: Ifdbbc3a19e1e2911f3624404555cc13ed271a9c5
Reviewed-on: https://chromium-review.googlesource.com/1064560Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560713}

Default:
- Remove hover borders
- Use light gray color for hover
Dark/Image:
- Use white/light gray for text and blacklist icon
- Use light transparent color for hover

Bug: 837798
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I461dc366a5e82457a6366ae31624f42ad8101a7d
Reviewed-on: https://chromium-review.googlesource.com/1065588
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560712}

ash_util.cc DEPS are non Mash only so are allowed.
Includes some other minor DEPS cleanup.

Bug: 843315
Change-Id: I3b637f041774b36b9b14c654cf15b222e9a8742e
Reviewed-on: https://chromium-review.googlesource.com/1069290Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560711}

This fixes the comment. The function was renamed here:
https://chromium-review.googlesource.com/675443

Bug: 695189
Change-Id: I58854785604b549d741c1a6287f66a767f749c12
Reviewed-on: https://chromium-review.googlesource.com/1067848Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560710}

Looks like this was forgotten in bug 842732. Perfbot sheriff disabling
to green up tree.

Bug: 842732
Change-Id: I5affabbb0a1454dc16614efb8a70a8fd019f49e0
TBR: charliea@chromium.org
NOTRY: true
Reviewed-on: https://chromium-review.googlesource.com/1069332Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560709}

This CL replaces std::move()s whose result is not used, as clang starts
warning that on C++17 mode.

Bug: 752720
Change-Id: I843ba7d9356fdb14fe5cc0c258018fae201a32c6
Reviewed-on: https://chromium-review.googlesource.com/1068639Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560708}

Bug: 845213
Change-Id: Iafa7dde32fc952bc5ab70fef7e348008449fc22b
Reviewed-on: https://chromium-review.googlesource.com/1067852Reviewed-by: enne <enne@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560707}

This reverts commit 4753267b.

Reason for revert: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-simulator/33343 started to fail at PopupMenuMediatorTest.TestElementsTabGrid*

Original change's description:
> Reland "Add blink effect to the PopupMenu"
> 
> This reverts commit 33c637fd.
> 
> Original change's description:
> > Revert "Add blink effect to the PopupMenu"
> >
> > This reverts commit 20a94e7f.
> >
> > Reason for revert:
> > https://bugs.chromium.org/p/chromium/issues/detail?id=844753
> >
> > Bug: 844753
> >
> > Original change's description:
> > > Add blink effect to the PopupMenu
> > >
> > > This CL adds an effect to make the "New Incognito Tab" row of the tools
> > > menu blink a selected state when the in product help requires it.
> > >
> > > Bug: 829344
> > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> > > Change-Id: Ib2345a98f8ec284369b342d111cadf7f6a55adef
> > > Reviewed-on: https://chromium-review.googlesource.com/1057708
> > > Commit-Queue: Gauthier Ambard <gambard@chromium.org>
> > > Reviewed-by: edchin <edchin@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#559481}
> >
> > TBR=edchin@chromium.org,gambard@chromium.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: 829344
> > Change-Id: I7135501ca78396a46d23ec53a538352d77e5c29d
> > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> > Reviewed-on: https://chromium-review.googlesource.com/1066334
> > Commit-Queue: Eugene But <eugenebut@chromium.org>
> > Reviewed-by: edchin <edchin@chromium.org>
> > Reviewed-by: Eugene But <eugenebut@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#560106}
> 
> Bug: 844753, 829344
> Change-Id: Ibaf0e5cb3938a58021105d14b8d9d60e08372e06
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Reviewed-on: https://chromium-review.googlesource.com/1068727
> Reviewed-by: edchin <edchin@chromium.org>
> Commit-Queue: Gauthier Ambard <gambard@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560632}

TBR=edchin@chromium.org,gambard@chromium.org

Change-Id: If2d2bea1069e682ec4e747d6790f68a9e289d7cf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 844753, 829344
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/1067644Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560706}

Bug: 772928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3bab99696087bb61e33bc75a4168a84bceee9ba1
Reviewed-on: https://chromium-review.googlesource.com/1062202
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560705}

Migrated two metrics to use new APIs and flagged other identified
histograms' descriptions to highlight issue on dashboards (I will
email relevant owners after this lands).
Relevant metrics list extracted from https://crbug.com/807615#c19

R=asvitkine@chromium.org, fdoray@chromium.org

Bug: 807615
Change-Id: I84f0f8fb5ca7fd3c5b43ba7209693b89928ade07
Reviewed-on: https://chromium-review.googlesource.com/1062830
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560704}

Bug: 845555
Change-Id: I029cf1f8e916b41febc69824d637a459c0d38921
TBR: charliea@chromium.org
NOTRY: true
Reviewed-on: https://chromium-review.googlesource.com/1069313Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560703}

These metrics are incorrect because they detect MAIN vs non-MAIN behaviour wrong
since the intent gets updated in onNewIntent(), but we set the intent in
onStart(). These are also incorrect because they get recorded every time
we call onStart(), which means that when we go to settings and come back
we would record the metric again.

Bug: 838388
Change-Id: Id8bb7b3401c8103029d5b397a57bb1f07dc56b26
Reviewed-on: https://chromium-review.googlesource.com/1062937Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560702}

Have VideoResourceUpdater delete recycled video plane resources if
they're the wrong size. This is mainly an issue for software compositing
where VideoResourceUpdater always has to allocate plane resources
itself, but if the video size changes then we'd have extra plane
resources that aren't freed until the user navigates away from the
video.

Bug: none
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I09e39eec246c1304ae72cf9aad1486abedbcd7c1
Reviewed-on: https://chromium-review.googlesource.com/1003215
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560701}

fido_constants.h device::to_string was declared as constexpr,
but NOTREACHED expands in non-official builds to calls that cannot
be used inside a constexpr in GCC.

We take the opportunity to rename the method to CredentialTypeToString
to avoid namespace polution (and match style guide).

Change-Id: I9b166ce9a3d7a2213fd81fb045e4a0709f62e426
Reviewed-on: https://chromium-review.googlesource.com/1065895Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Cr-Commit-Position: refs/heads/master@{#560700}