- 14 Oct, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602633476-0a6cb13b3824485740d2ed9816cdaa54debab52e.profdata to chrome-mac-master-1602654939-6aaab1e7299ba115ccc1d7beffbea8c42a27a599.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib11159a977842105389e5a07c5b1d1adf1b58795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469710Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816930}
-
Marc Treib authored
This factory method can also be used for the success case, so the new name is more accurate. This CL also introduces a ForUnspecifiedError() method to replace some instances of ForNetError(0). This CL also removes some TODOs that are obsolete or not worth it. Bug: 951350 Change-Id: I8d1cae97975c5ebdb37075bb666f6e3f3c22884e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467960 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#816929}
-
cfredric authored
This will be used to analyze how much entropy leaked by this API can be used for cross-site tracking. Bug: 973801 Change-Id: I08250b252bf183ab82b782c74328b5886ba385ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445844 Auto-Submit: Chris Fredrickson <cfredric@google.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#816928}
-
Viktor Semeniuk authored
This change moves password editing from the PasswordManagerPresenter to the SavedPasswordsPresenter so it is accessible for all platforms. Bug: 377410 Change-Id: I2b52f3f1233224329cefdc707a50a4a981220bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435105 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#816927}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/99446001182c..c5d2a2fe5321 2020-10-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from df6b7298bb41 to bd0d3f9c4ff8 (15 revisions) 2020-10-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from c4100566 to 7cb4c97a (455 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: I081c1a7e78045cde8871c216c3107334ab434954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470476Reviewed-by:
-
Swapnil Gupta authored
This reverts commit b505ee27. Reason for revert: crbug/1138138 Original change's description: > Lookalikes: Record histogram only once per navigation > > NavigationSuggestion.Event histogram records each lookalike domain in > a redirect chain as a separate entry. This slightly overcounts lookalike > matches. This CL changes the histogram name to > NavigationSuggestion.Event2 and records only one entry per navigation. > > Bug: 1136296 > Change-Id: I5b947d387f3dbc2bef1a95d4171c9ff22526d0f9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459430 > Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Chris Thompson <cthomp@chromium.org> > Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816816} TBR=meacer@chromium.org,asvitkine@chromium.org,cthomp@chromium.org,jdeblasio@chromium.org Change-Id: I88299421401417b47744966fd23d6736491c27fe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1136296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470063Reviewed-by:
Swapnil Gupta <swapnilgupta@google.com> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#816925}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/072e187b21bb..5ae4ed8c588c 2020-10-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I69e8838820a5b34b0d60495b37c7fd4a3de9626e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469709Reviewed-by:
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //services/device. R=blundell@chromium.org Bug: 1113033 Change-Id: I8196affb680eb6c7c1bfd07f6ea27db93d13cf42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469359 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#816923}
-
François Beaufort authored
This CL makes sure the Picture-in-Picture always open in the same display as the originated web contents. This does not apply when the Picture-in-Picture window is already visible. Change-Id: Ie61439927d5a7d02ae7ef0ed3979a316901f9834 Bug: 1135517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450197 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#816922}
-
Rushan Suleymanov authored
Removed histograms: * Bookmarks.CreateBookmarkIndexTime * Bookmarks.DecodeTime * Bookmarks.DuplicateAndEmptyTitleDetectionTime Bug: 993078 Change-Id: I176bc52a69b24fa2cca65d3de097a2fffb4393ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463576Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#816921}
-
Swapnil authored
This reverts commit b3d6fee5. Reason for revert: crbug/1138121 Original change's description: > Reland "Enable fetch send ArrayBuffer more than 128 MB" > > This reverts commit 77bfcdcd. > > Reason for reland: added Linux SlowTests expectations. > > Original change's description: > > Revert "Enable fetch send ArrayBuffer more than 128 MB" > > > > This reverts commit 96c04c00. > > > > Reason for revert: crbug.com/1136750 > > > > Original change's description: > > > Enable fetch send ArrayBuffer more than 128 MB > > > > > > This CL introduces mojo_base.mojom.BigBuffer instead of array<uint> > > > so that fetch can send big ArrayBuffer. > > > > > > Bug: 919361 > > > Change-Id: I45c3c560ca787858453c677cc0c7fbc8c1983063 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415810 > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > > > Commit-Queue: Yoichi Osato <yoichio@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#815479} > > > > TBR=kinuko@chromium.org,rockot@google.com,yhirano@chromium.org,yoichio@chromium.org > > > > Change-Id: Ie4339d0cf4b709efb961abe569cbe1fa7cb116e3 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 919361 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462908 > > Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> > > Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#815506} > > TBR=kinuko@chromium.org,rockot@google.com,yhirano@chromium.org,hajimehoshi@chromium.org,yoichio@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 919361,1136750 > Change-Id: I11049160e52a93bd7c757ec75eaa035b029124b4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462979 > Commit-Queue: Yoichi Osato <yoichio@chromium.org> > Reviewed-by: Yoichi Osato <yoichio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816800} TBR=yoichio@chromium.org Change-Id: Ifac5bac71f41b8348c8288a5c9da6bd792a2f9a4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 919361 Bug: 1136750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470576Reviewed-by:
-
Noel Gordon authored
DevToolsAgent emits a Runtime.executionContextsCreated "message" when a web page (WebContents) being examined for coverage by DevToolsAgent was created: a V8 instance was created for the web page. At this stage there are no scripts on the page, so we clear script_ and then subsequently: a Debugger.scriptParsed "message" is emitted for all scripts loaded by the web page (we store the details to script_). These emitted DevToolsAgent messages appear in the same order always so write the "message" handling code in message arrival order. The context creation message (executionContextsCreated) is first, and then whatever comes next (scriptParsed, ...). No change in behavior. Minor comment change for precision: change // deduplication => // script de-duplication. Tbr: benreich Bug: 1113941 Change-Id: If2817a9baba6635e358fa53e1f49501e3692b245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470283Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#816919}
-
Yunke Zhou authored
Currently we are using href="#" in oobe internal links which actually points to the top of the current page. When ChromeVox is enabled and pressing Search + Space, it focuses on the entire window instead of opening the link. Changed to use action-link so the anchor element works correctly when pressing Search + Space. Bug: 1133745 Change-Id: I103158d9b5774f896d3fbb3829ad5c187657c986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467898 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#816918}
-
Abhijeet Kandalkar authored
This CL converts WidgetMsg_SetViewportIntersection and FrameHostMsg_UpdateViewportIntersection to mojom. FrameHostMsg_UpdateViewportIntersection sends message from a parent renderer to the browser; it then initiates a WidgetHostMsg_SetViewportIntersection from browser to child renderer. This IPC messages are primarily used by the IntersectionObserver API. Bug: 1071582, 1093954 Change-Id: If1f403c37d150bc3165455df40f115bbf091320b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230584Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#816917}
-
Ben Reich authored
Current java code coverage is written into a coverage directory within the out dir on the bots. Changed to devtools_code_coverage to avoid overlap. Test: browser_tests --gtest_filter=*FilesApp* --devtools-code-coverage Bug: 1113941 Change-Id: I4961c0c5dd056e48e81561898e646f2dc3d9095c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470416Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/095444c21262..0150a791fcb7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6d2115d90408c1e3a64783e0a358b4ada2407787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470119Reviewed-by:
-
Bartek Nowierski authored
Instead of exposing raw_size_ptr, which is an implementation detail, better to just use getters and setters, accompanied by CanStoreRawSize(). Also, rename getters and setters, so that it's clear what they do. Change-Id: Idcc46a9e303d0582914c6e8ab111c3051e44946c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467641 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Dominic Mazzoni authored
The generated event gives us everything we need, and this is one fewer specific event that Blink has to worry about. Bug: 699438 Tbr: nasko@chromium.org Change-Id: Ic424a2df9c6f3860dd0b2db720df10df489d73ea AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441980 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#816913}
-
Koji Ishii authored
This patch fixes following issues in blink.natvis: 1. Fix the incorrect condition for the "bare" view of |StringImpl|. 2. Fix the order of `<DisplayString>` for |StringImpl|. The `<DisplayString>` element without `Condition` must come the last, causing a warning message when natvis diagnostic message is enabled. 3. At some point VisualStudio stopped displaying anonymous union, and that the natvis failed to display |NGFragmentItem|. Removed members of the anonymous union, instead, added |Type| and a few other members. Checked with natvis diagnostic message turned on. Change-Id: I25cebc1695434d712d7d5a1a816ae272120d6abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467503Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#816912}
-
Joe Mason authored
R=fdoray Bug: 1080672 Change-Id: Ia7d6d6139daac23a80d824734bde7bdc5c111ae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459567 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#816911}
-
Muhammad Hasan Khan authored
In https://crrev.com/c/2459528 we added a test for container_client_adapter that uses fake session_manager_client therefore we need to ensure that fake works the same way as real. BUG=b:164816080 TEST=components_unittests --gtest_filter='ArcContainerClientAdapterTest*' TEST=revert the fix and ensure that the test fails Change-Id: I271d116d10387cb6b5967378bab3fdea508d6581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461603 Auto-Submit: Muhammad Hasan Khan <mhasank@chromium.org> Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#816910}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/47cbd60f079b..a4b5132faf7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC alancutter@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: alancutter@google.com Change-Id: Iac9dae3e51aec61234e8243133adad7b5918bf9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469708Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816909}
-
Noel Gordon authored
Add SpanToStringPiece helper and use it handle response messages from the devtools agent. This avoids the implicit memcpy under-the-hood of the span to temporary std::string (message) conversion. Minor: remove unused includes, and add base::span, base::string_piece includes. No change in behavior. Tbr: benreich Bug: 1113941 Change-Id: I9a9295230b0a807d3405d70af92cf32ac88cbdaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470280 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Muhammad Hasan Khan authored
This change is needed to ensure that fake behaves the same as real client and we can use it in the unit test to validate that arc instance stopped is not fired on unrelated instance. BUG=b:164816080 TEST=cq Change-Id: Ice5e588b81231ac87b78dafd25188d6629b38bd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469231 Auto-Submit: Muhammad Hasan Khan <mhasank@chromium.org> Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Reviewed-by:
-
Noel Gordon authored
The helper URI encodes a url or any component of a url, so it is a URI string sequence, identical to the web method encodeURIComponent. Let's use |component| arg in its definition and adopt the name for clarity. No change in behavior, no new tests. Tbr: benreich Bug: 1113941 Change-Id: I4c46377656182bc97c04ea91997bbc3b36bfcc5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469920Reviewed-by:
-
Ramin Halavati authored
The criteria for disabling DeleteSoleProfile on Lacros are updated. Bug: 1130131 Change-Id: Ifbb3def8b809c990e12a873ddfc21d92abf4c8ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464931 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#816905}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6b8b2ea6be63..99446001182c 2020-10-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from d1bca09f4ab3 to cac0442277f7 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: If453399602c5f9d0015b22301d068afe79e55d13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469482Reviewed-by:
-
Manas Verma authored
Text now includes "Cashback linked" instead of including the percentage or dollar amount. Bug: 1093057 Change-Id: I53e046a6a495cc4b6cabbf35a8876e940f280b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466142 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#816903}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ad80b184a00d..9580f3b4c530 2020-10-14 jmadill@chromium.org Test Runner: Accept GTEST shard environment vars. 2020-10-14 ianelliott@google.com Vulkan: Remove Arm from perFrameWindowSizeQuery 2020-10-14 jmadill@chromium.org trigger.py: Remove GTest shard env when running one shard. 2020-10-13 jmadill@chromium.org Suppress multisample "max samples" tests on Win/NV/GL. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I45bf9adc253011aaa1b0d98bc23794ab9cb565f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469474Reviewed-by:
-
David Tseng authored
R=akihiroota@chromium.org AX-Relnotes: fixes an issue where ChromeVox would speak changes in a popup button when its value changes even if it didn't have focus. Bug: none Change-Id: Id609af0fb7ee5e99bb9f0c4e0e822ab986db11e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468573Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#816901}
-
Minoru Chikamune authored
[Context] This is a part of an effort to achieve MBI. We want to avoid per-thread task runner as much as possible. [Previous code] AssociatedInterfaceProvider::GetInterface was using per-thread default task runner because task_runner was not specified. [What this CL does] Use the given task runner for AssociatedInterfaceProvider::GetInterface instead of per-thread task runner [Rlated stack trace] base::SequencedTaskRunnerHandle::Get() mojo::internal::GetTaskRunnerToUseFromUserProvidedTaskRunner() mojo::internal::AssociatedInterfacePtrStateBase::Bind() mojo::internal::AssociatedInterfacePtrState<>::Bind() mojo::AssociatedRemote<>::Bind() mojo::AssociatedRemote<>::BindNewEndpointAndPassReceiver() mojo::AssociatedRemote<>::BindNewEndpointAndPassReceiver() blink::AssociatedInterfaceProvider::GetInterface<>() content::RenderFrameImpl::GetFrameHost() content::(anonymous namespace)::ResourceLoadCompleted() content::NotifyResourceLoadCompleted() content::NavigationBodyLoader::NotifyCompletionIfAppropriate() content::NavigationBodyLoader::OnComplete() network::mojom::URLLoaderClientStubDispatch::Accept() network::mojom::URLLoaderClientStub<>::Accept() Bug: 1105403 Change-Id: I20d3e2a7e1ba638a94d30e33d964d8df5f8fd418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462857Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#816900}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1602622713-d22858ceb9d9ad4a4a6268ac3709afaee3037eec.profdata to chrome-win64-master-1602633476-7a781163f6d564d4e8e8516c828c3e90624a360b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I49fb1178caf2cb562932d2a39316c1a502a2f756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469473Reviewed-by:
-
Trent Apted authored
Fixes, ../../ui/file_manager/image_loader/piex_loader.js:357: ERROR - [JSC_UNKNOWN_EXPR_TYPE] could not determine the type of this expression thumbnail: this.createImageDataArray_(view, preview).buffer, ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Bug: 1030935 Change-Id: I97a0f40f9c574e6af82aa5a46a91374db6c357f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470061 Commit-Queue: Trent Apted <tapted@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Trent Apted <tapted@chromium.org> Reviewed-by: -
Hiroki Nakagawa authored
mojom::PrerenderProcessor::Abandon() is a mojo call from a renderer process to the browser process in order to abandon a running prerender, but this is never called. This CL removes the mojo function and relevant functions (e.g., pre-finalizer). > Why is this never called? Abandon() is supposed to be called when a page that has <link rel=prerender> navigates away, etc, and apparently blink::PrerenderHandle::Dispose() calls it. However, actually Dispose() never calls Abandon(). See the following code snippet. void PrerenderHandle::Dispose() { if (remote_processor_.is_bound() && !GetExecutionContext()->IsContextDestroyed()) remote_processor_->Abandon(); Detach(); } Dispose() is called by ContextLifecycleObserver during the context destruction. |remote_processor_| can be unbound at this point because the remote processor is retained with MojoHeapRemote that is supposed to be reset by ContextLifecycleObserver. There is an ordering issue here. Also, even if the remote processor is still bound, IsContextDestroyed() always returns true because Dispose() is called during the context destruction. In another case, Dispose() is called on the pre-finalizer, but this doesn't work as well because PrerenderHandle::Cancel() that resets |remote_processor_| or ContextDestroyed() that calls Dispose() are already called before the pre-finalizer. In summary, both Abandon() and the pre-finalizer are not necessary. This CL removes them. > Mojo connections are managed by MojoHeap variants. Does > PrerenderHandle have to explicitly reset them on the context > destruction? That's not necessary. MojoHeap variants automatically reset the connections on the context destruction. This CL removes ContextLifecycleObserver implementation used for resetting the connections from PrerenderHandle. > Is the browser-side abandon code also never used? No, it's used. Instead of waiting for Abandon() call from a renderer process, PrerenderLinkManager::LinkPrerender in the browser process monitors the connection of mojom::PrerenderProcessorClient and abandons the running prerender on connection destruction. Therefore, this CL doesn't remove the browser-side code. Bug: 1130360 Change-Id: I14555530f98d1fb191b04f387636f58a52484c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462987 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#816897}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/538433c72064..a58a676ab96a 2020-10-14 tsepez@chromium.org Split up xfa/fgas/BUILD.gn by crt/ and font/ directories 2020-10-13 tsepez@chromium.org Move xfa/fxgraphics to xfa/fgas/graphics. 2020-10-13 tsepez@chromium.org Observe CFX_Timer's timer handler objects. 2020-10-13 tsepez@chromium.org Make CJS_Object's ObjDefnID be one-based. 2020-10-13 thestig@chromium.org Use "= default" for constructors. 2020-10-13 tsepez@chromium.org Nest class CPLST_Select as CPWL_ListCtrl::SelectState. 2020-10-13 tsepez@chromium.org Rename fpdfsdk/pwl/cpwl_list_impl.{cpp,h} to cpwl_list_ctrl.{cpp,h} If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1137668 Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ieaaf961c9793fadedd6c848a02344db4012b8da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470296Reviewed-by:
-
Joe Mason authored
Also adds a GetProcessNodeForRenderProcessHostId accessor to PerformanceManager. R=fdoray Bug: 1080672 Change-Id: I3c2ceb14643833867d836c06c8d409889e24ba46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456667 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#816895}
-
Omid Tourzan authored
It fixes the issue of showing remaining time for not supported operation. Also fixes the issue when remaining time displayed if same (identical panel item id) error panel gets updated or reused because not dismissed yet. Bug: 1137229 Change-Id: Ic09e621e8811322ad4602e5d4ecc8fef8f42929c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463100Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Omid Tourzan <oto@chromium.org> Cr-Commit-Position: refs/heads/master@{#816894}
-
Jimmy Gong authored
- Responsible for managing the internal notifications set and sending inline replies for notifications. Bug: 1106937 Test: chromeos_components_unittests Change-Id: I659f3b16c06005d213beb9c2cbe21618f35404c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466980Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ad59e7a16b5d..072e187b21bb 2020-10-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic05a08a549da7b50a274fe2902784daa58f424e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469475Reviewed-by:
-
Alan Cutter authored
This reverts commit e1ec1546. Reason for revert: Test times out on Mac. Bug: 1138084 Original change's description: > Focus WebContents prior to sending focus to renderer for accessibility > > When focus moves from the main WebContents to a guest WebContents, there > currently isn't any mechanism to make sure focus moves to the guest > WebContents. Due to this, the focus call ends up being a no-op which > causes focus not to move along with AT navigation. > > Ensure the guest web contents is focused before performing the rest of > the accessibility focus action which allows it to have the desired > effect. This has to happen whether or not the RenderWidgeHostView > believes it is focused (which it does in a guest web contents that > itself does not have focus). > > The new test is disabled for ozone wayland - it's passing on all other > platforms (including ozone x11) so will probably need an independent > platform-specific fix (tracked by crbug.com/1137626). > > Bug: 1130710 > > Change-Id: Idd5b9709f255b4085a5268ee52dd6375e88e9412 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446789 > Reviewed-by: Lucas Gadani <lfg@chromium.org> > Reviewed-by: Aaron Colwell <acolwell@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> > Commit-Queue: Daniel Libby <dlibby@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#816808} TBR=dmazzoni@chromium.org,acolwell@chromium.org,aleventhal@chromium.org,lfg@chromium.org,dlibby@microsoft.com,kschmi@microsoft.com Change-Id: I3fcf6285ff471e5f99038018c0d86a30ac397ec4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1130710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470059Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#816891}
-
