- 05 Sep, 2019 40 commits
-
-
Juan Antonio Navarro Perez authored
AddMeasurement is the new API that will be used to support ad hoc measurements collected by benchmarks. This also helps clients remove their dependency from legacy Telemetry values. Bug: 999484 Change-Id: I7d03c3380ddc99dce27b2200009d824faca82c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780839Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#693642}
-
Kent Tamura authored
Bug: 242216,922875 Change-Id: I723ff325ec4f6f7ee14a5d95bf5dccf77d916355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782370 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#693641}
-
Friedrich Horschig authored
This CL allows the bubble to extend over the whole length of the screen. The bubble will still be minimal and point to the highlighted item (see screenshot in the linked bug). The cause of the previous misalignment was, that we used chip as a rootview. This results in a very, very restricted area to put the IPH bubble into (basically the chip's rect instead of the whole activity). This also fixes the issue of IPH bubbles having multiple line breaks for small chips. Bug: 1000041 Change-Id: I21537011a190406b57ddd7a5fe513bfa30d7c56f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784718 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#693640}
-
Jit Yao Yap authored
This API function is replaced by chrome.loginState.getProfileType(). The function is currently unused and so is safe to remove. Bug: 995788 Change-Id: I408a81d8f3af032c69700873038cdee4882111bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780733Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#693639}
-
Leon Han authored
This is a reland of 581b273e Original change's description: > [webnfc] Refactor/Refine impl for "Creating Web NFC message" algorithm > > This CL implements strictly the "Creating Web NFC message" algorithm > described at http://w3c.github.io/web-nfc/#creating-web-nfc-message. > > 1. > Changes the Web IDL definition for NDEFRecordData from > "typedef (DOMString or unrestricted double or ArrayBuffer or Dictionary) NDEFRecordData;" > to > "typedef any NDEFRecordData;" > > 2. > Adds verification of NDEFRecordInit when creating NDEFRecord, i.e. makes > NDEFRecord ctor throw exceptions in case of invalid NDEFRecordInit. > Also, the same thing for NDEFMessage and NFCReadingEvent. > > 3. > Changes code flow for Step 10.9 of "9.10.1 The push() method" described > at https://w3c.github.io/web-nfc/#the-push-method. > " > Let output be the notation for the NDEF message to be created by UA, as > the result of passing message to create Web NFC message. If this throws > an exception, reject p with that exception and abort these steps. > " > Previously, > NDEFMessageSource (NDEFMessageInit) -Validity check-> > -Mojo TypeConverter-> Mojom NDEFMessagePtr > Now, > Remove "Validity check" and "Mojo TypeConverter" mentioned above, > instead, we reuse the process of creating NDEFMessage from > NDEFMessageSource (NDEFMessageInit), then the next step converting > NDEFMessage to Mojom NDEFMessagePtr is quite an easy job. > > BUG=520391 > > Change-Id: I628981e556f89ffdd0f883da0cfa99b20a6f8300 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767719 > Commit-Queue: Leon Han <leon.han@intel.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> > Cr-Commit-Position: refs/heads/master@{#693539} Bug: 520391,923974 TBR: dcheng@,reillyg@ Change-Id: I608e28638c0909c9d4f675774514cd990f9878c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787557 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9b3cc3e05337..19b256616d96 git log 9b3cc3e05337..19b256616d96 --date=short --no-merges --format='%ad %ae %s' 2019-09-04 zoddicus@users.noreply.github.com For WebGPU<->Vulkan optimization, set correct execution environment (#2834) 2019-09-04 40687079+rumblehhh@users.noreply.github.com Export SPIRV-Tools targets on installation (#2785) 2019-09-04 jmadill@chromium.org GN: Add Chromium GoogleTest deps. (#2832) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@19b256616d96 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@chromium.org,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,jmadill@chromium.org,jmadill@google.com Bug: None Change-Id: I4f45ef71c638ee96c6515e264f1643aa2f76e08c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787441Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693637}
-
Maksim Sisov authored
This CL adds a simple HeadlessScreen implementation and removes usage of NativeDisplayDelegate. Bug: 891613 Change-Id: I522b500ad32358f4ec7db95e4b58b0774b4cc807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782558 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#693636}
-
Fredrik Söderquist authored
When a nested <use> has not yet finished loading we currently defer the expansion of nested <use> altogether. Instead just build nested <use> that are available, skipping those which are still loading. Bug: 997176 Change-Id: I5d7ab737129af289add4e8a510f248dcfc28720f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768712Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#693635}
-
Kent Tamura authored
This CL changes ScrollbarMode to a |enum class|, and make it possible to do forward declaration. This CL adds a forward declaration of ScrollbarMode to document.h, and removes scroll_types.h include. It reduces the estimated pre-processed size of document.h by 0.23MB. Bug: 242216 Change-Id: I4d9264d156db66ddad65d6cf74b66fc45cec762e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784637Reviewed-by:
-
Marc Treib authored
The test and its PRE_ test both injected a bookmark to the fake server, intending them to be the same bookmark. However, they did not set a server ID for the bookmark entity, meaning they were treated as different entities. Depending on timing (whether Sync had already happened or not), this would trigger an assertion on the number of bookmarks. The fix is to assign a consistent server ID. Bug: 998130 Change-Id: Ic1192e0c51a23f8ef257003ade6f41d237c82463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787538 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#693633}
-
Olga Sharonova authored
This reverts commit 41e42bfb. Reason for revert: Not a root cause Original change's description: > Revert "Update V8 to version 7.8.283." > > This reverts commit ae084e61. > > Reason for revert: chromium build failure https://ci.chromium.org/p/chromium/builders/ci/linux-archive-dbg/3414 > > Original change's description: > > Update V8 to version 7.8.283. > > > > Summary of changes available at: > > https://chromium.googlesource.com/v8/v8/+log/681aa450..9ddd0c4c > > > > Please follow these instructions for assigning/CC'ing issues: > > https://v8.dev/docs/triage-issues > > > > Please close rolling in case of a roll revert: > > https://v8-roll.appspot.com/ > > This only works with a Google account. > > > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel > > > > TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > > > Change-Id: I5efb235167c182e0425b29399372f0f14883e2b1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786898 > > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > > Cr-Commit-Position: refs/heads/master@{#693524} > > TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,v8-waterfall-sheriff@grotations.appspotmail.com > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel > > Change-Id: I71e75ae25f1f4d03b60b843a45f17bec2c151ef3 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787597 > Commit-Queue: Henrik Boström <hbos@chromium.org> > Reviewed-by: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693598} CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,hbos@chromium.org,olka@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I43ca06d8ff4550d013ed9be447aa67f4c66bef56 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787599 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#693632}
-
Ioana Stefan authored
The Protocol Buffer that will be used for storing BackgroundTasks information was added in a previous CL. One information stored in this Protocol Buffer is the extras fields, used when the BackgroundTask is started. It was decided that these extras will be stored in the Protocol Buffer in a new proto message and in a serialized form. This CL adds the necessary changes for transforming the extras from their original representation (Bundle object) to the representation needed in the Protocol Buffer. Tests are also added to check this conversion. Bug: 970160 Change-Id: Ie2acd83b21ecaa51dff5b2c4b74288dac2ae5166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778488Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Ioana Stefan <ioanastefan@chromium.org> Cr-Commit-Position: refs/heads/master@{#693631}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chrome/browser/signin. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=droger@chromium.org Bug: 891670 Change-Id: I5fcbf414f1ca4222ed3a1f58efb358ecab32b40d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786778 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#693630}
-
Matt Falkenhagen authored
This is a follow-up to r691621. It converts code added since then. Bug: 824858 Change-Id: I6aa93cc6f5e2da40e51649c4b0052273db316581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786878Reviewed-by:
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /google_apis/gaia. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=blundell@chromium.org Bug: 891670 Change-Id: I549dadbf2e0cb990ad5f98998a2b2b9f6220caef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787107 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#693628}
-
Juan Antonio Navarro Perez authored
This CL enabled json-test-results to be handled by the results_processor instead of Telemetry. Bug: 981349 Change-Id: Ibe9c31c9839ff858be4d9fb0cb7e6ff77b3c79fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781446Reviewed-by:
-
Henrique Ferreiro authored
Split //services/identity deps into deps and public_deps. Also, fix include files and some build deps. Bug: 970268 Change-Id: I74cfa6dd0b60dec8b1e8ea8236589dc89d1a8703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712872 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
Lowell Manners authored
This test currently fails with "Check failed: !frame_widget_", so it is disabled for now. Change-Id: I52eeffc41cb33271d90424871840b5b8d8f4c5aa Bug: 993337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782899 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#693625}
-
Maksim Sisov authored
There are some methods in DWTHX11, which either have small or zero delta with the methods implemented in DWTHPlatform. Thus, either remove those or move to DWTHPlatform. Bug: 990756 Change-Id: I4780286d1a68844a304f138c5e829b45f6829ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773071 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Jan Krcal authored
This CL adds missing latency metrics for evaluation of the new feature in Beta. Bug: 955475 Change-Id: I1276331337d7c809a076f4b23de7a3a7edd8a910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771602 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#693623}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /services/network. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=yhirano@chromium.org Bug: 891670 Change-Id: I4eb4106b83976f08826467577d34c199cce6f468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787063 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#693622}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/639fcfb29204..63283689f1bf Created with: gclient setdep -r src-internal@63283689f1bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: If159addebf978cb4e2d2e1e5bbbb37f66d154368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787438Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693621}
-
Kenichi Ishibashi authored
ServiceWorkerGlobalScopeProxy was the only subclass that implemented the method but after crrev.com/c/1786523 it became no-op. This is a follow-up CL of crrev.com/c/1775856 Bug: N/A Change-Id: Ic6a2780d135339432d131d73b275c1f94bb8a237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786892Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#693620}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/acfa02ae7732..ebac3a0234ee git log acfa02ae7732..ebac3a0234ee --date=short --no-merges --format='%ad %ae %s' 2019-09-05 zamorzaev@chromium.org cbuildbot: Fix task link for paygen tests Created with: gclient setdep -r src/third_party/chromite@ebac3a0234ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I5350e94c30261cacf586ebaca74810f0cbe83463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786924Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0b526877afe9..99431375c8b5 git log 0b526877afe9..99431375c8b5 --date=short --no-merges --format='%ad %ae %s' 2019-09-05 eseckler@google.com Merge "startup writers: Bound the buffer size per writer" Created with: gclient setdep -r src/third_party/perfetto@99431375c8b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I0ecdc690ef91424f820d43564f98f57a3aa04106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787440Reviewed-by:
-
Mohamed Amir Yosef authored
Change-Id: I8fa5b9a5c7046fb56ed97a08dbd8c369b8663978 Bug: 991510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783151 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#693617}
-
Clemens Hammacher authored
Wasm code GC is enabled by default since https://crrev.com/c/1687535, thus the field trial is not needed any more. R=jwd@chromium.org CC=mstarzinger@chromium.org Bug: 956480 Change-Id: I911faa1109aa76802a15bd2b7df40b3c3f0dc0cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780833Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#693616}
-
Rohit Agarwal authored
Incognito window did not close after clicking on "exit incognito" button for the first time, when a DevTools detached window was open. The |skip_beforeunload| was set to true for incognito profile types for faster exit. However, this resulted in devtools not being informed the main window is closing. The fix is to add BeforeUnloadhandlers checks in the incognito mode if devtools windows are open. Bug: 953217 Change-Id: I3bf0a0b3b4986faab639db073ae093fbcde8406d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774635 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#693615}
-
Richard Knoll authored
This updates the illustration and shows it for all dialog types except the error dialog. The illustration is shown behind the dialog close button above the title. The BubbleFrameView is updated to support this illustration by adding a header view. This view is similar to the existing footnote view and is shown at the top of the dialog, above the title and behind the close button. Bug: 993378 Change-Id: I9d236557c2a3f31197441666e5aae526306e00cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778545Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#693614}
-
Olga Sharonova authored
This reverts commit afa2cbc7. Reason for revert: non_viz_browser_tests failed because of: OAuth2Test.SetInvalidTokenStatus https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/6325 Original change's description: > Backport some tests in /remoting to SingleThreadTaskEnvironment > > These tests were previously migrated from single-threaded MessageLoop to > a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as > part of crbug.com/891670. > > //base OWNERS decided in retrospect that it was better to keep a > single-threaded option for TaskEnvironment and introduced > SingleThreadTaskEnvironment. This CL retrofits that decision for > /remoting. > > This CL is a no-op if it passes CQ. > > This CL was uploaded by git cl split. > > R=jamiewalch@chromium.org > > Bug: 891670 > Change-Id: Id50cc3412d6fbec3e5c71672bf74f6abf0f7332d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786679 > Auto-Submit: Gabriel Charette <gab@chromium.org> > Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org> > Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693548} TBR=jamiewalch@chromium.org,lambroslambrou@chromium.org,gab@chromium.org Change-Id: Ibe96ffa6ddf39371dc64c6ad7236ec366f9331c4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787279Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e333505d7ffb..065dd27357bc git log e333505d7ffb..065dd27357bc --date=short --no-merges --format='%ad %ae %s' 2019-09-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c27b8dde..e96090c3 (693394:693514) Created with: gclient setdep -r src/third_party/webrtc@065dd27357bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I304bf0df2bcf433e37ae4f375aaa216e984b6447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787317Reviewed-by:
-
Andreas Haas authored
This CL cleans up the ArrayBuffer::Slice implementation: * I removed ArrayBuffer::Slice(begin); - This was dead code and not used. * I changed the type of the parameter from {int} to {unsigned}. All calls passed either 0 or a variable of type {unsigned} as parameter anyways. * I removed dead code. * I inlined functions functions that were only called once. I did this cleanup in the context of a V8 refactoring to support huge TypedArrays. Bug: v8:4153 Change-Id: I000e27790c2410d58bdda72341ecb93957a5093d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784605 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#693611}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/06605b01450f..f2c3c6a6ada7 git log 06605b01450f..f2c3c6a6ada7 --date=short --no-merges --format='%ad %ae %s' 2019-09-05 ulan@chromium.org [metrics] Move filtering of GC metrics to the metrics code Created with: gclient setdep -r src/third_party/catapult@f2c3c6a6ada7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:1000187 Change-Id: I12ef9d8d350c14d4bdacf9592aca358d1f6c537e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787439Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/696771ea2808..b0e2347fedfc git log 696771ea2808..b0e2347fedfc --date=short --no-merges --format='%ad %ae %s' 2019-09-05 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-09-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 a1bf69967a32..0c35e0f44dbd (5 commits) 2019-09-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 248662b1..e96090c3 (514 commits) Created with: gclient setdep -r src/third_party/skia@b0e2347fedfc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@google.com Bug: chromium:None,chromium:None Change-Id: Ifa6f12cb7c0c66322c92f4f11d51f09485cb6e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787437Reviewed-by:
-
Olga Sharonova authored
This reverts commit 6683bafc. Reason for revert: Not the root cause of the problem Original change's description: > Revert "[mojo] Simplify BrowserInterfaceBrokerProxy usage" > > This reverts commit 18662d71. > > Reason for revert: broke the tree https://ci.chromium.org/p/chromium/builders/ci/linux-archive-rel/7906 > > Original change's description: > > [mojo] Simplify BrowserInterfaceBrokerProxy usage > > > > This change makes the following updates: > > - ExecutionContext::GetBrowserInterfaceBrokerProxy() is renamed to > > GetBrowserInterfaceBroker() and returns a reference to avoid null checks; > > - Overrides in WebLocalFrameClient, EmptyLocalFrameClient, WorkletGlobalScope and > > NullExecutionContext now return an 'empty' broker that is valid but not > > connected to anything (so remote calls are no-ops). > > > > Also updates existing call sites. > > > > Bug: 718652, 997861 > > Change-Id: I84ec0e254fe4b094379459501e155cb3f74da945 > > > > TBR=staphany@chromium.org > > > > Change-Id: I84ec0e254fe4b094379459501e155cb3f74da945 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775374 > > Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> > > Reviewed-by: Staphany Park <staphany@chromium.org> > > Reviewed-by: Ayu Ishii <ayui@chromium.org> > > Reviewed-by: Raymond Toy <rtoy@chromium.org> > > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#693550} > > TBR=dmazzoni@chromium.org,dcheng@chromium.org,jam@chromium.org,mek@chromium.org,nhiroki@chromium.org,rtoy@chromium.org,oksamyt@chromium.org,staphany@chromium.org,ayui@chromium.org > > Change-Id: Ib569be17b6c78f4284d7155152d35dd5aa4063d3 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 718652, 997861 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787497 > Reviewed-by: Olga Sharonova <olka@chromium.org> > Commit-Queue: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693572} TBR=dmazzoni@chromium.org,dcheng@chromium.org,jam@chromium.org,mek@chromium.org,nhiroki@chromium.org,rtoy@chromium.org,olka@chromium.org,oksamyt@chromium.org,staphany@chromium.org,ayui@chromium.org Change-Id: Iefbec096c457f84006117f0ff29ea75886d1f151 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 718652, 997861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787539Reviewed-by:
-
Hitoshi Yoshida authored
This reverts commit 63c7234e. Reason for revert: Unit test failure (crbug.com/1001018) Original change's description: > Notification scheduler: Add icon database metrics. > > This CL adds icon database metrics, also fixes a typo in > stats::LogImpressionEvent. > > Bug: 963298 > Change-Id: I2fcd44d773166345760ee647c26e464c9ca0f89e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785161 > Commit-Queue: Xing Liu <xingliu@chromium.org> > Reviewed-by: Hesen Zhang <hesen@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693510} TBR=isherman@chromium.org,dtrainor@chromium.org,xingliu@chromium.org,hesen@chromium.org Change-Id: I94b298d9754e4651f757de2ba82a369be6523801 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 963298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786372Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#693607}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chrome/browser/prefs. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=battre@chromium.org Bug: 891670 Change-Id: I8e1135fec9f4a504865151a97ce730532f030228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787077 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#693606}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /content/browser/renderer_host/media. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=tommi@chromium.org Bug: 891670 Change-Id: Iad0205309ee97970a5f2d2585a2a44a825e872fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786952 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#693605}
-
Gabriel Charette authored
Backport some tests in /media/base/audio_renderer_mixer_input_unittest.cc to SingleThreadTaskEnvironment These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /media/base/audio_renderer_mixer_input_unittest.cc. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=tommi@chromium.org Bug: 891670 Change-Id: Ib96c66f6f7c392fec6344c517439234b2d8bc045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786945 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /media/audio. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=tommi@chromium.org Bug: 891670 Change-Id: I9bff22af41a71e1fd0483d76412748a38433da6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787199 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
