GitLab

BUG=657825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2528513003
Cr-Commit-Position: refs/heads/master@{#443142}

If a mousedown event was set to preventDefault() and the focus was
in a text input field, it won't blur the focus from the text input
field, and the following mouseup event will update the TextInputState of
the widget with the same TextInputType and ShowIme::IF_NEEDED.

If this is a minimize button of an app for example, the widget will hide,
but the later received IPC msg to UpdateTextInputState() will cause the
virtual keyboard to show up.

We need to make sure that the virtual keyboard is not shown as a result of
UpdateTextInputState() unless there's a valid text input client.

BUG=430026
TEST=Enable the virtual keyboard from settings. Open feedback app
(Alt+Shift+i) and minimize it. The virtual keyboard should not show.

Review-Url: https://codereview.chromium.org/2626903004
Cr-Commit-Position: refs/heads/master@{#443141}

This is a mechanical change to convert i18n-content to $i18n{} tags.

BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2626083005
Cr-Commit-Position: refs/heads/master@{#443140}

Adds disk configuration calculations that are slightly specialized for
Android, ChromeOS, and general desktop. The max memory space and disk
spaced are set based on the total RAM and disk of the device.

BUG=375297

Review-Url: https://codereview.chromium.org/2552153002
Cr-Commit-Position: refs/heads/master@{#443139}

Manual Revert of Reland: chromeos: Fix shelf appearing at login screen under mash (patchset #7 id:140001 of https://codereview.chromium.org/2625733003/ )

Reason for revert:
compile broken and reverting https://codereview.chromium.org/2628973002 didn't seem to fix it.

Original issue's description:
> Reland: chromeos: Fix shelf appearing at login screen under mash
>
> The reland adds a fix for a crash in window animation code when restoring
> a session that has a minimized window. The animation tries to compute a
> shelf item position before the shelf is initialized. The animation is not
> visible to the user. Returning an empty rect results in a default target
> position, which is fine in this case.
>
> Added guards for access to ShelfView before shelf is initialized.
>
> Original CL description:
>
> Previously chrome --mash would always create the shelf on startup, even at
> the login screen. Now it waits until login is complete, like classic ash.
>
> Ash watches for SessionState::ACTIVE via a SessionStateObserver to create the
> shelf, rather than NOTIFICATION_LOGIN_USER_PROFILE_PREPARED. For most login
> flows this doesn't matter, but for supervised user creation it means that the
> shelf is not created until the flow is completed. This is an improvement
> because in the old code the shelf would be created too early and had to be
> explicitly hidden.
>
> Always create a SessionControllerClient in chrome, even in classic ash. This
> allows classic ash to use the mojo pathway via ash::SessionController.
>
> Remove WmShell::ShowShelf(), which was introduced in crrev.com/10693003 to
> delay showing the shelf until post-login OOBE (like avatar picture select)
> was complete. It does not seem to be needed anymore, either in production or
> in tests.
>
> Change AshTestImplMus to simulate a user logging in which is required to
> create the shelf on the primary display and also to have a non-zero user
> count to create the shelf on additional displays.
>
> Remove some unnecessary OS_CHROMEOS ifdefs in //c/b/ui/ash.
>
> BUG=666021, 679513
> TEST=ash_unittests and chrome browser_tests
>
> Committed: https://crrev.com/7f99e933e595824281102ff6737075dccbbc4d5c
> Cr-Commit-Position: refs/heads/master@{#439845}
>
> Reverted:
>
> Review-Url: https://codereview.chromium.org/2619943002
> Cr-Original-Commit-Position: refs/heads/master@{#442484}
> Review-Url: https://codereview.chromium.org/2625733003
> Cr-Commit-Position: refs/heads/master@{#443106}
> Committed: https://chromium.googlesource.com/chromium/src/+/75298de72cf7c25e137c3c5e63e4d01aa0569c1c

TBR=msw@chromium.org,xiyuan@chromium.org,sky@chromium.org,jamescook@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=666021, 679513

Review-Url: https://codereview.chromium.org/2627243003
Cr-Commit-Position: refs/heads/master@{#443138}

This allows them to be used on iOS.

This CL also makes estark@ and lgarron@ owners of page info strings.

BUG=679976

Review-Url: https://codereview.chromium.org/2620123003
Cr-Commit-Position: refs/heads/master@{#443137}

destructor, instead of in the middle of a loop(?!) in the destructor.

BUG=679968

Review-Url: https://codereview.chromium.org/2625813004
Cr-Commit-Position: refs/heads/master@{#443136}

Review-Url: https://codereview.chromium.org/2625233003
Cr-Commit-Position: refs/heads/master@{#443135}

R=dpapad@chromium.org
BUG=680336
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2623363002
Cr-Commit-Position: refs/heads/master@{#443134}

The CSSValue must be a CSSPrimitiveValue containing a CSSCalcValue.

For example:
testElement.style.width = "calc(4 * (5em - 2px))";
testElmenet.styleMap.get('width');
// Returns CSSCalcLength({px: -8, em: 20})

Also removes redundant test typedcssom/inlinestyle/left-top-right-bottom.html
(superceded by typedcssom/inlinestyle/properties/bottom.html; will
add the others later)

BUG=545318

Review-Url: https://codereview.chromium.org/2371673002
Cr-Commit-Position: refs/heads/master@{#443133}

FloatRect::enclosingIntRect is hot on blink_perf.paint's paint offset
microbenchmark. A similar change to inline LayoutRect::enclosingIntRect[1]
was a large perf win [2] and this patch should have similar benefits.
There are relatively few callers so the risk of binary bloat is low.

enclosedIntRect and roundedIntRect are two additional candidates for
inlining but I'd like to separate these changes so we can measure
the impact (perf, binary) independently.

[1] https://crrev.com/af2c8d1e6a537c356b4cf931bb5aca1e5f09f119
[2] https://chromeperf.appspot.com/group_report?rev=436323

BUG=678597

Review-Url: https://codereview.chromium.org/2628903003
Cr-Commit-Position: refs/heads/master@{#443132}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/dcd70be386e3..d71b47153f16

$ git log dcd70be38..d71b47153 --date=short --no-merges --format='%ad %ae %s'
2017-01-11 dtu [pinpoint] Explicitly differentiate between missing and empty parameters.

BUG=680266

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2628003003
Cr-Commit-Position: refs/heads/master@{#443131}

Collected cookies when invoked from the site info bubble (padlock ->
Cookies -> click the "X in use" link) is already hooked up to
--secondary-ui-md. However, it can also be shown via the content
settings bubble when a cookie is blocked.

We also need TabDialogs' Signin confirmation dialog switched to Harmony,
so set up a way to show Harmony dialogs from the TabDialogs interface.

Opt collected cookies into DialogBrowserTest to make it easy to invoke
for testing.

BUG=654151, 677012, 610428

Review-Url: https://codereview.chromium.org/2534743002
Cr-Commit-Position: refs/heads/master@{#443130}

R=danakj@chromium.org
BUG=670043

Review-Url: https://codereview.chromium.org/2627713002
Cr-Commit-Position: refs/heads/master@{#443129}

Now that the Physical Web no longer displays notifications, the
opt-in notification will not fire.  Instead, users can enable the
Physical Web manually, or if they have Google search enabled (i.e.,
they are already sending info to Google for omnibox results).  Note
that this is the same behavior as on iOS.

BUG=663842

Review-Url: https://codereview.chromium.org/2618613007
Cr-Commit-Position: refs/heads/master@{#443128}

Tiny plugins will now always be disabled by plugin power saver, even if they have the same origin as the main page.

BUG=675707

patch from issue 2576893003 at patchset 1 (http://crrev.com/2576893003#ps1)

Review-Url: https://codereview.chromium.org/2627493002
Cr-Commit-Position: refs/heads/master@{#443127}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d1d93c3a..7ca33baf

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2627183002
Cr-Commit-Position: refs/heads/master@{#443126}

Revert of cc: Add image decode queue functionality to image manager. (patchset #12 id:220001 of https://codereview.chromium.org/2537683002/ )

Reason for revert:
Hoping to fix build/test errors such as
https://uberchromegw.corp.google.com/i/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/19947

-- sheriff.

Original issue's description:
> cc: Add image decode queue functionality to image manager.
>
> This patch adds an ability to request an image decode from
> the compositor. The caller should specify which image
> (SkImage) to decode and a callback. In return, it gets an
> id. When the image is decoded, the callback is issued with
> this id. The decode is then kept alive for 2 compositor
> frames.
>
> Right now, only unittests are using this functionality.
>
> R=enne@chromium.org, ericrk@chromium.org, danakj@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Review-Url: https://codereview.chromium.org/2537683002
> Cr-Commit-Position: refs/heads/master@{#443085}
> Committed: https://chromium.googlesource.com/chromium/src/+/bb991d41668aa0f37aa6d6712e3bf9b52a5480ae

TBR=enne@chromium.org,danakj@chromium.org,ericrk@chromium.org,vmpstr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2631453002
Cr-Commit-Position: refs/heads/master@{#443125}

Previously OnSurfaceAvailable() would call CompleteInitialization() if
init_cb_ was not null, but init_cb_ isn't reset until later in
NotifyInitializationComplete(). So if OnSurfaceAvailable() was called
more than once before deferred initialization completed, we would
erroneously call CompleteInitialization() more than once.

This CL cleans up the logic for OnSurfaceAvailable() so it's safe to call
at any time, and ensures that CompleteInitialization() only runs once.

BUG=677775

Review-Url: https://codereview.chromium.org/2621153004
Cr-Commit-Position: refs/heads/master@{#443124}

Using update-w3c-deps in Chromium 2e36b96a.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7867

TBR=qyearsley@chromium.org
NOEXPORT=true

Review-Url: https://codereview.chromium.org/2622083005
Cr-Commit-Position: refs/heads/master@{#443123}

MD History has several tests which test how focus reacts to keyboard
shortcuts. These have been flaky in browser tests, failing most of the
time when run in parallel with other browser tests. This CL attempts to
restore these tests by moving them to interactive UI tests, where
they should always be run one at a time.

These are the first interactive UI tests which run tests in a WebUI
page, so several test files have been moved in the build to accommodate
this.

BUG=642467

Review-Url: https://codereview.chromium.org/2613503004
Cr-Commit-Position: refs/heads/master@{#443122}

This was regressed in two different places, first by
https://codereview.chromium.org/2515903002
and then by
https://codereview.chromium.org/2607833002

BUG=680170

Review-Url: https://codereview.chromium.org/2628863003
Cr-Commit-Position: refs/heads/master@{#443121}

BUG=488194

Review-Url: https://codereview.chromium.org/2627113002
Cr-Commit-Position: refs/heads/master@{#443120}

. Introduces a parallel flow in ServiceManager to Connect called BindInterface which carries (via ConnectParams) interface name and pipe.
. Introduces an OnBindInterface() method to mojom::Service. In ServiceContext, this just calls through to OnConnect still since updating callsites is a pretty large task for a subsequent change.

Note that policy checking is still happening in the client - there was no easy way to avoid this without adding an unsafe mode to InterfaceRegistry that skips the check that I'd be concerned might be misused. And IR should probably just die once this work is complete anyway.

R=rockot@chromium.org,tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2610853013
Cr-Commit-Position: refs/heads/master@{#443119}

Review-Url: https://codereview.chromium.org/2620363003
Cr-Commit-Position: refs/heads/master@{#443118}

Revert of Moves definitions of RootWindowController into root_window_controller.cc (patchset #2 id:20001 of https://codereview.chromium.org/2628973002/ )

Reason for revert:
Attempting to resolve error in
https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/ChromiumOS%20amd64-generic%20Compile/builds/28853

>On 2017/01/11 22:44:48, James Cook wrote:
>> FYI I have a CL that deletes this method. We'll see who lands first.
> Done.

It looks like jamescook@ committed a bit more than four minutes earlier.
-- sheriff.

Original issue's description:
> Moves definitions of RootWindowController into root_window_controller.cc
>
> As part of this I made sure the definitions and declarations matched
> up. This resulted in reordering a couple of things. In addition the
> only other non-move I did was moving what was CreateLayoutManagers()
> into InitLayoutManagers() and CloseChildWindowsImpl() into
> CloseChildWindows().
>
> BUG=671246
> TEST=none
> R=jamescook@chromium.org
>
> Review-Url: https://codereview.chromium.org/2628973002
> Cr-Commit-Position: refs/heads/master@{#443109}
> Committed: https://chromium.googlesource.com/chromium/src/+/d20a89e7b56ad53a58f19edf4775528d066577d5

TBR=jamescook@chromium.org,sky@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=671246

Review-Url: https://codereview.chromium.org/2623393002
Cr-Commit-Position: refs/heads/master@{#443117}

Move these classes into components/safe_browsing_db/ and update references

BUG=679018

Review-Url: https://codereview.chromium.org/2622773002
Cr-Commit-Position: refs/heads/master@{#443116}

In the last cases of inconsistent evaluation of compile-time-constants
just make them constexpr and then ensure we always see constexpr things
as compile-time constants. Actually compiling figures this out even
though from the AST we see unresolved things that make this hard.

R=dcheng
BUG=677285

Review-Url: https://codereview.chromium.org/2626923004
Cr-Commit-Position: refs/heads/master@{#443115}

Attepted to enable this on an FYI bot. But that is unable to
successfully run chrome_public_test_apk due to some issue. Would
like to enable this on a bot already running chrome_public_test_apk
to see if it works as intended.

Review-Url: https://codereview.chromium.org/2626183002
Cr-Commit-Position: refs/heads/master@{#443114}

Now that there is support to count the number of active MediaKey
and MediaKeySession objects, update the tests to check the count
directly (there should be no such objects at the start of the test,
and if there are then something else is running and the counts
will be wrong anyway). By converting these tests to promise tests,
we get better logging if the test fails.

BUG=445324
TEST=updated tests pass

Review-Url: https://codereview.chromium.org/2618603002
Cr-Commit-Position: refs/heads/master@{#443113}

Provides a ScriptModule wrapper around v8::Module, as
well as primordial forms of the three basic operations
on modules:

  - compile(), a static method which takes a string and
    returns a ScriptModule
  - instantiate(), which "links" a module with its dependencies
    (the initial implementation does no actual linking)
  - evaluate(), which runs the module (and its dependencies;
    naturally this version doesn't do the latter)

Landing this in its early state makes it easier for others
working on <script type="module"> support to make progress
on other CLs, many of which will interact with this class

BUG=594639

Review-Url: https://codereview.chromium.org/2566513002
Cr-Commit-Position: refs/heads/master@{#443112}

BUG=678567

Review-Url: https://codereview.chromium.org/2623973002
Cr-Commit-Position: refs/heads/master@{#443111}

This required
1. Adding media_perftests to gn_isolate_map so that isolate can understand how
   to run them
2. Adding data dependencies to media_perftests target that are needed by the
   isolate script.
3. Added media_perftests to generate_perf_json.py configuration file.

A previous version of this CL (https://codereview.chromium.org/2595123002) got
reverted because I didn't do step 2. For that CL, I only tested media_perftests
in a local run. This time, I also ran using isolates as well. (Thanks eyaich@!)
See test run: https://chromium-swarm.appspot.com/task?id=3390ffce2596c810&refresh=10&request_detail=true&show_raw=1

Follow up CL(s) will also add support on Mac, Windows, and Android.

BUG=676188,392620

Review-Url: https://codereview.chromium.org/2617133004
Cr-Commit-Position: refs/heads/master@{#443110}

As part of this I made sure the definitions and declarations matched
up. This resulted in reordering a couple of things. In addition the
only other non-move I did was moving what was CreateLayoutManagers()
into InitLayoutManagers() and CloseChildWindowsImpl() into
CloseChildWindows().

BUG=671246
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2628973002
Cr-Commit-Position: refs/heads/master@{#443109}

This is a mechanical change to convert i18n-content to $i18n{} tags.

BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2625873006
Cr-Commit-Position: refs/heads/master@{#443108}

This CL:

1. Moves the code out of LayoutObject.
2. Forces the GraphicsLayer to be m_graphicsLayer and not
m_scrollingContentsLayer.

TEST=manual testing
BUG=679674

Review-Url: https://codereview.chromium.org/2620383004
Cr-Commit-Position: refs/heads/master@{#443107}

The reland adds a fix for a crash in window animation code when restoring
a session that has a minimized window. The animation tries to compute a
shelf item position before the shelf is initialized. The animation is not
visible to the user. Returning an empty rect results in a default target
position, which is fine in this case.

Added guards for access to ShelfView before shelf is initialized.

Original CL description:

Previously chrome --mash would always create the shelf on startup, even at
the login screen. Now it waits until login is complete, like classic ash.

Ash watches for SessionState::ACTIVE via a SessionStateObserver to create the
shelf, rather than NOTIFICATION_LOGIN_USER_PROFILE_PREPARED. For most login
flows this doesn't matter, but for supervised user creation it means that the
shelf is not created until the flow is completed. This is an improvement
because in the old code the shelf would be created too early and had to be
explicitly hidden.

Always create a SessionControllerClient in chrome, even in classic ash. This
allows classic ash to use the mojo pathway via ash::SessionController.

Remove WmShell::ShowShelf(), which was introduced in crrev.com/10693003 to
delay showing the shelf until post-login OOBE (like avatar picture select)
was complete. It does not seem to be needed anymore, either in production or
in tests.

Change AshTestImplMus to simulate a user logging in which is required to
create the shelf on the primary display and also to have a non-zero user
count to create the shelf on additional displays.

Remove some unnecessary OS_CHROMEOS ifdefs in //c/b/ui/ash.

BUG=666021, 679513
TEST=ash_unittests and chrome browser_tests

Committed: https://crrev.com/7f99e933e595824281102ff6737075dccbbc4d5c
Cr-Commit-Position: refs/heads/master@{#439845}

Reverted:

Review-Url: https://codereview.chromium.org/2619943002
Cr-Original-Commit-Position: refs/heads/master@{#442484}
Review-Url: https://codereview.chromium.org/2625733003
Cr-Commit-Position: refs/heads/master@{#443106}

https://pdfium.googlesource.com/pdfium.git/+log/96f482c9cd3c..d805eec52f6a

$ git log 96f482c9c..d805eec52 --date=short --no-merges --format='%ad %ae %s'
2017-01-11 tsepez Use observed pointers in CPDFSDK_AnnotIterator.
2017-01-11 npm Make tiff_read return actual length read

BUG=679230,670928

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2625253002
Cr-Commit-Position: refs/heads/master@{#443105}

If error page shows "DOWNLOAD PAGE LATER" button, we should also
enable download page action.

BUG=675225

Patch

Review-Url: https://codereview.chromium.org/2588253002
Cr-Commit-Position: refs/heads/master@{#443104}

This CL creates a StreamSocket::SocketMemoryStats to hold relevant
socket information so that we can avoid creating individual
MemoryAllocatorDump for each socket. MemoryAllocatorDump is expensive
to create. This CL makes net/ MemoryDumpProvider create fewer
MemoryAllocatorDump so that it can be enabled in Slow Reports.

BUG=669108

Review-Url: https://codereview.chromium.org/2623803002
Cr-Commit-Position: refs/heads/master@{#443103}