GitLab

Add a user policy to select the user experience of disabled features
listed in another policy 'SystemFeaturesDisableList'.

Bug: 1142785
Change-Id: I276eced7c9968e66988fbd2413ed09de35ee0bd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512886
Commit-Queue: Anqing Zhao <anqing@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Aya Elsayed <ayaelattar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828982}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome
TBR=chrome-os-gardeners@google.com

Change-Id: I90d6a33c4304b56563edee9268a320247eb56baf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544964Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828981}

https://dawn.googlesource.com/tint.git/+log/88091d3d17e1..627732c40839

2020-11-18 bclayton@google.com src/reader tests: Have parse() return a unique_ptr
2020-11-18 rharrison@chromium.org [transformer] Remove deprecated Manager constructor
2020-11-18 dsinclair@chromium.org ast: Support decoration kind hierarchies
2020-11-18 sarahmashay@google.com [validation] unittest v-0015: runtime array may only appear last in a structs
2020-11-18 dsinclair@chromium.org [spirv-writer] Support optional trailing return.
2020-11-18 bclayton@google.com Fix linter warnings, stdout test spew
2020-11-18 dneto@google.com Fix doxygen comment
2020-11-18 dneto@google.com spirv-reader: Register usage for handle vars and func parameters
2020-11-18 dneto@google.com spirv-reader: GetMemoryObjectDeclarationForHandl can return null

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-chromium-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: kainino@google.com
Change-Id: I0a765a26ed4917fd69f2e374d664e046e4ef4bed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547113Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#828980}

When clicking +1 button from the Tab Switcher, it launched the Start
surface via ChromeTabCreator#launchNTP(). During this transition from
the Tab Switcher mode to the Start surface mode, the onActivityChange()
event isn't triggered since tab is null in both scenarios. As a result,
the token to suppress the bottom sheet in Tab Switcher isn't released
when transiting to the Start surface.

In this CL, we make BottomSheetManager listen to the Start surface
state change, and move the logic of suppression of the bottom sheet for
Start surface + Tab switcher into the listener.

Bug: 1129746
Change-Id: I74fd545bfd6799626a57944fb97db6c9164225be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541811Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828979}

The <menu> tag is no longer supported as an interactive feature, but
is still supported as a semantic tag. The HTML spec still includes it
as a container for <li> children, but has removed <menuitem>.

Another option would be to try and be "clever" and look for
role=menuitem children, changing the mapping to menu. However, given
the state of the standard and varying browser support, it seems better
to not add extra complexity and also to not encourage usage.

Decisions:
- Support simple mapping to the list role, because if it's just used
semantically, it will be confusing for users who reach te menu and
it does not act like one.
- Remove behavior where child buttons/radios/checkboxes are mapped
to menuitemfoo roles when inside a menu. There is nothing spec'd in
HTML-AAM or CORE-AAM for either of these conditions, and it looks like
more strange menu code that was inherited from WebKit.

This CL will make it easier to support an upcoming CL that cleans
up radio button code.

Bug: None
Change-Id: I49e95b5e526e742102b0bb6ad92b17f7a4ba0175
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543685Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828978}

Decoding an image can result in it becoming a bitmap. To ensure this
doesn't negatively impact memory when decoding also apply the bitmap
size enforcement to already encoded images.

Bug: 1144768
Change-Id: I7fc36601e07fcafda65bc408f2563f0ec319dbf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547213Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828977}

Implementation is stubbed out today, but still needed so that
BrowserNonClientFrameViewChromeOS can be adopted on lacros builds.

SnapControllerLacros inherits the pure virtual
chromeos::SnapController, and "maximizing" lacros chrome windows
require an instance to exist (held by ChromeBrowserMainExtraPartsViewsLacros).

Similarly to ash::SnapControllerImpl, SnapControllerLacros
is created from the newly added
ChromeBrowserMainExtraPartsViewsLacros::PreProfileInit().

BUG=1113900
R=jamescook@chromium.org

Change-Id: I86a034ddcba7c12c3a7d7b2736058476c2db3ba2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547045
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828976}

Preliminary results from the Canary+Dev experiment are encouraging.
Adding to testing config to allow Beta experiments.

Bug: 1144166
Change-Id: Ie40d0c5f46ab2779c2a6ec3c55b21cdfec79abb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541004Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828975}

This prevents compile failures when e.g. doing EXPECT_EQ() with
StrongAliased types that don't have <<.

Bug: none
Change-Id: I8efe29521bc6b05ac39aa2602a4fa1189318af57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538497
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828974}

It runs 100% experimentally since crrev.com/c/2541222.
The build duration (http://shortn/_4qFyYutBjf) and
test devices (http://shortn/_gE18OBAzt8) are still in good shape.

Bug: 1111436
Change-Id: Iee624ad216243cd6a6b07afc9e64456acb5cdd60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544749Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Haiyang Pan <hypan@google.com>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#828973}

Update color of the expand arrow button as well as the deletion button
from Grey 900 --> Grey 700.

before: screenshot/4mphygPwGNXtcDv
after: screenshot/6CSf8WmB8DXD9kW

Fixed: 1146256
Change-Id: Iaddb97e4f7b70b85ca61815a6f341896832ea32a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547924
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828972}

ScopedObserver is being deprecated in favor of two new classes:
- base::ScopedObservation for observers that only ever observe
  a single source.
- base::ScopedMultiSourceObservation for observers that do or may
  observe more than a single source.

This CL was uploaded by git cl split.

R=ellyjones@chromium.org

Bug: 1145565
Change-Id: Ie6262d31836393d9c8bdbf0cc684564a073792b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547962
Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828971}

Fullscreen, window, region capture mode now all require change mouse
cursor. This CL put mouse cursor setting logic in a central place and
auto decide which cursor to use based on the current event location.
It unified the cursor behavior on the capture bar and button, and also
fixed a few bugs in the original implementation, like the mouse cursor
can be disappear after clamshell->tablet->clamshell transition.

Bug: 1142937
Change-Id: I139cfcb5b0c97970d65562579c2244080693f850
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537939
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#828564}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547429
Cr-Commit-Position: refs/heads/master@{#828970}

This change adds LocationBarMediator and puts it in front of most
signals that LocationBarLayout receives:
* AutocompleteDelegate
* FakeboxDelegate (moved from LocationBarCoordinator)
* VoiceRecognitionHandler.Delegate
* AssistantVoiceSearchService.Observer
* UrlBarDelegate (moved from LocationBarCoordinator)
(OnClickListener is excluded for now)
This also entails moving init/ownership of VoiceRecognitionHandler and
AssistantVoiceSearchService out of LocationBarLayout. Otherwise, the
change should be mechanical; LocationBarMediator merely forwards its
calls to LocationBarLayout.
A small set of unit tests for LocationBarMediator is included, with
the intent to add more as logic is ported into it.

Bug: 1147581
Change-Id: I6c2c97bac24b0040052079d4bc06cf502d07b7bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530747
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: bttk <bttk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828969}

This CL adds metrics for the configuration a user has when they capture.
I.e. taking a fullscreen screenshot, window screenshot, etc.

Test: manual + added
Bug: 1140182
Change-Id: Ibe4f6289d754d76e1e6ecba1d9442cdfc96d0d3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538062
Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828968}

ScopedObserver is being deprecated in favor of two new classes:
- base::ScopedObservation for observers that only ever observe
  a single source.
- base::ScopedMultiSourceObservation for observers that do or may
  observe more than a single source.

This CL was uploaded by git cl split.

R=shaktisahu@chromium.org

Bug: 1145565
Change-Id: I6d607bcafec4a912694f42c48881bcbec04914de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547770
Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828967}

- Add MapTraits to allow serialization of a vector of pairs directly
  into a Mojo map for ui::AXNodeData.
- Update AX browsertest to use Gmock matchers for container comparison.
  This test currently depends on an ordering that is not guaranteed by
  abnything and may unexpectedly break in the future.  Using Gmock makes
  it easier to update at such a point in the future.
- Deserialize attribute maps into a base::flat_map and extract the
  underlying result directly into ui::AXNodeData.

Bug: none
Change-Id: I1db2649312ad1e68a40962e27bd5c97da29cc3fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541745Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828966}

Disable SSLUITest.BadCertFollowedByGoodCert. Flaky.

Tbr: estark@chromium.org
Bug: 1150592
Change-Id: I2b3a4b9b82fd6e19cf9d2d8e66e4370a14efb20a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548180Reviewed-by: Nina Satragno <nsatragno@chromium.org>
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828965}

https://dawn.googlesource.com/dawn.git/+log/01e445072921..ce207be41fd6

2020-11-18 rharrison@chromium.org Use the transform manager instead of invoking the transform directly
2020-11-18 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 90f32536458a to 46d9c7745efa (13 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: kainino@google.com
Change-Id: Iea2a116ac2263e365320bce6e161ae188ccf5048
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546977Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#828964}

Onion-souping landed long ago, so remove the TODO item in the doc.

Change-Id: I58a20028eeae43fd56ac37f86d3be20e5b01b315
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547944
Auto-Submit: Eric Lawrence [MSFT] <ericlaw@microsoft.com>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828963}

Change-Id: Iabc86cc45f754e1f8b10191a6bb6118b21d80558
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545824
Commit-Queue: Yashar Dabiran <yashard@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828962}

ScopedObserver is being deprecated in favor of two new classes:
- base::ScopedObservation for observers that only ever observe
  a single source.
- base::ScopedMultiSourceObservation for observers that do or may
  observe more than a single source.

This CL was uploaded by git cl split.

R=grt@chromium.org

Bug: 1145565
Change-Id: I09bb3f756fd726ccf3e764bef51ff5ccc0a62bd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547963
Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828961}

It's required to retrieve results files, but was only being called as a
side-effect of pushing *multiple* files to the device. A test that
pushes only one file does not use "_PushChangedFilesZipped()"
under-the-hood, and so would fail due to not having "adb root" called.

Bug: 1145570, 1150237
Change-Id: I826db1db303144320ea75841da5902171b66c136
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545651
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828960}

We don't need to use an object replacement character in IAccessible2, UI Automation and Linux ATK
if the node whose text is replacing is not visible to those APIs,
i.e. if the node lies outside the part of the accessibility tree that could be
accessed by platform APIs.
Object replacement characters are only meaningful when they appear in the accessible text for IAccessible2 and ATK,
and only when they are used as a word or character boundary for UI Automation.
Therefore, any object replacement character that cannot be accessed either via IAccessibleText, UIATextRangeProvider,, ATKText, etc.
is unnecessary. We currently don't expose such characters in IA2 hypertext, for example.
It can also make it impossible to compute the equivalent ancestor AXPosition on a text field for
a text position that is pointing to an inline text box inside that field.

This patch improves and generalizes the fix in
https://chromium-review.googlesource.com/c/chromium/src/+/2473065

AX-Relnotes: n/a.

R=dmazzoni@chromium.org, kschmidt@microsoft.com, vicfei@microsoft.com

Bug: 1141171
Change-Id: Ia6699a841dfca59558ed1188de04a06e5b13e66c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504504Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Victor Fei <vicfei@microsoft.com>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Auto-Submit: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828959}

This CL is a refactor with no intended behavior change.

The implementation of LacrosChromeServiceImpl depends on many version
checks against AshChromeServiceVersion. New code can easily set the
wrong version due to a rebase. Using gneerated MinVersion enums
sidesteps this failure case.

Change-Id: I350dc69f430e7dab81eceaeb118ecdd5687be7dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547789
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828958}

ScopedObserver is being deprecated in favor of two new classes:
- base::ScopedObservation for observers that only ever observe
  a single source.
- base::ScopedMultiSourceObservation for observers that do or may
  observe more than a single source.

This CL was uploaded by git cl split.

R=sky@chromium.org

Bug: 1145565
Change-Id: I92bcf71a7f5296555933003d799fcb0fff7968e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548001
Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828957}

This is a update based on spec.

Bug: b/173476221
Test: manual
Change-Id: Id0450fb90084b9932cb534da475d1a7ab3f98d30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546601Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828956}

Bug: 11297512
Change-Id: I7bf329df83e8ae0185578cc0bf1b68090a937b4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547323Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Hannes Payer <hpayer@chromium.org>
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828955}

Feature Policy reporting origin trial ended in July 2019
(https://developers.chrome.com/origintrials/#/view_trial/2206763817411543041).

Related tests should be removed, as the trial itself has expired.

Bug: 1148804
Change-Id: I275cf2b0c9a35f7c535bcf5c5c7430576f6b30f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532670Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#828954}

TBR=bling-team@google.com

Change-Id: Ib7fc68197279ae8dc3f4317337e9afd7af80ad85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547885Reviewed-by: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#828953}

...in which case, the new vmshell will have the CWD the same as the
terminal with the id.

Bug: 1113207
Change-Id: I9cc49c5fde3c58eeebb8707c4190040a15dd2ac6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532340Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Jason Lin <lxj@google.com>
Auto-Submit: Jason Lin <lxj@google.com>
Cr-Commit-Position: refs/heads/master@{#828952}

 - Add placeholder icon
 - Adjust sizing of percent_bar_chart/realtime_cpu chart
 - Will be updated to adhere to the spec in the future.
 - A follow-up CL will update the labels for the percent_bar_chart
   and the realtime_cpu chart

Screenshot: http://shortn/_4EPGfnWJW6

Bug: 1125150
Test: browser_tests --gtest_filter=DiagnosticsApp*
Change-Id: Id05f75cd46a0b01887788f964c9e19a1843dc900
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536472
Commit-Queue: Michael Checo <michaelcheco@google.com>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828951}

This crash could happen if the enrollment update comes after the
Assistant has been stopped.

Bug: 1147895
Change-Id: I56b1db6e859fc24c621c36fe984f31168365fcf5
Tests: Compiled
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533194Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Yue Li <updowndota@chromium.org>
Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828950}

This reverts commit 35f1e6ba.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 828763 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzM1ZjFlNmJhODk1ZDM2MDI5OGU0YTM5YTE4YzNhODZkZDA5ZGRiNDMM

Sample Failed Build: https://ci.chromium.org/b/8863253709258648432

Sample Failed Step: compile

Original change's description:
> [third_party] Uprev grpc to v1.33.0+
> 
> Bug: b/132440534
> Test: CQ and manual size check.
> Change-Id: Ie892c66dd5773e93ed154d3754add455e1f47041
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518775
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Sean Topping <seantopping@chromium.org>
> Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org>
> Commit-Queue: Andres Medina <medinaandres@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#828763}


Change-Id: I0b47e5727536cab1f5a25d02171b6e60e3978b74
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/132440534
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548501
Cr-Commit-Position: refs/heads/master@{#828949}

Change tests in webview_login_browsertest.cc to explicitly specify which
client certificates need to be put into the fake system slot.

This is preparation for a follow-up CL that will add new tests that
actually select different client certificates than the previously single
"client_1" cert.

Also change some of the existing tests to additionally load some
unrelated certificates in cases where it's meaningful to test that no
wrong cert is selected.

Bug: 905994
Change-Id: I3227e9f3f42f900b9f0a587ae65a5da1676f8e10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426497
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Auto-Submit: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828948}

Now that size config JSON files have become the default way for android
binary size bots to pass data to binary size scripts, deprecated
arguments can be removed:
* generate_commit_size_analysis.py: Remove {--apk-name, --mapping-file}
  (replaced by --size-config-json).
* trybot_commit_size_checker.py: Remove --apk-name (replaced by
  --size-config-json-name).
  * Remove functions to guess .mapping file names (no longer needed).

Bug: 1040645
Change-Id: I62aab4982edb523ea66a9c14ef5fc541260e922a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546445Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828947}

Currently this class maintains several maps and sets of objects, indexed
by content::MediaPlayerId. Long lived WebContents that dynamically play
media can accumulate an unlimited number of these objects, as the
destruction of the objects is not tracked.

This CL adds WebContentsObserver::MediaDestroyed(), and plumbing for
this via MediaWebContentsObserver and WebContentsImpl.

BUG=885394,1014165,1144736

Change-Id: If275ccb7fc6e4fd518e4a2bcc3a79f1b09b5fa5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545502Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828946}

This reverts commit f139bbf8.

Reason for revert: Fix crash in PaintFastBottomLayer() in
box_painter_base.cc when painting a rounded custom scrollbar parts
with background image.

Original change's description:
> Revert "Use only one way to check if we are printing or painting preview"
>
> This reverts commit c5bbd834.
>
> Reason for revert: Breaks custom scrollbar background painting (null
> pointer when dereferencing a Node when getting the Document).
>
> Original change's description:
> > Use only one way to check if we are printing or painting preview
> >
> > We had 3 ways to check printing status:
> > - Document::Printing()/Document::IsPaintingPreview()/Document::IsCapturingLayout()
> > - GraphicsContext::Printing()/GraphicsContext::IsPaintingPreview()/GraphicsContext::IsPrintingOrPrintingPreview()
> > - PaintInfo::IsPrinting()
> >
> > Now keep the first way only to ensure consistency and reduce chance
> > of errors.
> >
> > Also simplify PaintRecordBuilder constructor parameters to avoid
> > multiple default parameters, and let callers set some GraphicsContext
> > related configs directly instead of through PaintRecordBuilder
> > constructor.
> >
> > Change-Id: I479b98b19700c5bed077ec9ef00bd148e3b33c63
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535627
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Reviewed-by: Stefan Zager <szager@chromium.org>
> > Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#828385}
>
> TBR=szager@chromium.org,wangxianzhu@chromium.org,mstensho@chromium.org,ckitagawa@chromium.org
>
> Change-Id: I9854b70695cf588fbc8f704c60fd211c936bd132
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1150260
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547424
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#828780}

TBR=szager@chromium.org,wangxianzhu@chromium.org,mstensho@chromium.org,ckitagawa@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 1150260
Change-Id: Ic3e3986d467054c9bf634eb40cd66d60bbc59147
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547766Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828945}

Bug: 1142413, 1150277
Change-Id: I60d8161fa25ef2cdeb2312a9eaf6b8e8c04f3669
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547980
Commit-Queue: Matthias Körber <koerber@google.com>
Reviewed-by: Matthias Körber <koerber@google.com>
Reviewed-by: Christoph Schwering <schwering@google.com>
Auto-Submit: Christoph Schwering <schwering@google.com>
Cr-Commit-Position: refs/heads/master@{#828944}

This is a reland of https://crrev.com/c/2536030, which was reverted
by mistake. The actual failure was caused by another CL
(https://crrev.com/c/2537939) which was also reverted.
No changes were made in this CL from the original.

TBR=jamescook@chromium.org, dcheng@chromium.org

Original CL description:
This is a follow-up CL to handle requests made on the recording
service CL (https://crrev.com/c/2404145):
- The Record*() APIs of the service should provide the needed client,
  video capturer, and audio stream factory, instead of exposing APIs
  in the client so that anyone can bind to those capturers.
- The service is launched to handle video recording, and terminated
  once recording ends, and all the chunks have been sent.
- A GPU crash is handled by ending the recording.

BUG=1126586, 1147989, 1143411
TEST=Manually, existing tests.

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536030Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#828574}
Change-Id: I747e6f74005b304e3954dc77615574ffe7a27cc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546857Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828943}