- 05 Oct, 2020 40 commits
-
-
Weilun Shi authored
Add assertion to generate_expired_histograms_array to make sure the --inputs always keeps in sync with |histogram_paths.ALL_XMLS|. Otherwise, the script will fail and ask users to update build targets --inputs. Bug: 1134434 Change-Id: I586c967e553aae9a7aba7bec5a887947aef4e7ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446205 Commit-Queue: Weilun Shi <sweilun@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#813929}
-
Matt Reynolds authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. BUG=1018739 Change-Id: I1eb15302d1c881068f59edffe1f0c85c4a2c1349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442199Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#813928}
-
Dana Fried authored
Bug: 1122214 Change-Id: Iabebb62c8bcdfcd2e65dda6f09fa99869648c316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450712 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#813927}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e61500059aa7..7a7bec371a3c 2020-10-05 johnstiles@google.com Capitalize static class methods. 2020-10-05 ethannicholas@google.com fixed Google3 build failure 2020-10-05 ethannicholas@google.com moved SkSL ForStatement data into IRNode 2020-10-05 bungeman@google.com Reland "Remove use of legacy display globals." 2020-10-05 herb@google.com add pixel xl to skpbench 2020-10-05 nigeltao@google.com Have SkWuffsCodec use PIXEL_BLEND__SRC_OVER 2020-10-05 bsalomon@google.com Remove unused variant of SkImage::MakeFromYUVAPixmaps 2020-10-05 ethannicholas@google.com Revert "Revert "moved SkSL Field data into IRNode"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: I54690ccc0e72951e5f40742091cfac929c9ce801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450790Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813926}
-
Francois Doray authored
setTimeout(..., 0) can be used to schedule a continuation. Opting out these timers from throttling reduces latency to receive notifications on some background pages and does not significantly affect speed or resource usage. Full cleanup will happen after the 1% Stable Experiment is complete. Experiment results: https://docs.google.com/document/d/1frGCY_ZCM0VYwThAVAxNRvEDnd5hbAHDgkyA5Tsawts/edit?usp=sharing Bug: 1075553 Change-Id: I0c1546d13e0aa8891479370ffb1706b75c9c77d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443230 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#813925}
-
Christopher Cameron authored
Restrict this to macOS 10.11 and above. In theory the function should not compile when targeting macOS 10.10. In practice it does, because the CoreMedia constants are preprocessor defined to their CoreVideo equivalents (which are defined). This function is nearly identical to media::GetImageBufferColorSpace, but instead operates on a CMFormatDescriptionRef. Add DCHECKs that the behavior of the two functions be the same, that is, the kCVImageBuffer-prefixed and kCMFormatDescription-prefixed constants be equal. Use base::mac::CFCast instead of reinterpret_casts. The next patch in this sequence will move these two functions over to media/base/mac, because it will be accessed in capture. Bug: 959962 Change-Id: Iea9d8d357dec72ddc928b7e1fd3a631c131ade74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449934Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#813924}
-
Austin Eng authored
On Linux, WebGPU shared images require a Vulkan GrContext. The current webgpu_decoder_unittest doesn't have a way to request this whereas webgpu_mailbox_unittest can correctly set up the context with shared image support. Move the tests so we can enable them on Linux. Bug: 976495 Change-Id: I11283e556d36a641e183857c087ca35f87e1e6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443975 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#813923}
-
Daniel Hosseinian authored
This is the last step before rolling out the feature to 100% stable. Bug: 696650 Change-Id: If76f9d1d1c54c51515ee891560d43c003699a623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450950 Auto-Submit: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#813922}
-
George Steel authored
Because composited animations are inaccessible from js, reftests are necessary to test their behavior. In this set, the file transform-interpolation-reftests.js defines the tests themselves and several wrapper html files each run a subset of them (this structure is due to the lack of support for test variants in reftests). As these tests are specifically meant for testing compositor animations, add css-transforms to the virtual/threaded suite to test with threaded compositing. As this has found several errors, bugs have been filed and linked to the threaded cases in TestExpectations Bug: 1131196, 1133901, 1131252 Change-Id: I9c6d92727e52a3ec11fe56f3375fc352baeadf04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443209Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#813921}
-
David Tseng authored
R=akihiroota@chromium.org sticky mode won't toggle off/on when encountering text fields even with Smart Sticky mode on. Bug: none Change-Id: I7e06c30daefa70835e6f09cce33867fcf3c3c46f AX-Relnotes: When performing ChromeVox's read from here (Search+R) command, Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448061Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#813920}
-
Andre Le authored
- Remove kConnecting and add timer to track requested state in find my device controller. - Edit FakeFindMyDeviceController to use for unit test. - Remove a TODO in enable hotspot since unnecessary. BUG=1106937,1126208 Change-Id: Ic5a5dd2126313b2b22885ce8a23237fe281e762a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446815 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#813919}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I02b373fe9b872292f634f87aa587727c3f9ccd5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450490Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#813918}
-
Tina Wang authored
1. Added EG tests for the managed items and click actions. 2. Added constants to autofill_constants and formatted the existing ones. 3. Improved the helper api by: - adding scroll action to avoid issue while testing on small screens. - simplify the parameters. Bug: 131052 Change-Id: Ibe507443a07b1fe7e5c2374bf8b5a1436b43461b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441191Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#813917}
-
manukh authored
Rich AC uses FindAtWordbreak and split rich AC (future CL) will use 2 additional utility methods regarding searching for terms in strings. This CL adds the latter 2 methods and moves the 3 methods to inline_autocompletion_util.cc. Bug: 1062446 Change-Id: I49a90c9ce8a17c0ff81a18c56c5151ca6c2f8608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450700Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#813916}
-
David Tseng authored
This getter returns an instance of Cursor, but it should return an instance of either Cursor or WrappingCursor. R=akihiroota@chromium.org of a page that has a text field at the end. Bug: none Change-Id: Id52523c4b391d175303130c3f5494a1bf63c2f13 AX-Relnotes: ChromeVox will now wrap correctly when moving forward from the end Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450209Reviewed-by:
-
Caitlin Fischer authored
This is done by updating the histograms config model and by uncommenting the call to ExpandHistogramsOWNERS() in merge_xml.py. This ensures <owner>src/dir/OWNERS</owner> is expanded into actual owners, e.g. <owner>name1@google.com</owner> and <owner>name2@chromium.org</owner>. Uncommenting this allows components to be extracted from OWNERS files as well. That way, component info, if available in an OWNERS file, is added to histogram expiry bugs, e.g. http://crbug/1088985. Also, add component documentation and add a component to two Variations.Headers.* histograms. Support was previously added for component tags, see http://crbug/989112 for details, but it wasn't explicitly used. Bug: 1133699 Change-Id: I572c877be8929923fd14df352e762a7a293ca5ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442136Reviewed-by:
Weilun Shi <sweilun@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#813914}
-
Chris Sharp authored
TBR=qinmin@chromium.org Bug: 1106059 Change-Id: Ie241c0a80c0f6b6788f8a8ee6df7208f57f42d57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449911Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#813913}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/745402dd650a..96edaff6ceb3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kristipark@google.com,csharp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1073584,chromium:1129255 Tbr: kristipark@google.com,csharp@google.com Change-Id: I8522a9d6cd92e9e6d353bdc85db4d7e68b342ef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450520Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813912}
-
Muyao Xu authored
The user can start a new cast session by clicking on the cast device button. If the session starts successfully, the GMC dialog will be closed. If the session fails to start, an error message will show up as the subtitle on the button (This is implemented by the CastDialogController class. Bug: b/161610050, 1107162 Change-Id: Ibaad612115ba73d8e883455cf89ec6e1a6cda401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441107Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Muyao Xu <muyaoxu@google.com> Cr-Commit-Position: refs/heads/master@{#813911}
-
Lukasz Anforowicz authored
After a recent migration (ending with https://crrev.com/c/2443398) factories are never put into the NonNetworkURLLoaderFactoryDeprecatedMap, except in a handful of tests. This CL removes these remaining uses in the test code (in DownloadTestContentBrowserClient, NavigationUrlRewriteBrowserTest, FirstPartySchemeContentBrowserClient) and proceeds to entirely remove the NonNetworkURLLoaderFactoryDeprecatedMap type alias from ContentBrowserClient. This also allows removing the following things: - |uniquely_owned_factories| parameter from RegisterNonNetworkNavigationURLLoaderFactories and RegisterNonNetworkSubresourceURLLoaderFactories methods - Code processing |uniquely_owned_factories| in callers of the two Register...Factories methods above (e.g. in DownloadManagerImpl::BeginResourceDownloadOnChecksComplete, EmbeddedWorkerInstance::CreateFactoryBundleOnUI, WorkerScriptFetchInitiator::CreateFactoryBundle) - Fields that (unsuccessfully/incorrectly) attempted to extend the lifetime of the factories in: NavigationURLLoaderImpl and RenderFrameHostImpl. Fixed: 1106995 Tbr: kmarshall@chromium.org for //fuchsia/engine Tbr: karandeepb@chromium.org for //extensions/shell Tbr: boliu@chromium.org for //android_webview Tbr: seantopping@chromium.org for //chromecast/browser Change-Id: Id1a0b8c91d07a68df3b7c907ed6315242fce8141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359402 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#813910}
-
Vincent Boisselle authored
Change-Id: I4378c135745eff9693a7d013d423a6f018dee649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440907 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#813909}
-
Chris Sharp authored
Currently print_backend_mojom_traits.h includes printing/backend/print_backend.h" so without this deps this target can't be built by itself. TBR=awscreen@chromium.org Bug: 1135263 Change-Id: Ic597468dcdaefbb83e145ef82bb4f4d6b93ef6c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449916Reviewed-by:
-
Sebastien Marchand authored
This create some issues in some tests, they fail with the following stack trace: BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x56400bd836c9 base::debug::CollectStackTrace() #1 0x56400bcb90c3 base::debug::StackTrace::StackTrace() #2 0x56400b74b5e6 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7fdc5b8c84c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x564010b453b0 __llvm_profile_merge_from_buffer #5 0x564010b43705 writeFile #6 0x564010b43547 __llvm_profile_write_file #7 0x564010b43874 __llvm_profile_dump #8 0x56400bda6373 base::WriteClangProfilingProfile() #9 0x56400d8cb484 content::ChildProcess::~ChildProcess() #10 0x564010780118 content::RenderProcessImpl::~RenderProcessImpl() #11 0x564010688274 content::InProcessRendererThread::CleanUp() #12 0x56400bd6c2b8 base::Thread::ThreadMain() #13 0x56400bd9a8d9 base::(anonymous namespace)::ThreadFunc() #14 0x7fdc60fa16ba start_thread #15 0x7fdc5b99a4dd clone This call to base::WriteClangProfilingProfile has been recently[1] added to ChildProcess::~ChildProcess to ensure that the child utility processes properly flushed their profiling data at shutdown. This was an issue when running the PGO profiling scenarios as some child processes were terminated too aggressively and sometime didn't had a chance to fully write their profiling data. It doesn't seem to affect the coverage data (and this change brings the coverage build back to the state it was in before [1]). We should ideally also look at this crash and understand why it's happening, this CL really just prevent this crash from happening by not calling the problematic function when it's not needed. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2378272 Bug: 1065485 Change-Id: I051ab0993216a887a38863070b554e02ba60bb77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450332Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#813907}
-
Solomon Kinard authored
Bug: None Change-Id: I68116f7a2973551f7dfc22fd4705574b29bd7271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450739Reviewed-by:
-
Ben Kelly authored
This feature launched to 100% on windows, mac, and android in M80. It was just enabled by default on ChromeOS in ToT after an extended period investigating performance regressions. Bug: 960012 Change-Id: I6e1edacd5f3c180f64a024cb948022aeaf130d1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450495Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#813905}
-
Jeffrey Young authored
Handle failure cases better by having backup photos on disk. Refresh these images after user logs in. BUG=b:167332126 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I7046a20ed9606638e851247f8c213d112af6c30b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429585 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#813904}
-
Joe Mason authored
[PM] Add WeakPtr accessors to all node types, and a PerformanceManager::GetProcessNodeForRenderProcessHost accessor R=fdoray Bug: 1134162 Change-Id: I3a47611e331d1da3193a2bdda48e5858ba2ad860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443189 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#813903}
-
Mikel Astiz authored
The number of unique clients is very low and approaching zero as the histogram expired in August 2020. Change-Id: I49d6cb443e21be64f934289c335f454287f21bff Fixed: 1097926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442014Reviewed-by:
Rushan Suleymanov <rushans@google.com> Reviewed-by:
-
Matt Menke authored
It's no longer being used. Fixed: 846167 Change-Id: I3636e12cdab07188c90199329826de4ef18432f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444430Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Avi Drissman authored
Fixed: 1089369 Change-Id: I5c6a2eccee34ba5dbb6b4ea2ea6b003f86525f12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442896 Commit-Queue: Ilya Sherman <isherman@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Xing Liu authored
ReadingListManagerFactory should be BrowserContextKeyedServiceFactory instead of SimpleKeyedServiceFactory, since reduced mode won't work for sync and ReadingListModel. Also we build components/reading_list to Android APK, which causes android binary size increase. Bug: 1128074 Binary-Size: Size increase is unavoidable (see above). Change-Id: If5393fa5dfb133b35c1ff1b17bf709f31f8815ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441204 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#813899}
-
Morten Stenshorne authored
We got it wrong when there was overflow. Use WritingModeConverter. Bug: 829028 Change-Id: Idf060c3417f254f414251a9e3287a3c8f5c6cd97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450315Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#813898}
-
Adam Langley authored
In order to make things more easily extendable in the future, make the contents of the caBLEv2 QR codes be a CBOR map. This should eliminate the need to version-switch based on a URL prefix, so drop the "/c1/" from the URL. BUG=1002262 Change-Id: Id05a38c8ba510f673594774e57d418f8259779f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444174 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#813897}
-
Eric Orth authored
These were never true timeouts but merely the period of time after querying a resolver before we would try another server or retry. The original query would keep going. Renaming these to avoid confusing myself as I add more logic for transaction timeouts (that actually will be timeouts for the overall transaction). Bug: 1109792 Change-Id: Icafcce30c5250a9164cd8b779a8ddf1b9fdbfbf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446526Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Becca Hughes authored
This reverts commit 55c1d6cd. Reason for revert: Broke official builds https://crbug.com/1135285 Original change's description: > WebUI: Replace uglify-es with terser. > > The former is deprecated and no longer receives any updates. > > Bug: 1087970 > Change-Id: I15cb6beb49eb55fb7fa7489459d7072ba8e2f66c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444486 > Reviewed-by: John Lee <johntlee@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: dpapad <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813856} TBR=thestig@chromium.org,dpapad@chromium.org,johntlee@chromium.org Change-Id: Ifd82789f8e17dd5c19ee894fa99f08278ed5be29 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1087970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450840Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#813895}
-
Mason Freed authored
This CL removes the Web Components V0 APIs (Shadow DOM v0, Custom Elements v0, and HTML Imports) from the web platform. The features are still available for use by limited internal code directly, for a limited additional period. See crbug.com/1111843 for reference. These features were deprecated in August, 2018, in [1], and removed by default in Chromium M80, in [2] and [3]. For those sites that needed additional time, there was then a "deprecation extension" [4] (sometimes called a "reverse origin trial") that allowed sites to continue using these APIs through M87. Now that M87 has branched to Beta, the origin trial has now ended. These public APIs are now disabled for all sites. With this CL, several test suites are being skipped in TestExpectations, including several folders that have been prepared in advance: crbug.com/1081941 web-components-v0-only/* [ Skip ] crbug.com/1081941 virtual/web-components-v0-disabled/* [ Skip ] crbug.com/1081941 http/tests/htmlimports/* [ Skip ] Once this CL has landed and stabilized, these folders/tests will be deleted entirely. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/h-JwMiPUnuU/sl79aLoLBQAJ [2] https://chromium-review.googlesource.com/c/chromium/src/+/1850795 [3] https://chromium-review.googlesource.com/c/chromium/src/+/1869562 [4] https://developers.chrome.com/origintrials/#/view_trial/2431943798780067841 Bug: 911943, 1111843 Change-Id: Ia7bde5af655eba43538d18ce1335ed3e72846503 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195005Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#813894}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1601877511-e7db431e3df4886bdee72d3fd137fde2437674f5.profdata to chrome-win32-master-1601899131-c43b6187adc90e2cb7e0fb0be3a8513091bf4fd9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id226d83f51577d75a58974891e99401acd083b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450111Reviewed-by:
-
Morten Stenshorne authored
A column spanner forcefully breaks a column, so any leading margins on content right after the spanner shouldn't be discarded. Bug: 829028 Change-Id: I767466677d72be2760306ddd531e847f52cfa8ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445482Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: I178fab3f54a6fcf52ac41f6642c5d6b02f1408de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442889Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#813891}
-
Anupam Snigdha authored
Clamped the values in |ConvertRectToScreen| to avoid integer overflow while calculating the width/height of the rectangle. Bug: 1134463 Change-Id: Ic53a8513be7393b0e58ee9d3b2019a0b71c9d703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450920Reviewed-by:
-
