GitLab

This reverts commit e61604f9.

Reason for revert: Tests started failing again.

Original change's description:
> Re-enabled system_health.memory_mobile benchmarks
> 
> These should be working again after
> https://chromium-review.googlesource.com/c/chromium/src/+/1626991
> 
> TBR=perezju@chromium.org
> 
> Bug: 964804
> Change-Id: Iddbffc36717e86db4da46cfc733821f169cf6f38
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628317
> Reviewed-by: oysteine <oysteine@chromium.org>
> Commit-Queue: oysteine <oysteine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#663183}

TBR=oysteine@chromium.org,perezju@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 964804
Change-Id: I23caa9852a521316ec7b61369584daa45e146ff9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630225Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663933}

Bug: 948955
Change-Id: I5c98964e81984ff2fca76a0500dd297f5189f5b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623535Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663932}

Change-Id: I5d5a979cb8360341c910288141394e84ebf4e2b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616389Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663931}

These should not start the reporter but are possible. Due to the
statefulness of WTR this means we need a new "has valid start time"
flag which controls when reporting is running.

BUG=965820,967103
TEST=new unittest
R=sandersd

Change-Id: Ieeb125472609f2a0c3b027c9c43ab4ded7cb669a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632893
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663930}

Bug: 965236
Change-Id: Ib3451b6a6860648f640a971ba2495816f8096840
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632592
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663929}

Change the icon of the relaunch notification. Use enterprise default
icon instead of SystemMenuUpdate icon.


Bug: 963883
Change-Id: I9246156160c9e7ede18298eaa89a2ebb1613e802
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630468Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Cr-Commit-Position: refs/heads/master@{#663928}

This further reduces back-and-forth flipping for LayoutNG, and makes it
clear that inspector highlight always uses physical coordinates.

Change-Id: Iecec0c03c2a1a14d8ad2aeb29f61f3a912d5d670
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625876
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663927}

Bug: none
Change-Id: I5faa2d53ffaf353d6209cfc68b5b0f83d6081f90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631941
Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663926}

This CL kills content protection tasks on display reconfiguration.
Clients are notified of failure, and are responsible for renewing
content protection requests.

Bug: 929449
Test: display_unittests
Change-Id: I9eb154becd1c0fd5b8988383592f5ee1d5f135c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597769
Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663925}

ee1d5124a2bf Fix incorrect range checks in elf image note reader

Bug: 967228, 967257, 967223
Change-Id: I3c6be7ab517b6f4a9c32ad2d607a2587b73d187e
TBR: jperaza@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630230
Commit-Queue: Scott Graham <scottmg@chromium.org>
Auto-Submit: Scott Graham <scottmg@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663924}

The device picker is the second step of the share experience that allows
users to choose which device to send the tab to.

This CL only contains the outline for the device picker.
Future CLs will add functionality, add polish, and wire
it to the share sheet.

Bug: 949223
Change-Id: I7ae8e3659c957acd0e33de33c4402562f577e91b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623601Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org>
Commit-Queue: Tanya Gupta <tgupta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663923}

Set the origin offset reference space on initialization. Otherwise, that
space will be null on the first call to onXRFrame and getViewerPose will
throw an exception, preventing the page from working.

Change-Id: Icf71ac3c8136e57906d01c3f8a4fdba8650f3495
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629693
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663922}

https://chromium.googlesource.com/external/github.com/material-components/material-components-ios/+log/f3f089d8833e..8d01645e5411


git log f3f089d8833e..8d01645e5411 --date=short --no-merges --format='%ad %ae %s'
2019-05-28 yarneo@gmail.com Merge branch 'release-candidate' into stable


Created with:
  gclient setdep -r src/ios/third_party/material_components_ios/src@8d01645e5411

The AutoRoll server is located here: https://autoroll.skia.org/r/material-components-ios-chromium

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:ios-internal-mdc
TBR=bling-p10-rolls@google.com

Change-Id: I21648fa87f2a1a2951b8445ee962486f6460bee8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632798Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#663921}

https://quiche.googlesource.com/quiche.git/+log/034c98c00b23..e01dd7043f7b

$ git log 034c98c00..e01dd7043 --date=short --no-merges --format='%ad %ae %s'
2019-05-21 dschinazi Clarify spdy response header log
2019-05-20 renjietang Refactor GetOrCreateStream() and GetOrCreateDynamicStream() and remove StreamHandler.
2019-05-20 fayang gfe-relnote: In QUIC, do not adjust burst token for bad bandwidth samples. Protected by gfe2_reloadable_flag_quic_conservative_bursts.
2019-05-20 renjietang Cloned from CL 231494986 by 'g4 patch'. Original change by bnc@bnc:majom-bnc-chromium-google3-headers-git5:2181:citc on 2019/01/29 16:21:02.
2019-05-20 wub gfe-relnote: (n/a) Remove parameter "reject_is_stateless" from function quic::test::crypto_test_utils::FillInDummyReject. Test only.
2019-05-20 rch Move the QuicEpollServerFactory out of quic_simple_server_bin.
2019-05-20 dschinazi Do not send retry token on non-initial packets
2019-05-20 dschinazi Rename connection_id to server_connection_id

Created with:
  roll-dep src/net/third_party/quiche/src

R=rch@chromium.org

Change-Id: I8e9a18cc23d7c6559758e4e4620907e30eea081a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631869
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663920}

There is a need to express localizable strings in //services code.
This CL introduces all the bits necessary to define translated resources
in a new //services/services_strings.grd file and moves a single string
(pertaining only to a service defined in //services) from the Chrome GRD
to the services GRD.

This is a precursor to simplifying expression of out-of-process service
registration by allowing service manifests to include a resource ID
directly in their definition.

Bug: 895615, 915806
Change-Id: I76d420266fb5528f407b624838172c267666654b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615701Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#663919}

As per the spec, the driver is expected to return a valid timestamp from
the call eglGetFrameTimestampsANDROID() when its not
EGL_TIMESTAMP_PENDING_ANDROID or EGL_TIMESTAMP_INVALID_ANDROID.
But currently few buggy drivers returns an invalid timestamp 0.

We fix/workaround this in chrome by returning the presentation time
as TimeTicks::Now() (snapped to the next vsync) instead of 0.

Bug: 966638
Change-Id: I5075dda0739f02029922ebbc20c09656fb0e87ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631354Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663918}

When an input_source is marked as removed, its gamepad needs to also be
marked as disconnected.  To facilitate writing tests for this, the blink
web_test mocks were also updated to allow for connecting/disconnecting a
gamepad object.

Also includes very minor cleanup to the test that was used as a pattern
when creating the newly added web_test.

Bug: 963013
Change-Id: Ia985b548dbc6b1e7052a6189a484b6a93298e2b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626885Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663917}

Bug: none
Change-Id: I05f25bc8f472d44660a8f98fb3b92b32ceebf3c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631940
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663916}

This "Turn off" button just resets the content setting to the default
setting, which is now BLOCK.

Bug: 965760
Change-Id: I32002bfdcad61ee36041d1ecb733b4cdc52981ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629041
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663915}

https://pdfium.googlesource.com/pdfium.git/+log/7eadbd640fc4..12d7da217249


git log 7eadbd640fc4..12d7da217249 --date=short --no-merges --format='%ad %ae %s'
2019-05-28 thestig@chromium.org Remove CPDF_Array::GetFloatAt().
2019-05-28 thestig@chromium.org Roll buildtools/ c79f3482c..0218c0f9a (18 commits; 5 trivial rolls)
2019-05-28 thestig@chromium.org Roll build/ 578c66146..4cebfa34c (159 commits)
2019-05-28 thestig@chromium.org Roll tools/code_coverage/ 90f3a1ede..b53d904eb (1 commit)
2019-05-28 thestig@chromium.org Roll tools/clang/ 2db48c749..9d46446d5 (6 commits)
2019-05-28 thestig@chromium.org Roll tools/clang/ 4e32649d7..2db48c749 (24 commits)
2019-05-28 thestig@chromium.org Roll third_party/catapult/ cca9447f6..a7b331246 (73 commits)
2019-05-28 thestig@chromium.org Roll third_party/depot_tools/ ccd2b4da9..26af0d34d (112 commits; 68 trivial rolls)
2019-05-28 thestig@chromium.org Roll third_party/icu/ ae4b77dc8..64e5d7d43 (4 commits)
2019-05-28 thestig@chromium.org Roll third_party/binutils/ 2be73f7fb..92bfa0a5d (1 commit)
2019-05-28 thestig@chromium.org Roll third_party/googletest/src/ 9997a830e..f71fb4f9a (8 commits)
2019-05-28 thestig@chromium.org Roll v8/ ed14aba38..c4c480a41 (655 commits)


Created with:
  gclient setdep -r src/third_party/pdfium@12d7da217249

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=pdfium-deps-rolls@chromium.org

Change-Id: Ia7c442f48a6df03779ea7b8254a8659a40e4a07d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632797Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#663914}

Recent UMA metrics suggest that AddLoginSync() unexpectedly fails to add
remote passwords the password manager when processing remote passwords
from the server. This CL is introducing a UMA metric to record the exact
reason of failure.

Bug: 902349
Change-Id: I71eaf22c35211f363123f21ef2d8dd78085206bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630478Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663913}

This CL does a few things to unify the usage of minimal_symbols
throughout mb_config.pyl:
1) It turns it on for all Goma mac builds, to match Win and other
   platforms
2) It removes it from configs which also specify release_trybot,
   where it is redundant
3) It renames a couple configs to better reflect their unique pieces

Bug: 966342
Change-Id: I6e12efbbe981e8eccbaa831430f8d833bd90e715
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628815
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663912}

With display locking, the subtree we have might not be laid out, and
is not visible. Hence, we should not generate subtree intersection
observations.

This patch implements this by skipping computation for locked subtree
elements.

R=chrishtr@chromium.org, rakina@chromium.org, szager@chromium.org

Bug: 945531
Change-Id: Iab4b91eb0c964a369901bc4ec322f4a421a8103f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614029Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663911}

These filed belonged "with the remote cocoa stuff", but at the time
there was no such place, or that place was tied to views, which didn't
seem right.

Now there is a "remote cocoa stuff for the browser process" place (well,
created by this patch).

Move the things that belong in that place to that place.

R=ellyjones
TBR=avi (content/)

Bug: 958255
Change-Id: I168a259403756cb429f772618161946373470db3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629042
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663910}

This reverts commit 1ffb9166. Since
we are coming up on the M76 branch point, restore the ZIP extraction
size limit. I'll roll this out when M75 is released, fixing the bug.

Bug: 959628
Change-Id: Iba156644101a1297cf03a129eea756020efe7fbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631895Reviewed-by: Nathan Parker <nparker@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663909}

With it we can know the associated blink-side identity of the cc layer,
e.g. the GraphicsLayer, DOM node, etc.

It also gives ForeignLayerDisplayItems meaningful debug names.

TBR=kylechar@chromium.org (for ui/compositor because of added 'const in a cc::LayerClient method)

Change-Id: I52f1839b406439fa2cf5b0a203a4e1f88929c345
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629292
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663908}

Previously the code used a |pendingOutput| string which was concatenated
with "+=" every time a new output line was added. Converting |pendingOutput|
to an Array and generating the final string only at the end is more
efficient.

Also performing some other minor cleanups.

Bug: None
Change-Id: I779ea4a0ea0097be70815f69759804b2e31d173b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629790
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663907}

In https://cr-rev.appspot.com/c/1594825 I refactored histogram reporting
and accidentally changed it to only report error values and never report
that a GWP-ASan crash was seen. Fix that.

Bug: 956824
Change-Id: I4a1a55fe45db380fc5a00952f304212698c37994
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632896
Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663906}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0210991491ea..fd40163541b4


Created with:
  gclient setdep -r src-internal@fd40163541b4

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com

Change-Id: I8fb753e9b0d66c0e39b2043bc545e3dda041a6aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632800Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#663905}

This is the 7th refactoring CL aimed at reducing duplication and
inconsistency for classifying omnibox results.

Navsuggests can come from either the search or zero suggest providers.
The zero suggest provider removes all bolding. Moreover, navsuggests do
not classify their descriptions (though they should and a future CL will
address this). So this CL impacts only search provider navsuggests'
contents.

In addition to migrating from unique classification logic to shared
classification methods, this CL affects the text and styling of
navsuggest contents:

1) Previously, navsuggests allowed mid-word matches; e.g., the user
input 'acebook' could match 'f[acebook].com'. With this CL, mid-word
matches are prohibited which is consistent with the other providers and
Google.com.

2) Previously, navsuggests did not break the user input into words;
e.g., the user input 'https://facebook' did not match
'https://m.facebook.com'. With this CL, the user input is broken into
words on whitespace and special characters, similar to other providers,
and the user input 'https://facebook' matches
'[https]://m.[facebook].com'.

3) Previously, navsuggests did not break the suggest text into words,
meaning the entirety of the user input must match; e.g., 'facebook.com/
learn' did not match 'facebook.com/business/learn'. With this CL, the
suggest text is also broken into words on whitespace and special
characters, similar to other providers, and the user input
'facebook.com/ learn' matches ‘[facebook.com]/business/[learn]’.

4) Navsuggests derive their content text from formatting their URLs.
They trim their URL prefixes if the user input does not match the
prefixes; e.g., the user input 'facebook.com' would hide 'https' and
'www' from the resulting navsuggests. Because of (2) and (3) above, the
user could explicitly type a prefix and it would be trimmed from the
navsuggest text anyways; e.g., the user input 'http/facebook.com' would
display the navsuggest 'facebook.com/device'. With this CL, the user
input 'http/facebook.com' will display the navsuggest
'[http]://[facebook].[com]/device'.

Bug: 366623
Change-Id: I3ae684c1ea0ea75c91ecf1bb2b702144ebf9d640
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562300
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663904}

Adds a class that enumerates the type of success or failue of a
CryptAuth v2 DeviceSync attempt as a
CryptAuthDeviceSyncResult::ResultCode. Instances of this class
potentially hold a new ClientDirective from the SyncMetadataResponse.
This object is passed to the CryptAuthScheduler after a DeviceSync
attempt finishes. The result code will be used for UMA metrics.

CryptAuthDeviceSyncResult is analogous to CryptAuthEnrollmentResult
which was used from CryptAuth v2 Enrollment.

Bug: 951969
Change-Id: Ie662e32a37718ade77f98ee127b52fb269aa37bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631764
Commit-Queue: Josh Nohle <nohle@chromium.org>
Auto-Submit: Josh Nohle <nohle@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663903}

Since UpdatePlayState() depends on |highest_ready_state_| we should call
it after SetReadyState() has been called. This is potentially causing
the perf issues on macOS.

BUG=965684

Change-Id: I053c71b2d1d5ffac5fa31de70e63c08488037a6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629588
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663902}

Instead of kUseTransforms from callers or forced by the implementation,
this CL make it by default. kIgnoreTransforms should be used if the
caller doesn't want transforms in some special cases.

To avoid accidentally changing the behavior, I created the final patch
in the following steps:
Step 1:
a) Added kIgnoreTransforms along with kUseTransforms in MapCoordinatesFlags;
b) Removed the default parameter values of MapCoordinatesFlags from
   geometry mapping functions;
c) Added DCHECK((mode & kIgnoreTransforms) || (mode & kUseTransforms)) to
   ensure that the caller must explicitly choose between kIgnoreTranforms
   and kUseTransforms;
d) Modified all callers to explicitly specify kIgnoreTransforms or
   kUseTransforms based on their original behavior.
e) Made all tests pass
https://chromium-review.googlesource.com/c/chromium/src/+/1621707/3

Step 2:
a) Remove kUseTransforms from MapCoordinatesFlags
b) Remove DCHECK((mode & kIgnoreTransforms) || (mode & kUseTransforms))
   from geometry mapping functions
c) Remove kUseTransforms from call sites

This CL should not change any existing behavior.

Change-Id: I860cde66f47f0c72509a21615afaefcb4851e4d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621707
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663901}

Cleans up some more code related to the removed functionality.

Bug: 931388
Change-Id: I971b25e5f8deefe24ef08ae4c2b4e8445d91c763
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629031Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663900}

This is where we actually use the cryptographer, or at least after
ongoing migrations are completed and SyncEncryptionHandlerImpl goes
away (replaced by NigoriSyncBridgeImpl).

Before we start refactorings, let's move the code to its final
location.

Bug: 967417
Change-Id: Ibef976dc05802585d872b937293098e76fd99c44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631652Reviewed-by: Adam Langley <agl@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663899}

Screenshot in bug.

Bug: 967356
Change-Id: Ife9734992e838236b38bb67dbb850111def88956
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631935
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Auto-Submit: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663898}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I680873cd19a6fdb0628236dbf9bcf326f090722f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632799Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#663897}

Texture::CompatibleWithSamplerUniformType only expects to run with
"renderable" textures, where the base level is initialized - in
particular it expects a valid internal_format/format/type.
Some old logic was skipping a check for GL_TEXTURE_EXTERNAL_OES,
allowing textures for which we didn't know the size, but that ends up
allowing uninitialized textures. Nowadays we should always know the size
even for those, so remove the logic skipping the initialized level check.

Bug: 966936
Change-Id: I61f64fe4fa7551ed7640f41fc0ea1111edb641bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629792
Auto-Submit: Antoine Labour <piman@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663896}

This module does not have actual tests yet, but it was tested with
print_js_egetest.mm which had local modifications.

Notable changes:
 - add ios_web_eg2tests_module module
 - rename ios_chrome_eg2_test_app_host to ios_chrome_eg2tests
 - rename ios_web_shell_test_app_host to ios_web_shell_eg2tests
 - rename ios_web_shell_eg2tests to ios_web_shell_eg2tests_module

Bug: 866147
Change-Id: I38e0ab1b76ba9cc56bb2b0af0cfc731d03b36f69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628171Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663895}

Bug: 649904,893460
Change-Id: Ibcc86ddb575d939bf27bf754b4fcf84d1c75767d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622599Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Tom Tan <Tom.Tan@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#663894}