GitLab

For repaint tests, compute minimum repaint by comparing pixel dump
before and after repaintTest() and output repaint in layout test result.

In overlay, visualize the minimum repaint in expected results.

In this way, when making repaint change and checking actual results,
we can easily discover under-repaint bugs if we see any solid black
area not covered by repaint rects.

This CL depends on chromium-side CL https://codereview.chromium.org/301243022.

Review URL: https://codereview.chromium.org/315443002

git-svn-id: svn://svn.chromium.org/blink/trunk@176257 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL takes care the testing, timing, workers and xml subdirs under core.

BUG=381876

Review URL: https://codereview.chromium.org/339573006

git-svn-id: svn://svn.chromium.org/blink/trunk@176256 bbb929c8-8fbe-4397-9dbb-9b2b20218538

bonus: sort entries on serviceworker expectations section.

NOTRY=true
BUG=385384, 364390

Review URL: https://codereview.chromium.org/339013002

git-svn-id: svn://svn.chromium.org/blink/trunk@176255 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=dpranke@chromium.org
BUG=

Review URL: https://codereview.chromium.org/338233002

git-svn-id: svn://svn.chromium.org/blink/trunk@176254 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Drop traverseNextElement() method from HTMLCollection class to avoid code
duplication with traverseForwardToOffset(). This method was only used
by supportedPropertyNames() and updateIdNameCache(). Now these methods
uses the standard traversal API (HTMLCollection::length() / item(index)),
and thus the standard code path for HTMLCollection traversal.

I did not see any regression with this change on Dromaeo:
http://dromaeo.com/?id=223149,223150

R=adamk@chromium.org, esprehn@chromium.org

Review URL: https://codereview.chromium.org/336133002

git-svn-id: svn://svn.chromium.org/blink/trunk@176253 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We can't enable Oilpan for ImageBitmapFactories, another class in
modules/imagebitmap/, because it's a Supplement of DOMWindow or
WorkerGlobalScope.

BUG=340522

Review URL: https://codereview.chromium.org/323293004

git-svn-id: svn://svn.chromium.org/blink/trunk@176252 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We check for form inputs in blockSuppressesAutosizing, but the block
must be a potential cluster root to reach this check.

BUG=376012

Review URL: https://codereview.chromium.org/334333002

git-svn-id: svn://svn.chromium.org/blink/trunk@176251 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=abarth@chromium.org
CC=jkarlin@chromium.org, japhet@chromium.org

Review URL: https://codereview.chromium.org/338093006

git-svn-id: svn://svn.chromium.org/blink/trunk@176250 bbb929c8-8fbe-4397-9dbb-9b2b20218538

WEB_AUDIO and SVG_FONTS conditions in tagName files were 
handled by generate scripts and this CL adds the support. 
This fix was also needed to build without SVG_FONTS enabled.

Review URL: https://codereview.chromium.org/330093002

git-svn-id: svn://svn.chromium.org/blink/trunk@176249 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=305497

Review URL: https://codereview.chromium.org/328263003

git-svn-id: svn://svn.chromium.org/blink/trunk@176248 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove inefficiency from HTMLCollection::namedItems(). The code was
unnecessarily checking that the pointers were non-null for every iteration of
the for loops. This CL updates the code so that the null check is done only
once.

R=esprehn@chromium.org, adamk@chromium.org

Review URL: https://codereview.chromium.org/337963002

git-svn-id: svn://svn.chromium.org/blink/trunk@176247 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=vsevik@chromium.org
BUG=354447

Review URL: https://codereview.chromium.org/331313002

git-svn-id: svn://svn.chromium.org/blink/trunk@176246 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The main frame might be null, so we need to check that before trying to
dereference it to see if it's a local frame.

BUG=385162

Review URL: https://codereview.chromium.org/334323002

git-svn-id: svn://svn.chromium.org/blink/trunk@176245 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Force the use of fully aliased text for certain common east asian fonts
at smaller font sizes to ensure that text is legible. This is only
required for fonts without an embedded bitmap at a the specific size and
the minimum size for enabling anti aliasing is set on a per font basis.

BUG=383090,383040
R=dglazkov@chromium.org, cpu@chromium.org

Review URL: https://codereview.chromium.org/339693002

git-svn-id: svn://svn.chromium.org/blink/trunk@176244 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Universal accelerated overflow scroll doesn't paint
highlight gaps between scroll children because the
scrolling contents layer isn't always set up to
draw content.

BUG=381185,381187

Review URL: https://codereview.chromium.org/303253004

git-svn-id: svn://svn.chromium.org/blink/trunk@176243 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=371746

Review URL: https://codereview.chromium.org/339703002

git-svn-id: svn://svn.chromium.org/blink/trunk@176241 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TEST=none
BUG=383749
R=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/334263005

git-svn-id: svn://svn.chromium.org/blink/trunk@176240 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Have NodeList::item() overrides return an Element* when appropriate instead
of a generic Node*. This makes it clear to callers that these are actually
returning Elements and avoids unnecessary isElementNode() checks or casts
that look unsafe.

R=adamk@chromium.org, esprehn@chromium.org

Review URL: https://codereview.chromium.org/331863003

git-svn-id: svn://svn.chromium.org/blink/trunk@176239 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[webcrypto] Require importKey() for JWK to provide data as a Javascript object rather than a JSON arraybuffer.

BUG=373917,245025

Review URL: https://codereview.chromium.org/336173002

git-svn-id: svn://svn.chromium.org/blink/trunk@176238 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL takes care the page, plugins, rendering, and svg subdirs under core.

BUG=381876

Review URL: https://codereview.chromium.org/334223005

git-svn-id: svn://svn.chromium.org/blink/trunk@176237 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Original patch from http://trac.webkit.org/changeset/169849

We were getting the length of the string before calling lower() on
it but we were looping over the new string which might have a
different length than the original.

BUG=383704

Review URL: https://codereview.chromium.org/333643008

git-svn-id: svn://svn.chromium.org/blink/trunk@176235 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL takes care the inspector and loader subdirs under core.

BUG=381876

Review URL: https://codereview.chromium.org/337873003

git-svn-id: svn://svn.chromium.org/blink/trunk@176234 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We currently use 26-bits in RenderBlock to cache the result of
RenderStyle::computedLineHeight(). However when you look at the
computations behind that function the main components are already cached
so at most we are saving a handful of computations per call.

In https://codereview.chromium.org/256593009/ we added a test that calls
RenderBlock::lineHeight() ~425,000 times on each run. This CL results in
no measurable degradation in performance against that test.

So since we cannot get a measurable improvement in performance as a result
of the caching when testing locally, remove it and free up space for more useful
bits in RenderBlock. We will let it cycle through the perf bots for a while
before allowing people to start using the spare bits though.

The cached result originally sat in RenderText and was inherited from the
fork from KHTML. http://trac.webkit.org/changeset/6010 moved it to RenderBlock
on the basis that "calls to fontMetrics().lineSpacing() are expensive." This
is no longer the case as far as I can tell, since both lineSpacing() and
fontMetrics() are now cached themselves.

Review URL: https://codereview.chromium.org/260073005

git-svn-id: svn://svn.chromium.org/blink/trunk@176233 bbb929c8-8fbe-4397-9dbb-9b2b20218538

WebLocalFrameImpl::createChildFrame needs to keep a reference to the
WebCore::LocalFrame in case LocalFrame::init() detaches the frame.

BUG=384890
TEST=fast/loader/create-frame-in-DOMContentLoaded.html
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/339513002

git-svn-id: svn://svn.chromium.org/blink/trunk@176232 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Revert of IDL: Support optional argument default value syntax (https://codereview.chromium.org/339683002/)

Reason for revert:
Revert the revert because the bot went green even without this revert, and other bots had no trouble.

Original issue's description:
> Revert of IDL: Support optional argument default value syntax (https://codereview.chromium.org/312683005/)
> 
> Reason for revert:
> This patch is the most likely candidate for browser test failures: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2905
> 
> BrowserTestBase signal handler received SIGTERM. Backtrace:
> #0 0x7f2c2a201a1d base::debug::StackTrace::StackTrace()
> #1 0x00000460caf2 content::(anonymous namespace)::DumpStackTraceSignalHandler()
> #2 0x7f2c232cd4a0 \u003Cunknown>
> #3 0x7f2c2337f313 __poll
> #4 0x7f2c240b6036 \u003Cunknown>
> #5 0x7f2c240b6164 g_main_context_iteration
> #6 0x7f2c2a1c9b45 base::MessagePumpGlib::Run()
> #7 0x7f2c2a29eed7 base::MessageLoop::RunHandler()
> #8 0x7f2c2a2f69d8 base::RunLoop::Run()
> #9 0x00000466bd59 content::RunThisRunLoop()
> #10 0x00000466c1b8 content::MessageLoopRunner::Run()
> #11 0x000004610946 content::TitleWatcher::WaitAndGetTitle()
> #12 0x0000011fdf00 MediaBrowserTest::RunTest()
> #13 0x0000011fdc00 MediaBrowserTest::RunMediaTestPage()
> #14 0x0000011ec98b EncryptedMediaTestBase::RunEncryptedMediaTestPage()
> #15 0x0000011ee5fa EncryptedMediaTest::TestConfigChange()
> #16 0x0000011eb73a EncryptedMediaTest_ConfigChangeVideo_Test::RunTestOnMainThread()
> ...
> 
> Please look into it. An alterate possible candidate is  https://codereview.chromium.org/327553002 but I think that's less likely.
> 
> Original issue's description:
> > IDL: Support optional argument default value syntax
> > 
> > Adds support for parsing default values of different types, but
> > only handles null default values when generating code.
> > 
> > Replaces existing
> > 
> >   [Default=Null] optional SomeInterface arg
> >   [Default=NullString] optional DOMString arg
> > 
> > with the now equivalent
> > 
> >   optional SomeInterface arg = null
> >   optional DOMString arg = null
> > 
> > in IDL files, and drops support for those [Default] attributes.
> > 
> > No changes to generated code.
> > 
> > BUG=258153
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176200
> 
> TBR=nbarth@chromium.org,haraken@chromium.org,pavan.e@samsung.com,jsbell@chromium.org,jl@opera.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=258153
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176220

TBR=nbarth@chromium.org,haraken@chromium.org,pavan.e@samsung.com,jsbell@chromium.org,jl@opera.com
NOTREECHECKS=true
NOTRY=true
BUG=258153

Review URL: https://codereview.chromium.org/339723002

git-svn-id: svn://svn.chromium.org/blink/trunk@176231 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change moves most of the emulation under |emulateDevice| setting.

BUG=327641

Review URL: https://codereview.chromium.org/330223004

git-svn-id: svn://svn.chromium.org/blink/trunk@176230 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/331143005

Review URL: https://codereview.chromium.org/331143005

git-svn-id: svn://svn.chromium.org/blink/trunk@176229 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361045

Review URL: https://codereview.chromium.org/337123002

git-svn-id: svn://svn.chromium.org/blink/trunk@176228 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Url for this event is retrieved from imageURL field later in the same switch.

BUG=361045

Review URL: https://codereview.chromium.org/339603002

git-svn-id: svn://svn.chromium.org/blink/trunk@176227 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1. Open page with javascript
2. Add breakpoint
3. Stop on breakpoint
4. Use live edit and save script
The test worked for Chromium revision until May 30.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176101

Review URL: https://codereview.chromium.org/329533002

git-svn-id: svn://svn.chromium.org/blink/trunk@176226 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is based on Aaron Colwell's patch:
https://codereview.chromium.org/170233009/#ps270001

BUG=249427
TEST=LayoutTests/media/avtracklists.html

Review URL: https://codereview.chromium.org/284513003

git-svn-id: svn://svn.chromium.org/blink/trunk@176224 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There use to be isBackground field on Timeline events but it has been removed.

BUG=None

Review URL: https://codereview.chromium.org/334743008

git-svn-id: svn://svn.chromium.org/blink/trunk@176223 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Implement Battery Status API using promises in blink as
according to the (modified) spec:
https://dvcs.w3.org/hg/dap/raw-file/tip/battery/Overview.html.
Using this patch the Battery Status API is accessible using:
navigator.getBattery().then(...) syntax.

Also added layout tests for the various use-cases.

BUG=122593, 360068

Review URL: https://codereview.chromium.org/329723005

git-svn-id: svn://svn.chromium.org/blink/trunk@176222 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=272416
R=yurys@chromium.org, pfeldman@chromium.org

Review URL: https://codereview.chromium.org/332493002

git-svn-id: svn://svn.chromium.org/blink/trunk@176221 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of IDL: Support optional argument default value syntax (https://codereview.chromium.org/312683005/)

Reason for revert:
This patch is the most likely candidate for browser test failures: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2905

BrowserTestBase signal handler received SIGTERM. Backtrace:
#0 0x7f2c2a201a1d base::debug::StackTrace::StackTrace()
#1 0x00000460caf2 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7f2c232cd4a0 \u003Cunknown>
#3 0x7f2c2337f313 __poll
#4 0x7f2c240b6036 \u003Cunknown>
#5 0x7f2c240b6164 g_main_context_iteration
#6 0x7f2c2a1c9b45 base::MessagePumpGlib::Run()
#7 0x7f2c2a29eed7 base::MessageLoop::RunHandler()
#8 0x7f2c2a2f69d8 base::RunLoop::Run()
#9 0x00000466bd59 content::RunThisRunLoop()
#10 0x00000466c1b8 content::MessageLoopRunner::Run()
#11 0x000004610946 content::TitleWatcher::WaitAndGetTitle()
#12 0x0000011fdf00 MediaBrowserTest::RunTest()
#13 0x0000011fdc00 MediaBrowserTest::RunMediaTestPage()
#14 0x0000011ec98b EncryptedMediaTestBase::RunEncryptedMediaTestPage()
#15 0x0000011ee5fa EncryptedMediaTest::TestConfigChange()
#16 0x0000011eb73a EncryptedMediaTest_ConfigChangeVideo_Test::RunTestOnMainThread()
...

Please look into it. An alterate possible candidate is  https://codereview.chromium.org/327553002 but I think that's less likely.

Original issue's description:
> IDL: Support optional argument default value syntax
> 
> Adds support for parsing default values of different types, but
> only handles null default values when generating code.
> 
> Replaces existing
> 
>   [Default=Null] optional SomeInterface arg
>   [Default=NullString] optional DOMString arg
> 
> with the now equivalent
> 
>   optional SomeInterface arg = null
>   optional DOMString arg = null
> 
> in IDL files, and drops support for those [Default] attributes.
> 
> No changes to generated code.
> 
> BUG=258153
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176200

TBR=nbarth@chromium.org,haraken@chromium.org,pavan.e@samsung.com,jsbell@chromium.org,jl@opera.com
NOTREECHECKS=true
NOTRY=true
BUG=258153

Review URL: https://codereview.chromium.org/339683002

git-svn-id: svn://svn.chromium.org/blink/trunk@176220 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL removes the setting of the first party for cookies url from
FrameFetchContext::addAdditionalRequestHeaders. For request going through the
ResourceFetcher, it will be added in content::RenderFrameImpl::willSendRequest (see https://chromiumcodereview.appspot.com/317853002/).
Other users of the function (BeaconLoader, PingLoader) can use a new specific
function of FetchContext.

BUG=376025

Review URL: https://codereview.chromium.org/314093002

git-svn-id: svn://svn.chromium.org/blink/trunk@176219 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none
TEST=compile

Review URL: https://codereview.chromium.org/331083003

git-svn-id: svn://svn.chromium.org/blink/trunk@176218 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Avoids its unnecessary persistents by doing so.

R=tkent@chromium.org
BUG=357163

Review URL: https://codereview.chromium.org/333313002

git-svn-id: svn://svn.chromium.org/blink/trunk@176217 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL takes care the rest part of html subdirs under core.

BUG=381876

Review URL: https://codereview.chromium.org/338123002

git-svn-id: svn://svn.chromium.org/blink/trunk@176216 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=376194

Review URL: https://codereview.chromium.org/337753004

git-svn-id: svn://svn.chromium.org/blink/trunk@176215 bbb929c8-8fbe-4397-9dbb-9b2b20218538