GitLab

Whether or not Windows Aero is enabled on Windows platforms changes
whether a dialog is owned as a transient child or a child widget, and
this distinction is not useful. Changed Widget::GetAllOwnedWidgets to
return child widgets as well so widgets like dialogs can be detected in
tests and at runtime, without special checks for whether Aero is
currently enabled.

This also fixes the test AppListControllerAppInfoDialogBrowserTest.

BUG=378251

Review URL: https://codereview.chromium.org/588113002

Cr-Commit-Position: refs/heads/master@{#301055}

This provides the image assets for
https://codereview.chromium.org/664503006/

BUG=420813
TBR=bauerb@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/679503003

Cr-Commit-Position: refs/heads/master@{#301054}

There are reports of crashes in DeviceInfoDataTypeController destructor. The
crash occurs when DeviceInfoDataTypeController has a pending subscription to
LocalDeviceInfoProvider and LocalDeviceInfoProvider gets destroyed first. This
doesn't happen normally as the subscription gets cleared once
LocalDeviceInfoProvider finishes its initialization.

The fix is to clear subscription in StopModel overrides in the two classes that
hold DeviceInfoDataTypeController::Subscription.

BUG=426205

Review URL: https://codereview.chromium.org/672863002

Cr-Commit-Position: refs/heads/master@{#301053}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/355414e..721f3e2

TBR=kochi@chromium.org,leviw@chromium.org

Review URL: https://codereview.chromium.org/671333003

Cr-Commit-Position: refs/heads/master@{#301052}

Before, we were using a timer in hope that the operation is started
synchronously, but it's a wrong assumption.

This patch resolves this issue by waiting until writing is really
started.

TEST=browser_test: *FileSystemProvider*Write*
BUG=426549

Review URL: https://codereview.chromium.org/677593002

Cr-Commit-Position: refs/heads/master@{#301051}

Review URL: https://codereview.chromium.org/638293007

Cr-Commit-Position: refs/heads/master@{#301050}

BUG=426600

Review URL: https://codereview.chromium.org/645703004

Cr-Commit-Position: refs/heads/master@{#301049}

gpu_info.h depended on media/video and media/ depended on gpu/.
gpu/ and media/ had a dependency cycle. Duplicate VEA::SupportedProfile
to gpu_info.h so gpu does not depend on media.

BUG=420801
TEST=Run apprtc loopback and ensure it uses HW encoder.

Review URL: https://codereview.chromium.org/668633002

Cr-Commit-Position: refs/heads/master@{#301048}

The patch has caused compilation error again.

TBR=sashab
NOTREECHECK=true

> This reverts commit 11778438.
>
> Enabled the App Info dialog on the Extensions page by default
>
> Changed the flag '--enable-extension-info-dialog' to
> '--disable-extension-info-dialog', which enables the App Info dialog as
> the default dialog for displaying permissions on the extensions page.
> Does not affect Mac platforms (where the old-style dialog is still
> used).
>
> BUG=395495
> Committed: https://crrev.com/a867ca2b5e42207b65e9d07702138ff79bed0bb0
> Cr-Commit-Position: refs/heads/master@{#301006}
>
> Committed: https://crrev.com/11778438dcb7670324f52e5df111e4007b9224ac
> Cr-Commit-Position: refs/heads/master@{#301046}

Review URL: https://codereview.chromium.org/671373002

Cr-Commit-Position: refs/heads/master@{#301047}

Changed the flag '--enable-extension-info-dialog' to
'--disable-extension-info-dialog', which enables the App Info dialog as
the default dialog for displaying permissions on the extensions page.
Does not affect Mac platforms (where the old-style dialog is still
used).

BUG=395495

Committed: https://crrev.com/a867ca2b5e42207b65e9d07702138ff79bed0bb0
Cr-Commit-Position: refs/heads/master@{#301006}

Review URL: https://codereview.chromium.org/668163002

Cr-Commit-Position: refs/heads/master@{#301046}

This skia API is marked as deprecated, so we need to remove all usages
of it, to be able to remove it in Skia.

BUG=None
TEST=None
TBR=skyostil@chromium.org

Review URL: https://codereview.chromium.org/669303005

Cr-Commit-Position: refs/heads/master@{#301045}

According to the DOM 3 Spec,
http://www.w3.org/TR/DOM-Level-3-Events-code/
the code value for VKEY_LCONTROL should be ControlLeft instead CtrlLeft.
(The same is also true for VKEY_RCONTROL)

BUG=426660

Review URL: https://codereview.chromium.org/640143003

Cr-Commit-Position: refs/heads/master@{#301044}

R=msw@chromium.org
BUG=366092

Review URL: https://codereview.chromium.org/420533002

Cr-Commit-Position: refs/heads/master@{#301043}

This does not change any behavior. It updates the test harness to write the already-computed autofill section to the output, and updates the expected outputs to include this data.

This will make it possible to add tests for this in a later pass.

Review URL: https://codereview.chromium.org/673923002

Cr-Commit-Position: refs/heads/master@{#301042}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0e04a3f..355414e

TBR=kochi@chromium.org,leviw@chromium.org

Review URL: https://codereview.chromium.org/680433002

Cr-Commit-Position: refs/heads/master@{#301041}

Has the benefit of looking a lot like an <a> tag naturally without a whole
bunch of CSS resetting. Also lacks the extra context menu options
(e.g. "Copy link location...") like <a href> has.

Replaces <button class="link-button">, which has always been odd to me.

BUG=399376
R=dmazzoni@chromium.org,aboxhall@chromium.org
TBR=fukino@chromium.org

Review URL: https://codereview.chromium.org/668983004

Cr-Commit-Position: refs/heads/master@{#301040}

This actually hooks up (i.e. passes from invoker) several variables
controlling apk creation (version name, version code,
use_relocation_packer, use_chromium_linker, unzip_libraries_from_apk).

Adds support for overriding some configuration in the private repo.

Adds support for public_configs in grit_rule.gni.

Adds some junit targets (these are built as android libraries currently
instead of host libraries, but that just means we do a bit extra work
that we don't really need).

BUG=359249

Review URL: https://codereview.chromium.org/659703002

Cr-Commit-Position: refs/heads/master@{#301039}

This code is being developed and tested in the mojo repository.

R=dpranke@chromium.org
TBR=navabi@chromium.org

Review URL: https://codereview.chromium.org/679553002

Cr-Commit-Position: refs/heads/master@{#301038}

This CL is to build ipc/ for nacl_helper_nonsfi.
The library is similar to ipc_nacl, but slightly different:
- The IPC::Channel should use ChannelPosix rather than ChannelNaCl,
  as it runs under linux directly.
- Some features of ChannelPosix cannot be compiled by PNaCl toolchain for
  Non-SFI build, but these are not necessary for nacl_helper_nonsfi.
  These are dropped by "ifdef" guard.
Note that this library is not used yet, but should be built successfully.

BUG=358465
TEST=Ran trybot. Implement nacl_helper_nonsfi on top of this CL, and made sure it works.

Review URL: https://codereview.chromium.org/659243002

Cr-Commit-Position: refs/heads/master@{#301037}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/11ed6b8..976386b

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/674043002

Cr-Commit-Position: refs/heads/master@{#301036}

The geometry headers were moved from /ui/gfx/ to ui/gfx/geometry, so we
are updating the include paths to fix this.

BUG=395370
TEST=None
TBR=ben@chromium.org,danakj@chromium.org

Review URL: https://codereview.chromium.org/669153008

Cr-Commit-Position: refs/heads/master@{#301035}

This partially reverts r300403. The test was still flaking on ChromeOS.

BUG=387045

Review URL: https://codereview.chromium.org/669333002

Cr-Commit-Position: refs/heads/master@{#301034}

Added folks who are familiar with the code.

TEST=None
BUG=None

Review URL: https://codereview.chromium.org/672423002

Cr-Commit-Position: refs/heads/master@{#301033}

BUG=None.
TEST=None.
R=tonyg

Review URL: https://codereview.chromium.org/588313002

Cr-Commit-Position: refs/heads/master@{#301032}

This adds a missing change from
https://crrev.com/680be408457f4272b468e72468eb22e1c0f0b67a

NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/673773003

Cr-Commit-Position: refs/heads/master@{#301031}

This reverts commit a867ca2b.

This CL forgot to change
chrome/browser/ui/webui/extensions/extension_settings_handler.cc
which resulted in compilation errors.

E.g.
http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Full/builds/6096

BUG=426717
TBR=sashab@chromium.org, thestig@chromium.org, asvitkine@chromium.org, benwells@chromium.org, mpearson@chromium.org

Review URL: https://codereview.chromium.org/650033006

Cr-Commit-Position: refs/heads/master@{#301030}

This CL renames a couple functions in order to try to more accurately reflect what they do:
  BuildCurrentRevision -> _ObtainBuild
  DownloadCurrentBuild -> _DownloadAndUnzipBuild

This CL breaks two sub-functions out of DownloadCurrentBuild:
  _WaitForBuildDownload
  _UnzipAndMoveBuildProducts

Note: Later, I plan to replace _GetBuildArchiveForRevision with fetch_build.FetchBuild, and possibly change _UnzipAndMoveBuildProducts so that it doesn't do unzipping, since unzipping is done in fetch_build.FetchBuild. Either that, or make it so that unzipping isn't done in that function.

BUG=

Review URL: https://codereview.chromium.org/664793002

Cr-Commit-Position: refs/heads/master@{#301029}

Previously, this was a private class in app_list_folder_item.cc. It will
soon be required from multiple locations (to generate folder icons), so
it deserves its own file.

Also moved methods/constants relating to the tiny icon size/position
into static methods of this class (as needed by various clients).

BUG=425444

Review URL: https://codereview.chromium.org/657793004

Cr-Commit-Position: refs/heads/master@{#301028}

BUG=424596
TEST=manual

Review URL: https://codereview.chromium.org/653423004

Cr-Commit-Position: refs/heads/master@{#301027}

BUG=417859

Review URL: https://codereview.chromium.org/601413003

Cr-Commit-Position: refs/heads/master@{#301026}

BUG=424113

Review URL: https://codereview.chromium.org/660023002

Cr-Commit-Position: refs/heads/master@{#301025}

Review URL: https://codereview.chromium.org/638273004

Cr-Commit-Position: refs/heads/master@{#301024}

Browser::ShowDownload does not try to close the web contents if there is
no corresponding tab. This avoids hitting a NOTREACHED later on which
checks for this case.

BUG=424413

Review URL: https://codereview.chromium.org/666803002

Cr-Commit-Position: refs/heads/master@{#301023}

This includes a fix for sites which renegotiate a different cipher suite. This
picks up the following changes:

751e889 Add SSL_SESSION serialization and deserialization tests.
d7a76e7 Remove key_arg and key_arg_length from SSL_SESSION.
a19fc25 Move ECC extensions out of SSL_SESSION.
4a67415 Set the IV length for AES-ECB to zero.
721e6e1 Don't read past the end of the string in BUF_strndup.
b698617 Add CBS_peek_asn1_tag.
7f7882f Remove obsolete TODO
a650e05 Fix pqueue_test.c memory leak.
3831173 Fix memory leak when decoding corrupt tickets.
88333ef Fix switching between AEAD and non-AEAD in a renegotiation.
0248889 Don't mix and match libraries and errors.

BUG=423998

Review URL: https://codereview.chromium.org/673913002

Cr-Commit-Position: refs/heads/master@{#301022}

Merged all the permissions in the App Info dialog (including files and
retained devices) into a single list. Also moved the two 'revoke'
buttons to just be X's next to their respective entries in the list.
Screenshots on bug.

BUG=420461

Review URL: https://codereview.chromium.org/661353002

Cr-Commit-Position: refs/heads/master@{#301021}

BUG=426271
R=piman@chromium.org

Review URL: https://codereview.chromium.org/676823002

Cr-Commit-Position: refs/heads/master@{#301020}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e64b597..0e04a3f

TBR=kochi@chromium.org,leviw@chromium.org

Review URL: https://codereview.chromium.org/673793003

Cr-Commit-Position: refs/heads/master@{#301019}

R=zea@chromium.org

Review URL: https://codereview.chromium.org/673933002

Cr-Commit-Position: refs/heads/master@{#301018}

Hide the second 'Details' link on extensions page if the Extension
Info Dialog is enabled. Screenshots on bug.

BUG=395495

Review URL: https://codereview.chromium.org/664473005

Cr-Commit-Position: refs/heads/master@{#301017}

BUG=chromedriver:944

Review URL: https://codereview.chromium.org/663343003

Cr-Commit-Position: refs/heads/master@{#301016}