- 19 May, 2020 40 commits
-
-
Christopher Lam authored
This CL adds easy file path override points for changes that need to be made to bring the Style Variable Generator into google3. Bug: 1018654 Change-Id: I4b8fd9de2baeaf7972c9319a05551df32c26b50f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198702Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#770008}
-
Roman Sorokin authored
The feature was never fully implemented Fixed: 899812 Change-Id: I6e813038fc20c1aab4ef785b7099d0a601b46b2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198985Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770007}
-
Yuki Shiino authored
Prints a warning message to the inspector's console when an invalid enum value is set to an IDL attribute. Bug: 839389 Change-Id: I27f12b5af8b510ea748ef2b3238af4d40e7e485a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202831 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#770006}
-
Yuki Shiino authored
In case of IDL primitive types, applies strict typing to bindings::V8SetReturnValue. Bug: 839389 Change-Id: Ia059a21ed120b6e31e35c8431a7357e07ae6e2ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202830Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1c8cab8f9441..7fd030c0d06f Created with: gclient setdep -r src-internal@7fd030c0d06f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shend@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: shend@google.com Change-Id: I9455b7e97d76922c29d1a3d3bc766280d9f6e671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208457Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770004}
-
Yuki Yamada authored
Removes a WeakPtrFactory for WorkerAnimationFrameProvider which is a BlinkGC class. Change-Id: I18d0af057804cef01abefe3229627d706d6cf90d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208153Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Yuki Yamada <yukiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#770003}
-
Ankit Kumar authored
This CL adds a browser test for TouchSelectionMenu in PDF. There is no utility class which could help in determining when touch selection menu is opened. This CL adds TouchSelectionMenuWaiter() to determine when touch selection menu is shown and helps in executing commands on the touch selection menu. Fix some nits in TouchSelectionMenuViews along the way. This CL originally landed as https://crrev.com/c/2082750 but got reverted in https://crrev.com/c/2178584 due to failures on bots with CFI enabled. The static cast from View to TouchSelectionMenuViews should be safe but for some reason CFI bot isn't happy. Given we don't need TouchSelectionMenuViews and View can satisfy the test, using View instead of casting to TouchSelectionMenuViews. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_cfi_rel_ng Bug: 1027842 Change-Id: Ia055dd15caf894fad64e2a35fed524244ed598f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203785 Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:Peter Kasting <pkasting@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#770002}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e67e41aa8994..5a7be3da2119 git log e67e41aa8994..5a7be3da2119 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 yekuang@google.com Roll out new goma client binary VERSION=200 Created with: gclient setdep -r src/third_party/depot_tools@5a7be3da2119 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Idba87111ad7217b52e537c996aee6e1cc9f77d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208464Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770001}
-
Takashi Toyoshima authored
To reduce risks for launching OOR-CORS on WebView 83/84, we temporarily disable the kStrictAccessControlAllowListCheck for M84. Once this patch is merged to the M84 branch, I will quickly revert this for M85. Bug: 1084376 Change-Id: I2256eed511ea995bad91b611f976d72eb228443b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206861 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#770000}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7a4ea2baf5df..de89a4a8e174 git log 7a4ea2baf5df..de89a4a8e174 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d34ab323f368..fabf74bda604 (4 commits) Created with: gclient setdep -r src/third_party/skia@de89a4a8e174 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: If8a3eaa50fcbf60e6f35332b92ee12c2cedcfe09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208463Reviewed-by:
-
John Abd-El-Malek authored
This makes it less error prone that an embedder would forget to call these methods on their profiles. e.g. WebLayer didn't do it correctly (see r769103). The one behavior change is to stop calling content::UpdateCorsExemptHeader() for the system network contexts in chrome, cast, and weblayer. This shouldn't be needed because web pages don't request URLs through these network contexts. Change-Id: I53d8aec24a6b129a1a711df6c8e6168068434807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203759 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#769998}
-
Samuel Huang authored
DeltaSymbolGroup.CountUniqueSymbols() sums separate unique leaf symbol counts in "before" and "after". Previously this was done via temporary SymbolGroups and using their CountUniqueSymbols(). As a memory optimization, both temporary SymbolGroups were given Symbol iterators at construction. However, the |_symbols| member become single- use as a result. This violates the immutability property of the object, and causes problem as we plan to process |_symbols| in upcoming work to add multi-container support. A short fix is to convert input and make |_symbols| as a list, but this is opaque, and undoes the optimization above. This CL makes the following changes instead: * Assert that SymbolGroup() is given list at construction. * Replace SymbolGroups.IterUniqueSymbols() with a static generator SymbolGroups.IterUnique() that takes an input iterator. * All callers undergo minor change. * Callers of {Delta}SymbolGroups.CountUniqueSymbol() are unchanged. * Update DeltaSymbolGroup.CountUniqueSymbols() to use the new interface, without needing temporary SymbolGroups. Optimization is kept. Bug: 1040645 Change-Id: I32c3867fe006a078f9a6ddcf764349b360120e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204304 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#769997}
-
rbpotter authored
Adding closure compilation for destination_settings_test. This also requires adding compilation for cloud_print_interface_stub and native_layer_stub. Bug: 1000989 Change-Id: Ie8ca55910c869208d0833bed8ca47676f84052e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204531 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#769996}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e25ee25e7743..949f1e45f1dc git log e25ee25e7743..949f1e45f1dc --date=short --first-parent --format='%ad %ae %s' 2020-05-19 natlee@microsoft.com Refactor MapRequestTracker to be its own class file. 2020-05-19 jiawei.shao@intel.com Disallow the copies within the same buffer 2020-05-18 hugo.amiard@laposte.net D3D12: Implement UseDxc toggle to use DXC for HLSL compilation Created with: gclient setdep -r src/third_party/dawn@949f1e45f1dc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I0cab6148884cf11e81105bc7d999b9d2f7e006e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208462Reviewed-by:
-
rbpotter authored
- Add closure targets for Print Preview test directory - Closure compile test utils and advanced_dialog_test - Resolve a circular dependency between print_preview_test_utils and native_layer_stub. - Add print_preview target in c/b/r/print_preview/BUILD.gn Bug: 1000989 Change-Id: Iba95a93b9c974c382fd7fd222f393861a2fae07a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204271 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Wei Lee authored
Since we already removed GCA and Migration app from latest image, we don't need to use preference service in Chrome to store the migration status. Instead, we can use local storage for it. Bug: 980846 Test: Launch CCA and it works normally Change-Id: I99c9a11f1dc4cdc5ebe871367cd596e7e0a66f3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132646 Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#769993}
-
Yuke Liao authored
TBR=thakis@chromium.org Cq-Include-Trybots: chrome/try:mac-chrome Cq-Include-Trybots: chrome/try:win-chrome Cq-Include-Trybots: chrome/try:win64-chrome Bug: 1071576 Change-Id: Ia1972fc48ffee6957bffa7d2639ae7a30817a01f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208029Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#769992}
-
Maksim Sisov authored
Just moving ScopedWlArray into a shared place and making the SendConfigureEvent available for other tests. It also automatically sends configure event to the window so that tests wouldn't need to activate the window by themselves. Basically, this is going to be needed for the CL I'm going to submit next. Bug: 1022750, 1083949 Change-Id: I4ce6f7d8720266b8ee20c9d8cf6ce3c50490791e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207170Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#769991}
-
Takashi Toyoshima authored
Disable OOR-CORS by default on Android again to mitigate risks on launching the feature on WebView M83. Bug: 1084380 Change-Id: Idd1a1aa9ef2ce813de78fe7d6ea3d5835bf8f2e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206565 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/36aad447..416580cd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iffab7c1075eb5b6ed7d0abd795ccc4d458eca31d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208491Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769989}
-
David Tseng authored
|cell_size| was not initialized during the test which expected it to be. The parameter is optional according to idl, but in this context, it probably should be initialized. Tested locally on an msan build. Original change https://chromium-review.googlesource.com/c/chromium/src/+/2206198 TBR=dtseng@chromium.org Change-Id: Ie623a55ad298c9e6522102338fe7357dd28c521e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208024Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#769988}
-
Xianzhu Wang authored
This avoids composited layer of the relative position element in the following example when the scroller is composited: <div style="width: 100px; height: 100px; overflow: scroll"> <div style="position: relative">layer in non-stacking-context scroller</div> ... </div> Stacked elements contained by a non-stacking-context composited scroller can be squashed into the scrolling contents layer if there are no other non-squashable layers interlacing between the scrolling contents layer and the candidate layer. This avoids unnecessary composited layers under composited scroller. Also avoids composited scrolling of non-stacking-context causing losing of LCD-text of layers like the relative position element above. The next step will remove MainThreadScrollingReason::kIsNotStackingContextAndLCDText, so that the situation won't block composited scrolling when LCD text is preferred. Bug: 1080056 Change-Id: Id1faafa567b67aae1d6d07dc93091b4d18620a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194791 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#769987}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4e79dd6ea5f3..9d8c46579122 git log 4e79dd6ea5f3..9d8c46579122 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@9d8c46579122 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie220a9b06666dfde49ef654b12a8da9f1bcb99a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208460Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4d12fe258b55..41d405e9fe05 git log 4d12fe258b55..41d405e9fe05 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 chonggu@google.com [Fuchsia] Add flag support for web-engine-shell on Fuchsia Created with: gclient setdep -r src/third_party/catapult@41d405e9fe05 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1075696 Tbr: oysteine@google.com Change-Id: I7b9eef9125a9a7b2f3ec3c5fbd10d0ef13f67bfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208458Reviewed-by:
-
Xianzhu Wang authored
We no longer need scrolling_layer_ after BGPT launched. For squashing_containment_layer_, we can remove it by ensuring squashing_layer_ is always the last child of graphics_layer_. There is still one dummy layer: overflow_controls_host_layer_ which is needed for convenience of reparenting overflow control layers. Change-Id: Ibdafef32d918e66a12c35d2a5726c50ea374f7a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205518 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#769984}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1b10c593. With Chromium commits locally applied on WPT: f6984fd9 "De-flaky pointerlock/pointerevent_pointermove_in_pointerlock.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ie7af8d42cc61bb20bf136e4be9ce766a578a9959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208490Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769983}
-
Keishi Hattori authored
Removes pre finalizer from HeapMojoRemote. HeapMojoUniqueReceiverSet, and HeapMojoAssociatedRemote. It turns out they weren't necessary as we do not store raw pointers to GCed objects inside mojo::Remote, UniqueReceiverSet, or AssociatedRemote. Change-Id: Ie44a9ef1ab9398e58dd972993663470ac0581881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206059Reviewed-by:
-
Willie Koomson authored
This changes removes cmtm@ from ArcProcessService OWNERS, since he no longers works on ARC, and adds wvk@ as a new owner. BUG=b:156981234 TEST=none Change-Id: I1082825aa594ef2a30a316d731d2b9b7fb43d2f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208260 Auto-Submit: Willie Koomson <wvk@google.com> Reviewed-by:
Chris Morin <cmtm@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#769981}
-
Charlene Yan authored
for the collapsed TabWidthConstraint. When the tab group collapses, the available tabstrip width is not updated to reflect the collapsed group. Also easier and less code >_> Bug: 1018230 Change-Id: If3e0907ce3b881e736c748a6db7b040e66a5c172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207617 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#769980}
-
Carlos IL authored
A bug was fixed in page info that invalidates the previous test goldens (in crrev.com/c/2199989), this increments the RenderTestRule revision in affected VR tests. Bug: 1083342 Change-Id: I22075e6373514a493cadbe43eb10d1b7d06ef403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207932Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#769979}
-
Rachel Carpenter authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/cnqGc0zHoLZzSKNvwi5e6XGyrYFhP1ILa3OsLp_g0PMC Release notes: http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202005180800_RC00.html Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: Ibe09e7cdd19c34bb211a41a450c7b70349b6c279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208150Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#769978}
-
George Burgess IV authored
Running this callback twice seems unintended, given that we `std::move` it at each call. Bug: None Change-Id: I0e9a19fd0caf255bcd817fffa6cf95b621fb6eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203477Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#769977}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8a90905cc0c8..7a960b632510 git log 8a90905cc0c8..7a960b632510 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src aaba2f0ac575..3e390a159761 (1 commits) Created with: gclient setdep -r src/third_party/angle@7a960b632510 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: I75f6242e4ea70edb7262d963e22663ef793b4f42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208207Reviewed-by:
-
Tom Anderson authored
This CL removes XAtom from x11_types.h and replaces all usages with x11::Atom. This means that ui/gfx/x/connection.h needs to be included everywhere x11_types.h was included, so it's just included from x11_types.h directly. This causes a problem: xproto_undef.h undefines a bunch of Xlib macros like CopyFromParent, so these usages are replaced with "0 /* CopyFromParent */" until further refactoring. There are a couple of cases where macros are not undefined (eg. Bool), so direct inclusions of ui/gfx/x/x11.h are added to fix these. Unfortunately, this CL introduces a lot of ugly static_cast's to convert from x11::Atom to uint32_t for Xlib APIs, which will be removed as usage of these Xlib APIs are removed. I also fixed any clang-tidy warnings that showed up in my editor along the way. BUG=1066670 R=sky Change-Id: Ifdc3c1a137a39cbbb37407e4299026c70da5281c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202789 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#769975}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: I0dbc1032169d826868ea0969c61563dcf814bba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208269Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769974}
-
Asami Doi authored
This CL makes offline capability check for navigation preload return a network error. |preload_handler_| is set up with dummy URLLoader and URLLoaderClient and it always calls OnComplete() with a network error. There are 2 new browser tests to make sure if offline capability is supported. Bug: 1031950 Change-Id: I6e74c02707305e4c654d1077c7cdd28d30aa4939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186871Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#769973}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/21bceb888974..9f35145a1ed0 git log 21bceb888974..9f35145a1ed0 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 thestig@chromium.org Replace remaining FX_ArraySize() usage with pdfium::size(). 2020-05-18 tsepez@chromium.org Remove pdfium::MakeUnique() 2020-05-18 tsepez@chromium.org Remove stray includes of ptr_util.h 2020-05-18 tsepez@chromium.org Convert remaining pdfium::MakeUnique<> to std::make_unique<> in xfa 2020-05-18 thestig@chromium.org Update third_party/base/optional.h. 2020-05-18 tsepez@chromium.org Convert pdfium::MakeUnique<> to std::make_unique<> in fxfa 2020-05-18 tsepez@chromium.org Convert pdfium::MakeUnique<> to std::make_unique<> in testing 2020-05-18 tsepez@chromium.org Convert pdfium::MakeUnique<> to std::MakeUnique<> in fpdfdoc. 2020-05-18 thestig@chromium.org Replace FX_ArraySize() with pdfium::size() in fpdfapi. 2020-05-18 tsepez@chromium.org Convert pdfium::MakeUnique<> to std::make_unique<> in fxge 2020-05-18 tsepez@chromium.org Convert pdfium::MakeUnique<> to std::make_unique<> in fxcrt 2020-05-18 tsepez@chromium.org Convert pdfium::MakeUnique<> to std::make_unique<> in fxcodec 2020-05-18 tsepez@chromium.org Convert pdfium::MakeUnique<> to std::make_unique<> in fpdfapi 2020-05-18 tsepez@chromium.org Convert pdfium::MakeUnique<> to std::make_unique<> in fxbarcode 2020-05-18 thestig@chromium.org Replace FX_ArraySize() with pdfium::size() outside of core/. Created with: gclient setdep -r src/third_party/pdfium@9f35145a1ed0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1435 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I259eca44111c5692312159c9e00138806315fdc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208208Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/98bc22c68981..7a4ea2baf5df git log 98bc22c68981..7a4ea2baf5df --date=short --first-parent --format='%ad %ae %s' 2020-05-19 reed@google.com Revert "Cache hb_face." Created with: gclient setdep -r src/third_party/skia@7a4ea2baf5df If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I2e0cdb9337eb915ac3c52dea058b2352366ec704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208455Reviewed-by:
-
Joe Downing authored
I originally fixed these as part of a different CL but that change turned out to be unnecessary due to my change last week to cleanly close the PeerConnection. So here is a super-minor clean-up CL that fixes some comments. Change-Id: I588239e74f341d87a2468d7d47eccb00161fb5b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208091 Commit-Queue: Joe Downing <joedow@chromium.org> Auto-Submit: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#769970}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/ca609c305ed1..763905cc6884 git log ca609c305ed1..763905cc6884 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 rwkeane@google.com Code Coverage: Add missing buildbot config Created with: gclient setdep -r src/third_party/openscreen/src@763905cc6884 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I36ed0d1538c473889fb42ac54e3a943ddebe50a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208452Reviewed-by:
-
