- 12 Sep, 2017 34 commits
-
-
Sergey Ulanov authored
Previously Recv() wasn't handling truncated packets consistently on all platforms. It was returning ERR_MSG_TOO_BIG on Windows, while silently truncating message on POSIX. This change updates POSIX version so that it behaves the same as the Windows implementation. Now recvmsg() is used instead of recvfrom(), which allows to get MSG_TRUNC flag back from the OS. Change-Id: Ie97fbec02dba721358f3595b33a265096a1b4289 Reviewed-on: https://chromium-review.googlesource.com/657780Reviewed-by:
Jana Iyengar <jri@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#501137}
-
Patti authored
Before r490727, Site Settings / Content Settings always interpreted URLs to be either an extension (in which the extension name would be retrieved) or a ContentSettingsPattern. r490727 introduced a third option which was to display the URL as the origin it belongs to (including stripping any default port numbers) by checking whether the pattern was a valid origin. However, this introduced a bug where 'https://*' would be intrepreted as a valid origin and be displayed as 'https://%2A' in cases where it should have stayed a ContentSettingsPattern. Fix this by re-separating the codepaths for getting a pattern display name and getting an origin display name. Manual test - Navigate to chrome://settings/content/flash/ and add a new 'Block' exception for 'http://*'. This should show up as typed and not get converted to 'http://%2A'. Bug: 656758, 762754 Change-Id: Ifa6c5f94e4485c7e78f1262a357b219e3cb86c19 Reviewed-on: https://chromium-review.googlesource.com/612025 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#501136}
-
Alice Boxhall authored
[Devtools] Maintain selection when selecting accessibility tree nodes which aren't represented in Elements tree Bug: 560525 Change-Id: I77f911996bbb4cad6ed7967b7e63d2286e39592f Reviewed-on: https://chromium-review.googlesource.com/644646Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#501135}
-
Ben Wells authored
This reverts commit 54a27d88. Reason for revert: Caused compile failure. Original change's description: > Switch RPM packager to use new dependency system > > BUG=758654 > R=thestig@chromium.org > > Change-Id: Ib64eb4ace73d7803b083f4d40795193dedc288f7 > Reviewed-on: https://chromium-review.googlesource.com/655943 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#501104} TBR=thestig@chromium.org,thomasanderson@chromium.org Change-Id: I3d625e3098e7b60ca173b51c8616c8d34c58a5a1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 758654 Reviewed-on: https://chromium-review.googlesource.com/662477Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#501134}
-
Ben Wells authored
This reverts commit aa28a986. Reason for revert: Has caused stack-use-after-scope errors on ASAn bot. First build failure: https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/23580 Sample output: [ RUN ] GLRendererTest.OverlaySyncTokensAreProcessed ================================================================= ==9679==ERROR: AddressSanitizer: stack-use-after-scope on address 0x7f2ca060c548 at pc 0x000000736f66 bp 0x7ffffdbd9de0 sp 0x7ffffdbd9dd8 READ of size 8 at 0x7f2ca060c548 thread T0 #0 0x736f65 in end buildtools/third_party/libc++/trunk/include/vector:1481:30 #1 0x736f65 in viz::(anonymous namespace)::CollectResources(std::__1::vector<viz::ReturnedResource, std::__1::allocator<viz::ReturnedResource> >*, std::__1::vector<viz::ReturnedResource, std::__1::allocator<viz::ReturnedResource> > const&, cc::BlockingTaskRunner*) components/viz/service/display/gl_renderer_unittest.cc:1925 #2 0x3680f76 in Run base/callback.h:92:12 #3 0x3680f76 in cc::DisplayResourceProvider::DeleteAndReturnUnusedResourcesToChild(std::__1::__hash_map_iterator<std::__1::__hash_iterator<std::__1::__hash_node<std::__1::__hash_value_type<int, cc::DisplayResourceProvider::Child>, void*>*> >, cc::ResourceProvider::DeleteStyle, std::__1::vector<unsigned int, std::__1::allocator<unsigned int> > const&) cc/resources/display_resource_provider.cc:255 #4 0x367dfbf in cc::DisplayResourceProvider::DestroyChildInternal(std::__1::__hash_map_iterator<std::__1::__hash_iterator<std::__1::__hash_node<std::__1::__hash_value_type<int, cc::DisplayResourceProvider::Child>, void*>*> >, cc::ResourceProvider::DeleteStyle) cc/resources/display_resource_provider.cc:145:3 #5 0x367d6d0 in cc::DisplayResourceProvider::~DisplayResourceProvider() cc/resources/display_resource_provider.cc:35:5 #6 0x367e10d in cc::DisplayResourceProvider::~DisplayResourceProvider() cc/resources/display_resource_provider.cc:33:53 #7 0x74ad4e in operator() buildtools/third_party/libc++/trunk/include/memory:2272:5 #8 0x74ad4e in reset buildtools/third_party/libc++/trunk/include/memory:2585 #9 0x74ad4e in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2539 #10 0x74ad4e in viz::(anonymous namespace)::GLRendererTest_OverlaySyncTokensAreProcessed_Test::TestBody() components/viz/service/display/gl_renderer_unittest.cc:2211 .... Original change's description: > viz: Move CreateResourceFromTextureMailbox from Display to LayerTree in GLRendererTest > > As a step of moving SingleReleaseCallbackImpl/CreateResourceFromTextureMailbox > into LayerTreeREsourceProvider, move the call of > DisplayResourceProvider::CreateResourceFromTextureMailbox > into LayerTreeResourceProvider::CreateResourceFromTextureMailbox. > > The usage of CreateResourceFromTextureMailbox is listed here: > https://docs.google.com/spreadsheets/d/1lnyONBganHkiQKw8J-3e3xC7STZkYvSh7dkzxSUFmPw/edit > > BUG=757291 > > Change-Id: I41e5d44c5f2ac03b3a5b3da1951a5ca09b3b4529 > Reviewed-on: https://chromium-review.googlesource.com/654444 > Commit-Queue: Xing Xu <xing.xu@intel.com> > Reviewed-by: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#500974} TBR=danakj@chromium.org,sunnyps@chromium.org,xing.xu@intel.com Change-Id: I4429d959bea725598662c5bee5c7f1c70acba22f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 757291 Reviewed-on: https://chromium-review.googlesource.com/662470Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#501133}
-
Jeremy Roman authored
It's not clear that much is gained by passing by value here (the inner functions use const references), and in any event, single-argument constructors should be explicit unless it's intended that they be used for implicit conversion. Change-Id: I0e4d0824dadfd8ef4de1ea513bf48059612ac53a Reviewed-on: https://chromium-review.googlesource.com/655858Reviewed-by:
meade_UTC10 <meade@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501132}
-
Xi Cheng authored
Currently, TopSites maintains a list of 20 top sites excluding the blacklist. Whenever there is a change in these 20 sites, TopSites updates its related database on disk via a task called TopSitesBackend::UpdateTopSitesOnDBThread. The task takes more than 900 ms on average and has a very high jank rate. These evidences show that it's the most expensive operation on the DB thread. In addition to updating DB, TopSites also notifies its observers about the change so that work is triggered in observer classes. However, only the top 8 sites are used by the observers of TopSites. In more details, apart from JumpList which uses the top 5 sites, all its observers use only the top 8 sites. These observers include InstantService, MostVistedSites, SpotlightTopSitesBridge and GlobalMenuBarX11. These facts indicate TopSites is maintaining more sites than needed. This CL changes TopSites to maintain only 10 top sites to trim out that waste. We prefer 10 over 8 because in that way, there is a bit of a buffer if the user blacklists a url and won't end up with an empty thumbnail. Bug: 763103, 763519 Change-Id: Ia0355cff95c8df23335c564a492a62e0011bc6f8 Reviewed-on: https://chromium-review.googlesource.com/656399 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#501131}
-
Ben Wells authored
TBR=brucedawson@chromium.org NOTRY=true Bug: 763197 Change-Id: Ie99b0e5e2839212cdbe6d01986aa99f31911d64e Reviewed-on: https://chromium-review.googlesource.com/662257Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#501130}
-
Justin DeWitt authored
This reverts commit e33804da. Reason for revert: crbug.com/763789 Canary crash, due to API requiring version 21. Original change's description: > Check for power saver mode. > > We should turn off prefetching if the user has power saver mode on. > > Bug: 701939 > Change-Id: Idc5ba38650ec0b4e7748b31b50c34955e29cc4b3 > Reviewed-on: https://chromium-review.googlesource.com/642091 > Commit-Queue: Peter Williamson <petewil@chromium.org> > Reviewed-by: Justin DeWitt <dewittj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#500780} TBR=petewil@chromium.org,dewittj@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 701939 Change-Id: Ic2ce555d0dbb94a4dc610e0167b1c1b168353c89 Reviewed-on: https://chromium-review.googlesource.com/661817Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#501129}
-
Hiroki Nakagawa authored
Some tests have friendliness ("friend class") with ServiceWorkerStorage just to access a private functions. Generally, it's cumbersome to keep the list of "friend class" up-to-date because an unused "friend class" is just ignored by the compiler. For code cleanup, this CL reduces the number of "friend class" by introducing a test-only public function ("LazyInitializeForTest()"). Bug: n/a Change-Id: I6d8c840089574ca840cd4f279e6c08f2109fd802 Reviewed-on: https://chromium-review.googlesource.com/658161Reviewed-by:Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#501128}
-
Xing Liu authored
ParallelDownloadResumption is flaky previously, the cause is an edge case bug in download resumption with a prallel download, that first hole can be filled before creating parallel requests. The impact of this bug is very small. Repro rate in browser test is only 1-2%, and resumption only happens for 4.9% for all downloads. Bug: 762763 Change-Id: I00efbc14ec40f484f3ef111f8237894c4009ba6d Reviewed-on: https://chromium-review.googlesource.com/653314Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#501127}
-
Evan Stade authored
Also remove platform ifdefs from DownloadItemNotification since it's only used on chromeos. Bug: Change-Id: I5aade81c13c96a6da22367c22ad1bad9a6b58286 Reviewed-on: https://chromium-review.googlesource.com/656506Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#501126}
-
Justin Carlson authored
Bug: 760665 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5a3e28e9a140497e536a006b91b101c54125cce1 Reviewed-on: https://chromium-review.googlesource.com/644510 Commit-Queue: Justin Carlson <justincarlson@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#501125}
-
Peng Huang authored
This change also adds the flag --disable-vsync-for-tests to disable vsync for test, so the tests will not wait for vsync signal and run as fast as possible. Bug: None Change-Id: I599566dac7381be753ca5dc285caf39cf17cc117 Reviewed-on: https://chromium-review.googlesource.com/661322Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#501124}
-
Scott Graham authored
Does a grabbag of things to get swarming tests working on trybots: - Include support .py (runner script, testserver, sdk for bootfs) in data for runner so they're available on the bot - Include filter files for now while the test binaries need test filters - Use netcp to copy json results summary - Make MB run the right command (i.e. out/Release/bin/run_blah) rather than trying to run a binary directly on the host - Now that we can know when the process is done, shutdown of the target happens without a 3s delay. This doesn't yet actually flip the bools of can_use_on_swarming_builders: true for any binaries, as we need the TUN/TAP device available on swarming bots, so that will happen in follow ups. This builds on testing and ssh setup work that jbudorick did in https://chromium-review.googlesource.com/c/chromium/src/+/581429. Bug: 761182, 734230,763992 Change-Id: I9d2caf35658b7c8fae8c13e841cd464b225654e8 Reviewed-on: https://chromium-review.googlesource.com/645774 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#501123}
-
Leo Zhang authored
Approval by https://bugs.chromium.org/p/chromium/issues/detail?id=720184#c19 Bug: 703887 Change-Id: I1fc6bbef1b966e26e666fdb5d51a1ee38751b6f9 Reviewed-on: https://chromium-review.googlesource.com/658577Reviewed-by:
Rachel Blum <groby@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#501122}
-
Chris Mumford authored
This change adds random padding to opaque resources stored in CacheStorage. The intent of this change is to obscure the size of these resources to avoid "leaking" their actual size. BUG=617963 Change-Id: I2ad94d799a456bf646a18e54a0a9d7151cf2821e Reviewed-on: https://chromium-review.googlesource.com/638793 Commit-Queue: Chris Mumford <cmumford@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#501121}
-
Karan Bhatia authored
This CL builds on r499857 and adds supports for indexing and persisting the manifest declarative rules on each load of unpacked extensions. Doc=http://go/declarative-net-request (Internal only) BUG=696822 Change-Id: I58afc054915b1cbbb97420edca5149a343a40fce Reviewed-on: https://chromium-review.googlesource.com/625482 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#501120}
-
Steve Kobes authored
With rwt.flag present, this method was adding flags to the array inside the optparse.Values object, so the command line grew extra copies of those flags with repeated calls, until system limits were reached. Bug: 755401 Change-Id: I49ae17d352f6a2a4f4c048e5ef0b488d955a6c64 Reviewed-on: https://chromium-review.googlesource.com/661739Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#501119}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/476d7916..3233811b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I2c931fad1720df080b32704f9225b4dd6baf6554 Reviewed-on: https://chromium-review.googlesource.com/661540Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#501118}
-
Will Chen authored
I forgot these when moving all the tests from LayoutTests/inspector/* to http/tests/devtools. Bug: 667560 Change-Id: I0f6d5cdd6ca89f69f2d4920fbe0c102574dc2d79 Reviewed-on: https://chromium-review.googlesource.com/661557Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#501117}
-
John Budorick authored
Bug: 764076 Change-Id: I759bc1950ff1022535364d605dbe69300d653365 No-Equivalent-Builders: true Reviewed-on: https://chromium-review.googlesource.com/661478 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#501116}
-
Thanh Pham authored
inspecting itself. The hierarchical listing of window/widget/view elements belonging to the browser instance will initially be shown. When attempting to inspect some of these elements, the majority of the node tree will disappear, event though the browser UI itself will remain unchanged. The bug is caused by UI Element reorder calls when a mouse click event happens. Bug: 750206 Change-Id: If8b001575b82bf92a787fdb4676aeebf6b390f2b Reviewed-on: https://chromium-review.googlesource.com/636400 Commit-Queue: Thanh Pham <thanhph@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#501115}
-
Chris Mumford authored
Maximum number of open files on Windows is only limited by available RAM. Making GetMaxFds return max size_t. Having this simplifies call sites allowing for platform agnostic code. Bug: None Change-Id: I78f01a9c0d2e49952148ee9febfdba49d8eaad9c Reviewed-on: https://chromium-review.googlesource.com/656108Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#501114}
-
Lucas Garron authored
TBR=palmer@chromium.org Bug: Change-Id: I0f0ec82c4662bdedadbed146dca58c03408a0d51 Reviewed-on: https://chromium-review.googlesource.com/661796Reviewed-by:
Lucas Garron <lgarron@chromium.org> Commit-Queue: Lucas Garron <lgarron@chromium.org> Cr-Commit-Position: refs/heads/master@{#501113}
-
Will Chen authored
Bug: 667560 Change-Id: Idda9841682e53af0f046a8b2f6dee98563fe4ee3 Reviewed-on: https://chromium-review.googlesource.com/661217 Commit-Queue: Will Chen <chenwilliam@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501112}
-
Tom Anderson authored
r499086 switched the Linux packaging staging dirs from /tmp to the out directory. This means it's no longer necessary to serialize package builds. The original CL passed argv[2:] to bash instead of argv[1:]. BUG=758654 R=thestig@chromium.org TBR=rdevlin.cronin@chromium.org Change-Id: If6dc9c35edeb60337b944a2a4350875274241747 Reviewed-on: https://chromium-review.googlesource.com/661780Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#501111}
-
Hans Wennborg authored
TBR=thakis Bug: 759794 Change-Id: Ic8561d64ac79d3db342537d182bb8faa95f74b5b Reviewed-on: https://chromium-review.googlesource.com/661948Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#501110}
-
Scott Chen authored
Change the positioning and overlapping of the focus and underline. Bug: 763451, 760331 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib91dfa1e9963e1e280e52f0627b6460516553137 Reviewed-on: https://chromium-review.googlesource.com/657276 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#501109}
-
Daichi Hirono authored
Previously Chrome sends only one URI to the client even if multiple files are being dragged. The CL lets Chrome send multiple URIs for the case. Bug: 758834 Test: Drag and drop multiple files Change-Id: I14d138c45fb06d509c628e3ad773e8848ca77891 Reviewed-on: https://chromium-review.googlesource.com/634775Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Daichi Hirono <hirono@chromium.org> Cr-Commit-Position: refs/heads/master@{#501108}
-
kristipark authored
Added valid origin check before tracking/untracking an origin. Bug: 760353 Change-Id: I1de5cf59b274838f0632b8d8141772d4929cc794 Reviewed-on: https://chromium-review.googlesource.com/648472 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#501107}
-
John Chen authored
ChromeDriver shouldn't use --load-extension switch to load any extensions when this switch has been excluded through Chrome options. Bug: chromedriver:1981 Change-Id: Ibf73fe15fa00eb7e83c8db4185471ec08b3679b8 Reviewed-on: https://chromium-review.googlesource.com/655337 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Shuotao Gao <stgao@chromium.org> Cr-Commit-Position: refs/heads/master@{#501106}
-
Brett Wilson authored
Replace uses of std::deque with base::circular_deque, and std::queue with base::queue. Uses in shared QUIC code are unchanged. We are standardizing on the base implementations to avoid the memory issues and widely varied implementations of the STL deque. Once most uses have been replaced, we will add a presubmit check to disallow the std:: variants. Three instances of deque were left where circular_deque is not appropriate (they required pointer stability across resizes). An implementation of EstimateMemoryUsage is provided for circular_deque which net required. BufferedSlice (quic_stream_send_buffer.h) was converted to be move-only (from being neither movable nor copyable) to support its membership in a circular_deque. When a typedef needed required changing, the typedef (and any adjacent one) was converted to "using" statements. The WebSocketChannel::PendingReceivedFrame declaration was moved to the .cc file since the limitations around its declaration in the header no longer exist (as explained in the removed comment). One include had to be added to a file in Chrome that was depending on net to being in <deque>. Bug: 757232 Change-Id: I8c265044ec2815deae457b299f30bf08938d0b87 Reviewed-on: https://chromium-review.googlesource.com/659317 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501105}
-
Tom Anderson authored
BUG=758654 R=thestig@chromium.org Change-Id: Ib64eb4ace73d7803b083f4d40795193dedc288f7 Reviewed-on: https://chromium-review.googlesource.com/655943 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#501104}
-
- 11 Sep, 2017 6 commits
-
-
Bret Sepulveda authored
I didn't realize the border set in FirstRunBubble was "extra" padding, not the total padding, so I've reverted the change and moved the calls around so the intent is clearer. Bug: 763826 Change-Id: Ieb0ab3d93bfb62f3738e970b9fac2c2a3e129332 Reviewed-on: https://chromium-review.googlesource.com/660684Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#501103}
-
Scott Chen authored
It now also tests whether a valid icon is applied to paper-icon-button-light. Bug: 754446 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6e9cc88c7b20c9a3795f69fc73a72f6c10d94751 Reviewed-on: https://chromium-review.googlesource.com/653658 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#501102}
-
Scott Graham authored
Fixed by upstream MG-1062. Bug: 759691 Change-Id: Id4155b1e4a223ead110dad3059676816280c1418 Reviewed-on: https://chromium-review.googlesource.com/661558Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#501101}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/9194706e8cf1..3261eb219f2c $ git log 9194706e8..3261eb219 --date=short --no-merges --format='%ad %ae %s' 2017-09-11 bsalomon Remove repeated conditional in TextureOp. 2017-09-11 ethannicholas Revert "Revert "Switch to the new SkSL lexer."" Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I76363bd8b8398f1cc8739a595edc615c1400f37e Reviewed-on: https://chromium-review.googlesource.com/661390Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501100}
-
Yuke Liao authored
This CL adds unit tests to test the mapping between a PBXObject and its name as a string by calling Name(). Bug: 742258 Change-Id: I8a4b55af84d1270f1c3c8927e4f124ddff0532e9 Reviewed-on: https://chromium-review.googlesource.com/636360 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#501099}
-
Matt Wolenetz authored
It looks like https://chromium-review.googlesource.com/c/chromium/src/+/481042 accidentally undid chcunningham@'s additions of all of these tests to SmokeTests. This is surprising, since running those specific tests was the primary reason for the media-gpu-accelerated virtual test suite. BUG=763528,599975,555703 Change-Id: Ia02f8c144dccd8709b6cda854089a166c667a8b9 Reviewed-on: https://chromium-review.googlesource.com/658356 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#501098}
-